Wayne Davison [Tue, 27 Jan 2004 06:51:39 +0000 (06:51 +0000)]
Percentage of file-count output was off by one.
J.W. Schultz [Tue, 27 Jan 2004 05:00:43 +0000 (05:00 +0000)]
EXCLUDE PATTERNS is not just about syntax.
Wayne Davison [Tue, 27 Jan 2004 03:49:54 +0000 (03:49 +0000)]
Mention the latest -x improvement. Also improved the description of
one of my previous fixes.
Wayne Davison [Tue, 27 Jan 2004 01:47:41 +0000 (01:47 +0000)]
Optimized the -x option by removing the skip_filesystem() call and using the
new FLAG_MOUNT_POINT flag.
Wayne Davison [Tue, 27 Jan 2004 01:47:40 +0000 (01:47 +0000)]
Added FLAG_MOUNT_POINT.
Wayne Davison [Tue, 27 Jan 2004 01:27:37 +0000 (01:27 +0000)]
Tweaked a comment.
Wayne Davison [Tue, 27 Jan 2004 01:05:14 +0000 (01:05 +0000)]
Improved the differentiation of the transmit flags from the live flags
by naming the transmit flags with an XMIT_ prefix. Improved the names
of two other flags, got rid of the LIVE_FLAGS mask, and shortened the
flag storage in the flist struct (to save memory).
Wayne Davison [Tue, 27 Jan 2004 01:05:13 +0000 (01:05 +0000)]
Use the new names for the transmit-flag defines. We also make sure
that the FLAG_TOP_DIR flag doesn't get set in the live data for a
non-directory (when it's used as a kluge to prevent a 0x00 byte being
sent over the wire for the flag data).
Wayne Davison [Tue, 27 Jan 2004 01:05:12 +0000 (01:05 +0000)]
Use the new names for the transmit-flag defines.
Wayne Davison [Mon, 26 Jan 2004 22:35:04 +0000 (22:35 +0000)]
Fixed reference to -u that should have been -o.
J.W. Schultz [Mon, 26 Jan 2004 20:54:02 +0000 (20:54 +0000)]
Back out bad refactor (thanks Wayne)
Wayne Davison [Mon, 26 Jan 2004 04:21:59 +0000 (04:21 +0000)]
Mention new hard-link optimization.
Wayne Davison [Sun, 25 Jan 2004 22:32:11 +0000 (22:32 +0000)]
Added defines (FLAG_HLINK_EOL, HL_CHECK_MASTER, and HL_SKIP) and changed
the struct hlink to have an index into the hlink_list[] array instead of
a head pointer.
Wayne Davison [Sun, 25 Jan 2004 22:32:10 +0000 (22:32 +0000)]
We now link the hard-linked flist entries into a circular list, mark
the last item with FLAG_HLINK_EOL, and save off an index for our
master entry in the hlink_list[] array. Added the hard_link_check()
function.
Wayne Davison [Sun, 25 Jan 2004 22:32:09 +0000 (22:32 +0000)]
Use the new hard_link_check() function to figure out which one of the
hard-linked files to send (when -H was specified, of course). Moved
the call to do_hard_links() and the final directory-permissions scan
into generate_files() from recv_files().
Wayne Davison [Sun, 25 Jan 2004 22:32:08 +0000 (22:32 +0000)]
Moved the call to do_hard_links() and the final directory-permissions
scan from recv_files() into generate_files().
Wayne Davison [Sun, 25 Jan 2004 22:32:07 +0000 (22:32 +0000)]
Changed F_HEAD to F_HLINDEX.
Wayne Davison [Sun, 25 Jan 2004 22:32:05 +0000 (22:32 +0000)]
Tweaked a comment.
J.W. Schultz [Sun, 25 Jan 2004 22:11:09 +0000 (22:11 +0000)]
Tightened up code in skip_filesystem()
Wayne Davison [Sat, 24 Jan 2004 22:12:58 +0000 (22:12 +0000)]
Replaced an snprintf() call with pathjoin().
Wayne Davison [Sat, 24 Jan 2004 18:36:36 +0000 (18:36 +0000)]
The static last_in value in match_gid() needed to default to -2 so
that we don't accidentally return a GID of 0 when we don't have the
permissions to set it.
Wayne Davison [Sat, 24 Jan 2004 01:48:12 +0000 (01:48 +0000)]
Another improvement in the "use chroot" section.
Wayne Davison [Fri, 23 Jan 2004 16:58:24 +0000 (16:58 +0000)]
Refer to I/O (not IO), ID (not id), and "an rsync" (not "a rsync").
Wayne Davison [Fri, 23 Jan 2004 16:55:40 +0000 (16:55 +0000)]
Improved the "use chroot" discussion on ID mapping.
Wayne Davison [Fri, 23 Jan 2004 16:40:17 +0000 (16:40 +0000)]
More changes to make the --owner and --group items clearer.
Wayne Davison [Fri, 23 Jan 2004 09:34:04 +0000 (09:34 +0000)]
Use "an" in front of rsync, not "a".
Wayne Davison [Fri, 23 Jan 2004 09:32:50 +0000 (09:32 +0000)]
Tweaked the --help text to refer to I/O (not IO) and use "an" in
front of rsync (not "a").
Wayne Davison [Fri, 23 Jan 2004 09:30:45 +0000 (09:30 +0000)]
Improved the "use chroot" section to mention how to get user/group
preservation by name (getting rid of the erroneous bit about the
--numeric-ids option being implied).
Wayne Davison [Fri, 23 Jan 2004 09:29:16 +0000 (09:29 +0000)]
Improved comments on --owner and --groups, and removed misinformation
on a chroot daemon (it does not imply --numeric-ids).
Wayne Davison [Fri, 23 Jan 2004 08:59:19 +0000 (08:59 +0000)]
Properly punctuate "etc." and changed all occurrences of "IO" to "I/O".
Wayne Davison [Fri, 23 Jan 2004 02:02:51 +0000 (02:02 +0000)]
Fixed two more misspelled words.
Wayne Davison [Fri, 23 Jan 2004 01:36:59 +0000 (01:36 +0000)]
Some spelling corrections and other simple fixes.
Wayne Davison [Thu, 22 Jan 2004 18:39:32 +0000 (18:39 +0000)]
When setting an flist entry's flags, mask it with LIVE_FLAGS.
Wayne Davison [Thu, 22 Jan 2004 18:37:26 +0000 (18:37 +0000)]
A couple comment tweaks.
Wayne Davison [Thu, 22 Jan 2004 09:16:21 +0000 (09:16 +0000)]
Made the getgroups() code a little more portable. This will hopefully
make the chgrp test work on the NetBSD and OpenBSD systems where it is
failing.
Wayne Davison [Thu, 22 Jan 2004 09:13:36 +0000 (09:13 +0000)]
Improved to add the default gid if it is missing from the list.
Wayne Davison [Thu, 22 Jan 2004 09:05:09 +0000 (09:05 +0000)]
Removed an obsolete comment.
Wayne Davison [Thu, 22 Jan 2004 04:40:33 +0000 (04:40 +0000)]
Tweaked an argv-type variable so that it's a little clearer what
the code is doing. Also added a comment.
Wayne Davison [Thu, 22 Jan 2004 04:38:18 +0000 (04:38 +0000)]
Use the new f_name_to() calling syntax.
Wayne Davison [Thu, 22 Jan 2004 04:38:17 +0000 (04:38 +0000)]
- Ensure in make_file() that we can't make a name that overflows
our buffers (note that receive_file_entry() already does this).
- Changed f_name_to() to not do any length checking since it is
now redundant.
Wayne Davison [Thu, 22 Jan 2004 02:02:00 +0000 (02:02 +0000)]
Added more missing news.
Wayne Davison [Thu, 22 Jan 2004 01:23:43 +0000 (01:23 +0000)]
New news.
Wayne Davison [Thu, 22 Jan 2004 01:20:24 +0000 (01:20 +0000)]
Size-check the --temp-dir string so we don't have to worry about it
overflowing elsewhere in the code.
Wayne Davison [Wed, 21 Jan 2004 02:45:10 +0000 (02:45 +0000)]
Improved a couple comments.
Wayne Davison [Tue, 20 Jan 2004 17:46:31 +0000 (17:46 +0000)]
Use new push_dir() syntax.
Wayne Davison [Tue, 20 Jan 2004 17:46:30 +0000 (17:46 +0000)]
- Use the new push_dir() and pop_dir() calling syntax.
- The "olddir" handling changed to accommodate the above, and to
avoid using malloc()/free().
Wayne Davison [Tue, 20 Jan 2004 17:46:29 +0000 (17:46 +0000)]
- Changed push_dir() to not take a "save" arg and to return 1 or 0
for success or failure instead of a string pointer. The function
also ensures that we don't overflow the curr_dir[] buffer.
- Changed pop_dir() to not free() anything and to return 1 or 0
for success or failure.
Wayne Davison [Tue, 20 Jan 2004 05:35:57 +0000 (05:35 +0000)]
Use new stringjoin() function.
Wayne Davison [Tue, 20 Jan 2004 05:27:09 +0000 (05:27 +0000)]
Find last '@' in the user@site string, just in case the username has
a '@' in it.
Wayne Davison [Tue, 20 Jan 2004 05:24:07 +0000 (05:24 +0000)]
Use new stringjoin() and pathjoin() functions.
Wayne Davison [Tue, 20 Jan 2004 05:15:14 +0000 (05:15 +0000)]
Use new pathjoin() function.
Wayne Davison [Tue, 20 Jan 2004 05:09:36 +0000 (05:09 +0000)]
Use new pathjoin() function.
Wayne Davison [Tue, 20 Jan 2004 04:56:20 +0000 (04:56 +0000)]
Use new stringjoin() function.
Wayne Davison [Tue, 20 Jan 2004 04:53:59 +0000 (04:53 +0000)]
Use new pathjoin() function.
Wayne Davison [Tue, 20 Jan 2004 04:43:49 +0000 (04:43 +0000)]
Added stringjoin() and pathjoin().
J.W. Schultz [Tue, 20 Jan 2004 03:37:04 +0000 (03:37 +0000)]
Eliminate unneeded strlen after strlcpy.
Wayne Davison [Tue, 20 Jan 2004 00:59:26 +0000 (00:59 +0000)]
Make sure that strlcpy() returns the right value when the bufsize is 0.
Wayne Davison [Tue, 20 Jan 2004 00:29:49 +0000 (00:29 +0000)]
Fixed a bug in strlcat() where it would not properly detect a no-change
condition if called with an initial string longer than the specified
size limit (due to an unsigned var's inability to go negative).
Wayne Davison [Mon, 19 Jan 2004 23:33:02 +0000 (23:33 +0000)]
Make sure that the batch-prefix string isn't overly long (avoiding
a potential problem in the batch-filename code).
Wayne Davison [Mon, 19 Jan 2004 23:28:57 +0000 (23:28 +0000)]
Actually, let's avoid snprintf() where possible.
Wayne Davison [Sun, 18 Jan 2004 21:22:49 +0000 (21:22 +0000)]
Use snprintf() instead of strlcpy()+strlcat().
Wayne Davison [Sat, 17 Jan 2004 19:45:26 +0000 (19:45 +0000)]
A few minor string optimizations and a new complaint if we try to
send a truncated filename.
Wayne Davison [Sat, 17 Jan 2004 05:04:04 +0000 (05:04 +0000)]
Got rid of an extra call to io_start_buffering_out().
Wayne Davison [Sat, 17 Jan 2004 04:58:24 +0000 (04:58 +0000)]
Unified the externs.
Wayne Davison [Sat, 17 Jan 2004 01:23:41 +0000 (01:23 +0000)]
A fix for --cvs-exclude.
Wayne Davison [Sat, 17 Jan 2004 01:16:49 +0000 (01:16 +0000)]
Items read from a per-directory .cvsignore file should be added to the
local_exclude_list, not the exclude_list.
Wayne Davison [Fri, 16 Jan 2004 16:31:47 +0000 (16:31 +0000)]
Output an error before we die if we get a wacko message from the receiver.
Wayne Davison [Thu, 15 Jan 2004 17:45:53 +0000 (17:45 +0000)]
Clarified the --delete-after descriptions.
Wayne Davison [Thu, 15 Jan 2004 17:43:34 +0000 (17:43 +0000)]
Clarified the --delete-after help text.
Wayne Davison [Thu, 15 Jan 2004 08:56:33 +0000 (08:56 +0000)]
If we're a daemon talking with a pre-28 protocol, use FERROR for a
vanished-file message (not FINFO).
Wayne Davison [Thu, 15 Jan 2004 08:39:25 +0000 (08:39 +0000)]
In two places: needed to use protocol_version, not PROTOCOL_VERSION.
Wayne Davison [Thu, 15 Jan 2004 08:16:40 +0000 (08:16 +0000)]
Changed version to "2.6.1cvs".
Wayne Davison [Thu, 15 Jan 2004 07:51:37 +0000 (07:51 +0000)]
Improved receiver/generator communications.
Wayne Davison [Thu, 15 Jan 2004 07:42:27 +0000 (07:42 +0000)]
- Define FULL_FLUSH and NORMAL_FLUSH.
- Got rid of FNONE from logcode enum.
- Created msgcode enum with MSG_DATA, MSG_REDO, MSG_DONE, etc.
Wayne Davison [Thu, 15 Jan 2004 07:42:25 +0000 (07:42 +0000)]
- Got rid of the f_gen pipe.
- Use new send_msg() call with MSG_DONE or MSG_REDO.
Wayne Davison [Thu, 15 Jan 2004 07:42:21 +0000 (07:42 +0000)]
- Call io_flush() with its new FULL_FLUSH/NORMAL_FLUSH arg.
- Got rid of the recv_pipe between the receiver and the generator.
- Use new send_msg(MSG_DONE,...) call to signal the generator
when the receiver is done.
- Use the new get_redo_num() call in the generator to read the
final -1 from the receiver.
Wayne Davison [Thu, 15 Jan 2004 07:42:19 +0000 (07:42 +0000)]
- Moved err_list* stuff to io.c and renamed them to msg_list*.
- Call the new send_msg() function to send a remote log message.
Wayne Davison [Thu, 15 Jan 2004 07:42:17 +0000 (07:42 +0000)]
- Moved the err_list* stuff here from log.c and renamed them msg_list*.
- Renamed log_error_fd to msg_fd_out, and io_error_fd to msg_fd_in.
- Added a redo_list* to keep track of any redo items that come over
the message channel from the receiver to the generator.
- The io_flush() and msg_list_push() functions now take an arg:
NORMAL_FLUSH or FULL_FLUSH. The latter ensures that we don't lose
any log messages that haven't gotten written from the msg_list.
- Added a send_msg() function that log.c calls to send any remote
log messages. It is also called to send the new MSG_REDO and
MSG_DONE messages.
Wayne Davison [Thu, 15 Jan 2004 07:42:15 +0000 (07:42 +0000)]
We now call get_redo_num() instead of reading f_recv (which was removed).
Wayne Davison [Thu, 15 Jan 2004 07:42:12 +0000 (07:42 +0000)]
Call io_flush() with its new FULL_FLUSH option.
Wayne Davison [Thu, 15 Jan 2004 07:08:00 +0000 (07:08 +0000)]
If the do_lchown() fails and we weren't trying to change the user,
the error now says that chgrp failed, not chown.
Wayne Davison [Thu, 15 Jan 2004 07:06:45 +0000 (07:06 +0000)]
Fixed a bug when a non-root user copies a GID=0 file with -g set
and no permissions to set group 0.
Wayne Davison [Thu, 15 Jan 2004 02:25:38 +0000 (02:25 +0000)]
The HAS_INODE_DATA flag is no longer a part of the LIVE_FLAGS define.
Wayne Davison [Tue, 13 Jan 2004 18:50:40 +0000 (18:50 +0000)]
Explain the --progress output.
Wayne Davison [Tue, 13 Jan 2004 18:25:03 +0000 (18:25 +0000)]
Give the user an idea of how far along in the transfer we are
when using --progress.
Wayne Davison [Tue, 13 Jan 2004 18:22:43 +0000 (18:22 +0000)]
Set stats.current_file_index.
Wayne Davison [Tue, 13 Jan 2004 18:22:13 +0000 (18:22 +0000)]
Added current_file_index.
Wayne Davison [Tue, 13 Jan 2004 06:27:30 +0000 (06:27 +0000)]
Merged a couple more f != -1 if sections.
Wayne Davison [Tue, 13 Jan 2004 05:13:57 +0000 (05:13 +0000)]
Moved a couple externs.
Wayne Davison [Tue, 13 Jan 2004 05:11:56 +0000 (05:11 +0000)]
Merged some "if (f != -1)" checks, put the clean_flist() call in the
right spot, and moved some externs.
Wayne Davison [Tue, 13 Jan 2004 04:50:45 +0000 (04:50 +0000)]
Relocated some externs.
Wayne Davison [Mon, 12 Jan 2004 03:59:53 +0000 (03:59 +0000)]
More hard-link stuff.
Wayne Davison [Mon, 12 Jan 2004 03:50:07 +0000 (03:50 +0000)]
Changed the hard-link check.
Wayne Davison [Mon, 12 Jan 2004 03:49:47 +0000 (03:49 +0000)]
Updated to perform a much more efficient hlink algorithm that doesn't
require any binary searching of hlink data.
Wayne Davison [Mon, 12 Jan 2004 03:48:43 +0000 (03:48 +0000)]
Added F_HEAD and F_NEXT defines.
Wayne Davison [Sun, 11 Jan 2004 22:39:34 +0000 (22:39 +0000)]
Mention more of the latest changes.
Wayne Davison [Sun, 11 Jan 2004 22:11:25 +0000 (22:11 +0000)]
More cleanup, fixing an error in the fatal-message strings that tried
to output the "filename" value when it might not be initialized.
Wayne Davison [Sun, 11 Jan 2004 08:17:19 +0000 (08:17 +0000)]
Updated a questioning comment.
Wayne Davison [Sun, 11 Jan 2004 07:56:14 +0000 (07:56 +0000)]
Use the new dev+inode union in the flist_struct.
Wayne Davison [Sun, 11 Jan 2004 07:55:53 +0000 (07:55 +0000)]
Moved the inode & dev items out of the flist_struct. Based on a
preliminary patch by J.W.