Size-check the --temp-dir string so we don't have to worry about it
authorWayne Davison <wayned@samba.org>
Thu, 22 Jan 2004 01:20:24 +0000 (01:20 +0000)
committerWayne Davison <wayned@samba.org>
Thu, 22 Jan 2004 01:20:24 +0000 (01:20 +0000)
overflowing elsewhere in the code.

options.c

index 166afdb..d719a4d 100644 (file)
--- a/options.c
+++ b/options.c
@@ -605,11 +605,16 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
        }
        if (batch_prefix && strlen(batch_prefix) > MAX_BATCH_PREFIX_LEN) {
                rprintf(FERROR,
-                       "the batch_prefix string must be %d characters or less.\n",
+                       "the batch-file prefix must be %d characters or less.\n",
                        MAX_BATCH_PREFIX_LEN);
                exit_cleanup(RERR_SYNTAX);
        }
 
+       if (tmpdir && strlen(tmpdir) >= MAXPATHLEN - 10) {
+               rprintf(FERROR, "the --temp-dir path is WAY too long.\n");
+               exit_cleanup(RERR_SYNTAX);
+       }
+
        if (do_compression && (write_batch || read_batch)) {
                rprintf(FERROR,
                        "compress can not be used with write-batch or read-batch\n");