fixed a bug in the handling of the new --relative option. The file was
authorAndrew Tridgell <tridge@samba.org>
Tue, 16 Dec 1997 20:29:35 +0000 (20:29 +0000)
committerAndrew Tridgell <tridge@samba.org>
Tue, 16 Dec 1997 20:29:35 +0000 (20:29 +0000)
being opened twice but closed once. The process eventually died with
an out of file descriptors error.

rsync.c

diff --git a/rsync.c b/rsync.c
index f961a5d..c4a92d6 100644 (file)
--- a/rsync.c
+++ b/rsync.c
@@ -656,6 +656,7 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
       /* open tmp file */
       if (strlen(fname) > (MAXPATHLEN-8)) {
        fprintf(FERROR,"filename too long\n");
+       close(fd1);
        continue;
       }
       sprintf(fnametmp,"%s.XXXXXX",fname);
@@ -667,7 +668,7 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
        continue;
       }
       fd2 = open(fnametmp,O_WRONLY|O_CREAT,file->mode);
-      if (relative_paths && errno == ENOENT && 
+      if (fd2 == -1 && relative_paths && errno == ENOENT && 
          create_directory_path(fnametmp) == 0) {
              fd2 = open(fnametmp,O_WRONLY|O_CREAT,file->mode);
       }
@@ -817,6 +818,7 @@ off_t send_files(struct file_list *flist,int f_out,int f_in)
       /* map the local file */
       if (fstat(fd,&st) != 0) {
        fprintf(FERROR,"fstat failed : %s\n",strerror(errno));
+       close(fd);
        return -1;
       }