Doc: Note from Dave Dykstra that getaddrinfo calls must be paired with
authorMartin Pool <mbp@samba.org>
Sat, 16 Mar 2002 08:23:08 +0000 (08:23 +0000)
committerMartin Pool <mbp@samba.org>
Sat, 16 Mar 2002 08:23:08 +0000 (08:23 +0000)
freeaddrinfo().

socket.c

index ccc79cf..acf6234 100644 (file)
--- a/socket.c
+++ b/socket.c
@@ -119,6 +119,8 @@ int try_bind_local(int s,
                return -1;
        }
 
                return -1;
        }
 
+       /* FIXME: Call freeaddrinfo() on all return paths! */
+
        for (r = bres_all; r; r = r->ai_next) {
                if (bind(s, r->ai_addr, r->ai_addrlen) == -1)
                        continue;
        for (r = bres_all; r; r = r->ai_next) {
                if (bind(s, r->ai_addr, r->ai_addrlen) == -1)
                        continue;
@@ -329,7 +331,8 @@ static int open_socket_in(int type, int port, const char *bind_address,
                        close(s);
                        continue;
                }
                        close(s);
                        continue;
                }
-               
+
+               /* FIXME: Call freeaddrinfo? */
                return s;
        }
 
                return s;
        }