Matt McCutchen's Web Site
/
rsync
/
rsync.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
a261103
)
Fixed an off-by-one error in the prefix-length checking in
author
Wayne Davison
<wayned@samba.org>
Sat, 5 Feb 2005 06:53:20 +0000
(06:53 +0000)
committer
Wayne Davison
<wayned@samba.org>
Sat, 5 Feb 2005 06:53:20 +0000
(06:53 +0000)
get_rule_prefix().
exclude.c
patch
|
blob
|
blame
|
history
diff --git
a/exclude.c
b/exclude.c
index
a60f5f8
..
d25b1b1
100644
(file)
--- a/
exclude.c
+++ b/
exclude.c
@@
-973,15
+973,13
@@
char *get_rule_prefix(int match_flags, const char *pat, int for_xfer,
}
if (match_flags & MATCHFLG_EXCLUDE_SELF)
*op++ = 'e';
}
if (match_flags & MATCHFLG_EXCLUDE_SELF)
*op++ = 'e';
- if (op - buf > legal_len)
- return NULL;
if (legal_len)
*op++ = ' ';
if (legal_len)
*op++ = ' ';
+ if (op - buf > legal_len)
+ return NULL;
*op = '\0';
if (plen_ptr)
*plen_ptr = op - buf;
*op = '\0';
if (plen_ptr)
*plen_ptr = op - buf;
- if (op - buf > MAX_RULE_PREFIX)
- overflow("get_rule_prefix");
return buf;
}
return buf;
}
@@
-1022,7
+1020,9
@@
static void send_rules(int f_out, struct filter_list_struct *flp)
/* This is only called by the client. */
void send_filter_list(int f_out)
{
/* This is only called by the client. */
void send_filter_list(int f_out)
{
- if (local_server || (am_sender && (!delete_mode || delete_excluded)))
+ int receiver_wants_list = delete_mode && !delete_excluded;
+
+ if (local_server || (am_sender && !receiver_wants_list))
f_out = -1;
if (cvs_exclude && am_sender) {
if (protocol_version >= 29)
f_out = -1;
if (cvs_exclude && am_sender) {
if (protocol_version >= 29)
@@
-1054,8
+1054,9
@@
void recv_filter_list(int f_in)
char line[MAXPATHLEN+MAX_RULE_PREFIX+1]; /* +1 for trailing slash. */
int xflags = protocol_version >= 29 ? 0 : XFLG_OLD_PREFIXES;
unsigned int len;
char line[MAXPATHLEN+MAX_RULE_PREFIX+1]; /* +1 for trailing slash. */
int xflags = protocol_version >= 29 ? 0 : XFLG_OLD_PREFIXES;
unsigned int len;
+ int receiver_wants_list = delete_mode && !delete_excluded;
- if (!local_server && (am_sender ||
(delete_mode && !delete_excluded)
)) {
+ if (!local_server && (am_sender ||
receiver_wants_list
)) {
while ((len = read_int(f_in)) != 0) {
if (len >= sizeof line)
overflow("recv_rules");
while ((len = read_int(f_in)) != 0) {
if (len >= sizeof line)
overflow("recv_rules");