Add comment about handling of 'use chroot'
authorMartin Pool <mbp@samba.org>
Fri, 31 Aug 2001 08:08:42 +0000 (08:08 +0000)
committerMartin Pool <mbp@samba.org>
Fri, 31 Aug 2001 08:08:42 +0000 (08:08 +0000)
clientserver.c

index 7dd72e9..0f54361 100644 (file)
@@ -244,6 +244,10 @@ static int rsync_module(int fd, int i)
        log_init();
 
        if (use_chroot) {
        log_init();
 
        if (use_chroot) {
+               /* TODO: If we're not running as root, then we'll get
+                * an error here.  I wonder if we should perhaps just
+                * log a warning here, and continue anyhow using the
+                * push_dir feature? -- mbp 2001-08-31 */
                if (chroot(lp_path(i))) {
                        rsyserr(FERROR, errno, "chroot %s failed", lp_path(i));
                        io_printf(fd,"@ERROR: chroot failed\n");
                if (chroot(lp_path(i))) {
                        rsyserr(FERROR, errno, "chroot %s failed", lp_path(i));
                        io_printf(fd,"@ERROR: chroot failed\n");