if (verbose > 2) {
rprintf(FINFO, "set modtime of %s to (%ld) %s",
- fname, (long) modtime,
+ fname, (long)modtime,
asctime(localtime(&modtime)));
}
int name_to_uid(char *name, uid_t *uid)
{
struct passwd *pass;
- if (!name || !*name) return 0;
+ if (!name || !*name)
+ return 0;
pass = getpwnam(name);
if (pass) {
*uid = pass->pw_uid;
int name_to_gid(char *name, gid_t *gid)
{
struct group *grp;
- if (!name || !*name) return 0;
+ if (!name || !*name)
+ return 0;
grp = getgrnam(name);
if (grp) {
*gid = grp->gr_gid;
return 0;
}
-static void glob_expand_one(char *s, char **argv, int *argc, int maxargs)
+static void glob_expand_one(char *s, char ***argv_ptr, int *argc_ptr,
+ int *maxargs_ptr)
{
+ char **argv = *argv_ptr;
+ int argc = *argc_ptr;
+ int maxargs = *maxargs_ptr;
#if !(defined(HAVE_GLOB) && defined(HAVE_GLOB_H))
- if (maxargs <= *argc)
- return;
+ if (argc == maxargs) {
+ maxargs += MAX_ARGS;
+ if (!(argv = realloc_array(argv, char *, maxargs)))
+ out_of_memory("glob_expand_one");
+ *argv_ptr = argv;
+ *maxargs_ptr = maxargs;
+ }
if (!*s)
s = ".";
- s = argv[*argc] = strdup(s);
+ s = argv[argc++] = strdup(s);
exclude_server_path(s);
- (*argc)++;
#else
glob_t globbuf;
int i;
+ if (maxargs <= argc)
+ return;
if (!*s)
s = ".";
- s = argv[*argc] = strdup(s);
+ s = strdup(s);
if (sanitize_paths)
sanitize_path(s, NULL);
memset(&globbuf, 0, sizeof globbuf);
if (!exclude_server_path(s))
glob(s, 0, NULL, &globbuf);
- if (globbuf.gl_pathc == 0) {
- (*argc)++;
- globfree(&globbuf);
- return;
+ if (MAX((int)globbuf.gl_pathc, 1) > maxargs - argc) {
+ maxargs += globbuf.gl_pathc + MAX_ARGS;
+ if (!(argv = realloc_array(argv, char *, maxargs)))
+ out_of_memory("glob_expand_one");
+ *argv_ptr = argv;
+ *maxargs_ptr = maxargs;
}
- for (i = 0; i < maxargs - *argc && i < (int)globbuf.gl_pathc; i++) {
- if (i == 0)
- free(s);
- argv[*argc + i] = strdup(globbuf.gl_pathv[i]);
- if (!argv[*argc + i])
- out_of_memory("glob_expand");
+ if (globbuf.gl_pathc == 0)
+ argv[argc++] = s;
+ else {
+ int j = globbuf.gl_pathc;
+ free(s);
+ for (i = 0; i < j; i++) {
+ if (!(argv[argc++] = strdup(globbuf.gl_pathv[i])))
+ out_of_memory("glob_expand_one");
+ }
}
globfree(&globbuf);
- *argc += i;
#endif
+ *argc_ptr = argc;
}
/* This routine is only used in daemon mode. */
-void glob_expand(char *base1, char **argv, int *argc, int maxargs)
+void glob_expand(char *base1, char ***argv_ptr, int *argc_ptr, int *maxargs_ptr)
{
- char *s = argv[*argc];
+ char *s = (*argv_ptr)[*argc_ptr];
char *p, *q;
char *base = base1;
int base_len = strlen(base);
- if (!s || !*s) return;
+ if (!s || !*s)
+ return;
if (strncmp(s, base, base_len) == 0)
s += base_len;
- s = strdup(s);
- if (!s) out_of_memory("glob_expand");
+ if (!(s = strdup(s)))
+ out_of_memory("glob_expand");
- if (asprintf(&base," %s/", base1) <= 0) out_of_memory("glob_expand");
+ if (asprintf(&base," %s/", base1) <= 0)
+ out_of_memory("glob_expand");
base_len++;
- q = s;
- while ((p = strstr(q,base)) != NULL && *argc < maxargs) {
- /* split it at this point */
- *p = 0;
- glob_expand_one(q, argv, argc, maxargs);
- q = p + base_len;
+ for (q = s; *q; q = p + base_len) {
+ if ((p = strstr(q, base)) != NULL)
+ *p = '\0'; /* split it at this point */
+ glob_expand_one(q, argv_ptr, argc_ptr, maxargs_ptr);
+ if (!p)
+ break;
}
- if (*q && *argc < maxargs)
- glob_expand_one(q, argv, argc, maxargs);
-
free(s);
free(base);
}
void strlower(char *s)
{
while (*s) {
- if (isupper(* (unsigned char *) s))
- *s = tolower(* (unsigned char *) s);
+ if (isupper(*(unsigned char *)s))
+ *s = tolower(*(unsigned char *)s);
s++;
}
}
int l;
int modified = 1;
- if (!name) return;
+ if (!name)
+ return;
while (modified) {
modified = 0;
return 1;
}
+/**
+ * Return the filename, turning any newlines into '?'s. This ensures that
+ * outputting it on a line of its own cannot generate an empty line. This
+ * function can handle only 2 names at a time!
+ **/
+const char *safe_fname(const char *fname)
+{
+ static char fbuf1[MAXPATHLEN], fbuf2[MAXPATHLEN];
+ static char *fbuf = fbuf2;
+ char *nl = strchr(fname, '\n');
+
+ if (!nl)
+ return fname;
+
+ fbuf = fbuf == fbuf1 ? fbuf2 : fbuf1;
+ strlcpy(fbuf, fname, MAXPATHLEN);
+ nl = fbuf + (nl - (char *)fname);
+ do {
+ *nl = '?';
+ } while ((nl = strchr(nl+1, '\n')) != NULL);
+
+ return fbuf;
+}
+
/**
* Return a quoted string with the full pathname of the indicated filename.
* The string " (in MODNAME)" may also be appended. The returned pointer
* remains valid until the next time full_fname() is called.
**/
-char *full_fname(char *fn)
+char *full_fname(const char *fn)
{
static char *result = NULL;
char *m1, *m2, *m3;
if (result)
free(result);
+ fn = safe_fname(fn);
if (*fn == '/')
p1 = p2 = "";
else {
int depth = 0;
/* all absolute and null symlinks are unsafe */
- if (!dest || !*dest || *dest == '/') return 1;
+ if (!dest || !*dest || *dest == '/')
+ return 1;
/* find out what our safety margin is */
for (name = src; (slash = strchr(name, '/')) != 0; name = slash+1) {
struct timeval tval, t1, t2;
gettimeofday(&t1, NULL);
- gettimeofday(&t2, NULL);
while (tdiff < t) {
tval.tv_sec = (t-tdiff)/1000;
Matt McCutchen's Web Site / rsync / rsync.git / blobdiff