if (compare_dest != NULL) {
if (access(fname, 0) != 0) {
- slprintf(fnamecmpdest,MAXPATHLEN,"%s/%s",
+ snprintf(fnamecmpdest,MAXPATHLEN,"%s/%s",
compare_dest,fname);
fname = fnamecmpdest;
}
if (only_existing && statret == -1 && errno == ENOENT) {
/* we only want to update existing files */
- if (verbose > 1) rprintf(FINFO,"not creating %s\n",fname);
+ if (verbose > 1) rprintf(FINFO, RSYNC_NAME
+ ": not creating new file \"%s\"\n",fname);
return;
}
}
if (S_ISDIR(file->mode)) {
- if (dry_run) return;
+ /* The file to be received is a directory, so we need
+ * to prepare appropriately. If there is already a
+ * file of that name and it is *not* a directory, then
+ * we need to delete it. If it doesn't exist, then
+ * recursively create it. */
+
+ if (dry_run) return; /* XXXX -- might cause inaccuracies?? -- mbp */
if (statret == 0 && !S_ISDIR(st.st_mode)) {
if (robust_unlink(fname) != 0) {
- rprintf(FERROR,"recv_generator: unlink %s: %s\n",fname,strerror(errno));
+ rprintf(FERROR, RSYNC_NAME
+ ": recv_generator: unlink \"%s\" to make room for directory: %s\n",
+ fname,strerror(errno));
return;
}
statret = -1;
if (!(relative_paths && errno==ENOENT &&
create_directory_path(fname)==0 &&
do_mkdir(fname,file->mode)==0)) {
- rprintf(FERROR,"recv_generator: mkdir %s: %s (2)\n",
+ rprintf(FERROR, RSYNC_NAME ": recv_generator: mkdir \"%s\": %s (2)\n",
fname,strerror(errno));
}
}
- if (set_perms(fname,file,NULL,0) && verbose)
+ /* f_out is set to -1 when doing final directory
+ permission and modification time repair */
+ if (set_perms(fname,file,NULL,0) && verbose && (f_out != -1))
rprintf(FINFO,"%s/\n",fname);
return;
}
if (safe_symlinks && unsafe_symlink(file->link, fname)) {
if (verbose) {
- rprintf(FINFO,"ignoring unsafe symlink %s -> %s\n",
+ rprintf(FINFO,RSYNC_NAME ": ignoring unsafe symlink \"%s\" -> \"%s\"\n",
fname,file->link);
}
return;
l = readlink(fname,lnk,MAXPATHLEN-1);
if (l > 0) {
lnk[l] = 0;
+ /* A link already pointing to the
+ * right place -- no further action
+ * required. */
if (strcmp(lnk,file->link) == 0) {
set_perms(fname,file,&st,1);
return;
}
- }
+ }
+ /* Not a symlink, so delete whatever's
+ * already there and put a new symlink
+ * in place. */
delete_file(fname);
}
if (do_symlink(file->link,fname) != 0) {
- rprintf(FERROR,"symlink %s -> %s : %s\n",
+ rprintf(FERROR,RSYNC_NAME": symlink \"%s\" -> \"%s\": %s\n",
fname,file->link,strerror(errno));
} else {
set_perms(fname,file,NULL,0);
if (verbose) {
- rprintf(FINFO,"%s -> %s\n",
+ rprintf(FINFO,RSYNC_NAME": %s -> %s\n",
fname,file->link);
}
}
if (preserve_hard_links && check_hard_link(file)) {
if (verbose > 1)
- rprintf(FINFO,"%s is a hard link\n",f_name(file));
+ rprintf(FINFO, RSYNC_NAME
+ ": \"%s\" is a hard link\n",f_name(file));
return;
}
if (!S_ISREG(file->mode)) {
- rprintf(FINFO,"skipping non-regular file %s\n",fname);
+ rprintf(FINFO, RSYNC_NAME
+ ": skipping non-regular file \"%s\"\n",fname);
return;
}
if ((statret == -1) && (compare_dest != NULL)) {
/* try the file at compare_dest instead */
int saveerrno = errno;
- slprintf(fnamecmpbuf,MAXPATHLEN,"%s/%s",compare_dest,fname);
+ snprintf(fnamecmpbuf,MAXPATHLEN,"%s/%s",compare_dest,fname);
statret = link_stat(fnamecmpbuf,&st);
if (!S_ISREG(st.st_mode))
statret = -1;
if (!dry_run) send_sums(NULL,f_out);
} else {
if (verbose > 1)
- rprintf(FERROR,"recv_generator failed to open %s\n",fname);
+ rprintf(FERROR, RSYNC_NAME
+ ": recv_generator failed to open \"%s\": %s\n",
+ fname, strerror(errno));
}
return;
}
fd = do_open(fnamecmp, O_RDONLY, 0);
if (fd == -1) {
- rprintf(FERROR,"failed to open %s, continuing : %s\n",fnamecmp,strerror(errno));
+ rprintf(FERROR,RSYNC_NAME": failed to open \"%s\", continuing : %s\n",fnamecmp,strerror(errno));
/* pretend the file didn't exist */
write_int(f_out,i);
send_sums(NULL,f_out);
rprintf(FINFO,"generator starting pid=%d count=%d\n",
(int)getpid(),flist->count);
+ /* we expect to just sit around now, so don't exit on a
+ timeout. If we really get a timeout then the other process should
+ exit */
+ io_timeout = 0;
+
for (i = 0; i < flist->count; i++) {
struct file_struct *file = flist->files[i];
mode_t saved_mode = file->mode;
them. This is then fixed after the files are transferred */
if (!am_root && S_ISDIR(file->mode)) {
file->mode |= S_IWUSR; /* user write */
+ /* XXX: Could this be causing a problem on SCO? Perhaps their
+ * handling of permissions is strange? */
}
recv_generator(local_name?local_name:f_name(file),
write_int(f,-1);
- /* we expect to just sit around now, so don't exit on a
- timeout. If we really get a timeout then the other process should
- exit */
- io_timeout = 0;
-
if (remote_version >= 13) {
/* in newer versions of the protocol the files can cycle through
the system more than once to catch initial checksum errors */