If --remove-sent-files was specified and we successfully updated a

[rsync/rsync.git] / sender.c

diff --git a/sender.c b/sender.c
index e1bee36..470b824 100644 (file)
--- a/sender.c
+++ b/sender.c
@@ -20,21 +20,21 @@
 #include "rsync.h"
 
 extern int verbose;
-extern int log_before_transfer;
-extern int itemize_changes;
-extern int csum_length;
-extern struct stats stats;
-extern int io_error;
 extern int dry_run;
 extern int am_server;
 extern int am_daemon;
+extern int log_before_transfer;
+extern int log_format_has_i;
+extern int daemon_log_format_has_i;
+extern int csum_length;
+extern int io_error;
 extern int protocol_version;
 extern int updating_basis_file;
 extern int make_backups;
 extern int do_progress;
 extern int inplace;
-extern char *log_format;
 extern struct stats stats;
+extern char *log_format;
 
 
 /**
@@ -112,6 +112,8 @@ void send_files(struct file_list *flist, int f_out, int f_in)
        int phase = 0;
        struct stats initial_stats;
        int save_make_backups = make_backups;
+       int itemizing = am_daemon ? daemon_log_format_has_i
+                     : !am_server && log_format_has_i;
        int i, j;
 
        if (verbose > 2)
@@ -143,15 +145,28 @@ void send_files(struct file_list *flist, int f_out, int f_in)
                }
 
                file = flist->files[i];
+               if (file->dir.root) {
+                       /* N.B. We're sure that this fits, so offset is OK. */
+                       offset = strlcpy(fname, file->dir.root, sizeof fname);
+                       if (!offset || fname[offset-1] != '/')
+                               fname[offset++] = '/';
+               } else
+                       offset = 0;
+               fname2 = f_name_to(file, fname + offset);
+
+               if (verbose > 2)
+                       rprintf(FINFO, "send_files(%d, %s)\n", i, fname);
 
                if (protocol_version >= 29) {
-                       iflags = read_short(f_in);
+                       iflags = read_shortint(f_in);
                        if (!(iflags & ITEM_UPDATING) || !S_ISREG(file->mode)) {
+                               int see_item = itemizing && (iflags || verbose > 1);
+                               write_int(f_out, i);
+                               write_shortint(f_out, iflags);
                                if (am_server) {
-                                       write_int(f_out, i);
-                                       write_short(f_out, iflags);
-                               } else if (itemize_changes
-                                   || iflags & ITEM_UPDATING
+                                       if (am_daemon && !dry_run && see_item)
+                                               log_send(file, &stats, iflags);
+                               } else if (see_item || iflags & ITEM_UPDATING
                                    || (S_ISDIR(file->mode)
                                     && iflags & ITEM_REPORT_TIME))
                                        log_send(file, &stats, iflags);
@@ -176,24 +191,12 @@ void send_files(struct file_list *flist, int f_out, int f_in)
                stats.num_transferred_files++;
                stats.total_transferred_size += file->length;
 
-               if (file->dir.root) {
-                       /* N.B. We're sure that this fits, so offset is OK. */
-                       offset = strlcpy(fname, file->dir.root, sizeof fname);
-                       if (!offset || fname[offset-1] != '/')
-                               fname[offset++] = '/';
-               } else
-                       offset = 0;
-               fname2 = f_name_to(file, fname + offset);
-
-               if (verbose > 2)
-                       rprintf(FINFO, "send_files(%d, %s)\n", i, fname);
-
                if (dry_run) { /* log the transfer */
                        if (!am_server && log_format)
                                log_send(file, &stats, iflags);
                        write_int(f_out, i);
                        if (protocol_version >= 29)
-                               write_short(f_out, iflags);
+                               write_shortint(f_out, iflags);
                        continue;
                }
 
@@ -246,7 +249,7 @@ void send_files(struct file_list *flist, int f_out, int f_in)
 
                write_int(f_out, i);
                if (protocol_version >= 29)
-                       write_short(f_out, iflags);
+                       write_shortint(f_out, iflags);
                write_sum_head(f_out, s);
 
                if (verbose > 2) {