extern int verbose;
extern int dry_run;
extern int do_xfers;
-extern int log_format_has_i;
-extern int daemon_log_format_has_i;
+extern int stdout_format_has_i;
+extern int logfile_format_has_i;
extern int am_root;
extern int am_server;
extern int am_daemon;
extern int do_progress;
-extern int recurse;
extern int relative_paths;
extern int implied_dirs;
extern int keep_dirlinks;
STRUCT_STAT st;
int j;
- if (dry_run > 1 /* destination doesn't exist yet */
- || list_only)
+ /* dry_run is incremented when the destination doesn't exist yet. */
+ if (dry_run > 1 || list_only)
return;
for (j = 0; j < flist->count; j++) {
iflags &= 0xffff;
if ((iflags & SIGNIFICANT_ITEM_FLAGS || verbose > 1
- || log_format_has_i > 1 || (xname && *xname)) && !read_batch) {
+ || stdout_format_has_i > 1 || (xname && *xname)) && !read_batch) {
if (protocol_version >= 29) {
if (ndx >= 0)
write_int(sock_f_out, ndx);
write_byte(sock_f_out, fnamecmp_type);
if (iflags & ITEM_XNAME_FOLLOWS)
write_vstring(sock_f_out, xname, strlen(xname));
- } else if (ndx >= 0)
- log_item(file, &stats, iflags, xname);
+ } else if (ndx >= 0) {
+ enum logcode code = logfile_format_has_i ? FINFO : FCLIENT;
+ log_item(code, file, &stats, iflags, xname);
+ }
}
}
int maybe_ATTRS_REPORT, enum logcode code)
{
int save_ignore_times = ignore_times;
- int save_size_only = size_only;
int best_match = -1;
int match_level = 0;
int j = 0;
- /* We can't let these send-affecting options affect our checking
- * for identical files in the alternate basis dirs. */
- ignore_times = size_only = 0;
+ /* We can't let ignore_times affect the unchanged_file() test in
+ * an alternate-dest dir or we will never find any matches. */
+ ignore_times = 0;
do {
pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
case 2:
if (!unchanged_attrs(file, stp))
continue;
- if (always_checksum
+ if (always_checksum && preserve_times
&& cmp_time(stp->st_mtime, file->modtime))
continue;
best_match = j;
} while (basis_dir[++j] != NULL);
ignore_times = save_ignore_times;
- size_only = save_size_only;
if (!match_level)
return -1;
match_level = 0;
}
-#ifdef HAVE_LINK
if (match_level == 3 && !copy_dest) {
+#ifdef SUPPORT_HARD_LINKS
if (link_dest) {
if (hard_link_one(file, ndx, fname, 0, stp,
cmpbuf, 1,
goto try_a_copy;
if (preserve_hard_links && file->link_u.links)
hard_link_cluster(file, ndx, itemizing, code);
- } else if (itemizing)
+ } else
+#endif
+ if (itemizing)
itemize(file, ndx, 0, stp, 0, 0, NULL);
if (verbose > 1 && maybe_ATTRS_REPORT) {
- code = daemon_log_format_has_i || dry_run
- ? FCLIENT : FINFO;
- rprintf(code, "%s is uptodate\n", fname);
+ rprintf(FCLIENT, "%s is uptodate\n", fname);
}
return -2;
}
-#endif
if (match_level >= 2) {
try_a_copy: /* Copy the file locally. */
if (maybe_ATTRS_REPORT
&& ((!itemizing && verbose && match_level == 2)
|| (verbose > 1 && match_level == 3))) {
- code = daemon_log_format_has_i || dry_run
- ? FCLIENT : FINFO;
+ code = match_level == 3 ? FCLIENT : FINFO;
rprintf(code, "%s%s\n", fname,
match_level == 3 ? " is uptodate" : "");
}
} else {
rprintf(FERROR,
"internal: try_dests_non() called with invalid mode (%o)\n",
- file->mode);
+ (int)file->mode);
exit_cleanup(RERR_UNSUPPORTED);
}
+#ifdef SUPPORT_HARD_LINKS
if (link_dest
#ifndef CAN_HARDLINK_SYMLINK
&& !S_ISLNK(file->mode)
if (preserve_hard_links && file->link_u.links)
hard_link_cluster(file, ndx, itemizing, code);
}
- if (itemizing && log_format_has_i && verbose > 1) {
+#endif
+ if (itemizing && stdout_format_has_i && verbose > 1) {
int changes = compare_dest ? 0 : ITEM_LOCAL_CHANGE
+ (link_dest ? ITEM_XNAME_FOLLOWS : 0);
char *lp = link_dest ? "" : NULL;
itemize(file, ndx, 0, &st, changes, 0, lp);
}
if (verbose > 1 && maybe_ATTRS_REPORT) {
- code = daemon_log_format_has_i || dry_run
- ? FCLIENT : FINFO;
- rprintf(code, "%s is uptodate\n", fname);
+ rprintf(FCLIENT, "%s is uptodate\n", fname);
}
return -2;
} while (basis_dir[++i] != NULL);
fuzzy_dirlist = NULL;
}
if (missing_below >= 0) {
- dry_run--;
+ if (dry_run)
+ dry_run--;
missing_below = -1;
}
parent_dirname = "";
}
}
- if (missing_below >= 0 && file->dir.depth <= missing_below) {
- dry_run--;
- missing_below = -1;
+ if (missing_below >= 0) {
+ if (file->dir.depth <= missing_below) {
+ if (dry_run)
+ dry_run--;
+ missing_below = -1;
+ } else if (!dry_run)
+ return;
}
if (dry_run > 1) {
statret = -1;
char *dn = file->dirname ? file->dirname : ".";
if (parent_dirname != dn && strcmp(parent_dirname, dn) != 0) {
if (relative_paths && !implied_dirs
- && do_stat(dn, &st) < 0
+ && safe_stat(dn, &st) < 0
&& create_directory_path(fname) < 0) {
rsyserr(FERROR, errno,
"recv_generator: mkdir %s failed",
rsyserr(FERROR, errno,
"recv_generator: mkdir %s failed",
full_fname(fname));
+ file->flags |= FLAG_MISSING;
+ if (ndx+1 < the_file_list->count
+ && the_file_list->files[ndx+1]->dir.depth > file->dir.depth) {
+ rprintf(FERROR,
+ "*** Skipping everything below this failed directory ***\n");
+ missing_below = file->dir.depth;
+ }
+ return;
}
}
if (set_file_attrs(fname, file, statret ? NULL : &st, 0)
if (protocol_version >= 29) {
itemizing = 1;
- maybe_ATTRS_REPORT = log_format_has_i ? 0 : ATTRS_REPORT;
- code = daemon_log_format_has_i ? 0 : FLOG;
+ maybe_ATTRS_REPORT = stdout_format_has_i ? 0 : ATTRS_REPORT;
+ code = logfile_format_has_i ? 0 : FLOG;
} else if (am_daemon) {
- itemizing = daemon_log_format_has_i && do_xfers;
+ itemizing = logfile_format_has_i && do_xfers;
maybe_ATTRS_REPORT = ATTRS_REPORT;
code = itemizing || !do_xfers ? FCLIENT : FINFO;
} else if (!am_server) {
- itemizing = log_format_has_i;
- maybe_ATTRS_REPORT = log_format_has_i ? 0 : ATTRS_REPORT;
+ itemizing = stdout_format_has_i;
+ maybe_ATTRS_REPORT = stdout_format_has_i ? 0 : ATTRS_REPORT;
code = itemizing ? 0 : FINFO;
} else {
itemizing = 0;
continue;
if (!need_retouch_dir_times && file->mode & S_IWUSR)
continue;
+ if (file->flags & FLAG_MISSING) {
+ int missing = file->dir.depth;
+ while (++i < flist->count) {
+ file = flist->files[i];
+ if (file->dir.depth <= missing)
+ break;
+ }
+ i--;
+ continue;
+ }
recv_generator(f_name(file, NULL), file, i, itemizing,
maybe_ATTRS_REPORT, code, -1);
if (allowed_lull && !(++j % lull_mod))