# You cannot use "function foo {" syntax, but must instead say "foo()
# {", or it breaks on FreeBSD.
+# BSD machines tend not to have "head" or "seq".
+
+# You cannot do "export VAR=VALUE" all on one line; the export must be
+# separate from the assignment. (SCO SysV)
+
# STILL TO DO:
# Perhaps we need a common way to cleanup tests. At the moment just
# clobbering the directory when we're done should be enough.
+# If any of the targets fail, then (GNU?) Make returns 2, instead of
+# the return code from the failing command. This is fine, but it
+# means that the build farm just shows "2" for failed tests, not the
+# number of tests that actually failed. For more details we might
+# need to grovel through the log files to find a line saying how many
+# failed.
+
set -e
passed=0
failed=0
-scratchdir=./testtmp
-[ -d "$scratchdir" ] && rm -r "$scratchdir"
-mkdir "$scratchdir"
-scratchdir=`cd $scratchdir && pwd`
+scratchdir="`cd ./testtmp && pwd`"
echo " scratchdir=$scratchdir"
suitedir="$srcdir/testsuite"
export scratchdir suitedir
+clean_scratch() {
+ [ -d "$scratchdir" ] && rm -rf "$scratchdir"
+ mkdir "$scratchdir"
+}
+
if [ "x$whichtests" = x ]
then
whichtests="*.test"
testbase=`echo $testscript | sed 's!.*/!!'`
echo "----- $testbase starting"
+ clean_scratch
if sh $RUNSHFLAGS "$testscript"
then
- echo "----- $testbase completed succesfully"
+ echo "----- $testbase completed successfully"
passed=`expr $passed + 1`
else
case $? in
[ "$missing" -gt 0 ] && echo " $missing missing"
echo '------------------------------------------------------------'
-exit `expr $failed + $missing`
+# OK, so expr exits with 0 if the result is neither null nor zero; and
+# 1 if the expression is null or zero. This is the opposite of what
+# we want, and if we just call expr then this script will always fail,
+# because -e is set.
+
+result=`expr $failed + $missing || true`
+echo "overall result is $result"
+exit $result