Fix a file-globbing bug in the daemon when chroot is on.

[rsync/rsync.git] / pipe.c

diff --git a/pipe.c b/pipe.c
index 98b2c15..5f79ede 100644 (file)
--- a/pipe.c
+++ b/pipe.c
@@ -4,11 +4,12 @@
  * Copyright (C) 1996-2000 Andrew Tridgell
  * Copyright (C) 1996 Paul Mackerras
  * Copyright (C) 2001, 2002 Martin Pool <mbp@samba.org>
- * Copyright (C) 2004-2007 Wayne Davison
+ * Copyright (C) 2004-2008 Wayne Davison
  *
  * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
  *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ -16,8 +17,7 @@
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License along
- * with this program; if not, write to the Free Software Foundation, Inc.,
- * 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
+ * with this program; if not, visit the http://fsf.org website.
  */
 
 #include "rsync.h"
@@ -50,7 +50,7 @@ pid_t piped_child(char **command, int *f_in, int *f_out)
        int from_child_pipe[2];
 
        if (verbose >= 2)
-               print_child_argv(command);
+               print_child_argv("opening connection using:", command);
 
        if (fd_pair(to_child_pipe) < 0 || fd_pair(from_child_pipe) < 0) {
                rsyserr(FERROR, errno, "pipe");
@@ -133,6 +133,12 @@ pid_t local_child(int argc, char **argv, int *f_in, int *f_out,
                filesfrom_fd = -1;
                chmod_modes = NULL; /* Let the sending side handle this. */
 
+               /* Let the client side handle this. */
+               if (logfile_name) {
+                       logfile_name = NULL;
+                       logfile_close();
+               }
+
                if (dup2(to_child_pipe[0], STDIN_FILENO) < 0 ||
                    close(to_child_pipe[1]) < 0 ||
                    close(from_child_pipe[0]) < 0 ||
@@ -144,15 +150,12 @@ pid_t local_child(int argc, char **argv, int *f_in, int *f_out,
                        close(to_child_pipe[0]);
                if (from_child_pipe[1] != STDOUT_FILENO)
                        close(from_child_pipe[1]);
+#ifdef ICONV_CONST
+               setup_iconv();
+#endif
                child_main(argc, argv);
        }
 
-       /* Let the client side handle this. */
-       if (logfile_name) {
-               logfile_name = NULL;
-               logfile_close();
-       }
-
        if (close(from_child_pipe[1]) < 0 ||
            close(to_child_pipe[0]) < 0) {
                rsyserr(FERROR, errno, "Failed to close");