int io_error;
static char empty_sum[MD4_SUM_LENGTH];
+static unsigned int min_file_struct_len;
static void clean_flist(struct file_list *flist, int strip_root, int no_dups);
+void init_flist(void)
+{
+ struct file_struct f;
+
+ /* Figure out how big the file_struct is without trailing padding */
+ min_file_struct_len = ((char*)&f.flags - (char*)&f) + sizeof f.flags;
+}
+
+
static int show_filelist_p(void)
{
return verbose && (recurse || files_from) && !am_server;
if (verbose >= 2) {
rprintf(FINFO, "[%s] expand file_list to %.0f bytes, did%s move\n",
- who_am_i(),
- (double)sizeof(flist->files[0])
- * flist->malloced,
- (new_ptr == flist->files) ? " not" : "");
+ who_am_i(),
+ (double) sizeof flist->files[0] * flist->malloced,
+ (new_ptr == flist->files) ? " not" : "");
}
flist->files = (struct file_struct **) new_ptr;
char thisname[MAXPATHLEN];
unsigned int l1 = 0, l2 = 0;
int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
- int idev_len, idev_pad;
+ int file_struct_len, idev_len;
OFF_T file_length;
char *basename, *dirname, *bp;
struct file_struct *file;
idev_len = 0;
sum_len = always_checksum && S_ISREG(mode) ? MD4_SUM_LENGTH : 0;
+ file_struct_len = idev_len? sizeof file[0] : min_file_struct_len;
- alloc_len = sizeof file[0] + dirname_len + basename_len
- + linkname_len + sum_len;
- if (idev_len) {
- idev_pad = (4 - (alloc_len % 4)) % 4;
- alloc_len += idev_pad + idev_len;
- } else
- idev_pad = 0;
+ alloc_len = file_struct_len + dirname_len + basename_len
+ + linkname_len + sum_len + idev_len;
if (!(bp = new_array(char, alloc_len)))
out_of_memory("receive_file_entry");
file = *fptr = (struct file_struct *)bp;
- memset(bp, 0, sizeof file[0]);
- bp += sizeof file[0];
+ memset(bp, 0, min_file_struct_len);
+ bp += file_struct_len;
file->flags = flags & XMIT_TOP_DIR ? FLAG_TOP_DIR : 0;
file->modtime = modtime;
file->uid = uid;
file->gid = gid;
+#if SUPPORT_HARD_LINKS
+ if (idev_len) {
+ file->link_u.idev = (struct idev *)bp;
+ bp += idev_len;
+ }
+#endif
+
if (dirname_len) {
file->dirname = lastdir = bp;
lastdir_len = dirname_len - 1;
#if SUPPORT_HARD_LINKS
if (idev_len) {
- file->link_u.idev = (struct idev *)(bp + idev_pad);
- bp += idev_pad + idev_len;
if (protocol_version < 26) {
dev = read_int(f);
file->F_INODE = read_int(f);
char thisname[MAXPATHLEN];
char linkname[MAXPATHLEN];
int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
- int idev_len, idev_pad;
+ int file_struct_len, idev_len;
char *basename, *dirname, *bp;
unsigned short flags = 0;
linkname_len = 0;
#endif
+ idev_len = 0;
#if SUPPORT_HARD_LINKS
- if (preserve_hard_links) {
- idev_len = (protocol_version < 28 ? S_ISREG(st.st_mode)
- : !S_ISDIR(st.st_mode) && st.st_nlink > 1)
- ? sizeof (struct idev) : 0;
- } else
+ if (preserve_hard_links && st.st_nlink > 1) {
+ if (protocol_version < 28) {
+ if (S_ISREG(st.st_mode))
+ idev_len = sizeof (struct idev);
+ } else {
+ if (!S_ISDIR(st.st_mode))
+ idev_len = sizeof (struct idev);
+ }
+ }
#endif
- idev_len = 0;
sum_len = always_checksum && S_ISREG(st.st_mode) ? MD4_SUM_LENGTH : 0;
+ file_struct_len = idev_len? sizeof file[0] : min_file_struct_len;
- alloc_len = sizeof file[0] + dirname_len + basename_len
- + linkname_len + sum_len;
- if (idev_len) {
- idev_pad = (4 - (alloc_len % 4)) % 4;
- alloc_len += idev_pad + idev_len;
- } else
- idev_pad = 0;
+ alloc_len = file_struct_len + dirname_len + basename_len
+ + linkname_len + sum_len + idev_len;
if (!(bp = new_array(char, alloc_len)))
out_of_memory("receive_file_entry");
file = (struct file_struct *)bp;
- memset(bp, 0, sizeof file[0]);
- bp += sizeof file[0];
+ memset(bp, 0, min_file_struct_len);
+ bp += file_struct_len;
file->flags = flags;
file->modtime = st.st_mtime;
file->uid = st.st_uid;
file->gid = st.st_gid;
+#if SUPPORT_HARD_LINKS
+ if (idev_len) {
+ file->link_u.idev = (struct idev *)bp;
+ bp += idev_len;
+ file->F_DEV = st.st_dev;
+ file->F_INODE = st.st_ino;
+ }
+#endif
+
if (dirname_len) {
file->dirname = lastdir = bp;
lastdir_len = dirname_len - 1;
}
#endif
-#if SUPPORT_HARD_LINKS
- if (idev_len) {
- file->link_u.idev = (struct idev *)(bp + idev_pad);
- bp += idev_pad + idev_len;
- file->F_DEV = st.st_dev;
- file->F_INODE = st.st_ino;
- }
-#endif
-
if (sum_len) {
file->u.sum = bp;
file_checksum(thisname, bp, st.st_size);
if (free_the_struct)
free(file);
else
- memset(file, 0, sizeof file[0]);
+ memset(file, 0, min_file_struct_len);
}
return;
qsort(flist->files, flist->count,
- sizeof(flist->files[0]), (int (*)()) file_compare);
+ sizeof flist->files[0], (int (*)()) file_compare);
for (i = no_dups? 0 : flist->count; i < flist->count; i++) {
if (flist->files[i]->basename) {