Tweaked the output a little.
[rsync/rsync.git] / flist.c
diff --git a/flist.c b/flist.c
index 62731a6..11d4b04 100644 (file)
--- a/flist.c
+++ b/flist.c
@@ -22,6 +22,7 @@
  */
 
 #include "rsync.h"
+#include "rounding.h"
 
 extern int verbose;
 extern int list_only;
@@ -58,7 +59,6 @@ extern int protocol_version;
 extern int sanitize_paths;
 extern struct stats stats;
 extern struct file_list *the_file_list;
-extern alloc_pool_t hlink_pool;
 
 extern char curr_dir[MAXPATHLEN];
 
@@ -76,12 +76,12 @@ dev_t filesystem_dev; /* used to implement -x */
  * will survive just long enough to be used by send_file_entry(). */
 static dev_t tmp_rdev;
 #ifdef SUPPORT_HARD_LINKS
-static struct idev tmp_idev;
+static int64 tmp_dev, tmp_ino;
 #endif
 static char tmp_sum[MD4_SUM_LENGTH];
 
 static char empty_sum[MD4_SUM_LENGTH];
-static int flist_count_offset;
+static int flist_count_offset; /* for --delete --progress */
 
 static void clean_flist(struct file_list *flist, int strip_root, int no_dups);
 static void output_flist(struct file_list *flist);
@@ -90,7 +90,7 @@ void init_flist(void)
 {
        if (verbose > 4) {
                rprintf(FINFO, "FILE_STRUCT_LEN=%d, EXTRA_LEN=%d\n",
-                       FILE_STRUCT_LEN, EXTRA_LEN);
+                       (int)FILE_STRUCT_LEN, (int)EXTRA_LEN);
        }
        checksum_len = protocol_version < 21 ? 2 : MD4_SUM_LENGTH;
 }
@@ -310,7 +310,7 @@ void flist_expand(struct file_list *flist)
                out_of_memory("flist_expand");
 }
 
-static void send_file_entry(struct file_struct *file, int f)
+static void send_file_entry(struct file_struct *file, int f, int ndx)
 {
        unsigned short flags;
        static time_t modtime;
@@ -322,21 +322,9 @@ static void send_file_entry(struct file_struct *file, int f)
        static gid_t gid;
        static char lastname[MAXPATHLEN];
        char fname[MAXPATHLEN];
+       int first_hlink_ndx = -1;
        int l1, l2;
 
-       if (f < 0)
-               return;
-
-       if (!file) {
-               write_byte(f, 0);
-               modtime = 0, mode = 0;
-               dev = 0, rdev = MAKEDEV(0, 0);
-               rdev_major = 0;
-               uid = 0, gid = 0;
-               *lastname = '\0';
-               return;
-       }
-
        f_name(file, fname);
 
        flags = file->flags & FLAG_TOP_DIR; /* FLAG_TOP_DIR == XMIT_TOP_DIR */
@@ -381,13 +369,23 @@ static void send_file_entry(struct file_struct *file, int f)
                modtime = file->modtime;
 
 #ifdef SUPPORT_HARD_LINKS
-       if (tmp_idev.dev != 0) {
-               if (tmp_idev.dev == dev) {
-                       if (protocol_version >= 28)
-                               flags |= XMIT_SAME_DEV;
-               } else
-                       dev = tmp_idev.dev;
-               flags |= XMIT_HAS_IDEV_DATA;
+       if (tmp_dev != 0) {
+               if (protocol_version >= 30) {
+                       struct idev_node *np = idev_node(tmp_dev, tmp_ino);
+                       first_hlink_ndx = (int32)np->data - 1;
+                       if (first_hlink_ndx < 0) {
+                               np->data = (void*)(ndx + 1);
+                               flags |= XMIT_HLINK_FIRST;
+                       }
+                       flags |= XMIT_HLINKED;
+               } else {
+                       if (tmp_dev == dev) {
+                               if (protocol_version >= 28)
+                                       flags |= XMIT_SAME_DEV_pre30;
+                       } else
+                               dev = tmp_dev;
+                       flags |= XMIT_HLINKED;
+               }
        }
 #endif
 
@@ -426,6 +424,11 @@ static void send_file_entry(struct file_struct *file, int f)
                write_byte(f, l2);
        write_buf(f, fname + l1, l2);
 
+       if (first_hlink_ndx >= 0) {
+               write_int(f, first_hlink_ndx);
+               goto the_end;
+       }
+
        write_longint(f, F_LENGTH(file));
        if (!(flags & XMIT_SAME_TIME))
                write_int(f, modtime);
@@ -466,16 +469,16 @@ static void send_file_entry(struct file_struct *file, int f)
 #endif
 
 #ifdef SUPPORT_HARD_LINKS
-       if (tmp_idev.dev != 0) {
+       if (tmp_dev != 0 && protocol_version < 30) {
                if (protocol_version < 26) {
                        /* 32-bit dev_t and ino_t */
                        write_int(f, (int32)dev);
-                       write_int(f, (int32)tmp_idev.ino);
+                       write_int(f, (int32)tmp_ino);
                } else {
                        /* 64-bit dev_t and ino_t */
-                       if (!(flags & XMIT_SAME_DEV))
+                       if (!(flags & XMIT_SAME_DEV_pre30))
                                write_longint(f, dev);
-                       write_longint(f, tmp_idev.ino);
+                       write_longint(f, tmp_ino);
                }
        }
 #endif
@@ -491,6 +494,7 @@ static void send_file_entry(struct file_struct *file, int f)
                write_buf(f, sum, checksum_len);
        }
 
+  the_end:
        strlcpy(lastname, fname, MAXPATHLEN);
 }
 
@@ -511,7 +515,8 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        char thisname[MAXPATHLEN];
        unsigned int l1 = 0, l2 = 0;
        int alloc_len, basename_len, dirname_len, linkname_len;
-       int extra_len = (flist_extra_cnt - 1) * EXTRA_LEN;
+       int extra_len = flist_extra_cnt * EXTRA_LEN;
+       int first_hlink_ndx = -1;
        OFF_T file_length;
        char *basename, *dirname, *bp;
        struct file_struct *file;
@@ -568,6 +573,38 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        }
        basename_len = strlen(basename) + 1; /* count the '\0' */
 
+#ifdef SUPPORT_HARD_LINKS
+       if (protocol_version >= 30
+        && BITS_SETnUNSET(flags, XMIT_HLINKED, XMIT_HLINK_FIRST)) {
+               struct file_struct *first;
+               first_hlink_ndx = read_int(f);
+               if (first_hlink_ndx < 0 || first_hlink_ndx >= flist->count) {
+                       rprintf(FERROR,
+                               "hard-link reference out of range: %d (%d)\n",
+                               first_hlink_ndx, flist->count);
+                       exit_cleanup(RERR_PROTOCOL);
+               }
+               first = flist->files[first_hlink_ndx];
+               file_length = F_LENGTH(first);
+               modtime = first->modtime;
+               mode = first->mode;
+               if (preserve_uid)
+                       uid = F_UID(first);
+               if (preserve_gid)
+                       gid = F_GID(first);
+               if ((preserve_devices && IS_DEVICE(mode))
+                || (preserve_specials && IS_SPECIAL(mode))) {
+                       uint32 *devp = F_RDEV_P(first);
+                       rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
+               }
+               if (preserve_links && S_ISLNK(mode))
+                       linkname_len = strlen(F_SYMLINK(first)) + 1;
+               else
+                       linkname_len = 0;
+               goto create_object;
+       }
+#endif
+
        file_length = read_longint(f);
        if (!(flags & XMIT_SAME_TIME))
                modtime = (time_t)read_int(f);
@@ -616,10 +653,11 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                linkname_len = 0;
 
 #ifdef SUPPORT_HARD_LINKS
+  create_object:
        if (preserve_hard_links) {
                if (protocol_version < 28 && S_ISREG(mode))
-                       flags |= XMIT_HAS_IDEV_DATA;
-               if (flags & XMIT_HAS_IDEV_DATA)
+                       flags |= XMIT_HLINKED;
+               if (flags & XMIT_HLINKED)
                        extra_len += EXTRA_LEN;
        }
 #endif
@@ -630,11 +668,16 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        if (file_length > 0xFFFFFFFFu && S_ISREG(mode))
                extra_len += EXTRA_LEN;
 
+#if EXTRA_ROUNDING > 0
+       if (extra_len & (EXTRA_ROUNDING * EXTRA_LEN))
+               extra_len = (extra_len | (EXTRA_ROUNDING * EXTRA_LEN)) + EXTRA_LEN;
+#endif
+
        alloc_len = FILE_STRUCT_LEN + extra_len + basename_len + dirname_len
                  + linkname_len;
        bp = pool_alloc(flist->file_pool, alloc_len, "recv_file_entry");
 
-       memset(bp, 0, FILE_STRUCT_LEN + extra_len);
+       memset(bp, 0, extra_len + FILE_STRUCT_LEN);
        bp += extra_len;
        file = (struct file_struct *)bp;
        bp += FILE_STRUCT_LEN;
@@ -643,7 +686,7 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
        bp += basename_len + linkname_len; /* skip space for symlink too */
 
 #ifdef SUPPORT_HARD_LINKS
-       if (flags & XMIT_HAS_IDEV_DATA)
+       if (flags & XMIT_HLINKED)
                file->flags |= FLAG_HLINKED;
 #endif
        file->modtime = modtime;
@@ -665,19 +708,19 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                bp += dirname_len;
                bp[-1] = '\0';
                lastdir_depth = count_dir_elements(lastdir);
-               file->dir.depth = lastdir_depth + 1;
+               F_DEPTH(file) = lastdir_depth + 1;
        } else if (dirname) {
                file->dirname = dirname; /* we're reusing lastname */
-               file->dir.depth = lastdir_depth + 1;
+               F_DEPTH(file) = lastdir_depth + 1;
        } else
-               file->dir.depth = 1;
+               F_DEPTH(file) = 1;
 
        if (S_ISDIR(mode)) {
                if (basename_len == 1+1 && *basename == '.') /* +1 for '\0' */
-                       file->dir.depth--;
+                       F_DEPTH(file)--;
                if (flags & XMIT_TOP_DIR) {
                        in_del_hier = recurse;
-                       del_hier_name_len = file->dir.depth == 0 ? 0 : l1 + l2;
+                       del_hier_name_len = F_DEPTH(file) == 0 ? 0 : l1 + l2;
                        if (relative_paths && del_hier_name_len > 2
                            && lastname[del_hier_name_len-1] == '.'
                            && lastname[del_hier_name_len-2] == '/')
@@ -702,26 +745,42 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
 
 #ifdef SUPPORT_LINKS
        if (linkname_len) {
-               bp = (char*)F_BASENAME(file) + basename_len;
-               read_sbuf(f, bp, linkname_len - 1);
+               bp = (char*)file->basename + basename_len;
+               if (first_hlink_ndx >= 0) {
+                       struct file_struct *first = flist->files[first_hlink_ndx];
+                       memcpy(bp, F_SYMLINK(first), linkname_len);
+               } else
+                       read_sbuf(f, bp, linkname_len - 1);
                if (sanitize_paths)
                        sanitize_path(bp, bp, "", lastdir_depth, NULL);
        }
 #endif
 
 #ifdef SUPPORT_HARD_LINKS
-       if (preserve_hard_links && flags & XMIT_HAS_IDEV_DATA) {
-               struct idev *idevp = pool_talloc(hlink_pool, struct idev,
-                                                1, "inode_table");
-               F_HL_IDEV(file) = idevp;
-               if (protocol_version < 26) {
-                       idevp->dev = read_int(f);
-                       idevp->ino = read_int(f);
+       if (preserve_hard_links && flags & XMIT_HLINKED) {
+               if (protocol_version >= 30) {
+                       F_HL_GNUM(file) = flags & XMIT_HLINK_FIRST
+                                       ? flist->count : first_hlink_ndx;
                } else {
-                       if (!(flags & XMIT_SAME_DEV))
-                               dev = read_longint(f);
-                       idevp->dev = dev;
-                       idevp->ino = read_longint(f);
+                       static int32 cnt = 0;
+                       struct idev_node *np;
+                       int64 ino;
+                       int32 ndx;
+                       if (protocol_version < 26) {
+                               dev = read_int(f);
+                               ino = read_int(f);
+                       } else {
+                               if (!(flags & XMIT_SAME_DEV_pre30))
+                                       dev = read_longint(f);
+                               ino = read_longint(f);
+                       }
+                       np = idev_node(dev, ino);
+                       ndx = (int32)np->data - 1;
+                       if (ndx < 0) {
+                               ndx = cnt++;
+                               np->data = (void*)cnt;
+                       }
+                       F_HL_GNUM(file) = ndx;
                }
        }
 #endif
@@ -733,7 +792,11 @@ static struct file_struct *recv_file_entry(struct file_list *flist,
                        /* Prior to 28, we get a useless set of nulls. */
                        bp = tmp_sum;
                }
-               read_buf(f, bp, checksum_len);
+               if (first_hlink_ndx >= 0) {
+                       struct file_struct *first = flist->files[first_hlink_ndx];
+                       memcpy(bp, F_SUM(first), checksum_len);
+               } else
+                       read_buf(f, bp, checksum_len);
        }
 
        return file;
@@ -764,7 +827,7 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
        char thisname[MAXPATHLEN];
        char linkname[MAXPATHLEN];
        int alloc_len, basename_len, dirname_len, linkname_len;
-       int extra_len = (flist_extra_cnt - 1) * EXTRA_LEN;
+       int extra_len = flist_extra_cnt * EXTRA_LEN;
        char *basename, *dirname, *bp;
 
        if (!flist || !flist->count)    /* Ignore lastdir when invalid. */
@@ -886,6 +949,11 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
        if (st.st_size > 0xFFFFFFFFu && S_ISREG(st.st_mode))
                extra_len += EXTRA_LEN;
 
+#if EXTRA_ROUNDING > 0
+       if (extra_len & (EXTRA_ROUNDING * EXTRA_LEN))
+               extra_len = (extra_len | (EXTRA_ROUNDING * EXTRA_LEN)) + EXTRA_LEN;
+#endif
+
        alloc_len = FILE_STRUCT_LEN + extra_len + basename_len + dirname_len
                  + linkname_len;
        if (flist)
@@ -895,7 +963,7 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
                        out_of_memory("make_file");
        }
 
-       memset(bp, 0, FILE_STRUCT_LEN + extra_len);
+       memset(bp, 0, extra_len + FILE_STRUCT_LEN);
        bp += extra_len;
        file = (struct file_struct *)bp;
        bp += FILE_STRUCT_LEN;
@@ -908,10 +976,10 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
                if (protocol_version >= 28
                 ? (!S_ISDIR(st.st_mode) && st.st_nlink > 1)
                 : S_ISREG(st.st_mode)) {
-                       tmp_idev.dev = st.st_dev;
-                       tmp_idev.ino = st.st_ino;
+                       tmp_dev = st.st_dev;
+                       tmp_ino = st.st_ino;
                } else
-                       tmp_idev.dev = tmp_idev.ino = 0;
+                       tmp_dev = 0;
        }
 #endif
 
@@ -946,7 +1014,7 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
 
 #ifdef SUPPORT_LINKS
        if (linkname_len) {
-               bp = (char*)F_BASENAME(file) + basename_len;
+               bp = (char*)file->basename + basename_len;
                memcpy(bp, linkname, linkname_len);
        }
 #endif
@@ -954,7 +1022,7 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
        if (always_checksum && am_sender && S_ISREG(st.st_mode))
                file_checksum(thisname, tmp_sum, st.st_size);
 
-       file->dir.root = flist_dir;
+       F_ROOTDIR(file) = flist_dir;
 
        /* This code is only used by the receiver when it is building
         * a list of files for a delete pass. */
@@ -987,8 +1055,12 @@ struct file_struct *make_file(const char *fname, struct file_list *flist,
 /* Only called for temporary file_struct entries created by make_file(). */
 void unmake_file(struct file_struct *file)
 {
-       int extra_cnt = flist_extra_cnt - 1 + LEN64_BUMP(file);
-       free(file->extras - extra_cnt);
+       int extra_cnt = flist_extra_cnt + LEN64_BUMP(file);
+#if EXTRA_ROUNDING > 0
+       if (extra_cnt & EXTRA_ROUNDING)
+               extra_cnt = (extra_cnt | EXTRA_ROUNDING) + 1;
+#endif
+       free(REQ_EXTRA(file, extra_cnt));
 }
 
 static struct file_struct *send_file_name(int f, struct file_list *flist,
@@ -1009,7 +1081,8 @@ static struct file_struct *send_file_name(int f, struct file_list *flist,
 
        flist_expand(flist);
        flist->files[flist->count++] = file;
-       send_file_entry(file, f);
+       if (f >= 0)
+               send_file_entry(file, f, flist->count - 1);
        return file;
 }
 
@@ -1045,8 +1118,7 @@ static void send_if_directory(int f, struct file_list *flist,
  * file list in memory without sending it over the wire.  Also, get_dirlist()
  * might call this with f set to -2, which also indicates that local filter
  * rules should be ignored. */
-static void send_directory(int f, struct file_list *flist,
-                          char *fbuf, int len)
+static void send_directory(int f, struct file_list *flist, char *fbuf, int len)
 {
        struct dirent *di;
        unsigned remainder;
@@ -1093,6 +1165,7 @@ static void send_directory(int f, struct file_list *flist,
 
        if (recurse) {
                int i, end = flist->count - 1;
+               /* send_if_directory() bumps flist->count, so use "end". */
                for (i = start; i <= end; i++)
                        send_if_directory(f, flist, flist->files[i], fbuf, len);
        }
@@ -1116,6 +1189,11 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
        start_write = stats.total_written;
        gettimeofday(&start_tv, NULL);
 
+#ifdef SUPPORT_HARD_LINKS
+       if (preserve_hard_links && protocol_version >= 30)
+               init_hard_links();
+#endif
+
        flist = flist_new("send_file_list");
 
        io_start_buffering_out();
@@ -1334,7 +1412,12 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                stats.flist_buildtime = 1;
        start_tv = end_tv;
 
-       send_file_entry(NULL, f);
+       write_byte(f, 0); /* Indicate end of file list */
+
+#ifdef SUPPORT_HARD_LINKS
+       if (preserve_hard_links && protocol_version >= 30)
+               idev_destroy();
+#endif
 
        if (show_filelist_p())
                finish_filelist_progress(flist);
@@ -1382,6 +1465,10 @@ struct file_list *recv_file_list(int f)
 
        flist = flist_new("recv_file_list");
 
+#ifdef SUPPORT_HARD_LINKS
+       if (preserve_hard_links && protocol_version < 30)
+               init_hard_links();
+#endif
 
        while ((flags = read_byte(f)) != 0) {
                struct file_struct *file;
@@ -1462,12 +1549,12 @@ int flist_find(struct file_list *flist, struct file_struct *f)
                        /* Scan for the next non-empty entry using the cached
                         * distance values.  If the value isn't fully up-to-
                         * date, update it. */
-                       mid_up = mid + flist->files[mid]->dir.depth;
+                       mid_up = mid + F_DEPTH(flist->files[mid]);
                        if (!F_IS_ACTIVE(flist->files[mid_up])) {
                                do {
-                                   mid_up += flist->files[mid_up]->dir.depth;
+                                   mid_up += F_DEPTH(flist->files[mid_up]);
                                } while (!F_IS_ACTIVE(flist->files[mid_up]));
-                               flist->files[mid]->dir.depth = mid_up - mid;
+                               F_DEPTH(flist->files[mid]) = mid_up - mid;
                        }
                        if (mid_up > high) {
                                /* If there's nothing left above us, set high to
@@ -1504,12 +1591,13 @@ int flist_find(struct file_list *flist, struct file_struct *f)
  */
 void clear_file(struct file_struct *file)
 {
-       memset((char*)file + EXTRA_LEN, 0, FILE_STRUCT_LEN - EXTRA_LEN + 1);
-       /* In an empty entry, dir.depth is an offset to the next non-empty
+       /* The +1 zeros out the first char of the basename. */
+       memset(file, 0, FILE_STRUCT_LEN + 1);
+       /* In an empty entry, F_DEPTH() is an offset to the next non-empty
         * entry.  Likewise for len32 in the opposite direction.  We assume
         * that we're alone for now since flist_find() will adjust the counts
         * it runs into that aren't up-to-date. */
-       file->len32 = file->dir.depth = 1;
+       file->len32 = F_DEPTH(file) = 1;
 }
 
 /* Allocate a new file list. */
@@ -1643,49 +1731,49 @@ static void clean_flist(struct file_list *flist, int strip_root, int no_dups)
                for (i = flist->low; i <= flist->high; i++) {
                        struct file_struct *fp, *file = flist->files[i];
 
-                       /* This temporarily abuses the dir.depth value for a
+                       /* This temporarily abuses the F_DEPTH() value for a
                         * directory that is in a chain that might get pruned.
                         * We restore the old value if it gets a reprieve. */
-                       if (S_ISDIR(file->mode) && file->dir.depth) {
+                       if (S_ISDIR(file->mode) && F_DEPTH(file)) {
                                /* Dump empty dirs when coming back down. */
-                               for (j = prev_depth; j >= file->dir.depth; j--) {
+                               for (j = prev_depth; j >= F_DEPTH(file); j--) {
                                        fp = flist->files[prev_i];
-                                       if (fp->dir.depth >= 0)
+                                       if (F_DEPTH(fp) >= 0)
                                                break;
-                                       prev_i = -fp->dir.depth-1;
+                                       prev_i = -F_DEPTH(fp)-1;
                                        clear_file(fp);
                                }
-                               prev_depth = file->dir.depth;
+                               prev_depth = F_DEPTH(file);
                                if (is_excluded(f_name(file, fbuf), 1,
                                                       ALL_FILTERS)) {
                                        /* Keep dirs through this dir. */
                                        for (j = prev_depth-1; ; j--) {
                                                fp = flist->files[prev_i];
-                                               if (fp->dir.depth >= 0)
+                                               if (F_DEPTH(fp) >= 0)
                                                        break;
-                                               prev_i = -fp->dir.depth-1;
-                                               fp->dir.depth = j;
+                                               prev_i = -F_DEPTH(fp)-1;
+                                               F_DEPTH(fp) = j;
                                        }
                                } else
-                                       file->dir.depth = -prev_i-1;
+                                       F_DEPTH(file) = -prev_i-1;
                                prev_i = i;
                        } else {
                                /* Keep dirs through this non-dir. */
                                for (j = prev_depth; ; j--) {
                                        fp = flist->files[prev_i];
-                                       if (fp->dir.depth >= 0)
+                                       if (F_DEPTH(fp) >= 0)
                                                break;
-                                       prev_i = -fp->dir.depth-1;
-                                       fp->dir.depth = j;
+                                       prev_i = -F_DEPTH(fp)-1;
+                                       F_DEPTH(fp) = j;
                                }
                        }
                }
                /* Dump empty all remaining empty dirs. */
                while (1) {
                        struct file_struct *fp = flist->files[prev_i];
-                       if (fp->dir.depth >= 0)
+                       if (F_DEPTH(fp) >= 0)
                                break;
-                       prev_i = -fp->dir.depth-1;
+                       prev_i = -F_DEPTH(fp)-1;
                        clear_file(fp);
                }
 
@@ -1706,7 +1794,7 @@ static void output_flist(struct file_list *flist)
 {
        char uidbuf[16], gidbuf[16], depthbuf[16];
        struct file_struct *file;
-       const char *dir, *slash, *name, *trail;
+       const char *root, *dir, *slash, *name, *trail;
        const char *who = who_am_i();
        int i;
 
@@ -1723,19 +1811,19 @@ static void output_flist(struct file_list *flist)
                } else
                        *gidbuf = '\0';
                if (!am_sender)
-                       snprintf(depthbuf, sizeof depthbuf, "%d", file->dir.depth);
+                       snprintf(depthbuf, sizeof depthbuf, "%d", F_DEPTH(file));
                if (F_IS_ACTIVE(file)) {
+                       root = am_sender ? NS(F_ROOTDIR(file)) : depthbuf;
                        if ((dir = file->dirname) == NULL)
                                dir = slash = "";
                        else
                                slash = "/";
-                       name = F_BASENAME(file);
+                       name = file->basename;
                        trail = S_ISDIR(file->mode) ? "/" : "";
                } else
-                       dir = slash = name = trail = "";
+                       root = dir = slash = name = trail = "";
                rprintf(FINFO, "[%s] i=%d %s %s%s%s%s mode=0%o len=%.0f%s%s flags=%x\n",
-                       who, i, am_sender ? NS(file->dir.root) : depthbuf,
-                       dir, slash, name, trail, (int)file->mode,
+                       who, i, root, dir, slash, name, trail, (int)file->mode,
                        (double)F_LENGTH(file), uidbuf, gidbuf, file->flags);
        }
 }
@@ -1780,7 +1868,7 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
                c1 = c2 = NULL;
        if (!c1) {
                type1 = S_ISDIR(f1->mode) ? t_path : t_ITEM;
-               c1 = (uchar*)F_BASENAME(f1);
+               c1 = (const uchar*)f1->basename;
                if (type1 == t_PATH && *c1 == '.' && !c1[1]) {
                        type1 = t_ITEM;
                        state1 = s_TRAILING;
@@ -1793,7 +1881,7 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
        }
        if (!c2) {
                type2 = S_ISDIR(f2->mode) ? t_path : t_ITEM;
-               c2 = (uchar*)F_BASENAME(f2);
+               c2 = (const uchar*)f2->basename;
                if (type2 == t_PATH && *c2 == '.' && !c2[1]) {
                        type2 = t_ITEM;
                        state2 = s_TRAILING;
@@ -1817,7 +1905,7 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
                                break;
                        case s_SLASH:
                                type1 = S_ISDIR(f1->mode) ? t_path : t_ITEM;
-                               c1 = (uchar*)F_BASENAME(f1);
+                               c1 = (const uchar*)f1->basename;
                                if (type1 == t_PATH && *c1 == '.' && !c1[1]) {
                                        type1 = t_ITEM;
                                        state1 = s_TRAILING;
@@ -1847,7 +1935,7 @@ int f_name_cmp(struct file_struct *f1, struct file_struct *f2)
                                break;
                        case s_SLASH:
                                type2 = S_ISDIR(f2->mode) ? t_path : t_ITEM;
-                               c2 = (uchar*)F_BASENAME(f2);
+                               c2 = (const uchar*)f2->basename;
                                if (type2 == t_PATH && *c2 == '.' && !c2[1]) {
                                        type2 = t_ITEM;
                                        state2 = s_TRAILING;
@@ -1902,9 +1990,9 @@ char *f_name(struct file_struct *f, char *fbuf)
                int len = strlen(f->dirname);
                memcpy(fbuf, f->dirname, len);
                fbuf[len] = '/';
-               strlcpy(fbuf + len + 1, F_BASENAME(f), MAXPATHLEN - (len + 1));
+               strlcpy(fbuf + len + 1, f->basename, MAXPATHLEN - (len + 1));
        } else
-               strlcpy(fbuf, F_BASENAME(f), MAXPATHLEN);
+               strlcpy(fbuf, f->basename, MAXPATHLEN);
 
        return fbuf;
 }
@@ -1914,8 +2002,7 @@ char *f_name(struct file_struct *f, char *fbuf)
  * of the dirname string, and also indicates that "dirname" is a MAXPATHLEN
  * buffer (the functions we call will append names onto the end, but the old
  * dir value will be restored on exit). */
-struct file_list *get_dirlist(char *dirname, int dlen,
-                             int ignore_filter_rules)
+struct file_list *get_dirlist(char *dirname, int dlen, int ignore_filter_rules)
 {
        struct file_list *dirlist;
        char dirbuf[MAXPATHLEN];