Changed rprintf() calls that included strerror() to use rsyserr().
[rsync/rsync.git] / receiver.c
index e7fb211..c7cde82 100644 (file)
 extern int verbose;
 extern int recurse;
 extern int delete_mode;
+extern int delete_after;
+extern int max_delete;
 extern int csum_length;
 extern struct stats stats;
 extern int dry_run;
 extern int am_server;
 extern int relative_paths;
 extern int preserve_hard_links;
+extern int preserve_perms;
 extern int cvs_exclude;
 extern int io_error;
 extern char *tmpdir;
@@ -39,21 +42,26 @@ extern char *backup_dir;
 extern char *backup_suffix;
 extern int backup_suffix_len;
 extern int cleanup_got_literal;
+extern int module_id;
+extern int ignore_errors;
+extern int orig_umask;
+extern int keep_partial;
 
 static void delete_one(char *fn, int is_dir)
 {
        if (!is_dir) {
                if (robust_unlink(fn) != 0) {
-                       rprintf(FERROR, "delete_one: unlink %s failed: %s\n",
-                               full_fname(fn), strerror(errno));
+                       rsyserr(FERROR, errno, "delete_one: unlink %s failed",
+                               full_fname(fn));
                } else if (verbose) {
                        rprintf(FINFO, "deleting %s\n", fn);
                }
        } else {
                if (do_rmdir(fn) != 0) {
                        if (errno != ENOTEMPTY && errno != EEXIST) {
-                               rprintf(FERROR, "delete_one: rmdir %s failed: %s\n",
-                                       full_fname(fn), strerror(errno));
+                               rsyserr(FERROR, errno,
+                                       "delete_one: rmdir %s failed",
+                                       full_fname(fn));
                        }
                } else if (verbose) {
                        rprintf(FINFO, "deleting directory %s\n", fn);
@@ -69,17 +77,13 @@ static int is_backup_file(char *fn)
 }
 
 
-/* this deletes any files on the receiving side that are not present
- * on the sending side. For version 1.6.4 I have changed the behaviour
- * to match more closely what most people seem to expect of this option */
+/* This deletes any files on the receiving side that are not present
+ * on the sending side. */
 void delete_files(struct file_list *flist)
 {
        struct file_list *local_file_list;
        int i, j;
-       char *name, fbuf[MAXPATHLEN];
-       extern int module_id;
-       extern int ignore_errors;
-       extern int max_delete;
+       char *argv[1], fbuf[MAXPATHLEN];
        static int deletion_count;
 
        if (cvs_exclude)
@@ -90,22 +94,25 @@ void delete_files(struct file_list *flist)
                return;
        }
 
-       for (j = 0;j < flist->count; j++) {
-               if (!S_ISDIR(flist->files[j]->mode) ||
-                   !(flist->files[j]->flags & FLAG_DELETE)) continue;
+       for (j = 0; j < flist->count; j++) {
+               if (!(flist->files[j]->flags & FLAG_TOP_DIR)
+                   || !S_ISDIR(flist->files[j]->mode))
+                       continue;
 
-               name = f_name_to(flist->files[j], fbuf, sizeof fbuf);
+               argv[0] = f_name_to(flist->files[j], fbuf);
 
-               if (!(local_file_list = send_file_list(-1,1,&name)))
+               if (!(local_file_list = send_file_list(-1, 1, argv)))
                        continue;
 
                if (verbose > 1)
-                       rprintf(FINFO,"deleting in %s\n", name);
+                       rprintf(FINFO, "deleting in %s\n", fbuf);
 
                for (i = local_file_list->count-1; i >= 0; i--) {
-                       if (max_delete && deletion_count > max_delete) break;
-                       if (!local_file_list->files[i]->basename) continue;
-                       if (-1 == flist_find(flist,local_file_list->files[i])) {
+                       if (max_delete && deletion_count > max_delete)
+                               break;
+                       if (!local_file_list->files[i]->basename)
+                               continue;
+                       if (flist_find(flist,local_file_list->files[i]) < 0) {
                                char *f = f_name(local_file_list->files[i]);
                                if (make_backups && (backup_dir || !is_backup_file(f))) {
                                        (void) make_backup(f);
@@ -151,8 +158,8 @@ static int get_tmpname(char *fnametmp, char *fname)
        int     maxname;
 
        if (tmpdir) {
-               strlcpy(fnametmp, tmpdir, MAXPATHLEN - 2);
-               length = strlen(fnametmp);
+               /* Note: this can't overflow, so the return value is safe */
+               length = strlcpy(fnametmp, tmpdir, MAXPATHLEN - 2);
                fnametmp[length++] = '/';
                fnametmp[length] = '\0';        /* always NULL terminated */
        }
@@ -217,8 +224,8 @@ static int receive_data(int f_in,struct map_struct *mapbuf,int fd,char *fname,
                        sum_update(data,i);
 
                        if (fd != -1 && write_file(fd,data,i) != i) {
-                               rprintf(FERROR, "write failed on %s: %s\n",
-                                       full_fname(fname), strerror(errno));
+                               rsyserr(FERROR, errno, "write failed on %s",
+                                       full_fname(fname));
                                exit_cleanup(RERR_FILEIO);
                        }
                        offset += i;
@@ -245,8 +252,8 @@ static int receive_data(int f_in,struct map_struct *mapbuf,int fd,char *fname,
                }
 
                if (fd != -1 && write_file(fd,map,len) != (int) len) {
-                       rprintf(FERROR, "write failed on %s: %s\n",
-                               full_fname(fname), strerror(errno));
+                       rsyserr(FERROR, errno, "write failed on %s",
+                               full_fname(fname));
                        exit_cleanup(RERR_FILEIO);
                }
                offset += len;
@@ -258,8 +265,8 @@ static int receive_data(int f_in,struct map_struct *mapbuf,int fd,char *fname,
                end_progress(total_size);
 
        if (fd != -1 && offset > 0 && sparse_end(fd) != 0) {
-               rprintf(FERROR, "write failed on %s: %s\n",
-                       full_fname(fname), strerror(errno));
+               rsyserr(FERROR, errno, "write failed on %s",
+                       full_fname(fname));
                exit_cleanup(RERR_FILEIO);
        }
 
@@ -280,7 +287,7 @@ static int receive_data(int f_in,struct map_struct *mapbuf,int fd,char *fname,
  * main routine for receiver process.
  *
  * Receiver process runs on the same host as the generator process. */
-int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
+int recv_files(int f_in,struct file_list *flist,char *local_name)
 {
        int fd1,fd2;
        STRUCT_STAT st;
@@ -294,16 +301,17 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
        struct file_struct *file;
        int phase=0;
        int recv_ok;
-       extern struct stats stats;
-       extern int preserve_perms;
-       extern int delete_after;
-       extern int orig_umask;
        struct stats initial_stats;
 
        if (verbose > 2) {
                rprintf(FINFO,"recv_files(%d) starting\n",flist->count);
        }
 
+       if (flist->hlink_pool) {
+               pool_destroy(flist->hlink_pool);
+               flist->hlink_pool = NULL;
+       }
+
        while (1) {
                cleanup_disable();
 
@@ -314,7 +322,7 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
                                csum_length = SUM_LENGTH;
                                if (verbose > 2)
                                        rprintf(FINFO,"recv_files phase=%d\n",phase);
-                               write_int(f_gen,-1);
+                               send_msg(MSG_DONE, "", 0);
                                continue;
                        }
                        break;
@@ -336,7 +344,7 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
                if (local_name)
                        fname = local_name;
                else
-                       fname = f_name_to(file, fbuf, sizeof fbuf);
+                       fname = f_name_to(file, fbuf);
 
                if (dry_run) {
                        if (!am_server && verbose) {    /* log transfer */
@@ -355,17 +363,17 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
                /* open the file */
                fd1 = do_open(fnamecmp, O_RDONLY, 0);
 
-               if ((fd1 == -1) && (compare_dest != NULL)) {
+               if (fd1 == -1 && compare_dest != NULL) {
                        /* try the file at compare_dest instead */
-                       snprintf(fnamecmpbuf,MAXPATHLEN,"%s/%s",
-                                               compare_dest,fname);
+                       pathjoin(fnamecmpbuf, sizeof fnamecmpbuf,
+                                compare_dest, fname);
                        fnamecmp = fnamecmpbuf;
                        fd1 = do_open(fnamecmp, O_RDONLY, 0);
                }
 
                if (fd1 != -1 && do_fstat(fd1,&st) != 0) {
-                       rprintf(FERROR, "fstat %s failed: %s\n",
-                               full_fname(fnamecmp), strerror(errno));
+                       rsyserr(FERROR, errno, "fstat %s failed",
+                               full_fname(fnamecmp));
                        receive_data(f_in,NULL,-1,NULL,file->length);
                        close(fd1);
                        continue;
@@ -410,7 +418,7 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
                        continue;
                }
 
-               strlcpy(template, fnametmp, sizeof(template));
+               strlcpy(template, fnametmp, sizeof template);
 
                /* we initially set the perms without the
                 * setuid/setgid bits to ensure that there is no race
@@ -425,12 +433,12 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
                 * transferred, but that may not be the case with -R */
                if (fd2 == -1 && relative_paths && errno == ENOENT &&
                    create_directory_path(fnametmp, orig_umask) == 0) {
-                       strlcpy(fnametmp, template, sizeof(fnametmp));
+                       strlcpy(fnametmp, template, sizeof fnametmp);
                        fd2 = do_mkstemp(fnametmp, file->mode & INITACCESSPERMS);
                }
                if (fd2 == -1) {
-                       rprintf(FERROR, "mkstemp %s failed: %s\n",
-                               full_fname(fnametmp), strerror(errno));
+                       rsyserr(FERROR, errno, "mkstemp %s failed",
+                               full_fname(fnametmp));
                        receive_data(f_in,mapbuf,-1,NULL,file->length);
                        if (mapbuf) unmap_file(mapbuf);
                        if (fd1 != -1) close(fd1);
@@ -452,12 +460,19 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
                if (fd1 != -1) {
                        close(fd1);
                }
-               close(fd2);
+               if (close(fd2) < 0) {
+                       rsyserr(FERROR, errno, "close failed on %s",
+                               full_fname(fnametmp));
+                       exit_cleanup(RERR_FILEIO);
+               }
 
                if (verbose > 2)
                        rprintf(FINFO,"renaming %s to %s\n",fnametmp,fname);
 
-               finish_transfer(fname, fnametmp, file);
+               if (recv_ok || keep_partial)
+                       finish_transfer(fname, fnametmp, file, recv_ok);
+               else
+                       do_unlink(fnametmp);
 
                cleanup_disable();
 
@@ -466,9 +481,11 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
                                rprintf(FERROR,"ERROR: file corruption in %s. File changed during transfer?\n",
                                        full_fname(fname));
                        } else {
+                               char buf[4];
                                if (verbose > 1)
                                        rprintf(FINFO,"redoing %s(%d)\n",fname,i);
-                               write_int(f_gen,i);
+                               SIVAL(buf, 0, i);
+                               send_msg(MSG_REDO, buf, 4);
                        }
                }
        }
@@ -477,18 +494,6 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen)
            && flist->count > 0)
                delete_files(flist);
 
-       if (preserve_hard_links)
-               do_hard_links();
-
-       /* now we need to fix any directory permissions that were
-        * modified during the transfer */
-       for (i = 0; i < flist->count; i++) {
-               file = flist->files[i];
-               if (!file->basename || !S_ISDIR(file->mode)) continue;
-               recv_generator(local_name? local_name
-                            : f_name_to(file,fbuf,sizeof fbuf), file, i, -1);
-       }
-
        if (verbose > 2)
                rprintf(FINFO,"recv_files finished\n");