Matt McCutchen's Web Site
/
rsync
/
rsync.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix a typo that Andrea Gelmini pointed out.
[rsync/rsync.git]
/
socket.c
diff --git
a/socket.c
b/socket.c
index
2b3271c
..
5df3a50
100644
(file)
--- a/
socket.c
+++ b/
socket.c
@@
-3,7
+3,7
@@
*
* Copyright (C) 1992-2001 Andrew Tridgell <tridge@samba.org>
* Copyright (C) 2001, 2002 Martin Pool <mbp@samba.org>
*
* Copyright (C) 1992-2001 Andrew Tridgell <tridge@samba.org>
* Copyright (C) 2001, 2002 Martin Pool <mbp@samba.org>
- * Copyright (C) 2003-200
8
Wayne Davison
+ * Copyright (C) 2003-200
9
Wayne Davison
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@
-25,7
+25,7
@@
* emulate it using the KAME implementation. */
#include "rsync.h"
* emulate it using the KAME implementation. */
#include "rsync.h"
-#include "i
func
s.h"
+#include "i
type
s.h"
#include <netinet/in_systm.h>
#include <netinet/ip.h>
#include <netinet/tcp.h>
#include <netinet/in_systm.h>
#include <netinet/ip.h>
#include <netinet/tcp.h>
@@
-578,7
+578,7
@@
void start_accept_loop(int port, int (*fn)(int, int))
fds = deffds;
#endif
fds = deffds;
#endif
- if (select(maxfd + 1, &fds, NULL, NULL, NULL)
!=
1)
+ if (select(maxfd + 1, &fds, NULL, NULL, NULL)
<
1)
continue;
for (i = 0, fd = -1; sp[i] >= 0; i++) {
continue;
for (i = 0, fd = -1; sp[i] >= 0; i++) {
@@
-823,6
+823,7
@@
static int socketpair_tcp(int fd[2])
**/
int sock_exec(const char *prog)
{
**/
int sock_exec(const char *prog)
{
+ pid_t pid;
int fd[2];
if (socketpair_tcp(fd) != 0) {
int fd[2];
if (socketpair_tcp(fd) != 0) {
@@
-831,14
+832,23
@@
int sock_exec(const char *prog)
}
if (DEBUG_GTE(CMD, 1))
rprintf(FINFO, "Running socket program: \"%s\"\n", prog);
}
if (DEBUG_GTE(CMD, 1))
rprintf(FINFO, "Running socket program: \"%s\"\n", prog);
- if (fork() == 0) {
+
+ pid = fork();
+ if (pid < 0) {
+ rsyserr(FERROR, errno, "fork");
+ exit_cleanup(RERR_IPC);
+ }
+
+ if (pid == 0) {
close(fd[0]);
close(fd[0]);
- close(0);
- close(1);
- dup(fd[1]);
- dup(fd[1]);
+ if (dup2(fd[1], STDIN_FILENO) < 0
+ || dup2(fd[1], STDOUT_FILENO) < 0) {
+ fprintf(stderr, "Failed to run \"%s\"\n", prog);
+ exit(1);
+ }
exit(system(prog));
}
exit(system(prog));
}
+
close(fd[1]);
return fd[0];
}
close(fd[1]);
return fd[0];
}