Set the file's gid to -1 if we don't have permissions to set it.

[rsync/rsync.git] / uidlist.c

diff --git a/uidlist.c b/uidlist.c
index eff8749..02d551d 100644 (file)
--- a/uidlist.c
+++ b/uidlist.c
@@ -28,6 +28,7 @@
 extern int preserve_uid;
 extern int preserve_gid;
 extern int numeric_ids;
+extern int am_root;
 
 struct idlist {
        struct idlist *next;
@@ -40,7 +41,7 @@ static struct idlist *gidlist;
 
 static struct idlist *add_list(int id, char *name)
 {
-       struct idlist *list = (struct idlist *)malloc(sizeof(list[0]));
+       struct idlist *list = new(struct idlist);
        if (!list) out_of_memory("add_list");
        list->next = NULL;
        list->name = strdup(name);
@@ -105,6 +106,40 @@ static uid_t match_uid(uid_t uid)
        return last_out;
 }
 
+static int is_in_group(gid_t gid)
+{
+#ifdef GETGROUPS_T
+       static gid_t last_in = (gid_t) -2, last_out;
+       static int ngroups = -2;
+       static GETGROUPS_T *gidset;
+       int n;
+
+       if (gid == last_in)
+               return last_out;
+       if (ngroups < -1) {
+               /* treat failure (-1) as if not member of any group */
+               ngroups = getgroups(0, 0);
+               if (ngroups > 0) {
+                       gidset = new_array(GETGROUPS_T, ngroups);
+                       ngroups = getgroups(ngroups, gidset);
+               }
+       }
+
+       last_in = gid;
+       last_out = 0;
+       for (n = 0; n < ngroups; n++) {
+               if (gidset[n] == gid) {
+                       last_out = 1;
+                       break;
+               }
+       }
+       return last_out;
+
+#else
+       return 0;
+#endif
+}
+
 static gid_t match_gid(gid_t gid)
 {
        static gid_t last_in, last_out;
@@ -122,7 +157,10 @@ static gid_t match_gid(gid_t gid)
                list = list->next;
        }
        
-       last_out = gid;
+       if (am_root)
+               last_out = gid;
+       else
+               last_out = (gid_t)-1;
        return last_out;
 }
 
@@ -234,10 +272,9 @@ void recv_uid_list(int f, struct file_list *flist)
        if (preserve_uid) {
                /* read the uid list */
                list = uidlist;
-               id = read_int(f);
-               while (id != 0) {
+               while ((id = read_int(f)) != 0) {
                        int len = read_byte(f);
-                       name = (char *)malloc(len+1);
+                       name = new_array(char, len+1);
                        if (!name) out_of_memory("recv_uid_list");
                        read_sbuf(f, name, len);
                        if (!list) {
@@ -249,7 +286,6 @@ void recv_uid_list(int f, struct file_list *flist)
                        }
                        list->id2 = map_uid(id, name);
                        free(name);
-                       id = read_int(f);
                }
        }
 
@@ -257,10 +293,9 @@ void recv_uid_list(int f, struct file_list *flist)
        if (preserve_gid) {
                /* and the gid list */
                list = gidlist;
-               id = read_int(f);
-               while (id != 0) {
+               while ((id = read_int(f)) != 0) {
                        int len = read_byte(f);
-                       name = (char *)malloc(len+1);
+                       name = new_array(char, len+1);
                        if (!name) out_of_memory("recv_uid_list");
                        read_sbuf(f, name, len);
                        if (!list) {
@@ -271,17 +306,18 @@ void recv_uid_list(int f, struct file_list *flist)
                                list = list->next;
                        }
                        list->id2 = map_gid(id, name);
+                       if (!am_root && !is_in_group(list->id2))
+                               list->id2 = (gid_t)-1;
                        free(name);
-                       id = read_int(f);
                }
        }
 
-       if (!uidlist && !gidlist) return;
+       if (!(am_root && preserve_uid) && !preserve_gid) return;
 
        /* now convert the uid/gid of all files in the list to the mapped
           uid/gid */
        for (i=0;i<flist->count;i++) {
-               if (preserve_uid && flist->files[i]->uid != 0) {
+               if (am_root && preserve_uid && flist->files[i]->uid != 0) {
                        flist->files[i]->uid = match_uid(flist->files[i]->uid);
                }
                if (preserve_gid && flist->files[i]->gid != 0) {