Added "need_first_push" logic to delete_in_dir().
[rsync/rsync.git] / flist.c
diff --git a/flist.c b/flist.c
index ac57167..b88ab8b 100644 (file)
--- a/flist.c
+++ b/flist.c
@@ -78,6 +78,8 @@ int io_error;
 static char empty_sum[MD4_SUM_LENGTH];
 static unsigned int file_struct_len;
 static struct file_list *received_flist;
+static dev_t filesystem_dev; /* used to implement -x */
+static int deletion_count = 0; /* used to implement --max-delete */
 
 static void clean_flist(struct file_list *flist, int strip_root, int no_dups);
 static void output_flist(struct file_list *flist, const char *whose_list);
@@ -251,18 +253,6 @@ static int is_excluded(char *fname, int is_dir, int filter_level)
        return 0;
 }
 
-/* used by the one_file_system code */
-static dev_t filesystem_dev;
-
-static void set_filesystem(char *fname)
-{
-       STRUCT_STAT st;
-       if (do_stat(fname, &st) != 0)
-               return;
-       filesystem_dev = st.st_dev;
-}
-
-
 static int to_wire_mode(mode_t mode)
 {
 #if SUPPORT_LINKS
@@ -280,7 +270,8 @@ static mode_t from_wire_mode(int mode)
 }
 
 
-static void send_directory(int f, struct file_list *flist, char *dir);
+static void send_directory(int f, struct file_list *flist,
+                          char *fbuf, unsigned int offset);
 
 static char *flist_dir;
 static int flist_dir_len;
@@ -531,7 +522,7 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags,
        static gid_t gid;
        static char lastname[MAXPATHLEN], *lastdir;
        static int lastdir_depth, lastdir_len = -1;
-       static unsigned int del_heir_name_len = -1;
+       static unsigned int del_heir_name_len = 0;
        static int in_del_hier = 0;
        char thisname[MAXPATHLEN];
        unsigned int l1 = 0, l2 = 0;
@@ -546,7 +537,7 @@ void receive_file_entry(struct file_struct **fptr, unsigned short flags,
                rdev_major = 0;
                uid = 0, gid = 0;
                *lastname = '\0';
-               del_heir_name_len = lastdir_len = -1;
+               lastdir_len = -1;
                in_del_hier = 0;
                return;
        }
@@ -925,7 +916,7 @@ skip_filters:
        memcpy(bp, basename, basename_len);
        bp += basename_len;
 
-#ifdef HAVE_STRUCT_STAT_ST_RDEV
+#if HAVE_STRUCT_STAT_ST_RDEV
        if (preserve_devices && IS_DEVICE(st.st_mode))
                file->u.rdev = st.st_rdev;
 #endif
@@ -996,80 +987,76 @@ void send_file_name(int f, struct file_list *flist, char *fname,
        }
 
        if (recursive && S_ISDIR(file->mode)
-           && !(file->flags & FLAG_MOUNT_POINT)) {
-               send_directory(f, flist, f_name_to(file, fbuf));
+           && !(file->flags & FLAG_MOUNT_POINT) && f_name_to(file, fbuf)) {
+               void *save_filters;
+               unsigned int len = strlen(fbuf);
+               if (len > 1 && fbuf[len-1] == '/')
+                       fbuf[--len] = '\0';
+               if (len >= MAXPATHLEN - 1) {
+                       io_error |= IOERR_GENERAL;
+                       rprintf(FERROR, "skipping long-named directory: %s\n",
+                               full_fname(fbuf));
+                       return;
+               }
+               save_filters = push_local_filters(fbuf, len);
+               send_directory(f, flist, fbuf, len);
+               pop_local_filters(save_filters);
        }
 }
 
 
 /* Note that the "recurse" value either contains -1, for infinite recursion,
  * or a number >= 0 indicating how many levels of recursion we will allow. */
-static void send_directory(int f, struct file_list *flist, char *dir)
+static void send_directory(int f, struct file_list *flist,
+                          char *fbuf, unsigned int len)
 {
-       DIR *d;
        struct dirent *di;
-       char fname[MAXPATHLEN];
-       unsigned int offset;
-       void *save_filters;
        char *p;
+       DIR *d;
 
-       d = opendir(dir);
-       if (!d) {
+       if (!(d = opendir(fbuf))) {
                io_error |= IOERR_GENERAL;
-               rsyserr(FERROR, errno, "opendir %s failed", full_fname(dir));
+               rsyserr(FERROR, errno, "opendir %s failed", full_fname(fbuf));
                return;
        }
 
-       offset = strlcpy(fname, dir, MAXPATHLEN);
-       p = fname + offset;
-       if (offset >= MAXPATHLEN || p[-1] != '/') {
-               if (offset >= MAXPATHLEN - 1) {
-                       io_error |= IOERR_GENERAL;
-                       rprintf(FERROR, "skipping long-named directory: %s\n",
-                               full_fname(fname));
-                       closedir(d);
-                       return;
-               }
+       p = fbuf + len;
+       if (len != 1 || *fbuf != '/')
                *p++ = '/';
-               offset++;
-       }
-
-       save_filters = push_local_filters(fname, offset);
+       *p = '\0';
 
        for (errno = 0, di = readdir(d); di; errno = 0, di = readdir(d)) {
                char *dname = d_name(di);
                if (dname[0] == '.' && (dname[1] == '\0'
                    || (dname[1] == '.' && dname[2] == '\0')))
                        continue;
-               if (strlcpy(p, dname, MAXPATHLEN - offset) < MAXPATHLEN - offset) {
+               if (strlcpy(p, dname, MAXPATHLEN - len) < MAXPATHLEN - len) {
                        int do_subdirs = recurse >= 1 ? recurse-- : recurse;
-                       send_file_name(f, flist, fname, do_subdirs, 0);
+                       send_file_name(f, flist, fbuf, do_subdirs, 0);
                } else {
                        io_error |= IOERR_GENERAL;
                        rprintf(FINFO,
                                "cannot send long-named file %s\n",
-                               full_fname(fname));
+                               full_fname(fbuf));
                }
        }
        if (errno) {
                io_error |= IOERR_GENERAL;
-               rsyserr(FERROR, errno, "readdir(%s)", dir);
+               *p = '\0';
+               rsyserr(FERROR, errno, "readdir(%s)", fbuf);
        }
 
-       pop_local_filters(save_filters);
-
        closedir(d);
 }
 
 
 /* This function is normally called by the sender, but the receiving side
  * also uses it to construct one or more file lists if one of the --delete
- * options have been specified.  The delete_in_dir() function sets f to -1
+ * options have been specified.  The delete_files() function sets f to -1
  * so that we just construct the file list in memory without sending it
  * over the wire.  It also has the side-effect of ignoring user-excludes if
  * delete_excluded is set (so that the delete list includes user-excluded
- * files) and it avoids some per-arg init code for limited recursion (since
- * delete_in_dir() sets recurse before calling this function). */
+ * files). */
 struct file_list *send_file_list(int f, int argc, char *argv[])
 {
        int l;
@@ -1078,6 +1065,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
        char lastpath[MAXPATHLEN] = "";
        struct file_list *flist;
        BOOL need_first_push = True;
+       struct timeval start_tv, end_tv;
        int64 start_write;
        int use_ff_fd = 0;
 
@@ -1085,6 +1073,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                start_filelist_progress("building file list");
 
        start_write = stats.total_written;
+       gettimeofday(&start_tv, NULL);
 
        flist = flist_new(f == -1 ? WITHOUT_HLINK : WITH_HLINK,
                          "send_file_list");
@@ -1132,9 +1121,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                                fname[l] = '\0';
                        }
                }
-               if (f == -1)
-                       ; /* recurse is pre-set */
-               else if (fname[l-1] == '.' && (l == 1 || fname[l-2] == '/')) {
+               if (fname[l-1] == '.' && (l == 1 || fname[l-2] == '/')) {
                        if (!recurse && xfer_dirs)
                                recurse = 1; /* allow one level */
                } else if (recurse > 0)
@@ -1233,7 +1220,7 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
                }
 
                if (one_file_system)
-                       set_filesystem(fname);
+                       filesystem_dev = st.st_dev;
 
                do_subdirs = recurse >= 1 ? recurse-- : recurse;
                send_file_name(f, flist, fname, do_subdirs, XMIT_DEL_START);
@@ -1250,10 +1237,23 @@ struct file_list *send_file_list(int f, int argc, char *argv[])
        }
 
        if (f != -1) {
+               gettimeofday(&end_tv, NULL);
+               stats.flist_buildtime =
+                   (int64)(end_tv.tv_sec - start_tv.tv_sec) * 1000
+                        + (end_tv.tv_usec - start_tv.tv_usec) / 1000;
+               if (stats.flist_buildtime == 0)
+                       stats.flist_buildtime = 1;
+               start_tv = end_tv;
+
                send_file_entry(NULL, f, 0);
 
                if (show_filelist_p())
                        finish_filelist_progress(flist);
+
+               gettimeofday(&end_tv, NULL);
+               stats.flist_xfertime =
+                   (int64)(end_tv.tv_sec - start_tv.tv_sec) * 1000
+                        + (end_tv.tv_usec - start_tv.tv_usec) / 1000;
        }
 
        if (flist->hlink_pool) {
@@ -1647,8 +1647,7 @@ char *f_name_to(struct file_struct *f, char *fbuf)
 }
 
 
-/* Like f_name_to(), but we rotate through 5 static buffers of our own.
- */
+/* Like f_name_to(), but we rotate through 5 static buffers of our own. */
 char *f_name(struct file_struct *f)
 {
        static char names[5][MAXPATHLEN];
@@ -1659,63 +1658,125 @@ char *f_name(struct file_struct *f)
        return f_name_to(f, names[n]);
 }
 
+
 static int is_backup_file(char *fn)
 {
        int k = strlen(fn) - backup_suffix_len;
        return k > 0 && strcmp(fn+k, backup_suffix) == 0;
 }
 
+
+/* This function is used to implement --delete-during. */
 void delete_in_dir(struct file_list *flist, char *fname)
 {
-       static int deletion_count = 0;
-       struct file_list *del_flist;
-       int save_recurse = recurse;
-       int save_xfer_dirs = xfer_dirs;
-       int save_implied_dirs = implied_dirs;
-       int save_relative_paths = relative_paths;
-       char *argv[1];
-       int i, j, mode;
+       static void *filt_array[MAXPATHLEN/2];
+       static BOOL need_first_push = True;
+       static int fa_lvl = 0;
+       static char fbuf[MAXPATHLEN];
+       struct file_list *dir_list;
+       STRUCT_STAT st;
+       int dlen, j;
+
+       if (!flist) {
+               while (fa_lvl)
+                       pop_local_filters(filt_array[--fa_lvl]);
+               need_first_push = True;
+               *fbuf = '\0';
+               return;
+       }
 
        if (max_delete && deletion_count >= max_delete)
                return;
 
        if (io_error && !(lp_ignore_errors(module_id) || ignore_errors)) {
-               rprintf(FINFO, "IO error encountered - skipping file deletion\n");
+               rprintf(FINFO,
+                       "IO error encountered - skipping file deletion\n");
                max_delete = -1; /* avoid duplicating the above warning */
                return;
        }
 
-       if (delete_during) {
-               recurse = 1; /* allow one level only */
-               xfer_dirs = 1;
-               implied_dirs = 0;
-               relative_paths = 1;
+       for (j = 0; fbuf[j]; j++) {
+               if (fbuf[j] != fname[j]) {
+                       while (fa_lvl) {
+                               if (fbuf[j] == '/')
+                                       pop_local_filters(filt_array[--fa_lvl]);
+                               if (!fbuf[++j])
+                                       break;
+                       }
+                       break;
+               }
        }
 
-       argv[0] = fname;
-       del_flist = send_file_list(-1, 1, argv);
+       dlen = strlcpy(fbuf, fname, MAXPATHLEN);
+       if (need_first_push) {
+               if (dlen != 1 || fbuf[0] != '.') {
+                       char *s = strrchr(fbuf, '/');
+                       int first_dlen;
+                       if (s)
+                               first_dlen = s - fbuf;
+                       else
+                               first_dlen = 0;
+                       if (!s || s[1] != '.' || s[2] != '\0') {
+                               filt_array[fa_lvl++] = push_local_filters(fbuf,
+                                                                         first_dlen);
+                       }
+               }
+               need_first_push = False;
+       }
 
-       relative_paths = save_relative_paths;
-       implied_dirs = save_implied_dirs;
-       xfer_dirs = save_xfer_dirs;
-       recurse = save_recurse;
+       if (dlen >= MAXPATHLEN - 1)
+               return;
+       if (fa_lvl >= MAXPATHLEN/2)
+               return; /* impossible... */
 
-       if (!del_flist)
+       if (link_stat(fname, &st, keep_dirlinks) < 0)
+               return;
+
+       if (one_file_system)
+               filesystem_dev = st.st_dev;
+
+       dir_list = flist_new(WITHOUT_HLINK, "delete_in_dir");
+
+       recurse = 0;
+       filt_array[fa_lvl++] = push_local_filters(fbuf, dlen);
+       send_directory(-1, dir_list, fbuf, dlen);
+       recurse = -1;
+
+       if (dlen == 1 && *fbuf == '.')
+               *fbuf = '\0';
+
+       clean_flist(dir_list, 0, 0);
+
+       if (verbose > 3)
+               output_flist(dir_list, "delete");
+
+       delete_missing(flist, dir_list, fname);
+
+       flist_free(dir_list);
+}
+
+
+/* If an item in dir_list is not found in full_list, delete it from the
+ * filesystem. */
+void delete_missing(struct file_list *full_list, struct file_list *dir_list,
+                   const char *dirname)
+{
+       int i, j, mode;
+
+       if (max_delete && deletion_count >= max_delete)
                return;
 
        if (verbose > 1)
-               rprintf(FINFO, "deleting in %s\n", safe_fname(fname));
+               rprintf(FINFO, "deleting in %s\n", safe_fname(dirname));
 
-       for (i = del_flist->count-1; i >= 0; i--) {
-               if (max_delete && deletion_count >= max_delete)
-                       break;
-               if (!del_flist->files[i]->basename)
+       for (i = dir_list->count; i--; ) {
+               if (!dir_list->files[i]->basename)
                        continue;
-               mode = del_flist->files[i]->mode;
-               if ((j = flist_find(flist, del_flist->files[i])) < 0
+               mode = dir_list->files[i]->mode;
+               if ((j = flist_find(full_list, dir_list->files[i])) < 0
                    || (delete_during && S_ISDIR(mode)
-                    && !S_ISDIR(flist->files[j]->mode))) {
-                       char *f = f_name(del_flist->files[i]);
+                    && !S_ISDIR(full_list->files[j]->mode))) {
+                       char *f = f_name(dir_list->files[i]);
                        if (make_backups && (backup_dir || !is_backup_file(f))
                          && !S_ISDIR(mode)) {
                                make_backup(f);
@@ -1723,12 +1784,16 @@ void delete_in_dir(struct file_list *flist, char *fname)
                                        rprintf(FINFO, "deleting %s\n",
                                                safe_fname(f));
                                }
+                       } else if (S_ISDIR(mode)) {
+                               int dflag = delete_during ? DEL_FORCE_RECURSE
+                                                         : DEL_NO_RECURSE;
+                               delete_file(f, DEL_DIR | dflag);
                        } else {
-                               delete_file(f, S_ISDIR(mode)
-                                               ? DEL_DIR | DEL_RECURSE : 0);
+                               delete_file(f, 0);
                        }
                        deletion_count++;
+                       if (max_delete && deletion_count >= max_delete)
+                               break;
                }
        }
-       flist_free(del_flist);
 }