Matt McCutchen's Web Site
/
rsync
/
rsync.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Added an extra comment.
[rsync/rsync.git]
/
flist.c
diff --git
a/flist.c
b/flist.c
index
0f4c88f
..
f1b054f
100644
(file)
--- a/
flist.c
+++ b/
flist.c
@@
-355,11
+355,12
@@
static void send_file_entry(struct file_struct *file, int f,
unsigned short base_flags)
{
unsigned short flags;
unsigned short base_flags)
{
unsigned short flags;
- static time_t last_time;
- static mode_t last_mode;
- static DEV64_T last_rdev;
- static uid_t last_uid;
- static gid_t last_gid;
+ static time_t modtime;
+ static mode_t mode;
+ static DEV64_T rdev; /* just high bytes after p28 */
+ static uid_t uid;
+ static gid_t gid;
+ static DEV64_T dev;
static char lastname[MAXPATHLEN];
char *fname, fbuf[MAXPATHLEN];
int l1, l2;
static char lastname[MAXPATHLEN];
char *fname, fbuf[MAXPATHLEN];
int l1, l2;
@@
-378,35
+379,48
@@
static void send_file_entry(struct file_struct *file, int f,
flags = base_flags;
flags = base_flags;
- if (file->mode ==
last_
mode)
+ if (file->mode == mode)
flags |= SAME_MODE;
else
flags |= SAME_MODE;
else
-
last_
mode = file->mode;
+ mode = file->mode;
if (preserve_devices) {
if (protocol_version < 28) {
if (preserve_devices) {
if (protocol_version < 28) {
- if (IS_DEVICE(last_mode) && file->rdev == last_rdev)
- flags |= OLD_SAME_RDEV|SAME_HIGH_RDEV;
+ if (IS_DEVICE(mode) && file->rdev == rdev) {
+ /* Set both flags so that the test when
+ * writing the data is simpler. */
+ flags |= SAME_RDEV_pre28|SAME_HIGH_RDEV;
+ }
else
else
-
last_
rdev = file->rdev;
+ rdev = file->rdev;
}
}
- else if (IS_DEVICE(
last_
mode)) {
- if ((file->rdev & ~0xFF) ==
(last_rdev & ~0xFF)
)
+ else if (IS_DEVICE(mode)) {
+ if ((file->rdev & ~0xFF) ==
rdev
)
flags |= SAME_HIGH_RDEV;
flags |= SAME_HIGH_RDEV;
- last_rdev = file->rdev;
+ else
+ rdev = file->rdev & ~0xFF;
}
}
}
}
- if (file->uid ==
last_
uid)
+ if (file->uid == uid)
flags |= SAME_UID;
else
flags |= SAME_UID;
else
-
last_
uid = file->uid;
- if (file->gid ==
last_
gid)
+ uid = file->uid;
+ if (file->gid == gid)
flags |= SAME_GID;
else
flags |= SAME_GID;
else
-
last_
gid = file->gid;
- if (file->modtime ==
last_
time)
+ gid = file->gid;
+ if (file->modtime ==
mod
time)
flags |= SAME_TIME;
else
flags |= SAME_TIME;
else
- last_time = file->modtime;
+ modtime = file->modtime;
+ if (file->flags & HAS_INODE_DATA) {
+ if (file->dev == dev) {
+ if (protocol_version >= 28)
+ flags |= SAME_DEV;
+ }
+ else
+ dev = file->dev;
+ flags |= HAS_INODE_DATA;
+ }
for (l1 = 0;
lastname[l1] && (fname[l1] == lastname[l1]) && (l1 < 255);
for (l1 = 0;
lastname[l1] && (fname[l1] == lastname[l1]) && (l1 < 255);
@@
-420,7
+434,7
@@
static void send_file_entry(struct file_struct *file, int f,
/* We must make sure we don't send a zero flags byte or
* the other end will terminate the flist transfer. */
/* We must make sure we don't send a zero flags byte or
* the other end will terminate the flist transfer. */
- if (flags == 0 && !S_ISDIR(
last_
mode))
+ if (flags == 0 && !S_ISDIR(mode))
flags |= FLAG_DELETE; /* NOTE: no meaning for non-dir */
if (protocol_version >= 28) {
if ((flags & 0xFF00) || flags == 0) {
flags |= FLAG_DELETE; /* NOTE: no meaning for non-dir */
if (protocol_version >= 28) {
if ((flags & 0xFF00) || flags == 0) {
@@
-444,41
+458,43
@@
static void send_file_entry(struct file_struct *file, int f,
write_longint(f, file->length);
if (!(flags & SAME_TIME))
write_longint(f, file->length);
if (!(flags & SAME_TIME))
- write_int(f,
last_
time);
+ write_int(f,
mod
time);
if (!(flags & SAME_MODE))
if (!(flags & SAME_MODE))
- write_int(f, to_wire_mode(
last_
mode));
+ write_int(f, to_wire_mode(mode));
if (preserve_uid && !(flags & SAME_UID)) {
if (preserve_uid && !(flags & SAME_UID)) {
- add_uid(
last_
uid);
- write_int(f,
last_
uid);
+ add_uid(uid);
+ write_int(f, uid);
}
if (preserve_gid && !(flags & SAME_GID)) {
}
if (preserve_gid && !(flags & SAME_GID)) {
- add_gid(
last_
gid);
- write_int(f,
last_
gid);
+ add_gid(gid);
+ write_int(f, gid);
}
}
- if (preserve_devices && IS_DEVICE(last_mode)) {
- /* If SAME_HIGH_RDEV is off, OLD_SAME_RDEV is also off. */
+ if (preserve_devices && IS_DEVICE(mode)) {
+ /* If SAME_HIGH_RDEV is off, SAME_RDEV_pre28 is also off.
+ * Also, avoid using "rdev" because it may be incomplete. */
if (!(flags & SAME_HIGH_RDEV))
if (!(flags & SAME_HIGH_RDEV))
- write_int(f,
last_
rdev);
+ write_int(f,
file->
rdev);
else if (protocol_version >= 28)
else if (protocol_version >= 28)
- write_byte(f,
last_
rdev);
+ write_byte(f,
file->
rdev);
}
#if SUPPORT_LINKS
}
#if SUPPORT_LINKS
- if (preserve_links && S_ISLNK(
last_
mode)) {
+ if (preserve_links && S_ISLNK(mode)) {
write_int(f, strlen(file->link));
write_buf(f, file->link, strlen(file->link));
}
#endif
#if SUPPORT_HARD_LINKS
write_int(f, strlen(file->link));
write_buf(f, file->link, strlen(file->link));
}
#endif
#if SUPPORT_HARD_LINKS
- if (
preserve_hard_links && S_ISREG(file->mode)
) {
+ if (
flags & HAS_INODE_DATA
) {
if (protocol_version < 26) {
/* 32-bit dev_t and ino_t */
if (protocol_version < 26) {
/* 32-bit dev_t and ino_t */
- write_int(f,
(int) file->
dev);
- write_int(f,
(int)
file->inode);
+ write_int(f, dev);
+ write_int(f, file->inode);
} else {
/* 64-bit dev_t and ino_t */
} else {
/* 64-bit dev_t and ino_t */
- write_longint(f, file->dev);
+ if (!(flags & SAME_DEV))
+ write_longint(f, dev);
write_longint(f, file->inode);
}
}
write_longint(f, file->inode);
}
}
@@
-502,11
+518,12
@@
static void send_file_entry(struct file_struct *file, int f,
static void receive_file_entry(struct file_struct **fptr,
unsigned short flags, int f)
{
static void receive_file_entry(struct file_struct **fptr,
unsigned short flags, int f)
{
- static time_t last_time;
- static mode_t last_mode;
- static DEV64_T last_rdev;
- static uid_t last_uid;
- static gid_t last_gid;
+ static time_t modtime;
+ static mode_t mode;
+ static DEV64_T rdev; /* just high bytes after p28 */
+ static uid_t uid;
+ static gid_t gid;
+ static DEV64_T dev;
static char lastname[MAXPATHLEN];
char thisname[MAXPATHLEN];
unsigned int l1 = 0, l2 = 0;
static char lastname[MAXPATHLEN];
char thisname[MAXPATHLEN];
unsigned int l1 = 0, l2 = 0;
@@
-568,42
+585,40
@@
static void receive_file_entry(struct file_struct **fptr,
file->flags = flags;
file->length = read_longint(f);
if (!(flags & SAME_TIME))
file->flags = flags;
file->length = read_longint(f);
if (!(flags & SAME_TIME))
-
last_
time = (time_t)read_int(f);
- file->modtime =
last_
time;
+
mod
time = (time_t)read_int(f);
+ file->modtime =
mod
time;
if (!(flags & SAME_MODE))
if (!(flags & SAME_MODE))
-
last_
mode = from_wire_mode(read_int(f));
- file->mode =
last_
mode;
+ mode = from_wire_mode(read_int(f));
+ file->mode = mode;
if (preserve_uid) {
if (!(flags & SAME_UID))
if (preserve_uid) {
if (!(flags & SAME_UID))
-
last_
uid = (uid_t)read_int(f);
- file->uid =
last_
uid;
+ uid = (uid_t)read_int(f);
+ file->uid = uid;
}
if (preserve_gid) {
if (!(flags & SAME_GID))
}
if (preserve_gid) {
if (!(flags & SAME_GID))
-
last_
gid = (gid_t)read_int(f);
- file->gid =
last_
gid;
+ gid = (gid_t)read_int(f);
+ file->gid = gid;
}
if (preserve_devices) {
if (protocol_version < 28) {
}
if (preserve_devices) {
if (protocol_version < 28) {
- if (IS_DEVICE(
last_
mode)) {
- if (!(flags &
OLD_SAME_RDEV
))
-
last_
rdev = (DEV64_T)read_int(f);
- file->rdev =
last_
rdev;
+ if (IS_DEVICE(mode)) {
+ if (!(flags &
SAME_RDEV_pre28
))
+ rdev = (DEV64_T)read_int(f);
+ file->rdev = rdev;
} else
} else
- last_rdev = 0;
- } else if (IS_DEVICE(last_mode)) {
- if (!(flags & SAME_HIGH_RDEV))
- last_rdev = (DEV64_T)read_int(f);
- else {
- last_rdev = (DEV64_T)((last_rdev & ~0xFF)
- | read_byte(f));
- }
- file->rdev = last_rdev;
+ rdev = 0;
+ } else if (IS_DEVICE(mode)) {
+ if (!(flags & SAME_HIGH_RDEV)) {
+ file->rdev = (DEV64_T)read_int(f);
+ rdev = file->rdev & ~0xFF;
+ } else
+ file->rdev = rdev | (DEV64_T)read_byte(f);
}
}
}
}
- if (preserve_links && S_ISLNK(
last_
mode)) {
+ if (preserve_links && S_ISLNK(mode)) {
int l = read_int(f);
if (l < 0) {
rprintf(FERROR, "overflow: l=%d\n", l);
int l = read_int(f);
if (l < 0) {
rprintf(FERROR, "overflow: l=%d\n", l);
@@
-617,14
+632,19
@@
static void receive_file_entry(struct file_struct **fptr,
sanitize_path(file->link, file->dirname);
}
#if SUPPORT_HARD_LINKS
sanitize_path(file->link, file->dirname);
}
#if SUPPORT_HARD_LINKS
- if (preserve_hard_links && S_ISREG(file->mode)) {
+ if (preserve_hard_links && protocol_version < 28
+ && S_ISREG(mode))
+ file->flags |= HAS_INODE_DATA;
+ if (file->flags & HAS_INODE_DATA) {
if (protocol_version < 26) {
if (protocol_version < 26) {
-
file->
dev = read_int(f);
+ dev = read_int(f);
file->inode = read_int(f);
} else {
file->inode = read_int(f);
} else {
- file->dev = read_longint(f);
+ if (!(flags & SAME_DEV))
+ dev = read_longint(f);
file->inode = read_longint(f);
}
file->inode = read_longint(f);
}
+ file->dev = dev;
}
#endif
}
#endif
@@
-780,8
+800,14
@@
struct file_struct *make_file(char *fname, struct string_area **ap,
file->mode = st.st_mode;
file->uid = st.st_uid;
file->gid = st.st_gid;
file->mode = st.st_mode;
file->uid = st.st_uid;
file->gid = st.st_gid;
- file->dev = st.st_dev;
- file->inode = st.st_ino;
+ if (preserve_hard_links) {
+ if (protocol_version < 28? S_ISREG(st.st_mode)
+ : !S_ISDIR(st.st_mode) && st.st_nlink > 1) {
+ file->dev = st.st_dev;
+ file->inode = st.st_ino;
+ file->flags |= HAS_INODE_DATA;
+ }
+ }
#ifdef HAVE_STRUCT_STAT_ST_RDEV
file->rdev = st.st_rdev;
#endif
#ifdef HAVE_STRUCT_STAT_ST_RDEV
file->rdev = st.st_rdev;
#endif