extern int no_detach;
extern int default_af_hint;
extern char *bind_address;
-extern struct exclude_struct **server_exclude_list;
+extern struct exclude_list_struct server_exclude_list;
extern char *exclude_path_prefix;
extern char *config_file;
int start_socket_client(char *host, char *path, int argc, char *argv[])
{
int fd, ret;
- char *p, *user=NULL;
+ char *p, *user = NULL;
/* this is redundant with code in start_inband_exchange(), but
* this short-circuits a problem before we open a socket, and
*p = 0;
}
- if (verbose >= 2) {
- /* FIXME: If we're going to use a socket program for
- * testing, then this message is wrong. We need to
- * say something like "(except really using %s)" */
- rprintf(FINFO, "opening tcp connection to %s port %d\n",
- host, rsync_port);
- }
fd = open_socket_out_wrapped(host, rsync_port, bind_address,
default_af_hint);
- if (fd == -1) {
+ if (fd == -1)
exit_cleanup(RERR_SOCKETIO);
- }
ret = start_inband_exchange(user, path, fd, fd, argc);
return -1;
}
- if (!user) user = getenv("USER");
- if (!user) user = getenv("LOGNAME");
+ if (!user)
+ user = getenv("USER");
+ if (!user)
+ user = getenv("LOGNAME");
/* set daemon_over_rsh to false since we need to build the
* true set of args passed through the rsh/ssh connection;
io_printf(f_out, "@RSYNCD: %d\n", protocol_version);
- if (!read_line(f_in, line, sizeof(line)-1)) {
+ if (!read_line(f_in, line, sizeof line - 1)) {
rprintf(FERROR, "rsync: did not see server greeting\n");
return -1;
}
kludge_around_eof = list_only && (protocol_version < 25);
while (1) {
- if (!read_line(f_in, line, sizeof(line)-1)) {
+ if (!read_line(f_in, line, sizeof line - 1)) {
rprintf(FERROR, "rsync: didn't get server startup line\n");
return -1;
}
continue;
}
- if (strcmp(line,"@RSYNCD: OK") == 0) break;
+ if (strcmp(line,"@RSYNCD: OK") == 0)
+ break;
if (strcmp(line,"@RSYNCD: EXIT") == 0) {
/* This is sent by recent versions of the
static int rsync_module(int f_in, int f_out, int i)
{
- int argc=0;
+ int argc = 0;
char *argv[MAX_ARGS];
char **argp;
char line[MAXPATHLEN];
char *host = client_name(f_in);
char *name = lp_name(i);
int use_chroot = lp_use_chroot(i);
- int start_glob=0;
+ int start_glob = 0;
int ret;
- char *request=NULL;
+ char *request = NULL;
if (!allow_access(addr, host, lp_hosts_allow(i), lp_hosts_deny(i))) {
rprintf(FERROR,"rsync denied on module %s from %s (%s)\n",
}
if (am_daemon && am_server) {
- rprintf(FINFO, "rsync allowed access on module %s from %s (%s)\n",
+ rprintf(FLOG, "rsync allowed access on module %s from %s (%s)\n",
name, host, addr);
}
if (!claim_connection(lp_lock_file(i), lp_max_connections(i))) {
if (errno) {
- rprintf(FERROR,"failed to open lock file %s : %s\n",
- lp_lock_file(i), strerror(errno));
- io_printf(f_out, "@ERROR: failed to open lock file %s : %s\n",
- lp_lock_file(i), strerror(errno));
+ rsyserr(FERROR, errno, "failed to open lock file %s",
+ lp_lock_file(i));
+ io_printf(f_out, "@ERROR: failed to open lock file %s\n",
+ lp_lock_file(i));
} else {
rprintf(FERROR,"max connections (%d) reached\n",
lp_max_connections(i));
return -1;
}
-
auth_user = auth_server(f_in, f_out, i, addr, "@RSYNCD: AUTHREQD ");
if (!auth_user) {
if (am_root) {
p = lp_uid(i);
if (!name_to_uid(p, &uid)) {
- if (!isdigit(* (unsigned char *) p)) {
+ if (!isdigit(*(unsigned char *)p)) {
rprintf(FERROR,"Invalid uid %s\n", p);
io_printf(f_out, "@ERROR: invalid uid %s\n", p);
return -1;
p = lp_gid(i);
if (!name_to_gid(p, &gid)) {
- if (!isdigit(* (unsigned char *) p)) {
+ if (!isdigit(*(unsigned char *)p)) {
rprintf(FERROR,"Invalid gid %s\n", p);
io_printf(f_out, "@ERROR: invalid gid %s\n", p);
return -1;
exclude_path_prefix = "";
p = lp_include_from(i);
- add_exclude_file(&server_exclude_list, p, MISSING_FATAL, ADD_INCLUDE);
+ add_exclude_file(&server_exclude_list, p,
+ XFLG_FATAL_ERRORS | XFLG_DEF_INCLUDE);
p = lp_include(i);
- add_exclude_line(&server_exclude_list, p, ADD_INCLUDE);
+ add_exclude(&server_exclude_list, p,
+ XFLG_WORD_SPLIT | XFLG_DEF_INCLUDE);
p = lp_exclude_from(i);
- add_exclude_file(&server_exclude_list, p, MISSING_FATAL, ADD_EXCLUDE);
+ add_exclude_file(&server_exclude_list, p,
+ XFLG_FATAL_ERRORS);
p = lp_exclude(i);
- add_exclude_line(&server_exclude_list, p, ADD_EXCLUDE);
+ add_exclude(&server_exclude_list, p, XFLG_WORD_SPLIT);
exclude_path_prefix = NULL;
* all their supplementary groups. */
if (setgid(gid)) {
- rsyserr(FERROR, errno, "setgid %d failed", (int) gid);
+ rsyserr(FERROR, errno, "setgid %d failed", (int)gid);
io_printf(f_out, "@ERROR: setgid failed\n");
return -1;
}
#endif
if (setuid(uid)) {
- rsyserr(FERROR, errno, "setuid %d failed", (int) uid);
+ rsyserr(FERROR, errno, "setuid %d failed", (int)uid);
io_printf(f_out, "@ERROR: setuid failed\n");
return -1;
}
argv[argc++] = "rsyncd";
while (1) {
- if (!read_line(f_in, line, sizeof(line)-1)) {
+ if (!read_line(f_in, line, sizeof line - 1))
return -1;
- }
- if (!*line) break;
+ if (!*line)
+ break;
p = line;
- argv[argc] = strdup(p);
- if (!argv[argc]) {
+ if (!(argv[argc] = strdup(p)))
return -1;
- }
if (start_glob) {
if (start_glob == 1) {
start_glob++;
}
glob_expand(name, argv, &argc, MAX_ARGS);
- } else {
+ } else
argc++;
- }
- if (strcmp(line,".") == 0) {
+ if (strcmp(line, ".") == 0)
start_glob = 1;
- }
- if (argc == MAX_ARGS) {
+ if (argc == MAX_ARGS)
return -1;
- }
- }
-
- if (sanitize_paths) {
- /*
- * Note that this is applied to all parameters, whether or not
- * they are filenames, but no other legal parameters contain
- * the forms that need to be sanitized so it doesn't hurt;
- * it is not known at this point which parameters are files
- * and which aren't.
- */
- for (i = 1; i < argc; i++) {
- sanitize_path(argv[i], NULL);
- }
}
argp = argv;
if (request) {
if (*auth_user) {
- rprintf(FINFO,"rsync %s %s from %s@%s (%s)\n",
- am_sender?"on":"to",
+ rprintf(FLOG, "rsync %s %s from %s@%s (%s)\n",
+ am_sender ? "on" : "to",
request, auth_user, host, addr);
} else {
- rprintf(FINFO,"rsync %s %s from %s (%s)\n",
- am_sender?"on":"to",
+ rprintf(FLOG, "rsync %s %s from %s (%s)\n",
+ am_sender ? "on" : "to",
request, host, addr);
}
free(request);
exit_cleanup(RERR_UNSUPPORTED);
}
- if (lp_timeout(i)) {
+ if (lp_timeout(i))
io_timeout = lp_timeout(i);
- }
start_server(f_in, f_out, argc, argp);
int n = lp_numservices();
int i;
- for (i=0;i<n;i++)
+ for (i = 0; i < n; i++)
if (lp_list(i))
io_printf(fd, "%-15s\t%s\n", lp_name(i), lp_comment(i));
char *motd;
int i = -1;
- if (!lp_load(config_file, 0)) {
+ if (!lp_load(config_file, 0))
exit_cleanup(RERR_SYNTAX);
- }
log_init();
if (motd && *motd) {
FILE *f = fopen(motd,"r");
while (f && !feof(f)) {
- int len = fread(line, 1, sizeof(line)-1, f);
+ int len = fread(line, 1, sizeof line - 1, f);
if (len > 0) {
line[len] = 0;
io_printf(f_out, "%s", line);
}
}
- if (f) fclose(f);
+ if (f)
+ fclose(f);
io_printf(f_out, "\n");
}
- if (!read_line(f_in, line, sizeof(line)-1)) {
+ if (!read_line(f_in, line, sizeof line - 1))
return -1;
- }
if (sscanf(line,"@RSYNCD: %d", &remote_protocol) != 1) {
io_printf(f_out, "@ERROR: protocol startup error\n");
while (i == -1) {
line[0] = 0;
- if (!read_line(f_in, line, sizeof(line)-1)) {
+ if (!read_line(f_in, line, sizeof line - 1))
return -1;
- }
- if (!*line || strcmp(line,"#list")==0) {
+ if (!*line || strcmp(line,"#list") == 0) {
send_listing(f_out);
return -1;
}
/* we are running via inetd - close off stdout and
* stderr so that library functions (and getopt) don't
* try to use them. Redirect them to /dev/null */
- for (i=1;i<3;i++) {
+ for (i = 1; i < 3; i++) {
close(i);
open("/dev/null", O_RDWR);
}
if (!no_detach)
become_daemon();
- if (!lp_load(config_file, 1)) {
+ if (!lp_load(config_file, 1))
exit_cleanup(RERR_SYNTAX);
- }
log_init();
- rprintf(FINFO, "rsyncd version %s starting, listening on port %d\n",
+ rprintf(FLOG, "rsyncd version %s starting, listening on port %d\n",
RSYNC_VERSION, rsync_port);
/* TODO: If listening on a particular address, then show that
* address too. In fact, why not just do inet_ntop on the
Matt McCutchen's Web Site / rsync / rsync.git / blobdiff