Fix copyright.

[rsync/rsync.git] / authenticate.c

diff --git a/authenticate.c b/authenticate.c
index 4058220..d2b74cd 100644 (file)
--- a/authenticate.c
+++ b/authenticate.c
@@ -105,8 +105,8 @@ static int get_secret(int module, char *user, char *secret, int len)
 
        while (!found) {
                int i = 0;
-               memset(line, 0, sizeof(line));
-               while (i<(sizeof(line)-1)) {
+               memset(line, 0, sizeof line);
+               while ((size_t) i < (sizeof(line)-1)) {
                        if (read(fd, &line[i], 1) != 1) {
                                memset(line, 0, sizeof(line));
                                close(fd);
@@ -272,6 +272,9 @@ void auth_client(int fd, char *user, char *challenge)
        if (!user || !*user) return;
 
        if (!(pass=getpassf(password_file)) && !(pass=getenv("RSYNC_PASSWORD"))) {
+               /* XXX: cyeoh says that getpass is deprecated, because
+                  it may return a truncated password on some systems,
+                  and it is not in the LSB. */
                pass = getpass("Password: ");
        }