/** @file flist.c
* Generate and receive file lists
*
- * @todo Get rid of the string_area optimization. Efficiently
- * allocating blocks is the responsibility of the system's malloc
- * library, not of rsync.
- *
* @sa http://lists.samba.org/pipermail/rsync/2000-June/002351.html
*
**/
int io_error;
-static struct file_struct null_file;
static char empty_sum[MD4_SUM_LENGTH];
+static unsigned int min_file_struct_len;
static void clean_flist(struct file_list *flist, int strip_root, int no_dups);
+void init_flist(void)
+{
+ struct file_struct f;
+
+ /* Figure out how big the file_struct is without trailing padding */
+ min_file_struct_len = ((char*)&f.flags - (char*)&f) + sizeof f.flags;
+}
+
+
static int show_filelist_p(void)
{
return verbose && (recurse || files_from) && !am_server;
}
-static struct string_area *string_area_new(int size)
-{
- struct string_area *a;
-
- if (size <= 0)
- size = ARENA_SIZE;
- a = new(struct string_area);
- if (!a)
- out_of_memory("string_area_new");
- a->current = a->base = new_array(char, size);
- if (!a->current)
- out_of_memory("string_area_new buffer");
- a->end = a->base + size;
- a->next = NULL;
-
- return a;
-}
-
-static void string_area_free(struct string_area *a)
-{
- struct string_area *next;
-
- for (; a; a = next) {
- next = a->next;
- free(a->base);
- }
-}
-
-static char *string_area_malloc(struct string_area **ap, int size)
-{
- char *p;
- struct string_area *a;
-
- /* does the request fit into the current space? */
- a = *ap;
- if (a->current + size >= a->end) {
- /* no; get space, move new string_area to front of the list */
- a = string_area_new(size > ARENA_SIZE ? size : ARENA_SIZE);
- a->next = *ap;
- *ap = a;
- }
-
- /* have space; do the "allocation." */
- p = a->current;
- a->current += size;
- return p;
-}
-
-static char *string_area_strdup(struct string_area **ap, const char *src)
-{
- char *dest = string_area_malloc(ap, strlen(src) + 1);
- return strcpy(dest, src);
-}
-
static void list_file_entry(struct file_struct *f)
{
char perms[11];
permstring(perms, f->mode);
+#if SUPPORT_LINKS
if (preserve_links && S_ISLNK(f->mode)) {
rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
perms,
(double) f->length, timestring(f->modtime),
f_name(f), f->u.link);
- } else {
+ } else
+#endif
rprintf(FINFO, "%s %11.0f %s %s\n",
perms,
(double) f->length, timestring(f->modtime),
f_name(f));
- }
}
static int to_wire_mode(mode_t mode)
{
+#if SUPPORT_LINKS
if (S_ISLNK(mode) && (_S_IFLNK != 0120000))
return (mode & ~(_S_IFMT)) | 0120000;
+#endif
return (int) mode;
}
}
if (verbose >= 2) {
- rprintf(FINFO, "expand file_list to %.0f bytes, did%s move\n",
- (double)sizeof(flist->files[0])
- * flist->malloced,
- (new_ptr == flist->files) ? " not" : "");
+ rprintf(FINFO, "[%s] expand file_list to %.0f bytes, did%s move\n",
+ who_am_i(),
+ (double) sizeof flist->files[0] * flist->malloced,
+ (new_ptr == flist->files) ? " not" : "");
}
flist->files = (struct file_struct **) new_ptr;
unsigned short flags;
static time_t modtime;
static mode_t mode;
- static DEV64_T rdev; /* just high bytes in p28 onward */
+ static DEV64_T rdev, rdev_high;
static DEV64_T dev;
static uid_t uid;
static gid_t gid;
if (!file) {
write_byte(f, 0);
modtime = 0, mode = 0;
- rdev = 0, dev = 0;
+ rdev = 0, rdev_high = 0, dev = 0;
uid = 0, gid = 0;
*lastname = '\0';
return;
} else
rdev = 0;
} else if (IS_DEVICE(mode)) {
- if ((file->u.rdev & ~0xFF) == rdev)
+ if ((file->u.rdev & ~0xFF) == rdev_high)
flags |= XMIT_SAME_HIGH_RDEV;
- else
- rdev = file->u.rdev & ~0xFF;
+ else {
+ rdev = file->u.rdev;
+ rdev_high = rdev & ~0xFF;
+ }
}
}
if (file->uid == uid)
flags |= XMIT_SAME_TIME;
else
modtime = file->modtime;
+
+#if SUPPORT_HARD_LINKS
if (file->link_u.idev) {
if (file->F_DEV == dev) {
if (protocol_version >= 28)
dev = file->F_DEV;
flags |= XMIT_HAS_IDEV_DATA;
}
+#endif
for (l1 = 0;
lastname[l1] && (fname[l1] == lastname[l1]) && (l1 < 255);
if (l2 > 255)
flags |= XMIT_LONG_NAME;
- /* We must make sure we don't send a zero flags byte or
- * the other end will terminate the flist transfer. */
- if (flags == 0 && !S_ISDIR(mode))
- flags |= XMIT_TOP_DIR; /* NOTE: no meaning for non-dir */
+ /* We must make sure we don't send a zero flag byte or the
+ * other end will terminate the flist transfer. Note that
+ * the use of XMIT_TOP_DIR on a non-dir has no meaning, so
+ * it's harmless way to add a bit to the first flag byte. */
if (protocol_version >= 28) {
- if ((flags & 0xFF00) || flags == 0) {
+ if (!flags && !S_ISDIR(mode))
+ flags |= XMIT_TOP_DIR;
+ if ((flags & 0xFF00) || !flags) {
flags |= XMIT_EXTENDED_FLAGS;
write_byte(f, flags);
write_byte(f, flags >> 8);
} else
write_byte(f, flags);
} else {
- if (flags == 0)
+ if (!(flags & 0xFF) && !S_ISDIR(mode))
+ flags |= XMIT_TOP_DIR;
+ if (!(flags & 0xFF))
flags |= XMIT_LONG_NAME;
write_byte(f, flags);
}
}
if (preserve_devices && IS_DEVICE(mode)) {
/* If XMIT_SAME_HIGH_RDEV is off, XMIT_SAME_RDEV_pre28 is
- * also off. Also, avoid using "rdev" because it may be
- * incomplete. */
+ * also off. */
if (!(flags & XMIT_SAME_HIGH_RDEV))
- write_int(f, file->u.rdev);
+ write_int(f, rdev);
else if (protocol_version >= 28)
- write_byte(f, file->u.rdev);
+ write_byte(f, rdev);
}
#if SUPPORT_LINKS
if (preserve_links && S_ISLNK(mode)) {
- write_int(f, strlen(file->u.link));
- write_buf(f, file->u.link, strlen(file->u.link));
+ int len = strlen(file->u.link);
+ write_int(f, len);
+ write_buf(f, file->u.link, len);
}
#endif
{
static time_t modtime;
static mode_t mode;
- static DEV64_T rdev; /* just high bytes in p28 onward */
+ static DEV64_T rdev, rdev_high;
static DEV64_T dev;
static uid_t uid;
static gid_t gid;
- static char lastname[MAXPATHLEN];
+ static char lastname[MAXPATHLEN], *lastdir;
+ static int lastdir_len = -1;
char thisname[MAXPATHLEN];
unsigned int l1 = 0, l2 = 0;
- char *p;
+ int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
+ int file_struct_len, idev_len;
+ OFF_T file_length;
+ char *basename, *dirname, *bp;
struct file_struct *file;
if (!fptr) {
modtime = 0, mode = 0;
- rdev = 0, dev = 0;
+ rdev = 0, rdev_high = 0, dev = 0;
uid = 0, gid = 0;
*lastname = '\0';
return;
else
l2 = read_byte(f);
- file = new(struct file_struct);
- if (!file)
- out_of_memory("receive_file_entry");
- memset((char *) file, 0, sizeof(*file));
- (*fptr) = file;
-
if (l2 >= MAXPATHLEN - l1) {
rprintf(FERROR,
"overflow: flags=0x%x l1=%d l2=%d lastname=%s\n",
thisname[l1 + l2] = 0;
strlcpy(lastname, thisname, MAXPATHLEN);
- lastname[MAXPATHLEN - 1] = 0;
clean_fname(thisname);
- if (sanitize_paths) {
+ if (sanitize_paths)
sanitize_path(thisname, NULL);
- }
- if ((p = strrchr(thisname, '/'))) {
- static char *lastdir;
- *p = 0;
- if (lastdir && strcmp(thisname, lastdir) == 0)
- file->dirname = lastdir;
- else {
- file->dirname = strdup(thisname);
- lastdir = file->dirname;
- }
- file->basename = strdup(p + 1);
+ if ((basename = strrchr(thisname, '/')) != NULL) {
+ dirname_len = ++basename - thisname; /* counts future '\0' */
+ if (lastdir_len == dirname_len - 1
+ && strncmp(thisname, lastdir, lastdir_len) == 0) {
+ dirname = lastdir;
+ dirname_len = 0; /* indicates no copy is needed */
+ } else
+ dirname = thisname;
} else {
- file->dirname = NULL;
- file->basename = strdup(thisname);
+ basename = thisname;
+ dirname = NULL;
+ dirname_len = 0;
}
+ basename_len = strlen(basename) + 1; /* count the '\0' */
- if (!file->basename)
- out_of_memory("receive_file_entry 1");
-
- file->flags = flags & XMIT_TOP_DIR ? FLAG_TOP_DIR : 0;
- file->length = read_longint(f);
+ file_length = read_longint(f);
if (!(flags & XMIT_SAME_TIME))
modtime = (time_t)read_int(f);
- file->modtime = modtime;
if (!(flags & XMIT_SAME_MODE))
mode = from_wire_mode(read_int(f));
- file->mode = mode;
- if (preserve_uid) {
- if (!(flags & XMIT_SAME_UID))
- uid = (uid_t)read_int(f);
- file->uid = uid;
- }
- if (preserve_gid) {
- if (!(flags & XMIT_SAME_GID))
- gid = (gid_t)read_int(f);
- file->gid = gid;
- }
+ if (preserve_uid && !(flags & XMIT_SAME_UID))
+ uid = (uid_t)read_int(f);
+ if (preserve_gid && !(flags & XMIT_SAME_GID))
+ gid = (gid_t)read_int(f);
+
if (preserve_devices) {
if (protocol_version < 28) {
if (IS_DEVICE(mode)) {
if (!(flags & XMIT_SAME_RDEV_pre28))
rdev = (DEV64_T)read_int(f);
- file->u.rdev = rdev;
} else
rdev = 0;
} else if (IS_DEVICE(mode)) {
if (!(flags & XMIT_SAME_HIGH_RDEV)) {
- file->u.rdev = (DEV64_T)read_int(f);
- rdev = file->u.rdev & ~0xFF;
+ rdev = (DEV64_T)read_int(f);
+ rdev_high = rdev & ~0xFF;
} else
- file->u.rdev = rdev | (DEV64_T)read_byte(f);
+ rdev = rdev_high | (DEV64_T)read_byte(f);
}
}
+#if SUPPORT_LINKS
if (preserve_links && S_ISLNK(mode)) {
- int l = read_int(f);
- if (l < 0) {
- rprintf(FERROR, "overflow: l=%d\n", l);
+ linkname_len = read_int(f) + 1; /* count the '\0' */
+ if (linkname_len <= 0 || linkname_len > MAXPATHLEN) {
+ rprintf(FERROR, "overflow: linkname_len=%d\n",
+ linkname_len - 1);
overflow("receive_file_entry");
}
- if (!(file->u.link = new_array(char, l + 1)))
- out_of_memory("receive_file_entry 2");
- read_sbuf(f, file->u.link, l);
- if (sanitize_paths)
- sanitize_path(file->u.link, file->dirname);
}
+ else
+#endif
+ linkname_len = 0;
+
#if SUPPORT_HARD_LINKS
if (preserve_hard_links && protocol_version < 28 && S_ISREG(mode))
flags |= XMIT_HAS_IDEV_DATA;
- if (flags & XMIT_HAS_IDEV_DATA) {
- if (!(file->link_u.idev = new(struct idev)))
- out_of_memory("file inode data");
+ if (flags & XMIT_HAS_IDEV_DATA)
+ idev_len = sizeof (struct idev);
+ else
+#endif
+ idev_len = 0;
+
+ sum_len = always_checksum && S_ISREG(mode) ? MD4_SUM_LENGTH : 0;
+ file_struct_len = idev_len? sizeof file[0] : min_file_struct_len;
+
+ alloc_len = file_struct_len + dirname_len + basename_len
+ + linkname_len + sum_len + idev_len;
+ if (!(bp = new_array(char, alloc_len)))
+ out_of_memory("receive_file_entry");
+ file = *fptr = (struct file_struct *)bp;
+ memset(bp, 0, min_file_struct_len);
+ bp += file_struct_len;
+
+ file->flags = flags & XMIT_TOP_DIR ? FLAG_TOP_DIR : 0;
+ file->modtime = modtime;
+ file->length = file_length;
+ file->mode = mode;
+ file->uid = uid;
+ file->gid = gid;
+
+#if SUPPORT_HARD_LINKS
+ if (idev_len) {
+ file->link_u.idev = (struct idev *)bp;
+ bp += idev_len;
+ }
+#endif
+
+ if (dirname_len) {
+ file->dirname = lastdir = bp;
+ lastdir_len = dirname_len - 1;
+ memcpy(bp, dirname, dirname_len - 1);
+ bp += dirname_len;
+ bp[-1] = '\0';
+ } else if (dirname)
+ file->dirname = dirname;
+
+ file->basename = bp;
+ memcpy(bp, basename, basename_len);
+ bp += basename_len;
+
+ if (preserve_devices && IS_DEVICE(mode))
+ file->u.rdev = rdev;
+
+#if SUPPORT_LINKS
+ if (linkname_len) {
+ file->u.link = bp;
+ read_sbuf(f, bp, linkname_len - 1);
+ if (sanitize_paths)
+ sanitize_path(bp, lastdir);
+ bp += linkname_len;
+ }
+#endif
+
+#if SUPPORT_HARD_LINKS
+ if (idev_len) {
if (protocol_version < 26) {
dev = read_int(f);
file->F_INODE = read_int(f);
if (always_checksum) {
char *sum;
- if (S_ISREG(mode)) {
- sum = file->u.sum = new_array(char, MD4_SUM_LENGTH);
- if (!sum)
- out_of_memory("md4 sum");
+ if (sum_len) {
+ file->u.sum = sum = bp;
+ /*bp += sum_len;*/
} else if (protocol_version < 28) {
/* Prior to 28, we get a useless set of nulls. */
sum = empty_sum;
}
-#define STRDUP(ap, p) (ap ? string_area_strdup(ap, p) : strdup(p))
-/* IRIX cc cares that the operands to the ternary have the same type. */
-#define MALLOC(ap, i) (ap ? (void*) string_area_malloc(ap, i) : malloc(i))
-
/**
* Create a file_struct for a named file by reading its stat()
* information and performing extensive checks against global
* statting directories if we're not recursing, but this is not a very
* important case. Some systems may not have d_type.
**/
-struct file_struct *make_file(char *fname, struct string_area **ap,
- int exclude_level)
+struct file_struct *make_file(char *fname, int exclude_level)
{
+ static char *lastdir;
+ static int lastdir_len = -1;
struct file_struct *file;
STRUCT_STAT st;
char sum[SUM_LENGTH];
- char *p;
- char cleaned_name[MAXPATHLEN];
- char linkbuf[MAXPATHLEN];
+ char thisname[MAXPATHLEN];
+ char linkname[MAXPATHLEN];
+ int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
+ int file_struct_len, idev_len;
+ char *basename, *dirname, *bp;
unsigned short flags = 0;
- if (strlcpy(cleaned_name, fname, sizeof cleaned_name)
- >= sizeof cleaned_name - flist_dir_len) {
+ if (strlcpy(thisname, fname, sizeof thisname)
+ >= sizeof thisname - flist_dir_len) {
rprintf(FINFO, "skipping overly long name: %s\n", fname);
return NULL;
}
- clean_fname(cleaned_name);
+ clean_fname(thisname);
if (sanitize_paths)
- sanitize_path(cleaned_name, NULL);
- fname = cleaned_name;
+ sanitize_path(thisname, NULL);
memset(sum, 0, SUM_LENGTH);
- if (readlink_stat(fname, &st, linkbuf) != 0) {
+ if (readlink_stat(thisname, &st, linkname) != 0) {
int save_errno = errno;
if (errno == ENOENT && exclude_level != NO_EXCLUDES) {
/* either symlink pointing nowhere or file that
* was removed during rsync run; see if excluded
* before reporting an error */
- if (check_exclude_file(fname, 0, exclude_level)) {
+ if (check_exclude_file(thisname, 0, exclude_level)) {
/* file is excluded anyway, ignore silently */
return NULL;
}
}
io_error |= IOERR_GENERAL;
rprintf(FERROR, "readlink %s failed: %s\n",
- full_fname(fname), strerror(save_errno));
+ full_fname(thisname), strerror(save_errno));
return NULL;
}
goto skip_excludes;
if (S_ISDIR(st.st_mode) && !recurse && !files_from) {
- rprintf(FINFO, "skipping directory %s\n", fname);
+ rprintf(FINFO, "skipping directory %s\n", thisname);
return NULL;
}
flags |= FLAG_MOUNT_POINT;
}
- if (check_exclude_file(fname, S_ISDIR(st.st_mode) != 0, exclude_level))
+ if (check_exclude_file(thisname, S_ISDIR(st.st_mode) != 0, exclude_level))
return NULL;
- if (lp_ignore_nonreadable(module_id) && access(fname, R_OK) != 0)
+ if (lp_ignore_nonreadable(module_id) && access(thisname, R_OK) != 0)
return NULL;
skip_excludes:
- if (verbose > 2)
- rprintf(FINFO, "make_file(%s,*,%d)\n", fname, exclude_level);
+ if (verbose > 2) {
+ rprintf(FINFO, "[%s] make_file(%s,*,%d)\n",
+ who_am_i(), thisname, exclude_level);
+ }
- file = new(struct file_struct);
- if (!file)
- out_of_memory("make_file");
- memset((char *) file, 0, sizeof(*file));
- file->flags = flags;
+ if ((basename = strrchr(thisname, '/')) != NULL) {
+ dirname_len = ++basename - thisname; /* counts future '\0' */
+ if (lastdir_len == dirname_len - 1
+ && strncmp(thisname, lastdir, lastdir_len) == 0) {
+ dirname = lastdir;
+ dirname_len = 0; /* indicates no copy is needed */
+ } else
+ dirname = thisname;
+ } else {
+ basename = thisname;
+ dirname = NULL;
+ dirname_len = 0;
+ }
+ basename_len = strlen(basename) + 1; /* count the '\0' */
- if ((p = strrchr(fname, '/'))) {
- static char *lastdir;
- *p = 0;
- if (lastdir && strcmp(fname, lastdir) == 0)
- file->dirname = lastdir;
- else {
- file->dirname = strdup(fname);
- lastdir = file->dirname;
+#if SUPPORT_LINKS
+ linkname_len = S_ISLNK(st.st_mode) ? strlen(linkname) + 1 : 0;
+#else
+ linkname_len = 0;
+#endif
+
+ idev_len = 0;
+#if SUPPORT_HARD_LINKS
+ if (preserve_hard_links && st.st_nlink > 1) {
+ if (protocol_version < 28) {
+ if (S_ISREG(st.st_mode))
+ idev_len = sizeof (struct idev);
+ } else {
+ if (!S_ISDIR(st.st_mode))
+ idev_len = sizeof (struct idev);
}
- file->basename = STRDUP(ap, p + 1);
- *p = '/';
- } else {
- file->dirname = NULL;
- file->basename = STRDUP(ap, fname);
}
+#endif
+
+ sum_len = always_checksum && S_ISREG(st.st_mode) ? MD4_SUM_LENGTH : 0;
+ file_struct_len = idev_len? sizeof file[0] : min_file_struct_len;
+ alloc_len = file_struct_len + dirname_len + basename_len
+ + linkname_len + sum_len + idev_len;
+ if (!(bp = new_array(char, alloc_len)))
+ out_of_memory("receive_file_entry");
+ file = (struct file_struct *)bp;
+ memset(bp, 0, min_file_struct_len);
+ bp += file_struct_len;
+
+ file->flags = flags;
file->modtime = st.st_mtime;
file->length = st.st_size;
file->mode = st.st_mode;
file->uid = st.st_uid;
file->gid = st.st_gid;
- if (preserve_hard_links) {
- if (protocol_version < 28 ? S_ISREG(st.st_mode)
- : !S_ISDIR(st.st_mode) && st.st_nlink > 1) {
- if (!(file->link_u.idev = new(struct idev)))
- out_of_memory("file inode data");
- file->F_DEV = st.st_dev;
- file->F_INODE = st.st_ino;
- }
+
+#if SUPPORT_HARD_LINKS
+ if (idev_len) {
+ file->link_u.idev = (struct idev *)bp;
+ bp += idev_len;
+ file->F_DEV = st.st_dev;
+ file->F_INODE = st.st_ino;
}
+#endif
+
+ if (dirname_len) {
+ file->dirname = lastdir = bp;
+ lastdir_len = dirname_len - 1;
+ memcpy(bp, dirname, dirname_len - 1);
+ bp += dirname_len;
+ bp[-1] = '\0';
+ } else if (dirname)
+ file->dirname = dirname;
+
+ file->basename = bp;
+ memcpy(bp, basename, basename_len);
+ bp += basename_len;
+
#ifdef HAVE_STRUCT_STAT_ST_RDEV
- if (IS_DEVICE(st.st_mode))
+ if (preserve_devices && IS_DEVICE(st.st_mode))
file->u.rdev = st.st_rdev;
#endif
#if SUPPORT_LINKS
- if (S_ISLNK(st.st_mode))
- file->u.link = STRDUP(ap, linkbuf);
+ if (linkname_len) {
+ file->u.link = bp;
+ memcpy(bp, linkname, linkname_len);
+ bp += linkname_len;
+ }
#endif
- if (always_checksum && S_ISREG(st.st_mode)) {
- if (!(file->u.sum = (char*)MALLOC(ap, MD4_SUM_LENGTH)))
- out_of_memory("md4 sum");
- file_checksum(fname, file->u.sum, st.st_size);
+ if (sum_len) {
+ file->u.sum = bp;
+ file_checksum(thisname, bp, st.st_size);
+ /*bp += sum_len;*/
}
file->basedir = flist_dir;
extern int delete_excluded;
/* f is set to -1 when calculating deletion file list */
- file = make_file(fname, &flist->string_area,
+ file = make_file(fname,
f == -1 && delete_excluded? SERVER_EXCLUDES
: ALL_EXCLUDES);
flist_dir = lastdir;
flist_dir_len = lastdir_len;
} else {
- if (lastdir)
- free(lastdir);
flist_dir = lastdir = strdup(dir);
flist_dir_len = lastdir_len = strlen(dir);
}
/*
- * free up one file
+ * Free up any resources a file_struct has allocated, and optionally free
+ * it up as well.
*/
-void free_file(struct file_struct *file)
+void free_file(struct file_struct *file, int free_the_struct)
{
- if (!file)
- return;
- if (file->basename)
- free(file->basename);
- if (!IS_DEVICE(file->mode) && file->u.link)
- free(file->u.link); /* Handles u.sum too. */
- if (file->link_u.idev)
- free((char*)file->link_u.idev); /* Handles link_u.links too. */
- *file = null_file;
+ if (free_the_struct)
+ free(file);
+ else
+ memset(file, 0, min_file_struct_len);
}
flist->malloced = 0;
flist->files = NULL;
-#if ARENA_SIZE > 0
- flist->string_area = string_area_new(0);
-#else
- flist->string_area = NULL;
-#endif
return flist;
}
void flist_free(struct file_list *flist)
{
int i;
- for (i = 1; i < flist->count; i++) {
- if (!flist->string_area)
- free_file(flist->files[i]);
- free(flist->files[i]);
- }
- /* FIXME: I don't think we generally need to blank the flist
- * since it's about to be freed. This will just cause more
- * memory traffic. If you want a freed-memory debugger, you
- * know where to get it. */
- memset((char *) flist->files, 0,
- sizeof(flist->files[0]) * flist->count);
+ for (i = 1; i < flist->count; i++)
+ free_file(flist->files[i], FREE_STRUCT);
free(flist->files);
- if (flist->string_area)
- string_area_free(flist->string_area);
- memset((char *) flist, 0, sizeof(*flist));
free(flist);
}
return;
qsort(flist->files, flist->count,
- sizeof(flist->files[0]), (int (*)()) file_compare);
+ sizeof flist->files[0], (int (*)()) file_compare);
for (i = no_dups? 0 : flist->count; i < flist->count; i++) {
if (flist->files[i]->basename) {
* else deletions will mysteriously fail with -R). */
if (flist->files[i]->flags & FLAG_TOP_DIR)
flist->files[prev_i]->flags |= FLAG_TOP_DIR;
- /* it's not great that the flist knows the semantics of
- * the file memory usage, but i'd rather not add a flag
- * byte to that struct.
- * XXX can i use a bit in the flags field? */
- if (flist->string_area)
- flist->files[i][0] = null_file;
- else
- free_file(flist->files[i]);
+ free_file(flist->files[i], CLEAR_STRUCT);
} else
prev_i = i;
}
return;
for (i = 0; i < flist->count; i++) {
- rprintf(FINFO, "[%ld] i=%d %s %s mode=0%o len=%.0f\n",
- (long) getpid(), i,
+ rprintf(FINFO, "[%s] i=%d %s %s %s mode=0%o len=%.0f\n",
+ who_am_i(), i,
+ NS(flist->files[i]->basedir),
NS(flist->files[i]->dirname),
NS(flist->files[i]->basename),
(int) flist->files[i]->mode,