Use preserve_[ug]id values for send/recv checking, which will
[rsync/rsync.git] / generator.c
index 5ba5579..f4f15bb 100644 (file)
@@ -27,6 +27,7 @@ extern int dry_run;
 extern int do_xfers;
 extern int stdout_format_has_i;
 extern int logfile_format_has_i;
+extern int receiver_symlink_times;
 extern int am_root;
 extern int am_server;
 extern int am_daemon;
@@ -41,6 +42,7 @@ extern int preserve_links;
 extern int preserve_devices;
 extern int preserve_specials;
 extern int preserve_hard_links;
+extern int preserve_executability;
 extern int preserve_perms;
 extern int preserve_times;
 extern int uid_ndx;
@@ -84,20 +86,19 @@ extern int list_only;
 extern int read_batch;
 extern int safe_symlinks;
 extern long block_size; /* "long" because popt can't set an int32. */
+extern int unsort_ndx;
 extern int max_delete;
 extern int force_delete;
 extern int one_file_system;
 extern struct stats stats;
 extern dev_t filesystem_dev;
 extern mode_t orig_umask;
+extern uid_t our_uid;
 extern char *backup_dir;
 extern char *backup_suffix;
 extern int backup_suffix_len;
 extern struct file_list *cur_flist, *first_flist, *dir_flist;
 extern struct filter_list_struct server_filter_list;
-#ifdef ICONV_OPTION
-extern int ic_ndx;
-#endif
 
 int ignore_perishable = 0;
 int non_perishable_cnt = 0;
@@ -115,8 +116,16 @@ static int need_retouch_dir_perms;
 static const char *solo_file = NULL;
 
 /* For calling delete_item() and delete_dir_contents(). */
-#define DEL_RECURSE            (1<<1) /* recurse */
+#define DEL_OWNED_BY_US        (1<<0) /* file/dir has our uid */
+#define DEL_RECURSE            (1<<1) /* if dir, delete all contents */
 #define DEL_DIR_IS_EMPTY       (1<<2) /* internal delete_FUNCTIONS use only */
+#define DEL_FOR_FILE           (1<<3) /* making room for a replacement file */
+#define DEL_FOR_DIR            (1<<4) /* making room for a replacement dir */
+#define DEL_FOR_SYMLINK        (1<<5) /* making room for a replacement symlink */
+#define DEL_FOR_DEVICE         (1<<6) /* making room for a replacement device */
+#define DEL_FOR_SPECIAL        (1<<7) /* making room for a replacement special */
+
+#define DEL_MAKE_ROOM (DEL_FOR_FILE|DEL_FOR_DIR|DEL_FOR_SYMLINK|DEL_FOR_DEVICE|DEL_FOR_SPECIAL)
 
 enum nonregtype {
     TYPE_DIR, TYPE_SPECIAL, TYPE_DEVICE, TYPE_SYMLINK
@@ -129,7 +138,6 @@ enum delret {
 /* Forward declaration for delete_item(). */
 static enum delret delete_dir_contents(char *fname, int flags);
 
-
 static int is_backup_file(char *fn)
 {
        int k = strlen(fn) - backup_suffix_len;
@@ -142,7 +150,7 @@ static int is_backup_file(char *fn)
  * Note that fbuf must point to a MAXPATHLEN buffer if the mode indicates it's
  * a directory! (The buffer is used for recursion, but returned unchanged.)
  */
-static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
+static enum delret delete_item(char *fbuf, int mode, int flags)
 {
        enum delret ret;
        char *what;
@@ -153,6 +161,9 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
                        fbuf, mode, flags);
        }
 
+       if (!am_root && !(mode & S_IWUSR) && flags & DEL_OWNED_BY_US)
+               do_chmod(fbuf, mode |= S_IWUSR);
+
        if (S_ISDIR(mode) && !(flags & DEL_DIR_IS_EMPTY)) {
                ignore_perishable = 1;
                /* If DEL_RECURSE is not set, this just reports emptiness. */
@@ -163,7 +174,7 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
                /* OK: try to delete the directory. */
        }
 
-       if (!replace && max_delete >= 0 && ++deletion_count > max_delete)
+       if (!(flags & DEL_MAKE_ROOM) && max_delete >= 0 && ++deletion_count > max_delete)
                return DR_AT_LIMIT;
 
        if (S_ISDIR(mode)) {
@@ -178,7 +189,7 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
        }
 
        if (ok) {
-               if (!replace)
+               if (!(flags & DEL_MAKE_ROOM))
                        log_delete(fbuf, mode);
                ret = DR_SUCCESS;
        } else {
@@ -197,9 +208,18 @@ static enum delret delete_item(char *fbuf, int mode, char *replace, int flags)
        }
 
   check_ret:
-       if (replace && ret != DR_SUCCESS) {
-               rprintf(FERROR, "could not make way for new %s: %s\n",
-                       replace, fbuf);
+       if (ret != DR_SUCCESS && flags & DEL_MAKE_ROOM) {
+               const char *desc;
+               switch (flags & DEL_MAKE_ROOM) {
+               case DEL_FOR_FILE: desc = "regular file"; break;
+               case DEL_FOR_DIR: desc = "directory"; break;
+               case DEL_FOR_SYMLINK: desc = "symlink"; break;
+               case DEL_FOR_DEVICE: desc = "device file"; break;
+               case DEL_FOR_SPECIAL: desc = "special file"; break;
+               default: exit_cleanup(RERR_UNSUPPORTED); /* IMPOSSIBLE */
+               }
+               rprintf(FERROR_XFER, "could not make way for new %s: %s\n",
+                       desc, fbuf);
        }
        return ret;
 }
@@ -244,7 +264,7 @@ static enum delret delete_dir_contents(char *fname, int flags)
        remainder = MAXPATHLEN - (p - fname);
 
        /* We do our own recursion, so make delete_item() non-recursive. */
-       flags = (flags & ~DEL_RECURSE) | DEL_DIR_IS_EMPTY;
+       flags = (flags & ~(DEL_RECURSE|DEL_MAKE_ROOM)) | DEL_DIR_IS_EMPTY;
 
        for (j = dirlist->used; j--; ) {
                struct file_struct *fp = dirlist->files[j];
@@ -260,11 +280,18 @@ static enum delret delete_dir_contents(char *fname, int flags)
                }
 
                strlcpy(p, fp->basename, remainder);
+               if (!uid_ndx || (uid_t)F_OWNER(fp) == our_uid)
+                       flags |= DEL_OWNED_BY_US;
+               else
+                       flags &= ~DEL_OWNED_BY_US;
                /* Save stack by recursing to ourself directly. */
-               if (S_ISDIR(fp->mode)
-                && delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS)
-                       ret = DR_NOT_EMPTY;
-               if (delete_item(fname, fp->mode, NULL, flags) != DR_SUCCESS)
+               if (S_ISDIR(fp->mode)) {
+                       if (!am_root && !(fp->mode & S_IWUSR) && flags & DEL_OWNED_BY_US)
+                               do_chmod(fname, fp->mode |= S_IWUSR);
+                       if (delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS)
+                               ret = DR_NOT_EMPTY;
+               }
+               if (delete_item(fname, fp->mode, flags) != DR_SUCCESS)
                        ret = DR_NOT_EMPTY;
        }
 
@@ -314,14 +341,17 @@ static int flush_delete_delay(void)
        return 1;
 }
 
-static int remember_delete(struct file_struct *file, const char *fname)
+static int remember_delete(struct file_struct *file, const char *fname, int flags)
 {
+       const char *plus = (!am_root && !(file->mode & S_IWUSR) && flags & DEL_OWNED_BY_US)
+                        ? "+" : "";
        int len;
 
        while (1) {
                len = snprintf(deldelay_buf + deldelay_cnt,
                               deldelay_size - deldelay_cnt,
-                              "%x %s%c", (int)file->mode, fname, '\0');
+                              "%s%x %s%c",
+                              plus, (int)file->mode, fname, '\0');
                if ((deldelay_cnt += len) <= deldelay_size)
                        break;
                if (deldelay_fd < 0 && !start_delete_delay_temp())
@@ -334,7 +364,7 @@ static int remember_delete(struct file_struct *file, const char *fname)
        return 1;
 }
 
-static int read_delay_line(char *buf)
+static int read_delay_line(char *buf, int *own_flag_p)
 {
        static int read_pos = 0;
        int j, len, mode;
@@ -375,6 +405,11 @@ static int read_delay_line(char *buf)
        }
 
        bp = deldelay_buf + read_pos;
+       if (*bp == '+') {
+               bp++;
+               *own_flag_p = DEL_OWNED_BY_US;
+       } else
+               *own_flag_p = 0;
 
        if (sscanf(bp, "%x ", &mode) != 1) {
          invalid_data:
@@ -399,15 +434,15 @@ static int read_delay_line(char *buf)
 
 static void do_delayed_deletions(char *delbuf)
 {
-       int mode;
+       int mode, own_flag;
 
        if (deldelay_fd >= 0) {
                if (deldelay_cnt && !flush_delete_delay())
                        return;
                lseek(deldelay_fd, 0, 0);
        }
-       while ((mode = read_delay_line(delbuf)) >= 0)
-               delete_item(delbuf, mode, NULL, DEL_RECURSE);
+       while ((mode = read_delay_line(delbuf, &own_flag)) >= 0)
+               delete_item(delbuf, mode, own_flag | DEL_RECURSE);
        if (deldelay_fd >= 0)
                close(deldelay_fd);
 }
@@ -469,12 +504,14 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
                        continue;
                }
                if (flist_find(cur_flist, fp) < 0) {
+                       int flags = DEL_RECURSE
+                                 | (!uid_ndx || (uid_t)F_OWNER(fp) == our_uid ? DEL_OWNED_BY_US : 0);
                        f_name(fp, delbuf);
                        if (delete_during == 2) {
-                               if (!remember_delete(fp, delbuf))
+                               if (!remember_delete(fp, delbuf, flags))
                                        break;
                        } else
-                               delete_item(delbuf, fp->mode, NULL, DEL_RECURSE);
+                               delete_item(delbuf, fp->mode, flags);
                }
        }
 
@@ -517,7 +554,7 @@ static void do_delete_pass(void)
 
 int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp)
 {
-#if !defined HAVE_LCHMOD && !defined HAVE_SETATTRLIST
+#if !defined HAVE_LUTIMES || !defined HAVE_UTIMES
        if (S_ISLNK(file->mode)) {
                ;
        } else
@@ -528,6 +565,9 @@ int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp)
        if (preserve_perms && !BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
                return 0;
 
+       if (preserve_executability && ((sxp->st.st_mode & 0111 ? 1 : 0) ^ (file->mode & 0111 ? 1 : 0)))
+               return 0;
+
        if (am_root && uid_ndx && sxp->st.st_uid != (uid_t)F_OWNER(file))
                return 0;
 
@@ -560,8 +600,11 @@ void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statre
 {
        if (statret >= 0) { /* A from-dest-dir statret can == 1! */
                int keep_time = !preserve_times ? 0
-                   : S_ISDIR(file->mode) ? preserve_times > 1
-                   : !S_ISLNK(file->mode);
+                   : S_ISDIR(file->mode) ? preserve_times > 1 :
+#if defined HAVE_LUTIMES && defined HAVE_UTIMES
+                   (receiver_symlink_times && !(file->flags & FLAG_TIME_FAILED)) ||
+#endif
+                   !S_ISLNK(file->mode);
 
                if (S_ISREG(file->mode) && F_LENGTH(file) != sxp->st.st_size)
                        iflags |= ITEM_REPORT_SIZE;
@@ -575,7 +618,8 @@ void itemize(const char *fnamecmp, struct file_struct *file, int ndx, int statre
                        ;
                } else
 #endif
-               if (!BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
+               if ((preserve_perms || preserve_executability)
+                && !BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
                        iflags |= ITEM_REPORT_PERMS;
                if (uid_ndx && am_root && (uid_t)F_OWNER(file) != sxp->st.st_uid)
                        iflags |= ITEM_REPORT_OWNER;
@@ -843,7 +887,7 @@ static int copy_altdest_file(const char *src, const char *dest, struct file_stru
 {
        char buf[MAXPATHLEN];
        const char *copy_to, *partialptr;
-       int fd_w;
+       int ok, fd_w;
 
        if (inplace) {
                /* Let copy_file open the destination in place. */
@@ -867,11 +911,9 @@ static int copy_altdest_file(const char *src, const char *dest, struct file_stru
                return -1;
        }
        partialptr = partial_dir ? partial_dir_fname(dest) : NULL;
-       if (partialptr && *partialptr == '/')
-               partialptr = NULL;
-       finish_transfer(dest, copy_to, src, partialptr, file, 1, 0);
+       ok = finish_transfer(dest, copy_to, src, partialptr, file, 1, 0);
        cleanup_disable();
-       return 0;
+       return ok ? 0 : -1;
 }
 
 /* This is only called for regular files.  We return -2 if we've finished
@@ -903,9 +945,6 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
                case 2:
                        if (!unchanged_attrs(cmpbuf, file, sxp))
                                continue;
-                       if (always_checksum > 0 && preserve_times
-                        && cmp_time(sxp->st.st_mtime, file->modtime))
-                               continue;
                        best_match = j;
                        match_level = 3;
                        break;
@@ -930,7 +969,7 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
                                goto try_a_copy;
                        if (preserve_hard_links && F_IS_HLINKED(file))
                                finish_hard_link(file, fname, ndx, &sxp->st, itemizing, code, j);
-                       if (itemizing && (verbose > 1 || stdout_format_has_i > 1)) {
+                       if (!maybe_ATTRS_REPORT && (verbose > 1 || stdout_format_has_i > 1)) {
                                itemize(cmpbuf, file, ndx, 1, sxp,
                                        ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS,
                                        0, "");
@@ -952,10 +991,6 @@ static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
                        return -1;
                if (itemizing)
                        itemize(cmpbuf, file, ndx, 0, sxp, ITEM_LOCAL_CHANGE, 0, NULL);
-#ifdef SUPPORT_XATTRS
-               if (preserve_xattrs)
-                       xattr_clear_locals(file);
-#endif
                if (maybe_ATTRS_REPORT
                 && ((!itemizing && verbose && match_level == 2)
                  || (verbose > 1 && match_level == 3))) {
@@ -1087,7 +1122,7 @@ static int try_dests_non(struct file_struct *file, char *fname, int ndx,
 #endif
                 && !S_ISDIR(file->mode)) {
                        if (do_link(cmpbuf, fname) < 0) {
-                               rsyserr(FERROR, errno,
+                               rsyserr(FERROR_XFER, errno,
                                        "failed to hard-link %s with %s",
                                        cmpbuf, fname);
                                return j;
@@ -1176,38 +1211,40 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
        uchar fnamecmp_type;
        int implied_dirs_are_missing = relative_paths && !implied_dirs && protocol_version < 30;
        int del_opts = delete_mode || force_delete ? DEL_RECURSE : 0;
+       int is_dir = !S_ISDIR(file->mode) ? 0
+                  : inc_recurse && ndx != cur_flist->ndx_start - 1 ? -1
+                  : 1;
 
        if (verbose > 2)
                rprintf(FINFO, "recv_generator(%s,%d)\n", fname, ndx);
 
        if (list_only) {
-               if (S_ISDIR(file->mode)
-                && ((!implied_dirs && file->flags & FLAG_IMPLIED_DIR)
-                 || (inc_recurse && ndx != cur_flist->ndx_start - 1)))
+               if (is_dir < 0
+                || (is_dir && !implied_dirs && file->flags & FLAG_IMPLIED_DIR))
                        return;
                list_file_entry(file);
                return;
        }
 
        if (server_filter_list.head) {
+               int filtered = check_filter(&server_filter_list, fname, is_dir) < 0;
+               if (is_dir < 0 && filtered)
+                       return;
                if (excluded_below >= 0) {
                        if (F_DEPTH(file) > excluded_below
                         && (!implied_dirs_are_missing || f_name_has_prefix(file, excluded_dir)))
                                goto skipping;
                        excluded_below = -1;
                }
-               if (check_filter(&server_filter_list, fname,
-                                S_ISDIR(file->mode)) < 0) {
-                       if (S_ISDIR(file->mode)) {
+               if (filtered) {
+                       if (is_dir) {
                                excluded_below = F_DEPTH(file);
                                excluded_dir = file;
                        }
                  skipping:
-                       if (verbose) {
-                               rprintf(FINFO,
-                                       "skipping server-excluded file \"%s\"\n",
-                                       fname);
-                       }
+                       rprintf(FERROR_XFER,
+                               "skipping daemon-excluded file \"%s\"\n",
+                               fname);
                        return;
                }
        }
@@ -1219,7 +1256,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                dry_run--;
                        missing_below = -1;
                } else if (!dry_run) {
-                       if (S_ISDIR(file->mode))
+                       if (is_dir)
                                file->flags |= FLAG_MISSING_DIR;
                        return;
                }
@@ -1244,7 +1281,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        if (relative_paths && !implied_dirs
                         && do_stat(dn, &sx.st) < 0
                         && create_directory_path(fname) < 0) {
-                               rsyserr(FERROR, errno,
+                               rsyserr(FERROR_XFER, errno,
                                        "recv_generator: mkdir %s failed",
                                        full_fname(dn));
                        }
@@ -1267,18 +1304,14 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        need_fuzzy_dirlist = 0;
                }
 
-               statret = link_stat(fname, &sx.st,
-                                   keep_dirlinks && S_ISDIR(file->mode));
+               statret = link_stat(fname, &sx.st, keep_dirlinks && is_dir);
                stat_errno = errno;
        }
 
        if (ignore_non_existing > 0 && statret == -1 && stat_errno == ENOENT) {
-               if (verbose > 1) {
-                       rprintf(FINFO, "not creating new %s \"%s\"\n",
-                               S_ISDIR(file->mode) ? "directory" : "file",
-                               fname);
-               }
-               if (S_ISDIR(file->mode)) {
+               if (is_dir) {
+                       if (is_dir < 0)
+                               return;
                        if (missing_below < 0) {
                                if (dry_run)
                                        dry_run++;
@@ -1287,13 +1320,20 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        }
                        file->flags |= FLAG_MISSING_DIR;
                }
+               if (verbose > 1) {
+                       rprintf(FINFO, "not creating new %s \"%s\"\n",
+                               is_dir ? "directory" : "file", fname);
+               }
                return;
        }
 
-       if (S_ISDIR(file->mode)) {
+       if (statret == 0 && sx.st.st_uid == our_uid)
+               del_opts |= DEL_OWNED_BY_US;
+
+       if (is_dir) {
                if (!implied_dirs && file->flags & FLAG_IMPLIED_DIR)
                        goto cleanup;
-               if (inc_recurse && ndx != cur_flist->ndx_start - 1) {
+               if (is_dir < 0) {
                        /* In inc_recurse mode we want to make sure any missing
                         * directories get created while we're still processing
                         * the parent dir (which allows us to touch the parent
@@ -1301,7 +1341,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                         * full later (right before we handle its contents). */
                        if (statret == 0
                         && (S_ISDIR(sx.st.st_mode)
-                         || delete_item(fname, sx.st.st_mode, "directory", del_opts) != 0))
+                         || delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_DIR) != 0))
                                goto cleanup; /* Any errors get reported later. */
                        if (do_mkdir(fname, file->mode & 0700) == 0)
                                file->flags |= FLAG_DIR_CREATED;
@@ -1313,7 +1353,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                 * we need to delete it.  If it doesn't exist, then
                 * (perhaps recursively) create it. */
                if (statret == 0 && !S_ISDIR(sx.st.st_mode)) {
-                       if (delete_item(fname, sx.st.st_mode, "directory", del_opts) != 0)
+                       if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_DIR) != 0)
                                goto skipping_dir_contents;
                        statret = -1;
                }
@@ -1347,7 +1387,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        if (!relative_paths || errno != ENOENT
                            || create_directory_path(fname) < 0
                            || (do_mkdir(fname, file->mode) < 0 && errno != EEXIST)) {
-                               rsyserr(FERROR, errno,
+                               rsyserr(FERROR_XFER, errno,
                                        "recv_generator: mkdir %s failed",
                                        full_fname(fname));
                          skipping_dir_contents:
@@ -1370,7 +1410,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                if (!am_root && !(file->mode & S_IWUSR) && dir_tweaking) {
                        mode_t mode = file->mode | S_IWUSR;
                        if (do_chmod(fname, mode) < 0) {
-                               rsyserr(FERROR, errno,
+                               rsyserr(FERROR_XFER, errno,
                                        "failed to modify permissions on %s",
                                        full_fname(fname));
                        }
@@ -1432,7 +1472,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                set_file_attrs(fname, file, &sx, NULL, maybe_ATTRS_REPORT);
                                if (itemizing)
                                        itemize(fname, file, ndx, 0, &sx, 0, 0, NULL);
-#ifdef SUPPORT_HARD_LINKS
+#if defined SUPPORT_HARD_LINKS && defined CAN_HARDLINK_SYMLINK
                                if (preserve_hard_links && F_IS_HLINKED(file))
                                        finish_hard_link(file, fname, ndx, &sx.st, itemizing, code, -1);
 #endif
@@ -1442,7 +1482,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        }
                        /* Not the right symlink (or not a symlink), so
                         * delete it. */
-                       if (delete_item(fname, sx.st.st_mode, "symlink", del_opts) != 0)
+                       if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_SYMLINK) != 0)
                                goto cleanup;
                } else if (basis_dir[0] != NULL) {
                        int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
@@ -1467,7 +1507,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                }
 #endif
                if (do_symlink(sl, fname) != 0) {
-                       rsyserr(FERROR, errno, "symlink %s -> \"%s\" failed",
+                       rsyserr(FERROR_XFER, errno, "symlink %s -> \"%s\" failed",
                                full_fname(fname), sl);
                } else {
                        set_file_attrs(fname, file, NULL, NULL, 0);
@@ -1496,15 +1536,15 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                uint32 *devp = F_RDEV_P(file);
                dev_t rdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
                if (statret == 0) {
-                       char *t;
+                       int del_for_flag;
                        if (IS_DEVICE(file->mode)) {
                                if (!IS_DEVICE(sx.st.st_mode))
                                        statret = -1;
-                               t = "device file";
+                               del_for_flag = DEL_FOR_DEVICE;
                        } else {
                                if (!IS_SPECIAL(sx.st.st_mode))
                                        statret = -1;
-                               t = "special file";
+                               del_for_flag = DEL_FOR_SPECIAL;
                        }
                        if (statret == 0
                         && BITS_EQUAL(sx.st.st_mode, file->mode, _S_IFMT)
@@ -1521,7 +1561,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                        goto return_with_success;
                                goto cleanup;
                        }
-                       if (delete_item(fname, sx.st.st_mode, t, del_opts) != 0)
+                       if (delete_item(fname, sx.st.st_mode, del_opts | del_for_flag) != 0)
                                goto cleanup;
                } else if (basis_dir[0] != NULL) {
                        int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
@@ -1551,7 +1591,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                                (long)major(rdev), (long)minor(rdev));
                }
                if (do_mknod(fname, file->mode, rdev) < 0) {
-                       rsyserr(FERROR, errno, "mknod %s failed",
+                       rsyserr(FERROR_XFER, errno, "mknod %s failed",
                                full_fname(fname));
                } else {
                        set_file_attrs(fname, file, NULL, NULL, 0);
@@ -1612,7 +1652,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
        fnamecmp_type = FNAMECMP_FNAME;
 
        if (statret == 0 && !S_ISREG(sx.st.st_mode)) {
-               if (delete_item(fname, sx.st.st_mode, "regular file", del_opts) != 0)
+               if (delete_item(fname, sx.st.st_mode, del_opts | DEL_FOR_FILE) != 0)
                        goto cleanup;
                statret = -1;
                stat_errno = ENOENT;
@@ -1669,7 +1709,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
 #endif
                if (stat_errno == ENOENT)
                        goto notify_others;
-               rsyserr(FERROR, stat_errno, "recv_generator: failed to stat %s",
+               rsyserr(FERROR_XFER, stat_errno, "recv_generator: failed to stat %s",
                        full_fname(fname));
                goto cleanup;
        }
@@ -1759,7 +1799,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                        goto pretend_missing;
                }
                if (robust_unlink(backupptr) && errno != ENOENT) {
-                       rsyserr(FERROR, errno, "unlink %s",
+                       rsyserr(FERROR_XFER, errno, "unlink %s",
                                full_fname(backupptr));
                        unmake_file(back_file);
                        back_file = NULL;
@@ -1769,7 +1809,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
                if ((f_copy = do_open(backupptr, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0
                 && (errno != ENOENT || make_bak_dir(backupptr) < 0
                  || (f_copy = do_open(backupptr, O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0)) {
-                       rsyserr(FERROR, errno, "open %s",
+                       rsyserr(FERROR_XFER, errno, "open %s",
                                full_fname(backupptr));
                        unmake_file(back_file);
                        back_file = NULL;
@@ -1904,57 +1944,63 @@ void check_for_finished_files(int itemizing, enum logcode code, int check_redo)
        char fbuf[MAXPATHLEN];
        int ndx;
 
+       while (1) {
 #ifdef SUPPORT_HARD_LINKS
-       while (preserve_hard_links && (ndx = get_hlink_num()) != -1) {
-               flist = flist_for_ndx(ndx);
-               assert(flist != NULL);
-               file = flist->files[ndx - flist->ndx_start];
-               assert(file->flags & FLAG_HLINKED);
-               finish_hard_link(file, f_name(file, fbuf), ndx, NULL, itemizing, code, -1);
-               flist->in_progress--;
-       }
+               if (preserve_hard_links && (ndx = get_hlink_num()) != -1) {
+                       flist = flist_for_ndx(ndx);
+                       assert(flist != NULL);
+                       file = flist->files[ndx - flist->ndx_start];
+                       assert(file->flags & FLAG_HLINKED);
+                       finish_hard_link(file, f_name(file, fbuf), ndx, NULL, itemizing, code, -1);
+                       flist->in_progress--;
+                       continue;
+               }
 #endif
 
-       while (check_redo && (ndx = get_redo_num()) != -1) {
-               csum_length = SUM_LENGTH;
-               max_size = -max_size;
-               min_size = -min_size;
-               ignore_existing = -ignore_existing;
-               ignore_non_existing = -ignore_non_existing;
-               update_only = -update_only;
-               always_checksum = -always_checksum;
-               size_only = -size_only;
-               append_mode = -append_mode;
-               make_backups = -make_backups; /* avoid dup backup w/inplace */
-               ignore_times++;
-
-               flist = cur_flist;
-               cur_flist = flist_for_ndx(ndx);
-
-               file = cur_flist->files[ndx - cur_flist->ndx_start];
-               if (solo_file)
-                       strlcpy(fbuf, solo_file, sizeof fbuf);
-               else
-                       f_name(file, fbuf);
-               recv_generator(fbuf, file, ndx, itemizing, code, sock_f_out);
-               cur_flist->to_redo--;
-
-               cur_flist = flist;
-
-               csum_length = SHORT_SUM_LENGTH;
-               max_size = -max_size;
-               min_size = -min_size;
-               ignore_existing = -ignore_existing;
-               ignore_non_existing = -ignore_non_existing;
-               update_only = -update_only;
-               always_checksum = -always_checksum;
-               size_only = -size_only;
-               append_mode = -append_mode;
-               make_backups = -make_backups;
-               ignore_times--;
-       }
-
-       while (cur_flist != first_flist) { /* only possible with inc_recurse */
+               if (check_redo && (ndx = get_redo_num()) != -1) {
+                       csum_length = SUM_LENGTH;
+                       max_size = -max_size;
+                       min_size = -min_size;
+                       ignore_existing = -ignore_existing;
+                       ignore_non_existing = -ignore_non_existing;
+                       update_only = -update_only;
+                       always_checksum = -always_checksum;
+                       size_only = -size_only;
+                       append_mode = -append_mode;
+                       make_backups = -make_backups; /* avoid dup backup w/inplace */
+                       ignore_times++;
+
+                       flist = cur_flist;
+                       cur_flist = flist_for_ndx(ndx);
+
+                       file = cur_flist->files[ndx - cur_flist->ndx_start];
+                       if (solo_file)
+                               strlcpy(fbuf, solo_file, sizeof fbuf);
+                       else
+                               f_name(file, fbuf);
+                       recv_generator(fbuf, file, ndx, itemizing, code, sock_f_out);
+                       cur_flist->to_redo--;
+
+                       cur_flist = flist;
+
+                       csum_length = SHORT_SUM_LENGTH;
+                       max_size = -max_size;
+                       min_size = -min_size;
+                       ignore_existing = -ignore_existing;
+                       ignore_non_existing = -ignore_non_existing;
+                       update_only = -update_only;
+                       always_checksum = -always_checksum;
+                       size_only = -size_only;
+                       append_mode = -append_mode;
+                       make_backups = -make_backups;
+                       ignore_times--;
+                       continue;
+               }
+
+               if (cur_flist == first_flist)
+                       break;
+
+               /* We only get here if inc_recurse is enabled. */
                if (first_flist->in_progress || first_flist->to_redo)
                        break;
 
@@ -2045,7 +2091,7 @@ void generate_files(int f_out, const char *local_name)
                        f_name(fp, fbuf);
                        ndx = cur_flist->ndx_start - 1;
                        recv_generator(fbuf, fp, ndx, itemizing, code, f_out);
-                       if (delete_during && dry_run < 2) {
+                       if (delete_during && dry_run < 2 && !list_only) {
                                if (BITS_SETnUNSET(fp->flags, FLAG_CONTENT_DIR, FLAG_MISSING_DIR)) {
                                        dev_t dirdev;
                                        if (one_file_system) {
@@ -2063,11 +2109,9 @@ void generate_files(int f_out, const char *local_name)
                        if (!F_IS_ACTIVE(file))
                                continue;
 
-#ifdef ICONV_OPTION
-                       if (ic_ndx)
+                       if (unsort_ndx)
                                ndx = F_NDX(file);
                        else
-#endif
                                ndx = i + cur_flist->ndx_start;
 
                        if (solo_file)