Matt McCutchen's Web Site
/
rsync
/
rsync.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fixed the buffer-has-space check in write_buf().
[rsync/rsync.git]
/
main.c
diff --git
a/main.c
b/main.c
index
75e9a2f
..
038214f
100644
(file)
--- a/
main.c
+++ b/
main.c
@@
-29,6
+29,7
@@
extern int dry_run;
extern int list_only;
extern int dry_run;
extern int list_only;
+extern int io_timeout;
extern int am_root;
extern int am_server;
extern int am_sender;
extern int am_root;
extern int am_server;
extern int am_sender;
@@
-43,6
+44,7
@@
extern int kluge_around_eof;
extern int got_xfer_error;
extern int msgs2stderr;
extern int module_id;
extern int got_xfer_error;
extern int msgs2stderr;
extern int module_id;
+extern int read_only;
extern int copy_links;
extern int copy_dirlinks;
extern int copy_unsafe_links;
extern int copy_links;
extern int copy_dirlinks;
extern int copy_unsafe_links;
@@
-63,9
+65,13
@@
extern int whole_file;
extern int read_batch;
extern int write_batch;
extern int batch_fd;
extern int read_batch;
extern int write_batch;
extern int batch_fd;
+extern int sock_f_in;
+extern int sock_f_out;
extern int filesfrom_fd;
extern int connect_timeout;
extern int filesfrom_fd;
extern int connect_timeout;
+extern int send_msgs_to_gen;
extern pid_t cleanup_child_pid;
extern pid_t cleanup_child_pid;
+extern size_t bwlimit_writemax;
extern unsigned int module_dirlen;
extern struct stats stats;
extern char *stdout_format;
extern unsigned int module_dirlen;
extern struct stats stats;
extern char *stdout_format;
@@
-82,9
+88,10
@@
extern char curr_dir[MAXPATHLEN];
extern char backup_dir_buf[MAXPATHLEN];
extern char *basis_dir[MAX_BASIS_DIRS+1];
extern struct file_list *first_flist;
extern char backup_dir_buf[MAXPATHLEN];
extern char *basis_dir[MAX_BASIS_DIRS+1];
extern struct file_list *first_flist;
-extern
struct filter_list_struc
t daemon_filter_list;
+extern
filter_rule_lis
t daemon_filter_list;
uid_t our_uid;
uid_t our_uid;
+gid_t our_gid;
int am_generator = 0;
int local_server = 0;
int daemon_over_rsh = 0;
int am_generator = 0;
int local_server = 0;
int daemon_over_rsh = 0;
@@
-178,7
+185,7
@@
void write_del_stats(int f)
if (read_batch)
write_int(f, NDX_DEL_STATS);
else
if (read_batch)
write_int(f, NDX_DEL_STATS);
else
-
send_msg(MSG_DEL_STATS, "", 0, 0
);
+
write_ndx(f, NDX_DEL_STATS
);
write_varint(f, stats.deleted_files - stats.deleted_dirs
- stats.deleted_symlinks - stats.deleted_devices
- stats.deleted_specials);
write_varint(f, stats.deleted_files - stats.deleted_dirs
- stats.deleted_symlinks - stats.deleted_devices
- stats.deleted_specials);
@@
-397,7
+404,7
@@
static pid_t do_cmd(char *cmd, char *machine, char *user, char **remote_argv, in
cmd = rsh_env;
if (!cmd)
cmd = RSYNC_RSH;
cmd = rsh_env;
if (!cmd)
cmd = RSYNC_RSH;
- cmd = strdup(cmd); /*
MEMORY LEAK
*/
+ cmd = strdup(cmd); /*
MEMORY LEAK
*/
if (!cmd)
goto oom;
if (!cmd)
goto oom;
@@
-722,7
+729,7
@@
static void read_final_goodbye(int f_in, int f_out)
if (protocol_version < 29)
i = read_int(f_in);
else {
if (protocol_version < 29)
i = read_int(f_in);
else {
- i = read_ndx_and_attrs(f_in, &iflags, &fnamecmp_type, xname, &xlen);
+ i = read_ndx_and_attrs(f_in,
f_out,
&iflags, &fnamecmp_type, xname, &xlen);
if (protocol_version >= 31 && i == NDX_DONE) {
if (am_sender)
write_ndx(f_out, NDX_DONE);
if (protocol_version >= 31 && i == NDX_DONE) {
if (am_sender)
write_ndx(f_out, NDX_DONE);
@@
-731,9
+738,9
@@
static void read_final_goodbye(int f_in, int f_out)
while (read_int(batch_gen_fd) != NDX_DEL_STATS) {}
read_del_stats(batch_gen_fd);
}
while (read_int(batch_gen_fd) != NDX_DEL_STATS) {}
read_del_stats(batch_gen_fd);
}
-
send_msg(MSG_DONE, "", 0, 0
);
+
write_int(f_out, NDX_DONE
);
}
}
- i = read_ndx_and_attrs(f_in, &iflags, &fnamecmp_type, xname, &xlen);
+ i = read_ndx_and_attrs(f_in,
f_out,
&iflags, &fnamecmp_type, xname, &xlen);
}
}
}
}
@@
-759,7
+766,7
@@
static void do_server_sender(int f_in, int f_out, int argc, char *argv[])
exit_cleanup(RERR_SYNTAX);
return;
}
exit_cleanup(RERR_SYNTAX);
return;
}
- if (am_daemon &&
lp_read_only(module_id)
&& remove_source_files) {
+ if (am_daemon &&
read_only
&& remove_source_files) {
rprintf(FERROR,
"ERROR: --remove-%s-files cannot be used with a read-only module\n",
remove_source_files == 1 ? "source" : "sent");
rprintf(FERROR,
"ERROR: --remove-%s-files cannot be used with a read-only module\n",
remove_source_files == 1 ? "source" : "sent");
@@
-825,13
+832,11
@@
static int do_recv(int f_in, int f_out, char *local_name)
exit_cleanup(RERR_SYNTAX);
if (ret)
rprintf(FINFO, "Created backup_dir %s\n", backup_dir_buf);
exit_cleanup(RERR_SYNTAX);
if (ret)
rprintf(FINFO, "Created backup_dir %s\n", backup_dir_buf);
- else if (INFO_GTE(BACKUP, 1)) {
- char *dir = *backup_dir_buf ? backup_dir_buf : ".";
- rprintf(FINFO, "backup_dir is %s\n", dir);
- }
+ else if (INFO_GTE(BACKUP, 1))
+ rprintf(FINFO, "backup_dir is %s\n", backup_dir_buf);
}
}
- io_flush(
NORMA
L_FLUSH);
+ io_flush(
FUL
L_FLUSH);
if ((pid = do_fork()) == -1) {
rsyserr(FERROR, errno, "fork failed in do_recv");
if ((pid = do_fork()) == -1) {
rsyserr(FERROR, errno, "fork failed in do_recv");
@@
-839,18
+844,24
@@
static int do_recv(int f_in, int f_out, char *local_name)
}
if (pid == 0) {
}
if (pid == 0) {
+ send_msgs_to_gen = am_server;
+
close(error_pipe[0]);
close(error_pipe[0]);
+
+ /* We can't let two processes write to the socket at one time. */
+ io_end_multiplex_out(MPLX_SWITCHING);
if (f_in != f_out)
close(f_out);
if (f_in != f_out)
close(f_out);
+ sock_f_out = -1;
+ f_out = error_pipe[1];
- /* we can't let two processes write to the socket at one time */
- io_end_multiplex_out();
+ bwlimit_writemax = 0; /* receiver doesn't need to do this */
- /* set place to send errors */
-
set_msg_fd_out(error_pipe[1]
);
- io_start_
buffering_out(error_pipe[1]
);
+ if (read_batch)
+
io_start_buffering_in(f_in
);
+ io_start_
multiplex_out(f_out
);
- recv_files(f_in, local_name);
+ recv_files(f_in,
f_out,
local_name);
io_flush(FULL_FLUSH);
handle_stats(f_in);
io_flush(FULL_FLUSH);
handle_stats(f_in);
@@
-859,8
+870,8
@@
static int do_recv(int f_in, int f_out, char *local_name)
output_needs_newline = 0;
}
output_needs_newline = 0;
}
-
send_msg(MSG_DONE, "", 1, 0
);
-
write_varlong(error_pipe[1], stats.total_read, 3
);
+
write_int(f_out, NDX_DONE
);
+
send_msg(MSG_STATS, (char*)&stats.total_read, sizeof stats.total_read, 0
);
io_flush(FULL_FLUSH);
/* Handle any keep-alive packets from the post-processing work
io_flush(FULL_FLUSH);
/* Handle any keep-alive packets from the post-processing work
@@
-885,18
+896,18
@@
static int do_recv(int f_in, int f_out, char *local_name)
am_generator = 1;
am_generator = 1;
- io_end_multiplex_in();
+ io_end_multiplex_in(
MPLX_SWITCHING
);
if (write_batch && !am_server)
stop_write_batch();
close(error_pipe[1]);
if (f_in != f_out)
close(f_in);
if (write_batch && !am_server)
stop_write_batch();
close(error_pipe[1]);
if (f_in != f_out)
close(f_in);
+ sock_f_in = -1;
+ f_in = error_pipe[0];
io_start_buffering_out(f_out);
io_start_buffering_out(f_out);
-
- set_msg_fd_in(error_pipe[0]);
- io_start_buffering_in(error_pipe[0]);
+ io_start_multiplex_in(f_in);
#ifdef SUPPORT_HARD_LINKS
if (preserve_hard_links && inc_recurse) {
#ifdef SUPPORT_HARD_LINKS
if (preserve_hard_links && inc_recurse) {
@@
-916,7
+927,6
@@
static int do_recv(int f_in, int f_out, char *local_name)
}
io_flush(FULL_FLUSH);
}
io_flush(FULL_FLUSH);
- set_msg_fd_in(-1);
kill(pid, SIGUSR2);
wait_process_with_flush(pid, &exit_code);
return exit_code;
kill(pid, SIGUSR2);
wait_process_with_flush(pid, &exit_code);
return exit_code;
@@
-929,7
+939,7
@@
static void do_server_recv(int f_in, int f_out, int argc, char *argv[])
char *local_name = NULL;
int negated_levels;
char *local_name = NULL;
int negated_levels;
- if (filesfrom_fd >= 0 && !msgs2stderr) {
+ if (filesfrom_fd >= 0 && !msgs2stderr
&& protocol_version < 31
) {
/* We can't mix messages with files-from data on the socket,
* so temporarily turn off info/debug messages. */
negate_output_levels();
/* We can't mix messages with files-from data on the socket,
* so temporarily turn off info/debug messages. */
negate_output_levels();
@@
-942,7
+952,7
@@
static void do_server_recv(int f_in, int f_out, int argc, char *argv[])
argc, (long)getpid());
}
argc, (long)getpid());
}
- if (am_daemon &&
lp_read_only(module_id)
) {
+ if (am_daemon &&
read_only
) {
rprintf(FERROR,"ERROR: module is read only\n");
exit_cleanup(RERR_SYNTAX);
return;
rprintf(FERROR,"ERROR: module is read only\n");
exit_cleanup(RERR_SYNTAX);
return;
@@
-960,7
+970,7
@@
static void do_server_recv(int f_in, int f_out, int argc, char *argv[])
}
if (protocol_version >= 30)
}
if (protocol_version >= 30)
- io_start_multiplex_in();
+ io_start_multiplex_in(
f_in
);
else
io_start_buffering_in(f_in);
recv_filter_list(f_in);
else
io_start_buffering_in(f_in);
recv_filter_list(f_in);
@@
-971,7
+981,7
@@
static void do_server_recv(int f_in, int f_out, int argc, char *argv[])
* need the IO routines to automatically write out the names
* onto our f_out socket as we read the file-list. This
* avoids both deadlock and extra delays/buffers. */
* need the IO routines to automatically write out the names
* onto our f_out socket as we read the file-list. This
* avoids both deadlock and extra delays/buffers. */
-
io_set_filesfrom_fds(filesfrom_fd, f_out
);
+
start_filesfrom_forwarding(filesfrom_fd
);
filesfrom_fd = -1;
}
filesfrom_fd = -1;
}
@@
-1002,7
+1012,7
@@
static void do_server_recv(int f_in, int f_out, int argc, char *argv[])
if (daemon_filter_list.head) {
char **dir_p;
if (daemon_filter_list.head) {
char **dir_p;
-
struct filter_list_struc
t *elp = &daemon_filter_list;
+
filter_rule_lis
t *elp = &daemon_filter_list;
for (dir_p = basis_dir; *dir_p; dir_p++) {
char *dir = *dir_p;
for (dir_p = basis_dir; *dir_p; dir_p++) {
char *dir = *dir_p;
@@
-1041,12
+1051,16
@@
void start_server(int f_in, int f_out, int argc, char *argv[])
setup_protocol(f_out, f_in);
if (protocol_version >= 23)
setup_protocol(f_out, f_in);
if (protocol_version >= 23)
- io_start_multiplex_out();
+ io_start_multiplex_out(f_out);
+ if (am_daemon && io_timeout && protocol_version >= 31)
+ send_msg_int(MSG_IO_TIMEOUT, io_timeout);
if (am_sender) {
keep_dirlinks = 0; /* Must be disabled on the sender. */
if (need_messages_from_generator)
if (am_sender) {
keep_dirlinks = 0; /* Must be disabled on the sender. */
if (need_messages_from_generator)
- io_start_multiplex_in();
+ io_start_multiplex_in(f_in);
+ else
+ io_start_buffering_in(f_in);
recv_filter_list(f_in);
do_server_sender(f_in, f_out, argc, argv);
} else
recv_filter_list(f_in);
do_server_sender(f_in, f_out, argc, argv);
} else
@@
-1054,11
+1068,8
@@
void start_server(int f_in, int f_out, int argc, char *argv[])
exit_cleanup(0);
}
exit_cleanup(0);
}
-
-/*
- * This is called once the connection has been negotiated. It is used
- * for rsyncd, remote-shell, and local connections.
- */
+/* This is called once the connection has been negotiated. It is used
+ * for rsyncd, remote-shell, and local connections. */
int client_run(int f_in, int f_out, pid_t pid, int argc, char *argv[])
{
struct file_list *flist = NULL;
int client_run(int f_in, int f_out, pid_t pid, int argc, char *argv[])
{
struct file_list *flist = NULL;
@@
-1093,11
+1104,13
@@
int client_run(int f_in, int f_out, pid_t pid, int argc, char *argv[])
sender_keeps_checksum = 1;
if (protocol_version >= 30)
sender_keeps_checksum = 1;
if (protocol_version >= 30)
- io_start_multiplex_out();
+ io_start_multiplex_out(
f_out
);
else
io_start_buffering_out(f_out);
else
io_start_buffering_out(f_out);
- if (!filesfrom_host)
- set_msg_fd_in(f_in);
+ if (protocol_version >= 31 || (!filesfrom_host && protocol_version >= 23))
+ io_start_multiplex_in(f_in);
+ else
+ io_start_buffering_in(f_in);
send_filter_list(f_out);
if (filesfrom_host)
filesfrom_fd = f_in;
send_filter_list(f_out);
if (filesfrom_host)
filesfrom_fd = f_in;
@@
-1108,8
+1121,8
@@
int client_run(int f_in, int f_out, pid_t pid, int argc, char *argv[])
if (DEBUG_GTE(FLIST, 3))
rprintf(FINFO,"file list sent\n");
if (DEBUG_GTE(FLIST, 3))
rprintf(FINFO,"file list sent\n");
- if (protocol_version >= 23)
- io_start_multiplex_in();
+ if (protocol_version
< 31 && filesfrom_host && protocol_version
>= 23)
+ io_start_multiplex_in(
f_in
);
io_flush(NORMAL_FLUSH);
send_files(f_in, f_out);
io_flush(NORMAL_FLUSH);
send_files(f_in, f_out);
@@
-1130,15
+1143,17
@@
int client_run(int f_in, int f_out, pid_t pid, int argc, char *argv[])
if (!read_batch) {
if (protocol_version >= 23)
if (!read_batch) {
if (protocol_version >= 23)
- io_start_multiplex_in();
+ io_start_multiplex_in(
f_in
);
if (need_messages_from_generator)
if (need_messages_from_generator)
- io_start_multiplex_out();
+ io_start_multiplex_out(f_out);
+ else
+ io_start_buffering_out(f_out);
}
send_filter_list(read_batch ? -1 : f_out);
if (filesfrom_fd >= 0) {
}
send_filter_list(read_batch ? -1 : f_out);
if (filesfrom_fd >= 0) {
-
io_set_filesfrom_fds(filesfrom_fd, f_out
);
+
start_filesfrom_forwarding(filesfrom_fd
);
filesfrom_fd = -1;
}
filesfrom_fd = -1;
}
@@
-1185,14
+1200,12
@@
static int copy_argv(char *argv[])
}
}
-/**
- * Start a client for either type of remote connection. Work out
+/* Start a client for either type of remote connection. Work out
* whether the arguments request a remote shell or rsyncd connection,
* and call the appropriate connection function, then run_client.
*
* Calls either start_socket_client (for sockets) or do_cmd and
* whether the arguments request a remote shell or rsyncd connection,
* and call the appropriate connection function, then run_client.
*
* Calls either start_socket_client (for sockets) or do_cmd and
- * client_run (for ssh).
- **/
+ * client_run (for ssh). */
static int start_client(int argc, char *argv[])
{
char *p, *shell_machine = NULL, *shell_user = NULL;
static int start_client(int argc, char *argv[])
{
char *p, *shell_machine = NULL, *shell_user = NULL;
@@
-1487,6
+1500,7
@@
int main(int argc,char *argv[])
starttime = time(NULL);
our_uid = MY_UID();
starttime = time(NULL);
our_uid = MY_UID();
+ our_gid = MY_GID();
am_root = our_uid == 0;
memset(&stats, 0, sizeof(stats));
am_root = our_uid == 0;
memset(&stats, 0, sizeof(stats));