Added 2 new config options: "pre-xfer exec" and "post-xfer exec".
[rsync/rsync.git] / options.c
index b95e1e4..cb1e89f 100644 (file)
--- a/options.c
+++ b/options.c
@@ -21,8 +21,8 @@
 #include "rsync.h"
 #include "popt.h"
 
+extern int module_id;
 extern int sanitize_paths;
-extern int select_timeout;
 extern struct filter_list_struct filter_list;
 extern struct filter_list_struct server_filter_list;
 
@@ -38,6 +38,7 @@ int make_backups = 0;
  **/
 int whole_file = -1;
 
+int append_mode = 0;
 int archive_mode = 0;
 int keep_dirlinks = 0;
 int copy_links = 0;
@@ -52,31 +53,33 @@ int omit_dir_times = 0;
 int update_only = 0;
 int cvs_exclude = 0;
 int dry_run = 0;
-int local_server = 0;
+int do_xfers = 1;
 int ignore_times = 0;
 int delete_mode = 0;
 int delete_during = 0;
 int delete_before = 0;
 int delete_after = 0;
 int delete_excluded = 0;
+int remove_sent_files = 0;
 int one_file_system = 0;
 int protocol_version = PROTOCOL_VERSION;
 int sparse_files = 0;
 int do_compression = 0;
 int am_root = 0;
+int am_server = 0;
+int am_sender = 0;
+int am_generator = 0;
+int am_starting_up = 1;
 int orig_umask = 0;
 int relative_paths = -1;
 int implied_dirs = 1;
 int numeric_ids = 0;
 int force_delete = 0;
 int io_timeout = 0;
-int module_id = -1;
-int am_server = 0;
-int am_sender = 0;
-int am_generator = 0;
+int allowed_lull = 0;
 char *files_from = NULL;
 int filesfrom_fd = -1;
-char *remote_filesfrom_file = NULL;
+char *filesfrom_host = NULL;
 int eol_nulls = 0;
 int recurse = 0;
 int xfer_dirs = 0;
@@ -90,9 +93,11 @@ int copy_unsafe_links = 0;
 int size_only = 0;
 int daemon_bwlimit = 0;
 int bwlimit = 0;
+int fuzzy_basis = 0;
 size_t bwlimit_writemax = 0;
 int only_existing = 0;
 int opt_ignore_existing = 0;
+int need_messages_from_generator = 0;
 int max_delete = 0;
 OFF_T max_size = 0;
 int ignore_errors = 0;
@@ -114,7 +119,12 @@ int default_af_hint = AF_INET;     /* Must use IPv4 */
 /** Do not go into the background when run as --daemon.  Good
  * for debugging and required for running as a service on W32,
  * or under Unix process-monitors. **/
-int no_detach = 0;
+int no_detach
+#if defined _WIN32 || defined __WIN32__
+       = 1;
+#else
+       = 0;
+#endif
 
 int write_batch = 0;
 int read_batch = 0;
@@ -138,9 +148,13 @@ int compare_dest = 0;
 int copy_dest = 0;
 int link_dest = 0;
 int basis_dir_cnt = 0;
+char *dest_option = NULL;
 
 int verbose = 0;
 int quiet = 0;
+int log_before_transfer = 0;
+int log_format_has_i = 0;
+int log_format_has_o_or_i = 0;
 int always_checksum = 0;
 int list_only = 0;
 
@@ -150,8 +164,12 @@ char *batch_name = NULL;
 static int daemon_opt;   /* sets am_daemon after option error-reporting */
 static int F_option_cnt = 0;
 static int modify_window_set;
-static char *dest_option = NULL;
+static int itemize_changes = 0;
+static int refused_delete, refused_archive_part;
+static int refused_partial, refused_progress, refused_delete_before;
+static int refused_inplace;
 static char *max_size_arg;
+static char partialdir_for_delayupdate[] = ".~tmp~";
 
 /** Local address to bind.  As a character string because it's
  * interpreted by the IPv6 layer: should be a numeric IP4 or IP6
@@ -172,19 +190,19 @@ static void print_rsync_version(enum logcode f)
        got_socketpair = "";
 #endif
 
-#if HAVE_FTRUNCATE
+#ifdef HAVE_FTRUNCATE
        have_inplace = "";
 #endif
 
-#if SUPPORT_HARD_LINKS
+#ifdef SUPPORT_HARD_LINKS
        hardlinks = "";
 #endif
 
-#if SUPPORT_LINKS
+#ifdef SUPPORT_LINKS
        links = "";
 #endif
 
-#if INET6
+#ifdef INET6
        ipv6 = "";
 #endif
 
@@ -235,7 +253,7 @@ void usage(enum logcode F)
   rprintf(F,"\nrsync is a file transfer program capable of efficient remote update\nvia a fast differencing algorithm.\n\n");
 
   rprintf(F,"Usage: rsync [OPTION]... SRC [SRC]... [USER@]HOST:DEST\n");
-  rprintf(F,"  or   rsync [OPTION]... [USER@]HOST:SRC DEST\n");
+  rprintf(F,"  or   rsync [OPTION]... [USER@]HOST:SRC [DEST]\n");
   rprintf(F,"  or   rsync [OPTION]... SRC [SRC]... DEST\n");
   rprintf(F,"  or   rsync [OPTION]... [USER@]HOST::SRC [DEST]\n");
   rprintf(F,"  or   rsync [OPTION]... SRC [SRC]... [USER@]HOST::DEST\n");
@@ -258,6 +276,7 @@ void usage(enum logcode F)
   rprintf(F,"     --suffix=SUFFIX         set backup suffix (default %s w/o --backup-dir)\n",BACKUP_SUFFIX);
   rprintf(F," -u, --update                skip files that are newer on the receiver\n");
   rprintf(F,"     --inplace               update destination files in-place (SEE MAN PAGE)\n");
+  rprintf(F,"     --append                append data onto shorter files\n");
   rprintf(F," -d, --dirs                  transfer directories without recursing\n");
   rprintf(F," -l, --links                 copy symlinks as symlinks\n");
   rprintf(F," -L, --copy-links            transform symlink into referent file/dir\n");
@@ -273,14 +292,15 @@ void usage(enum logcode F)
   rprintf(F," -O, --omit-dir-times        omit directories when preserving times\n");
   rprintf(F," -S, --sparse                handle sparse files efficiently\n");
   rprintf(F," -n, --dry-run               show what would have been transferred\n");
-  rprintf(F," -W, --whole-file            copy files whole\n");
+  rprintf(F," -W, --whole-file            copy files whole (without rsync algorithm)\n");
   rprintf(F,"     --no-whole-file         always use incremental rsync algorithm\n");
   rprintf(F," -x, --one-file-system       don't cross filesystem boundaries\n");
   rprintf(F," -B, --block-size=SIZE       force a fixed checksum block-size\n");
   rprintf(F," -e, --rsh=COMMAND           specify the remote shell to use\n");
-  rprintf(F,"     --rsync-path=PATH       specify path to rsync on the remote machine\n");
+  rprintf(F,"     --rsync-path=PROGRAM    specify the rsync to run on the remote machine\n");
   rprintf(F,"     --existing              only update files that already exist on receiver\n");
   rprintf(F,"     --ignore-existing       ignore files that already exist on receiving side\n");
+  rprintf(F,"     --remove-sent-files     sent files/symlinks are removed from sending side\n");
   rprintf(F,"     --del                   an alias for --delete-during\n");
   rprintf(F,"     --delete                delete files that don't exist on the sending side\n");
   rprintf(F,"     --delete-before         receiver deletes before transfer (default)\n");
@@ -300,37 +320,42 @@ void usage(enum logcode F)
   rprintf(F,"     --size-only             skip files that match in size\n");
   rprintf(F,"     --modify-window=NUM     compare mod-times with reduced accuracy\n");
   rprintf(F," -T, --temp-dir=DIR          create temporary files in directory DIR\n");
+  rprintf(F," -y, --fuzzy                 find similar file for basis if no dest file\n");
   rprintf(F,"     --compare-dest=DIR      also compare destination files relative to DIR\n");
   rprintf(F,"     --copy-dest=DIR         ... and include copies of unchanged files\n");
   rprintf(F,"     --link-dest=DIR         hardlink to files in DIR when unchanged\n");
-  rprintf(F," -z, --compress              compress file data\n");
+  rprintf(F," -z, --compress              compress file data during the transfer\n");
   rprintf(F," -C, --cvs-exclude           auto-ignore files the same way CVS does\n");
   rprintf(F," -f, --filter=RULE           add a file-filtering RULE\n");
-  rprintf(F," -F                          same as --filter=': /.rsync-filter'\n");
+  rprintf(F," -F                          same as --filter='dir-merge /.rsync-filter'\n");
   rprintf(F,"                             repeated: --filter='- .rsync-filter'\n");
   rprintf(F,"     --exclude=PATTERN       exclude files matching PATTERN\n");
   rprintf(F,"     --exclude-from=FILE     read exclude patterns from FILE\n");
   rprintf(F,"     --include=PATTERN       don't exclude files matching PATTERN\n");
   rprintf(F,"     --include-from=FILE     read include patterns from FILE\n");
   rprintf(F,"     --files-from=FILE       read list of source-file names from FILE\n");
-  rprintf(F," -0, --from0                 all *-from file lists are delimited by nulls\n");
-  rprintf(F,"     --version               print version number\n");
+  rprintf(F," -0, --from0                 all *-from/filter files are delimited by 0s\n");
+  rprintf(F,"     --address=ADDRESS       bind address for outgoing socket to daemon\n");
   rprintf(F,"     --port=PORT             specify double-colon alternate port number\n");
   rprintf(F,"     --blocking-io           use blocking I/O for the remote shell\n");
   rprintf(F,"     --no-blocking-io        turn off blocking I/O when it is the default\n");
   rprintf(F,"     --stats                 give some file-transfer stats\n");
   rprintf(F,"     --progress              show progress during transfer\n");
   rprintf(F," -P                          same as --partial --progress\n");
-  rprintf(F,"     --log-format=FORMAT     log file-transfers using specified format\n");
+  rprintf(F," -i, --itemize-changes       output a change-summary for all updates\n");
+  rprintf(F,"     --log-format=FORMAT     output filenames using the specified format\n");
   rprintf(F,"     --password-file=FILE    read password from FILE\n");
   rprintf(F,"     --list-only             list the files instead of copying them\n");
   rprintf(F,"     --bwlimit=KBPS          limit I/O bandwidth; KBytes per second\n");
   rprintf(F,"     --write-batch=FILE      write a batched update to FILE\n");
+  rprintf(F,"     --only-write-batch=FILE like --write-batch but w/o updating destination\n");
   rprintf(F,"     --read-batch=FILE       read a batched update from FILE\n");
+  rprintf(F,"     --protocol=NUM          force an older protocol version to be used\n");
 #ifdef INET6
   rprintf(F," -4, --ipv4                  prefer IPv4\n");
   rprintf(F," -6, --ipv6                  prefer IPv6\n");
 #endif
+  rprintf(F,"     --version               print version number\n");
   rprintf(F," -h, --help                  show this help screen\n");
 
   rprintf(F,"\nUse \"rsync --daemon --help\" to see the daemon-mode command-line options.\n");
@@ -341,7 +366,7 @@ void usage(enum logcode F)
 enum {OPT_VERSION = 1000, OPT_DAEMON, OPT_SENDER, OPT_EXCLUDE, OPT_EXCLUDE_FROM,
       OPT_FILTER, OPT_COMPARE_DEST, OPT_COPY_DEST, OPT_LINK_DEST,
       OPT_INCLUDE, OPT_INCLUDE_FROM, OPT_MODIFY_WINDOW,
-      OPT_READ_BATCH, OPT_WRITE_BATCH, OPT_TIMEOUT, OPT_MAX_SIZE,
+      OPT_READ_BATCH, OPT_WRITE_BATCH, OPT_ONLY_WRITE_BATCH, OPT_MAX_SIZE,
       OPT_REFUSED_BASE = 9000};
 
 static struct poptOption long_options[] = {
@@ -356,11 +381,13 @@ static struct poptOption long_options[] = {
   {"one-file-system", 'x', POPT_ARG_NONE,   &one_file_system, 0, 0, 0 },
   {"existing",         0,  POPT_ARG_NONE,   &only_existing, 0, 0, 0 },
   {"ignore-existing",  0,  POPT_ARG_NONE,   &opt_ignore_existing, 0, 0, 0 },
+  {"del",              0,  POPT_ARG_NONE,   &delete_during, 0, 0, 0 },
   {"delete",           0,  POPT_ARG_NONE,   &delete_mode, 0, 0, 0 },
   {"delete-before",    0,  POPT_ARG_VAL,    &delete_before, 2, 0, 0 },
   {"delete-during",    0,  POPT_ARG_NONE,   &delete_during, 0, 0, 0 },
   {"delete-after",     0,  POPT_ARG_NONE,   &delete_after, 0, 0, 0 },
   {"delete-excluded",  0,  POPT_ARG_NONE,   &delete_excluded, 0, 0, 0 },
+  {"remove-sent-files",0,  POPT_ARG_NONE,   &remove_sent_files, 0, 0, 0 },
   {"force",            0,  POPT_ARG_NONE,   &force_delete, 0, 0, 0 },
   {"numeric-ids",      0,  POPT_ARG_NONE,   &numeric_ids, 0, 0, 0 },
   {"filter",          'f', POPT_ARG_STRING, 0, OPT_FILTER, 0, 0 },
@@ -380,22 +407,23 @@ static struct poptOption long_options[] = {
   {"links",           'l', POPT_ARG_NONE,   &preserve_links, 0, 0, 0 },
   {"copy-links",      'L', POPT_ARG_NONE,   &copy_links, 0, 0, 0 },
   {"keep-dirlinks",   'K', POPT_ARG_NONE,   &keep_dirlinks, 0, 0, 0 },
+  {"append",           0,  POPT_ARG_VAL,    &append_mode, 1, 0, 0 },
   {"whole-file",      'W', POPT_ARG_VAL,    &whole_file, 1, 0, 0 },
   {"no-whole-file",    0,  POPT_ARG_VAL,    &whole_file, 0, 0, 0 },
-  {"copy-unsafe-links", 0, POPT_ARG_NONE,   &copy_unsafe_links, 0, 0, 0 },
+  {"copy-unsafe-links",0,  POPT_ARG_NONE,   &copy_unsafe_links, 0, 0, 0 },
   {"perms",           'p', POPT_ARG_NONE,   &preserve_perms, 0, 0, 0 },
   {"owner",           'o', POPT_ARG_NONE,   &preserve_uid, 0, 0, 0 },
   {"group",           'g', POPT_ARG_NONE,   &preserve_gid, 0, 0, 0 },
   {"devices",         'D', POPT_ARG_NONE,   &preserve_devices, 0, 0, 0 },
   {"times",           't', POPT_ARG_NONE,   &preserve_times, 0, 0, 0 },
-  {"omit-dir-times",  'O', POPT_ARG_NONE,   &omit_dir_times, 0, 0, 0 },
+  {"omit-dir-times",  'O', POPT_ARG_VAL,    &omit_dir_times, 2, 0, 0 },
   {"checksum",        'c', POPT_ARG_NONE,   &always_checksum, 0, 0, 0 },
   {"verbose",         'v', POPT_ARG_NONE,   0, 'v', 0, 0 },
   {"quiet",           'q', POPT_ARG_NONE,   0, 'q', 0, 0 },
   {"archive",         'a', POPT_ARG_NONE,   &archive_mode, 0, 0, 0 },
   {"server",           0,  POPT_ARG_NONE,   &am_server, 0, 0, 0 },
   {"sender",           0,  POPT_ARG_NONE,   0, OPT_SENDER, 0, 0 },
-  {"recursive",       'r', POPT_ARG_VAL,    &recurse, -1, 0, 0 },
+  {"recursive",       'r', POPT_ARG_NONE,   &recurse, 0, 0, 0 },
   {"list-only",        0,  POPT_ARG_VAL,    &list_only, 2, 0, 0 },
   {"relative",        'R', POPT_ARG_VAL,    &relative_paths, 1, 0, 0 },
   {"no-relative",      0,  POPT_ARG_VAL,    &relative_paths, 0, 0, 0 },
@@ -403,11 +431,12 @@ static struct poptOption long_options[] = {
   {"block-size",      'B', POPT_ARG_LONG,   &block_size, 0, 0, 0 },
   {"max-delete",       0,  POPT_ARG_INT,    &max_delete, 0, 0, 0 },
   {"max-size",         0,  POPT_ARG_STRING, &max_size_arg,  OPT_MAX_SIZE, 0, 0 },
-  {"timeout",          0,  POPT_ARG_INT,    &io_timeout, OPT_TIMEOUT, 0, 0 },
+  {"timeout",          0,  POPT_ARG_INT,    &io_timeout, 0, 0, 0 },
   {"temp-dir",        'T', POPT_ARG_STRING, &tmpdir, 0, 0, 0 },
   {"compare-dest",     0,  POPT_ARG_STRING, 0, OPT_COMPARE_DEST, 0, 0 },
   {"copy-dest",        0,  POPT_ARG_STRING, 0, OPT_COPY_DEST, 0, 0 },
   {"link-dest",        0,  POPT_ARG_STRING, 0, OPT_LINK_DEST, 0, 0 },
+  {"fuzzy",           'y', POPT_ARG_NONE,   &fuzzy_basis, 0, 0, 0 },
   /* TODO: Should this take an optional int giving the compression level? */
   {"compress",        'z', POPT_ARG_NONE,   &do_compression, 0, 0, 0 },
   {"stats",            0,  POPT_ARG_NONE,   &do_stats, 0, 0, 0 },
@@ -420,13 +449,16 @@ static struct poptOption long_options[] = {
   {"no-blocking-io",   0,  POPT_ARG_VAL,    &blocking_io, 0, 0, 0 },
   {0,                 'F', POPT_ARG_NONE,   0, 'F', 0, 0 },
   {0,                 'P', POPT_ARG_NONE,   0, 'P', 0, 0 },
+  {"address",          0,  POPT_ARG_STRING, &bind_address, 0, 0, 0 },
   {"port",             0,  POPT_ARG_INT,    &rsync_port, 0, 0, 0 },
   {"log-format",       0,  POPT_ARG_STRING, &log_format, 0, 0, 0 },
+  {"itemize-changes", 'i', POPT_ARG_NONE,   &itemize_changes, 0, 0, 0 },
   {"bwlimit",          0,  POPT_ARG_INT,    &bwlimit, 0, 0, 0 },
   {"backup-dir",       0,  POPT_ARG_STRING, &backup_dir, 0, 0, 0 },
   {"hard-links",      'H', POPT_ARG_NONE,   &preserve_hard_links, 0, 0, 0 },
   {"read-batch",       0,  POPT_ARG_STRING, &batch_name, OPT_READ_BATCH, 0, 0 },
   {"write-batch",      0,  POPT_ARG_STRING, &batch_name, OPT_WRITE_BATCH, 0, 0 },
+  {"only-write-batch", 0,  POPT_ARG_STRING, &batch_name, OPT_ONLY_WRITE_BATCH, 0, 0 },
   {"files-from",       0,  POPT_ARG_STRING, &files_from, 0, 0, 0 },
   {"from0",           '0', POPT_ARG_NONE,   &eol_nulls, 0, 0, 0},
   {"no-implied-dirs",  0,  POPT_ARG_VAL,    &implied_dirs, 0, 0, 0 },
@@ -437,9 +469,9 @@ static struct poptOption long_options[] = {
   {"ipv6",            '6', POPT_ARG_VAL,    &default_af_hint, AF_INET6, 0, 0 },
 #endif
   /* All these options switch us into daemon-mode option-parsing. */
-  {"address",          0,  POPT_ARG_STRING, 0, OPT_DAEMON, 0, 0 },
   {"config",           0,  POPT_ARG_STRING, 0, OPT_DAEMON, 0, 0 },
   {"daemon",           0,  POPT_ARG_NONE,   0, OPT_DAEMON, 0, 0 },
+  {"detach",           0,  POPT_ARG_NONE,   0, OPT_DAEMON, 0, 0 },
   {"no-detach",        0,  POPT_ARG_NONE,   0, OPT_DAEMON, 0, 0 },
   {0,0,0,0, 0, 0, 0}
 };
@@ -475,7 +507,8 @@ static struct poptOption long_daemon_options[] = {
   {"ipv4",            '4', POPT_ARG_VAL,    &default_af_hint, AF_INET, 0, 0 },
   {"ipv6",            '6', POPT_ARG_VAL,    &default_af_hint, AF_INET6, 0, 0 },
 #endif
-  {"no-detach",        0,  POPT_ARG_NONE,   &no_detach, 0, 0, 0 },
+  {"detach",           0,  POPT_ARG_VAL,    &no_detach, 0, 0, 0 },
+  {"no-detach",        0,  POPT_ARG_VAL,    &no_detach, 1, 0, 0 },
   {"port",             0,  POPT_ARG_INT,    &rsync_port, 0, 0, 0 },
   {"protocol",         0,  POPT_ARG_INT,    &protocol_version, 0, 0, 0 },
   {"server",           0,  POPT_ARG_NONE,   &am_server, 0, 0, 0 },
@@ -522,9 +555,6 @@ static void set_refuse_options(char *bp)
                        break;
                if ((cp = strchr(bp, ' ')) != NULL)
                        *cp= '\0';
-               /* If they specify "delete", reject all delete options. */
-               if (strcmp(bp, "delete") == 0)
-                       bp = "delete*";
                is_wild = strpbrk(bp, "*?[") != NULL;
                found_match = 0;
                for (op = long_options; ; op++) {
@@ -537,6 +567,26 @@ static void set_refuse_options(char *bp)
                                        op->argInfo = POPT_ARG_NONE;
                                op->val = (op - long_options) + OPT_REFUSED_BASE;
                                found_match = 1;
+                               /* These flags are set to let us easily check
+                                * an implied option later in the code. */
+                               switch (*shortname) {
+                               case 'r': case 'd': case 'l': case 'p':
+                               case 't': case 'g': case 'o': case 'D':
+                                       refused_archive_part = op->val;
+                                       break;
+                               case '\0':
+                                       if (wildmatch("delete", op->longName))
+                                               refused_delete = op->val;
+                                       else if (wildmatch("delete-before", op->longName))
+                                               refused_delete_before = op->val;
+                                       else if (wildmatch("partial", op->longName))
+                                               refused_partial = op->val;
+                                       else if (wildmatch("progress", op->longName))
+                                               refused_progress = op->val;
+                                       else if (wildmatch("inplace", op->longName))
+                                               refused_inplace = op->val;
+                                       break;
+                               }
                                if (!is_wild)
                                        break;
                        }
@@ -550,6 +600,17 @@ static void set_refuse_options(char *bp)
                *cp = ' ';
                bp = cp + 1;
        }
+
+       for (op = long_options; ; op++) {
+               *shortname = op->shortName;
+               if (!op->longName && !*shortname)
+                       break;
+               if (op->val == OPT_DAEMON) {
+                       if (op->argInfo == POPT_ARG_VAL)
+                               op->argInfo = POPT_ARG_NONE;
+                       op->val = (op - long_options) + OPT_REFUSED_BASE;
+               }
+       }
 }
 
 
@@ -566,6 +627,49 @@ static int count_args(const char **argv)
 }
 
 
+static OFF_T parse_size_arg(const char *size_arg)
+{
+       const char *arg;
+       OFF_T size;
+
+       for (arg = size_arg; isdigit(*(uchar*)arg); arg++) {}
+       if (*arg == '.')
+               for (arg++; isdigit(*(uchar*)arg); arg++) {}
+       switch (*arg) {
+       case 'k': case 'K':
+               size = atof(size_arg) * 1024;
+               break;
+       case 'm': case 'M':
+               size = atof(size_arg) * 1024*1024;
+               break;
+       case 'g': case 'G':
+               size = atof(size_arg) * 1024*1024*1024;
+               break;
+       case '\0':
+               size = atof(size_arg);
+               break;
+       default:
+               size = 0;
+               break;
+       }
+       return size;
+}
+
+
+static void create_refuse_error(int which)
+{
+       /* The "which" value is the index + OPT_REFUSED_BASE. */
+       struct poptOption *op = &long_options[which - OPT_REFUSED_BASE];
+       int n = snprintf(err_buf, sizeof err_buf,
+                        "The server is configured to refuse --%s\n",
+                        op->longName) - 1;
+       if (op->shortName) {
+               snprintf(err_buf + n, sizeof err_buf - n,
+                        " (-%c)\n", op->shortName);
+       }
+}
+
+
 /**
  * Process command line arguments.  Called on both local and remote.
  *
@@ -589,16 +693,6 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
        /* The context leaks in case of an error, but if there's a
         * problem we always exit anyhow. */
        pc = poptGetContext(RSYNC_NAME, *argc, *argv, long_options, 0);
-       {
-               struct poptAlias my_alias;
-               char **argv = new_array(char *, 1);
-               argv[0] = strdup("--delete-during");
-               my_alias.longName = "del", my_alias.shortName = '\0';
-               my_alias.argc = 1;
-               my_alias.argv = (const char **)argv;
-               if (argv && argv[0])
-                       poptAddAlias(pc, my_alias, 0);
-       }
        poptReadDefaultConfig(pc, 0);
 
        while ((opt = poptGetNextOpt(pc)) != -1) {
@@ -645,6 +739,7 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                        }
                        *argv = poptGetArgs(pc);
                        *argc = count_args(*argv);
+                       am_starting_up = 0;
                        daemon_opt = 0;
                        am_daemon = 1;
                        return 1;
@@ -657,17 +752,17 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                        break;
 
                case OPT_FILTER:
-                       add_filter(&filter_list, poptGetOptArg(pc), 0);
+                       parse_rule(&filter_list, poptGetOptArg(pc), 0, 0);
                        break;
 
                case OPT_EXCLUDE:
-                       add_filter(&filter_list, poptGetOptArg(pc),
-                                  XFLG_DEF_EXCLUDE);
+                       parse_rule(&filter_list, poptGetOptArg(pc),
+                                  0, XFLG_OLD_PREFIXES);
                        break;
 
                case OPT_INCLUDE:
-                       add_filter(&filter_list, poptGetOptArg(pc),
-                                  XFLG_DEF_INCLUDE);
+                       parse_rule(&filter_list, poptGetOptArg(pc),
+                                  MATCHFLG_INCLUDE, XFLG_OLD_PREFIXES);
                        break;
 
                case OPT_EXCLUDE_FROM:
@@ -677,13 +772,15 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                                arg = sanitize_path(NULL, arg, NULL, 0);
                        if (server_filter_list.head) {
                                char *cp = (char *)arg;
+                               if (!*cp)
+                                       goto options_rejected;
                                clean_fname(cp, 1);
                                if (check_filter(&server_filter_list, cp, 0) < 0)
                                        goto options_rejected;
                        }
-                       add_filter_file(&filter_list, arg, XFLG_FATAL_ERRORS
-                               | (opt == OPT_INCLUDE_FROM ? XFLG_DEF_INCLUDE
-                                                          : XFLG_DEF_EXCLUDE));
+                       parse_filter_file(&filter_list, arg,
+                               opt == OPT_INCLUDE_FROM ? MATCHFLG_INCLUDE : 0,
+                               XFLG_FATAL_ERRORS | XFLG_OLD_PREFIXES);
                        break;
 
                case 'h':
@@ -710,17 +807,20 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                case 'F':
                        switch (++F_option_cnt) {
                        case 1:
-                               add_filter(&filter_list,
-                                           ": /.rsync-filter", 0);
+                               parse_rule(&filter_list,": /.rsync-filter",0,0);
                                break;
                        case 2:
-                               add_filter(&filter_list,
-                                           "- .rsync-filter", 0);
+                               parse_rule(&filter_list,"- .rsync-filter",0,0);
                                break;
                        }
                        break;
 
                case 'P':
+                       if (refused_partial || refused_progress) {
+                               create_refuse_error(refused_partial
+                                   ? refused_partial : refused_progress);
+                               return 0;
+                       }
                        do_progress = 1;
                        keep_partial = 1;
                        break;
@@ -730,33 +830,18 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                        write_batch = 1;
                        break;
 
+               case OPT_ONLY_WRITE_BATCH:
+                       /* batch_name is already set */
+                       write_batch = -1;
+                       break;
+
                case OPT_READ_BATCH:
                        /* batch_name is already set */
                        read_batch = 1;
                        break;
 
                case OPT_MAX_SIZE:
-                       for (arg = max_size_arg; isdigit(*arg); arg++) {}
-                       if (*arg == '.')
-                               for (arg++; isdigit(*arg); arg++) {}
-                       switch (*arg) {
-                       case 'k': case 'K':
-                               max_size = atof(max_size_arg) * 1024;
-                               break;
-                       case 'm': case 'M':
-                               max_size = atof(max_size_arg) * 1024*1024;
-                               break;
-                       case 'g': case 'G':
-                               max_size = atof(max_size_arg) * 1024*1024*1024;
-                               break;
-                       case '\0':
-                               max_size = atof(max_size_arg);
-                               break;
-                       default:
-                               max_size = 0;
-                               break;
-                       }
-                       if (max_size <= 0) {
+                       if ((max_size = parse_size_arg(max_size_arg)) <= 0) {
                                snprintf(err_buf, sizeof err_buf,
                                        "--max-size value is invalid: %s\n",
                                        max_size_arg);
@@ -764,13 +849,8 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                        }
                        break;
 
-               case OPT_TIMEOUT:
-                       if (io_timeout && io_timeout < select_timeout)
-                               select_timeout = io_timeout;
-                       break;
-
                case OPT_LINK_DEST:
-#if HAVE_LINK
+#ifdef HAVE_LINK
                        link_dest = 1;
                        dest_option = "--link-dest";
                        goto set_dest_dir;
@@ -804,28 +884,20 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
 
                default:
                        /* A large opt value means that set_refuse_options()
-                        * turned this option off (opt-BASE is its index). */
+                        * turned this option off. */
                        if (opt >= OPT_REFUSED_BASE) {
-                               struct poptOption *op =
-                                   &long_options[opt-OPT_REFUSED_BASE];
-                               int n = snprintf(err_buf, sizeof err_buf,
-                                   "The server is configured to refuse --%s\n",
-                                   op->longName) - 1;
-                               if (op->shortName) {
-                                       snprintf(err_buf+n, sizeof err_buf-n,
-                                           " (-%c)\n", op->shortName);
-                               }
-                       } else {
-                               snprintf(err_buf, sizeof err_buf, "%s%s: %s\n",
-                                   am_server ? "on remote machine: " : "",
-                                   poptBadOption(pc, POPT_BADOPTION_NOALIAS),
-                                   poptStrerror(opt));
+                               create_refuse_error(opt);
+                               return 0;
                        }
+                       snprintf(err_buf, sizeof err_buf, "%s%s: %s\n",
+                                am_server ? "on remote machine: " : "",
+                                poptBadOption(pc, POPT_BADOPTION_NOALIAS),
+                                poptStrerror(opt));
                        return 0;
                }
        }
 
-#if !SUPPORT_LINKS
+#ifndef SUPPORT_LINKS
        if (preserve_links && !am_sender) {
                snprintf(err_buf, sizeof err_buf,
                         "symlinks are not supported on this %s\n",
@@ -834,7 +906,7 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
        }
 #endif
 
-#if !SUPPORT_HARD_LINKS
+#ifndef SUPPORT_HARD_LINKS
        if (preserve_hard_links) {
                snprintf(err_buf, sizeof err_buf,
                         "hard links are not supported on this %s\n",
@@ -848,13 +920,7 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                        "--write-batch and --read-batch can not be used together\n");
                return 0;
        }
-       if (write_batch || read_batch) {
-               if (dry_run) {
-                       snprintf(err_buf, sizeof err_buf,
-                               "--%s-batch cannot be used with --dry_run (-n)\n",
-                               write_batch ? "write" : "read");
-                       return 0;
-               }
+       if (write_batch > 0 || read_batch) {
                if (am_server) {
                        rprintf(FINFO,
                                "ignoring --%s-batch option sent to server\n",
@@ -864,7 +930,8 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                         * batch args to server. */
                        read_batch = write_batch = 0;
                        batch_name = NULL;
-               }
+               } else if (dry_run)
+                       write_batch = 0;
        }
        if (read_batch && files_from) {
                snprintf(err_buf, sizeof err_buf,
@@ -891,9 +958,13 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
        }
 
        if (archive_mode) {
+               if (refused_archive_part) {
+                       create_refuse_error(refused_archive_part);
+                       return 0;
+               }
                if (!files_from)
-                       recurse = -1; /* infinite recursion */
-#if SUPPORT_LINKS
+                       recurse = 1;
+#ifdef SUPPORT_LINKS
                preserve_links = 1;
 #endif
                preserve_perms = 1;
@@ -908,16 +979,42 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
 
        if (relative_paths < 0)
                relative_paths = files_from? 1 : 0;
+       if (!relative_paths)
+               implied_dirs = 0;
 
        if (!!delete_before + delete_during + delete_after > 1) {
                snprintf(err_buf, sizeof err_buf,
                        "You may not combine multiple --delete-WHEN options.\n");
                return 0;
        }
-       if (delete_before || delete_during || delete_after)
+       if (!recurse) {
+               delete_before = delete_during = delete_after = 0;
+               delete_mode = delete_excluded = 0;
+       } else if (delete_before || delete_during || delete_after)
                delete_mode = 1;
-       else if (delete_mode || delete_excluded)
+       else if (delete_mode || delete_excluded) {
+               if (refused_delete_before) {
+                       create_refuse_error(refused_delete_before);
+                       return 0;
+               }
                delete_mode = delete_before = 1;
+       }
+
+       if (delete_mode && refused_delete) {
+               create_refuse_error(refused_delete);
+               return 0;
+       }
+
+       if (remove_sent_files) {
+               /* We only want to infer this refusal of --remove-sent-files
+                * via the refusal of "delete", not any of the "delete-FOO"
+                * options. */
+               if (refused_delete && am_sender) {
+                       create_refuse_error(refused_delete);
+                       return 0;
+               }
+               need_messages_from_generator = 1;
+       }
 
        *argv = poptGetArgs(pc);
        *argc = count_args(*argv);
@@ -932,40 +1029,39 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                        partial_dir = sanitize_path(NULL, partial_dir, NULL, 0);
                if (backup_dir)
                        backup_dir = sanitize_path(NULL, backup_dir, NULL, 0);
-               if (files_from)
-                       files_from = sanitize_path(NULL, files_from, NULL, 0);
        }
        if (server_filter_list.head && !am_sender) {
                struct filter_list_struct *elp = &server_filter_list;
                int i;
                if (tmpdir) {
+                       if (!*tmpdir)
+                               goto options_rejected;
                        clean_fname(tmpdir, 1);
                        if (check_filter(elp, tmpdir, 1) < 0)
                                goto options_rejected;
                }
-               if (partial_dir) {
+               if (partial_dir && *partial_dir) {
                        clean_fname(partial_dir, 1);
                        if (check_filter(elp, partial_dir, 1) < 0)
                                goto options_rejected;
                }
                for (i = 0; i < basis_dir_cnt; i++) {
+                       if (!*basis_dir[i])
+                               goto options_rejected;
                        clean_fname(basis_dir[i], 1);
                        if (check_filter(elp, basis_dir[i], 1) < 0)
                                goto options_rejected;
                }
                if (backup_dir) {
-                       clean_fname(backup_dir, 1);
-                       if (check_filter(elp, backup_dir, 1) < 0)
+                       if (!*backup_dir)
                                goto options_rejected;
-               }
-       }
-       if (server_filter_list.head && files_from) {
-               clean_fname(files_from, 1);
-               if (check_filter(&server_filter_list, files_from, 0) < 0) {
-                   options_rejected:
-                       snprintf(err_buf, sizeof err_buf,
-                           "Your options have been rejected by the server.\n");
-                       return 0;
+                       clean_fname(backup_dir, 1);
+                       if (check_filter(elp, backup_dir, 1) < 0) {
+                           options_rejected:
+                               snprintf(err_buf, sizeof err_buf,
+                                   "Your options have been rejected by the server.\n");
+                               return 0;
+                       }
                }
        }
 
@@ -990,17 +1086,46 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                        backup_dir_buf[backup_dir_len++] = '/';
                        backup_dir_buf[backup_dir_len] = '\0';
                }
-               if (verbose > 1 && !am_sender)
-                       rprintf(FINFO, "backup_dir is %s\n", backup_dir_buf);
+               if (verbose > 1 && !am_sender) {
+                       rprintf(FINFO, "backup_dir is %s\n",
+                               safe_fname(backup_dir_buf));
+               }
        } else if (!backup_suffix_len && (!am_server || !am_sender)) {
                snprintf(err_buf, sizeof err_buf,
                        "--suffix cannot be a null string without --backup-dir\n");
                return 0;
        }
+       if (make_backups && !backup_dir)
+               omit_dir_times = 1;
+
+       if (log_format) {
+               if (log_format_has(log_format, 'i'))
+                       log_format_has_i = 1;
+               if (!log_format_has(log_format, 'b')
+                && !log_format_has(log_format, 'c'))
+                       log_before_transfer = !am_server;
+       } else if (itemize_changes) {
+               log_format = "%i %n%L";
+               log_format_has_i = 1;
+               log_before_transfer = !am_server;
+       }
 
-       if (do_progress && !verbose)
+       if ((do_progress || dry_run) && !verbose && !log_before_transfer
+           && !am_server)
                verbose = 1;
 
+       if (dry_run)
+               do_xfers = 0;
+
+       set_io_timeout(io_timeout);
+
+       if (verbose && !log_format) {
+               log_format = "%n%L";
+               log_before_transfer = !am_server;
+       }
+       if (log_format_has_i || log_format_has(log_format, 'o'))
+               log_format_has_o_or_i = 1;
+
        if (daemon_bwlimit && (!bwlimit || bwlimit > daemon_bwlimit))
                bwlimit = daemon_bwlimit;
        if (bwlimit) {
@@ -1009,40 +1134,70 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                        bwlimit_writemax = 512;
        }
 
+       if (append_mode) {
+               if (whole_file > 0) {
+                       snprintf(err_buf, sizeof err_buf,
+                                "--append cannot be used with --whole-file\n");
+                       return 0;
+               }
+               if (refused_inplace) {
+                       create_refuse_error(refused_inplace);
+                       return 0;
+               }
+               inplace = 1;
+       }
+
        if (delay_updates && !partial_dir)
-               partial_dir = ".~tmp~";
+               partial_dir = partialdir_for_delayupdate;
 
        if (inplace) {
-#if HAVE_FTRUNCATE
+#ifdef HAVE_FTRUNCATE
                if (partial_dir) {
                        snprintf(err_buf, sizeof err_buf,
-                                "--inplace cannot be used with --%s\n",
+                                "--%s cannot be used with --%s\n",
+                                append_mode ? "append" : "inplace",
                                 delay_updates ? "delay-updates" : "partial-dir");
                        return 0;
                }
+               /* --inplace implies --partial for refusal purposes, but we
+                * clear the keep_partial flag for internal logic purposes. */
+               if (refused_partial) {
+                       create_refuse_error(refused_partial);
+                       return 0;
+               }
                keep_partial = 0;
 #else
                snprintf(err_buf, sizeof err_buf,
-                        "--inplace is not supported on this %s\n",
+                        "--%s is not supported on this %s\n",
+                        append_mode ? "append" : "inplace",
                         am_server ? "server" : "client");
                return 0;
 #endif
        } else {
-               if (keep_partial && !partial_dir)
-                       partial_dir = getenv("RSYNC_PARTIAL_DIR");
+               if (keep_partial && !partial_dir) {
+                       if ((arg = getenv("RSYNC_PARTIAL_DIR")) != NULL && *arg)
+                               partial_dir = strdup(arg);
+               }
                if (partial_dir) {
+                       if (*partial_dir)
+                               clean_fname(partial_dir, 1);
                        if (!*partial_dir || strcmp(partial_dir, ".") == 0)
                                partial_dir = NULL;
                        else if (*partial_dir != '/') {
-                               add_filter(&filter_list, partial_dir,
-                                           XFLG_DIRECTORY | XFLG_DEF_EXCLUDE);
+                               parse_rule(&filter_list, partial_dir,
+                                   MATCHFLG_NO_PREFIXES|MATCHFLG_DIRECTORY, 0);
+                       }
+                       if (!partial_dir && refused_partial) {
+                               create_refuse_error(refused_partial);
+                               return 0;
                        }
                        keep_partial = 1;
                }
        }
 
        if (files_from) {
-               char *colon;
+               char *h, *p;
+               int q;
                if (*argc > 2 || (!am_daemon && *argc == 1)) {
                        usage(FERROR);
                        exit_cleanup(RERR_SYNTAX);
@@ -1050,20 +1205,30 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                if (strcmp(files_from, "-") == 0) {
                        filesfrom_fd = 0;
                        if (am_server)
-                               remote_filesfrom_file = "-";
-               }
-               else if ((colon = find_colon(files_from)) != 0) {
+                               filesfrom_host = ""; /* reading from socket */
+               } else if ((p = check_for_hostspec(files_from, &h, &q)) != 0) {
                        if (am_server) {
-                               usage(FERROR);
-                               exit_cleanup(RERR_SYNTAX);
+                               snprintf(err_buf, sizeof err_buf,
+                                       "The --files-from sent to the server cannot specify a host.\n");
+                               return 0;
                        }
-                       remote_filesfrom_file = colon+1 + (colon[1] == ':');
-                       if (strcmp(remote_filesfrom_file, "-") == 0) {
+                       files_from = p;
+                       filesfrom_host = h;
+                       if (strcmp(files_from, "-") == 0) {
                                snprintf(err_buf, sizeof err_buf,
                                        "Invalid --files-from remote filename\n");
                                return 0;
                        }
                } else {
+                       if (sanitize_paths)
+                               files_from = sanitize_path(NULL, files_from, NULL, 0);
+                       if (server_filter_list.head) {
+                               if (!*files_from)
+                                       goto options_rejected;
+                               clean_fname(files_from, 1);
+                               if (check_filter(&server_filter_list, files_from, 0) < 0)
+                                       goto options_rejected;
+                       }
                        filesfrom_fd = open(files_from, O_RDONLY|O_BINARY);
                        if (filesfrom_fd < 0) {
                                snprintf(err_buf, sizeof err_buf,
@@ -1074,6 +1239,8 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
                }
        }
 
+       am_starting_up = 0;
+
        return 1;
 }
 
@@ -1088,7 +1255,7 @@ int parse_arguments(int *argc, const char ***argv, int frommain)
  **/
 void server_options(char **args,int *argc)
 {
-       static char argstr[50+MAX_BASIS_DIRS*2];
+       static char argstr[64];
        int ac = *argc;
        char *arg;
 
@@ -1119,14 +1286,14 @@ void server_options(char **args,int *argc)
                argstr[x++] = 'b';
        if (update_only)
                argstr[x++] = 'u';
-       if (dry_run)
+       if (!do_xfers) /* NOT "dry_run"! */
                argstr[x++] = 'n';
        if (preserve_links)
                argstr[x++] = 'l';
        if (copy_links)
                argstr[x++] = 'L';
        if (xfer_dirs > 1)
-               argstr[x++] = 'k';
+               argstr[x++] = 'd';
        if (keep_dirlinks && am_sender)
                argstr[x++] = 'K';
 
@@ -1146,11 +1313,11 @@ void server_options(char **args,int *argc)
                argstr[x++] = 'D';
        if (preserve_times)
                argstr[x++] = 't';
-       if (omit_dir_times && am_sender)
+       if (omit_dir_times == 2 && am_sender)
                argstr[x++] = 'O';
        if (preserve_perms)
                argstr[x++] = 'p';
-       if (recurse < 0)
+       if (recurse)
                argstr[x++] = 'r';
        if (always_checksum)
                argstr[x++] = 'c';
@@ -1170,7 +1337,7 @@ void server_options(char **args,int *argc)
        /* This is a complete hack - blame Rusty.  FIXME!
         * This hack is only needed for older rsync versions that
         * don't understand the --list-only option. */
-       if (list_only == 1 && recurse >= 0)
+       if (list_only == 1 && !recurse)
                argstr[x++] = 'r';
 
        argstr[x] = 0;
@@ -1181,6 +1348,17 @@ void server_options(char **args,int *argc)
        if (list_only > 1)
                args[ac++] = "--list-only";
 
+       /* The server side doesn't use our log-format, but in certain
+        * circumstances they need to know a little about the option. */
+       if (log_format && am_sender) {
+               if (log_format_has_i)
+                       args[ac++] = "--log-format=%i";
+               else if (log_format_has_o_or_i)
+                       args[ac++] = "--log-format=%o";
+               else if (!verbose)
+                       args[ac++] = "--log-format=X";
+       }
+
        if (block_size) {
                if (asprintf(&arg, "-B%lu", block_size) < 0)
                        goto oom;
@@ -1236,6 +1414,8 @@ void server_options(char **args,int *argc)
                        args[ac++] = "--delete-after";
                if (force_delete)
                        args[ac++] = "--force";
+               if (write_batch < 0)
+                       args[ac++] = "--only-write-batch=X";
        }
 
        if (size_only)
@@ -1254,8 +1434,10 @@ void server_options(char **args,int *argc)
        }
 
        if (partial_dir && am_sender) {
-               args[ac++] = "--partial-dir";
-               args[ac++] = partial_dir;
+               if (partial_dir != partialdir_for_delayupdate) {
+                       args[ac++] = "--partial-dir";
+                       args[ac++] = partial_dir;
+               }
                if (delay_updates)
                        args[ac++] = "--delay-updates";
        } else if (keep_partial)
@@ -1279,7 +1461,9 @@ void server_options(char **args,int *argc)
        if (opt_ignore_existing && am_sender)
                args[ac++] = "--ignore-existing";
 
-       if (inplace)
+       if (append_mode)
+               args[ac++] = "--append";
+       else if (inplace)
                args[ac++] = "--inplace";
 
        if (tmpdir) {
@@ -1299,10 +1483,10 @@ void server_options(char **args,int *argc)
                }
        }
 
-       if (files_from && (!am_sender || remote_filesfrom_file)) {
-               if (remote_filesfrom_file) {
+       if (files_from && (!am_sender || filesfrom_host)) {
+               if (filesfrom_host) {
                        args[ac++] = "--files-from";
-                       args[ac++] = remote_filesfrom_file;
+                       args[ac++] = files_from;
                        if (eol_nulls)
                                args[ac++] = "--from0";
                } else {
@@ -1312,9 +1496,15 @@ void server_options(char **args,int *argc)
                if (!relative_paths)
                        args[ac++] = "--no-relative";
        }
-       if (!implied_dirs && !am_sender)
+       if (relative_paths && !implied_dirs && !am_sender)
                args[ac++] = "--no-implied-dirs";
 
+       if (fuzzy_basis && am_sender)
+               args[ac++] = "--fuzzy";
+
+       if (remove_sent_files)
+               args[ac++] = "--remove-sent-files";
+
        *argc = ac;
        return;
 
@@ -1322,23 +1512,75 @@ void server_options(char **args,int *argc)
        out_of_memory("server_options");
 }
 
-/**
- * Return the position of a ':' IF it is not part of a filename (i.e. as
- * long as it doesn't occur after a slash.
- */
-char *find_colon(char *s)
+/* Look for a HOST specfication of the form "HOST:PATH", "HOST::PATH", or
+ * "rsync://HOST:PORT/PATH".  If found, *host_ptr will be set to some allocated
+ * memory with the HOST.  If a daemon-accessing spec was specified, the value
+ * of *port_ptr will contain a non-0 port number, otherwise it will be set to
+ * 0.  The return value is a pointer to the PATH.  Note that the HOST spec can
+ * be an IPv6 literal address enclosed in '[' and ']' (such as "[::1]" or
+ * "[::ffff:127.0.0.1]") which is returned without the '[' and ']'. */
+char *check_for_hostspec(char *s, char **host_ptr, int *port_ptr)
 {
-       char *p, *p2;
+       char *p;
+       int not_host;
+
+       if (port_ptr && strncasecmp(URL_PREFIX, s, strlen(URL_PREFIX)) == 0) {
+               char *path;
+               int hostlen;
+               s += strlen(URL_PREFIX);
+               if ((p = strchr(s, '/')) != NULL) {
+                       hostlen = p - s;
+                       path = p + 1;
+               } else {
+                       hostlen = strlen(s);
+                       path = "";
+               }
+               if (*s == '[' && (p = strchr(s, ']')) != NULL) {
+                       s++;
+                       hostlen = p - s;
+                       if (p[1] == ':')
+                               *port_ptr = atoi(p+2);
+               } else {
+                       if ((p = strchr(s, ':')) != NULL) {
+                               hostlen = p - s;
+                               *port_ptr = atoi(p+1);
+                       }
+               }
+               if (!*port_ptr)
+                       *port_ptr = RSYNC_PORT;
+               *host_ptr = new_array(char, hostlen + 1);
+               strlcpy(*host_ptr, s, hostlen + 1);
+               return path;
+       }
 
-       p = strchr(s,':');
-       if (!p)
-               return NULL;
+       if (*s == '[' && (p = strchr(s, ']')) != NULL && p[1] == ':') {
+               s++;
+               *p = '\0';
+               not_host = strchr(s, '/') || !strchr(s, ':');
+               *p = ']';
+               if (not_host)
+                       return NULL;
+               p++;
+       } else {
+               if (!(p = strchr(s, ':')))
+                       return NULL;
+               *p = '\0';
+               not_host = strchr(s, '/') != NULL;
+               *p = ':';
+               if (not_host)
+                       return NULL;
+       }
+
+       *host_ptr = new_array(char, p - s + 1);
+       strlcpy(*host_ptr, s, p - s + 1);
 
-       /* now check to see if there is a / in the string before the : - if there is then
-          discard the colon on the assumption that the : is part of a filename */
-       p2 = strchr(s,'/');
-       if (p2 && p2 < p)
-               return NULL;
+       if (p[1] == ':') {
+               if (port_ptr && !*port_ptr)
+                       *port_ptr = RSYNC_PORT;
+               return p + 2;
+       }
+       if (port_ptr)
+               *port_ptr = 0;
 
-       return p;
+       return p + 1;
 }