Commit | Line | Data |
---|---|---|
46ef7d1d | 1 | -*- indented-text -*- |
a0365806 | 2 | |
259c3e72 MP |
3 | BUGS --------------------------------------------------------------- |
4 | ||
5 | There seems to be a bug with hardlinks | |
6 | ||
7 | mbp/2 build$ ls -l /tmp/a /tmp/b -i | |
8 | /tmp/a: | |
9 | total 32 | |
10 | 2568307 -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a1 | |
11 | 2568307 -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a2 | |
12 | 2568307 -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a3 | |
13 | 2568310 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 a4 | |
14 | 2568310 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 a5 | |
15 | 2568310 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b1 | |
16 | 2568310 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b2 | |
17 | 2568310 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b3 | |
18 | ||
19 | /tmp/b: | |
20 | total 32 | |
21 | 2568309 -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a1 | |
22 | 2568309 -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a2 | |
23 | 2568309 -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a3 | |
24 | 2568311 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 a4 | |
25 | 2568311 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 a5 | |
26 | 2568311 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b1 | |
27 | 2568311 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b2 | |
28 | 2568311 -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b3 | |
29 | mbp/2 build$ rm -r /tmp/b && ./rsync -avH /tmp/a/ /tmp/b | |
30 | building file list ... done | |
31 | created directory /tmp/b | |
32 | ./ | |
33 | a1 | |
34 | a4 | |
35 | a2 => a1 | |
36 | a3 => a2 | |
37 | wrote 350 bytes read 52 bytes 804.00 bytes/sec | |
38 | total size is 232 speedup is 0.58 | |
39 | mbp/2 build$ rm -r /tmp/b | |
40 | mbp/2 build$ ls -l /tmp/b | |
41 | ls: /tmp/b: No such file or directory | |
42 | mbp/2 build$ rm -r /tmp/b && ./rsync -avH /tmp/a/ /tmp/b | |
43 | rm: cannot remove `/tmp/b': No such file or directory | |
44 | mbp/2 build$ rm -f -r /tmp/b && ./rsync -avH /tmp/a/ /tmp/b | |
45 | building file list ... done | |
46 | created directory /tmp/b | |
47 | ./ | |
48 | a1 | |
49 | a4 | |
50 | a2 => a1 | |
51 | a3 => a2 | |
52 | wrote 350 bytes read 52 bytes 804.00 bytes/sec | |
53 | total size is 232 speedup is 0.58 | |
54 | mbp/2 build$ ls -l /tmp/b | |
55 | total 32 | |
56 | -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a1 | |
57 | -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a2 | |
58 | -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a3 | |
59 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 a4 | |
60 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 a5 | |
61 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b1 | |
62 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b2 | |
63 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b3 | |
64 | mbp/2 build$ ls -l /tmp/a | |
65 | total 32 | |
66 | -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a1 | |
67 | -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a2 | |
68 | -rw-rw-r-- 3 mbp mbp 29 Mar 25 17:30 a3 | |
69 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 a4 | |
70 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 a5 | |
71 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b1 | |
72 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b2 | |
73 | -rw-rw-r-- 5 mbp mbp 29 Mar 25 17:30 b3 | |
46ef7d1d | 74 | |
33d213bb | 75 | |
e4724e5c MP |
76 | Progress indicator can produce corrupt output when transferring directories: |
77 | ||
78 | main/binary-arm/ | |
79 | main/binary-arm/admin/ | |
80 | main/binary-arm/base/ | |
81 | main/binary-arm/comm/8.56kB/s 0:00:52 | |
82 | main/binary-arm/devel/ | |
83 | main/binary-arm/doc/ | |
84 | main/binary-arm/editors/ | |
85 | main/binary-arm/electronics/s 0:00:53 | |
86 | main/binary-arm/games/ | |
87 | main/binary-arm/graphics/ | |
88 | main/binary-arm/hamradio/ | |
89 | main/binary-arm/interpreters/ | |
90 | main/binary-arm/libs/6.61kB/s 0:00:54 | |
91 | main/binary-arm/mail/ | |
92 | main/binary-arm/math/ | |
93 | main/binary-arm/misc/ | |
94 | ||
95 | lchmod | |
e4724e5c MP |
96 | I don't think we handle this properly on systems that don't have the |
97 | call. | |
98 | ||
5ba268ef MP |
99 | Cross-test versions |
100 | Part of the regression suite should be making sure that we don't | |
101 | break backwards compatibility: old clients vs new servers and so | |
102 | on. Ideally we would test the cross product of versions. | |
103 | ||
104 | It might be sufficient to test downloads from well-known public | |
105 | rsync servers running different versions of rsync. This will give | |
106 | some testing and also be the most common case for having different | |
107 | versions and not being able to upgrade. | |
108 | ||
f5e4eadb MP |
109 | --no-blocking-io might be broken |
110 | ||
111 | in the same way as --no-whole-file; somebody needs to check. | |
112 | ||
e4724e5c | 113 | |
3d90ec14 MP |
114 | DAEMON -------------------------------------------------------------- |
115 | ||
116 | server-imposed bandwidth limits | |
117 | ||
118 | rsyncd over ssh | |
119 | ||
120 | There are already some patches to do this. | |
121 | ||
122 | BitKeeper uses a server whose login shell is set to bkd. That's | |
123 | probably a reasonable approach. | |
124 | ||
125 | ||
126 | FEATURES ------------------------------------------------------------ | |
33d213bb | 127 | |
33d213bb | 128 | |
642a979a MP |
129 | --dry-run is insufficiently dry |
130 | ||
131 | Mark Santcroos points out that -n fails to list files which have | |
132 | only metadata changes, though it probably should. | |
133 | ||
134 | There may be a Debian bug about this as well. | |
135 | ||
136 | ||
a2d2e5c0 MP |
137 | use chroot |
138 | ||
139 | If the platform doesn't support it, then don't even try. | |
140 | ||
141 | If running as non-root, then don't fail, just give a warning. | |
142 | (There was a thread about this a while ago?) | |
143 | ||
144 | http://lists.samba.org/pipermail/rsync/2001-August/thread.html | |
145 | http://lists.samba.org/pipermail/rsync/2001-September/thread.html | |
146 | ||
642a979a | 147 | |
a2d2e5c0 MP |
148 | --files-from |
149 | ||
150 | Avoids traversal. Better option than a pile of --include statements | |
151 | for people who want to generate the file list using a find(1) | |
152 | command or a script. | |
153 | ||
642a979a | 154 | |
595f2d4d MP |
155 | supplementary groups |
156 | ||
157 | Perhaps allow supplementary groups to be specified in rsyncd.conf; | |
158 | then make the first one the primary gid and all the rest be | |
159 | supplementary gids. | |
160 | ||
161 | ||
8f4455f2 MP |
162 | File list structure in memory |
163 | ||
164 | Rather than one big array, perhaps have a tree in memory mirroring | |
165 | the directory tree. | |
166 | ||
167 | This might make sorting much faster! (I'm not sure it's a big CPU | |
168 | problem, mind you.) | |
169 | ||
170 | It might also reduce memory use in storing repeated directory names | |
171 | -- again I'm not sure this is a problem. | |
0e5a1f83 | 172 | |
a2d2e5c0 MP |
173 | Performance |
174 | ||
175 | Traverse just one directory at a time. Tridge says it's possible. | |
a6a3c3df MP |
176 | |
177 | At the moment rsync reads the whole file list into memory at the | |
178 | start, which makes us use a lot of memory and also not pipeline | |
179 | network access as much as we could. | |
180 | ||
0e5a1f83 MP |
181 | |
182 | Handling duplicate names | |
183 | ||
b3e6c815 | 184 | We need to be careful of duplicate names getting into the file list. |
d2e9d069 MP |
185 | See clean_flist(). This could happen if multiple arguments include |
186 | the same file. Bad. | |
b3e6c815 MP |
187 | |
188 | I think duplicates are only a problem if they're both flowing | |
189 | through the pipeline at the same time. For example we might have | |
190 | updated the first occurrence after reading the checksums for the | |
191 | second. So possibly we just need to make sure that we don't have | |
192 | both in the pipeline at the same time. | |
193 | ||
194 | Possibly if we did one directory at a time that would be sufficient. | |
195 | ||
196 | Alternatively we could pre-process the arguments to make sure no | |
58379559 MP |
197 | duplicates will ever be inserted. There could be some bad cases |
198 | when we're collapsing symlinks. | |
b3e6c815 MP |
199 | |
200 | We could have a hash table. | |
201 | ||
d2e9d069 MP |
202 | The root of the problem is that we do not want more than one file |
203 | list entry referring to the same file. At first glance there are | |
204 | several ways this could happen: symlinks, hardlinks, and repeated | |
205 | names on the command line. | |
206 | ||
207 | If names are repeated on the command line, they may be present in | |
208 | different forms, perhaps by traversing directory paths in different | |
209 | ways, traversing paths including symlinks. Also we need to allow | |
210 | for expansion of globs by rsync. | |
211 | ||
212 | At the moment, clean_flist() requires having the entire file list in | |
213 | memory. Duplicate names are detected just by a string comparison. | |
214 | ||
215 | We don't need to worry about hard links causing duplicates because | |
216 | files are never updated in place. Similarly for symlinks. | |
217 | ||
218 | I think even if we're using a different symlink mode we don't need | |
219 | to worry. | |
220 | ||
0e5a1f83 MP |
221 | Unless we're really clever this will introduce a protocol |
222 | incompatibility, so we need to be able to accept the old format as | |
223 | well. | |
224 | ||
225 | ||
a6a3c3df MP |
226 | Memory accounting |
227 | ||
228 | At exit, show how much memory was used for the file list, etc. | |
229 | ||
b3e6c815 MP |
230 | Also we do a wierd exponential-growth allocation in flist.c. I'm |
231 | not sure this makes sense with modern mallocs. At any rate it will | |
232 | make us allocate a huge amount of memory for large file lists. | |
233 | ||
0e5a1f83 | 234 | |
a6a3c3df MP |
235 | Hard-link handling |
236 | ||
237 | At the moment hardlink handling is very expensive, so it's off by | |
238 | default. It does not need to be so. | |
239 | ||
0e5a1f83 MP |
240 | Since most of the solutions are rather intertwined with the file |
241 | list it is probably better to fix that first, although fixing | |
242 | hardlinks is possibly simpler. | |
243 | ||
a6a3c3df MP |
244 | We can rule out hardlinked directories since they will probably |
245 | screw us up in all kinds of ways. They simply should not be used. | |
246 | ||
247 | At the moment rsync only cares about hardlinks to regular files. I | |
248 | guess you could also use them for sockets, devices and other beasts, | |
249 | but I have not seen them. | |
250 | ||
251 | When trying to reproduce hard links, we only need to worry about | |
252 | files that have more than one name (nlinks>1 && !S_ISDIR). | |
253 | ||
254 | The basic point of this is to discover alternate names that refer to | |
255 | the same file. All operations, including creating the file and | |
256 | writing modifications to it need only to be done for the first name. | |
257 | For all later names, we just create the link and then leave it | |
258 | alone. | |
259 | ||
260 | If hard links are to be preserved: | |
261 | ||
262 | Before the generator/receiver fork, the list of files is received | |
263 | from the sender (recv_file_list), and a table for detecting hard | |
264 | links is built. | |
265 | ||
266 | The generator looks for hard links within the file list and does | |
267 | not send checksums for them, though it does send other metadata. | |
268 | ||
269 | The sender sends the device number and inode with file entries, so | |
270 | that files are uniquely identified. | |
271 | ||
272 | The receiver goes through and creates hard links (do_hard_links) | |
273 | after all data has been written, but before directory permissions | |
274 | are set. | |
275 | ||
276 | At the moment device and inum are sent as 4-byte integers, which | |
277 | will probably cause problems on large filesystems. On Linux the | |
278 | kernel uses 64-bit ino_t's internally, and people will soon have | |
279 | filesystems big enough to use them. We ought to follow NFS4 in | |
280 | using 64-bit device and inode identification, perhaps with a | |
281 | protocol version bump. | |
282 | ||
283 | Once we've seen all the names for a particular file, we no longer | |
284 | need to think about it and we can deallocate the memory. | |
285 | ||
286 | We can also have the case where there are links to a file that are | |
287 | not in the tree being transferred. There's nothing we can do about | |
288 | that. Because we rename the destination into place after writing, | |
289 | any hardlinks to the old file are always going to be orphaned. In | |
290 | fact that is almost necessary because otherwise we'd get really | |
291 | confused if we were generating checksums for one name of a file and | |
292 | modifying another. | |
293 | ||
294 | At the moment the code seems to make a whole second copy of the file | |
295 | list, which seems unnecessary. | |
296 | ||
297 | We should have a test case that exercises hard links. Since it | |
298 | might be hard to compare ./tls output where the inodes change we | |
299 | might need a little program to check whether several names refer to | |
300 | the same file. | |
a2d2e5c0 MP |
301 | |
302 | IPv6 | |
303 | ||
c33e3e39 MP |
304 | Implement suggestions from http://www.kame.net/newsletter/19980604/ |
305 | and ftp://ftp.iij.ad.jp/pub/RFC/rfc2553.txt | |
306 | ||
307 | If a host has multiple addresses, then listen try to connect to all | |
308 | in order until we get through. (getaddrinfo may return multiple | |
c10b0bdd | 309 | addresses.) This is kind of implemented already. |
c33e3e39 MP |
310 | |
311 | Possibly also when starting as a server we may need to listen on | |
312 | multiple passive addresses. This might be a bit harder, because we | |
313 | may need to select on all of them. Hm. | |
314 | ||
a2d2e5c0 MP |
315 | Define a syntax for IPv6 literal addresses. Since they include |
316 | colons, they tend to break most naming systems, including ours. | |
317 | Based on the HTTP IPv6 syntax, I think we should use | |
318 | ||
319 | rsync://[::1]/foo/bar | |
320 | [::1]::bar | |
321 | ||
322 | which should just take a small change to the parser code. | |
323 | ||
b17dd0c4 | 324 | |
5aafd07b MP |
325 | Errors |
326 | ||
327 | If we hang or get SIGINT, then explain where we were up to. Perhaps | |
328 | have a static buffer that contains the current function name, or | |
329 | some kind of description of what we were trying to do. This is a | |
330 | little easier on people than needing to run strace/truss. | |
331 | ||
332 | "The dungeon collapses! You are killed." Rather than "unexpected | |
333 | eof" give a message that is more detailed if possible and also more | |
334 | helpful. | |
335 | ||
89b0a3d9 MP |
336 | If we get an error writing to a socket, then we should perhaps |
337 | continue trying to read to see if an error message comes across | |
338 | explaining why the socket is closed. I'm not sure if this would | |
339 | work, but it would certainly make our messages more helpful. | |
340 | ||
b17dd0c4 MP |
341 | What happens if a directory is missing -x attributes. Do we lose |
342 | our load? (Debian #28416) Probably fixed now, but a test case | |
343 | would be good. | |
344 | ||
345 | ||
5575de14 MP |
346 | File attributes |
347 | ||
348 | Device major/minor numbers should be at least 32 bits each. See | |
349 | http://lists.samba.org/pipermail/rsync/2001-November/005357.html | |
350 | ||
351 | Transfer ACLs. Need to think of a standard representation. | |
352 | Probably better not to even try to convert between NT and POSIX. | |
353 | Possibly can share some code with Samba. | |
5aafd07b | 354 | |
28a69e25 MP |
355 | Empty directories |
356 | ||
357 | With the current common --include '*/' --exclude '*' pattern, people | |
358 | can end up with many empty directories. We might avoid this by | |
359 | lazily creating such directories. | |
360 | ||
c6e27b60 | 361 | |
28a69e25 MP |
362 | zlib |
363 | ||
c6e27b60 MP |
364 | Perhaps don't use our own zlib. |
365 | ||
366 | Advantages: | |
367 | ||
368 | - will automatically be up to date with bugfixes in zlib | |
369 | ||
370 | - can leave it out for small rsync on e.g. recovery disks | |
371 | ||
372 | - can use a shared library | |
373 | ||
374 | - avoids people breaking rsync by trying to do this themselves and | |
375 | messing up | |
376 | ||
377 | Should we ship zlib for systems that don't have it, or require | |
378 | people to install it separately? | |
379 | ||
380 | Apparently this will make us incompatible with versions of rsync | |
381 | that use the patched version of rsync. Probably the simplest way to | |
382 | do this is to just disable gzip (with a warning) when talking to old | |
383 | versions. | |
384 | ||
5ba268ef MP |
385 | |
386 | logging | |
387 | ||
388 | Perhaps flush stdout after each filename, so that people trying to | |
389 | monitor progress in a log file can do so more easily. See | |
390 | http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=48108 | |
391 | ||
392 | At the connections that just get a list of modules are not logged, | |
393 | but they should be. | |
394 | ||
395 | If a child of the rsync daemon dies with a signal, we should notice | |
396 | that when we reap it and log a message. | |
397 | ||
398 | Keep stderr and stdout properly separated (Debian #23626) | |
399 | ||
595f2d4d MP |
400 | After we get the @RSYNCD greeting from the server, we know it's |
401 | version but we have not yet sent the command line, so we could just | |
402 | remove the -z option if the server is too old. | |
403 | ||
404 | For ssh invocation it's not so simple, because we actually use the | |
405 | command line to start the remote process. However, we only actually | |
406 | do compression in token.c, and we could therefore once we discover | |
407 | the remote version emit an error if it's too old. I'm not sure if | |
408 | that's a good tradeoff or not. | |
409 | ||
28a69e25 | 410 | |
5ba268ef MP |
411 | rsyncd over ssh |
412 | ||
413 | There are already some patches to do this. | |
414 | ||
92325ada MP |
415 | proxy authentication |
416 | ||
417 | Allow RSYNC_PROXY to be http://user:pass@proxy.foo:3128/, and do | |
418 | HTTP Basic Proxy-Authentication. | |
419 | ||
420 | Multiple schemes are possible, up to and including the insanity that | |
421 | is NTLM, but Basic probably covers most cases. | |
422 | ||
423 | SOCKS | |
424 | ||
425 | Add --with-socks, and then perhaps a command-line option to put them | |
426 | on or off. This might be more reliable than LD_PRELOAD hacks. | |
427 | ||
5ba268ef MP |
428 | FAT support |
429 | ||
430 | rsync to a FAT partition on a Unix machine doesn't work very well | |
431 | at the moment. I think we get errors about invalid filenames and | |
432 | perhaps also trying to do atomic renames. | |
433 | ||
434 | I guess the code to do this is currently #ifdef'd on Windows; perhaps | |
435 | we ought to intelligently fall back to it on Unix too. | |
436 | ||
437 | ||
27741d9f MP |
438 | Better statistics: |
439 | ||
440 | <Rasmus> mbp: hey, how about an rsync option that just gives you the | |
441 | summary without the list of files? And perhaps gives more | |
442 | information like the number of new files, number of changed, | |
443 | deleted, etc. ? | |
444 | <mbp> Rasmus: nice idea | |
445 | <mbp> there is --stats | |
446 | <mbp> but at the moment it's very tridge-oriented | |
447 | <mbp> rather than user-friendly | |
448 | <mbp> it would be nice to improve it | |
449 | <mbp> that would also work well with --dryrun | |
450 | ||
e53fe9a2 MP |
451 | TDB: |
452 | ||
453 | Rather than storing the file list in memory, store it in a TDB. | |
454 | ||
455 | This *might* make memory usage lower while building the file list. | |
456 | ||
457 | Hashtable lookup will mean files are not transmitted in order, | |
458 | though... hm. | |
459 | ||
460 | This would neatly eliminate one of the major post-fork shared data | |
461 | structures. | |
462 | ||
463 | ||
97e1254a MP |
464 | chmod: |
465 | ||
466 | On 12 Mar 2002, Dave Dykstra <dwd@bell-labs.com> wrote: | |
467 | > If we would add an option to do that functionality, I would vote for one | |
468 | > that was more general which could mask off any set of permission bits and | |
469 | > possibly add any set of bits. Perhaps a chmod-like syntax if it could be | |
470 | > implemented simply. | |
471 | ||
472 | I think that would be good too. For example, people uploading files | |
473 | to a web server might like to say | |
474 | ||
475 | rsync -avzP --chmod a+rX ./ sourcefrog.net:/home/www/sourcefrog/ | |
476 | ||
477 | Ideally the patch would implement as many of the gnu chmod semantics | |
478 | as possible. I think the mode parser should be a separate function | |
479 | that passes back something like (mask,set) description to the rest of | |
480 | the program. For bonus points there would be a test case for the | |
481 | parser. | |
482 | ||
36692011 MP |
483 | (Debian #23628) |
484 | ||
97e1254a | 485 | |
3c1edccb MP |
486 | --diff |
487 | ||
488 | Allow people to specify the diff command. (Might want to use wdiff, | |
489 | gnudiff, etc.) | |
490 | ||
491 | Just diff the temporary file with the destination file, and delete | |
492 | the tmp file rather than moving it into place. | |
493 | ||
494 | Interaction with --partial. | |
495 | ||
496 | Security interactions with daemon mode? | |
497 | ||
498 | (Suggestion from david.e.sewell) | |
499 | ||
500 | ||
a628b069 MP |
501 | Incorrect timestamps (Debian #100295) |
502 | ||
503 | A bit hard to believe, but apparently it happens. | |
6d19c674 MP |
504 | |
505 | ||
506 | Check "refuse options works" | |
507 | ||
508 | We need a test case for this... | |
509 | ||
510 | Was this broken when we changed to popt? | |
6479c2ed MP |
511 | |
512 | ||
bd0ad74f MP |
513 | PERFORMANCE ---------------------------------------------------------- |
514 | ||
515 | MD4 file_sum | |
516 | ||
517 | If we're doing a local transfer, or using -W, then perhaps don't | |
518 | send the file checksum. If we're doing a local transfer, then | |
519 | calculating MD4 checksums uses 90% of CPU and is unlikely to be | |
520 | useful. | |
521 | ||
522 | Indeed for transfers over zlib or ssh we can also rely on the | |
523 | transport to have quite strong protection against corruption. | |
524 | ||
525 | Perhaps we should have an option to disable this, analogous to | |
526 | --whole-file, although it would default to disabled. The file | |
527 | checksum takes up a definite space in the protocol -- we can either | |
528 | set it to 0, or perhaps just leave it out. | |
529 | ||
530 | MD4 | |
531 | ||
532 | Perhaps borrow an assembler MD4 from someone? | |
533 | ||
534 | Make sure we call MD4 with properly-sized blocks whenever possible | |
535 | to avoid copying into the residue region? | |
536 | ||
6479c2ed MP |
537 | String area code |
538 | ||
539 | Test whether this is actually faster than just using malloc(). If | |
540 | it's not (anymore), throw it out. | |
a628b069 MP |
541 | |
542 | ||
a2d2e5c0 MP |
543 | PLATFORMS ------------------------------------------------------------ |
544 | ||
545 | Win32 | |
546 | ||
547 | Don't detach, because this messes up --srvany. | |
548 | ||
549 | http://sources.redhat.com/ml/cygwin/2001-08/msg00234.html | |
550 | ||
551 | According to "Effective TCP/IP Programming" (??) close() on a socket | |
552 | has incorrect behaviour on Windows -- it sends a RST packet to the | |
553 | other side, which gives a "connection reset by peer" error. On that | |
554 | platform we should probably do shutdown() instead. However, on Unix | |
555 | we are correct to call close(), because shutdown() discards | |
556 | untransmitted data. | |
557 | ||
5ba268ef | 558 | |
0e23e41d MP |
559 | DEVELOPMENT ---------------------------------------------------------- |
560 | ||
561 | Splint | |
562 | ||
563 | Build rsync with SPLINT to try to find security holes. Add | |
564 | annotations as necessary. Keep track of the number of warnings | |
565 | found initially, and see how many of them are real bugs, or real | |
566 | security bugs. Knowing the percentage of likely hits would be | |
567 | really interesting for other projects. | |
568 | ||
f5a95bb5 MP |
569 | Torture test |
570 | ||
571 | Something that just keeps running rsync continuously over a data set | |
572 | likely to generate problems. | |
573 | ||
574 | Cross-testing | |
575 | ||
576 | Run current rsync versions against significant past releases. | |
577 | ||
43a4dc10 MP |
578 | Memory debugger |
579 | ||
3a79260d | 580 | jra recommends Valgrind: |
43a4dc10 MP |
581 | |
582 | http://devel-home.kde.org/~sewardj/ | |
583 | ||
25ff30e8 MP |
584 | Release script |
585 | ||
586 | Update spec files | |
587 | ||
588 | Build tar file; upload | |
589 | ||
590 | Send announcement to mailing list and c.o.l.a. | |
591 | ||
592 | Make freshmeat announcement | |
593 | ||
594 | Update web site | |
595 | ||
596 | ||
597 | ||
e9c4c301 MP |
598 | TESTING -------------------------------------------------------------- |
599 | ||
600 | Cross-test versions | |
601 | ||
602 | Part of the regression suite should be making sure that we don't | |
603 | break backwards compatibility: old clients vs new servers and so | |
25ff30e8 MP |
604 | on. Ideally we would test both up and down from the current release |
605 | to all old versions. | |
606 | ||
607 | We might need to omit broken old versions, or versions in which | |
608 | particular functionality is broken | |
e9c4c301 MP |
609 | |
610 | It might be sufficient to test downloads from well-known public | |
611 | rsync servers running different versions of rsync. This will give | |
612 | some testing and also be the most common case for having different | |
613 | versions and not being able to upgrade. | |
614 | ||
25ff30e8 MP |
615 | |
616 | Test on kernel source | |
617 | ||
618 | Download all versions of kernel; unpack, sync between them. Also | |
619 | sync between uncompressed tarballs. Compare directories after | |
620 | transfer. | |
621 | ||
622 | Use local mode; ssh; daemon; --whole-file and --no-whole-file. | |
623 | ||
624 | Use awk to pull out the 'speedup' number for each transfer. Make | |
625 | sure it is >= x. | |
626 | ||
627 | ||
e9c4c301 MP |
628 | Test large files |
629 | ||
630 | Sparse and non-sparse | |
631 | ||
632 | Mutator program | |
633 | ||
634 | Insert bytes, delete bytes, swap blocks, ... | |
635 | ||
636 | configure option to enable dangerous tests | |
637 | ||
638 | If tests are skipped, say why. | |
639 | ||
b73b51a9 MP |
640 | Test daemon feature to disallow particular options. |
641 | ||
599dc93c MP |
642 | Pipe program that makes slow/jerky connections. |
643 | ||
76533c52 MP |
644 | Versions of read() and write() that corrupt the stream, or abruptly fail |
645 | ||
6479c2ed MP |
646 | Separate makefile target to run rough tests -- or perhaps just run |
647 | them every time? | |
648 | ||
717eb9b8 MP |
649 | Test "refuse options" works |
650 | ||
651 | What about for --recursive? | |
652 | ||
653 | If you specify an unrecognized option here, you should get an error. | |
654 | ||
e9c4c301 | 655 | |
7c583c73 MP |
656 | DOCUMENTATION -------------------------------------------------------- |
657 | ||
658 | Update README | |
659 | ||
b73b51a9 MP |
660 | Keep list of open issues and todos on the web site |
661 | ||
662 | Update web site from CVS | |
663 | ||
5af50297 MP |
664 | |
665 | Perhaps redo manual as SGML | |
666 | ||
667 | The man page is getting rather large, and there is more information | |
668 | that ought to be added. | |
669 | ||
670 | TexInfo source is probably a dying format. | |
671 | ||
672 | Linuxdoc looks like the most likely contender. I know DocBook is | |
673 | favoured by some people, but it's so bloody verbose, even with emacs | |
674 | support. | |
675 | ||
676 | ||
a2d2e5c0 MP |
677 | BUILD FARM ----------------------------------------------------------- |
678 | ||
679 | Add machines | |
680 | ||
681 | AMDAHL UTS (Dave Dykstra) | |
682 | ||
683 | Cygwin (on different versions of Win32?) | |
684 | ||
685 | HP-UX variants (via HP?) | |
33d213bb | 686 | |
5aafd07b MP |
687 | SCO |
688 | ||
46ef7d1d | 689 | |
62b68c80 | 690 | LOGGING -------------------------------------------------------------- |
a2d2e5c0 | 691 | |
62b68c80 MP |
692 | Perhaps flush stdout after each filename, so that people trying to |
693 | monitor progress in a log file can do so more easily. See | |
694 | http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=48108 | |
a2d2e5c0 | 695 | |
62b68c80 MP |
696 | At the connections that just get a list of modules are not logged, |
697 | but they should be. | |
698 | ||
699 | If a child of the rsync daemon dies with a signal, we should notice | |
700 | that when we reap it and log a message. | |
701 | ||
702 | Keep stderr and stdout properly separated (Debian #23626) | |
703 | ||
704 | Use a separate function for reporting errors; prefix it with | |
705 | "rsync:" or "rsync(remote)", or perhaps even "rsync(local | |
706 | generator): ". | |
a2d2e5c0 | 707 | |
50f2f002 MP |
708 | verbose output |
709 | ||
710 | Indicate whether files are new, updated, or deleted | |
711 | ||
d834adc1 MP |
712 | At end of transfer, show how many files were or were not transferred |
713 | correctly. | |
714 | ||
62b68c80 MP |
715 | -vv |
716 | ||
717 | Explain *why* every file is transferred or not (e.g. "local mtime | |
718 | 123123 newer than 1283198") | |
719 | ||
720 | ||
8ff9d697 MP |
721 | debugging of daemon |
722 | ||
723 | Add an rsyncd.conf parameter to turn on debugging on the server. | |
724 | ||
725 | ||
62b68c80 MP |
726 | |
727 | NICE ----------------------------------------------------------------- | |
728 | ||
729 | --no-detach and --no-fork options | |
730 | ||
731 | Very useful for debugging. Also good when running under a | |
732 | daemon-monitoring process that tries to restart the service when the | |
733 | parent exits. | |
734 | ||
735 | hang/timeout friendliness | |
3d90ec14 | 736 | |
a2d2e5c0 MP |
737 | internationalization |
738 | ||
739 | Change to using gettext(). Probably need to ship this for platforms | |
740 | that don't have it. | |
741 | ||
742 | Solicit translations. | |
743 | ||
3d90ec14 MP |
744 | Does anyone care? Before we bother modifying the code, we ought to |
745 | get the manual translated first, because that's possibly more useful | |
746 | and at any rate demonstrates desire. | |
747 | ||
46ef7d1d MP |
748 | rsyncsh |
749 | ||
750 | Write a small emulation of interactive ftp as a Pythonn program | |
751 | that calls rsync. Commands such as "cd", "ls", "ls *.c" etc map | |
752 | fairly directly into rsync commands: it just needs to remember the | |
753 | current host, directory and so on. We can probably even do | |
754 | completion of remote filenames. | |
25ff30e8 MP |
755 | |
756 | ||
757 | RELATED PROJECTS ----------------------------------------------------- | |
758 | ||
759 | http://rsync.samba.org/rsync-and-debian/ | |
760 | ||
761 | rsyncable gzip patch | |
762 | ||
763 | Exhaustive, tortuous testing | |
764 | ||
765 | Cleanups? | |
766 | ||
767 | rsyncsplit as alternative to real integration with gzip? | |
768 | ||
769 | reverse rsync over HTTP Range | |
770 | ||
771 | Goswin Brederlow suggested this on Debian; I think tridge and I | |
772 | talked about it previous in relation to rproxy. |