1 To use this patch, run these commands for a successful build:
3 patch -p1 <patches/acls.diff
5 ./configure --enable-acl-support
8 See the --acls (-A) option in the revised man page for a note on using this
9 latest ACL-enabling patch to send files to an older ACL-enabled rsync.
13 @@ -26,15 +26,15 @@ VERSION=@VERSION@
17 -HEADERS=byteorder.h config.h errcode.h proto.h rsync.h lib/pool_alloc.h
18 +HEADERS=byteorder.h config.h errcode.h proto.h rsync.h smb_acls.h lib/pool_alloc.h
19 LIBOBJ=lib/wildmatch.o lib/compat.o lib/snprintf.o lib/mdfour.o \
20 - lib/permstring.o lib/pool_alloc.o @LIBOBJS@
21 + lib/permstring.o lib/pool_alloc.o lib/sysacls.o @LIBOBJS@
22 ZLIBOBJ=zlib/deflate.o zlib/inffast.o zlib/inflate.o zlib/inftrees.o \
23 zlib/trees.o zlib/zutil.o zlib/adler32.o zlib/compress.o zlib/crc32.o
24 OBJS1=flist.o rsync.o generator.o receiver.o cleanup.o sender.o exclude.o \
25 util.o main.o checksum.o match.o syscall.o log.o backup.o
26 OBJS2=options.o io.o compat.o hlink.o token.o uidlist.o socket.o \
27 - fileio.o batch.o clientname.o chmod.o
28 + fileio.o batch.o clientname.o chmod.o acls.o
29 OBJS3=progress.o pipe.o
30 DAEMON_OBJ = params.o loadparm.o clientserver.o access.o connection.o authenticate.o
31 popt_OBJS=popt/findme.o popt/popt.o popt/poptconfig.o \
36 + * Handle passing Access Control Lists between systems.
38 + * Copyright (C) 1996 Andrew Tridgell
39 + * Copyright (C) 1996 Paul Mackerras
40 + * Copyright (C) 2006 Wayne Davison
42 + * This program is free software; you can redistribute it and/or modify
43 + * it under the terms of the GNU General Public License as published by
44 + * the Free Software Foundation; either version 2 of the License, or
45 + * (at your option) any later version.
47 + * This program is distributed in the hope that it will be useful,
48 + * but WITHOUT ANY WARRANTY; without even the implied warranty of
49 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
50 + * GNU General Public License for more details.
52 + * You should have received a copy of the GNU General Public License along
53 + * with this program; if not, write to the Free Software Foundation, Inc.,
54 + * 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
58 +#include "lib/sysacls.h"
63 +extern int read_only;
64 +extern int list_only;
65 +extern int orig_umask;
66 +extern int protocol_version;
68 +/* === ACL structures === */
80 +#define NO_ENTRY ((uchar)0x80)
81 +typedef struct rsync_acl {
84 + /* These will be NO_ENTRY if there's no such entry. */
96 +static const rsync_acl empty_rsync_acl = {
97 + {NULL, 0}, {NULL, 0}, NO_ENTRY, NO_ENTRY, NO_ENTRY, NO_ENTRY
100 +static item_list access_acl_list = EMPTY_ITEM_LIST;
101 +static item_list default_acl_list = EMPTY_ITEM_LIST;
103 +/* === Calculations on ACL types === */
105 +static const char *str_acl_type(SMB_ACL_TYPE_T type)
107 + return type == SMB_ACL_TYPE_ACCESS ? "SMB_ACL_TYPE_ACCESS"
108 + : type == SMB_ACL_TYPE_DEFAULT ? "SMB_ACL_TYPE_DEFAULT"
109 + : "unknown SMB_ACL_TYPE_T";
112 +#define OTHER_TYPE(t) (SMB_ACL_TYPE_ACCESS+SMB_ACL_TYPE_DEFAULT-(t))
113 +#define BUMP_TYPE(t) ((t = OTHER_TYPE(t)) == SMB_ACL_TYPE_DEFAULT)
115 +static int count_racl_entries(const rsync_acl *racl)
117 + return racl->users.count + racl->groups.count
118 + + (racl->user_obj != NO_ENTRY)
119 + + (racl->group_obj != NO_ENTRY)
120 + + (racl->mask != NO_ENTRY)
121 + + (racl->other != NO_ENTRY);
124 +static int calc_sacl_entries(const rsync_acl *racl)
126 + /* A System ACL always gets user/group/other permission entries. */
127 + return racl->users.count + racl->groups.count
128 +#ifdef ACLS_NEED_MASK
131 + + (racl->mask != NO_ENTRY) + 3;
135 +/* Extracts and returns the permission bits from the ACL. This cannot be
136 + * called on an rsync_acl that has NO_ENTRY in any spot but the mask. */
137 +static int rsync_acl_get_perms(const rsync_acl *racl)
139 + return (racl->user_obj << 6)
140 + + ((racl->mask != NO_ENTRY ? racl->mask : racl->group_obj) << 3)
144 +/* Removes the permission-bit entries from the ACL because these
145 + * can be reconstructed from the file's mode. */
146 +static void rsync_acl_strip_perms(rsync_acl *racl)
148 + racl->user_obj = NO_ENTRY;
149 + if (racl->mask == NO_ENTRY)
150 + racl->group_obj = NO_ENTRY;
152 + if (racl->group_obj == racl->mask)
153 + racl->group_obj = NO_ENTRY;
154 + racl->mask = NO_ENTRY;
156 + racl->other = NO_ENTRY;
159 +/* Given an empty rsync_acl, fake up the permission bits. */
160 +static void rsync_acl_fake_perms(rsync_acl *racl, mode_t mode)
162 + racl->user_obj = (mode >> 6) & 7;
163 + racl->group_obj = (mode >> 3) & 7;
164 + racl->other = mode & 7;
167 +/* === Rsync ACL functions === */
169 +static BOOL ida_entries_equal(const ida_entries *ial1, const ida_entries *ial2)
171 + id_access *ida1, *ida2;
172 + int count = ial1->count;
173 + if (count != ial2->count)
177 + for (; count--; ida1++, ida2++) {
178 + if (ida1->access != ida2->access || ida1->id != ida2->id)
184 +static BOOL rsync_acl_equal(const rsync_acl *racl1, const rsync_acl *racl2)
186 + return racl1->user_obj == racl2->user_obj
187 + && racl1->group_obj == racl2->group_obj
188 + && racl1->mask == racl2->mask
189 + && racl1->other == racl2->other
190 + && ida_entries_equal(&racl1->users, &racl2->users)
191 + && ida_entries_equal(&racl1->groups, &racl2->groups);
194 +/* Are the extended (non-permission-bit) entries equal? If so, the rest of
195 + * the ACL will be handled by the normal mode-preservation code. This is
196 + * only meaningful for access ACLs! Note: the 1st arg is a fully-populated
197 + * rsync_acl, but the 2nd parameter can be a condensed rsync_acl, which means
198 + * that it might have several of its permission objects set to NO_ENTRY. */
199 +static BOOL rsync_acl_equal_enough(const rsync_acl *racl1,
200 + const rsync_acl *racl2, mode_t m)
202 + if ((racl1->mask ^ racl2->mask) & NO_ENTRY)
203 + return False; /* One has a mask and the other doesn't */
205 + /* When there's a mask, the group_obj becomes an extended entry. */
206 + if (racl1->mask != NO_ENTRY) {
207 + /* A condensed rsync_acl with a mask can only have no
208 + * group_obj when it was identical to the mask. This
209 + * means that it was also identical to the group attrs
210 + * from the mode. */
211 + if (racl2->group_obj == NO_ENTRY) {
212 + if (racl1->group_obj != ((m >> 3) & 7))
214 + } else if (racl1->group_obj != racl2->group_obj)
217 + return ida_entries_equal(&racl1->users, &racl2->users)
218 + && ida_entries_equal(&racl1->groups, &racl2->groups);
221 +static void rsync_acl_free(rsync_acl *racl)
223 + if (racl->users.idas)
224 + free(racl->users.idas);
225 + if (racl->groups.idas)
226 + free(racl->groups.idas);
227 + *racl = empty_rsync_acl;
230 +void free_acl(statx *sxp)
232 + if (sxp->acc_acl) {
233 + rsync_acl_free(sxp->acc_acl);
234 + free(sxp->acc_acl);
235 + sxp->acc_acl = NULL;
237 + if (sxp->def_acl) {
238 + rsync_acl_free(sxp->def_acl);
239 + free(sxp->def_acl);
240 + sxp->def_acl = NULL;
244 +static int id_access_sorter(const void *r1, const void *r2)
246 + id_access *ida1 = (id_access *)r1;
247 + id_access *ida2 = (id_access *)r2;
248 + id_t rid1 = ida1->id, rid2 = ida2->id;
249 + return rid1 == rid2 ? 0 : rid1 < rid2 ? -1 : 1;
252 +static void sort_ida_entries(ida_entries *idal)
256 + qsort(idal->idas, idal->count, sizeof idal->idas[0], id_access_sorter);
259 +/* Transfer the count id_access items out of the temp_ida_list into either
260 + * the users or groups ida_entries list in racl. */
261 +static void save_idas(item_list *temp_ida_list, rsync_acl *racl, SMB_ACL_TAG_T type)
266 + if (temp_ida_list->count) {
267 + int cnt = temp_ida_list->count;
268 + id_access *temp_idas = temp_ida_list->items;
269 + if (!(idas = new_array(id_access, cnt)))
270 + out_of_memory("save_idas");
271 + memcpy(idas, temp_idas, cnt * sizeof *temp_idas);
275 + ent = type == SMB_ACL_USER ? &racl->users : &racl->groups;
278 + rprintf(FERROR, "save_idas: disjoint list found for type %d\n", type);
279 + exit_cleanup(RERR_UNSUPPORTED);
281 + ent->count = temp_ida_list->count;
284 + /* Truncate the temporary list now that its idas have been saved. */
285 + temp_ida_list->count = 0;
288 +/* === System ACLs === */
290 +/* Unpack system ACL -> rsync ACL verbatim. Return whether we succeeded. */
291 +static BOOL unpack_smb_acl(rsync_acl *racl, SMB_ACL_T sacl)
293 + static item_list temp_ida_list = EMPTY_ITEM_LIST;
294 + SMB_ACL_TAG_T prior_list_type = 0;
295 + SMB_ACL_ENTRY_T entry;
296 + const char *errfun;
299 + errfun = "sys_acl_get_entry";
300 + for (rc = sys_acl_get_entry(sacl, SMB_ACL_FIRST_ENTRY, &entry);
302 + rc = sys_acl_get_entry(sacl, SMB_ACL_NEXT_ENTRY, &entry)) {
303 + SMB_ACL_TAG_T tag_type;
304 + SMB_ACL_PERMSET_T permset;
308 + if ((rc = sys_acl_get_tag_type(entry, &tag_type))) {
309 + errfun = "sys_acl_get_tag_type";
312 + if ((rc = sys_acl_get_permset(entry, &permset))) {
313 + errfun = "sys_acl_get_tag_type";
316 + access = (sys_acl_get_perm(permset, SMB_ACL_READ) ? 4 : 0)
317 + | (sys_acl_get_perm(permset, SMB_ACL_WRITE) ? 2 : 0)
318 + | (sys_acl_get_perm(permset, SMB_ACL_EXECUTE) ? 1 : 0);
319 + /* continue == done with entry; break == store in temporary ida list */
320 + switch (tag_type) {
321 + case SMB_ACL_USER_OBJ:
322 + if (racl->user_obj == NO_ENTRY)
323 + racl->user_obj = access;
325 + rprintf(FINFO, "unpack_smb_acl: warning: duplicate USER_OBJ entry ignored\n");
329 + case SMB_ACL_GROUP_OBJ:
330 + if (racl->group_obj == NO_ENTRY)
331 + racl->group_obj = access;
333 + rprintf(FINFO, "unpack_smb_acl: warning: duplicate GROUP_OBJ entry ignored\n");
335 + case SMB_ACL_GROUP:
338 + if (racl->mask == NO_ENTRY)
339 + racl->mask = access;
341 + rprintf(FINFO, "unpack_smb_acl: warning: duplicate MASK entry ignored\n");
343 + case SMB_ACL_OTHER:
344 + if (racl->other == NO_ENTRY)
345 + racl->other = access;
347 + rprintf(FINFO, "unpack_smb_acl: warning: duplicate OTHER entry ignored\n");
350 + rprintf(FINFO, "unpack_smb_acl: warning: entry with unrecognized tag type ignored\n");
353 + if (!(qualifier = sys_acl_get_qualifier(entry))) {
354 + errfun = "sys_acl_get_tag_type";
358 + if (tag_type != prior_list_type) {
359 + if (prior_list_type)
360 + save_idas(&temp_ida_list, racl, prior_list_type);
361 + prior_list_type = tag_type;
363 + ida = EXPAND_ITEM_LIST(&temp_ida_list, id_access, -10);
364 + ida->id = *((id_t *)qualifier);
365 + ida->access = access;
366 + sys_acl_free_qualifier(qualifier, tag_type);
369 + rsyserr(FERROR, errno, "unpack_smb_acl: %s()", errfun);
370 + rsync_acl_free(racl);
373 + if (prior_list_type)
374 + save_idas(&temp_ida_list, racl, prior_list_type);
376 + sort_ida_entries(&racl->users);
377 + sort_ida_entries(&racl->groups);
379 +#ifdef ACLS_NEED_MASK
380 + if (!racl->users.count && !racl->groups.count && racl->mask != NO_ENTRY) {
381 + /* Throw away a superfluous mask, but mask off the
382 + * group perms with it first. */
383 + racl->group_obj &= racl->mask;
384 + racl->mask = NO_ENTRY;
391 +/* Synactic sugar for system calls */
393 +#define CALL_OR_ERROR(func,args,str) \
401 +#define COE(func,args) CALL_OR_ERROR(func,args,#func)
402 +#define COE2(func,args) CALL_OR_ERROR(func,args,NULL)
404 +/* Store the permissions in the system ACL entry. */
405 +static int store_access_in_entry(uchar access, SMB_ACL_ENTRY_T entry)
407 + const char *errfun = NULL;
408 + SMB_ACL_PERMSET_T permset;
410 + COE( sys_acl_get_permset,(entry, &permset) );
411 + COE( sys_acl_clear_perms,(permset) );
413 + COE( sys_acl_add_perm,(permset, SMB_ACL_READ) );
415 + COE( sys_acl_add_perm,(permset, SMB_ACL_WRITE) );
417 + COE( sys_acl_add_perm,(permset, SMB_ACL_EXECUTE) );
418 + COE( sys_acl_set_permset,(entry, permset) );
423 + rsyserr(FERROR, errno, "store_access_in_entry %s()", errfun);
427 +/* Pack rsync ACL -> system ACL verbatim. Return whether we succeeded. */
428 +static BOOL pack_smb_acl(SMB_ACL_T *smb_acl, const rsync_acl *racl)
430 +#ifdef ACLS_NEED_MASK
435 + const char *errfun = NULL;
436 + SMB_ACL_ENTRY_T entry;
438 + if (!(*smb_acl = sys_acl_init(calc_sacl_entries(racl)))) {
439 + rsyserr(FERROR, errno, "pack_smb_acl: sys_acl_init()");
443 + COE( sys_acl_create_entry,(smb_acl, &entry) );
444 + COE( sys_acl_set_tag_type,(entry, SMB_ACL_USER_OBJ) );
445 + COE2( store_access_in_entry,(racl->user_obj & 7, entry) );
447 + for (ida = racl->users.idas, count = racl->users.count; count--; ida++) {
448 + COE( sys_acl_create_entry,(smb_acl, &entry) );
449 + COE( sys_acl_set_tag_type,(entry, SMB_ACL_USER) );
450 + COE( sys_acl_set_qualifier,(entry, (void*)&ida->id) );
451 + COE2( store_access_in_entry,(ida->access, entry) );
454 + COE( sys_acl_create_entry,(smb_acl, &entry) );
455 + COE( sys_acl_set_tag_type,(entry, SMB_ACL_GROUP_OBJ) );
456 + COE2( store_access_in_entry,(racl->group_obj & 7, entry) );
458 + for (ida = racl->groups.idas, count = racl->groups.count; count--; ida++) {
459 + COE( sys_acl_create_entry,(smb_acl, &entry) );
460 + COE( sys_acl_set_tag_type,(entry, SMB_ACL_GROUP) );
461 + COE( sys_acl_set_qualifier,(entry, (void*)&ida->id) );
462 + COE2( store_access_in_entry,(ida->access, entry) );
465 +#ifdef ACLS_NEED_MASK
466 + mask_bits = racl->mask == NO_ENTRY ? racl->group_obj & 7 : racl->mask;
467 + COE( sys_acl_create_entry,(smb_acl, &entry) );
468 + COE( sys_acl_set_tag_type,(entry, SMB_ACL_MASK) );
469 + COE2( store_access_in_entry,(mask_bits, entry) );
471 + if (racl->mask != NO_ENTRY) {
472 + COE( sys_acl_create_entry,(smb_acl, &entry) );
473 + COE( sys_acl_set_tag_type,(entry, SMB_ACL_MASK) );
474 + COE2( store_access_in_entry,(racl->mask, entry) );
478 + COE( sys_acl_create_entry,(smb_acl, &entry) );
479 + COE( sys_acl_set_tag_type,(entry, SMB_ACL_OTHER) );
480 + COE2( store_access_in_entry,(racl->other & 7, entry) );
483 + if (sys_acl_valid(*smb_acl) < 0)
484 + rprintf(FERROR, "pack_smb_acl: warning: system says the ACL I packed is invalid\n");
491 + rsyserr(FERROR, errno, "pack_smb_acl %s()", errfun);
493 + sys_acl_free_acl(*smb_acl);
497 +static int find_matching_rsync_acl(SMB_ACL_TYPE_T type,
498 + const item_list *racl_list,
499 + const rsync_acl *racl)
501 + static int access_match = -1, default_match = -1;
502 + int *match = type == SMB_ACL_TYPE_ACCESS ? &access_match : &default_match;
503 + size_t count = racl_list->count;
505 + /* If this is the first time through or we didn't match the last
506 + * time, then start at the end of the list, which should be the
507 + * best place to start hunting. */
509 + *match = racl_list->count - 1;
511 + rsync_acl *base = racl_list->items;
512 + if (rsync_acl_equal(base + *match, racl))
515 + *match = racl_list->count - 1;
522 +/* Return the Access Control List for the given filename. */
523 +int get_acl(const char *fname, statx *sxp)
525 + SMB_ACL_TYPE_T type;
527 + if (S_ISLNK(sxp->st.st_mode))
530 + type = SMB_ACL_TYPE_ACCESS;
532 + SMB_ACL_T sacl = sys_acl_get_file(fname, type);
533 + rsync_acl *racl = new(rsync_acl);
536 + out_of_memory("get_acl");
537 + *racl = empty_rsync_acl;
538 + if (type == SMB_ACL_TYPE_ACCESS)
539 + sxp->acc_acl = racl;
541 + sxp->def_acl = racl;
544 + BOOL ok = unpack_smb_acl(racl, sacl);
546 + sys_acl_free_acl(sacl);
551 + } else if (errno == ENOTSUP || errno == ENOSYS) {
552 + /* ACLs are not supported, so pretend we have a basic ACL. */
553 + if (type == SMB_ACL_TYPE_ACCESS)
554 + rsync_acl_fake_perms(racl, sxp->st.st_mode);
556 + rsyserr(FERROR, errno, "get_acl: sys_acl_get_file(%s, %s)",
557 + fname, str_acl_type(type));
561 + } while (BUMP_TYPE(type) && S_ISDIR(sxp->st.st_mode));
566 +/* === Send functions === */
568 +/* The general strategy with the tag_type <-> character mapping is that
569 + * lowercase implies that no qualifier follows, where uppercase does.
570 + * A similar idiom for the ACL type (access or default) itself, but
571 + * lowercase in this instance means there's no ACL following, so the
572 + * ACL is a repeat, so the receiver should reuse the last of the same
575 +/* Send the ida list over the file descriptor. */
576 +static void send_ida_entries(int f, const ida_entries *idal, char tag_char)
579 + size_t count = idal->count;
580 + for (ida = idal->idas; count--; ida++) {
581 + write_byte(f, tag_char);
582 + write_byte(f, ida->access);
583 + write_int(f, ida->id);
584 + /* FIXME: sorta wasteful: we should maybe buffer as
585 + * many ids as max(ACL_USER + ACL_GROUP) objects to
586 + * keep from making so many calls. */
587 + if (tag_char == 'U')
594 +/* Send an rsync ACL over the file descriptor. */
595 +static void send_rsync_acl(int f, const rsync_acl *racl)
597 + size_t count = count_racl_entries(racl);
598 + write_int(f, count);
599 + if (racl->user_obj != NO_ENTRY) {
600 + write_byte(f, 'u');
601 + write_byte(f, racl->user_obj);
603 + send_ida_entries(f, &racl->users, 'U');
604 + if (racl->group_obj != NO_ENTRY) {
605 + write_byte(f, 'g');
606 + write_byte(f, racl->group_obj);
608 + send_ida_entries(f, &racl->groups, 'G');
609 + if (racl->mask != NO_ENTRY) {
610 + write_byte(f, 'm');
611 + write_byte(f, racl->mask);
613 + if (racl->other != NO_ENTRY) {
614 + write_byte(f, 'o');
615 + write_byte(f, racl->other);
619 +/* Send the ACL from the statx structure down the indicated file descriptor.
620 + * This also frees the ACL data. */
621 +void send_acl(statx *sxp, int f)
623 + SMB_ACL_TYPE_T type;
624 + rsync_acl *racl, *new_racl;
625 + item_list *racl_list;
628 + if (S_ISLNK(sxp->st.st_mode))
631 + type = SMB_ACL_TYPE_ACCESS;
632 + racl = sxp->acc_acl;
633 + racl_list = &access_acl_list;
636 + racl = new(rsync_acl);
638 + out_of_memory("send_acl");
639 + *racl = empty_rsync_acl;
640 + if (type == SMB_ACL_TYPE_ACCESS) {
641 + rsync_acl_fake_perms(racl, sxp->st.st_mode);
642 + sxp->acc_acl = racl;
644 + sxp->def_acl = racl;
647 + /* Avoid sending values that can be inferred from other data. */
648 + if (type == SMB_ACL_TYPE_ACCESS && protocol_version >= 30)
649 + rsync_acl_strip_perms(racl);
650 + if ((ndx = find_matching_rsync_acl(type, racl_list, racl)) != -1) {
651 + write_byte(f, type == SMB_ACL_TYPE_ACCESS ? 'a' : 'd');
654 + new_racl = EXPAND_ITEM_LIST(racl_list, rsync_acl, 1000);
655 + write_byte(f, type == SMB_ACL_TYPE_ACCESS ? 'A' : 'D');
656 + send_rsync_acl(f, racl);
658 + *racl = empty_rsync_acl;
660 + racl = sxp->def_acl;
661 + racl_list = &default_acl_list;
662 + } while (BUMP_TYPE(type) && S_ISDIR(sxp->st.st_mode));
667 +/* === Receive functions === */
669 +static void receive_rsync_acl(rsync_acl *racl, int f, SMB_ACL_TYPE_T type)
671 + static item_list temp_ida_list = EMPTY_ITEM_LIST;
672 + SMB_ACL_TAG_T tag_type = 0, prior_list_type = 0;
673 + uchar computed_mask_bits = 0;
677 + if (!(count = read_int(f)))
681 + char tag = read_byte(f);
682 + uchar access = read_byte(f);
683 + if (access & ~ (4 | 2 | 1)) {
684 + rprintf(FERROR, "receive_rsync_acl: bogus permset %o\n",
686 + exit_cleanup(RERR_STREAMIO);
690 + if (racl->user_obj != NO_ENTRY) {
691 + rprintf(FERROR, "receive_rsync_acl: error: duplicate USER_OBJ entry\n");
692 + exit_cleanup(RERR_STREAMIO);
694 + racl->user_obj = access;
697 + tag_type = SMB_ACL_USER;
700 + if (racl->group_obj != NO_ENTRY) {
701 + rprintf(FERROR, "receive_rsync_acl: error: duplicate GROUP_OBJ entry\n");
702 + exit_cleanup(RERR_STREAMIO);
704 + racl->group_obj = access;
707 + tag_type = SMB_ACL_GROUP;
710 + if (racl->mask != NO_ENTRY) {
711 + rprintf(FERROR, "receive_rsync_acl: error: duplicate MASK entry\n");
712 + exit_cleanup(RERR_STREAMIO);
714 + racl->mask = access;
717 + if (racl->other != NO_ENTRY) {
718 + rprintf(FERROR, "receive_rsync_acl: error: duplicate OTHER entry\n");
719 + exit_cleanup(RERR_STREAMIO);
721 + racl->other = access;
724 + rprintf(FERROR, "receive_rsync_acl: unknown tag %c\n",
726 + exit_cleanup(RERR_STREAMIO);
728 + if (tag_type != prior_list_type) {
729 + if (prior_list_type)
730 + save_idas(&temp_ida_list, racl, prior_list_type);
731 + prior_list_type = tag_type;
733 + ida = EXPAND_ITEM_LIST(&temp_ida_list, id_access, -10);
734 + ida->access = access;
735 + ida->id = read_int(f);
736 + computed_mask_bits |= access;
738 + if (prior_list_type)
739 + save_idas(&temp_ida_list, racl, prior_list_type);
741 + if (type == SMB_ACL_TYPE_DEFAULT) {
742 + /* Ensure that these are never unset. */
743 + if (racl->user_obj == NO_ENTRY)
744 + racl->user_obj = 7;
745 + if (racl->group_obj == NO_ENTRY)
746 + racl->group_obj = 0;
747 + if (racl->other == NO_ENTRY)
751 + if (!racl->users.count && !racl->groups.count) {
752 + /* If we received a superfluous mask, throw it away. */
753 + if (racl->mask != NO_ENTRY) {
754 + /* Mask off the group perms with it first. */
755 + racl->group_obj &= racl->mask | NO_ENTRY;
756 + racl->mask = NO_ENTRY;
758 + } else if (racl->mask == NO_ENTRY) /* Must be non-empty with lists. */
759 + racl->mask = computed_mask_bits | (racl->group_obj & 7);
762 +/* Receive the ACL info the sender has included for this file-list entry. */
763 +void receive_acl(struct file_struct *file, int f)
765 + SMB_ACL_TYPE_T type;
766 + item_list *racl_list;
768 + if (S_ISLNK(file->mode))
771 + type = SMB_ACL_TYPE_ACCESS;
772 + racl_list = &access_acl_list;
774 + char tag = read_byte(f);
777 + if (tag == 'A' || tag == 'a') {
778 + if (type != SMB_ACL_TYPE_ACCESS) {
779 + rprintf(FERROR, "receive_acl %s: duplicate access ACL\n",
780 + f_name(file, NULL));
781 + exit_cleanup(RERR_STREAMIO);
783 + } else if (tag == 'D' || tag == 'd') {
784 + if (type == SMB_ACL_TYPE_ACCESS) {
785 + rprintf(FERROR, "receive_acl %s: expecting access ACL; got default\n",
786 + f_name(file, NULL));
787 + exit_cleanup(RERR_STREAMIO);
790 + rprintf(FERROR, "receive_acl %s: unknown ACL type tag: %c\n",
791 + f_name(file, NULL), tag);
792 + exit_cleanup(RERR_STREAMIO);
794 + if (tag == 'A' || tag == 'D') {
796 + ndx = racl_list->count;
797 + duo_item = EXPAND_ITEM_LIST(racl_list, acl_duo, 1000);
798 + duo_item->racl = empty_rsync_acl;
799 + receive_rsync_acl(&duo_item->racl, f, type);
800 + duo_item->sacl = NULL;
803 + if (ndx < 0 || (size_t)ndx >= racl_list->count) {
804 + rprintf(FERROR, "receive_acl %s: %s ACL index %d out of range\n",
805 + f_name(file, NULL), str_acl_type(type), ndx);
806 + exit_cleanup(RERR_STREAMIO);
809 + if (type == SMB_ACL_TYPE_ACCESS)
812 + F_DEF_ACL(file) = ndx;
813 + racl_list = &default_acl_list;
814 + } while (BUMP_TYPE(type) && S_ISDIR(file->mode));
817 +/* Turn the ACL data in statx into cached ACL data, setting the index
818 + * values in the file struct. */
819 +void cache_acl(struct file_struct *file, statx *sxp)
821 + SMB_ACL_TYPE_T type;
823 + item_list *racl_list;
826 + if (S_ISLNK(file->mode))
829 + type = SMB_ACL_TYPE_ACCESS;
830 + racl = sxp->acc_acl;
831 + racl_list = &access_acl_list;
835 + else if ((ndx = find_matching_rsync_acl(type, racl_list, racl)) == -1) {
837 + ndx = racl_list->count;
838 + new_duo = EXPAND_ITEM_LIST(racl_list, acl_duo, 1000);
839 + new_duo->racl = *racl;
840 + new_duo->sacl = NULL;
841 + *racl = empty_rsync_acl;
843 + if (type == SMB_ACL_TYPE_ACCESS)
846 + F_DEF_ACL(file) = ndx;
847 + racl = sxp->def_acl;
848 + racl_list = &default_acl_list;
849 + } while (BUMP_TYPE(type) && S_ISDIR(sxp->st.st_mode));
854 +static mode_t change_sacl_perms(SMB_ACL_T sacl, rsync_acl *racl, mode_t old_mode, mode_t mode)
856 + SMB_ACL_ENTRY_T entry;
857 + const char *errfun;
860 + if (S_ISDIR(mode)) {
861 + /* If the sticky bit is going on, it's not safe to allow all
862 + * the new ACL to go into effect before it gets set. */
863 +#ifdef SMB_ACL_LOSES_SPECIAL_MODE_BITS
864 + if (mode & S_ISVTX)
867 + if (mode & S_ISVTX && !(old_mode & S_ISVTX))
870 + /* If setuid or setgid is going off, it's not safe to allow all
871 + * the new ACL to go into effect before they get cleared. */
872 + if ((old_mode & S_ISUID && !(mode & S_ISUID))
873 + || (old_mode & S_ISGID && !(mode & S_ISGID)))
878 + errfun = "sys_acl_get_entry";
879 + for (rc = sys_acl_get_entry(sacl, SMB_ACL_FIRST_ENTRY, &entry);
881 + rc = sys_acl_get_entry(sacl, SMB_ACL_NEXT_ENTRY, &entry)) {
882 + SMB_ACL_TAG_T tag_type;
883 + if ((rc = sys_acl_get_tag_type(entry, &tag_type))) {
884 + errfun = "sys_acl_get_tag_type";
887 + switch (tag_type) {
888 + case SMB_ACL_USER_OBJ:
889 + COE2( store_access_in_entry,((mode >> 6) & 7, entry) );
891 + case SMB_ACL_GROUP_OBJ:
892 + /* group is only empty when identical to group perms. */
893 + if (racl->group_obj != NO_ENTRY)
895 + COE2( store_access_in_entry,((mode >> 3) & 7, entry) );
898 +#ifndef ACLS_NEED_MASK
899 + /* mask is only empty when we don't need it. */
900 + if (racl->mask == NO_ENTRY)
903 + COE2( store_access_in_entry,((mode >> 3) & 7, entry) );
905 + case SMB_ACL_OTHER:
906 + COE2( store_access_in_entry,(mode & 7, entry) );
913 + rsyserr(FERROR, errno, "change_sacl_perms: %s()",
919 +#ifdef SMB_ACL_LOSES_SPECIAL_MODE_BITS
920 + /* Ensure that chmod() will be called to restore any lost setid bits. */
921 + if (old_mode & (S_ISUID | S_ISGID | S_ISVTX)
922 + && BITS_EQUAL(old_mode, mode, CHMOD_BITS))
923 + old_mode &= ~(S_ISUID | S_ISGID | S_ISVTX);
926 + /* Return the mode of the file on disk, as we will set them. */
927 + return (old_mode & ~ACCESSPERMS) | (mode & ACCESSPERMS);
930 +/* Set ACL on indicated filename.
932 + * This sets extended access ACL entries and default ACL. If convenient,
933 + * it sets permission bits along with the access ACL and signals having
934 + * done so by modifying sxp->st.st_mode.
936 + * Returns 1 for unchanged, 0 for changed, -1 for failed. Call this
937 + * with fname set to NULL to just check if the ACL is unchanged. */
938 +int set_acl(const char *fname, const struct file_struct *file, statx *sxp)
941 + SMB_ACL_TYPE_T type;
943 + if (!dry_run && (read_only || list_only)) {
948 + if (S_ISLNK(file->mode))
951 + type = SMB_ACL_TYPE_ACCESS;
957 + if (type == SMB_ACL_TYPE_ACCESS) {
959 + if (ndx < 0 || (size_t)ndx >= access_acl_list.count)
961 + duo_item = access_acl_list.items;
964 + && rsync_acl_equal_enough(sxp->acc_acl, &duo_item->racl, file->mode);
966 + ndx = F_DEF_ACL(file);
967 + if (ndx < 0 || (size_t)ndx >= default_acl_list.count)
969 + duo_item = default_acl_list.items;
972 + && rsync_acl_equal(sxp->def_acl, &duo_item->racl);
976 + if (!dry_run && fname) {
977 + if (type == SMB_ACL_TYPE_DEFAULT
978 + && duo_item->racl.user_obj == NO_ENTRY) {
979 + if (sys_acl_delete_def_file(fname) < 0) {
980 + rsyserr(FERROR, errno, "set_acl: sys_acl_delete_def_file(%s)",
986 + mode_t cur_mode = sxp->st.st_mode;
987 + if (!duo_item->sacl
988 + && !pack_smb_acl(&duo_item->sacl, &duo_item->racl)) {
992 + if (type == SMB_ACL_TYPE_ACCESS) {
993 + cur_mode = change_sacl_perms(duo_item->sacl, &duo_item->racl,
994 + cur_mode, file->mode);
995 + if (cur_mode == (mode_t)~0)
998 + if (sys_acl_set_file(fname, type, duo_item->sacl) < 0) {
999 + rsyserr(FERROR, errno, "set_acl: sys_acl_set_file(%s, %s)",
1000 + fname, str_acl_type(type));
1004 + if (type == SMB_ACL_TYPE_ACCESS)
1005 + sxp->st.st_mode = cur_mode;
1008 + if (unchanged == 1)
1010 + } while (BUMP_TYPE(type) && S_ISDIR(file->mode));
1015 +/* === Enumeration functions for uid mapping === */
1017 +/* Context -- one and only one. Should be cycled through once on uid
1018 + * mapping and once on gid mapping. */
1019 +static item_list *_enum_racl_lists[] = {
1020 + &access_acl_list, &default_acl_list, NULL
1023 +static item_list **enum_racl_list = &_enum_racl_lists[0];
1024 +static int enum_ida_index = 0;
1025 +static size_t enum_racl_index = 0;
1027 +/* This returns the next tag_type id from the given ACL for the next entry,
1028 + * or it returns 0 if there are no more tag_type ids in the acl. */
1029 +static id_t *next_ace_id(SMB_ACL_TAG_T tag_type, const rsync_acl *racl)
1031 + const ida_entries *idal = tag_type == SMB_ACL_USER ? &racl->users : &racl->groups;
1032 + if (enum_ida_index < idal->count) {
1033 + id_access *ida = &idal->idas[enum_ida_index++];
1036 + enum_ida_index = 0;
1040 +static id_t *next_acl_id(SMB_ACL_TAG_T tag_type, const item_list *racl_list)
1042 + for (; enum_racl_index < racl_list->count; enum_racl_index++) {
1044 + acl_duo *duo_item = racl_list->items;
1045 + duo_item += enum_racl_index;
1046 + if ((id = next_ace_id(tag_type, &duo_item->racl)) != NULL)
1049 + enum_racl_index = 0;
1053 +static id_t *next_acl_list_id(SMB_ACL_TAG_T tag_type)
1055 + for (; *enum_racl_list; enum_racl_list++) {
1056 + id_t *id = next_acl_id(tag_type, *enum_racl_list);
1060 + enum_racl_list = &_enum_racl_lists[0];
1064 +id_t *next_acl_uid()
1066 + return next_acl_list_id(SMB_ACL_USER);
1069 +id_t *next_acl_gid()
1071 + return next_acl_list_id(SMB_ACL_GROUP);
1074 +/* This is used by dest_mode(). */
1075 +int default_perms_for_dir(const char *dir)
1084 + perms = ACCESSPERMS & ~orig_umask;
1085 + /* Read the directory's default ACL. If it has none, this will successfully return an empty ACL. */
1086 + sacl = sys_acl_get_file(dir, SMB_ACL_TYPE_DEFAULT);
1087 + if (sacl == NULL) {
1088 + /* Couldn't get an ACL. Darn. */
1092 + /* No ACLs are available. */
1096 + /* We're doing a dry run, so the containing directory
1097 + * wasn't actually created. Don't worry about it. */
1100 + /* Otherwise fall through. */
1102 + rprintf(FERROR, "default_perms_for_dir: sys_acl_get_file(%s, %s): %s, falling back on umask\n",
1103 + dir, str_acl_type(SMB_ACL_TYPE_DEFAULT), strerror(errno));
1109 + racl = empty_rsync_acl;
1110 + ok = unpack_smb_acl(&racl, sacl);
1111 + sys_acl_free_acl(sacl);
1113 + rprintf(FERROR, "default_perms_for_dir: unpack_smb_acl failed, falling back on umask\n");
1117 + /* Apply the permission-bit entries of the default ACL, if any. */
1118 + if (racl.user_obj != NO_ENTRY) {
1119 + perms = rsync_acl_get_perms(&racl);
1121 + rprintf(FINFO, "got ACL-based default perms %o for directory %s\n", perms, dir);
1124 + rsync_acl_free(&racl);
1128 +#endif /* SUPPORT_ACLS */
1135 +extern int preserve_acls;
1136 extern int preserve_devices;
1137 extern int preserve_specials;
1138 extern int preserve_links;
1139 @@ -93,7 +94,8 @@ path
1140 ****************************************************************************/
1141 static int make_bak_dir(char *fullpath)
1145 + struct file_struct *file;
1146 char *rel = fullpath + backup_dir_len;
1147 char *end = rel + strlen(rel);
1149 @@ -125,15 +127,24 @@ static int make_bak_dir(char *fullpath)
1151 /* Try to transfer the directory settings of the
1152 * actual dir that the files are coming from. */
1153 - if (do_stat(rel, &st) < 0) {
1154 + if (do_stat(rel, &sx.st) < 0) {
1155 rsyserr(FERROR, errno,
1156 "make_bak_dir stat %s failed",
1159 - do_lchown(fullpath, st.st_uid, st.st_gid);
1161 - do_chmod(fullpath, st.st_mode);
1162 +#ifdef SUPPORT_ACLS
1163 + sx.acc_acl = sx.def_acl = NULL;
1165 + if (!(file = make_file(rel, NULL, NULL, 0, NO_FILTERS)))
1167 +#ifdef SUPPORT_ACLS
1168 + if (preserve_acls) {
1169 + get_acl(rel, &sx);
1170 + cache_acl(file, &sx);
1173 + set_file_attrs(fullpath, file, NULL, 0);
1178 @@ -171,15 +182,18 @@ static int robust_move(const char *src,
1179 * We will move the file to be deleted into a parallel directory tree. */
1180 static int keep_backup(const char *fname)
1184 struct file_struct *file;
1189 /* return if no file to keep */
1190 - if (do_lstat(fname, &st) < 0)
1191 + if (do_lstat(fname, &sx.st) < 0)
1193 +#ifdef SUPPORT_ACLS
1194 + sx.acc_acl = sx.def_acl = NULL;
1197 if (!(file = make_file(fname, NULL, NULL, 0, NO_FILTERS)))
1198 return 1; /* the file could have disappeared */
1199 @@ -189,6 +203,13 @@ static int keep_backup(const char *fname
1203 +#ifdef SUPPORT_ACLS
1204 + if (preserve_acls) {
1205 + get_acl(fname, &sx);
1206 + cache_acl(file, &sx);
1210 /* Check to see if this is a device file, or link */
1211 if ((am_root && preserve_devices && IS_DEVICE(file->mode))
1212 || (preserve_specials && IS_SPECIAL(file->mode))) {
1213 @@ -260,7 +281,7 @@ static int keep_backup(const char *fname
1214 if (robust_move(fname, buf) != 0) {
1215 rsyserr(FERROR, errno, "keep_backup failed: %s -> \"%s\"",
1216 full_fname(fname), buf);
1217 - } else if (st.st_nlink > 1) {
1218 + } else if (sx.st.st_nlink > 1) {
1219 /* If someone has hard-linked the file into the backup
1220 * dir, rename() might return success but do nothing! */
1221 robust_unlink(fname); /* Just in case... */
1224 @@ -56,6 +56,8 @@ void setup_protocol(int f_out,int f_in)
1225 preserve_uid = ++file_extra_cnt;
1227 preserve_gid = ++file_extra_cnt;
1228 + if (preserve_acls && !am_sender)
1229 + preserve_acls = ++file_extra_cnt;
1231 if (remote_protocol == 0) {
1233 --- old/configure.in
1234 +++ new/configure.in
1235 @@ -542,6 +542,11 @@ if test x"$ac_cv_func_strcasecmp" = x"no
1236 AC_CHECK_LIB(resolv, strcasecmp)
1239 +AC_CHECK_FUNCS(aclsort)
1240 +if test x"$ac_cv_func_aclsort" = x"no"; then
1241 + AC_CHECK_LIB(sec, aclsort)
1244 dnl At the moment we don't test for a broken memcmp(), because all we
1245 dnl need to do is test for equality, not comparison, and it seems that
1246 dnl every platform has a memcmp that can do at least that.
1247 @@ -806,6 +811,78 @@ AC_SUBST(OBJ_RESTORE)
1248 AC_SUBST(CC_SHOBJ_FLAG)
1249 AC_SUBST(BUILD_POPT)
1251 +AC_CHECK_HEADERS(sys/acl.h acl/libacl.h)
1252 +AC_CHECK_FUNCS(_acl __acl _facl __facl)
1253 +#################################################
1254 +# check for ACL support
1256 +AC_MSG_CHECKING(whether to support ACLs)
1257 +AC_ARG_ENABLE(acl-support,
1258 +AC_HELP_STRING([--enable-acl-support], [Include ACL support (default=no)]),
1259 +[ case "$enableval" in
1262 + case "$host_os" in
1264 + AC_MSG_RESULT(Using UnixWare ACLs)
1265 + AC_DEFINE(HAVE_UNIXWARE_ACLS, 1, [true if you have UnixWare ACLs])
1267 + *solaris*|*cygwin*)
1268 + AC_MSG_RESULT(Using solaris ACLs)
1269 + AC_DEFINE(HAVE_SOLARIS_ACLS, 1, [true if you have solaris ACLs])
1272 + AC_MSG_RESULT(Using HPUX ACLs)
1273 + AC_DEFINE(HAVE_HPUX_ACLS, 1, [true if you have HPUX ACLs])
1276 + AC_MSG_RESULT(Using IRIX ACLs)
1277 + AC_DEFINE(HAVE_IRIX_ACLS, 1, [true if you have IRIX ACLs])
1280 + AC_MSG_RESULT(Using AIX ACLs)
1281 + AC_DEFINE(HAVE_AIX_ACLS, 1, [true if you have AIX ACLs])
1284 + AC_MSG_RESULT(Using Tru64 ACLs)
1285 + AC_DEFINE(HAVE_TRU64_ACLS, 1, [true if you have Tru64 ACLs])
1286 + LIBS="$LIBS -lpacl"
1289 + AC_MSG_RESULT(ACLs requested -- running tests)
1290 + AC_CHECK_LIB(acl,acl_get_file)
1291 + AC_CACHE_CHECK([for ACL support],samba_cv_HAVE_POSIX_ACLS,[
1292 + AC_TRY_LINK([#include <sys/types.h>
1293 +#include <sys/acl.h>],
1294 +[ acl_t acl; int entry_id; acl_entry_t *entry_p; return acl_get_entry( acl, entry_id, entry_p);],
1295 +samba_cv_HAVE_POSIX_ACLS=yes,samba_cv_HAVE_POSIX_ACLS=no)])
1296 + AC_MSG_CHECKING(ACL test results)
1297 + if test x"$samba_cv_HAVE_POSIX_ACLS" = x"yes"; then
1298 + AC_MSG_RESULT(Using posix ACLs)
1299 + AC_DEFINE(HAVE_POSIX_ACLS, 1, [true if you have posix ACLs])
1300 + AC_CACHE_CHECK([for acl_get_perm_np],samba_cv_HAVE_ACL_GET_PERM_NP,[
1301 + AC_TRY_LINK([#include <sys/types.h>
1302 +#include <sys/acl.h>],
1303 +[ acl_permset_t permset_d; acl_perm_t perm; return acl_get_perm_np( permset_d, perm);],
1304 +samba_cv_HAVE_ACL_GET_PERM_NP=yes,samba_cv_HAVE_ACL_GET_PERM_NP=no)])
1305 + if test x"$samba_cv_HAVE_ACL_GET_PERM_NP" = x"yes"; then
1306 + AC_DEFINE(HAVE_ACL_GET_PERM_NP, 1, [true if you have acl_get_perm_np])
1309 + AC_MSG_ERROR(Failed to find ACL support)
1316 + AC_DEFINE(HAVE_NO_ACLS, 1, [true if you don't have ACLs])
1319 + AC_DEFINE(HAVE_NO_ACLS, 1, [true if you don't have ACLs])
1323 AC_CONFIG_FILES([Makefile lib/dummy zlib/dummy popt/dummy shconfig])
1328 @@ -42,6 +42,7 @@ extern int filesfrom_fd;
1329 extern int one_file_system;
1330 extern int copy_dirlinks;
1331 extern int keep_dirlinks;
1332 +extern int preserve_acls;
1333 extern int preserve_links;
1334 extern int preserve_hard_links;
1335 extern int preserve_devices;
1336 @@ -153,6 +154,8 @@ static void list_file_entry(struct file_
1337 permstring(permbuf, f->mode);
1340 + /* TODO: indicate '+' if the entry has an ACL. */
1342 #ifdef SUPPORT_LINKS
1343 if (preserve_links && S_ISLNK(f->mode)) {
1344 rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
1345 @@ -715,6 +718,12 @@ static struct file_struct *recv_file_ent
1349 +#ifdef SUPPORT_ACLS
1350 + /* We need one or two index int32s when we're preserving ACLs. */
1351 + if (preserve_acls)
1352 + extra_len += (S_ISDIR(mode) ? 2 : 1) * EXTRA_LEN;
1355 if (always_checksum && S_ISREG(mode))
1356 extra_len += SUM_EXTRA_CNT * EXTRA_LEN;
1358 @@ -852,6 +861,11 @@ static struct file_struct *recv_file_ent
1359 read_buf(f, bp, checksum_len);
1362 +#ifdef SUPPORT_ACLS
1363 + if (preserve_acls)
1364 + receive_acl(file, f);
1367 if (S_ISREG(mode) || S_ISLNK(mode))
1368 stats.total_size += file_length;
1370 @@ -1123,6 +1137,9 @@ static struct file_struct *send_file_nam
1371 int flags, int filter_flags)
1373 struct file_struct *file;
1374 +#ifdef SUPPORT_ACLS
1378 file = make_file(fname, flist, stp, flags, filter_flags);
1380 @@ -1131,12 +1148,26 @@ static struct file_struct *send_file_nam
1381 if (chmod_modes && !S_ISLNK(file->mode))
1382 file->mode = tweak_mode(file->mode, chmod_modes);
1384 +#ifdef SUPPORT_ACLS
1385 + if (preserve_acls && f >= 0) {
1386 + sx.st.st_mode = file->mode;
1387 + sx.acc_acl = sx.def_acl = NULL;
1388 + if (get_acl(fname, &sx) < 0)
1393 maybe_emit_filelist_progress(flist->count + flist_count_offset);
1395 flist_expand(flist);
1396 flist->files[flist->count++] = file;
1399 send_file_entry(f, file, flist->count - 1);
1400 +#ifdef SUPPORT_ACLS
1401 + if (preserve_acls)
1410 @@ -36,6 +36,7 @@ extern int do_progress;
1411 extern int relative_paths;
1412 extern int implied_dirs;
1413 extern int keep_dirlinks;
1414 +extern int preserve_acls;
1415 extern int preserve_links;
1416 extern int preserve_devices;
1417 extern int preserve_specials;
1418 @@ -90,6 +91,7 @@ extern int force_delete;
1419 extern int one_file_system;
1420 extern struct stats stats;
1421 extern dev_t filesystem_dev;
1422 +extern mode_t orig_umask;
1423 extern char *backup_dir;
1424 extern char *backup_suffix;
1425 extern int backup_suffix_len;
1426 @@ -512,22 +514,27 @@ static void do_delete_pass(struct file_l
1427 rprintf(FINFO, " \r");
1430 -int unchanged_attrs(struct file_struct *file, STRUCT_STAT *st)
1431 +int unchanged_attrs(struct file_struct *file, statx *sxp)
1433 - if (preserve_perms && !BITS_EQUAL(st->st_mode, file->mode, CHMOD_BITS))
1434 + if (preserve_perms && !BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
1437 - if (am_root && preserve_uid && st->st_uid != F_UID(file))
1438 + if (am_root && preserve_uid && sxp->st.st_uid != F_UID(file))
1441 - if (preserve_gid && F_GID(file) != GID_NONE && st->st_gid != F_GID(file))
1442 + if (preserve_gid && F_GID(file) != GID_NONE && sxp->st.st_gid != F_GID(file))
1445 +#ifdef SUPPORT_ACLS
1446 + if (preserve_acls && set_acl(NULL, file, sxp) == 0)
1453 void itemize(struct file_struct *file, int ndx, int statret,
1454 - STRUCT_STAT *st, int32 iflags, uchar fnamecmp_type,
1455 + statx *sxp, int32 iflags, uchar fnamecmp_type,
1458 if (statret >= 0) { /* A from-dest-dir statret can == 1! */
1459 @@ -535,20 +542,24 @@ void itemize(struct file_struct *file, i
1460 : S_ISDIR(file->mode) ? !omit_dir_times
1461 : !S_ISLNK(file->mode);
1463 - if (S_ISREG(file->mode) && F_LENGTH(file) != st->st_size)
1464 + if (S_ISREG(file->mode) && F_LENGTH(file) != sxp->st.st_size)
1465 iflags |= ITEM_REPORT_SIZE;
1466 if ((iflags & (ITEM_TRANSFER|ITEM_LOCAL_CHANGE) && !keep_time
1467 && !(iflags & ITEM_MATCHED)
1468 && (!(iflags & ITEM_XNAME_FOLLOWS) || *xname))
1469 - || (keep_time && cmp_time(file->modtime, st->st_mtime) != 0))
1470 + || (keep_time && cmp_time(file->modtime, sxp->st.st_mtime) != 0))
1471 iflags |= ITEM_REPORT_TIME;
1472 - if (!BITS_EQUAL(st->st_mode, file->mode, CHMOD_BITS))
1473 + if (!BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
1474 iflags |= ITEM_REPORT_PERMS;
1475 - if (preserve_uid && am_root && F_UID(file) != st->st_uid)
1476 + if (preserve_uid && am_root && F_UID(file) != sxp->st.st_uid)
1477 iflags |= ITEM_REPORT_OWNER;
1478 if (preserve_gid && F_GID(file) != GID_NONE
1479 - && st->st_gid != F_GID(file))
1480 + && sxp->st.st_gid != F_GID(file))
1481 iflags |= ITEM_REPORT_GROUP;
1482 +#ifdef SUPPORT_ACLS
1483 + if (preserve_acls && set_acl(NULL, file, sxp) == 0)
1484 + iflags |= ITEM_REPORT_ACL;
1487 iflags |= ITEM_IS_NEW;
1489 @@ -784,7 +795,7 @@ static int find_fuzzy(struct file_struct
1490 * handling the file, -1 if no dest-linking occurred, or a non-negative
1491 * value if we found an alternate basis file. */
1492 static int try_dests_reg(struct file_struct *file, char *fname, int ndx,
1493 - char *cmpbuf, STRUCT_STAT *stp, int itemizing,
1494 + char *cmpbuf, statx *sxp, int itemizing,
1497 int best_match = -1;
1498 @@ -793,7 +804,7 @@ static int try_dests_reg(struct file_str
1501 pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
1502 - if (link_stat(cmpbuf, stp, 0) < 0 || !S_ISREG(stp->st_mode))
1503 + if (link_stat(cmpbuf, &sxp->st, 0) < 0 || !S_ISREG(sxp->st.st_mode))
1505 switch (match_level) {
1507 @@ -801,16 +812,20 @@ static int try_dests_reg(struct file_str
1511 - if (!unchanged_file(cmpbuf, file, stp))
1512 + if (!unchanged_file(cmpbuf, file, &sxp->st))
1518 - if (!unchanged_attrs(file, stp))
1519 +#ifdef SUPPORT_ACLS
1520 + if (preserve_acls)
1521 + get_acl(cmpbuf, sxp);
1523 + if (!unchanged_attrs(file, sxp))
1525 if (always_checksum > 0 && preserve_times
1526 - && cmp_time(stp->st_mtime, file->modtime))
1527 + && cmp_time(sxp->st.st_mtime, file->modtime))
1531 @@ -825,7 +840,7 @@ static int try_dests_reg(struct file_str
1532 if (j != best_match) {
1534 pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
1535 - if (link_stat(cmpbuf, stp, 0) < 0)
1536 + if (link_stat(cmpbuf, &sxp->st, 0) < 0)
1540 @@ -835,16 +850,25 @@ static int try_dests_reg(struct file_str
1541 if (!hard_link_one(file, fname, cmpbuf, 1))
1543 if (preserve_hard_links && F_IS_HLINKED(file))
1544 - finish_hard_link(file, fname, stp, itemizing, code, j);
1545 + finish_hard_link(file, fname, &sxp->st, itemizing, code, j);
1546 if (itemizing && (verbose > 1 || stdout_format_has_i > 1)) {
1547 - itemize(file, ndx, 1, stp,
1548 +#ifdef SUPPORT_ACLS
1549 + if (preserve_acls && !ACL_READY(*sxp))
1550 + get_acl(fname, sxp);
1552 + itemize(file, ndx, 1, sxp,
1553 ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS,
1559 - itemize(file, ndx, 0, stp, 0, 0, NULL);
1561 +#ifdef SUPPORT_ACLS
1562 + if (preserve_acls && !ACL_READY(*sxp))
1563 + get_acl(fname, sxp);
1565 + itemize(file, ndx, 0, sxp, 0, 0, NULL);
1567 if (verbose > 1 && maybe_ATTRS_REPORT)
1568 rprintf(FCLIENT, "%s is uptodate\n", fname);
1570 @@ -861,8 +885,13 @@ static int try_dests_reg(struct file_str
1575 - itemize(file, ndx, 0, stp, ITEM_LOCAL_CHANGE, 0, NULL);
1577 +#ifdef SUPPORT_ACLS
1578 + if (preserve_acls && !ACL_READY(*sxp))
1579 + get_acl(fname, sxp);
1581 + itemize(file, ndx, 0, sxp, ITEM_LOCAL_CHANGE, 0, NULL);
1583 set_file_attrs(fname, file, NULL, 0);
1584 if (maybe_ATTRS_REPORT
1585 && ((!itemizing && verbose && match_level == 2)
1586 @@ -873,7 +902,7 @@ static int try_dests_reg(struct file_str
1588 #ifdef SUPPORT_HARD_LINKS
1589 if (preserve_hard_links && F_IS_HLINKED(file))
1590 - finish_hard_link(file, fname, stp, itemizing, code, -1);
1591 + finish_hard_link(file, fname, &sxp->st, itemizing, code, -1);
1595 @@ -885,7 +914,7 @@ static int try_dests_reg(struct file_str
1596 * handling the file, or -1 if no dest-linking occurred, or a non-negative
1597 * value if we found an alternate basis file. */
1598 static int try_dests_non(struct file_struct *file, char *fname, int ndx,
1599 - char *cmpbuf, STRUCT_STAT *stp, int itemizing,
1600 + char *cmpbuf, statx *sxp, int itemizing,
1603 char lnk[MAXPATHLEN];
1604 @@ -918,24 +947,24 @@ static int try_dests_non(struct file_str
1607 pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
1608 - if (link_stat(cmpbuf, stp, 0) < 0)
1609 + if (link_stat(cmpbuf, &sxp->st, 0) < 0)
1613 - if (!S_ISDIR(stp->st_mode))
1614 + if (!S_ISDIR(sxp->st.st_mode))
1618 - if (!IS_SPECIAL(stp->st_mode))
1619 + if (!IS_SPECIAL(sxp->st.st_mode))
1623 - if (!IS_DEVICE(stp->st_mode))
1624 + if (!IS_DEVICE(sxp->st.st_mode))
1627 #ifdef SUPPORT_LINKS
1629 - if (!S_ISLNK(stp->st_mode))
1630 + if (!S_ISLNK(sxp->st.st_mode))
1634 @@ -950,7 +979,7 @@ static int try_dests_non(struct file_str
1637 devp = F_RDEV_P(file);
1638 - if (stp->st_rdev != MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp)))
1639 + if (sxp->st.st_rdev != MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp)))
1642 #ifdef SUPPORT_LINKS
1643 @@ -967,7 +996,11 @@ static int try_dests_non(struct file_str
1647 - if (unchanged_attrs(file, stp)) {
1648 +#ifdef SUPPORT_ACLS
1649 + if (preserve_acls)
1650 + get_acl(cmpbuf, sxp);
1652 + if (unchanged_attrs(file, sxp)) {
1656 @@ -980,7 +1013,7 @@ static int try_dests_non(struct file_str
1657 if (j != best_match) {
1659 pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
1660 - if (link_stat(cmpbuf, stp, 0) < 0)
1661 + if (link_stat(cmpbuf, &sxp->st, 0) < 0)
1665 @@ -1011,7 +1044,15 @@ static int try_dests_non(struct file_str
1667 + (match_level == 3 ? ITEM_XNAME_FOLLOWS : 0);
1668 char *lp = match_level == 3 ? "" : NULL;
1669 - itemize(file, ndx, 0, stp, chg + ITEM_MATCHED, 0, lp);
1670 +#ifdef SUPPORT_ACLS
1671 + if (preserve_acls)
1672 + get_acl(fname, sxp);
1674 + itemize(file, ndx, 0, sxp, chg + ITEM_MATCHED, 0, lp);
1675 +#ifdef SUPPORT_ACLS
1676 + if (preserve_acls)
1680 if (verbose > 1 && maybe_ATTRS_REPORT) {
1681 rprintf(FCLIENT, "%s%s is uptodate\n",
1682 @@ -1024,6 +1065,7 @@ static int try_dests_non(struct file_str
1685 static int phase = 0;
1686 +static int dflt_perms;
1688 /* Acts on the indicated item in cur_flist whose name is fname. If a dir,
1689 * make sure it exists, and has the right permissions/timestamp info. For
1690 @@ -1044,7 +1086,8 @@ static void recv_generator(char *fname,
1691 static int need_fuzzy_dirlist = 0;
1692 struct file_struct *fuzzy_file = NULL;
1693 int fd = -1, f_copy = -1;
1694 - STRUCT_STAT st, real_st, partial_st;
1695 + statx sx, real_sx;
1696 + STRUCT_STAT partial_st;
1697 struct file_struct *back_file = NULL;
1698 int statret, real_ret, stat_errno;
1699 char *fnamecmp, *partialptr, *backupptr = NULL;
1700 @@ -1089,6 +1132,9 @@ static void recv_generator(char *fname,
1704 +#ifdef SUPPORT_ACLS
1705 + sx.acc_acl = sx.def_acl = NULL;
1708 if (fuzzy_dirlist) {
1709 flist_free(fuzzy_dirlist);
1710 @@ -1101,7 +1147,7 @@ static void recv_generator(char *fname,
1711 const char *dn = file->dirname ? file->dirname : ".";
1712 if (parent_dirname != dn && strcmp(parent_dirname, dn) != 0) {
1713 if (relative_paths && !implied_dirs
1714 - && do_stat(dn, &st) < 0
1715 + && do_stat(dn, &sx.st) < 0
1716 && create_directory_path(fname) < 0) {
1717 rsyserr(FERROR, errno,
1718 "recv_generator: mkdir %s failed",
1719 @@ -1113,6 +1159,10 @@ static void recv_generator(char *fname,
1722 need_fuzzy_dirlist = 1;
1723 +#ifdef SUPPORT_ACLS
1724 + if (!preserve_perms)
1725 + dflt_perms = default_perms_for_dir(dn);
1728 parent_dirname = dn;
1730 @@ -1122,7 +1172,7 @@ static void recv_generator(char *fname,
1731 need_fuzzy_dirlist = 0;
1734 - statret = link_stat(fname, &st,
1735 + statret = link_stat(fname, &sx.st,
1736 keep_dirlinks && S_ISDIR(file->mode));
1739 @@ -1148,8 +1198,9 @@ static void recv_generator(char *fname,
1740 * mode based on the local permissions and some heuristics. */
1741 if (!preserve_perms) {
1742 int exists = statret == 0
1743 - && S_ISDIR(st.st_mode) == S_ISDIR(file->mode);
1744 - file->mode = dest_mode(file->mode, st.st_mode, exists);
1745 + && S_ISDIR(sx.st.st_mode) == S_ISDIR(file->mode);
1746 + file->mode = dest_mode(file->mode, sx.st.st_mode, dflt_perms,
1750 if (S_ISDIR(file->mode)) {
1751 @@ -1158,8 +1209,8 @@ static void recv_generator(char *fname,
1752 * file of that name and it is *not* a directory, then
1753 * we need to delete it. If it doesn't exist, then
1754 * (perhaps recursively) create it. */
1755 - if (statret == 0 && !S_ISDIR(st.st_mode)) {
1756 - if (delete_item(fname, st.st_mode, "directory", del_opts) != 0)
1757 + if (statret == 0 && !S_ISDIR(sx.st.st_mode)) {
1758 + if (delete_item(fname, sx.st.st_mode, "directory", del_opts) != 0)
1762 @@ -1168,14 +1219,14 @@ static void recv_generator(char *fname,
1769 if (*fname == '.' && fname[1] == '\0')
1773 if (statret != 0 && basis_dir[0] != NULL) {
1774 - int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
1775 + int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
1779 @@ -1184,7 +1235,11 @@ static void recv_generator(char *fname,
1782 if (itemizing && f_out != -1) {
1783 - itemize(file, ndx, statret, &st,
1784 +#ifdef SUPPORT_ACLS
1785 + if (preserve_acls && statret == 0)
1786 + get_acl(fname, &sx);
1788 + itemize(file, ndx, statret, &sx,
1789 statret ? ITEM_LOCAL_CHANGE : 0, 0, NULL);
1791 if (real_ret != 0 && do_mkdir(fname,file->mode) < 0 && errno != EEXIST) {
1792 @@ -1198,31 +1253,31 @@ static void recv_generator(char *fname,
1793 "*** Skipping any contents from this failed directory ***\n");
1794 missing_below = F_DEPTH(file);
1795 file->flags |= FLAG_MISSING_DIR;
1800 - if (set_file_attrs(fname, file, real_ret ? NULL : &real_st, 0)
1801 + if (set_file_attrs(fname, file, real_ret ? NULL : &real_sx, 0)
1802 && verbose && code != FNONE && f_out != -1)
1803 rprintf(code, "%s/\n", fname);
1804 if (real_ret != 0 && one_file_system)
1805 - real_st.st_dev = filesystem_dev;
1806 + real_sx.st.st_dev = filesystem_dev;
1808 if (one_file_system) {
1809 uint32 *devp = F_DIRDEV_P(file);
1810 - DEV_MAJOR(devp) = major(real_st.st_dev);
1811 - DEV_MINOR(devp) = minor(real_st.st_dev);
1812 + DEV_MAJOR(devp) = major(real_sx.st.st_dev);
1813 + DEV_MINOR(devp) = minor(real_sx.st.st_dev);
1816 else if (delete_during && f_out != -1 && !phase && dry_run < 2
1817 && (file->flags & FLAG_XFER_DIR))
1818 - delete_in_dir(cur_flist, fname, file, &real_st.st_dev);
1820 + delete_in_dir(cur_flist, fname, file, &real_sx.st.st_dev);
1824 #ifdef SUPPORT_HARD_LINKS
1825 if (preserve_hard_links && F_HLINK_NOT_FIRST(file)
1826 - && hard_link_check(file, ndx, fname, statret, &st, itemizing, code))
1828 + && hard_link_check(file, ndx, fname, statret, &sx, itemizing, code))
1832 if (preserve_links && S_ISLNK(file->mode)) {
1833 @@ -1242,28 +1297,28 @@ static void recv_generator(char *fname,
1834 char lnk[MAXPATHLEN];
1837 - if (!S_ISLNK(st.st_mode))
1838 + if (!S_ISLNK(sx.st.st_mode))
1840 else if ((len = readlink(fname, lnk, MAXPATHLEN-1)) > 0
1841 && strncmp(lnk, sl, len) == 0 && sl[len] == '\0') {
1842 /* The link is pointing to the right place. */
1844 - itemize(file, ndx, 0, &st, 0, 0, NULL);
1845 - set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
1846 + itemize(file, ndx, 0, &sx, 0, 0, NULL);
1847 + set_file_attrs(fname, file, &sx, maybe_ATTRS_REPORT);
1848 #ifdef SUPPORT_HARD_LINKS
1849 if (preserve_hard_links && F_IS_HLINKED(file))
1850 - finish_hard_link(file, fname, &st, itemizing, code, -1);
1851 + finish_hard_link(file, fname, &sx.st, itemizing, code, -1);
1853 if (remove_source_files == 1)
1854 goto return_with_success;
1858 /* Not the right symlink (or not a symlink), so
1860 - if (delete_item(fname, st.st_mode, "symlink", del_opts) != 0)
1862 + if (delete_item(fname, sx.st.st_mode, "symlink", del_opts) != 0)
1864 } else if (basis_dir[0] != NULL) {
1865 - int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
1866 + int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
1869 #ifndef CAN_HARDLINK_SYMLINK
1870 @@ -1272,7 +1327,7 @@ static void recv_generator(char *fname,
1879 @@ -1280,7 +1335,7 @@ static void recv_generator(char *fname,
1881 #ifdef SUPPORT_HARD_LINKS
1882 if (preserve_hard_links && F_HLINK_NOT_LAST(file))
1886 if (do_symlink(sl, fname) != 0) {
1887 rsyserr(FERROR, errno, "symlink %s -> \"%s\" failed",
1888 @@ -1288,7 +1343,7 @@ static void recv_generator(char *fname,
1890 set_file_attrs(fname, file, NULL, 0);
1892 - itemize(file, ndx, statret, &st,
1893 + itemize(file, ndx, statret, &sx,
1894 ITEM_LOCAL_CHANGE, 0, NULL);
1896 if (code != FNONE && verbose)
1897 @@ -1304,7 +1359,7 @@ static void recv_generator(char *fname,
1898 goto return_with_success;
1905 if ((am_root && preserve_devices && IS_DEVICE(file->mode))
1906 @@ -1314,33 +1369,38 @@ static void recv_generator(char *fname,
1909 if (IS_DEVICE(file->mode)) {
1910 - if (!IS_DEVICE(st.st_mode))
1911 + if (!IS_DEVICE(sx.st.st_mode))
1915 - if (!IS_SPECIAL(st.st_mode))
1916 + if (!IS_SPECIAL(sx.st.st_mode))
1921 - && BITS_EQUAL(st.st_mode, file->mode, _S_IFMT)
1922 - && st.st_rdev == rdev) {
1923 + && BITS_EQUAL(sx.st.st_mode, file->mode, _S_IFMT)
1924 + && sx.st.st_rdev == rdev) {
1925 /* The device or special file is identical. */
1927 - itemize(file, ndx, 0, &st, 0, 0, NULL);
1928 - set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
1930 +#ifdef SUPPORT_ACLS
1931 + if (preserve_acls)
1932 + get_acl(fname, &sx);
1934 + itemize(file, ndx, 0, &sx, 0, 0, NULL);
1936 + set_file_attrs(fname, file, &sx, maybe_ATTRS_REPORT);
1937 #ifdef SUPPORT_HARD_LINKS
1938 if (preserve_hard_links && F_IS_HLINKED(file))
1939 - finish_hard_link(file, fname, &st, itemizing, code, -1);
1940 + finish_hard_link(file, fname, &sx.st, itemizing, code, -1);
1942 if (remove_source_files == 1)
1943 goto return_with_success;
1947 - if (delete_item(fname, st.st_mode, t, del_opts) != 0)
1949 + if (delete_item(fname, sx.st.st_mode, t, del_opts) != 0)
1951 } else if (basis_dir[0] != NULL) {
1952 - int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &st,
1953 + int j = try_dests_non(file, fname, ndx, fnamecmpbuf, &sx,
1956 #ifndef CAN_HARDLINK_SPECIAL
1957 @@ -1349,7 +1409,7 @@ static void recv_generator(char *fname,
1966 @@ -1357,7 +1417,7 @@ static void recv_generator(char *fname,
1968 #ifdef SUPPORT_HARD_LINKS
1969 if (preserve_hard_links && F_HLINK_NOT_LAST(file))
1974 rprintf(FINFO, "mknod(%s, 0%o, [%ld,%ld])\n",
1975 @@ -1370,7 +1430,11 @@ static void recv_generator(char *fname,
1977 set_file_attrs(fname, file, NULL, 0);
1979 - itemize(file, ndx, statret, &st,
1980 +#ifdef SUPPORT_ACLS
1981 + if (preserve_acls && statret == 0)
1982 + get_acl(fname, &sx);
1984 + itemize(file, ndx, statret, &sx,
1985 ITEM_LOCAL_CHANGE, 0, NULL);
1987 if (code != FNONE && verbose)
1988 @@ -1382,14 +1446,14 @@ static void recv_generator(char *fname,
1989 if (remove_source_files == 1)
1990 goto return_with_success;
1996 if (!S_ISREG(file->mode)) {
1998 fname = f_name(file, NULL);
1999 rprintf(FINFO, "skipping non-regular file \"%s\"\n", fname);
2004 if (max_size > 0 && F_LENGTH(file) > max_size) {
2005 @@ -1398,7 +1462,7 @@ static void recv_generator(char *fname,
2006 fname = f_name(file, NULL);
2007 rprintf(FINFO, "%s is over max-size\n", fname);
2012 if (min_size > 0 && F_LENGTH(file) < min_size) {
2014 @@ -1406,39 +1470,39 @@ static void recv_generator(char *fname,
2015 fname = f_name(file, NULL);
2016 rprintf(FINFO, "%s is under min-size\n", fname);
2022 if (ignore_existing > 0 && statret == 0) {
2024 rprintf(FINFO, "%s exists\n", fname);
2029 if (update_only > 0 && statret == 0
2030 - && cmp_time(st.st_mtime, file->modtime) > 0) {
2031 + && cmp_time(sx.st.st_mtime, file->modtime) > 0) {
2033 rprintf(FINFO, "%s is newer\n", fname);
2039 fnamecmp_type = FNAMECMP_FNAME;
2041 - if (statret == 0 && !S_ISREG(st.st_mode)) {
2042 - if (delete_item(fname, st.st_mode, "regular file", del_opts) != 0)
2044 + if (statret == 0 && !S_ISREG(sx.st.st_mode)) {
2045 + if (delete_item(fname, sx.st.st_mode, "regular file", del_opts) != 0)
2048 stat_errno = ENOENT;
2051 if (statret != 0 && basis_dir[0] != NULL) {
2052 - int j = try_dests_reg(file, fname, ndx, fnamecmpbuf, &st,
2053 + int j = try_dests_reg(file, fname, ndx, fnamecmpbuf, &sx,
2056 if (remove_source_files == 1)
2057 goto return_with_success;
2062 fnamecmp = fnamecmpbuf;
2063 @@ -1448,7 +1512,7 @@ static void recv_generator(char *fname,
2070 if (partial_dir && (partialptr = partial_dir_fname(fname)) != NULL
2071 && link_stat(partialptr, &partial_st, 0) == 0
2072 @@ -1467,7 +1531,7 @@ static void recv_generator(char *fname,
2073 rprintf(FINFO, "fuzzy basis selected for %s: %s\n",
2074 fname, fnamecmpbuf);
2076 - st.st_size = F_LENGTH(fuzzy_file);
2077 + sx.st.st_size = F_LENGTH(fuzzy_file);
2079 fnamecmp = fnamecmpbuf;
2080 fnamecmp_type = FNAMECMP_FUZZY;
2081 @@ -1477,45 +1541,50 @@ static void recv_generator(char *fname,
2083 #ifdef SUPPORT_HARD_LINKS
2084 if (preserve_hard_links && F_HLINK_NOT_LAST(file))
2088 if (stat_errno == ENOENT)
2090 rsyserr(FERROR, stat_errno, "recv_generator: failed to stat %s",
2096 - if (append_mode > 0 && st.st_size > F_LENGTH(file))
2098 + if (append_mode > 0 && sx.st.st_size > F_LENGTH(file))
2101 if (fnamecmp_type <= FNAMECMP_BASIS_DIR_HIGH)
2103 else if (fnamecmp_type == FNAMECMP_FUZZY)
2105 - else if (unchanged_file(fnamecmp, file, &st)) {
2106 + else if (unchanged_file(fnamecmp, file, &sx.st)) {
2108 do_unlink(partialptr);
2109 handle_partial_dir(partialptr, PDIR_DELETE);
2112 - itemize(file, ndx, statret, &st, 0, 0, NULL);
2113 - set_file_attrs(fname, file, &st, maybe_ATTRS_REPORT);
2115 +#ifdef SUPPORT_ACLS
2116 + if (preserve_acls && statret == 0)
2117 + get_acl(fnamecmp, &sx);
2119 + itemize(file, ndx, statret, &sx, 0, 0, NULL);
2121 + set_file_attrs(fname, file, &sx, maybe_ATTRS_REPORT);
2122 #ifdef SUPPORT_HARD_LINKS
2123 if (preserve_hard_links && F_IS_HLINKED(file))
2124 - finish_hard_link(file, fname, &st, itemizing, code, -1);
2125 + finish_hard_link(file, fname, &sx.st, itemizing, code, -1);
2127 if (remove_source_files != 1)
2130 return_with_success:
2132 send_msg_int(MSG_SUCCESS, ndx);
2140 + sx.st = partial_st;
2141 fnamecmp = partialptr;
2142 fnamecmp_type = FNAMECMP_PARTIAL_DIR;
2144 @@ -1540,16 +1609,20 @@ static void recv_generator(char *fname,
2145 /* pretend the file didn't exist */
2146 #ifdef SUPPORT_HARD_LINKS
2147 if (preserve_hard_links && F_HLINK_NOT_LAST(file))
2151 statret = real_ret = -1;
2152 +#ifdef SUPPORT_ACLS
2153 + if (preserve_acls && ACL_READY(sx))
2159 if (inplace && make_backups > 0 && fnamecmp_type == FNAMECMP_FNAME) {
2160 if (!(backupptr = get_backup_name(fname))) {
2165 if (!(back_file = make_file(fname, NULL, NULL, 0, NO_FILTERS))) {
2167 @@ -1560,7 +1633,7 @@ static void recv_generator(char *fname,
2168 full_fname(backupptr));
2169 unmake_file(back_file);
2174 if ((f_copy = do_open(backupptr,
2175 O_WRONLY | O_CREAT | O_TRUNC | O_EXCL, 0600)) < 0) {
2176 @@ -1568,14 +1641,14 @@ static void recv_generator(char *fname,
2177 full_fname(backupptr));
2178 unmake_file(back_file);
2183 fnamecmp_type = FNAMECMP_BACKUP;
2187 rprintf(FINFO, "gen mapped %s of size %.0f\n",
2188 - fnamecmp, (double)st.st_size);
2189 + fnamecmp, (double)sx.st.st_size);
2193 @@ -1599,26 +1672,34 @@ static void recv_generator(char *fname,
2194 iflags |= ITEM_BASIS_TYPE_FOLLOWS;
2195 if (fnamecmp_type == FNAMECMP_FUZZY)
2196 iflags |= ITEM_XNAME_FOLLOWS;
2197 - itemize(file, -1, real_ret, &real_st, iflags, fnamecmp_type,
2198 +#ifdef SUPPORT_ACLS
2199 + if (preserve_acls && real_ret == 0)
2200 + get_acl(fnamecmp, &real_sx);
2202 + itemize(file, -1, real_ret, &real_sx, iflags, fnamecmp_type,
2203 fuzzy_file ? fuzzy_file->basename : NULL);
2204 +#ifdef SUPPORT_ACLS
2205 + if (preserve_acls)
2206 + free_acl(&real_sx);
2211 #ifdef SUPPORT_HARD_LINKS
2212 if (preserve_hard_links && F_IS_HLINKED(file))
2213 - finish_hard_link(file, fname, &st, itemizing, code, -1);
2214 + finish_hard_link(file, fname, &sx.st, itemizing, code, -1);
2223 if (statret != 0 || whole_file) {
2224 write_sum_head(f_out, NULL);
2229 - generate_and_send_sums(fd, st.st_size, f_out, f_copy);
2230 + generate_and_send_sums(fd, sx.st.st_size, f_out, f_copy);
2234 @@ -1631,6 +1712,13 @@ static void recv_generator(char *fname,
2240 +#ifdef SUPPORT_ACLS
2241 + if (preserve_acls)
2247 static void touch_up_dirs(struct file_list *flist, int ndx)
2248 @@ -1799,6 +1887,8 @@ void generate_files(int f_out, const cha
2249 * notice that and let us know via the redo pipe (or its closing). */
2252 + dflt_perms = (ACCESSPERMS & ~orig_umask);
2255 if (inc_recurse && delete_during && cur_flist->ndx_start) {
2256 struct file_struct *fp = dir_flist->files[cur_flist->parent_ndx];
2259 @@ -27,6 +27,7 @@ extern int verbose;
2261 extern int do_xfers;
2262 extern int link_dest;
2263 +extern int preserve_acls;
2264 extern int make_backups;
2265 extern int protocol_version;
2266 extern int remove_source_files;
2267 @@ -268,15 +269,19 @@ void match_hard_links(void)
2270 static int maybe_hard_link(struct file_struct *file, int ndx,
2271 - const char *fname, int statret, STRUCT_STAT *stp,
2272 + const char *fname, int statret, statx *sxp,
2273 const char *oldname, STRUCT_STAT *old_stp,
2274 const char *realname, int itemizing, enum logcode code)
2277 - if (stp->st_dev == old_stp->st_dev
2278 - && stp->st_ino == old_stp->st_ino) {
2279 + if (sxp->st.st_dev == old_stp->st_dev
2280 + && sxp->st.st_ino == old_stp->st_ino) {
2282 - itemize(file, ndx, statret, stp,
2283 +#ifdef SUPPORT_ACLS
2284 + if (preserve_acls && !ACL_READY(*sxp))
2285 + get_acl(fname, sxp);
2287 + itemize(file, ndx, statret, sxp,
2288 ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS,
2291 @@ -297,7 +302,11 @@ static int maybe_hard_link(struct file_s
2293 if (hard_link_one(file, fname, oldname, 0)) {
2295 - itemize(file, ndx, statret, stp,
2296 +#ifdef SUPPORT_ACLS
2297 + if (preserve_acls && statret == 0 && !ACL_READY(*sxp))
2298 + get_acl(fname, sxp);
2300 + itemize(file, ndx, statret, sxp,
2301 ITEM_LOCAL_CHANGE | ITEM_XNAME_FOLLOWS, 0,
2304 @@ -311,7 +320,7 @@ static int maybe_hard_link(struct file_s
2305 /* Only called if FLAG_HLINKED is set and FLAG_HLINK_FIRST is not. Returns:
2306 * 0 = process the file, 1 = skip the file, -1 = error occurred. */
2307 int hard_link_check(struct file_struct *file, int ndx, const char *fname,
2308 - int statret, STRUCT_STAT *stp, int itemizing,
2309 + int statret, statx *sxp, int itemizing,
2312 STRUCT_STAT prev_st;
2313 @@ -362,18 +371,20 @@ int hard_link_check(struct file_struct *
2314 if (statret < 0 && basis_dir[0] != NULL) {
2315 /* If we match an alt-dest item, we don't output this as a change. */
2316 char cmpbuf[MAXPATHLEN];
2317 - STRUCT_STAT alt_st;
2320 +#ifdef SUPPORT_ACLS
2321 + alt_sx.acc_acl = alt_sx.def_acl = NULL;
2324 pathjoin(cmpbuf, MAXPATHLEN, basis_dir[j], fname);
2325 - if (link_stat(cmpbuf, &alt_st, 0) < 0)
2326 + if (link_stat(cmpbuf, &alt_sx.st, 0) < 0)
2329 - if (prev_st.st_dev != alt_st.st_dev
2330 - || prev_st.st_ino != alt_st.st_ino)
2331 + if (prev_st.st_dev != alt_sx.st.st_dev
2332 + || prev_st.st_ino != alt_sx.st.st_ino)
2336 if (verbose < 2 || !stdout_format_has_i) {
2339 @@ -382,16 +393,36 @@ int hard_link_check(struct file_struct *
2343 - if (!unchanged_file(cmpbuf, file, &alt_st))
2344 + if (!unchanged_file(cmpbuf, file, &alt_sx.st))
2348 - if (unchanged_attrs(file, &alt_st))
2349 +#ifdef SUPPORT_ACLS
2350 + if (preserve_acls)
2351 + get_acl(cmpbuf, &alt_sx);
2353 + if (unchanged_attrs(file, &alt_sx))
2355 } while (basis_dir[++j] != NULL);
2356 + if (statret == 1) {
2357 + sxp->st = alt_sx.st;
2358 +#ifdef SUPPORT_ACLS
2359 + if (preserve_acls) {
2360 + if (!ACL_READY(*sxp))
2361 + get_acl(cmpbuf, sxp);
2363 + sxp->acc_acl = alt_sx.acc_acl;
2364 + sxp->def_acl = alt_sx.def_acl;
2369 +#ifdef SUPPORT_ACLS
2370 + else if (preserve_acls)
2371 + free_acl(&alt_sx);
2375 - if (maybe_hard_link(file, ndx, fname, statret, stp, prev_name, &prev_st,
2376 + if (maybe_hard_link(file, ndx, fname, statret, sxp, prev_name, &prev_st,
2377 realname, itemizing, code) < 0)
2380 @@ -426,7 +457,8 @@ void finish_hard_link(struct file_struct
2381 STRUCT_STAT *stp, int itemizing, enum logcode code,
2384 - STRUCT_STAT st, prev_st;
2387 char alt_name[MAXPATHLEN], *prev_name;
2388 const char *our_name;
2389 int prev_statret, ndx, prev_ndx = F_HL_PREV(file);
2390 @@ -450,14 +482,24 @@ void finish_hard_link(struct file_struct
2394 +#ifdef SUPPORT_ACLS
2395 + prev_sx.acc_acl = prev_sx.def_acl = NULL;
2398 while ((ndx = prev_ndx) >= 0) {
2401 file->flags = (file->flags & ~FLAG_HLINK_FIRST) | FLAG_HLINK_DONE;
2402 prev_ndx = F_HL_PREV(file);
2403 prev_name = f_name(file, NULL);
2404 - prev_statret = link_stat(prev_name, &prev_st, 0);
2405 - if (maybe_hard_link(file, ndx, prev_name, prev_statret, &prev_st,
2406 - our_name, stp, fname, itemizing, code) < 0)
2407 + prev_statret = link_stat(prev_name, &prev_sx.st, 0);
2408 + val = maybe_hard_link(file, ndx, prev_name, prev_statret, &prev_sx,
2409 + our_name, stp, fname, itemizing, code);
2410 +#ifdef SUPPORT_ACLS
2411 + if (preserve_acls)
2412 + free_acl(&prev_sx);
2416 if (remove_source_files == 1 && do_xfers)
2417 send_msg_int(MSG_SUCCESS, ndx);
2418 --- old/lib/sysacls.c
2419 +++ new/lib/sysacls.c
2422 + Unix SMB/CIFS implementation.
2423 + Samba system utilities for ACL support.
2424 + Copyright (C) Jeremy Allison 2000.
2426 + This program is free software; you can redistribute it and/or modify
2427 + it under the terms of the GNU General Public License as published by
2428 + the Free Software Foundation; either version 2 of the License, or
2429 + (at your option) any later version.
2431 + This program is distributed in the hope that it will be useful,
2432 + but WITHOUT ANY WARRANTY; without even the implied warranty of
2433 + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2434 + GNU General Public License for more details.
2436 + You should have received a copy of the GNU General Public License
2437 + along with this program; if not, write to the Free Software
2438 + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
2442 +#include "sysacls.h" /****** ADDED ******/
2444 +#ifdef SUPPORT_ACLS
2446 +/****** EXTRAS -- THESE ITEMS ARE NOT FROM THE SAMBA SOURCE ******/
2452 +void SAFE_FREE(void *mem)
2458 +char *uidtoname(uid_t uid)
2460 + static char idbuf[12];
2461 + struct passwd *pw;
2463 + if ((pw = getpwuid(uid)) == NULL) {
2464 + slprintf(idbuf, sizeof(idbuf)-1, "%ld", (long)uid);
2467 + return pw->pw_name;
2469 +/****** EXTRAS -- END ******/
2472 + This file wraps all differing system ACL interfaces into a consistent
2473 + one based on the POSIX interface. It also returns the correct errors
2474 + for older UNIX systems that don't support ACLs.
2476 + The interfaces that each ACL implementation must support are as follows :
2478 + int sys_acl_get_entry( SMB_ACL_T theacl, int entry_id, SMB_ACL_ENTRY_T *entry_p)
2479 + int sys_acl_get_tag_type( SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p)
2480 + int sys_acl_get_permset( SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p
2481 + void *sys_acl_get_qualifier( SMB_ACL_ENTRY_T entry_d)
2482 + SMB_ACL_T sys_acl_get_file( const char *path_p, SMB_ACL_TYPE_T type)
2483 + SMB_ACL_T sys_acl_get_fd(int fd)
2484 + int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset);
2485 + int sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm);
2486 + char *sys_acl_to_text( SMB_ACL_T theacl, ssize_t *plen)
2487 + SMB_ACL_T sys_acl_init( int count)
2488 + int sys_acl_create_entry( SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry)
2489 + int sys_acl_set_tag_type( SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype)
2490 + int sys_acl_set_qualifier( SMB_ACL_ENTRY_T entry, void *qual)
2491 + int sys_acl_set_permset( SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset)
2492 + int sys_acl_valid( SMB_ACL_T theacl )
2493 + int sys_acl_set_file( const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl)
2494 + int sys_acl_set_fd( int fd, SMB_ACL_T theacl)
2495 + int sys_acl_delete_def_file(const char *path)
2497 + This next one is not POSIX complient - but we *have* to have it !
2498 + More POSIX braindamage.
2500 + int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
2502 + The generic POSIX free is the following call. We split this into
2503 + several different free functions as we may need to add tag info
2504 + to structures when emulating the POSIX interface.
2506 + int sys_acl_free( void *obj_p)
2508 + The calls we actually use are :
2510 + int sys_acl_free_text(char *text) - free acl_to_text
2511 + int sys_acl_free_acl(SMB_ACL_T posix_acl)
2512 + int sys_acl_free_qualifier(void *qualifier, SMB_ACL_TAG_T tagtype)
2516 +#if defined(HAVE_POSIX_ACLS)
2518 +/* Identity mapping - easy. */
2520 +int sys_acl_get_entry( SMB_ACL_T the_acl, int entry_id, SMB_ACL_ENTRY_T *entry_p)
2522 + return acl_get_entry( the_acl, entry_id, entry_p);
2525 +int sys_acl_get_tag_type( SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p)
2527 + return acl_get_tag_type( entry_d, tag_type_p);
2530 +int sys_acl_get_permset( SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
2532 + return acl_get_permset( entry_d, permset_p);
2535 +void *sys_acl_get_qualifier( SMB_ACL_ENTRY_T entry_d)
2537 + return acl_get_qualifier( entry_d);
2540 +SMB_ACL_T sys_acl_get_file( const char *path_p, SMB_ACL_TYPE_T type)
2542 + return acl_get_file( path_p, type);
2545 +SMB_ACL_T sys_acl_get_fd(int fd)
2547 + return acl_get_fd(fd);
2550 +int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset)
2552 + return acl_clear_perms(permset);
2555 +int sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
2557 + return acl_add_perm(permset, perm);
2560 +int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
2562 +#if defined(HAVE_ACL_GET_PERM_NP)
2564 + * Required for TrustedBSD-based ACL implementations where
2565 + * non-POSIX.1e functions are denoted by a _np (non-portable)
2568 + return acl_get_perm_np(permset, perm);
2570 + return acl_get_perm(permset, perm);
2574 +char *sys_acl_to_text( SMB_ACL_T the_acl, ssize_t *plen)
2576 + return acl_to_text( the_acl, plen);
2579 +SMB_ACL_T sys_acl_init( int count)
2581 + return acl_init(count);
2584 +int sys_acl_create_entry( SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry)
2586 + return acl_create_entry(pacl, pentry);
2589 +int sys_acl_set_tag_type( SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype)
2591 + return acl_set_tag_type(entry, tagtype);
2594 +int sys_acl_set_qualifier( SMB_ACL_ENTRY_T entry, void *qual)
2596 + return acl_set_qualifier(entry, qual);
2599 +int sys_acl_set_permset( SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset)
2601 + return acl_set_permset(entry, permset);
2604 +int sys_acl_valid( SMB_ACL_T theacl )
2606 + return acl_valid(theacl);
2609 +int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl)
2611 + return acl_set_file(name, acltype, theacl);
2614 +int sys_acl_set_fd( int fd, SMB_ACL_T theacl)
2616 + return acl_set_fd(fd, theacl);
2619 +int sys_acl_delete_def_file(const char *name)
2621 + return acl_delete_def_file(name);
2624 +int sys_acl_free_text(char *text)
2626 + return acl_free(text);
2629 +int sys_acl_free_acl(SMB_ACL_T the_acl)
2631 + return acl_free(the_acl);
2634 +int sys_acl_free_qualifier(void *qual, UNUSED(SMB_ACL_TAG_T tagtype))
2636 + return acl_free(qual);
2639 +#elif defined(HAVE_TRU64_ACLS)
2641 + * The interface to DEC/Compaq Tru64 UNIX ACLs
2642 + * is based on Draft 13 of the POSIX spec which is
2643 + * slightly different from the Draft 16 interface.
2645 + * Also, some of the permset manipulation functions
2646 + * such as acl_clear_perm() and acl_add_perm() appear
2647 + * to be broken on Tru64 so we have to manipulate
2648 + * the permission bits in the permset directly.
2650 +int sys_acl_get_entry( SMB_ACL_T the_acl, int entry_id, SMB_ACL_ENTRY_T *entry_p)
2652 + SMB_ACL_ENTRY_T entry;
2654 + if (entry_id == SMB_ACL_FIRST_ENTRY && acl_first_entry(the_acl) != 0) {
2659 + if ((entry = acl_get_entry(the_acl)) != NULL) {
2664 + return errno ? -1 : 0;
2667 +int sys_acl_get_tag_type( SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p)
2669 + return acl_get_tag_type( entry_d, tag_type_p);
2672 +int sys_acl_get_permset( SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
2674 + return acl_get_permset( entry_d, permset_p);
2677 +void *sys_acl_get_qualifier( SMB_ACL_ENTRY_T entry_d)
2679 + return acl_get_qualifier( entry_d);
2682 +SMB_ACL_T sys_acl_get_file( const char *path_p, SMB_ACL_TYPE_T type)
2684 + return acl_get_file((char *)path_p, type);
2687 +SMB_ACL_T sys_acl_get_fd(int fd)
2689 + return acl_get_fd(fd, ACL_TYPE_ACCESS);
2692 +int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset)
2694 + *permset = 0; /* acl_clear_perm() is broken on Tru64 */
2699 +int sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
2701 + if (perm & ~(SMB_ACL_READ | SMB_ACL_WRITE | SMB_ACL_EXECUTE)) {
2706 + *permset |= perm; /* acl_add_perm() is broken on Tru64 */
2711 +int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
2713 + return *permset & perm; /* Tru64 doesn't have acl_get_perm() */
2716 +char *sys_acl_to_text( SMB_ACL_T the_acl, ssize_t *plen)
2718 + return acl_to_text( the_acl, plen);
2721 +SMB_ACL_T sys_acl_init( int count)
2723 + return acl_init(count);
2726 +int sys_acl_create_entry( SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry)
2728 + SMB_ACL_ENTRY_T entry;
2730 + if ((entry = acl_create_entry(pacl)) == NULL) {
2738 +int sys_acl_set_tag_type( SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype)
2740 + return acl_set_tag_type(entry, tagtype);
2743 +int sys_acl_set_qualifier( SMB_ACL_ENTRY_T entry, void *qual)
2745 + return acl_set_qualifier(entry, qual);
2748 +int sys_acl_set_permset( SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset)
2750 + return acl_set_permset(entry, permset);
2753 +int sys_acl_valid( SMB_ACL_T theacl )
2755 + acl_entry_t entry;
2757 + return acl_valid(theacl, &entry);
2760 +int sys_acl_set_file( const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl)
2762 + return acl_set_file((char *)name, acltype, theacl);
2765 +int sys_acl_set_fd( int fd, SMB_ACL_T theacl)
2767 + return acl_set_fd(fd, ACL_TYPE_ACCESS, theacl);
2770 +int sys_acl_delete_def_file(const char *name)
2772 + return acl_delete_def_file((char *)name);
2775 +int sys_acl_free_text(char *text)
2778 + * (void) cast and explicit return 0 are for DEC UNIX
2779 + * which just #defines acl_free_text() to be free()
2781 + (void) acl_free_text(text);
2785 +int sys_acl_free_acl(SMB_ACL_T the_acl)
2787 + return acl_free(the_acl);
2790 +int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype)
2792 + return acl_free_qualifier(qual, tagtype);
2795 +#elif defined(HAVE_UNIXWARE_ACLS) || defined(HAVE_SOLARIS_ACLS)
2798 + * Donated by Michael Davidson <md@sco.COM> for UnixWare / OpenUNIX.
2799 + * Modified by Toomas Soome <tsoome@ut.ee> for Solaris.
2803 + * Note that while this code implements sufficient functionality
2804 + * to support the sys_acl_* interfaces it does not provide all
2805 + * of the semantics of the POSIX ACL interfaces.
2807 + * In particular, an ACL entry descriptor (SMB_ACL_ENTRY_T) returned
2808 + * from a call to sys_acl_get_entry() should not be assumed to be
2809 + * valid after calling any of the following functions, which may
2810 + * reorder the entries in the ACL.
2813 + * sys_acl_set_file()
2814 + * sys_acl_set_fd()
2818 + * The only difference between Solaris and UnixWare / OpenUNIX is
2819 + * that the #defines for the ACL operations have different names
2821 +#if defined(HAVE_UNIXWARE_ACLS)
2823 +#define SETACL ACL_SET
2824 +#define GETACL ACL_GET
2825 +#define GETACLCNT ACL_CNT
2830 +int sys_acl_get_entry(SMB_ACL_T acl_d, int entry_id, SMB_ACL_ENTRY_T *entry_p)
2832 + if (entry_id != SMB_ACL_FIRST_ENTRY && entry_id != SMB_ACL_NEXT_ENTRY) {
2837 + if (entry_p == NULL) {
2842 + if (entry_id == SMB_ACL_FIRST_ENTRY) {
2846 + if (acl_d->next < 0) {
2851 + if (acl_d->next >= acl_d->count) {
2855 + *entry_p = &acl_d->acl[acl_d->next++];
2860 +int sys_acl_get_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *type_p)
2862 + *type_p = entry_d->a_type;
2867 +int sys_acl_get_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
2869 + *permset_p = &entry_d->a_perm;
2874 +void *sys_acl_get_qualifier(SMB_ACL_ENTRY_T entry_d)
2876 + if (entry_d->a_type != SMB_ACL_USER
2877 + && entry_d->a_type != SMB_ACL_GROUP) {
2882 + return &entry_d->a_id;
2886 + * There is no way of knowing what size the ACL returned by
2887 + * GETACL will be unless you first call GETACLCNT which means
2888 + * making an additional system call.
2890 + * In the hope of avoiding the cost of the additional system
2891 + * call in most cases, we initially allocate enough space for
2892 + * an ACL with INITIAL_ACL_SIZE entries. If this turns out to
2893 + * be too small then we use GETACLCNT to find out the actual
2894 + * size, reallocate the ACL buffer, and then call GETACL again.
2897 +#define INITIAL_ACL_SIZE 16
2899 +SMB_ACL_T sys_acl_get_file(const char *path_p, SMB_ACL_TYPE_T type)
2902 + int count; /* # of ACL entries allocated */
2903 + int naccess; /* # of access ACL entries */
2904 + int ndefault; /* # of default ACL entries */
2906 + if (type != SMB_ACL_TYPE_ACCESS && type != SMB_ACL_TYPE_DEFAULT) {
2911 + count = INITIAL_ACL_SIZE;
2912 + if ((acl_d = sys_acl_init(count)) == NULL) {
2917 + * If there isn't enough space for the ACL entries we use
2918 + * GETACLCNT to determine the actual number of ACL entries
2919 + * reallocate and try again. This is in a loop because it
2920 + * is possible that someone else could modify the ACL and
2921 + * increase the number of entries between the call to
2922 + * GETACLCNT and the call to GETACL.
2924 + while ((count = acl(path_p, GETACL, count, &acl_d->acl[0])) < 0
2925 + && errno == ENOSPC) {
2927 + sys_acl_free_acl(acl_d);
2929 + if ((count = acl(path_p, GETACLCNT, 0, NULL)) < 0) {
2933 + if ((acl_d = sys_acl_init(count)) == NULL) {
2939 + sys_acl_free_acl(acl_d);
2944 + * calculate the number of access and default ACL entries
2946 + * Note: we assume that the acl() system call returned a
2947 + * well formed ACL which is sorted so that all of the
2948 + * access ACL entries preceed any default ACL entries
2950 + for (naccess = 0; naccess < count; naccess++) {
2951 + if (acl_d->acl[naccess].a_type & ACL_DEFAULT)
2954 + ndefault = count - naccess;
2957 + * if the caller wants the default ACL we have to copy
2958 + * the entries down to the start of the acl[] buffer
2959 + * and mask out the ACL_DEFAULT flag from the type field
2961 + if (type == SMB_ACL_TYPE_DEFAULT) {
2964 + for (i = 0, j = naccess; i < ndefault; i++, j++) {
2965 + acl_d->acl[i] = acl_d->acl[j];
2966 + acl_d->acl[i].a_type &= ~ACL_DEFAULT;
2969 + acl_d->count = ndefault;
2971 + acl_d->count = naccess;
2977 +SMB_ACL_T sys_acl_get_fd(int fd)
2980 + int count; /* # of ACL entries allocated */
2981 + int naccess; /* # of access ACL entries */
2983 + count = INITIAL_ACL_SIZE;
2984 + if ((acl_d = sys_acl_init(count)) == NULL) {
2988 + while ((count = facl(fd, GETACL, count, &acl_d->acl[0])) < 0
2989 + && errno == ENOSPC) {
2991 + sys_acl_free_acl(acl_d);
2993 + if ((count = facl(fd, GETACLCNT, 0, NULL)) < 0) {
2997 + if ((acl_d = sys_acl_init(count)) == NULL) {
3003 + sys_acl_free_acl(acl_d);
3008 + * calculate the number of access ACL entries
3010 + for (naccess = 0; naccess < count; naccess++) {
3011 + if (acl_d->acl[naccess].a_type & ACL_DEFAULT)
3015 + acl_d->count = naccess;
3020 +int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset_d)
3027 +int sys_acl_add_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
3029 + if (perm != SMB_ACL_READ && perm != SMB_ACL_WRITE
3030 + && perm != SMB_ACL_EXECUTE) {
3035 + if (permset_d == NULL) {
3040 + *permset_d |= perm;
3045 +int sys_acl_get_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
3047 + return *permset_d & perm;
3050 +char *sys_acl_to_text(SMB_ACL_T acl_d, ssize_t *len_p)
3057 + * use an initial estimate of 20 bytes per ACL entry
3058 + * when allocating memory for the text representation
3062 + maxlen = 20 * acl_d->count;
3063 + if ((text = SMB_MALLOC(maxlen)) == NULL) {
3068 + for (i = 0; i < acl_d->count; i++) {
3069 + struct acl *ap = &acl_d->acl[i];
3078 + switch (ap->a_type) {
3080 + * for debugging purposes it's probably more
3081 + * useful to dump unknown tag types rather
3082 + * than just returning an error
3085 + slprintf(tagbuf, sizeof(tagbuf)-1, "0x%x",
3088 + slprintf(idbuf, sizeof(idbuf)-1, "%ld",
3093 + case SMB_ACL_USER:
3094 + id = uidtoname(ap->a_id);
3095 + case SMB_ACL_USER_OBJ:
3099 + case SMB_ACL_GROUP:
3100 + if ((gr = getgrgid(ap->a_id)) == NULL) {
3101 + slprintf(idbuf, sizeof(idbuf)-1, "%ld",
3107 + case SMB_ACL_GROUP_OBJ:
3111 + case SMB_ACL_OTHER:
3115 + case SMB_ACL_MASK:
3121 + perms[0] = (ap->a_perm & SMB_ACL_READ) ? 'r' : '-';
3122 + perms[1] = (ap->a_perm & SMB_ACL_WRITE) ? 'w' : '-';
3123 + perms[2] = (ap->a_perm & SMB_ACL_EXECUTE) ? 'x' : '-';
3126 + /* <tag> : <qualifier> : rwx \n \0 */
3127 + nbytes = strlen(tag) + 1 + strlen(id) + 1 + 3 + 1 + 1;
3130 + * If this entry would overflow the buffer
3131 + * allocate enough additional memory for this
3132 + * entry and an estimate of another 20 bytes
3133 + * for each entry still to be processed
3135 + if ((len + nbytes) > maxlen) {
3136 + char *oldtext = text;
3138 + maxlen += nbytes + 20 * (acl_d->count - i);
3140 + if ((text = SMB_REALLOC(oldtext, maxlen)) == NULL) {
3141 + SAFE_FREE(oldtext);
3147 + slprintf(&text[len], nbytes-1, "%s:%s:%s\n", tag, id, perms);
3148 + len += nbytes - 1;
3157 +SMB_ACL_T sys_acl_init(int count)
3167 + * note that since the definition of the structure pointed
3168 + * to by the SMB_ACL_T includes the first element of the
3169 + * acl[] array, this actually allocates an ACL with room
3170 + * for (count+1) entries
3172 + if ((a = (SMB_ACL_T)SMB_MALLOC(sizeof(struct SMB_ACL_T) + count * sizeof(struct acl))) == NULL) {
3177 + a->size = count + 1;
3185 +int sys_acl_create_entry(SMB_ACL_T *acl_p, SMB_ACL_ENTRY_T *entry_p)
3188 + SMB_ACL_ENTRY_T entry_d;
3190 + if (acl_p == NULL || entry_p == NULL || (acl_d = *acl_p) == NULL) {
3195 + if (acl_d->count >= acl_d->size) {
3200 + entry_d = &acl_d->acl[acl_d->count++];
3201 + entry_d->a_type = 0;
3202 + entry_d->a_id = -1;
3203 + entry_d->a_perm = 0;
3204 + *entry_p = entry_d;
3209 +int sys_acl_set_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T tag_type)
3211 + switch (tag_type) {
3212 + case SMB_ACL_USER:
3213 + case SMB_ACL_USER_OBJ:
3214 + case SMB_ACL_GROUP:
3215 + case SMB_ACL_GROUP_OBJ:
3216 + case SMB_ACL_OTHER:
3217 + case SMB_ACL_MASK:
3218 + entry_d->a_type = tag_type;
3228 +int sys_acl_set_qualifier(SMB_ACL_ENTRY_T entry_d, void *qual_p)
3230 + if (entry_d->a_type != SMB_ACL_GROUP
3231 + && entry_d->a_type != SMB_ACL_USER) {
3236 + entry_d->a_id = *((id_t *)qual_p);
3241 +int sys_acl_set_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T permset_d)
3243 + if (*permset_d & ~(SMB_ACL_READ|SMB_ACL_WRITE|SMB_ACL_EXECUTE)) {
3247 + entry_d->a_perm = *permset_d;
3253 + * sort the ACL and check it for validity
3255 + * if it's a minimal ACL with only 4 entries then we
3256 + * need to recalculate the mask permissions to make
3257 + * sure that they are the same as the GROUP_OBJ
3258 + * permissions as required by the UnixWare acl() system call.
3260 + * (note: since POSIX allows minimal ACLs which only contain
3261 + * 3 entries - ie there is no mask entry - we should, in theory,
3262 + * check for this and add a mask entry if necessary - however
3263 + * we "know" that the caller of this interface always specifies
3264 + * a mask so, in practice "this never happens" (tm) - if it *does*
3265 + * happen aclsort() will fail and return an error and someone will
3266 + * have to fix it ...)
3269 +static int acl_sort(SMB_ACL_T acl_d)
3271 + int fixmask = (acl_d->count <= 4);
3273 + if (aclsort(acl_d->count, fixmask, acl_d->acl) != 0) {
3280 +int sys_acl_valid(SMB_ACL_T acl_d)
3282 + return acl_sort(acl_d);
3285 +int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T type, SMB_ACL_T acl_d)
3288 + struct acl *acl_p;
3290 + struct acl *acl_buf = NULL;
3293 + if (type != SMB_ACL_TYPE_ACCESS && type != SMB_ACL_TYPE_DEFAULT) {
3298 + if (acl_sort(acl_d) != 0) {
3302 + acl_p = &acl_d->acl[0];
3303 + acl_count = acl_d->count;
3306 + * if it's a directory there is extra work to do
3307 + * since the acl() system call will replace both
3308 + * the access ACLs and the default ACLs (if any)
3310 + if (stat(name, &s) != 0) {
3313 + if (S_ISDIR(s.st_mode)) {
3314 + SMB_ACL_T acc_acl;
3315 + SMB_ACL_T def_acl;
3316 + SMB_ACL_T tmp_acl;
3319 + if (type == SMB_ACL_TYPE_ACCESS) {
3321 + def_acl = tmp_acl = sys_acl_get_file(name, SMB_ACL_TYPE_DEFAULT);
3325 + acc_acl = tmp_acl = sys_acl_get_file(name, SMB_ACL_TYPE_ACCESS);
3328 + if (tmp_acl == NULL) {
3333 + * allocate a temporary buffer for the complete ACL
3335 + acl_count = acc_acl->count + def_acl->count;
3336 + acl_p = acl_buf = SMB_MALLOC_ARRAY(struct acl, acl_count);
3338 + if (acl_buf == NULL) {
3339 + sys_acl_free_acl(tmp_acl);
3345 + * copy the access control and default entries into the buffer
3347 + memcpy(&acl_buf[0], &acc_acl->acl[0],
3348 + acc_acl->count * sizeof(acl_buf[0]));
3350 + memcpy(&acl_buf[acc_acl->count], &def_acl->acl[0],
3351 + def_acl->count * sizeof(acl_buf[0]));
3354 + * set the ACL_DEFAULT flag on the default entries
3356 + for (i = acc_acl->count; i < acl_count; i++) {
3357 + acl_buf[i].a_type |= ACL_DEFAULT;
3360 + sys_acl_free_acl(tmp_acl);
3362 + } else if (type != SMB_ACL_TYPE_ACCESS) {
3367 + ret = acl(name, SETACL, acl_count, acl_p);
3369 + SAFE_FREE(acl_buf);
3374 +int sys_acl_set_fd(int fd, SMB_ACL_T acl_d)
3376 + if (acl_sort(acl_d) != 0) {
3380 + return facl(fd, SETACL, acl_d->count, &acl_d->acl[0]);
3383 +int sys_acl_delete_def_file(const char *path)
3389 + * fetching the access ACL and rewriting it has
3390 + * the effect of deleting the default ACL
3392 + if ((acl_d = sys_acl_get_file(path, SMB_ACL_TYPE_ACCESS)) == NULL) {
3396 + ret = acl(path, SETACL, acl_d->count, acl_d->acl);
3398 + sys_acl_free_acl(acl_d);
3403 +int sys_acl_free_text(char *text)
3409 +int sys_acl_free_acl(SMB_ACL_T acl_d)
3415 +int sys_acl_free_qualifier(UNUSED(void *qual), UNUSED(SMB_ACL_TAG_T tagtype))
3420 +#elif defined(HAVE_HPUX_ACLS)
3424 + * Based on the Solaris/SCO code - with modifications.
3428 + * Note that while this code implements sufficient functionality
3429 + * to support the sys_acl_* interfaces it does not provide all
3430 + * of the semantics of the POSIX ACL interfaces.
3432 + * In particular, an ACL entry descriptor (SMB_ACL_ENTRY_T) returned
3433 + * from a call to sys_acl_get_entry() should not be assumed to be
3434 + * valid after calling any of the following functions, which may
3435 + * reorder the entries in the ACL.
3438 + * sys_acl_set_file()
3439 + * sys_acl_set_fd()
3442 +/* This checks if the POSIX ACL system call is defined */
3443 +/* which basically corresponds to whether JFS 3.3 or */
3444 +/* higher is installed. If acl() was called when it */
3445 +/* isn't defined, it causes the process to core dump */
3446 +/* so it is important to check this and avoid acl() */
3447 +/* calls if it isn't there. */
3449 +static BOOL hpux_acl_call_presence(void)
3452 + shl_t handle = NULL;
3455 + static BOOL already_checked=0;
3457 + if(already_checked)
3461 + ret_val = shl_findsym(&handle, "acl", TYPE_PROCEDURE, &value);
3463 + if(ret_val != 0) {
3464 + DEBUG(5, ("hpux_acl_call_presence: shl_findsym() returned %d, errno = %d, error %s\n",
3465 + ret_val, errno, strerror(errno)));
3466 + DEBUG(5,("hpux_acl_call_presence: acl() system call is not present. Check if you have JFS 3.3 and above?\n"));
3470 + DEBUG(10,("hpux_acl_call_presence: acl() system call is present. We have JFS 3.3 or above \n"));
3472 + already_checked = True;
3476 +int sys_acl_get_entry(SMB_ACL_T acl_d, int entry_id, SMB_ACL_ENTRY_T *entry_p)
3478 + if (entry_id != SMB_ACL_FIRST_ENTRY && entry_id != SMB_ACL_NEXT_ENTRY) {
3483 + if (entry_p == NULL) {
3488 + if (entry_id == SMB_ACL_FIRST_ENTRY) {
3492 + if (acl_d->next < 0) {
3497 + if (acl_d->next >= acl_d->count) {
3501 + *entry_p = &acl_d->acl[acl_d->next++];
3506 +int sys_acl_get_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *type_p)
3508 + *type_p = entry_d->a_type;
3513 +int sys_acl_get_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
3515 + *permset_p = &entry_d->a_perm;
3520 +void *sys_acl_get_qualifier(SMB_ACL_ENTRY_T entry_d)
3522 + if (entry_d->a_type != SMB_ACL_USER
3523 + && entry_d->a_type != SMB_ACL_GROUP) {
3528 + return &entry_d->a_id;
3532 + * There is no way of knowing what size the ACL returned by
3533 + * ACL_GET will be unless you first call ACL_CNT which means
3534 + * making an additional system call.
3536 + * In the hope of avoiding the cost of the additional system
3537 + * call in most cases, we initially allocate enough space for
3538 + * an ACL with INITIAL_ACL_SIZE entries. If this turns out to
3539 + * be too small then we use ACL_CNT to find out the actual
3540 + * size, reallocate the ACL buffer, and then call ACL_GET again.
3543 +#define INITIAL_ACL_SIZE 16
3545 +SMB_ACL_T sys_acl_get_file(const char *path_p, SMB_ACL_TYPE_T type)
3548 + int count; /* # of ACL entries allocated */
3549 + int naccess; /* # of access ACL entries */
3550 + int ndefault; /* # of default ACL entries */
3552 + if(hpux_acl_call_presence() == False) {
3553 + /* Looks like we don't have the acl() system call on HPUX.
3554 + * May be the system doesn't have the latest version of JFS.
3559 + if (type != SMB_ACL_TYPE_ACCESS && type != SMB_ACL_TYPE_DEFAULT) {
3564 + count = INITIAL_ACL_SIZE;
3565 + if ((acl_d = sys_acl_init(count)) == NULL) {
3570 + * If there isn't enough space for the ACL entries we use
3571 + * ACL_CNT to determine the actual number of ACL entries
3572 + * reallocate and try again. This is in a loop because it
3573 + * is possible that someone else could modify the ACL and
3574 + * increase the number of entries between the call to
3575 + * ACL_CNT and the call to ACL_GET.
3577 + while ((count = acl(path_p, ACL_GET, count, &acl_d->acl[0])) < 0 && errno == ENOSPC) {
3579 + sys_acl_free_acl(acl_d);
3581 + if ((count = acl(path_p, ACL_CNT, 0, NULL)) < 0) {
3585 + if ((acl_d = sys_acl_init(count)) == NULL) {
3591 + sys_acl_free_acl(acl_d);
3596 + * calculate the number of access and default ACL entries
3598 + * Note: we assume that the acl() system call returned a
3599 + * well formed ACL which is sorted so that all of the
3600 + * access ACL entries preceed any default ACL entries
3602 + for (naccess = 0; naccess < count; naccess++) {
3603 + if (acl_d->acl[naccess].a_type & ACL_DEFAULT)
3606 + ndefault = count - naccess;
3609 + * if the caller wants the default ACL we have to copy
3610 + * the entries down to the start of the acl[] buffer
3611 + * and mask out the ACL_DEFAULT flag from the type field
3613 + if (type == SMB_ACL_TYPE_DEFAULT) {
3616 + for (i = 0, j = naccess; i < ndefault; i++, j++) {
3617 + acl_d->acl[i] = acl_d->acl[j];
3618 + acl_d->acl[i].a_type &= ~ACL_DEFAULT;
3621 + acl_d->count = ndefault;
3623 + acl_d->count = naccess;
3629 +SMB_ACL_T sys_acl_get_fd(int fd)
3632 + * HPUX doesn't have the facl call. Fake it using the path.... JRA.
3635 + files_struct *fsp = file_find_fd(fd);
3637 + if (fsp == NULL) {
3643 + * We know we're in the same conn context. So we
3644 + * can use the relative path.
3647 + return sys_acl_get_file(fsp->fsp_name, SMB_ACL_TYPE_ACCESS);
3650 +int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset_d)
3657 +int sys_acl_add_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
3659 + if (perm != SMB_ACL_READ && perm != SMB_ACL_WRITE
3660 + && perm != SMB_ACL_EXECUTE) {
3665 + if (permset_d == NULL) {
3670 + *permset_d |= perm;
3675 +int sys_acl_get_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
3677 + return *permset_d & perm;
3680 +char *sys_acl_to_text(SMB_ACL_T acl_d, ssize_t *len_p)
3687 + * use an initial estimate of 20 bytes per ACL entry
3688 + * when allocating memory for the text representation
3692 + maxlen = 20 * acl_d->count;
3693 + if ((text = SMB_MALLOC(maxlen)) == NULL) {
3698 + for (i = 0; i < acl_d->count; i++) {
3699 + struct acl *ap = &acl_d->acl[i];
3708 + switch (ap->a_type) {
3710 + * for debugging purposes it's probably more
3711 + * useful to dump unknown tag types rather
3712 + * than just returning an error
3715 + slprintf(tagbuf, sizeof(tagbuf)-1, "0x%x",
3718 + slprintf(idbuf, sizeof(idbuf)-1, "%ld",
3723 + case SMB_ACL_USER:
3724 + id = uidtoname(ap->a_id);
3725 + case SMB_ACL_USER_OBJ:
3729 + case SMB_ACL_GROUP:
3730 + if ((gr = getgrgid(ap->a_id)) == NULL) {
3731 + slprintf(idbuf, sizeof(idbuf)-1, "%ld",
3737 + case SMB_ACL_GROUP_OBJ:
3741 + case SMB_ACL_OTHER:
3745 + case SMB_ACL_MASK:
3751 + perms[0] = (ap->a_perm & SMB_ACL_READ) ? 'r' : '-';
3752 + perms[1] = (ap->a_perm & SMB_ACL_WRITE) ? 'w' : '-';
3753 + perms[2] = (ap->a_perm & SMB_ACL_EXECUTE) ? 'x' : '-';
3756 + /* <tag> : <qualifier> : rwx \n \0 */
3757 + nbytes = strlen(tag) + 1 + strlen(id) + 1 + 3 + 1 + 1;
3760 + * If this entry would overflow the buffer
3761 + * allocate enough additional memory for this
3762 + * entry and an estimate of another 20 bytes
3763 + * for each entry still to be processed
3765 + if ((len + nbytes) > maxlen) {
3766 + char *oldtext = text;
3768 + maxlen += nbytes + 20 * (acl_d->count - i);
3770 + if ((text = SMB_REALLOC(oldtext, maxlen)) == NULL) {
3777 + slprintf(&text[len], nbytes-1, "%s:%s:%s\n", tag, id, perms);
3778 + len += nbytes - 1;
3787 +SMB_ACL_T sys_acl_init(int count)
3797 + * note that since the definition of the structure pointed
3798 + * to by the SMB_ACL_T includes the first element of the
3799 + * acl[] array, this actually allocates an ACL with room
3800 + * for (count+1) entries
3802 + if ((a = SMB_MALLOC(sizeof(struct SMB_ACL_T) + count * sizeof(struct acl))) == NULL) {
3807 + a->size = count + 1;
3815 +int sys_acl_create_entry(SMB_ACL_T *acl_p, SMB_ACL_ENTRY_T *entry_p)
3818 + SMB_ACL_ENTRY_T entry_d;
3820 + if (acl_p == NULL || entry_p == NULL || (acl_d = *acl_p) == NULL) {
3825 + if (acl_d->count >= acl_d->size) {
3830 + entry_d = &acl_d->acl[acl_d->count++];
3831 + entry_d->a_type = 0;
3832 + entry_d->a_id = -1;
3833 + entry_d->a_perm = 0;
3834 + *entry_p = entry_d;
3839 +int sys_acl_set_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T tag_type)
3841 + switch (tag_type) {
3842 + case SMB_ACL_USER:
3843 + case SMB_ACL_USER_OBJ:
3844 + case SMB_ACL_GROUP:
3845 + case SMB_ACL_GROUP_OBJ:
3846 + case SMB_ACL_OTHER:
3847 + case SMB_ACL_MASK:
3848 + entry_d->a_type = tag_type;
3858 +int sys_acl_set_qualifier(SMB_ACL_ENTRY_T entry_d, void *qual_p)
3860 + if (entry_d->a_type != SMB_ACL_GROUP
3861 + && entry_d->a_type != SMB_ACL_USER) {
3866 + entry_d->a_id = *((id_t *)qual_p);
3871 +int sys_acl_set_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T permset_d)
3873 + if (*permset_d & ~(SMB_ACL_READ|SMB_ACL_WRITE|SMB_ACL_EXECUTE)) {
3877 + entry_d->a_perm = *permset_d;
3882 +/* Structure to capture the count for each type of ACE. */
3884 +struct hpux_acl_types {
3888 + int n_def_user_obj;
3893 + int n_def_group_obj;
3897 + int n_def_other_obj;
3900 + int n_def_class_obj;
3902 + int n_illegal_obj;
3906 + * Counts the different number of objects in a given array of ACL
3910 + * acl_count - Count of ACLs in the array of ACL strucutres.
3911 + * aclp - Array of ACL structures.
3912 + * acl_type_count - Pointer to acl_types structure. Should already be
3916 + * acl_type_count - This structure is filled up with counts of various
3920 +static int hpux_count_obj(int acl_count, struct acl *aclp, struct hpux_acl_types *acl_type_count)
3924 + memset(acl_type_count, 0, sizeof(struct hpux_acl_types));
3926 + for(i=0;i<acl_count;i++) {
3927 + switch(aclp[i].a_type) {
3929 + acl_type_count->n_user++;
3932 + acl_type_count->n_user_obj++;
3934 + case DEF_USER_OBJ:
3935 + acl_type_count->n_def_user_obj++;
3938 + acl_type_count->n_group++;
3941 + acl_type_count->n_group_obj++;
3943 + case DEF_GROUP_OBJ:
3944 + acl_type_count->n_def_group_obj++;
3947 + acl_type_count->n_other_obj++;
3949 + case DEF_OTHER_OBJ:
3950 + acl_type_count->n_def_other_obj++;
3953 + acl_type_count->n_class_obj++;
3955 + case DEF_CLASS_OBJ:
3956 + acl_type_count->n_def_class_obj++;
3959 + acl_type_count->n_def_user++;
3962 + acl_type_count->n_def_group++;
3965 + acl_type_count->n_illegal_obj++;
3971 +/* swap_acl_entries: Swaps two ACL entries.
3973 + * Inputs: aclp0, aclp1 - ACL entries to be swapped.
3976 +static void hpux_swap_acl_entries(struct acl *aclp0, struct acl *aclp1)
3978 + struct acl temp_acl;
3980 + temp_acl.a_type = aclp0->a_type;
3981 + temp_acl.a_id = aclp0->a_id;
3982 + temp_acl.a_perm = aclp0->a_perm;
3984 + aclp0->a_type = aclp1->a_type;
3985 + aclp0->a_id = aclp1->a_id;
3986 + aclp0->a_perm = aclp1->a_perm;
3988 + aclp1->a_type = temp_acl.a_type;
3989 + aclp1->a_id = temp_acl.a_id;
3990 + aclp1->a_perm = temp_acl.a_perm;
3993 +/* prohibited_duplicate_type
3994 + * Identifies if given ACL type can have duplicate entries or
3997 + * Inputs: acl_type - ACL Type.
4003 + * True - If the ACL type matches any of the prohibited types.
4004 + * False - If the ACL type doesn't match any of the prohibited types.
4007 +static BOOL hpux_prohibited_duplicate_type(int acl_type)
4009 + switch(acl_type) {
4020 +/* get_needed_class_perm
4021 + * Returns the permissions of a ACL structure only if the ACL
4022 + * type matches one of the pre-determined types for computing
4023 + * CLASS_OBJ permissions.
4025 + * Inputs: aclp - Pointer to ACL structure.
4028 +static int hpux_get_needed_class_perm(struct acl *aclp)
4030 + switch(aclp->a_type) {
4034 + case DEF_USER_OBJ:
4036 + case DEF_GROUP_OBJ:
4038 + case DEF_CLASS_OBJ:
4039 + case DEF_OTHER_OBJ:
4040 + return aclp->a_perm;
4046 +/* acl_sort for HPUX.
4047 + * Sorts the array of ACL structures as per the description in
4048 + * aclsort man page. Refer to aclsort man page for more details
4052 + * acl_count - Count of ACLs in the array of ACL structures.
4053 + * calclass - If this is not zero, then we compute the CLASS_OBJ
4055 + * aclp - Array of ACL structures.
4059 + * aclp - Sorted array of ACL structures.
4063 + * Returns 0 for success -1 for failure. Prints a message to the Samba
4064 + * debug log in case of failure.
4067 +static int hpux_acl_sort(int acl_count, int calclass, struct acl *aclp)
4069 +#if !defined(HAVE_HPUX_ACLSORT)
4071 + * The aclsort() system call is availabe on the latest HPUX General
4072 + * Patch Bundles. So for HPUX, we developed our version of acl_sort
4073 + * function. Because, we don't want to update to a new
4074 + * HPUX GR bundle just for aclsort() call.
4077 + struct hpux_acl_types acl_obj_count;
4078 + int n_class_obj_perm = 0;
4082 + DEBUG(10,("Zero acl count passed. Returning Success\n"));
4086 + if(aclp == NULL) {
4087 + DEBUG(0,("Null ACL pointer in hpux_acl_sort. Returning Failure. \n"));
4091 + /* Count different types of ACLs in the ACLs array */
4093 + hpux_count_obj(acl_count, aclp, &acl_obj_count);
4095 + /* There should be only one entry each of type USER_OBJ, GROUP_OBJ,
4096 + * CLASS_OBJ and OTHER_OBJ
4099 + if( (acl_obj_count.n_user_obj != 1) ||
4100 + (acl_obj_count.n_group_obj != 1) ||
4101 + (acl_obj_count.n_class_obj != 1) ||
4102 + (acl_obj_count.n_other_obj != 1)
4104 + DEBUG(0,("hpux_acl_sort: More than one entry or no entries for \
4105 +USER OBJ or GROUP_OBJ or OTHER_OBJ or CLASS_OBJ\n"));
4109 + /* If any of the default objects are present, there should be only
4110 + * one of them each.
4113 + if( (acl_obj_count.n_def_user_obj > 1) || (acl_obj_count.n_def_group_obj > 1) ||
4114 + (acl_obj_count.n_def_other_obj > 1) || (acl_obj_count.n_def_class_obj > 1) ) {
4115 + DEBUG(0,("hpux_acl_sort: More than one entry for DEF_CLASS_OBJ \
4116 +or DEF_USER_OBJ or DEF_GROUP_OBJ or DEF_OTHER_OBJ\n"));
4120 + /* We now have proper number of OBJ and DEF_OBJ entries. Now sort the acl
4123 + * Sorting crieteria - First sort by ACL type. If there are multiple entries of
4124 + * same ACL type, sort by ACL id.
4126 + * I am using the trival kind of sorting method here because, performance isn't
4127 + * really effected by the ACLs feature. More over there aren't going to be more
4128 + * than 17 entries on HPUX.
4131 + for(i=0; i<acl_count;i++) {
4132 + for (j=i+1; j<acl_count; j++) {
4133 + if( aclp[i].a_type > aclp[j].a_type ) {
4134 + /* ACL entries out of order, swap them */
4136 + hpux_swap_acl_entries((aclp+i), (aclp+j));
4138 + } else if ( aclp[i].a_type == aclp[j].a_type ) {
4140 + /* ACL entries of same type, sort by id */
4142 + if(aclp[i].a_id > aclp[j].a_id) {
4143 + hpux_swap_acl_entries((aclp+i), (aclp+j));
4144 + } else if (aclp[i].a_id == aclp[j].a_id) {
4145 + /* We have a duplicate entry. */
4146 + if(hpux_prohibited_duplicate_type(aclp[i].a_type)) {
4147 + DEBUG(0, ("hpux_acl_sort: Duplicate entry: Type(hex): %x Id: %d\n",
4148 + aclp[i].a_type, aclp[i].a_id));
4157 + /* set the class obj permissions to the computed one. */
4159 + int n_class_obj_index = -1;
4161 + for(i=0;i<acl_count;i++) {
4162 + n_class_obj_perm |= hpux_get_needed_class_perm((aclp+i));
4164 + if(aclp[i].a_type == CLASS_OBJ)
4165 + n_class_obj_index = i;
4167 + aclp[n_class_obj_index].a_perm = n_class_obj_perm;
4172 + return aclsort(acl_count, calclass, aclp);
4177 + * sort the ACL and check it for validity
4179 + * if it's a minimal ACL with only 4 entries then we
4180 + * need to recalculate the mask permissions to make
4181 + * sure that they are the same as the GROUP_OBJ
4182 + * permissions as required by the UnixWare acl() system call.
4184 + * (note: since POSIX allows minimal ACLs which only contain
4185 + * 3 entries - ie there is no mask entry - we should, in theory,
4186 + * check for this and add a mask entry if necessary - however
4187 + * we "know" that the caller of this interface always specifies
4188 + * a mask so, in practice "this never happens" (tm) - if it *does*
4189 + * happen aclsort() will fail and return an error and someone will
4190 + * have to fix it ...)
4193 +static int acl_sort(SMB_ACL_T acl_d)
4195 + int fixmask = (acl_d->count <= 4);
4197 + if (hpux_acl_sort(acl_d->count, fixmask, acl_d->acl) != 0) {
4204 +int sys_acl_valid(SMB_ACL_T acl_d)
4206 + return acl_sort(acl_d);
4209 +int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T type, SMB_ACL_T acl_d)
4212 + struct acl *acl_p;
4214 + struct acl *acl_buf = NULL;
4217 + if(hpux_acl_call_presence() == False) {
4218 + /* Looks like we don't have the acl() system call on HPUX.
4219 + * May be the system doesn't have the latest version of JFS.
4225 + if (type != SMB_ACL_TYPE_ACCESS && type != SMB_ACL_TYPE_DEFAULT) {
4230 + if (acl_sort(acl_d) != 0) {
4234 + acl_p = &acl_d->acl[0];
4235 + acl_count = acl_d->count;
4238 + * if it's a directory there is extra work to do
4239 + * since the acl() system call will replace both
4240 + * the access ACLs and the default ACLs (if any)
4242 + if (stat(name, &s) != 0) {
4245 + if (S_ISDIR(s.st_mode)) {
4246 + SMB_ACL_T acc_acl;
4247 + SMB_ACL_T def_acl;
4248 + SMB_ACL_T tmp_acl;
4251 + if (type == SMB_ACL_TYPE_ACCESS) {
4253 + def_acl = tmp_acl = sys_acl_get_file(name, SMB_ACL_TYPE_DEFAULT);
4257 + acc_acl = tmp_acl = sys_acl_get_file(name, SMB_ACL_TYPE_ACCESS);
4260 + if (tmp_acl == NULL) {
4265 + * allocate a temporary buffer for the complete ACL
4267 + acl_count = acc_acl->count + def_acl->count;
4268 + acl_p = acl_buf = SMB_MALLOC_ARRAY(struct acl, acl_count);
4270 + if (acl_buf == NULL) {
4271 + sys_acl_free_acl(tmp_acl);
4277 + * copy the access control and default entries into the buffer
4279 + memcpy(&acl_buf[0], &acc_acl->acl[0],
4280 + acc_acl->count * sizeof(acl_buf[0]));
4282 + memcpy(&acl_buf[acc_acl->count], &def_acl->acl[0],
4283 + def_acl->count * sizeof(acl_buf[0]));
4286 + * set the ACL_DEFAULT flag on the default entries
4288 + for (i = acc_acl->count; i < acl_count; i++) {
4289 + acl_buf[i].a_type |= ACL_DEFAULT;
4292 + sys_acl_free_acl(tmp_acl);
4294 + } else if (type != SMB_ACL_TYPE_ACCESS) {
4299 + ret = acl(name, ACL_SET, acl_count, acl_p);
4308 +int sys_acl_set_fd(int fd, SMB_ACL_T acl_d)
4311 + * HPUX doesn't have the facl call. Fake it using the path.... JRA.
4314 + files_struct *fsp = file_find_fd(fd);
4316 + if (fsp == NULL) {
4321 + if (acl_sort(acl_d) != 0) {
4326 + * We know we're in the same conn context. So we
4327 + * can use the relative path.
4330 + return sys_acl_set_file(fsp->fsp_name, SMB_ACL_TYPE_ACCESS, acl_d);
4333 +int sys_acl_delete_def_file(const char *path)
4339 + * fetching the access ACL and rewriting it has
4340 + * the effect of deleting the default ACL
4342 + if ((acl_d = sys_acl_get_file(path, SMB_ACL_TYPE_ACCESS)) == NULL) {
4346 + ret = acl(path, ACL_SET, acl_d->count, acl_d->acl);
4348 + sys_acl_free_acl(acl_d);
4353 +int sys_acl_free_text(char *text)
4359 +int sys_acl_free_acl(SMB_ACL_T acl_d)
4365 +int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype)
4370 +#elif defined(HAVE_IRIX_ACLS)
4372 +int sys_acl_get_entry(SMB_ACL_T acl_d, int entry_id, SMB_ACL_ENTRY_T *entry_p)
4374 + if (entry_id != SMB_ACL_FIRST_ENTRY && entry_id != SMB_ACL_NEXT_ENTRY) {
4379 + if (entry_p == NULL) {
4384 + if (entry_id == SMB_ACL_FIRST_ENTRY) {
4388 + if (acl_d->next < 0) {
4393 + if (acl_d->next >= acl_d->aclp->acl_cnt) {
4397 + *entry_p = &acl_d->aclp->acl_entry[acl_d->next++];
4402 +int sys_acl_get_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *type_p)
4404 + *type_p = entry_d->ae_tag;
4409 +int sys_acl_get_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
4411 + *permset_p = entry_d;
4416 +void *sys_acl_get_qualifier(SMB_ACL_ENTRY_T entry_d)
4418 + if (entry_d->ae_tag != SMB_ACL_USER
4419 + && entry_d->ae_tag != SMB_ACL_GROUP) {
4424 + return &entry_d->ae_id;
4427 +SMB_ACL_T sys_acl_get_file(const char *path_p, SMB_ACL_TYPE_T type)
4431 + if ((a = SMB_MALLOC_P(struct SMB_ACL_T)) == NULL) {
4435 + if ((a->aclp = acl_get_file(path_p, type)) == NULL) {
4440 + a->freeaclp = True;
4444 +SMB_ACL_T sys_acl_get_fd(int fd)
4448 + if ((a = SMB_MALLOC_P(struct SMB_ACL_T)) == NULL) {
4452 + if ((a->aclp = acl_get_fd(fd)) == NULL) {
4457 + a->freeaclp = True;
4461 +int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset_d)
4463 + permset_d->ae_perm = 0;
4468 +int sys_acl_add_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
4470 + if (perm != SMB_ACL_READ && perm != SMB_ACL_WRITE
4471 + && perm != SMB_ACL_EXECUTE) {
4476 + if (permset_d == NULL) {
4481 + permset_d->ae_perm |= perm;
4486 +int sys_acl_get_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
4488 + return permset_d->ae_perm & perm;
4491 +char *sys_acl_to_text(SMB_ACL_T acl_d, ssize_t *len_p)
4493 + return acl_to_text(acl_d->aclp, len_p);
4496 +SMB_ACL_T sys_acl_init(int count)
4505 + if ((a = SMB_MALLOC(sizeof(struct SMB_ACL_T) + sizeof(struct acl))) == NULL) {
4511 + a->freeaclp = False;
4512 + a->aclp = (struct acl *)(&a->aclp + sizeof(struct acl *));
4513 + a->aclp->acl_cnt = 0;
4519 +int sys_acl_create_entry(SMB_ACL_T *acl_p, SMB_ACL_ENTRY_T *entry_p)
4522 + SMB_ACL_ENTRY_T entry_d;
4524 + if (acl_p == NULL || entry_p == NULL || (acl_d = *acl_p) == NULL) {
4529 + if (acl_d->aclp->acl_cnt >= ACL_MAX_ENTRIES) {
4534 + entry_d = &acl_d->aclp->acl_entry[acl_d->aclp->acl_cnt++];
4535 + entry_d->ae_tag = 0;
4536 + entry_d->ae_id = 0;
4537 + entry_d->ae_perm = 0;
4538 + *entry_p = entry_d;
4543 +int sys_acl_set_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T tag_type)
4545 + switch (tag_type) {
4546 + case SMB_ACL_USER:
4547 + case SMB_ACL_USER_OBJ:
4548 + case SMB_ACL_GROUP:
4549 + case SMB_ACL_GROUP_OBJ:
4550 + case SMB_ACL_OTHER:
4551 + case SMB_ACL_MASK:
4552 + entry_d->ae_tag = tag_type;
4562 +int sys_acl_set_qualifier(SMB_ACL_ENTRY_T entry_d, void *qual_p)
4564 + if (entry_d->ae_tag != SMB_ACL_GROUP
4565 + && entry_d->ae_tag != SMB_ACL_USER) {
4570 + entry_d->ae_id = *((id_t *)qual_p);
4575 +int sys_acl_set_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T permset_d)
4577 + if (permset_d->ae_perm & ~(SMB_ACL_READ|SMB_ACL_WRITE|SMB_ACL_EXECUTE)) {
4581 + entry_d->ae_perm = permset_d->ae_perm;
4586 +int sys_acl_valid(SMB_ACL_T acl_d)
4588 + return acl_valid(acl_d->aclp);
4591 +int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T type, SMB_ACL_T acl_d)
4593 + return acl_set_file(name, type, acl_d->aclp);
4596 +int sys_acl_set_fd(int fd, SMB_ACL_T acl_d)
4598 + return acl_set_fd(fd, acl_d->aclp);
4601 +int sys_acl_delete_def_file(const char *name)
4603 + return acl_delete_def_file(name);
4606 +int sys_acl_free_text(char *text)
4608 + return acl_free(text);
4611 +int sys_acl_free_acl(SMB_ACL_T acl_d)
4613 + if (acl_d->freeaclp) {
4614 + acl_free(acl_d->aclp);
4620 +int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype)
4625 +#elif defined(HAVE_AIX_ACLS)
4627 +/* Donated by Medha Date, mdate@austin.ibm.com, for IBM */
4629 +int sys_acl_get_entry( SMB_ACL_T theacl, int entry_id, SMB_ACL_ENTRY_T *entry_p)
4631 + struct acl_entry_link *link;
4632 + struct new_acl_entry *entry;
4635 + DEBUG(10,("This is the count: %d\n",theacl->count));
4637 + /* Check if count was previously set to -1. *
4638 + * If it was, that means we reached the end *
4639 + * of the acl last time. */
4640 + if(theacl->count == -1)
4644 + /* To get to the next acl, traverse linked list until index *
4645 + * of acl matches the count we are keeping. This count is *
4646 + * incremented each time we return an acl entry. */
4648 + for(keep_going = 0; keep_going < theacl->count; keep_going++)
4649 + link = link->nextp;
4651 + entry = *entry_p = link->entryp;
4653 + DEBUG(10,("*entry_p is %d\n",entry_p));
4654 + DEBUG(10,("*entry_p->ace_access is %d\n",entry->ace_access));
4656 + /* Increment count */
4658 + if(link->nextp == NULL)
4659 + theacl->count = -1;
4664 +int sys_acl_get_tag_type( SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p)
4666 + /* Initialize tag type */
4669 + DEBUG(10,("the tagtype is %d\n",entry_d->ace_id->id_type));
4671 + /* Depending on what type of entry we have, *
4672 + * return tag type. */
4673 + switch(entry_d->ace_id->id_type) {
4675 + *tag_type_p = SMB_ACL_USER;
4678 + *tag_type_p = SMB_ACL_GROUP;
4681 + case SMB_ACL_USER_OBJ:
4682 + case SMB_ACL_GROUP_OBJ:
4683 + case SMB_ACL_OTHER:
4684 + *tag_type_p = entry_d->ace_id->id_type;
4694 +int sys_acl_get_permset( SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
4696 + DEBUG(10,("Starting AIX sys_acl_get_permset\n"));
4697 + *permset_p = &entry_d->ace_access;
4698 + DEBUG(10,("**permset_p is %d\n",**permset_p));
4699 + if(!(**permset_p & S_IXUSR) &&
4700 + !(**permset_p & S_IWUSR) &&
4701 + !(**permset_p & S_IRUSR) &&
4702 + (**permset_p != 0))
4705 + DEBUG(10,("Ending AIX sys_acl_get_permset\n"));
4709 +void *sys_acl_get_qualifier( SMB_ACL_ENTRY_T entry_d)
4711 + return(entry_d->ace_id->id_data);
4714 +SMB_ACL_T sys_acl_get_file( const char *path_p, SMB_ACL_TYPE_T type)
4716 + struct acl *file_acl = (struct acl *)NULL;
4717 + struct acl_entry *acl_entry;
4718 + struct new_acl_entry *new_acl_entry;
4719 + struct ace_id *idp;
4720 + struct acl_entry_link *acl_entry_link;
4721 + struct acl_entry_link *acl_entry_link_head;
4726 + /* AIX has no DEFAULT */
4727 + if ( type == SMB_ACL_TYPE_DEFAULT ) {
4732 + /* Get the acl using statacl */
4734 + DEBUG(10,("Entering sys_acl_get_file\n"));
4735 + DEBUG(10,("path_p is %s\n",path_p));
4737 + file_acl = (struct acl *)SMB_MALLOC(BUFSIZ);
4739 + if(file_acl == NULL) {
4741 + DEBUG(0,("Error in AIX sys_acl_get_file: %d\n",errno));
4745 + memset(file_acl,0,BUFSIZ);
4747 + rc = statacl((char *)path_p,0,file_acl,BUFSIZ);
4749 + DEBUG(0,("statacl returned %d with errno %d\n",rc,errno));
4750 + SAFE_FREE(file_acl);
4754 + DEBUG(10,("Got facl and returned it\n"));
4756 + /* Point to the first acl entry in the acl */
4757 + acl_entry = file_acl->acl_ext;
4759 + /* Begin setting up the head of the linked list *
4760 + * that will be used for the storing the acl *
4761 + * in a way that is useful for the posix_acls.c *
4764 + acl_entry_link_head = acl_entry_link = sys_acl_init(0);
4765 + if(acl_entry_link_head == NULL)
4768 + acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4769 + if(acl_entry_link->entryp == NULL) {
4770 + SAFE_FREE(file_acl);
4772 + DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
4776 + DEBUG(10,("acl_entry is %d\n",acl_entry));
4777 + DEBUG(10,("acl_last(file_acl) id %d\n",acl_last(file_acl)));
4779 + /* Check if the extended acl bit is on. *
4780 + * If it isn't, do not show the *
4781 + * contents of the acl since AIX intends *
4782 + * the extended info to remain unused */
4784 + if(file_acl->acl_mode & S_IXACL){
4785 + /* while we are not pointing to the very end */
4786 + while(acl_entry < acl_last(file_acl)) {
4787 + /* before we malloc anything, make sure this is */
4788 + /* a valid acl entry and one that we want to map */
4789 + idp = id_nxt(acl_entry->ace_id);
4790 + if((acl_entry->ace_type == ACC_SPECIFY ||
4791 + (acl_entry->ace_type == ACC_PERMIT)) && (idp != id_last(acl_entry))) {
4792 + acl_entry = acl_nxt(acl_entry);
4796 + idp = acl_entry->ace_id;
4798 + /* Check if this is the first entry in the linked list. *
4799 + * The first entry needs to keep prevp pointing to NULL *
4800 + * and already has entryp allocated. */
4802 + if(acl_entry_link_head->count != 0) {
4803 + acl_entry_link->nextp = SMB_MALLOC_P(struct acl_entry_link);
4805 + if(acl_entry_link->nextp == NULL) {
4806 + SAFE_FREE(file_acl);
4808 + DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
4812 + acl_entry_link->nextp->prevp = acl_entry_link;
4813 + acl_entry_link = acl_entry_link->nextp;
4814 + acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4815 + if(acl_entry_link->entryp == NULL) {
4816 + SAFE_FREE(file_acl);
4818 + DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
4821 + acl_entry_link->nextp = NULL;
4824 + acl_entry_link->entryp->ace_len = acl_entry->ace_len;
4826 + /* Don't really need this since all types are going *
4827 + * to be specified but, it's better than leaving it 0 */
4829 + acl_entry_link->entryp->ace_type = acl_entry->ace_type;
4831 + acl_entry_link->entryp->ace_access = acl_entry->ace_access;
4833 + memcpy(acl_entry_link->entryp->ace_id,idp,sizeof(struct ace_id));
4835 + /* The access in the acl entries must be left shifted by *
4836 + * three bites, because they will ultimately be compared *
4837 + * to S_IRUSR, S_IWUSR, and S_IXUSR. */
4839 + switch(acl_entry->ace_type){
4842 + acl_entry_link->entryp->ace_access = acl_entry->ace_access;
4843 + acl_entry_link->entryp->ace_access <<= 6;
4844 + acl_entry_link_head->count++;
4847 + /* Since there is no way to return a DENY acl entry *
4848 + * change to PERMIT and then shift. */
4849 + DEBUG(10,("acl_entry->ace_access is %d\n",acl_entry->ace_access));
4850 + acl_entry_link->entryp->ace_access = ~acl_entry->ace_access & 7;
4851 + DEBUG(10,("acl_entry_link->entryp->ace_access is %d\n",acl_entry_link->entryp->ace_access));
4852 + acl_entry_link->entryp->ace_access <<= 6;
4853 + acl_entry_link_head->count++;
4859 + DEBUG(10,("acl_entry = %d\n",acl_entry));
4860 + DEBUG(10,("The ace_type is %d\n",acl_entry->ace_type));
4862 + acl_entry = acl_nxt(acl_entry);
4864 + } /* end of if enabled */
4866 + /* Since owner, group, other acl entries are not *
4867 + * part of the acl entries in an acl, they must *
4868 + * be dummied up to become part of the list. */
4870 + for( i = 1; i < 4; i++) {
4871 + DEBUG(10,("i is %d\n",i));
4872 + if(acl_entry_link_head->count != 0) {
4873 + acl_entry_link->nextp = SMB_MALLOC_P(struct acl_entry_link);
4874 + if(acl_entry_link->nextp == NULL) {
4875 + SAFE_FREE(file_acl);
4877 + DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
4881 + acl_entry_link->nextp->prevp = acl_entry_link;
4882 + acl_entry_link = acl_entry_link->nextp;
4883 + acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4884 + if(acl_entry_link->entryp == NULL) {
4885 + SAFE_FREE(file_acl);
4887 + DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
4892 + acl_entry_link->nextp = NULL;
4894 + new_acl_entry = acl_entry_link->entryp;
4895 + idp = new_acl_entry->ace_id;
4897 + new_acl_entry->ace_len = sizeof(struct acl_entry);
4898 + new_acl_entry->ace_type = ACC_PERMIT;
4899 + idp->id_len = sizeof(struct ace_id);
4900 + DEBUG(10,("idp->id_len = %d\n",idp->id_len));
4901 + memset(idp->id_data,0,sizeof(uid_t));
4905 + new_acl_entry->ace_access = file_acl->g_access << 6;
4906 + idp->id_type = SMB_ACL_GROUP_OBJ;
4910 + new_acl_entry->ace_access = file_acl->o_access << 6;
4911 + idp->id_type = SMB_ACL_OTHER;
4915 + new_acl_entry->ace_access = file_acl->u_access << 6;
4916 + idp->id_type = SMB_ACL_USER_OBJ;
4924 + acl_entry_link_head->count++;
4925 + DEBUG(10,("new_acl_entry->ace_access = %d\n",new_acl_entry->ace_access));
4928 + acl_entry_link_head->count = 0;
4929 + SAFE_FREE(file_acl);
4931 + return(acl_entry_link_head);
4934 +SMB_ACL_T sys_acl_get_fd(int fd)
4936 + struct acl *file_acl = (struct acl *)NULL;
4937 + struct acl_entry *acl_entry;
4938 + struct new_acl_entry *new_acl_entry;
4939 + struct ace_id *idp;
4940 + struct acl_entry_link *acl_entry_link;
4941 + struct acl_entry_link *acl_entry_link_head;
4946 + /* Get the acl using fstatacl */
4948 + DEBUG(10,("Entering sys_acl_get_fd\n"));
4949 + DEBUG(10,("fd is %d\n",fd));
4950 + file_acl = (struct acl *)SMB_MALLOC(BUFSIZ);
4952 + if(file_acl == NULL) {
4954 + DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
4958 + memset(file_acl,0,BUFSIZ);
4960 + rc = fstatacl(fd,0,file_acl,BUFSIZ);
4962 + DEBUG(0,("The fstatacl call returned %d with errno %d\n",rc,errno));
4963 + SAFE_FREE(file_acl);
4967 + DEBUG(10,("Got facl and returned it\n"));
4969 + /* Point to the first acl entry in the acl */
4971 + acl_entry = file_acl->acl_ext;
4972 + /* Begin setting up the head of the linked list *
4973 + * that will be used for the storing the acl *
4974 + * in a way that is useful for the posix_acls.c *
4977 + acl_entry_link_head = acl_entry_link = sys_acl_init(0);
4978 + if(acl_entry_link_head == NULL){
4979 + SAFE_FREE(file_acl);
4983 + acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4985 + if(acl_entry_link->entryp == NULL) {
4987 + DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
4988 + SAFE_FREE(file_acl);
4992 + DEBUG(10,("acl_entry is %d\n",acl_entry));
4993 + DEBUG(10,("acl_last(file_acl) id %d\n",acl_last(file_acl)));
4995 + /* Check if the extended acl bit is on. *
4996 + * If it isn't, do not show the *
4997 + * contents of the acl since AIX intends *
4998 + * the extended info to remain unused */
5000 + if(file_acl->acl_mode & S_IXACL){
5001 + /* while we are not pointing to the very end */
5002 + while(acl_entry < acl_last(file_acl)) {
5003 + /* before we malloc anything, make sure this is */
5004 + /* a valid acl entry and one that we want to map */
5006 + idp = id_nxt(acl_entry->ace_id);
5007 + if((acl_entry->ace_type == ACC_SPECIFY ||
5008 + (acl_entry->ace_type == ACC_PERMIT)) && (idp != id_last(acl_entry))) {
5009 + acl_entry = acl_nxt(acl_entry);
5013 + idp = acl_entry->ace_id;
5015 + /* Check if this is the first entry in the linked list. *
5016 + * The first entry needs to keep prevp pointing to NULL *
5017 + * and already has entryp allocated. */
5019 + if(acl_entry_link_head->count != 0) {
5020 + acl_entry_link->nextp = SMB_MALLOC_P(struct acl_entry_link);
5021 + if(acl_entry_link->nextp == NULL) {
5023 + DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
5024 + SAFE_FREE(file_acl);
5027 + acl_entry_link->nextp->prevp = acl_entry_link;
5028 + acl_entry_link = acl_entry_link->nextp;
5029 + acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
5030 + if(acl_entry_link->entryp == NULL) {
5032 + DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
5033 + SAFE_FREE(file_acl);
5037 + acl_entry_link->nextp = NULL;
5040 + acl_entry_link->entryp->ace_len = acl_entry->ace_len;
5042 + /* Don't really need this since all types are going *
5043 + * to be specified but, it's better than leaving it 0 */
5045 + acl_entry_link->entryp->ace_type = acl_entry->ace_type;
5046 + acl_entry_link->entryp->ace_access = acl_entry->ace_access;
5048 + memcpy(acl_entry_link->entryp->ace_id, idp, sizeof(struct ace_id));
5050 + /* The access in the acl entries must be left shifted by *
5051 + * three bites, because they will ultimately be compared *
5052 + * to S_IRUSR, S_IWUSR, and S_IXUSR. */
5054 + switch(acl_entry->ace_type){
5057 + acl_entry_link->entryp->ace_access = acl_entry->ace_access;
5058 + acl_entry_link->entryp->ace_access <<= 6;
5059 + acl_entry_link_head->count++;
5062 + /* Since there is no way to return a DENY acl entry *
5063 + * change to PERMIT and then shift. */
5064 + DEBUG(10,("acl_entry->ace_access is %d\n",acl_entry->ace_access));
5065 + acl_entry_link->entryp->ace_access = ~acl_entry->ace_access & 7;
5066 + DEBUG(10,("acl_entry_link->entryp->ace_access is %d\n",acl_entry_link->entryp->ace_access));
5067 + acl_entry_link->entryp->ace_access <<= 6;
5068 + acl_entry_link_head->count++;
5074 + DEBUG(10,("acl_entry = %d\n",acl_entry));
5075 + DEBUG(10,("The ace_type is %d\n",acl_entry->ace_type));
5077 + acl_entry = acl_nxt(acl_entry);
5079 + } /* end of if enabled */
5081 + /* Since owner, group, other acl entries are not *
5082 + * part of the acl entries in an acl, they must *
5083 + * be dummied up to become part of the list. */
5085 + for( i = 1; i < 4; i++) {
5086 + DEBUG(10,("i is %d\n",i));
5087 + if(acl_entry_link_head->count != 0){
5088 + acl_entry_link->nextp = SMB_MALLOC_P(struct acl_entry_link);
5089 + if(acl_entry_link->nextp == NULL) {
5091 + DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
5092 + SAFE_FREE(file_acl);
5096 + acl_entry_link->nextp->prevp = acl_entry_link;
5097 + acl_entry_link = acl_entry_link->nextp;
5098 + acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
5100 + if(acl_entry_link->entryp == NULL) {
5101 + SAFE_FREE(file_acl);
5103 + DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
5108 + acl_entry_link->nextp = NULL;
5110 + new_acl_entry = acl_entry_link->entryp;
5111 + idp = new_acl_entry->ace_id;
5113 + new_acl_entry->ace_len = sizeof(struct acl_entry);
5114 + new_acl_entry->ace_type = ACC_PERMIT;
5115 + idp->id_len = sizeof(struct ace_id);
5116 + DEBUG(10,("idp->id_len = %d\n",idp->id_len));
5117 + memset(idp->id_data,0,sizeof(uid_t));
5121 + new_acl_entry->ace_access = file_acl->g_access << 6;
5122 + idp->id_type = SMB_ACL_GROUP_OBJ;
5126 + new_acl_entry->ace_access = file_acl->o_access << 6;
5127 + idp->id_type = SMB_ACL_OTHER;
5131 + new_acl_entry->ace_access = file_acl->u_access << 6;
5132 + idp->id_type = SMB_ACL_USER_OBJ;
5139 + acl_entry_link_head->count++;
5140 + DEBUG(10,("new_acl_entry->ace_access = %d\n",new_acl_entry->ace_access));
5143 + acl_entry_link_head->count = 0;
5144 + SAFE_FREE(file_acl);
5146 + return(acl_entry_link_head);
5149 +int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset)
5151 + *permset = *permset & ~0777;
5155 +int sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
5158 + (perm & (S_IXUSR | S_IWUSR | S_IRUSR)) == 0)
5162 + DEBUG(10,("This is the permset now: %d\n",*permset));
5166 +char *sys_acl_to_text( SMB_ACL_T theacl, ssize_t *plen)
5171 +SMB_ACL_T sys_acl_init( int count)
5173 + struct acl_entry_link *theacl = NULL;
5175 + DEBUG(10,("Entering sys_acl_init\n"));
5177 + theacl = SMB_MALLOC_P(struct acl_entry_link);
5178 + if(theacl == NULL) {
5180 + DEBUG(0,("Error in sys_acl_init is %d\n",errno));
5184 + theacl->count = 0;
5185 + theacl->nextp = NULL;
5186 + theacl->prevp = NULL;
5187 + theacl->entryp = NULL;
5188 + DEBUG(10,("Exiting sys_acl_init\n"));
5192 +int sys_acl_create_entry( SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry)
5194 + struct acl_entry_link *theacl;
5195 + struct acl_entry_link *acl_entryp;
5196 + struct acl_entry_link *temp_entry;
5199 + DEBUG(10,("Entering the sys_acl_create_entry\n"));
5201 + theacl = acl_entryp = *pacl;
5203 + /* Get to the end of the acl before adding entry */
5205 + for(counting=0; counting < theacl->count; counting++){
5206 + DEBUG(10,("The acl_entryp is %d\n",acl_entryp));
5207 + temp_entry = acl_entryp;
5208 + acl_entryp = acl_entryp->nextp;
5211 + if(theacl->count != 0){
5212 + temp_entry->nextp = acl_entryp = SMB_MALLOC_P(struct acl_entry_link);
5213 + if(acl_entryp == NULL) {
5215 + DEBUG(0,("Error in sys_acl_create_entry is %d\n",errno));
5219 + DEBUG(10,("The acl_entryp is %d\n",acl_entryp));
5220 + acl_entryp->prevp = temp_entry;
5221 + DEBUG(10,("The acl_entryp->prevp is %d\n",acl_entryp->prevp));
5224 + *pentry = acl_entryp->entryp = SMB_MALLOC_P(struct new_acl_entry);
5225 + if(*pentry == NULL) {
5227 + DEBUG(0,("Error in sys_acl_create_entry is %d\n",errno));
5231 + memset(*pentry,0,sizeof(struct new_acl_entry));
5232 + acl_entryp->entryp->ace_len = sizeof(struct acl_entry);
5233 + acl_entryp->entryp->ace_type = ACC_PERMIT;
5234 + acl_entryp->entryp->ace_id->id_len = sizeof(struct ace_id);
5235 + acl_entryp->nextp = NULL;
5237 + DEBUG(10,("Exiting sys_acl_create_entry\n"));
5241 +int sys_acl_set_tag_type( SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype)
5243 + DEBUG(10,("Starting AIX sys_acl_set_tag_type\n"));
5244 + entry->ace_id->id_type = tagtype;
5245 + DEBUG(10,("The tag type is %d\n",entry->ace_id->id_type));
5246 + DEBUG(10,("Ending AIX sys_acl_set_tag_type\n"));
5249 +int sys_acl_set_qualifier( SMB_ACL_ENTRY_T entry, void *qual)
5251 + DEBUG(10,("Starting AIX sys_acl_set_qualifier\n"));
5252 + memcpy(entry->ace_id->id_data,qual,sizeof(uid_t));
5253 + DEBUG(10,("Ending AIX sys_acl_set_qualifier\n"));
5257 +int sys_acl_set_permset( SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset)
5259 + DEBUG(10,("Starting AIX sys_acl_set_permset\n"));
5260 + if(!(*permset & S_IXUSR) &&
5261 + !(*permset & S_IWUSR) &&
5262 + !(*permset & S_IRUSR) &&
5266 + entry->ace_access = *permset;
5267 + DEBUG(10,("entry->ace_access = %d\n",entry->ace_access));
5268 + DEBUG(10,("Ending AIX sys_acl_set_permset\n"));
5272 +int sys_acl_valid( SMB_ACL_T theacl )
5275 + int group_obj = 0;
5276 + int other_obj = 0;
5277 + struct acl_entry_link *acl_entry;
5279 + for(acl_entry=theacl; acl_entry != NULL; acl_entry = acl_entry->nextp) {
5280 + user_obj += (acl_entry->entryp->ace_id->id_type == SMB_ACL_USER_OBJ);
5281 + group_obj += (acl_entry->entryp->ace_id->id_type == SMB_ACL_GROUP_OBJ);
5282 + other_obj += (acl_entry->entryp->ace_id->id_type == SMB_ACL_OTHER);
5285 + DEBUG(10,("user_obj=%d, group_obj=%d, other_obj=%d\n",user_obj,group_obj,other_obj));
5287 + if(user_obj != 1 || group_obj != 1 || other_obj != 1)
5293 +int sys_acl_set_file( const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl)
5295 + struct acl_entry_link *acl_entry_link = NULL;
5296 + struct acl *file_acl = NULL;
5297 + struct acl *file_acl_temp = NULL;
5298 + struct acl_entry *acl_entry = NULL;
5299 + struct ace_id *ace_id = NULL;
5306 + DEBUG(10,("Entering sys_acl_set_file\n"));
5307 + DEBUG(10,("File name is %s\n",name));
5309 + /* AIX has no default ACL */
5310 + if(acltype == SMB_ACL_TYPE_DEFAULT)
5313 + acl_length = BUFSIZ;
5314 + file_acl = (struct acl *)SMB_MALLOC(BUFSIZ);
5316 + if(file_acl == NULL) {
5318 + DEBUG(0,("Error in sys_acl_set_file is %d\n",errno));
5322 + memset(file_acl,0,BUFSIZ);
5324 + file_acl->acl_len = ACL_SIZ;
5325 + file_acl->acl_mode = S_IXACL;
5327 + for(acl_entry_link=theacl; acl_entry_link != NULL; acl_entry_link = acl_entry_link->nextp) {
5328 + acl_entry_link->entryp->ace_access >>= 6;
5329 + id_type = acl_entry_link->entryp->ace_id->id_type;
5332 + case SMB_ACL_USER_OBJ:
5333 + file_acl->u_access = acl_entry_link->entryp->ace_access;
5335 + case SMB_ACL_GROUP_OBJ:
5336 + file_acl->g_access = acl_entry_link->entryp->ace_access;
5338 + case SMB_ACL_OTHER:
5339 + file_acl->o_access = acl_entry_link->entryp->ace_access;
5341 + case SMB_ACL_MASK:
5345 + if((file_acl->acl_len + sizeof(struct acl_entry)) > acl_length) {
5346 + acl_length += sizeof(struct acl_entry);
5347 + file_acl_temp = (struct acl *)SMB_MALLOC(acl_length);
5348 + if(file_acl_temp == NULL) {
5349 + SAFE_FREE(file_acl);
5351 + DEBUG(0,("Error in sys_acl_set_file is %d\n",errno));
5355 + memcpy(file_acl_temp,file_acl,file_acl->acl_len);
5356 + SAFE_FREE(file_acl);
5357 + file_acl = file_acl_temp;
5360 + acl_entry = (struct acl_entry *)((char *)file_acl + file_acl->acl_len);
5361 + file_acl->acl_len += sizeof(struct acl_entry);
5362 + acl_entry->ace_len = acl_entry_link->entryp->ace_len;
5363 + acl_entry->ace_access = acl_entry_link->entryp->ace_access;
5365 + /* In order to use this, we'll need to wait until we can get denies */
5366 + /* if(!acl_entry->ace_access && acl_entry->ace_type == ACC_PERMIT)
5367 + acl_entry->ace_type = ACC_SPECIFY; */
5369 + acl_entry->ace_type = ACC_SPECIFY;
5371 + ace_id = acl_entry->ace_id;
5373 + ace_id->id_type = acl_entry_link->entryp->ace_id->id_type;
5374 + DEBUG(10,("The id type is %d\n",ace_id->id_type));
5375 + ace_id->id_len = acl_entry_link->entryp->ace_id->id_len;
5376 + memcpy(&user_id, acl_entry_link->entryp->ace_id->id_data, sizeof(uid_t));
5377 + memcpy(acl_entry->ace_id->id_data, &user_id, sizeof(uid_t));
5380 + rc = chacl(name,file_acl,file_acl->acl_len);
5381 + DEBUG(10,("errno is %d\n",errno));
5382 + DEBUG(10,("return code is %d\n",rc));
5383 + SAFE_FREE(file_acl);
5384 + DEBUG(10,("Exiting the sys_acl_set_file\n"));
5388 +int sys_acl_set_fd( int fd, SMB_ACL_T theacl)
5390 + struct acl_entry_link *acl_entry_link = NULL;
5391 + struct acl *file_acl = NULL;
5392 + struct acl *file_acl_temp = NULL;
5393 + struct acl_entry *acl_entry = NULL;
5394 + struct ace_id *ace_id = NULL;
5400 + DEBUG(10,("Entering sys_acl_set_fd\n"));
5401 + acl_length = BUFSIZ;
5402 + file_acl = (struct acl *)SMB_MALLOC(BUFSIZ);
5404 + if(file_acl == NULL) {
5406 + DEBUG(0,("Error in sys_acl_set_fd is %d\n",errno));
5410 + memset(file_acl,0,BUFSIZ);
5412 + file_acl->acl_len = ACL_SIZ;
5413 + file_acl->acl_mode = S_IXACL;
5415 + for(acl_entry_link=theacl; acl_entry_link != NULL; acl_entry_link = acl_entry_link->nextp) {
5416 + acl_entry_link->entryp->ace_access >>= 6;
5417 + id_type = acl_entry_link->entryp->ace_id->id_type;
5418 + DEBUG(10,("The id_type is %d\n",id_type));
5421 + case SMB_ACL_USER_OBJ:
5422 + file_acl->u_access = acl_entry_link->entryp->ace_access;
5424 + case SMB_ACL_GROUP_OBJ:
5425 + file_acl->g_access = acl_entry_link->entryp->ace_access;
5427 + case SMB_ACL_OTHER:
5428 + file_acl->o_access = acl_entry_link->entryp->ace_access;
5430 + case SMB_ACL_MASK:
5434 + if((file_acl->acl_len + sizeof(struct acl_entry)) > acl_length) {
5435 + acl_length += sizeof(struct acl_entry);
5436 + file_acl_temp = (struct acl *)SMB_MALLOC(acl_length);
5437 + if(file_acl_temp == NULL) {
5438 + SAFE_FREE(file_acl);
5440 + DEBUG(0,("Error in sys_acl_set_fd is %d\n",errno));
5444 + memcpy(file_acl_temp,file_acl,file_acl->acl_len);
5445 + SAFE_FREE(file_acl);
5446 + file_acl = file_acl_temp;
5449 + acl_entry = (struct acl_entry *)((char *)file_acl + file_acl->acl_len);
5450 + file_acl->acl_len += sizeof(struct acl_entry);
5451 + acl_entry->ace_len = acl_entry_link->entryp->ace_len;
5452 + acl_entry->ace_access = acl_entry_link->entryp->ace_access;
5454 + /* In order to use this, we'll need to wait until we can get denies */
5455 + /* if(!acl_entry->ace_access && acl_entry->ace_type == ACC_PERMIT)
5456 + acl_entry->ace_type = ACC_SPECIFY; */
5458 + acl_entry->ace_type = ACC_SPECIFY;
5460 + ace_id = acl_entry->ace_id;
5462 + ace_id->id_type = acl_entry_link->entryp->ace_id->id_type;
5463 + DEBUG(10,("The id type is %d\n",ace_id->id_type));
5464 + ace_id->id_len = acl_entry_link->entryp->ace_id->id_len;
5465 + memcpy(&user_id, acl_entry_link->entryp->ace_id->id_data, sizeof(uid_t));
5466 + memcpy(ace_id->id_data, &user_id, sizeof(uid_t));
5469 + rc = fchacl(fd,file_acl,file_acl->acl_len);
5470 + DEBUG(10,("errno is %d\n",errno));
5471 + DEBUG(10,("return code is %d\n",rc));
5472 + SAFE_FREE(file_acl);
5473 + DEBUG(10,("Exiting sys_acl_set_fd\n"));
5477 +int sys_acl_delete_def_file(const char *name)
5479 + /* AIX has no default ACL */
5483 +int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
5485 + return(*permset & perm);
5488 +int sys_acl_free_text(char *text)
5493 +int sys_acl_free_acl(SMB_ACL_T posix_acl)
5495 + struct acl_entry_link *acl_entry_link;
5497 + for(acl_entry_link = posix_acl->nextp; acl_entry_link->nextp != NULL; acl_entry_link = acl_entry_link->nextp) {
5498 + SAFE_FREE(acl_entry_link->prevp->entryp);
5499 + SAFE_FREE(acl_entry_link->prevp);
5502 + SAFE_FREE(acl_entry_link->prevp->entryp);
5503 + SAFE_FREE(acl_entry_link->prevp);
5504 + SAFE_FREE(acl_entry_link->entryp);
5505 + SAFE_FREE(acl_entry_link);
5510 +int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype)
5515 +#else /* No ACLs. */
5517 +int sys_acl_get_entry(UNUSED(SMB_ACL_T the_acl), UNUSED(int entry_id), UNUSED(SMB_ACL_ENTRY_T *entry_p))
5523 +int sys_acl_get_tag_type(UNUSED(SMB_ACL_ENTRY_T entry_d), UNUSED(SMB_ACL_TAG_T *tag_type_p))
5529 +int sys_acl_get_permset(UNUSED(SMB_ACL_ENTRY_T entry_d), UNUSED(SMB_ACL_PERMSET_T *permset_p))
5535 +void *sys_acl_get_qualifier(UNUSED(SMB_ACL_ENTRY_T entry_d))
5541 +SMB_ACL_T sys_acl_get_file(UNUSED(const char *path_p), UNUSED(SMB_ACL_TYPE_T type))
5544 + return (SMB_ACL_T)NULL;
5547 +SMB_ACL_T sys_acl_get_fd(UNUSED(int fd))
5550 + return (SMB_ACL_T)NULL;
5553 +int sys_acl_clear_perms(UNUSED(SMB_ACL_PERMSET_T permset))
5559 +int sys_acl_add_perm( UNUSED(SMB_ACL_PERMSET_T permset), UNUSED(SMB_ACL_PERM_T perm))
5565 +int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
5568 + return (permset & perm) ? 1 : 0;
5571 +char *sys_acl_to_text(UNUSED(SMB_ACL_T the_acl), UNUSED(ssize_t *plen))
5577 +int sys_acl_free_text(UNUSED(char *text))
5583 +SMB_ACL_T sys_acl_init(UNUSED(int count))
5589 +int sys_acl_create_entry(UNUSED(SMB_ACL_T *pacl), UNUSED(SMB_ACL_ENTRY_T *pentry))
5595 +int sys_acl_set_tag_type(UNUSED(SMB_ACL_ENTRY_T entry), UNUSED(SMB_ACL_TAG_T tagtype))
5601 +int sys_acl_set_qualifier(UNUSED(SMB_ACL_ENTRY_T entry), UNUSED(void *qual))
5607 +int sys_acl_set_permset(UNUSED(SMB_ACL_ENTRY_T entry), UNUSED(SMB_ACL_PERMSET_T permset))
5613 +int sys_acl_valid(UNUSED(SMB_ACL_T theacl))
5619 +int sys_acl_set_file(UNUSED(const char *name), UNUSED(SMB_ACL_TYPE_T acltype), UNUSED(SMB_ACL_T theacl))
5625 +int sys_acl_set_fd(UNUSED(int fd), UNUSED(SMB_ACL_T theacl))
5631 +int sys_acl_delete_def_file(UNUSED(const char *name))
5637 +int sys_acl_free_acl(UNUSED(SMB_ACL_T the_acl))
5643 +int sys_acl_free_qualifier(UNUSED(void *qual), UNUSED(SMB_ACL_TAG_T tagtype))
5649 +#endif /* No ACLs. */
5651 +/************************************************************************
5652 + Deliberately outside the ACL defines. Return 1 if this is a "no acls"
5654 +************************************************************************/
5656 +int no_acl_syscall_error(int err)
5658 +#if defined(ENOSYS)
5659 + if (err == ENOSYS) {
5663 +#if defined(ENOTSUP)
5664 + if (err == ENOTSUP) {
5671 +#endif /* SUPPORT_ACLS */
5672 --- old/lib/sysacls.h
5673 +++ new/lib/sysacls.h
5675 +#ifdef SUPPORT_ACLS
5677 +#ifdef HAVE_SYS_ACL_H
5678 +#include <sys/acl.h>
5680 +#ifdef HAVE_ACL_LIBACL_H
5681 +#include <acl/libacl.h>
5683 +#include "smb_acls.h"
5685 +#define SMB_MALLOC(cnt) new_array(char, cnt)
5686 +#define SMB_MALLOC_P(obj) new_array(obj, 1)
5687 +#define SMB_MALLOC_ARRAY(obj, cnt) new_array(obj, cnt)
5688 +#define SMB_REALLOC(mem, cnt) realloc_array(mem, char, cnt)
5689 +#define slprintf snprintf
5691 +int sys_acl_get_entry(SMB_ACL_T the_acl, int entry_id, SMB_ACL_ENTRY_T *entry_p);
5692 +int sys_acl_get_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p);
5693 +int sys_acl_get_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p);
5694 +void *sys_acl_get_qualifier(SMB_ACL_ENTRY_T entry_d);
5695 +SMB_ACL_T sys_acl_get_file(const char *path_p, SMB_ACL_TYPE_T type);
5696 +SMB_ACL_T sys_acl_get_fd(int fd);
5697 +int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset);
5698 +int sys_acl_add_perm(SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm);
5699 +int sys_acl_get_perm(SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm);
5700 +char *sys_acl_to_text(SMB_ACL_T the_acl, ssize_t *plen);
5701 +SMB_ACL_T sys_acl_init(int count);
5702 +int sys_acl_create_entry(SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry);
5703 +int sys_acl_set_tag_type(SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype);
5704 +int sys_acl_set_qualifier(SMB_ACL_ENTRY_T entry, void *qual);
5705 +int sys_acl_set_permset(SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset);
5706 +int sys_acl_valid(SMB_ACL_T theacl);
5707 +int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl);
5708 +int sys_acl_set_fd(int fd, SMB_ACL_T theacl);
5709 +int sys_acl_delete_def_file(const char *name);
5710 +int sys_acl_free_text(char *text);
5711 +int sys_acl_free_acl(SMB_ACL_T the_acl);
5712 +int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype);
5714 +#endif /* SUPPORT_ACLS */
5717 @@ -625,8 +625,10 @@ static void log_formatted(enum logcode c
5718 c[5] = !(iflags & ITEM_REPORT_PERMS) ? '.' : 'p';
5719 c[6] = !(iflags & ITEM_REPORT_OWNER) ? '.' : 'o';
5720 c[7] = !(iflags & ITEM_REPORT_GROUP) ? '.' : 'g';
5723 + c[8] = !(iflags & ITEM_REPORT_ATIME) ? '.' : 'u';
5724 + c[9] = !(iflags & ITEM_REPORT_ACL) ? '.' : 'a';
5725 + c[10] = !(iflags & ITEM_REPORT_XATTR) ? '.' : 'x';
5728 if (iflags & (ITEM_IS_NEW|ITEM_MISSING_DATA)) {
5729 char ch = iflags & ITEM_IS_NEW ? '+' : '?';
5732 @@ -47,6 +47,7 @@ int copy_dirlinks = 0;
5734 int preserve_links = 0;
5735 int preserve_hard_links = 0;
5736 +int preserve_acls = 0;
5737 int preserve_perms = 0;
5738 int preserve_executability = 0;
5739 int preserve_devices = 0;
5740 @@ -199,6 +200,7 @@ static void print_rsync_version(enum log
5741 char const *got_socketpair = "no ";
5742 char const *have_inplace = "no ";
5743 char const *hardlinks = "no ";
5744 + char const *acls = "no ";
5745 char const *links = "no ";
5746 char const *ipv6 = "no ";
5747 STRUCT_STAT *dumstat;
5748 @@ -215,6 +217,10 @@ static void print_rsync_version(enum log
5752 +#ifdef SUPPORT_ACLS
5756 #ifdef SUPPORT_LINKS
5759 @@ -233,8 +239,8 @@ static void print_rsync_version(enum log
5760 (int)(sizeof (int64) * 8));
5761 rprintf(f, " %ssocketpairs, %shardlinks, %ssymlinks, %sIPv6, batchfiles, %sinplace,\n",
5762 got_socketpair, hardlinks, links, ipv6, have_inplace);
5763 - rprintf(f, " %sappend\n",
5765 + rprintf(f, " %sappend, %sACLs\n",
5766 + have_inplace, acls);
5768 #ifdef MAINTAINER_MODE
5769 rprintf(f, "Panic Action: \"%s\"\n", get_panic_action());
5770 @@ -280,7 +286,7 @@ void usage(enum logcode F)
5771 rprintf(F," -q, --quiet suppress non-error messages\n");
5772 rprintf(F," --no-motd suppress daemon-mode MOTD (see manpage caveat)\n");
5773 rprintf(F," -c, --checksum skip based on checksum, not mod-time & size\n");
5774 - rprintf(F," -a, --archive archive mode; same as -rlptgoD (no -H)\n");
5775 + rprintf(F," -a, --archive archive mode; same as -rlptgoD (no -H, -A)\n");
5776 rprintf(F," --no-OPTION turn off an implied OPTION (e.g. --no-D)\n");
5777 rprintf(F," -r, --recursive recurse into directories\n");
5778 rprintf(F," -R, --relative use relative path names\n");
5779 @@ -302,6 +308,9 @@ void usage(enum logcode F)
5780 rprintf(F," -p, --perms preserve permissions\n");
5781 rprintf(F," -E, --executability preserve the file's executability\n");
5782 rprintf(F," --chmod=CHMOD affect file and/or directory permissions\n");
5783 +#ifdef SUPPORT_ACLS
5784 + rprintf(F," -A, --acls preserve ACLs (implies --perms)\n");
5786 rprintf(F," -o, --owner preserve owner (super-user only)\n");
5787 rprintf(F," -g, --group preserve group\n");
5788 rprintf(F," --devices preserve device files (super-user only)\n");
5789 @@ -422,6 +431,9 @@ static struct poptOption long_options[]
5790 {"no-perms", 0, POPT_ARG_VAL, &preserve_perms, 0, 0, 0 },
5791 {"no-p", 0, POPT_ARG_VAL, &preserve_perms, 0, 0, 0 },
5792 {"executability", 'E', POPT_ARG_NONE, &preserve_executability, 0, 0, 0 },
5793 + {"acls", 'A', POPT_ARG_NONE, 0, 'A', 0, 0 },
5794 + {"no-acls", 0, POPT_ARG_VAL, &preserve_acls, 0, 0, 0 },
5795 + {"no-A", 0, POPT_ARG_VAL, &preserve_acls, 0, 0, 0 },
5796 {"times", 't', POPT_ARG_VAL, &preserve_times, 1, 0, 0 },
5797 {"no-times", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
5798 {"no-t", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
5799 @@ -1093,6 +1105,24 @@ int parse_arguments(int *argc, const cha
5804 +#ifdef SUPPORT_ACLS
5805 + preserve_acls = 1;
5806 + preserve_perms = 1;
5809 + /* FIXME: this should probably be ignored with a
5810 + * warning and then countermeasures taken to
5811 + * restrict group and other access in the presence
5812 + * of any more restrictive ACLs, but this is safe
5814 + snprintf(err_buf,sizeof(err_buf),
5815 + "ACLs are not supported on this %s\n",
5816 + am_server ? "server" : "client");
5822 /* A large opt value means that set_refuse_options()
5823 * turned this option off. */
5824 @@ -1556,6 +1586,10 @@ void server_options(char **args,int *arg
5826 else if (preserve_executability && am_sender)
5828 +#ifdef SUPPORT_ACLS
5829 + if (preserve_acls)
5830 + argstr[x++] = 'A';
5834 if (always_checksum)
5837 @@ -48,6 +48,7 @@ extern int keep_partial;
5838 extern int checksum_seed;
5840 extern int delay_updates;
5841 +extern mode_t orig_umask;
5842 extern struct stats stats;
5843 extern char *tmpdir;
5844 extern char *partial_dir;
5845 @@ -348,6 +349,10 @@ int recv_files(int f_in, char *local_nam
5846 int itemizing = am_server ? logfile_format_has_i : stdout_format_has_i;
5847 enum logcode log_code = log_before_transfer ? FLOG : FINFO;
5848 int max_phase = protocol_version >= 29 ? 2 : 1;
5849 + int dflt_perms = (ACCESSPERMS & ~orig_umask);
5850 +#ifdef SUPPORT_ACLS
5851 + const char *parent_dirname = "";
5856 @@ -563,7 +568,16 @@ int recv_files(int f_in, char *local_nam
5857 * mode based on the local permissions and some heuristics. */
5858 if (!preserve_perms) {
5859 int exists = fd1 != -1;
5860 - file->mode = dest_mode(file->mode, st.st_mode, exists);
5861 +#ifdef SUPPORT_ACLS
5862 + const char *dn = file->dirname ? file->dirname : ".";
5863 + if (parent_dirname != dn
5864 + && strcmp(parent_dirname, dn) != 0) {
5865 + dflt_perms = default_perms_for_dir(dn);
5866 + parent_dirname = dn;
5869 + file->mode = dest_mode(file->mode, st.st_mode,
5870 + dflt_perms, exists);
5873 /* We now check to see if we are writing the file "inplace" */
5880 +extern int preserve_acls;
5881 extern int preserve_perms;
5882 extern int preserve_executability;
5883 extern int preserve_times;
5884 @@ -50,7 +51,6 @@ extern int inplace;
5885 extern int flist_eof;
5886 extern int keep_dirlinks;
5887 extern int make_backups;
5888 -extern mode_t orig_umask;
5889 extern struct file_list *cur_flist, *first_flist, *dir_flist;
5890 extern struct chmod_mode_struct *daemon_chmod_modes;
5892 @@ -202,7 +202,8 @@ void free_sums(struct sum_struct *s)
5894 /* This is only called when we aren't preserving permissions. Figure out what
5895 * the permissions should be and return them merged back into the mode. */
5896 -mode_t dest_mode(mode_t flist_mode, mode_t stat_mode, int exists)
5897 +mode_t dest_mode(mode_t flist_mode, mode_t stat_mode, int dflt_perms,
5901 /* If the file already exists, we'll return the local permissions,
5902 @@ -219,56 +220,65 @@ mode_t dest_mode(mode_t flist_mode, mode
5903 new_mode |= (new_mode & 0444) >> 2;
5906 - /* Apply the umask and turn off special permissions. */
5907 - new_mode = flist_mode & (~CHMOD_BITS | (ACCESSPERMS & ~orig_umask));
5908 + /* Apply destination default permissions and turn
5909 + * off special permissions. */
5910 + new_mode = flist_mode & (~CHMOD_BITS | dflt_perms);
5915 -int set_file_attrs(char *fname, struct file_struct *file, STRUCT_STAT *st,
5916 +int set_file_attrs(char *fname, struct file_struct *file, statx *sxp,
5922 int change_uid, change_gid;
5923 mode_t new_mode = file->mode;
5929 - if (link_stat(fname, &st2, 0) < 0) {
5930 + if (link_stat(fname, &sx2.st, 0) < 0) {
5931 rsyserr(FERROR, errno, "stat %s failed",
5936 +#ifdef SUPPORT_ACLS
5937 + sx2.acc_acl = sx2.def_acl = NULL;
5939 if (!preserve_perms && S_ISDIR(new_mode)
5940 - && st->st_mode & S_ISGID) {
5941 + && sx2.st.st_mode & S_ISGID) {
5942 /* We just created this directory and its setgid
5943 * bit is on, so make sure it stays on. */
5944 new_mode |= S_ISGID;
5949 - if (!preserve_times || (S_ISDIR(st->st_mode) && omit_dir_times))
5950 +#ifdef SUPPORT_ACLS
5951 + if (preserve_acls && !ACL_READY(*sxp))
5952 + get_acl(fname, sxp);
5955 + if (!preserve_times || (S_ISDIR(sxp->st.st_mode) && omit_dir_times))
5956 flags |= ATTRS_SKIP_MTIME;
5957 if (!(flags & ATTRS_SKIP_MTIME)
5958 - && cmp_time(st->st_mtime, file->modtime) != 0) {
5959 - int ret = set_modtime(fname, file->modtime, st->st_mode);
5960 + && cmp_time(sxp->st.st_mtime, file->modtime) != 0) {
5961 + int ret = set_modtime(fname, file->modtime, sxp->st.st_mode);
5963 rsyserr(FERROR, errno, "failed to set times on %s",
5968 if (ret == 0) /* ret == 1 if symlink could not be set */
5972 - change_uid = am_root && preserve_uid && st->st_uid != F_UID(file);
5973 + change_uid = am_root && preserve_uid && sxp->st.st_uid != F_UID(file);
5974 change_gid = preserve_gid && F_GID(file) != GID_NONE
5975 - && st->st_gid != F_GID(file);
5976 + && sxp->st.st_gid != F_GID(file);
5977 #if !defined HAVE_LCHOWN && !defined CHOWN_MODIFIES_SYMLINK
5978 - if (S_ISLNK(st->st_mode))
5979 + if (S_ISLNK(sxp->st.st_mode))
5983 @@ -278,45 +288,57 @@ int set_file_attrs(char *fname, struct f
5985 "set uid of %s from %ld to %ld\n",
5987 - (long)st->st_uid, (long)F_UID(file));
5988 + (long)sxp->st.st_uid, (long)F_UID(file));
5992 "set gid of %s from %ld to %ld\n",
5994 - (long)st->st_gid, (long)F_GID(file));
5995 + (long)sxp->st.st_gid, (long)F_GID(file));
5998 if (do_lchown(fname,
5999 - change_uid ? F_UID(file) : st->st_uid,
6000 - change_gid ? F_GID(file) : st->st_gid) != 0) {
6001 + change_uid ? F_UID(file) : sxp->st.st_uid,
6002 + change_gid ? F_GID(file) : sxp->st.st_gid) != 0) {
6003 /* shouldn't have attempted to change uid or gid
6004 * unless have the privilege */
6005 rsyserr(FERROR, errno, "%s %s failed",
6006 change_uid ? "chown" : "chgrp",
6011 /* a lchown had been done - we have to re-stat if the
6012 * destination had the setuid or setgid bits set due
6013 * to the side effect of the chown call */
6014 - if (st->st_mode & (S_ISUID | S_ISGID)) {
6015 - link_stat(fname, st,
6016 - keep_dirlinks && S_ISDIR(st->st_mode));
6017 + if (sxp->st.st_mode & (S_ISUID | S_ISGID)) {
6018 + link_stat(fname, &sxp->st,
6019 + keep_dirlinks && S_ISDIR(sxp->st.st_mode));
6024 if (daemon_chmod_modes && !S_ISLNK(new_mode))
6025 new_mode = tweak_mode(new_mode, daemon_chmod_modes);
6027 +#ifdef SUPPORT_ACLS
6028 + /* It's OK to call set_acl() now, even for a dir, as the generator
6029 + * will enable owner-writability using chmod, if necessary.
6031 + * If set_acl() changes permission bits in the process of setting
6032 + * an access ACL, it changes sxp->st.st_mode so we know whether we
6033 + * need to chmod(). */
6034 + if (preserve_acls && set_acl(fname, file, sxp) == 0)
6039 - if (!BITS_EQUAL(st->st_mode, new_mode, CHMOD_BITS)) {
6040 + if (!BITS_EQUAL(sxp->st.st_mode, new_mode, CHMOD_BITS)) {
6041 int ret = do_chmod(fname, new_mode);
6043 rsyserr(FERROR, errno,
6044 "failed to set permissions on %s",
6049 if (ret == 0) /* ret == 1 if symlink could not be set */
6051 @@ -329,6 +351,11 @@ int set_file_attrs(char *fname, struct f
6053 rprintf(FCLIENT, "%s is uptodate\n", fname);
6056 +#ifdef SUPPORT_ACLS
6057 + if (preserve_acls && sxp == &sx2)
6065 @@ -546,6 +546,14 @@ struct idev_node {
6066 #define IN_LOOPBACKNET 127
6069 +#ifndef HAVE_NO_ACLS
6070 +#define SUPPORT_ACLS 1
6073 +#if HAVE_UNIXWARE_ACLS|HAVE_SOLARIS_ACLS|HAVE_HPUX_ACLS
6074 +#define ACLS_NEED_MASK 1
6077 #define GID_NONE ((gid_t)-1)
6080 @@ -565,6 +573,7 @@ struct file_struct {
6081 extern int file_extra_cnt;
6082 extern int preserve_uid;
6083 extern int preserve_gid;
6084 +extern int preserve_acls;
6086 #define FILE_STRUCT_LEN (offsetof(struct file_struct, basename))
6087 #define EXTRA_LEN (sizeof (union file_extras))
6088 @@ -597,10 +606,12 @@ extern int preserve_gid;
6089 /* When the associated option is on, all entries will have these present: */
6090 #define F_OWNER(f) REQ_EXTRA(f, preserve_uid)->unum
6091 #define F_GROUP(f) REQ_EXTRA(f, preserve_gid)->unum
6092 +#define F_ACL(f) REQ_EXTRA(f, preserve_acls)->unum
6094 /* These items are per-entry optional and mutally exclusive: */
6095 #define F_HL_GNUM(f) OPT_EXTRA(f, LEN64_BUMP(f))->num
6096 #define F_HL_PREV(f) OPT_EXTRA(f, LEN64_BUMP(f))->num
6097 +#define F_DEF_ACL(f) OPT_EXTRA(f, LEN64_BUMP(f))->unum
6098 #define F_DIRDEV_P(f) (&OPT_EXTRA(f, LEN64_BUMP(f) + 2 - 1)->unum)
6099 #define F_DIRNODE_P(f) (&OPT_EXTRA(f, LEN64_BUMP(f) + 3 - 1)->num)
6101 @@ -752,6 +763,17 @@ struct stats {
6103 struct chmod_mode_struct;
6105 +#define EMPTY_ITEM_LIST {NULL, 0, 0}
6113 +#define EXPAND_ITEM_LIST(lp, type, incr) \
6114 + (type*)expand_item_list(lp, sizeof (type), #type, incr)
6116 #include "byteorder.h"
6117 #include "lib/mdfour.h"
6118 #include "lib/wildmatch.h"
6119 @@ -770,6 +792,16 @@ struct chmod_mode_struct;
6120 #define NORETURN __attribute__((__noreturn__))
6125 +#ifdef SUPPORT_ACLS
6126 + struct rsync_acl *acc_acl; /* access ACL */
6127 + struct rsync_acl *def_acl; /* default ACL */
6131 +#define ACL_READY(sx) ((sx).acc_acl != NULL)
6135 /* We have replacement versions of these if they're missing. */
6138 @@ -301,7 +301,7 @@ to the detailed description below for a
6139 -q, --quiet suppress non-error messages
6140 --no-motd suppress daemon-mode MOTD (see caveat)
6141 -c, --checksum skip based on checksum, not mod-time & size
6142 - -a, --archive archive mode; same as -rlptgoD (no -H)
6143 + -a, --archive archive mode; same as -rlptgoD (no -H, -A)
6144 --no-OPTION turn off an implied OPTION (e.g. --no-D)
6145 -r, --recursive recurse into directories
6146 -R, --relative use relative path names
6147 @@ -323,6 +323,7 @@ to the detailed description below for a
6148 -p, --perms preserve permissions
6149 -E, --executability preserve executability
6150 --chmod=CHMOD affect file and/or directory permissions
6151 + -A, --acls preserve ACLs (implies -p) [non-standard]
6152 -o, --owner preserve owner (super-user only)
6153 -g, --group preserve group
6154 --devices preserve device files (super-user only)
6155 @@ -771,7 +772,9 @@ quote(itemization(
6156 permissions, though the bf(--executability) option might change just
6157 the execute permission for the file.
6158 it() New files get their "normal" permission bits set to the source
6159 - file's permissions masked with the receiving end's umask setting, and
6160 + file's permissions masked with the receiving directory's default
6161 + permissions (either the receiving process's umask, or the permissions
6162 + specified via the destination directory's default ACL), and
6163 their special permission bits disabled except in the case where a new
6164 directory inherits a setgid bit from its parent directory.
6166 @@ -802,9 +805,11 @@ The preservation of the destination's se
6167 directories when bf(--perms) is off was added in rsync 2.6.7. Older rsync
6168 versions erroneously preserved the three special permission bits for
6169 newly-created files when bf(--perms) was off, while overriding the
6170 -destination's setgid bit setting on a newly-created directory. (Keep in
6171 -mind that it is the version of the receiving rsync that affects this
6173 +destination's setgid bit setting on a newly-created directory. Default ACL
6174 +observance was added to the ACL patch for rsync 2.6.7, so older (or
6175 +non-ACL-enabled) rsyncs use the umask even if default ACLs are present.
6176 +(Keep in mind that it is the version of the receiving rsync that affects
6179 dit(bf(-E, --executability)) This option causes rsync to preserve the
6180 executability (or non-executability) of regular files when bf(--perms) is
6181 @@ -822,6 +827,14 @@ quote(itemization(
6183 If bf(--perms) is enabled, this option is ignored.
6185 +dit(bf(-A, --acls)) This option causes rsync to update the destination
6186 +ACLs to be the same as the source ACLs. This nonstandard option only
6187 +works if the remote rsync also supports it. bf(--acls) implies bf(--perms).
6189 +The ACL-sending protocol used by this version was first introduced in
6190 +the patch that was shipped with 2.6.8. Sending ACLs to an older version
6191 +of the ACL patch is not supported.
6193 dit(bf(--chmod)) This option tells rsync to apply one or more
6194 comma-separated "chmod" strings to the permission of the files in the
6195 transfer. The resulting value is treated as though it was the permissions
6196 @@ -1432,8 +1445,8 @@ if the receiving rsync is at least versi
6197 with older versions of rsync, but that also turns on the output of other
6200 -The "%i" escape has a cryptic output that is 9 letters long. The general
6201 -format is like the string bf(YXcstpogz), where bf(Y) is replaced by the
6202 +The "%i" escape has a cryptic output that is 11 letters long. The general
6203 +format is like the string bf(YXcstpoguax), where bf(Y) is replaced by the
6204 type of update being done, bf(X) is replaced by the file-type, and the
6205 other letters represent attributes that may be output if they are being
6207 @@ -1482,7 +1495,11 @@ quote(itemization(
6208 sender's value (requires bf(--owner) and super-user privileges).
6209 it() A bf(g) means the group is different and is being updated to the
6210 sender's value (requires bf(--group) and the authority to set the group).
6211 - it() The bf(z) slot is reserved for future use.
6212 + it() The bf(u) slot is reserved for reporting update (access) time changes
6213 + (a feature that is not yet released).
6214 + it() The bf(a) means that the ACL information changed.
6215 + it() The bf(x) slot is reserved for reporting extended attribute changes
6216 + (a feature that is not yet released).
6219 One other output is possible: when deleting files, the "%i" will output
6224 + Unix SMB/Netbios implementation.
6226 + Portable SMB ACL interface
6227 + Copyright (C) Jeremy Allison 2000
6229 + This program is free software; you can redistribute it and/or modify
6230 + it under the terms of the GNU General Public License as published by
6231 + the Free Software Foundation; either version 2 of the License, or
6232 + (at your option) any later version.
6234 + This program is distributed in the hope that it will be useful,
6235 + but WITHOUT ANY WARRANTY; without even the implied warranty of
6236 + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6237 + GNU General Public License for more details.
6239 + You should have received a copy of the GNU General Public License
6240 + along with this program; if not, write to the Free Software
6241 + Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
6244 +#ifndef _SMB_ACLS_H
6245 +#define _SMB_ACLS_H
6247 +#if defined HAVE_POSIX_ACLS
6249 +/* This is an identity mapping (just remove the SMB_). */
6251 +#define SMB_ACL_TAG_T acl_tag_t
6252 +#define SMB_ACL_TYPE_T acl_type_t
6253 +#define SMB_ACL_PERMSET_T acl_permset_t
6254 +#define SMB_ACL_PERM_T acl_perm_t
6255 +#define SMB_ACL_READ ACL_READ
6256 +#define SMB_ACL_WRITE ACL_WRITE
6257 +#define SMB_ACL_EXECUTE ACL_EXECUTE
6259 +/* Types of ACLs. */
6260 +#define SMB_ACL_USER ACL_USER
6261 +#define SMB_ACL_USER_OBJ ACL_USER_OBJ
6262 +#define SMB_ACL_GROUP ACL_GROUP
6263 +#define SMB_ACL_GROUP_OBJ ACL_GROUP_OBJ
6264 +#define SMB_ACL_OTHER ACL_OTHER
6265 +#define SMB_ACL_MASK ACL_MASK
6267 +#define SMB_ACL_T acl_t
6269 +#define SMB_ACL_ENTRY_T acl_entry_t
6271 +#define SMB_ACL_FIRST_ENTRY ACL_FIRST_ENTRY
6272 +#define SMB_ACL_NEXT_ENTRY ACL_NEXT_ENTRY
6274 +#define SMB_ACL_TYPE_ACCESS ACL_TYPE_ACCESS
6275 +#define SMB_ACL_TYPE_DEFAULT ACL_TYPE_DEFAULT
6277 +#elif defined HAVE_TRU64_ACLS
6279 +/* This is for DEC/Compaq Tru64 UNIX */
6281 +#define SMB_ACL_TAG_T acl_tag_t
6282 +#define SMB_ACL_TYPE_T acl_type_t
6283 +#define SMB_ACL_PERMSET_T acl_permset_t
6284 +#define SMB_ACL_PERM_T acl_perm_t
6285 +#define SMB_ACL_READ ACL_READ
6286 +#define SMB_ACL_WRITE ACL_WRITE
6287 +#define SMB_ACL_EXECUTE ACL_EXECUTE
6289 +/* Types of ACLs. */
6290 +#define SMB_ACL_USER ACL_USER
6291 +#define SMB_ACL_USER_OBJ ACL_USER_OBJ
6292 +#define SMB_ACL_GROUP ACL_GROUP
6293 +#define SMB_ACL_GROUP_OBJ ACL_GROUP_OBJ
6294 +#define SMB_ACL_OTHER ACL_OTHER
6295 +#define SMB_ACL_MASK ACL_MASK
6297 +#define SMB_ACL_T acl_t
6299 +#define SMB_ACL_ENTRY_T acl_entry_t
6301 +#define SMB_ACL_FIRST_ENTRY 0
6302 +#define SMB_ACL_NEXT_ENTRY 1
6304 +#define SMB_ACL_TYPE_ACCESS ACL_TYPE_ACCESS
6305 +#define SMB_ACL_TYPE_DEFAULT ACL_TYPE_DEFAULT
6307 +#elif defined HAVE_UNIXWARE_ACLS || defined HAVE_SOLARIS_ACLS
6309 + * Donated by Michael Davidson <md@sco.COM> for UnixWare / OpenUNIX.
6310 + * Modified by Toomas Soome <tsoome@ut.ee> for Solaris.
6313 +/* SVR4.2 ES/MP ACLs */
6314 +typedef int SMB_ACL_TAG_T;
6315 +typedef int SMB_ACL_TYPE_T;
6316 +typedef ushort *SMB_ACL_PERMSET_T;
6317 +typedef ushort SMB_ACL_PERM_T;
6318 +#define SMB_ACL_READ 4
6319 +#define SMB_ACL_WRITE 2
6320 +#define SMB_ACL_EXECUTE 1
6322 +/* Types of ACLs. */
6323 +#define SMB_ACL_USER USER
6324 +#define SMB_ACL_USER_OBJ USER_OBJ
6325 +#define SMB_ACL_GROUP GROUP
6326 +#define SMB_ACL_GROUP_OBJ GROUP_OBJ
6327 +#define SMB_ACL_OTHER OTHER_OBJ
6328 +#define SMB_ACL_MASK CLASS_OBJ
6330 +typedef struct SMB_ACL_T {
6334 + struct acl acl[1];
6337 +typedef struct acl *SMB_ACL_ENTRY_T;
6339 +#define SMB_ACL_FIRST_ENTRY 0
6340 +#define SMB_ACL_NEXT_ENTRY 1
6342 +#define SMB_ACL_TYPE_ACCESS 0
6343 +#define SMB_ACL_TYPE_DEFAULT 1
6346 +#define SMB_ACL_LOSES_SPECIAL_MODE_BITS
6349 +#elif defined HAVE_HPUX_ACLS
6352 + * Based on the Solaris & UnixWare code.
6356 +#include <sys/aclv.h>
6358 +/* SVR4.2 ES/MP ACLs */
6359 +typedef int SMB_ACL_TAG_T;
6360 +typedef int SMB_ACL_TYPE_T;
6361 +typedef ushort *SMB_ACL_PERMSET_T;
6362 +typedef ushort SMB_ACL_PERM_T;
6363 +#define SMB_ACL_READ 4
6364 +#define SMB_ACL_WRITE 2
6365 +#define SMB_ACL_EXECUTE 1
6367 +/* Types of ACLs. */
6368 +#define SMB_ACL_USER USER
6369 +#define SMB_ACL_USER_OBJ USER_OBJ
6370 +#define SMB_ACL_GROUP GROUP
6371 +#define SMB_ACL_GROUP_OBJ GROUP_OBJ
6372 +#define SMB_ACL_OTHER OTHER_OBJ
6373 +#define SMB_ACL_MASK CLASS_OBJ
6375 +typedef struct SMB_ACL_T {
6379 + struct acl acl[1];
6382 +typedef struct acl *SMB_ACL_ENTRY_T;
6384 +#define SMB_ACL_FIRST_ENTRY 0
6385 +#define SMB_ACL_NEXT_ENTRY 1
6387 +#define SMB_ACL_TYPE_ACCESS 0
6388 +#define SMB_ACL_TYPE_DEFAULT 1
6390 +#elif defined HAVE_IRIX_ACLS
6392 +#define SMB_ACL_TAG_T acl_tag_t
6393 +#define SMB_ACL_TYPE_T acl_type_t
6394 +#define SMB_ACL_PERMSET_T acl_permset_t
6395 +#define SMB_ACL_PERM_T acl_perm_t
6396 +#define SMB_ACL_READ ACL_READ
6397 +#define SMB_ACL_WRITE ACL_WRITE
6398 +#define SMB_ACL_EXECUTE ACL_EXECUTE
6400 +/* Types of ACLs. */
6401 +#define SMB_ACL_USER ACL_USER
6402 +#define SMB_ACL_USER_OBJ ACL_USER_OBJ
6403 +#define SMB_ACL_GROUP ACL_GROUP
6404 +#define SMB_ACL_GROUP_OBJ ACL_GROUP_OBJ
6405 +#define SMB_ACL_OTHER ACL_OTHER_OBJ
6406 +#define SMB_ACL_MASK ACL_MASK
6408 +typedef struct SMB_ACL_T {
6414 +#define SMB_ACL_ENTRY_T acl_entry_t
6416 +#define SMB_ACL_FIRST_ENTRY 0
6417 +#define SMB_ACL_NEXT_ENTRY 1
6419 +#define SMB_ACL_TYPE_ACCESS ACL_TYPE_ACCESS
6420 +#define SMB_ACL_TYPE_DEFAULT ACL_TYPE_DEFAULT
6422 +#elif defined HAVE_AIX_ACLS
6424 +/* Donated by Medha Date, mdate@austin.ibm.com, for IBM */
6426 +#include "/usr/include/acl.h"
6428 +typedef uint *SMB_ACL_PERMSET_T;
6430 +struct acl_entry_link{
6431 + struct acl_entry_link *prevp;
6432 + struct new_acl_entry *entryp;
6433 + struct acl_entry_link *nextp;
6437 +struct new_acl_entry{
6438 + unsigned short ace_len;
6439 + unsigned short ace_type;
6440 + unsigned int ace_access;
6441 + struct ace_id ace_id[1];
6444 +#define SMB_ACL_ENTRY_T struct new_acl_entry*
6445 +#define SMB_ACL_T struct acl_entry_link*
6447 +#define SMB_ACL_TAG_T unsigned short
6448 +#define SMB_ACL_TYPE_T int
6449 +#define SMB_ACL_PERM_T uint
6450 +#define SMB_ACL_READ S_IRUSR
6451 +#define SMB_ACL_WRITE S_IWUSR
6452 +#define SMB_ACL_EXECUTE S_IXUSR
6454 +/* Types of ACLs. */
6455 +#define SMB_ACL_USER ACEID_USER
6456 +#define SMB_ACL_USER_OBJ 3
6457 +#define SMB_ACL_GROUP ACEID_GROUP
6458 +#define SMB_ACL_GROUP_OBJ 4
6459 +#define SMB_ACL_OTHER 5
6460 +#define SMB_ACL_MASK 6
6463 +#define SMB_ACL_FIRST_ENTRY 1
6464 +#define SMB_ACL_NEXT_ENTRY 2
6466 +#define SMB_ACL_TYPE_ACCESS 0
6467 +#define SMB_ACL_TYPE_DEFAULT 1
6469 +#else /* No ACLs. */
6471 +/* No ACLS - fake it. */
6472 +#define SMB_ACL_TAG_T int
6473 +#define SMB_ACL_TYPE_T int
6474 +#define SMB_ACL_PERMSET_T mode_t
6475 +#define SMB_ACL_PERM_T mode_t
6476 +#define SMB_ACL_READ S_IRUSR
6477 +#define SMB_ACL_WRITE S_IWUSR
6478 +#define SMB_ACL_EXECUTE S_IXUSR
6480 +/* Types of ACLs. */
6481 +#define SMB_ACL_USER 0
6482 +#define SMB_ACL_USER_OBJ 1
6483 +#define SMB_ACL_GROUP 2
6484 +#define SMB_ACL_GROUP_OBJ 3
6485 +#define SMB_ACL_OTHER 4
6486 +#define SMB_ACL_MASK 5
6488 +typedef struct SMB_ACL_T {
6492 +typedef struct SMB_ACL_ENTRY_T {
6494 +} *SMB_ACL_ENTRY_T;
6496 +#define SMB_ACL_FIRST_ENTRY 0
6497 +#define SMB_ACL_NEXT_ENTRY 1
6499 +#define SMB_ACL_TYPE_ACCESS 0
6500 +#define SMB_ACL_TYPE_DEFAULT 1
6502 +#endif /* No ACLs. */
6503 +#endif /* _SMB_ACLS_H */
6504 --- old/testsuite/acls.test
6505 +++ new/testsuite/acls.test
6509 +# This program is distributable under the terms of the GNU GPL (see
6512 +# Test that rsync handles basic ACL preservation.
6514 +. $srcdir/testsuite/rsync.fns
6516 +$RSYNC --version | grep ", ACLs" >/dev/null || test_skipped "Rsync is configured without ACL support"
6517 +case "$setfacl_nodef" in
6518 +true) test_skipped "I don't know how to use your setfacl command" ;;
6521 +makepath "$fromdir/foo"
6522 +echo something >"$fromdir/file1"
6523 +echo else >"$fromdir/file2"
6525 +files='foo file1 file2'
6527 +setfacl -m u:0:7 "$fromdir/foo" || test_skipped "Your filesystem has ACLs disabled"
6528 +setfacl -m u:0:5 "$fromdir/file1"
6529 +setfacl -m u:0:5 "$fromdir/file2"
6531 +$RSYNC -avvA "$fromdir/" "$todir/"
6534 +getfacl $files >"$scratchdir/acls.txt"
6537 +getfacl $files | diff $diffopt "$scratchdir/acls.txt" -
6539 +# The script would have aborted on error, so getting here means we've won.
6541 --- old/testsuite/default-acls.test
6542 +++ new/testsuite/default-acls.test
6546 +# This program is distributable under the terms of the GNU GPL (see
6549 +# Test that rsync obeys default ACLs. -- Matt McCutchen
6551 +. $srcdir/testsuite/rsync.fns
6553 +$RSYNC --version | grep ", ACLs" >/dev/null || test_skipped "Rsync is configured without ACL support"
6554 +case "$setfacl_nodef" in
6555 +true) test_skipped "I don't know how to use your setfacl command" ;;
6556 +*-k*) opts='-dm u::7,g::5,o:5' ;;
6557 +*) opts='-m d:u::7,d:g::5,d:o:5' ;;
6559 +setfacl $opts "$scratchdir" || test_skipped "Your filesystem has ACLs disabled"
6561 +# Call as: testit <dirname> <default-acl> <file-expected> <program-expected>
6563 + todir="$scratchdir/$1"
6565 + $setfacl_nodef "$todir"
6567 + case "$setfacl_nodef" in
6568 + *-k*) opts="-dm $2" ;;
6569 + *) opts="-m `echo $2 | sed 's/\([ugom]:\)/d:\1/g'`"
6571 + setfacl $opts "$todir"
6573 + # Make sure we obey ACLs when creating a directory to hold multiple transferred files,
6574 + # even though the directory itself is outside the transfer
6575 + $RSYNC -rvv "$scratchdir/dir" "$scratchdir/file" "$scratchdir/program" "$todir/to/"
6576 + check_perms "$todir/to" $4 "Target $1"
6577 + check_perms "$todir/to/dir" $4 "Target $1"
6578 + check_perms "$todir/to/file" $3 "Target $1"
6579 + check_perms "$todir/to/program" $4 "Target $1"
6580 + # Make sure get_local_name doesn't mess us up when transferring only one file
6581 + $RSYNC -rvv "$scratchdir/file" "$todir/to/anotherfile"
6582 + check_perms "$todir/to/anotherfile" $3 "Target $1"
6583 + # Make sure we obey default ACLs when not transferring a regular file
6584 + $RSYNC -rvv "$scratchdir/dir/" "$todir/to/anotherdir/"
6585 + check_perms "$todir/to/anotherdir" $4 "Target $1"
6588 +mkdir "$scratchdir/dir"
6589 +echo "File!" >"$scratchdir/file"
6590 +echo "#!/bin/sh" >"$scratchdir/program"
6591 +chmod 777 "$scratchdir/dir"
6592 +chmod 666 "$scratchdir/file"
6593 +chmod 777 "$scratchdir/program"
6595 +# Test some target directories
6597 +testit da777 u::7,g::7,o:7 rw-rw-rw- rwxrwxrwx
6598 +testit da775 u::7,g::7,o:5 rw-rw-r-- rwxrwxr-x
6599 +testit da750 u::7,g::5,o:0 rw-r----- rwxr-x---
6600 +testit da770mask u::7,u:0:7,g::0,m:7,o:0 rw-rw---- rwxrwx---
6601 +testit noda1 '' rw------- rwx------
6603 +testit noda2 '' rw-rw-rw- rwxrwxrwx
6605 +testit noda3 '' rw-r--r-- rwxr-xr-x
6609 --- old/testsuite/devices.test
6610 +++ new/testsuite/devices.test
6611 @@ -42,14 +42,14 @@ touch -r "$fromdir/block" "$fromdir/bloc
6612 $RSYNC -ai "$fromdir/block" "$todir/block2" \
6614 cat <<EOT >"$chkfile"
6618 diff $diffopt "$chkfile" "$outfile" || test_fail "test 1 failed"
6620 $RSYNC -ai "$fromdir/block2" "$todir/block" \
6622 cat <<EOT >"$chkfile"
6626 diff $diffopt "$chkfile" "$outfile" || test_fail "test 2 failed"
6628 @@ -58,7 +58,7 @@ sleep 1
6629 $RSYNC -Di "$fromdir/block3" "$todir/block" \
6631 cat <<EOT >"$chkfile"
6635 diff $diffopt "$chkfile" "$outfile" || test_fail "test 3 failed"
6637 @@ -66,15 +66,15 @@ $RSYNC -aiHvv "$fromdir/" "$todir/" \
6640 cat <<EOT >"$chkfile"
6645 -hD+++++++ block2.5 => block3
6654 +hD+++++++++ block2.5 => block3
6660 if test ! -b "$fromdir/block2.5"; then
6661 sed -e '/block2\.5/d' \
6662 @@ -94,15 +94,15 @@ if test -b "$fromdir/block2.5"; then
6663 $RSYNC -aii --link-dest="$todir" "$fromdir/" "$chkdir/" \
6665 cat <<EOT >"$chkfile"
6685 diff $diffopt "$chkfile" "$outfile" || test_fail "test 4 failed"
6687 --- old/testsuite/itemize.test
6688 +++ new/testsuite/itemize.test
6689 @@ -47,16 +47,16 @@ rm -f "$to2dir" "$to2dir.test"
6690 $RSYNC -iplr "$fromdir/" "$todir/" \
6692 sed -e "$sed_cmd" <<EOT >"$chkfile"
6695 -cd+++++++ foo/_P30_
6697 ->f+++++++ bar/baz/rsync
6698 -cd+++++++ foo/_P29_
6699 ->f+++++++ foo/config1
6700 ->f+++++++ foo/config2
6701 ->f+++++++ foo/extra
6702 -cL+++++++ foo/sym -> ../bar/baz/rsync
6705 +cd+++++++++ foo/_P30_
6706 +cd+++++++++ bar/baz/
6707 +>f+++++++++ bar/baz/rsync
6708 +cd+++++++++ foo/_P29_
6709 +>f+++++++++ foo/config1
6710 +>f+++++++++ foo/config2
6711 +>f+++++++++ foo/extra
6712 +cL+++++++++ foo/sym -> ../bar/baz/rsync
6714 diff $diffopt "$chkfile" "$outfile" || test_fail "test 1 failed"
6716 @@ -68,10 +68,10 @@ chmod 601 "$fromdir/foo/config2"
6717 $RSYNC -iplrH "$fromdir/" "$todir/" \
6719 sed -e "$sed_cmd" <<EOT >"$chkfile"
6720 ->f..T.... bar/baz/rsync
6721 ->f..T.... foo/config1
6722 ->f.sTp... foo/config2
6723 -hf..T.... foo/extra => foo/config1
6724 +>f..T...... bar/baz/rsync
6725 +>f..T...... foo/config1
6726 +>f.sTp..... foo/config2
6727 +hf..T...... foo/extra => foo/config1
6729 diff $diffopt "$chkfile" "$outfile" || test_fail "test 2 failed"
6731 @@ -88,12 +88,12 @@ chmod 777 "$todir/bar/baz/rsync"
6732 $RSYNC -iplrtc "$fromdir/" "$todir/" \
6734 sed -e "$sed_cmd" <<EOT >"$chkfile"
6735 -.d..t.... foo/_P30_
6736 -.f..tp... bar/baz/rsync
6737 -.d..t.... foo/_P29_
6738 -.f..t.... foo/config1
6739 ->fcstp... foo/config2
6740 -cL..T.... foo/sym -> ../bar/baz/rsync
6741 +.d..t...... foo/_P30_
6742 +.f..tp..... bar/baz/rsync
6743 +.d..t...... foo/_P29_
6744 +.f..t...... foo/config1
6745 +>fcstp..... foo/config2
6746 +cL..T...... foo/sym -> ../bar/baz/rsync
6748 diff $diffopt "$chkfile" "$outfile" || test_fail "test 3 failed"
6750 @@ -118,15 +118,15 @@ $RSYNC -ivvplrtH "$fromdir/" "$todir/" \
6753 sed -e "$sed_cmd" <<EOT >"$chkfile"
6757 -.f...p... bar/baz/rsync
6760 ->f..t.... foo/config2
6762 -.L foo/sym -> ../bar/baz/rsync
6766 +.f...p..... bar/baz/rsync
6769 +>f..t...... foo/config2
6771 +.L foo/sym -> ../bar/baz/rsync
6773 diff $diffopt "$chkfile" "$outfile" || test_fail "test 5 failed"
6775 @@ -145,8 +145,8 @@ touch "$todir/foo/config2"
6776 $RSYNC -iplrtH "$fromdir/" "$todir/" \
6778 sed -e "$sed_cmd" <<EOT >"$chkfile"
6779 -.f...p... foo/config1
6780 ->f..t.... foo/config2
6781 +.f...p..... foo/config1
6782 +>f..t...... foo/config2
6784 diff $diffopt "$chkfile" "$outfile" || test_fail "test 7 failed"
6786 @@ -154,15 +154,15 @@ $RSYNC -ivvplrtH --copy-dest=../to "$fro
6789 sed -e "$sed_cmd" <<EOT >"$chkfile"
6797 -hf foo/extra => foo/config1
6798 -cL foo/sym -> ../bar/baz/rsync
6806 +hf foo/extra => foo/config1
6807 +cL foo/sym -> ../bar/baz/rsync
6809 diff $diffopt "$chkfile" "$outfile" || test_fail "test 8 failed"
6811 @@ -170,7 +170,7 @@ rm -rf "$to2dir"
6812 $RSYNC -iplrtH --copy-dest=../to "$fromdir/" "$to2dir/" \
6814 sed -e "$sed_cmd" <<EOT >"$chkfile"
6815 -hf foo/extra => foo/config1
6816 +hf foo/extra => foo/config1
6818 diff $diffopt "$chkfile" "$outfile" || test_fail "test 9 failed"
6820 @@ -196,15 +196,15 @@ $RSYNC -ivvplrtH --link-dest="$todir" "$
6823 sed -e "$sed_cmd" <<EOT >"$chkfile"
6831 -hf foo/extra => foo/config1
6832 -$L foo/sym -> ../bar/baz/rsync
6840 +hf foo/extra => foo/config1
6841 +$L foo/sym -> ../bar/baz/rsync
6843 diff $diffopt "$chkfile" "$outfile" || test_fail "test 11 failed"
6845 @@ -244,15 +244,15 @@ $RSYNC -ivvplrtH --compare-dest="$todir"
6848 sed -e "$sed_cmd" <<EOT >"$chkfile"
6857 -.L foo/sym -> ../bar/baz/rsync
6866 +.L foo/sym -> ../bar/baz/rsync
6868 diff $diffopt "$chkfile" "$outfile" || test_fail "test 15 failed"
6872 @@ -36,6 +36,7 @@ extern int verbose;
6874 extern int preserve_uid;
6875 extern int preserve_gid;
6876 +extern int preserve_acls;
6877 extern int numeric_ids;
6880 @@ -272,7 +273,7 @@ void send_uid_list(int f)
6882 struct idlist *list;
6884 - if (preserve_uid) {
6885 + if (preserve_uid || preserve_acls) {
6887 /* we send sequences of uid/byte-length/name */
6888 for (list = uidlist; list; list = list->next) {
6889 @@ -289,7 +290,7 @@ void send_uid_list(int f)
6893 - if (preserve_gid) {
6894 + if (preserve_gid || preserve_acls) {
6896 for (list = gidlist; list; list = list->next) {
6898 @@ -329,18 +330,28 @@ void recv_uid_list(int f, struct file_li
6902 - if (preserve_uid && !numeric_ids) {
6903 + if ((preserve_uid || preserve_acls) && !numeric_ids) {
6904 /* read the uid list */
6905 while ((id = read_int(f)) != 0)
6906 recv_user_name(f, (uid_t)id);
6909 - if (preserve_gid && !numeric_ids) {
6910 + if ((preserve_gid || preserve_acls) && !numeric_ids) {
6911 /* read the gid list */
6912 while ((id = read_int(f)) != 0)
6913 recv_group_name(f, (gid_t)id);
6916 +#ifdef SUPPORT_ACLS
6917 + if (preserve_acls && !numeric_ids) {
6919 + while ((id = next_acl_uid(flist)) != NULL)
6920 + *id = match_uid(*id);
6921 + while ((id = next_acl_gid(flist)) != NULL)
6922 + *id = match_gid(*id);
6926 /* Now convert all the uids/gids from sender values to our values. */
6927 if (am_root && preserve_uid && !numeric_ids) {
6928 for (i = 0; i < flist->count; i++)
6931 @@ -1467,3 +1467,31 @@ int bitbag_next_bit(struct bitbag *bb, i
6936 +void *expand_item_list(item_list *lp, size_t item_size,
6937 + const char *desc, int incr)
6939 + /* First time through, 0 <= 0, so list is expanded. */
6940 + if (lp->malloced <= lp->count) {
6942 + size_t new_size = lp->malloced;
6944 + new_size -= incr; /* increase slowly */
6945 + else if (new_size < (size_t)incr)
6949 + new_ptr = realloc_array(lp->items, char, new_size * item_size);
6950 + if (verbose >= 4) {
6951 + rprintf(FINFO, "[%s] expand %s to %.0f bytes, did%s move\n",
6952 + who_am_i(), desc, (double)new_size * item_size,
6953 + new_ptr == lp->items ? " not" : "");
6956 + out_of_memory("expand_item_list");
6958 + lp->items = new_ptr;
6959 + lp->malloced = new_size;
6961 + return (char*)lp->items + (lp->count++ * item_size);