1 This patch changes the receiving side to have the receiving code use a thread
2 instead of a forked process. This extra thread does read from the socket, but
3 it sends any stdout/stderr messages to the generator (main thread) to output.
5 ** This is very new code. ** Yes, it passes the "make test" testsuite, but
6 there may still be some problems, especially in some of the untested features.
7 (For one thing, I haven't yet added code to properly handle any keep-alive
8 messages that arrive on the receiving side during the --delete-after phase!)
10 This code just uses pthread.h directly, so configure changes will probably be
11 needed to make this compatible with more systems. I have also tested that
12 this code works fine using the GNU pth library without any code changes if
13 you configured it with --enable-syscall-soft --enable-pthread (you may need
14 to twiddle the Makefile options if you didn't install the library, though).
16 NOTE: we still need to duplicate the partial_fname static in util.c!
18 If you try this out, please send some email to wayned@samba.org or the rsync
19 mailing list with your results, build changes, bug reports, etc. Thanks!
21 To use this patch, run these commands for a successful build:
23 patch -p1 <patches/threaded-receiver.diff
29 @@ -7,7 +7,7 @@ exec_prefix=@exec_prefix@
34 +LIBS=@LIBS@ -lpthread
40 @@ -31,10 +31,6 @@ extern int log_got_error;
41 extern char *partial_dir;
42 extern char *logfile_name;
44 -#ifdef HAVE_SIGACTION
45 -static struct sigaction sigact;
49 * Close all open sockets and files, allowing a (somewhat) graceful
50 * shutdown() of socket connections. This eliminates the abortive
51 @@ -98,9 +94,6 @@ NORETURN void _exit_cleanup(int code, co
52 static int exit_code = 0;
53 static int unmodified_code = 0;
55 - SIGACTION(SIGUSR1, SIG_IGN);
56 - SIGACTION(SIGUSR2, SIG_IGN);
58 if (exit_code) /* Preserve first error code when recursing. */
61 @@ -157,8 +150,6 @@ NORETURN void _exit_cleanup(int code, co
64 do_unlink(cleanup_fname);
67 if (cleanup_pid && cleanup_pid == getpid()) {
68 char *pidf = lp_pid_file();
73 #define RERR_CRASHED 15 /* sibling crashed */
74 #define RERR_TERMINATED 16 /* sibling terminated abnormally */
76 -#define RERR_SIGNAL1 19 /* status returned when sent SIGUSR1 */
77 #define RERR_SIGNAL 20 /* status returned when sent SIGINT, SIGTERM, SIGHUP */
78 #define RERR_WAITCHILD 21 /* some error returned by waitpid() */
79 #define RERR_MALLOC 22 /* error allocating core memory buffers */
82 @@ -66,7 +66,6 @@ extern OFF_T min_size;
84 extern int allowed_lull;
85 extern int sock_f_out;
86 -extern int ignore_timeout;
87 extern int protocol_version;
88 extern int fuzzy_basis;
89 extern int always_checksum;
90 @@ -95,6 +94,11 @@ extern struct filter_list_struct server_
92 static int deletion_count = 0; /* used to implement --max-delete */
94 +/* These vars are local copies so that the receiver can use the originals. */
95 +static int GEN_append_mode;
96 +static int GEN_make_backups;
97 +static int GEN_csum_length;
99 /* For calling delete_item() */
100 #define DEL_RECURSE (1<<1) /* recurse */
102 @@ -477,8 +481,8 @@ static void sum_sizes_sqroot(struct sum_
105 if (protocol_version < 27) {
106 - s2length = csum_length;
107 - } else if (csum_length == SUM_LENGTH) {
108 + s2length = GEN_csum_length;
109 + } else if (GEN_csum_length == SUM_LENGTH) {
110 s2length = SUM_LENGTH;
113 @@ -488,7 +492,7 @@ static void sum_sizes_sqroot(struct sum_
114 for (c = blength; (c >>= 1) && b; b--) {}
115 /* add a bit, subtract rollsum, round up. */
116 s2length = (b + 1 - 32 + 7) / 8; /* --optimize in compiler-- */
117 - s2length = MAX(s2length, csum_length);
118 + s2length = MAX(s2length, GEN_csum_length);
119 s2length = MIN(s2length, SUM_LENGTH);
122 @@ -522,7 +526,7 @@ static void generate_and_send_sums(int f
123 sum_sizes_sqroot(&sum, len);
124 write_sum_head(f_out, &sum);
126 - if (append_mode > 0 && f_copy < 0)
127 + if (GEN_append_mode > 0 && f_copy < 0)
131 @@ -541,7 +545,7 @@ static void generate_and_send_sums(int f
134 full_write(f_copy, map, n1);
135 - if (append_mode > 0)
136 + if (GEN_append_mode > 0)
140 @@ -1316,7 +1320,7 @@ static void recv_generator(char *fname,
144 - if (append_mode && st.st_size > file->length)
145 + if (GEN_append_mode && st.st_size > file->length)
148 if (fnamecmp_type <= FNAMECMP_BASIS_DIR_HIGH)
149 @@ -1379,7 +1383,7 @@ static void recv_generator(char *fname,
153 - if (inplace && make_backups && fnamecmp_type == FNAMECMP_FNAME) {
154 + if (inplace && GEN_make_backups && fnamecmp_type == FNAMECMP_FNAME) {
155 if (!(backupptr = get_backup_name(fname))) {
158 @@ -1470,9 +1474,12 @@ void generate_files(int f_out, struct fi
159 int save_ignore_existing = ignore_existing;
160 int save_ignore_non_existing = ignore_non_existing;
161 int save_do_progress = do_progress;
162 - int save_make_backups = make_backups;
163 + int save_make_backups = GEN_make_backups = make_backups;
164 int dir_tweaking = !(list_only || local_name || dry_run);
166 + GEN_append_mode = append_mode;
167 + GEN_csum_length = csum_length;
169 if (protocol_version >= 29) {
171 maybe_ATTRS_REPORT = stdout_format_has_i ? 0 : ATTRS_REPORT;
172 @@ -1500,7 +1507,7 @@ void generate_files(int f_out, struct fi
173 do_delete_pass(flist);
176 - if (append_mode || whole_file < 0)
177 + if (GEN_append_mode || whole_file < 0)
180 rprintf(FINFO, "delta-transmission %s\n",
181 @@ -1509,12 +1516,6 @@ void generate_files(int f_out, struct fi
185 - /* Since we often fill up the outgoing socket and then just sit around
186 - * waiting for the other 2 processes to do their thing, we don't want
187 - * to exit on a timeout. If the data stops flowing, the receiver will
188 - * notice that and let us know via the redo pipe (or its closing). */
189 - ignore_timeout = 1;
191 for (i = 0; i < flist->count; i++) {
192 struct file_struct *file = flist->files[i];
194 @@ -1558,23 +1559,34 @@ void generate_files(int f_out, struct fi
195 delete_in_dir(NULL, NULL, NULL, NULL);
198 - csum_length = SUM_LENGTH;
199 + GEN_csum_length = SUM_LENGTH; /* csum_length is set by the receiver */
200 max_size = min_size = ignore_existing = ignore_non_existing = 0;
201 update_only = always_checksum = size_only = 0;
203 - if (append_mode) /* resend w/o append mode */
204 - append_mode = -1; /* ... but only longer files */
205 - make_backups = 0; /* avoid a duplicate backup for inplace processing */
206 + if (GEN_append_mode) /* resend w/o append mode */
207 + GEN_append_mode = -1; /* ... but only longer files */
208 + GEN_make_backups = 0; /* avoid a duplicate backup for inplace processing */
211 rprintf(FINFO,"generate_files phase=%d\n",phase);
213 write_int(f_out, -1);
214 + io_flush(NORMAL_FLUSH);
216 /* files can cycle through the system more than once
217 * to catch initial checksum errors */
218 - while ((i = get_redo_num(itemizing, code)) != -1) {
219 - struct file_struct *file = flist->files[i];
221 + struct file_struct *file;
222 + if (preserve_hard_links)
223 + check_for_finished_hlinks(itemizing, code);
224 + if ((i = get_redo_num()) < 0) {
227 + io_flush(NORMAL_FLUSH);
231 + file = flist->files[i];
233 strlcpy(fbuf, local_name, sizeof fbuf);
235 @@ -1586,27 +1598,43 @@ void generate_files(int f_out, struct fi
237 ignore_non_existing = save_ignore_non_existing;
238 ignore_existing = save_ignore_existing;
239 - make_backups = save_make_backups;
240 + GEN_make_backups = save_make_backups;
243 rprintf(FINFO,"generate_files phase=%d\n",phase);
245 write_int(f_out, -1);
246 + io_flush(NORMAL_FLUSH);
248 /* Reduce round-trip lag-time for a useless delay-updates phase. */
249 - if (protocol_version >= 29 && !delay_updates)
250 + if (protocol_version >= 29 && !delay_updates) {
251 write_int(f_out, -1);
252 + io_flush(NORMAL_FLUSH);
255 - /* Read MSG_DONE for the redo phase (and any prior messages). */
256 - get_redo_num(itemizing, code);
257 + /* Read end marker for the redo phase (and any prior messages). */
259 + if (preserve_hard_links)
260 + check_for_finished_hlinks(itemizing, code);
261 + if (get_redo_num() == -2)
263 + io_flush(NORMAL_FLUSH);
267 if (protocol_version >= 29) {
270 rprintf(FINFO, "generate_files phase=%d\n", phase);
272 + if (delay_updates) {
273 write_int(f_out, -1);
274 - /* Read MSG_DONE for delay-updates phase & prior messages. */
275 - get_redo_num(itemizing, code);
276 + io_flush(NORMAL_FLUSH);
278 + /* Read end marker for delay-updates phase & prior messages. */
279 + while (get_redo_num() != -2) {
280 + io_flush(NORMAL_FLUSH);
285 do_progress = save_do_progress;
288 @@ -40,20 +40,17 @@ extern int allowed_lull;
289 extern int am_server;
290 extern int am_daemon;
291 extern int am_sender;
292 -extern int am_generator;
293 extern int eol_nulls;
294 extern int read_batch;
295 extern int csum_length;
296 extern int checksum_seed;
297 extern int protocol_version;
298 -extern int remove_source_files;
299 extern int preserve_hard_links;
300 extern char *filesfrom_host;
301 extern struct stats stats;
302 extern struct file_list *the_file_list;
304 const char phase_unknown[] = "unknown";
305 -int ignore_timeout = 0;
307 int batch_gen_fd = -1;
309 @@ -61,7 +58,6 @@ int batch_gen_fd = -1;
310 int kluge_around_eof = 0;
313 -int msg_fd_out = -1;
317 @@ -88,27 +84,31 @@ static OFF_T active_bytecnt = 0;
318 static void read_loop(int fd, char *buf, size_t len);
320 struct flist_ndx_item {
321 - struct flist_ndx_item *next;
322 + volatile struct flist_ndx_item *next;
326 struct flist_ndx_list {
327 - struct flist_ndx_item *head, *tail;
328 + volatile struct flist_ndx_item *head, *tail;
329 + pthread_mutex_t mutex;
332 -static struct flist_ndx_list redo_list, hlink_list;
333 +static struct flist_ndx_list redo_list = { NULL, NULL, PTHREAD_MUTEX_INITIALIZER };
334 +static struct flist_ndx_list hlink_list = { NULL, NULL, PTHREAD_MUTEX_INITIALIZER };
336 struct msg_list_item {
337 - struct msg_list_item *next;
338 + volatile struct msg_list_item *next;
345 - struct msg_list_item *head, *tail;
346 + volatile struct msg_list_item *head, *tail;
347 + pthread_mutex_t mutex;
350 -static struct msg_list msg2genr, msg2sndr;
351 +static struct msg_list msg_list = { NULL, NULL, PTHREAD_MUTEX_INITIALIZER };
353 static void flist_ndx_push(struct flist_ndx_list *lp, int ndx)
355 @@ -118,27 +118,31 @@ static void flist_ndx_push(struct flist_
356 out_of_memory("flist_ndx_push");
359 + pthread_mutex_lock(&redo_list.mutex);
361 lp->tail->next = item;
365 + pthread_mutex_unlock(&redo_list.mutex);
368 static int flist_ndx_pop(struct flist_ndx_list *lp)
370 - struct flist_ndx_item *next;
371 + struct flist_ndx_item *head, *next;
377 - ndx = lp->head->ndx;
378 - next = lp->head->next;
382 + pthread_mutex_lock(&hlink_list.mutex);
383 + head = (struct flist_ndx_item *)lp->head;
384 + next = (struct flist_ndx_item *)head->next;
386 + if (!(lp->head = next))
388 + pthread_mutex_unlock(&hlink_list.mutex);
393 @@ -147,7 +151,7 @@ static void check_timeout(void)
397 - if (!io_timeout || ignore_timeout)
402 @@ -188,44 +192,38 @@ void set_io_timeout(int secs)
404 /* Setup the fd used to receive MSG_* messages. Only needed during the
405 * early stages of being a local sender (up through the sending of the
406 - * file list) or when we're the generator (to fetch the messages from
407 - * the receiver). */
409 void set_msg_fd_in(int fd)
414 -/* Setup the fd used to send our MSG_* messages. Only needed when
415 - * we're the receiver (to send our messages to the generator). */
416 -void set_msg_fd_out(int fd)
419 - set_nonblocking(msg_fd_out);
422 /* Add a message to the pending MSG_* list. */
423 -static void msg_list_add(struct msg_list *lst, int code, char *buf, int len)
424 +static void msg_list_add(int code, char *buf, int len)
426 struct msg_list_item *m;
427 - int sz = len + 4 + sizeof m[0] - 1;
428 + int sz = len + sizeof m[0] - 1;
430 + assert(am_receiver());
431 if (!(m = (struct msg_list_item *)new_array(char, sz)))
432 out_of_memory("msg_list_add");
435 - SIVAL(m->buf, 0, ((code+MPLEX_BASE)<<24) | len);
436 - memcpy(m->buf + 4, buf, len);
438 - lst->tail->next = m;
441 + memcpy(m->buf, buf, len);
443 + pthread_mutex_lock(&msg_list.mutex);
445 + msg_list.tail->next = m;
451 + pthread_mutex_unlock(&msg_list.mutex);
454 -/* Read a message from the MSG_* fd and handle it. This is called either
455 +/* Read a message from the MSG_* fd and handle it. This is only called
456 * during the early stages of being a local sender (up through the sending
457 - * of the file list) or when we're the generator (to fetch the messages
458 - * from the receiver). */
459 + * of the file list). */
460 static void read_msg_fd(void)
463 @@ -244,51 +242,6 @@ static void read_msg_fd(void)
464 tag = (tag >> 24) - MPLEX_BASE;
468 - if (len != 0 || !am_generator) {
469 - rprintf(FERROR, "invalid message %d:%d\n", tag, len);
470 - exit_cleanup(RERR_STREAMIO);
472 - flist_ndx_push(&redo_list, -1);
475 - if (len != 4 || !am_generator) {
476 - rprintf(FERROR, "invalid message %d:%d\n", tag, len);
477 - exit_cleanup(RERR_STREAMIO);
479 - read_loop(fd, buf, 4);
480 - if (remove_source_files)
481 - decrement_active_files(IVAL(buf,0));
482 - flist_ndx_push(&redo_list, IVAL(buf,0));
485 - if (len >= (int)sizeof buf || !am_generator) {
486 - rprintf(FERROR, "invalid message %d:%d\n", tag, len);
487 - exit_cleanup(RERR_STREAMIO);
489 - read_loop(fd, buf, len);
490 - send_msg(MSG_DELETED, buf, len);
493 - if (len != 4 || !am_generator) {
494 - rprintf(FERROR, "invalid message %d:%d\n", tag, len);
495 - exit_cleanup(RERR_STREAMIO);
497 - read_loop(fd, buf, len);
498 - if (remove_source_files) {
499 - decrement_active_files(IVAL(buf,0));
500 - send_msg(MSG_SUCCESS, buf, len);
502 - if (preserve_hard_links)
503 - flist_ndx_push(&hlink_list, IVAL(buf,0));
506 - if (!am_generator) {
507 - rprintf(FERROR, "invalid message %d:%d\n", tag, len);
508 - exit_cleanup(RERR_STREAMIO);
510 - close_multiplexing_out();
515 @@ -332,75 +285,80 @@ void decrement_active_files(int ndx)
516 active_bytecnt -= the_file_list->files[ndx]->length;
519 -/* Try to push messages off the list onto the wire. If we leave with more
520 +/* Try to pop messages off the list onto the wire. If we leave with more
521 * to do, return 0. On error, return -1. If everything flushed, return 1.
522 - * This is only active in the receiver. */
523 -static int msg2genr_flush(int flush_it_all)
524 + * This is only called by the generator. */
525 +static void msg_list_flush(void)
527 - static int written = 0;
530 + assert(am_generator());
532 - if (msg_fd_out < 0)
534 + if (defer_forwarding_messages)
537 - while (msg2genr.head) {
538 - struct msg_list_item *m = msg2genr.head;
539 - int n = write(msg_fd_out, m->buf + written, m->len - written);
541 - if (errno == EINTR)
543 - if (errno != EWOULDBLOCK && errno != EAGAIN)
548 - FD_SET(msg_fd_out, &fds);
549 - tv.tv_sec = select_timeout;
551 - if (!select(msg_fd_out+1, NULL, &fds, NULL, &tv))
553 - } else if ((written += n) == m->len) {
554 - msg2genr.head = m->next;
555 - if (!msg2genr.head)
556 - msg2genr.tail = NULL;
560 + defer_forwarding_messages = 1;
561 + while (msg_list.head) {
562 + struct msg_list_item *m = (struct msg_list_item *)msg_list.head;
563 + pthread_mutex_lock(&msg_list.mutex);
564 + if (!(msg_list.head = m->next))
565 + msg_list.tail = NULL;
566 + pthread_mutex_unlock(&msg_list.mutex);
569 + close_multiplexing_out();
574 + rwrite(m->code, m->buf, m->len);
577 + io_multiplex_write(m->code, m->buf, m->len);
583 + defer_forwarding_messages = 0;
587 int send_msg(enum msgcode code, char *buf, int len)
589 - if (msg_fd_out < 0) {
590 + if (!am_receiver()) {
591 if (!defer_forwarding_messages)
592 return io_multiplex_write(code, buf, len);
593 if (!io_multiplexing_out)
595 - msg_list_add(&msg2sndr, code, buf, len);
598 - msg_list_add(&msg2genr, code, buf, len);
599 - msg2genr_flush(NORMAL_FLUSH);
600 + msg_list_add(code, buf, len);
604 -int get_redo_num(int itemizing, enum logcode code)
605 +/* This is only used by the receiver. */
606 +void push_redo_num(int ndx)
609 - if (hlink_list.head)
610 - check_for_finished_hlinks(itemizing, code);
611 - if (redo_list.head)
615 + assert(am_receiver());
616 + flist_ndx_push(&redo_list, ndx);
619 +/* This is only used by the generator. */
620 +int get_redo_num(void)
622 + assert(am_generator());
623 return flist_ndx_pop(&redo_list);
626 +/* This is only used by the receiver. */
627 +void push_hlink_num(int ndx)
629 + assert(am_receiver());
630 + flist_ndx_push(&hlink_list, ndx);
633 +/* This is only used by the generator. */
634 int get_hlink_num(void)
636 + assert(am_generator());
637 return flist_ndx_pop(&hlink_list);
640 @@ -480,11 +438,6 @@ static int read_timeout(int fd, char *bu
644 - if (msg2genr.head) {
645 - FD_SET(msg_fd_out, &w_fds);
646 - if (msg_fd_out > maxfd)
647 - maxfd = msg_fd_out;
649 if (io_filesfrom_f_out >= 0) {
651 if (io_filesfrom_buflen == 0) {
652 @@ -517,9 +470,6 @@ static int read_timeout(int fd, char *bu
656 - if (msg2genr.head && FD_ISSET(msg_fd_out, &w_fds))
657 - msg2genr_flush(NORMAL_FLUSH);
659 if (io_filesfrom_f_out >= 0) {
660 if (io_filesfrom_buflen) {
661 if (FD_ISSET(io_filesfrom_f_out, &w_fds)) {
662 @@ -847,6 +797,8 @@ static void readfd(int fd, char *buffer,
665 if (fd == write_batch_monitor_in) {
666 + if (am_generator())
667 + rprintf(FINFO, "writing %d bytes to batch file from generator\n", total);
668 if ((size_t)write(batch_fd, buffer, total) != total)
669 exit_cleanup(RERR_FILEIO);
671 @@ -1115,7 +1067,6 @@ static void writefd_unbuffered(int fd,ch
672 * to grab any messages they sent before they died. */
673 while (fd == sock_f_out && io_multiplexing_in) {
675 - ignore_timeout = 0;
676 readfd_unbuffered(sock_f_in, io_filesfrom_buf,
677 sizeof io_filesfrom_buf);
679 @@ -1126,7 +1077,7 @@ static void writefd_unbuffered(int fd,ch
680 defer_forwarding_messages = 1;
682 if (fd == sock_f_out) {
683 - if (io_timeout || am_generator)
684 + if (io_timeout || am_generator())
685 last_io_out = time(NULL);
686 sleep_for_bwlimit(cnt);
688 @@ -1136,23 +1087,6 @@ static void writefd_unbuffered(int fd,ch
692 -static void msg2sndr_flush(void)
694 - if (defer_forwarding_messages)
697 - while (msg2sndr.head && io_multiplexing_out) {
698 - struct msg_list_item *m = msg2sndr.head;
699 - if (!(msg2sndr.head = m->next))
700 - msg2sndr.tail = NULL;
701 - stats.total_written += m->len;
702 - defer_forwarding_messages = 1;
703 - writefd_unbuffered(sock_f_out, m->buf, m->len);
704 - defer_forwarding_messages = 0;
710 * Write an message to a multiplexed stream. If this fails then rsync
712 @@ -1178,14 +1112,15 @@ static void mplex_write(enum msgcode cod
713 defer_forwarding_messages = 1;
714 writefd_unbuffered(sock_f_out, buf, len);
715 defer_forwarding_messages = 0;
717 + if (am_generator())
722 -void io_flush(int flush_it_all)
723 +void io_flush(UNUSED(int flush_it_all))
725 - msg2genr_flush(flush_it_all);
727 + if (am_generator())
730 if (!iobuf_out_cnt || no_flush)
732 @@ -1199,11 +1134,6 @@ void io_flush(int flush_it_all)
734 static void writefd(int fd,char *buf,size_t len)
736 - if (fd == msg_fd_out) {
737 - rprintf(FERROR, "Internal error: wrong write used in receiver.\n");
738 - exit_cleanup(RERR_PROTOCOL);
741 if (fd == sock_f_out)
742 stats.total_written += len;
744 @@ -1409,9 +1339,3 @@ void start_write_batch(int fd)
746 write_batch_monitor_in = fd;
749 -void stop_write_batch(void)
751 - write_batch_monitor_out = -1;
752 - write_batch_monitor_in = -1;
756 @@ -33,7 +33,6 @@ extern int am_sender;
757 extern int local_server;
759 extern int module_id;
760 -extern int msg_fd_out;
761 extern int allow_8bit_chars;
762 extern int protocol_version;
763 extern int preserve_times;
764 @@ -75,7 +74,6 @@ struct {
765 { RERR_IPC , "error in IPC code" },
766 { RERR_CRASHED , "sibling process crashed" },
767 { RERR_TERMINATED , "sibling process terminated abnormally" },
768 - { RERR_SIGNAL1 , "received SIGUSR1" },
769 { RERR_SIGNAL , "received SIGINT, SIGTERM, or SIGHUP" },
770 { RERR_WAITCHILD , "waitpid() failed" },
771 { RERR_MALLOC , "error allocating core memory buffers" },
772 @@ -241,8 +239,8 @@ void rwrite(enum logcode code, char *buf
774 exit_cleanup(RERR_MESSAGEIO);
776 - if (am_server && msg_fd_out >= 0) {
777 - /* Pass the message to our sibling. */
778 + if (am_receiver()) {
779 + /* Pass the message to the generator thread. */
780 send_msg((enum msgcode)code, buf, len);
785 @@ -32,7 +32,6 @@ extern int list_only;
787 extern int am_server;
788 extern int am_sender;
789 -extern int am_generator;
790 extern int am_daemon;
791 extern int blocking_io;
792 extern int remove_source_files;
793 @@ -96,9 +95,20 @@ struct pid_status {
795 static time_t starttime, endtime;
796 static int64 total_read, total_written;
797 +static pthread_t receiver_tid;
799 static void show_malloc_stats(void);
803 + return receiver_tid != 0 && pthread_self() != receiver_tid;
808 + return receiver_tid != 0 && pthread_self() == receiver_tid;
811 /* Works like waitpid(), but if we already harvested the child pid in our
812 * remember_children(), we succeed instead of returning an error. */
813 pid_t wait_process(pid_t pid, int *status_ptr, int flags)
814 @@ -175,7 +185,7 @@ static void handle_stats(int f)
819 + if (am_generator())
823 @@ -683,12 +693,30 @@ static void do_server_sender(int f_in, i
827 +struct thread_args {
828 + struct file_list *flist;
833 +static void *start_receiver_thread(void *arg)
835 + static int exit_code;
836 + struct thread_args *ta = (struct thread_args *)arg;
838 + recv_files(ta->f_in, ta->flist, ta->local_name);
839 + handle_stats(ta->f_in);
843 + exit_code = log_got_error ? RERR_PARTIAL : 0;
847 static int do_recv(int f_in,int f_out,struct file_list *flist,char *local_name)
853 + struct thread_args args;
855 /* The receiving side mustn't obey this, or an existing symlink that
856 * points to an identical file won't be replaced by the referent. */
857 @@ -697,70 +725,16 @@ static int do_recv(int f_in,int f_out,st
858 if (preserve_hard_links)
861 - if (fd_pair(error_pipe) < 0) {
862 - rsyserr(FERROR, errno, "pipe failed in do_recv");
863 - exit_cleanup(RERR_IPC);
866 - io_flush(NORMAL_FLUSH);
868 - if ((pid = do_fork()) == -1) {
869 - rsyserr(FERROR, errno, "fork failed in do_recv");
871 + args.flist = flist;
872 + args.local_name = local_name;
873 + if (pthread_create(&receiver_tid, NULL, start_receiver_thread, &args) < 0) {
874 + rsyserr(FERROR, errno, "pthread_create failed in do_recv");
875 exit_cleanup(RERR_IPC);
879 - close(error_pipe[0]);
883 - /* we can't let two processes write to the socket at one time */
884 - close_multiplexing_out();
886 - /* set place to send errors */
887 - set_msg_fd_out(error_pipe[1]);
889 - recv_files(f_in, flist, local_name);
890 - io_flush(FULL_FLUSH);
891 - handle_stats(f_in);
893 - send_msg(MSG_DONE, "", 0);
894 - io_flush(FULL_FLUSH);
896 - /* Handle any keep-alive packets from the post-processing work
897 - * that the generator does. */
898 - if (protocol_version >= 29) {
899 - kluge_around_eof = -1;
901 - /* This should only get stopped via a USR2 signal. */
902 - while (read_int(f_in) == flist->count
903 - && read_shortint(f_in) == ITEM_IS_NEW) {}
905 - rprintf(FERROR, "Invalid packet at end of run [%s]\n",
907 - exit_cleanup(RERR_PROTOCOL);
910 - /* Finally, we go to sleep until our parent kills us with a
911 - * USR2 signal. We sleep for a short time, as on some OSes
912 - * a signal won't interrupt a sleep! */
918 - close_multiplexing_in();
919 - if (write_batch && !am_server)
920 - stop_write_batch();
922 - close(error_pipe[1]);
926 io_start_buffering_out();
928 - set_msg_fd_in(error_pipe[0]);
930 generate_files(f_out, flist, local_name);
933 @@ -771,10 +745,13 @@ static int do_recv(int f_in,int f_out,st
935 io_flush(FULL_FLUSH);
938 - kill(pid, SIGUSR2);
939 - wait_process_with_flush(pid, &exit_code);
941 + pthread_join(receiver_tid, &value_ptr);
947 + return *(int*)value_ptr;
951 @@ -1176,22 +1153,6 @@ static int start_client(int argc, char *
956 -static RETSIGTYPE sigusr1_handler(UNUSED(int val))
958 - exit_cleanup(RERR_SIGNAL1);
961 -static RETSIGTYPE sigusr2_handler(UNUSED(int val))
967 - _exit(RERR_PARTIAL);
971 RETSIGTYPE remember_children(UNUSED(int val))
974 @@ -1283,8 +1244,6 @@ int main(int argc,char *argv[])
976 sigact.sa_flags = SA_NOCLDSTOP;
978 - SIGACTMASK(SIGUSR1, sigusr1_handler);
979 - SIGACTMASK(SIGUSR2, sigusr2_handler);
980 SIGACTMASK(SIGCHLD, remember_children);
981 #ifdef MAINTAINER_MODE
982 SIGACTMASK(SIGSEGV, rsync_panic_handler);
989 -extern int do_progress;
990 +extern int recv_progress;
991 extern int checksum_seed;
992 extern int append_mode;
994 @@ -113,7 +113,7 @@ static void matched(int f, struct sum_st
998 - if (buf && do_progress)
999 + if (buf && recv_progress)
1000 show_progress(last_match, buf->file_size);
1003 @@ -317,7 +317,7 @@ void match_sums(int f, struct sum_struct
1006 for (j = CHUNK_SIZE; j < s->flength; j += CHUNK_SIZE) {
1007 - if (buf && do_progress)
1008 + if (buf && recv_progress)
1009 show_progress(last_match, buf->file_size);
1010 sum_update(map_ptr(buf, last_match, CHUNK_SIZE),
1012 @@ -325,7 +325,7 @@ void match_sums(int f, struct sum_struct
1014 if (last_match < s->flength) {
1015 int32 len = s->flength - last_match;
1016 - if (buf && do_progress)
1017 + if (buf && recv_progress)
1018 show_progress(last_match, buf->file_size);
1019 sum_update(map_ptr(buf, last_match, len), len);
1020 last_match = s->flength;
1023 @@ -74,7 +74,6 @@ int def_compress_level = Z_DEFAULT_COMPR
1027 -int am_generator = 0;
1028 int am_starting_up = 1;
1029 int relative_paths = -1;
1030 int implied_dirs = 1;
1031 @@ -95,6 +94,7 @@ int am_daemon = 0;
1032 int daemon_over_rsh = 0;
1034 int do_progress = 0;
1035 +int recv_progress = 0;
1036 int keep_partial = 0;
1037 int safe_symlinks = 0;
1038 int copy_unsafe_links = 0;
1039 @@ -1306,6 +1306,7 @@ int parse_arguments(int *argc, const cha
1041 if (do_progress && !verbose && !log_before_transfer && !am_server)
1043 + recv_progress = do_progress;
1049 @@ -59,7 +59,7 @@ pid_t piped_child(char **command, int *f
1050 exit_cleanup(RERR_IPC);
1056 rsyserr(FERROR, errno, "fork");
1057 exit_cleanup(RERR_IPC);
1058 @@ -123,7 +123,7 @@ pid_t local_child(int argc, char **argv,
1059 exit_cleanup(RERR_IPC);
1065 rsyserr(FERROR, errno, "fork");
1066 exit_cleanup(RERR_IPC);
1071 extern int do_xfers;
1072 extern int am_server;
1073 -extern int do_progress;
1074 +extern int recv_progress;
1075 extern int log_before_transfer;
1076 extern int stdout_format_has_i;
1077 extern int logfile_format_has_i;
1078 @@ -157,7 +157,7 @@ static int receive_data(int f_in, char *
1080 sum.flength -= sum.blength - sum.remainder;
1081 for (j = CHUNK_SIZE; j < sum.flength; j += CHUNK_SIZE) {
1083 + if (recv_progress)
1084 show_progress(offset, total_size);
1085 sum_update(map_ptr(mapbuf, offset, CHUNK_SIZE),
1087 @@ -165,7 +165,7 @@ static int receive_data(int f_in, char *
1089 if (offset < sum.flength) {
1090 int32 len = sum.flength - offset;
1092 + if (recv_progress)
1093 show_progress(offset, total_size);
1094 sum_update(map_ptr(mapbuf, offset, len), len);
1095 offset = sum.flength;
1096 @@ -178,7 +178,7 @@ static int receive_data(int f_in, char *
1099 while ((i = recv_token(f_in, &data)) != 0) {
1101 + if (recv_progress)
1102 show_progress(offset, total_size);
1105 @@ -248,7 +248,7 @@ static int receive_data(int f_in, char *
1106 ftruncate(fd, offset);
1110 + if (recv_progress)
1111 end_progress(total_size);
1113 if (fd != -1 && offset > 0 && sparse_end(fd) != 0) {
1114 @@ -299,12 +299,12 @@ static void handle_delayed_updates(struc
1115 "rename failed for %s (from %s)",
1116 full_fname(fname), partialptr);
1118 - if (remove_source_files
1119 - || (preserve_hard_links
1120 - && file->link_u.links)) {
1121 + if (remove_source_files) {
1122 SIVAL(numbuf, 0, i);
1123 send_msg(MSG_SUCCESS,numbuf,4);
1125 + if (preserve_hard_links && file->link_u.links)
1126 + push_hlink_num(i);
1127 handle_partial_dir(partialptr, PDIR_DELETE);
1130 @@ -355,11 +355,6 @@ int recv_files(int f_in, struct file_lis
1132 rprintf(FINFO,"recv_files(%d) starting\n",flist->count);
1134 - if (flist->hlink_pool) {
1135 - pool_destroy(flist->hlink_pool);
1136 - flist->hlink_pool = NULL;
1140 delayed_bits = bitbag_create(flist->count);
1142 @@ -382,7 +377,7 @@ int recv_files(int f_in, struct file_lis
1143 rprintf(FINFO, "recv_files phase=%d\n", phase);
1144 if (phase == 2 && delay_updates)
1145 handle_delayed_updates(flist, local_name);
1146 - send_msg(MSG_DONE, "", 0);
1147 + push_redo_num(-2);
1148 if (keep_partial && !partial_dir)
1149 make_backups = 0; /* prevents double backup */
1151 @@ -607,7 +602,7 @@ int recv_files(int f_in, struct file_lis
1152 /* log the transfer */
1153 if (log_before_transfer)
1154 log_item(FCLIENT, file, &initial_stats, iflags, NULL);
1155 - else if (!am_server && verbose && do_progress)
1156 + else if (!am_server && verbose && recv_progress)
1157 rprintf(FINFO, "%s\n", fname);
1159 /* recv file data */
1160 @@ -654,11 +649,13 @@ int recv_files(int f_in, struct file_lis
1164 - if (remove_source_files
1165 - || (preserve_hard_links && file->link_u.links)) {
1166 + if (remove_source_files) {
1167 + decrement_active_files(i);
1168 SIVAL(numbuf, 0, i);
1169 send_msg(MSG_SUCCESS, numbuf, 4);
1171 + if (preserve_hard_links && file->link_u.links)
1172 + push_hlink_num(i);
1173 } else if (!recv_ok) {
1174 int msgtype = phase || read_batch ? FERROR : FINFO;
1175 if (msgtype == FERROR || verbose) {
1176 @@ -681,8 +678,8 @@ int recv_files(int f_in, struct file_lis
1177 errstr, fname, keptstr, redostr);
1180 - SIVAL(numbuf, 0, i);
1181 - send_msg(MSG_REDO, numbuf, 4);
1182 + decrement_active_files(i);
1189 @@ -39,7 +39,6 @@ extern int omit_dir_times;
1191 extern int am_server;
1192 extern int am_sender;
1193 -extern int am_generator;
1194 extern int am_starting_up;
1195 extern int allow_8bit_chars;
1196 extern int preserve_uid;
1197 @@ -305,5 +304,5 @@ const char *who_am_i(void)
1200 return am_server ? "server" : "client";
1201 - return am_sender ? "sender" : am_generator ? "generator" : "receiver";
1202 + return am_sender ? "sender" : am_generator() ? "generator" : "receiver";
1206 @@ -170,10 +170,8 @@ enum msgcode {
1207 MSG_DATA=0, /* raw data on the multiplexed stream */
1208 MSG_ERROR=FERROR, MSG_INFO=FINFO, /* remote logging */
1209 MSG_LOG=FLOG, MSG_SOCKERR=FSOCKERR, /* sibling logging */
1210 - MSG_REDO=9, /* reprocess indicated flist index */
1211 MSG_SUCCESS=100,/* successfully updated indicated flist index */
1212 MSG_DELETED=101,/* successfully deleted a file on receiving side */
1213 - MSG_DONE=86 /* current phase is done */
1216 #include "errcode.h"
1217 @@ -330,6 +328,7 @@ enum msgcode {
1221 +#include <pthread.h>
1223 #include "lib/pool_alloc.h"
1227 @@ -415,49 +415,6 @@ int robust_rename(char *from, char *to,
1231 -static pid_t all_pids[10];
1232 -static int num_pids;
1234 -/** Fork and record the pid of the child. **/
1235 -pid_t do_fork(void)
1237 - pid_t newpid = fork();
1239 - if (newpid != 0 && newpid != -1) {
1240 - all_pids[num_pids++] = newpid;
1246 - * Kill all children.
1248 - * @todo It would be kind of nice to make sure that they are actually
1249 - * all our children before we kill them, because their pids may have
1250 - * been recycled by some other process. Perhaps when we wait for a
1251 - * child, we should remove it from this array. Alternatively we could
1252 - * perhaps use process groups, but I think that would not work on
1253 - * ancient Unix versions that don't support them.
1255 -void kill_all(int sig)
1259 - for (i = 0; i < num_pids; i++) {
1260 - /* Let's just be a little careful where we
1261 - * point that gun, hey? See kill(2) for the
1262 - * magic caused by negative values. */
1263 - pid_t p = all_pids[i];
1265 - if (p == getpid())
1274 /** Turn a user name into a uid */
1275 int name_to_uid(char *name, uid_t *uid)