1 Depends-On-Patch: acls.diff
2 Depends-On-Patch: xattrs.diff
4 This patch adds a new option: --fake-super, which tells rsync to copy in a
5 fake super-user mode that stores various file attributes in an extended-
6 attribute value instead of as real file-system attributes. The items
9 mode the real mode of a file is always (666 & umask) while
10 the real mode of a directory is always (777 & umask).
12 rdev devices and special files are created as zero-length
15 uid the real owner is always left unchanged.
17 gid the real group is always left unchanged.
19 A daemon can set "fake super = yes" in the rsync.conf file for any module
20 that you'd like to run without root perms while pretending it has them (the
21 client cannot affect this).
23 The --fake-super option only affects the side where the option is used. To
24 affect the remote side of a remote-shell connection, specify an rsync path:
26 rsync -av --rsync-path='rsync --fake-super' /src/ host:/dest/
28 For a local copy where you want to affect only one side or the other,
29 you'll need to turn the copy into a remote copy to localhost.
31 After applying this patch, run these commands for a successful build:
39 @@ -41,7 +41,7 @@ popt_OBJS=popt/findme.o popt/popt.o po
40 popt/popthelp.o popt/poptparse.o
41 OBJS=$(OBJS1) $(OBJS2) $(OBJS3) $(DAEMON_OBJ) $(LIBOBJ) $(ZLIBOBJ) @BUILD_POPT@
43 -TLS_OBJ = tls.o syscall.o lib/compat.o lib/snprintf.o lib/permstring.o
44 +TLS_OBJ = tls.o syscall.o lib/compat.o lib/snprintf.o lib/permstring.o lib/sysxattr.o
46 # Programs we must have to run the test cases
47 CHECK_PROGS = rsync$(EXEEXT) tls$(EXEEXT) getgroups$(EXEEXT) getfsdev$(EXEEXT) \
48 @@ -83,11 +83,11 @@ getgroups$(EXEEXT): getgroups.o
49 getfsdev$(EXEEXT): getfsdev.o
50 $(CC) $(CFLAGS) $(LDFLAGS) -o $@ getfsdev.o $(LIBS)
52 -TRIMSLASH_OBJ = trimslash.o syscall.o lib/compat.o lib/snprintf.o
53 +TRIMSLASH_OBJ = trimslash.o syscall.o lib/compat.o lib/snprintf.o lib/sysxattr.o
54 trimslash$(EXEEXT): $(TRIMSLASH_OBJ)
55 $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(TRIMSLASH_OBJ) $(LIBS)
57 -T_UNSAFE_OBJ = t_unsafe.o syscall.o util.o t_stub.o lib/compat.o lib/snprintf.o
58 +T_UNSAFE_OBJ = t_unsafe.o syscall.o util.o t_stub.o lib/compat.o lib/snprintf.o lib/sysxattr.o
59 t_unsafe$(EXEEXT): $(T_UNSAFE_OBJ)
60 $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $(T_UNSAFE_OBJ) $(LIBS)
62 --- old/clientserver.c
63 +++ new/clientserver.c
64 @@ -625,6 +625,11 @@ static int rsync_module(int f_in, int f_
65 ret = parse_arguments(&argc, (const char ***) &argv, 0);
66 quiet = 0; /* Don't let someone try to be tricky. */
68 + if (lp_fake_super(i))
70 + else if (am_root < 0) /* Treat --fake-super from client as --super. */
73 if (filesfrom_fd == 0)
78 @@ -1510,13 +1510,14 @@ void generate_files(int f_out, struct fi
79 recv_generator(fbuf, file, i, itemizing, maybe_ATTRS_REPORT,
82 - /* We need to ensure that any dirs we create have writeable
83 + /* We need to ensure that any dirs we create have rwx
84 * permissions during the time we are putting files within
85 * them. This is then fixed after the transfer is done. */
87 - if (!am_root && S_ISDIR(file->mode) && !(file->mode & S_IWUSR)
88 + if (am_root <= 0 && S_ISDIR(file->mode)
89 + && (file->mode & S_IRWXU) != S_IRWXU
91 - mode_t mode = file->mode | S_IWUSR; /* user write */
92 + mode_t mode = file->mode | S_IRWXU; /* user rwx */
93 char *fname = local_name ? local_name : fbuf;
94 if (do_chmod(fname, mode) < 0) {
95 rsyserr(FERROR, errno,
98 @@ -150,6 +150,7 @@ typedef struct
104 BOOL ignore_nonreadable;
106 @@ -197,6 +198,7 @@ static service sDefault =
107 /* syslog_facility; */ LOG_DAEMON,
110 + /* fake_super; */ False,
111 /* ignore_errors; */ False,
112 /* ignore_nonreadable; */ False,
114 @@ -298,6 +300,7 @@ static struct parm_struct parm_table[] =
115 {"dont compress", P_STRING, P_LOCAL, &sDefault.dont_compress, NULL,0},
116 {"exclude from", P_STRING, P_LOCAL, &sDefault.exclude_from, NULL,0},
117 {"exclude", P_STRING, P_LOCAL, &sDefault.exclude, NULL,0},
118 + {"fake super", P_BOOL, P_LOCAL, &sDefault.fake_super, NULL,0},
119 {"filter", P_STRING, P_LOCAL, &sDefault.filter, NULL,0},
120 {"gid", P_STRING, P_LOCAL, &sDefault.gid, NULL,0},
121 {"hosts allow", P_STRING, P_LOCAL, &sDefault.hosts_allow, NULL,0},
122 @@ -412,6 +415,7 @@ FN_LOCAL_INTEGER(lp_max_connections, max
123 FN_LOCAL_INTEGER(lp_max_verbosity, max_verbosity)
124 FN_LOCAL_INTEGER(lp_timeout, timeout)
126 +FN_LOCAL_BOOL(lp_fake_super, fake_super)
127 FN_LOCAL_BOOL(lp_ignore_errors, ignore_errors)
128 FN_LOCAL_BOOL(lp_ignore_nonreadable, ignore_nonreadable)
129 FN_LOCAL_BOOL(lp_list, list)
130 @@ -816,7 +820,7 @@ BOOL lp_load(char *pszFname, int globals
133 pstrcpy(n2,pszFname);
134 - else if (am_server && !am_root)
135 + else if (am_server && am_root <= 0)
136 pstrcpy(n2,RSYNCD_USERCONF);
138 pstrcpy(n2,RSYNCD_SYSCONF);
141 @@ -73,7 +73,7 @@ int protocol_version = PROTOCOL_VERSION;
142 int sparse_files = 0;
143 int do_compression = 0;
144 int def_compress_level = Z_DEFAULT_COMPRESSION;
146 +int am_root = 0; /* 0 = normal, 1 = super, 2 = --super, -1 = --fake-super */
149 int am_generator = 0;
150 @@ -330,6 +330,7 @@ void usage(enum logcode F)
151 rprintf(F," -t, --times preserve times\n");
152 rprintf(F," -O, --omit-dir-times omit directories when preserving times\n");
153 rprintf(F," --super receiver attempts super-user activities\n");
154 + rprintf(F," --fake-super fake root by storing/reading ownership/etc in EAs\n");
155 rprintf(F," -S, --sparse handle sparse files efficiently\n");
156 rprintf(F," -n, --dry-run show what would have been transferred\n");
157 rprintf(F," -W, --whole-file copy files whole (without rsync algorithm)\n");
158 @@ -454,6 +455,7 @@ static struct poptOption long_options[]
159 {"modify-window", 0, POPT_ARG_INT, &modify_window, OPT_MODIFY_WINDOW, 0, 0 },
160 {"super", 0, POPT_ARG_VAL, &am_root, 2, 0, 0 },
161 {"no-super", 0, POPT_ARG_VAL, &am_root, 0, 0, 0 },
162 + {"fake-super", 0, POPT_ARG_VAL, &am_root, -1, 0, 0 },
163 {"owner", 'o', POPT_ARG_VAL, &preserve_uid, 1, 0, 0 },
164 {"no-owner", 0, POPT_ARG_VAL, &preserve_uid, 0, 0, 0 },
165 {"no-o", 0, POPT_ARG_VAL, &preserve_uid, 0, 0, 0 },
168 @@ -197,6 +197,12 @@ int set_file_attrs(char *fname, struct f
169 (long)sxp->st.st_gid, (long)file->gid);
174 + sxp->st.st_uid = file->uid;
176 + sxp->st.st_gid = file->gid;
179 change_uid ? file->uid : sxp->st.st_uid,
180 change_gid ? file->gid : sxp->st.st_gid) != 0) {
181 @@ -206,7 +212,7 @@ int set_file_attrs(char *fname, struct f
182 change_uid ? "chown" : "chgrp",
187 /* a lchown had been done - we have to re-stat if the
188 * destination had the setuid or setgid bits set due
189 * to the side effect of the chown call */
190 @@ -237,7 +243,16 @@ int set_file_attrs(char *fname, struct f
193 if ((sxp->st.st_mode & CHMOD_BITS) != (new_mode & CHMOD_BITS)) {
194 - int ret = do_chmod(fname, new_mode);
197 + mode_t mode = 0666 & ~orig_umask;
198 + if ((sxp->st.st_mode & CHMOD_BITS) != mode)
199 + ret = do_chmod(fname, mode);
202 + sxp->st.st_mode = new_mode;
204 + ret = do_chmod(fname, new_mode);
206 rsyserr(FERROR, errno,
207 "failed to set permissions on %s",
208 @@ -249,6 +264,22 @@ int set_file_attrs(char *fname, struct f
213 + int write_it = updated;
214 + if (IS_DEVICE(file->mode) || IS_SPECIAL(file->mode)) {
215 + if (file->u.rdev != sxp->st.st_rdev) {
216 + sxp->st.st_rdev = file->u.rdev;
220 + sxp->st.st_rdev = 0;
221 + if (write_it && set_stat_xattr(fname, &sxp->st) < 0) {
222 + rsyserr(FERROR, errno,
223 + "write of stat xattr failed for %s",
224 + full_fname(fname));
228 if (verbose > 1 && flags & ATTRS_REPORT) {
230 rprintf(FCLIENT, "%s\n", fname);
235 #define BACKUP_SUFFIX "~"
237 +#define FAKE_XATTR "user.fake%stat"
239 /* a non-zero CHAR_OFFSET makes the rolling sum stronger, but is
240 incompatible with older versions :-( */
241 #define CHAR_OFFSET 0
248 +#include "lib/sysxattr.h"
250 #if !defined MKNOD_CREATES_SOCKETS && defined HAVE_SYS_UN_H
256 extern int read_only;
257 extern int list_only;
258 extern int preserve_perms;
259 @@ -79,6 +81,15 @@ int do_mknod(char *pathname, mode_t mode
261 if (dry_run) return 0;
262 RETURN_ERROR_IF_RO_OR_LO;
264 + /* For --fake-super, we create a normal file with mode 0600. */
266 + int fd = open(pathname, O_WRONLY|O_CREAT|O_TRUNC, S_IWUSR|S_IRUSR);
267 + if (fd < 0 || close(fd) < 0)
272 #if !defined MKNOD_CREATES_FIFOS && defined HAVE_MKFIFO
274 return mkfifo(pathname, mode);
275 @@ -133,6 +144,7 @@ int do_open(const char *pathname, int fl
280 int do_chmod(const char *path, mode_t mode)
283 @@ -215,23 +227,69 @@ int do_mkstemp(char *template, mode_t pe
287 +int get_stat_xattr(const char *fname, STRUCT_STAT *st)
289 + int mode, rdev, uid, gid, len;
292 + len = sys_lgetxattr(fname, FAKE_XATTR, buf, sizeof buf - 1);
293 + if (len < 0 || len >= (int)sizeof buf) {
294 + if (errno == ENOTSUP || errno == ENOATTR)
300 + if (sscanf(buf, "%o %d %d:%d", &mode, &rdev, &uid, &gid) != 4) {
305 + st->st_mode = mode;
306 + st->st_rdev = rdev;
313 +int set_stat_xattr(const char *fname, STRUCT_STAT *st)
317 + if (dry_run) return 0;
318 + RETURN_ERROR_IF_RO_OR_LO;
319 + len = snprintf(buf, sizeof buf, "%o %d %d:%d",
320 + (int)st->st_mode, (int)st->st_rdev,
321 + (int)st->st_uid, (int)st->st_gid);
322 + return sys_lsetxattr(fname, FAKE_XATTR, buf, len, 0);
325 int do_stat(const char *fname, STRUCT_STAT *st)
328 #ifdef USE_STAT64_FUNCS
329 - return stat64(fname, st);
330 + ret = stat64(fname, st);
332 - return stat(fname, st);
333 + ret = stat(fname, st);
335 + if (am_root < 0 && ret == 0)
336 + get_stat_xattr(fname, st);
340 int do_lstat(const char *fname, STRUCT_STAT *st)
344 # ifdef USE_STAT64_FUNCS
345 - return lstat64(fname, st);
346 + ret = lstat64(fname, st);
348 - return lstat(fname, st);
349 + ret = lstat(fname, st);
351 + if (am_root < 0 && ret == 0)
352 + get_stat_xattr(fname, st);
355 return do_stat(fname, st);
363 -int dry_run, read_only, list_only, verbose;
369 int preserve_perms = 0;
376 /* These are to make syscall.o shut up. */
378 +int am_root = 0; /* TODO: add option to set this to -1. */
381 int preserve_perms = 0;
386 /* These are to make syscall.o shut up. */
391 int preserve_perms = 0;
395 #ifdef SUPPORT_XATTRS
399 extern unsigned int file_struct_len;
401 #define RSYNC_XAL_INITIAL 5
402 @@ -130,9 +131,15 @@ static int rsync_xal_get(const char *fna
405 for (left = name_size, name = namebuf; left > 0 ; left -= len, name += len) {
406 - rsync_xa *rxas = EXPAND_ITEM_LIST(xalp, rsync_xa, RSYNC_XAL_INITIAL);
409 len = strlen(name) + 1;
410 + if (am_root < 0 && len == sizeof FAKE_XATTR
411 + && name[9] == '%' && strcmp(name, FAKE_XATTR) == 0)
414 + rxas = EXPAND_ITEM_LIST(xalp, rsync_xa, RSYNC_XAL_INITIAL);
416 datum_size = sys_lgetxattr(fname, name, NULL, 0);
417 if (datum_size < 0) {
418 if (errno == ENOTSUP)
419 @@ -285,10 +292,19 @@ void receive_xattr(struct file_struct *f
420 out_of_memory("receive_xattr");
421 read_buf(f, ptr, name_len);
422 read_buf(f, ptr + name_len, datum_len);
424 + if (am_root < 0 && name_len == sizeof FAKE_XATTR
425 + && ptr[9] == '%' && strcmp(ptr, FAKE_XATTR) == 0) {
427 + temp_xattr.count--;
431 rxa->name_len = name_len;
432 rxa->datum_len = datum_len;
434 rxa->datum = ptr + name_len;
436 #ifdef HAVE_OSX_XATTRS
437 if (strncmp(rxa->name, unique_prefix, upre_len) == 0) {
438 rxa->name_len -= upre_len;