rsync/rsync.git
19 years agoTweaked a comment.
Wayne Davison [Sun, 20 Jun 2004 19:47:05 +0000 (19:47 +0000)]
Tweaked a comment.

19 years agoMust not call check_timeout() before checking the errno value.
Wayne Davison [Sat, 19 Jun 2004 07:09:57 +0000 (07:09 +0000)]
Must not call check_timeout() before checking the errno value.

19 years agoAdded some missing changes.
Wayne Davison [Sat, 19 Jun 2004 06:55:58 +0000 (06:55 +0000)]
Added some missing changes.

19 years agoSome minor improved sentences.
Wayne Davison [Sat, 19 Jun 2004 05:52:45 +0000 (05:52 +0000)]
Some minor improved sentences.

19 years agoTweaked some comments.
Wayne Davison [Fri, 18 Jun 2004 16:55:12 +0000 (16:55 +0000)]
Tweaked some comments.

19 years agoSome helpful comments from Chris Shoemaker.
Wayne Davison [Fri, 18 Jun 2004 16:50:20 +0000 (16:50 +0000)]
Some helpful comments from Chris Shoemaker.

19 years agoFixed some typos in a comment, moved an extern, and made a few
Wayne Davison [Fri, 18 Jun 2004 16:30:24 +0000 (16:30 +0000)]
Fixed some typos in a comment, moved an extern, and made a few
minor format tweaks.

19 years agoImproved a comment.
Wayne Davison [Fri, 18 Jun 2004 16:29:21 +0000 (16:29 +0000)]
Improved a comment.

19 years agoMoved the externs to the top and made a few trivial format tweaks.
Wayne Davison [Fri, 18 Jun 2004 16:22:14 +0000 (16:22 +0000)]
Moved the externs to the top and made a few trivial format tweaks.

19 years agoGot rid of some trailing whitespace.
Wayne Davison [Fri, 18 Jun 2004 16:00:33 +0000 (16:00 +0000)]
Got rid of some trailing whitespace.

19 years agoIf --partial was specified, make sure that make_backup is turned
Wayne Davison [Mon, 14 Jun 2004 15:09:36 +0000 (15:09 +0000)]
If --partial was specified, make sure that make_backup is turned
off during the second (retry) phase of the transfer to avoid
making a second backup of a file (which would lose the original).

19 years agoAdded a short msleep() after option_error() before we exit. This
Wayne Davison [Sun, 13 Jun 2004 14:18:48 +0000 (14:18 +0000)]
Added a short msleep() after option_error() before we exit.  This
ensures that the remote client has time to read our error message
while it is trying to write data to us before it gets a socket
error.

19 years agoChanged the new code in delete_one() so that some compilers
Wayne Davison [Sat, 12 Jun 2004 21:30:07 +0000 (21:30 +0000)]
Changed the new code in delete_one() so that some compilers
don't complain about returning a value from a void function.

19 years agoMention the bugfix in option-parsing error-reporting from a daemon.
Wayne Davison [Sat, 12 Jun 2004 18:27:04 +0000 (18:27 +0000)]
Mention the bugfix in option-parsing error-reporting from a daemon.

19 years ago- Changed some FERROR log calls to FLOG.
Wayne Davison [Sat, 12 Jun 2004 18:22:39 +0000 (18:22 +0000)]
- Changed some FERROR log calls to FLOG.
- Improved the option-error-reporting to actually get the error back
  to the user (by getting I/O multiplexing started).

19 years ago- Made readlink_stat() and link_stat() optionally follow a symlink
Wayne Davison [Fri, 11 Jun 2004 07:40:57 +0000 (07:40 +0000)]
- Made readlink_stat() and link_stat() optionally follow a symlink
  to a dir.  This fixes deletions inside "kept" symlinked dirs.
- Call link_stat() with its new arg (for --keep-dirlinks support).

19 years agoMake sure that keep_dirlinks is turned off for the sender.
Wayne Davison [Fri, 11 Jun 2004 07:40:54 +0000 (07:40 +0000)]
Make sure that keep_dirlinks is turned off for the sender.

19 years ago- Moved --keep-dirlinks code over to flist.c.
Wayne Davison [Fri, 11 Jun 2004 07:40:51 +0000 (07:40 +0000)]
- Moved --keep-dirlinks code over to flist.c.
- Call link_stat() with its new arg (for --keep-dirlinks support).

19 years agoMade delete_one() handle a failed rmdir on a symlink when
Wayne Davison [Fri, 11 Jun 2004 07:40:48 +0000 (07:40 +0000)]
Made delete_one() handle a failed rmdir on a symlink when
--keep-dirlinks was specified.

19 years agoCall link_stat() with its new arg (for --keep-dirlinks support).
Wayne Davison [Fri, 11 Jun 2004 07:40:45 +0000 (07:40 +0000)]
Call link_stat() with its new arg (for --keep-dirlinks support).

19 years agoIn set_filesystem(), call do_stat(), not link_stat() to ensure
Wayne Davison [Fri, 11 Jun 2004 05:02:59 +0000 (05:02 +0000)]
In set_filesystem(), call do_stat(), not link_stat() to ensure
that we get the directory behind it all.

19 years agoThe mkdir code should be using do_stat(), not do_lstat() to copy
Wayne Davison [Thu, 10 Jun 2004 16:43:52 +0000 (16:43 +0000)]
The mkdir code should be using do_stat(), not do_lstat() to copy
each existing dir's mode & owner info.

19 years agoAllow the argv list the daemon uses for globbing its args to grow.
Wayne Davison [Wed, 9 Jun 2004 21:51:07 +0000 (21:51 +0000)]
Allow the argv list the daemon uses for globbing its args to grow.

19 years agoRemoved some excessive parens.
Wayne Davison [Wed, 9 Jun 2004 21:43:28 +0000 (21:43 +0000)]
Removed some excessive parens.

19 years agoMentioned a couple more bugfixes.
Wayne Davison [Wed, 9 Jun 2004 21:42:33 +0000 (21:42 +0000)]
Mentioned a couple more bugfixes.

19 years agoRestore UNUSED() macro (the prior problems that prompted me to remove
Wayne Davison [Wed, 9 Jun 2004 21:41:21 +0000 (21:41 +0000)]
Restore UNUSED() macro (the prior problems that prompted me to remove
it appear to have been a build-farm bug).

19 years agoNeeded to enclose the new symlink-warning code in an
Wayne Davison [Wed, 9 Jun 2004 19:23:56 +0000 (19:23 +0000)]
Needed to enclose the new symlink-warning code in an
"#if SUPPORT_LINKS" conditional.

19 years agoRenamed read_unbuffered() to readfd_unbuffered() so that it matches
Wayne Davison [Wed, 9 Jun 2004 03:07:50 +0000 (03:07 +0000)]
Renamed read_unbuffered() to readfd_unbuffered() so that it matches
writefd_unbuffered().

19 years ago- Made the maximum-fd computation prior to a select() use the same idiom
Wayne Davison [Tue, 8 Jun 2004 22:18:04 +0000 (22:18 +0000)]
- Made the maximum-fd computation prior to a select() use the same idiom
  in both the read and write code (also use a better variable name).
- Made the bytes-available code at the end of the select() loop use the
  same flow of control in the read and the write code.

19 years agoImproved a comment in read_msg_fd() and made the byte-reading code
Wayne Davison [Tue, 8 Jun 2004 16:23:54 +0000 (16:23 +0000)]
Improved a comment in read_msg_fd() and made the byte-reading code
in read_timeout() a little better.

19 years agoImproved rwrite() in two ways:
Wayne Davison [Mon, 7 Jun 2004 22:51:14 +0000 (22:51 +0000)]
Improved rwrite() in two ways:
- We no longer assume that the buffer is null terminated (daemon
  mode would ignore the len when logging a message).
- Errors in daemon mode are now sent to both the log and the user.

19 years agoIncrease the size of the message-receving buffer for error
Wayne Davison [Mon, 7 Jun 2004 22:47:01 +0000 (22:47 +0000)]
Increase the size of the message-receving buffer for error
messages sent from the receiver to the generator.

19 years agoChanged a few FINFO messages to FLOG.
Wayne Davison [Mon, 7 Jun 2004 22:33:01 +0000 (22:33 +0000)]
Changed a few FINFO messages to FLOG.

19 years agoGot rid of some am_daemon games in option_error().
Wayne Davison [Mon, 7 Jun 2004 22:05:22 +0000 (22:05 +0000)]
Got rid of some am_daemon games in option_error().

19 years agoUpdated some exclude information that has changed.
Wayne Davison [Mon, 7 Jun 2004 21:40:11 +0000 (21:40 +0000)]
Updated some exclude information that has changed.

19 years agoDon't report a "file vanished" error if a symlink points to nowhere
Wayne Davison [Mon, 7 Jun 2004 19:59:20 +0000 (19:59 +0000)]
Don't report a "file vanished" error if a symlink points to nowhere
and -L was specified.

19 years agoUpdated a couple things.
Wayne Davison [Sun, 6 Jun 2004 20:41:01 +0000 (20:41 +0000)]
Updated a couple things.

19 years agoTell folks to go to the bug-tracking page to report bugs.
Wayne Davison [Sun, 6 Jun 2004 20:36:56 +0000 (20:36 +0000)]
Tell folks to go to the bug-tracking page to report bugs.

19 years ago- Got rid of some useless calls to msg_list_push().
Wayne Davison [Sun, 6 Jun 2004 19:15:58 +0000 (19:15 +0000)]
- Got rid of some useless calls to msg_list_push().
- Added a couple checks to ensure that the receiver doesn't mix two
  clashing kinds of writes on the msg_fd_out pipe.
- Made sure that the read code in the receiver flushes the msg_fd_out
  pipe, if needed.

19 years agoIf the user specifies a small io_timeout value, lower select_timeout.
Wayne Davison [Sun, 6 Jun 2004 19:02:40 +0000 (19:02 +0000)]
If the user specifies a small io_timeout value, lower select_timeout.

19 years agoMake sure our select calls don't sleep for over one minute at a time,
Wayne Davison [Sun, 6 Jun 2004 19:02:09 +0000 (19:02 +0000)]
Make sure our select calls don't sleep for over one minute at a time,
even when io_timeout is a longer value (though the code in options.c
might set it to a shorter value if io_timeout is small).

19 years agoDon't use single-line "if (condition) statement;" idiom.
Wayne Davison [Sun, 6 Jun 2004 18:36:22 +0000 (18:36 +0000)]
Don't use single-line "if (condition) statement;" idiom.

19 years agoMention changes to the patches dir.
Wayne Davison [Sat, 5 Jun 2004 21:23:59 +0000 (21:23 +0000)]
Mention changes to the patches dir.

19 years agoNeatened up some of the glob-expand code and made a few other
Wayne Davison [Sat, 5 Jun 2004 20:26:56 +0000 (20:26 +0000)]
Neatened up some of the glob-expand code and made a few other
minor tweaks.

19 years agoSome superficial code tweaks.
Wayne Davison [Sat, 5 Jun 2004 19:59:03 +0000 (19:59 +0000)]
Some superficial code tweaks.

19 years agoMentioned new --keep-dirlinks option.
Wayne Davison [Sat, 5 Jun 2004 16:19:02 +0000 (16:19 +0000)]
Mentioned new --keep-dirlinks option.

19 years agoNew --keep-dirlinks option.
Wayne Davison [Sat, 5 Jun 2004 16:16:30 +0000 (16:16 +0000)]
New --keep-dirlinks option.

19 years agoMention new SSH_* vars.
Wayne Davison [Thu, 3 Jun 2004 17:20:33 +0000 (17:20 +0000)]
Mention new SSH_* vars.

19 years agoThe daemon-over-ssh code now looks for $SSH_CONNECTION and $SSH2_CLIENT
Wayne Davison [Thu, 3 Jun 2004 17:20:21 +0000 (17:20 +0000)]
The daemon-over-ssh code now looks for $SSH_CONNECTION and $SSH2_CLIENT
as well as $SSH_CLIENT to figure out the remote IP address.

19 years ago- Added older news from NEWS file.
Wayne Davison [Tue, 1 Jun 2004 21:27:52 +0000 (21:27 +0000)]
- Added older news from NEWS file.
- Added missing releases from the Partial Protocol History section.

19 years agoMoved older news to OLDNEWS.
Wayne Davison [Tue, 1 Jun 2004 21:27:12 +0000 (21:27 +0000)]
Moved older news to OLDNEWS.

19 years agoGot rid of an unneeded character pointer in send_file_entry().
Wayne Davison [Sat, 29 May 2004 21:21:17 +0000 (21:21 +0000)]
Got rid of an unneeded character pointer in send_file_entry().

19 years agoMention the --bwlimit change.
Wayne Davison [Fri, 28 May 2004 19:42:06 +0000 (19:42 +0000)]
Mention the --bwlimit change.

19 years agoImprovements to make --bwlimit work better.
Wayne Davison [Thu, 27 May 2004 22:09:31 +0000 (22:09 +0000)]
Improvements to make --bwlimit work better.

19 years agoSet a new variable, bwlimit_writemax, based on the value of the bwlimit
Wayne Davison [Thu, 27 May 2004 21:51:53 +0000 (21:51 +0000)]
Set a new variable, bwlimit_writemax, based on the value of the bwlimit
option.

19 years agoGot rid of a superfluous call to gettimeofday().
Wayne Davison [Mon, 24 May 2004 22:59:16 +0000 (22:59 +0000)]
Got rid of a superfluous call to gettimeofday().

19 years agoThe various include/exclude options are not used on the server side,
Wayne Davison [Mon, 24 May 2004 18:38:05 +0000 (18:38 +0000)]
The various include/exclude options are not used on the server side,
so if someone is trying something funny, just quit.

19 years agoMade full_fname()'s char-pointer arg const.
Wayne Davison [Mon, 24 May 2004 08:10:22 +0000 (08:10 +0000)]
Made full_fname()'s char-pointer arg const.

19 years ago- Properly quote the $excl references.
Wayne Davison [Mon, 24 May 2004 00:16:07 +0000 (00:16 +0000)]
- Properly quote the $excl references.
- Moved the creation of our .cvsignore exclude file.

19 years agoImproved the depth calculation in sanitize_path() so that it properly
Wayne Davison [Sun, 23 May 2004 23:46:56 +0000 (23:46 +0000)]
Improved the depth calculation in sanitize_path() so that it properly
handles a trailing slash, a leading slash, and an empty string.

19 years agoMoved a couple lines.
Wayne Davison [Sat, 22 May 2004 19:29:53 +0000 (19:29 +0000)]
Moved a couple lines.

19 years agoA few minor improvements to the existing items.
Wayne Davison [Sat, 22 May 2004 19:24:24 +0000 (19:24 +0000)]
A few minor improvements to the existing items.

19 years agoFixed a typo in the sending of the --checksum-seed option to the server.
Wayne Davison [Sat, 22 May 2004 06:09:22 +0000 (06:09 +0000)]
Fixed a typo in the sending of the --checksum-seed option to the server.

19 years agoFixed the comment for get_exclude_tok().
Wayne Davison [Sat, 22 May 2004 05:32:20 +0000 (05:32 +0000)]
Fixed the comment for get_exclude_tok().

19 years agoTweaked the alloc/realloc code in flist_expand().
Wayne Davison [Fri, 21 May 2004 23:22:14 +0000 (23:22 +0000)]
Tweaked the alloc/realloc code in flist_expand().

19 years agoTell rsync to preserve permissions.
Wayne Davison [Fri, 21 May 2004 10:06:09 +0000 (10:06 +0000)]
Tell rsync to preserve permissions.

19 years agoAnother new option.
Wayne Davison [Fri, 21 May 2004 10:00:21 +0000 (10:00 +0000)]
Another new option.

19 years agoGot rid of a compiler warning (which was only output by certain
Wayne Davison [Fri, 21 May 2004 09:59:49 +0000 (09:59 +0000)]
Got rid of a compiler warning (which was only output by certain
compilers).

19 years agoAdded the --checksum-seed option.
Wayne Davison [Fri, 21 May 2004 09:44:32 +0000 (09:44 +0000)]
Added the --checksum-seed option.

19 years ago- Improved option_error() to make sure that the user sees the error in
Wayne Davison [Fri, 21 May 2004 09:41:38 +0000 (09:41 +0000)]
- Improved option_error() to make sure that the user sees the error in
  daemon mode.
- Got rid of some repetitious outputting of the same error-message.

19 years agoDocument a couple more changes.
Wayne Davison [Fri, 21 May 2004 09:29:17 +0000 (09:29 +0000)]
Document a couple more changes.

19 years agoIf --backup was specified without a --backup-dir, don't preserve the
Wayne Davison [Fri, 21 May 2004 08:43:03 +0000 (08:43 +0000)]
If --backup was specified without a --backup-dir, don't preserve the
directory timestamps.

19 years agoMoved a few externs.
Wayne Davison [Fri, 21 May 2004 08:40:25 +0000 (08:40 +0000)]
Moved a few externs.

19 years agoChanged sum_init() to take a seed value as an arg instead of always
Wayne Davison [Fri, 21 May 2004 08:27:04 +0000 (08:27 +0000)]
Changed sum_init() to take a seed value as an arg instead of always
using checksum_init.  This fixes an authentication problem in server
mode (as pointed out by Craig Barratt).

19 years ago- Mention the change to the daemon-mode's exclude handling.
Wayne Davison [Wed, 19 May 2004 22:20:56 +0000 (22:20 +0000)]
- Mention the change to the daemon-mode's exclude handling.
- Mention the new "write only" daemon-config option.
- Fixed another entry to refer to the right files.

19 years agoAdded the "write only" option to the daemon config file.
Wayne Davison [Wed, 19 May 2004 22:19:19 +0000 (22:19 +0000)]
Added the "write only" option to the daemon config file.

19 years agoA few minor text improvements.
Wayne Davison [Tue, 18 May 2004 09:54:52 +0000 (09:54 +0000)]
A few minor text improvements.

19 years agoAdded a little more quoting.
Wayne Davison [Tue, 18 May 2004 09:47:42 +0000 (09:47 +0000)]
Added a little more quoting.

19 years agoOutput a message when we skip a server-excluded file.
Wayne Davison [Tue, 18 May 2004 08:50:17 +0000 (08:50 +0000)]
Output a message when we skip a server-excluded file.

19 years agoDocument the latest changes.
Wayne Davison [Tue, 18 May 2004 01:13:14 +0000 (01:13 +0000)]
Document the latest changes.

19 years ago- Use fromdir, todir, and tmpdir instead of FROM, TO, and TMP.
Wayne Davison [Tue, 18 May 2004 00:41:55 +0000 (00:41 +0000)]
- Use fromdir, todir, and tmpdir instead of FROM, TO, and TMP.
- Added chkdir.
- Quote the dir expansions to avoid problems with spaces.
- Added "exclude = foobar.baz" the the rsync.conf file we create.

19 years agoTest that a config-file-specified exclude works right.
Wayne Davison [Tue, 18 May 2004 00:41:51 +0000 (00:41 +0000)]
Test that a config-file-specified exclude works right.

19 years agoQuote the dir expansions to avoid problems with spaces.
Wayne Davison [Tue, 18 May 2004 00:41:49 +0000 (00:41 +0000)]
Quote the dir expansions to avoid problems with spaces.

19 years ago- Use fromdir and todir instead of FROM and TO.
Wayne Davison [Tue, 18 May 2004 00:41:46 +0000 (00:41 +0000)]
- Use fromdir and todir instead of FROM and TO.
- Quote the dir expansions to avoid problems with spaces.

19 years ago- Use $suitedir to find rsync.fns.
Wayne Davison [Tue, 18 May 2004 00:41:43 +0000 (00:41 +0000)]
- Use $suitedir to find rsync.fns.
- Use tmpdir instead of TMP.

19 years agoUse $suitedir to find rsync.fns.
Wayne Davison [Tue, 18 May 2004 00:41:40 +0000 (00:41 +0000)]
Use $suitedir to find rsync.fns.

19 years ago- Use $suitedir to find rsync.fns.
Wayne Davison [Tue, 18 May 2004 00:41:38 +0000 (00:41 +0000)]
- Use $suitedir to find rsync.fns.
- The values of fromdir, todir, and chkdir are already set.

19 years ago- Use $suitedir to find rsync.fns.
Wayne Davison [Tue, 18 May 2004 00:41:35 +0000 (00:41 +0000)]
- Use $suitedir to find rsync.fns.
- The values of fromdir and todir are already set.

19 years agoRemoving obsoleted test.sh file (we used the runtests.sh framework for
Wayne Davison [Tue, 18 May 2004 00:32:36 +0000 (00:32 +0000)]
Removing obsoleted test.sh file (we used the runtests.sh framework for
some time now).

19 years agoIf the server has excluded a file, we now exclude it from being
Wayne Davison [Tue, 18 May 2004 00:14:10 +0000 (00:14 +0000)]
If the server has excluded a file, we now exclude it from being
uploaded as well as downloaded.

19 years agoRenamed free_exclude_list() to clear_exclude_list().
Wayne Davison [Sun, 16 May 2004 23:54:12 +0000 (23:54 +0000)]
Renamed free_exclude_list() to clear_exclude_list().

19 years agoMoved the setting of ret->match_flags up a little in make_exclude().
Wayne Davison [Sun, 16 May 2004 14:08:34 +0000 (14:08 +0000)]
Moved the setting of ret->match_flags up a little in make_exclude().

19 years ago- Save some memory in each exclude_struct item by dumping the "include"
Wayne Davison [Sun, 16 May 2004 07:28:24 +0000 (07:28 +0000)]
- Save some memory in each exclude_struct item by dumping the "include"
  and "directory" ints and using bits in the match_flags value instead.
- Added defines for the new match-flag values, including a new one that
  lets get_exclude_tok() properly return an indication that it parsed
  the list-clearing token.

19 years ago- Switched the "include" and "directory" ints into bits in match_flags.
Wayne Davison [Sun, 16 May 2004 07:28:21 +0000 (07:28 +0000)]
- Switched the "include" and "directory" ints into bits in match_flags.
- Made some length vars unsigned.

19 years ago- Improved rsyserr() to prefix RSYNC_NAME (as the TODO requested),
Wayne Davison [Sat, 15 May 2004 19:31:16 +0000 (19:31 +0000)]
- Improved rsyserr() to prefix RSYNC_NAME (as the TODO requested),
  to construct the string in a better manner, and to have a buffer
  big enough to hold a full MAXPATHLEN filename plus some error
  text.
- Fixed some comments referring to vsprintf() returning -1 -- our
  configuration process now ensures that we replace such a function
  with our own lib version.

19 years ago- Complain about an exclude that was too long and then dump it
Wayne Davison [Sat, 15 May 2004 19:31:13 +0000 (19:31 +0000)]
- Complain about an exclude that was too long and then dump it
  (used to be silently truncated).
- Include extra space in our exclude-reading buffers so that we
  can fit a 2-char prefix and a trailing slash and still handle
  a MAXPATHLEN name.

19 years agoChanged rprintf() calls that included strerror() to use rsyserr().
Wayne Davison [Sat, 15 May 2004 19:31:10 +0000 (19:31 +0000)]
Changed rprintf() calls that included strerror() to use rsyserr().

19 years agoChanged rprintf() calls that included strerror() to use rsyserr().
Wayne Davison [Sat, 15 May 2004 19:31:10 +0000 (19:31 +0000)]
Changed rprintf() calls that included strerror() to use rsyserr().

19 years agoAdded rsyserr().
Wayne Davison [Sat, 15 May 2004 19:31:05 +0000 (19:31 +0000)]
Added rsyserr().

19 years agoWhitespace tweaks.
Wayne Davison [Sat, 15 May 2004 19:09:42 +0000 (19:09 +0000)]
Whitespace tweaks.