Wayne Davison [Sat, 21 Feb 2004 21:39:54 +0000 (21:39 +0000)]
Another bug fix.
Wayne Davison [Sat, 21 Feb 2004 21:37:14 +0000 (21:37 +0000)]
Got rid of the "refuse options" section.
Wayne Davison [Sat, 21 Feb 2004 21:36:55 +0000 (21:36 +0000)]
Complain in the daemon log file if there is an unknown option in the
"refuse options" value. Also changed the idiom used to mark refused
options in the popt struct.
Wayne Davison [Sat, 21 Feb 2004 21:12:49 +0000 (21:12 +0000)]
Fixed the "refuse options" setting in the daemon after Fabrice Bellet
identified what was wrong.
Wayne Davison [Fri, 20 Feb 2004 17:09:30 +0000 (17:09 +0000)]
- Guard against and out-of-memory condition.
- Don't use the NGROUPS_MAX define.
Wayne Davison [Fri, 20 Feb 2004 17:01:33 +0000 (17:01 +0000)]
Don't use NGROUPS_MAX define.
Wayne Davison [Wed, 18 Feb 2004 22:33:21 +0000 (22:33 +0000)]
Don't use ENOMSG -- it's not portable.
Wayne Davison [Tue, 17 Feb 2004 23:13:10 +0000 (23:13 +0000)]
Moved the EXDEV handling into robust_rename().
Wayne Davison [Tue, 17 Feb 2004 23:00:00 +0000 (23:00 +0000)]
- If we return an error because of dry_run being set, we now set errno.
- The do_mkstemp() routine now preserves the errno value from fchmod()
if that call fails.
- Improved the CHECK_RO macro stuff.
Wayne Davison [Tue, 17 Feb 2004 22:49:19 +0000 (22:49 +0000)]
We no longer munge a double-leading slash in do_open() because we
shouldn't generate a path with a double-leading slash anymore.
Wayne Davison [Tue, 17 Feb 2004 21:57:44 +0000 (21:57 +0000)]
Don't create a pathname that has two leading slashes (which we used
to do when the root of the transfer was "/").
J.W. Schultz [Sat, 14 Feb 2004 01:43:24 +0000 (01:43 +0000)]
Remove "Conditional -z for old protocols" because those old
protocols are no longer supported.
Wayne Davison [Wed, 11 Feb 2004 08:01:21 +0000 (08:01 +0000)]
Reordered the items inside the file_struct so that alignment padding
should be minimized.
Wayne Davison [Wed, 11 Feb 2004 05:03:04 +0000 (05:03 +0000)]
If --backup was specified, the links we remove are backed up.
Wayne Davison [Wed, 11 Feb 2004 05:02:21 +0000 (05:02 +0000)]
- Revised and optimized the directory-making code.
- Optimized the keep_backup() code.
Wayne Davison [Wed, 11 Feb 2004 04:30:41 +0000 (04:30 +0000)]
Added backup_dir_buf and backup_dir_remainder.
Wayne Davison [Wed, 11 Feb 2004 02:48:58 +0000 (02:48 +0000)]
Fixed a crash bug when keep_backup() calls make_file() and the lastdir
pointer is no longer valid.
Wayne Davison [Wed, 11 Feb 2004 02:33:17 +0000 (02:33 +0000)]
Got rid of hard-link message (since I don't think it was ever
output in older rsync versions).
Wayne Davison [Tue, 10 Feb 2004 23:35:12 +0000 (23:35 +0000)]
Another attempt at measuring the minimum alignment for a system.
J.W. Schultz [Tue, 10 Feb 2004 23:23:09 +0000 (23:23 +0000)]
Simplified test for hardlink in make_backup debug message to
avoid core-dump.
Wayne Davison [Tue, 10 Feb 2004 22:56:16 +0000 (22:56 +0000)]
Got rid of useless extern.
Wayne Davison [Tue, 10 Feb 2004 22:28:36 +0000 (22:28 +0000)]
Trying a different MINALIGN because of core dumps on the sparc-64
build-farm machines.
J.W. Schultz [Tue, 10 Feb 2004 21:11:24 +0000 (21:11 +0000)]
Revert pool_alloc's use of bomb if pool == NULL.
J.W. Schultz [Tue, 10 Feb 2004 21:11:24 +0000 (21:11 +0000)]
Keep in sync with protocol if idev data on stream but no hlink_pool.
Wayne Davison [Tue, 10 Feb 2004 17:53:52 +0000 (17:53 +0000)]
If XMIT_HAS_IDEV_DATA is set in receive_file_entry(), we now bomb out
if flist->hlink_pool isn't set (instead of neglecting to read the idev
info).
Wayne Davison [Tue, 10 Feb 2004 17:52:31 +0000 (17:52 +0000)]
If we call pool_alloc() on a NULL pool, bomb out with an error.
Wayne Davison [Tue, 10 Feb 2004 17:35:04 +0000 (17:35 +0000)]
Empty-line tweaks.
Wayne Davison [Tue, 10 Feb 2004 17:34:05 +0000 (17:34 +0000)]
Changed a while loop to a for loop.
Wayne Davison [Tue, 10 Feb 2004 17:28:59 +0000 (17:28 +0000)]
Tweaked an if.
Wayne Davison [Tue, 10 Feb 2004 17:28:31 +0000 (17:28 +0000)]
Changed flist_init() to use offsetof().
Wayne Davison [Tue, 10 Feb 2004 17:06:11 +0000 (17:06 +0000)]
Added lib/pool_alloc.h to the HEADERS.
J.W. Schultz [Tue, 10 Feb 2004 03:54:47 +0000 (03:54 +0000)]
Dropped support for protocol versions less than 20 (2.3.0
released 15 Mar 1999) and activated warnings for protocols
less than 25 (2.5.0 released 23 Aug 2001)
J.W. Schultz [Tue, 10 Feb 2004 03:26:41 +0000 (03:26 +0000)]
Added allocation pool code.
J.W. Schultz [Tue, 10 Feb 2004 03:23:37 +0000 (03:23 +0000)]
Make idev, hlink and file_struct + strings use allocation
pools.
Wayne Davison [Mon, 9 Feb 2004 21:22:59 +0000 (21:22 +0000)]
Die if we overflowed the args[] array when building up the remote
command in do_cmd().
Wayne Davison [Mon, 9 Feb 2004 18:32:54 +0000 (18:32 +0000)]
The batch-options now set checksum_seed to the appropriate fixed value.
Wayne Davison [Mon, 9 Feb 2004 18:32:53 +0000 (18:32 +0000)]
Set checksum_seed only if it is still zero.
Wayne Davison [Mon, 9 Feb 2004 18:32:52 +0000 (18:32 +0000)]
Made checksum_seed an extern.
Wayne Davison [Mon, 9 Feb 2004 18:10:57 +0000 (18:10 +0000)]
Use asprintf() in server_options() (plus a few more whitespace tweaks).
Wayne Davison [Mon, 9 Feb 2004 17:45:22 +0000 (17:45 +0000)]
Updated the sizeof syntax and tweaked some whitespace.
Wayne Davison [Sat, 7 Feb 2004 18:40:52 +0000 (18:40 +0000)]
Got rid of unused true/false defines.
Wayne Davison [Sat, 7 Feb 2004 00:12:40 +0000 (00:12 +0000)]
Made a couple comments a little clearer.
Wayne Davison [Fri, 6 Feb 2004 15:33:15 +0000 (15:33 +0000)]
Got rid of unused string_area struct.
J.W. Schultz [Fri, 6 Feb 2004 10:00:33 +0000 (10:00 +0000)]
Start flist with a more reasonable size, grow it linearly
once it reaches a largish size (16 million files) and make it
actually match the comments so it may be used to initialize
flists of known size (create_flist_from_batch()).
J.W. Schultz [Fri, 6 Feb 2004 07:26:15 +0000 (07:26 +0000)]
Update TODO to reflect recent changes.
Hardlink handling is improved.
String area code is gone for other reasons.
Wayne Davison [Fri, 6 Feb 2004 07:19:57 +0000 (07:19 +0000)]
Fixed the indentation in init_flist().
J.W. Schultz [Fri, 6 Feb 2004 04:51:09 +0000 (04:51 +0000)]
Correct sizeof usage and other whitespace.
J.W. Schultz [Fri, 6 Feb 2004 01:56:25 +0000 (01:56 +0000)]
Added a total memory allocated (allmem) line to
show_malloc_stats.
J.W. Schultz [Thu, 5 Feb 2004 03:27:54 +0000 (03:27 +0000)]
Cause all three processes to report memory stats when -vv --stats
Wayne Davison [Thu, 5 Feb 2004 02:56:57 +0000 (02:56 +0000)]
Mention a couple more changes.
Wayne Davison [Thu, 5 Feb 2004 01:37:08 +0000 (01:37 +0000)]
Now that the long-standing chgrp bug is fixed, go back to -vvv from -vvvv.
Wayne Davison [Thu, 5 Feb 2004 01:32:38 +0000 (01:32 +0000)]
Fixed a problem handling GID_NONE in match_gid().
Wayne Davison [Thu, 5 Feb 2004 01:07:23 +0000 (01:07 +0000)]
- Fixed a bug using --numeric-ids as non-root when the receiver
does not have permissions to set one or more of the gids.
- If the add_[ug]id() routine couldn't find a name for an ID, we
still note the ID in our list of IDs so that we don't try to
look it up again (and again). (The name-less IDs are stripped
when sending the IDs from the sender to the receiver.)
- Created a better add_to_list() function that handles the linking
of the new node into the list (rather than the caller doing it).
- Added new internal functions for some receiver-side work that
needed to be done in multiple places (the recv_add_[ug]id()
functions).
- We output debug info even for ID mappings that have no names.
This make the list complete and also notes which gids get
mapped to -1 (GID_NONE).
- Turned several while loops into for loops.
Wayne Davison [Thu, 5 Feb 2004 00:46:32 +0000 (00:46 +0000)]
Added new extern.
Wayne Davison [Thu, 5 Feb 2004 00:44:11 +0000 (00:44 +0000)]
Only call add_uid() or add_gid() if numeric_ids is not set.
Wayne Davison [Wed, 4 Feb 2004 20:09:21 +0000 (20:09 +0000)]
Moved a function.
Wayne Davison [Wed, 4 Feb 2004 19:25:11 +0000 (19:25 +0000)]
If a gid doesn't have a name on the originating system, the receiver
won't see it in the list of IDs to remap. That means that we need to
call the is_in_group() function from inside match_gid() to know if we
can set the group or not (if we're not root).
Wayne Davison [Wed, 4 Feb 2004 18:24:41 +0000 (18:24 +0000)]
Improved the trailing comment.
Wayne Davison [Wed, 4 Feb 2004 17:49:36 +0000 (17:49 +0000)]
Use the new HAVE_GETGROUPS define.
Wayne Davison [Wed, 4 Feb 2004 17:21:48 +0000 (17:21 +0000)]
Added function check for getgroups.
Wayne Davison [Wed, 4 Feb 2004 17:06:07 +0000 (17:06 +0000)]
Use MY_UID() instead of getuid().
Wayne Davison [Wed, 4 Feb 2004 17:05:44 +0000 (17:05 +0000)]
Use MY_GID() instead of getgid().
Wayne Davison [Wed, 4 Feb 2004 17:04:58 +0000 (17:04 +0000)]
Added two defines: MY_UID() and MY_GID().
Wayne Davison [Wed, 4 Feb 2004 16:45:26 +0000 (16:45 +0000)]
Added getegid to the functions we check.
Wayne Davison [Wed, 4 Feb 2004 16:33:34 +0000 (16:33 +0000)]
Added geteuid to the functions to check.
Wayne Davison [Wed, 4 Feb 2004 16:27:47 +0000 (16:27 +0000)]
Another improvement to the debug info we output.
Wayne Davison [Wed, 4 Feb 2004 07:32:48 +0000 (07:32 +0000)]
Set the "max verbosity" global to 9.
Wayne Davison [Wed, 4 Feb 2004 07:32:12 +0000 (07:32 +0000)]
Use the new lp_max_verbosity() value to limit the server's "verbose"
value.
Wayne Davison [Wed, 4 Feb 2004 07:31:29 +0000 (07:31 +0000)]
Added "max verbosity" global parameter that allows you to configure
a higher debug level instead of the default of level-l verbosity.
Wayne Davison [Wed, 4 Feb 2004 07:24:13 +0000 (07:24 +0000)]
Tweaked the new debug-logging strings.
Wayne Davison [Wed, 4 Feb 2004 06:15:24 +0000 (06:15 +0000)]
Turned on 4 -v options for some build-farm testing.
Wayne Davison [Wed, 4 Feb 2004 05:34:29 +0000 (05:34 +0000)]
If we encounter an error, output the rsyncd.log file, if it exists.
Wayne Davison [Wed, 4 Feb 2004 03:58:19 +0000 (03:58 +0000)]
Temporarily switch to 4 -v options.
Wayne Davison [Wed, 4 Feb 2004 03:52:51 +0000 (03:52 +0000)]
Delay the output the (verbose > 3) list of files until we've had a
chance to map the uid/gid info in the receiver.
Wayne Davison [Wed, 4 Feb 2004 03:50:16 +0000 (03:50 +0000)]
Output some debug info if verbose > 3.
Wayne Davison [Wed, 4 Feb 2004 03:28:22 +0000 (03:28 +0000)]
If we're dumping the file list (i.e. verbose > 3), mention the uid and/or
gid (depending on applicability).
Wayne Davison [Wed, 4 Feb 2004 03:25:18 +0000 (03:25 +0000)]
Changed the -x code to allow -L to copy a file on another filesystem
that is pointed to by a symlink on our exclusive filesystem.
Wayne Davison [Wed, 4 Feb 2004 03:01:32 +0000 (03:01 +0000)]
Fixed a dropped '-'.
Wayne Davison [Tue, 3 Feb 2004 23:28:19 +0000 (23:28 +0000)]
Added a little more compatibility code for non-standard systems.
Wayne Davison [Tue, 3 Feb 2004 23:04:25 +0000 (23:04 +0000)]
Some indentation fixes and the removal of some superfluous parens.
Wayne Davison [Tue, 3 Feb 2004 23:01:58 +0000 (23:01 +0000)]
Changed a couple sizeof calls and improved some string handling in
the {send,recv}_exclude_list() calls.
Wayne Davison [Tue, 3 Feb 2004 22:48:32 +0000 (22:48 +0000)]
Modified sizeof usage and eliminated trailing whitespace.
Wayne Davison [Tue, 3 Feb 2004 20:01:26 +0000 (20:01 +0000)]
Added some temporary code to try to figure out what is going wrong
on one NetBSD box in our build farm.
Wayne Davison [Tue, 3 Feb 2004 20:00:35 +0000 (20:00 +0000)]
If verbose > 2, mention it if we're setting the uid or the gid.
J.W. Schultz [Tue, 3 Feb 2004 06:21:56 +0000 (06:21 +0000)]
correct sizeof usage.
Wayne Davison [Tue, 3 Feb 2004 04:21:15 +0000 (04:21 +0000)]
Made hard-link sending compatible with pre-28 protocols again.
J.W. Schultz [Tue, 3 Feb 2004 03:42:49 +0000 (03:42 +0000)]
Corrected sizeof usage:
sizeof obj
sizeof (type)
Wayne Davison [Mon, 2 Feb 2004 22:35:07 +0000 (22:35 +0000)]
Fix for memset bug found by buildfarm.
Wayne Davison [Mon, 2 Feb 2004 22:18:23 +0000 (22:18 +0000)]
Change to try to debug a failure on the build farm.
Wayne Davison [Mon, 2 Feb 2004 21:33:10 +0000 (21:33 +0000)]
Don't warn about lack of -l support if we're the sender -- we just won't
send the receiver any symlinks.
Wayne Davison [Mon, 2 Feb 2004 21:33:06 +0000 (21:33 +0000)]
- Call init_flist().
- Got rid of the symbolic-links-warning code (it was not right, and it is
now handled in options.c).
Wayne Davison [Mon, 2 Feb 2004 21:33:03 +0000 (21:33 +0000)]
- Use as little memory as possible for the file_struct (saves another 3
bytes per file).
- Made the idev struct allocated by the group-malloc again (J.W. suggested
the proper way to align it for all systems).
- Added init_flist().
Wayne Davison [Mon, 2 Feb 2004 21:32:56 +0000 (21:32 +0000)]
Added comment about the position of file_list's "flags" var.
Wayne Davison [Mon, 2 Feb 2004 21:32:52 +0000 (21:32 +0000)]
Don't free link_u.idev.
Wayne Davison [Mon, 2 Feb 2004 21:02:13 +0000 (21:02 +0000)]
Use "%H:%M:%S" instead of "%T" in strftime() call since it looks to be
more portable.
Wayne Davison [Mon, 2 Feb 2004 18:25:37 +0000 (18:25 +0000)]
Clarify the safe/unsafe symlink options in the usage text.
Wayne Davison [Mon, 2 Feb 2004 18:23:09 +0000 (18:23 +0000)]
Clarify the various safe/unsafe symlink options.
Wayne Davison [Mon, 2 Feb 2004 07:06:54 +0000 (07:06 +0000)]
Go back to using malloc() for the hard-link data structure (for now
at least).
Wayne Davison [Mon, 2 Feb 2004 07:06:50 +0000 (07:06 +0000)]
Free the hlink data again.
Wayne Davison [Mon, 2 Feb 2004 06:52:49 +0000 (06:52 +0000)]
Make sure that the idev struct's data is 4-byte aligned.