Wayne Davison [Thu, 23 Jun 2005 15:53:26 +0000 (15:53 +0000)]
Tweaked a comment in the perl code we output.
Wayne Davison [Mon, 20 Jun 2005 07:01:29 +0000 (07:01 +0000)]
Improved a couple sentences.
Wayne Davison [Fri, 17 Jun 2005 23:23:00 +0000 (23:23 +0000)]
Changed the code to use the single long-option hash from cull_options.
Wayne Davison [Fri, 17 Jun 2005 23:16:22 +0000 (23:16 +0000)]
- Fixed a bug where the --*-dest options weren't being culled.
- Simplified the output format by putting all the long-name
options into a single hash.
Wayne Davison [Fri, 17 Jun 2005 16:48:02 +0000 (16:48 +0000)]
- Improved some comments (some taken from the new cull-options output).
- Made the user-config sections easier to find.
- Default to running a fully-specified rsync executable so that there
are not PATH surprises.
- A few minor tweaks to the arg-checking code to make it clearer without
actually changing its logic.
Wayne Davison [Fri, 17 Jun 2005 16:29:21 +0000 (16:29 +0000)]
Another readability improvement in the perl code we output.
Wayne Davison [Fri, 17 Jun 2005 16:12:05 +0000 (16:12 +0000)]
Improved some of the comments that are output into the perl code.
Wayne Davison [Fri, 17 Jun 2005 05:14:15 +0000 (05:14 +0000)]
- Make sure that the command contained the '.' arg at the end of the
options.
- Fixed the expanding of wildcards for a restriction of '/'.
Wayne Davison [Fri, 17 Jun 2005 04:50:22 +0000 (04:50 +0000)]
- Be restrictive on matching the --sender option so that the user
can't fool us into thinking we're the sender by using a filename
of --sender (or similar ploy).
- Make sure that our '..' check can't be fooled by sly backslashing.
- Tweaked some comments.
Wayne Davison [Fri, 17 Jun 2005 04:46:02 +0000 (04:46 +0000)]
Output a leading comment and surrounding blank lines.
Wayne Davison [Fri, 17 Jun 2005 01:26:33 +0000 (01:26 +0000)]
Mention rrsync changes.
Wayne Davison [Fri, 17 Jun 2005 01:17:44 +0000 (01:17 +0000)]
If SUBDIR is specified as a non-absolute path, make it absolute.
Wayne Davison [Thu, 16 Jun 2005 19:30:53 +0000 (19:30 +0000)]
- Made it easy to configure the path of the rsync executable.
- Fully parse all legal options that might come from a stock rsync and
validate/restrict any option's args (previously we rejected options
with args).
- Made it easy to disable specific options.
- Properly handle a multi-arg copy's multiple args.
- Make sure that the restricted dir actually exists and we can chdir
to it.
- Just reject any dangerous args that have .. in them instead of trying
to munge them.
- We don't treat single-or double-quotes specially, just backslash-
escaped characters.
- Turn on strict mode.
- Use the array-arg version of exec() so that we don't spawn a shell.
- Use File::Glob to glob wildcards in args.
- Tweaked the log-file format so that it logs the modified command
without any "OK" suffix.
Wayne Davison [Thu, 16 Jun 2005 19:17:47 +0000 (19:17 +0000)]
A developer-oriented script that outputs perl code for valid server
options.
Wayne Davison [Sun, 12 Jun 2005 06:10:14 +0000 (06:10 +0000)]
Mention latest fix.
Wayne Davison [Sun, 12 Jun 2005 06:07:23 +0000 (06:07 +0000)]
In clean_flist(), fixed the setting of the flist->high value for an
empty list so that it can't cause a crash if it gets passed to
flist_find().
Wayne Davison [Fri, 10 Jun 2005 23:36:57 +0000 (23:36 +0000)]
- Added a comment to the filter_outfile function.
- Twiddled where the calls to filter_outfile happen.
Wayne Davison [Fri, 10 Jun 2005 21:56:52 +0000 (21:56 +0000)]
Simplified the regular expressions for sed due to problems on some
OSes.
Wayne Davison [Fri, 10 Jun 2005 20:33:57 +0000 (20:33 +0000)]
- Put the output we're expecting into an chk file, for easier
debugging on failures.
- Added the function filter_outfile() and used it in place of the
various output-filtering commands.
- Use the sed rules for filtering the combination of --itemized
output with double-verbose output so that we're sure there's no
superfluous lines being output (which the old grep filtering
would have ignored).
Wayne Davison [Fri, 10 Jun 2005 20:04:42 +0000 (20:04 +0000)]
Several expansions of $srcdir were not double-quoted.
Wayne Davison [Fri, 10 Jun 2005 20:04:11 +0000 (20:04 +0000)]
One expansion of $srcdir wasn't double-quoted.
Wayne Davison [Fri, 10 Jun 2005 18:02:14 +0000 (18:02 +0000)]
One more instance of the umask kluge was needed.
Wayne Davison [Fri, 10 Jun 2005 17:58:39 +0000 (17:58 +0000)]
Mention backup change.
Wayne Davison [Fri, 10 Jun 2005 17:57:18 +0000 (17:57 +0000)]
Fixed a problem in the backing up of symlinks and devices: we
need to remove any old symlink/device/file to create the backup.
Also fixed a couple minor logic errors in the handling of symlinks
and devices. NOTE: the code still doesn't handle the changing of
a name from a dir to a non-dir or visa versa (which is a very old
deficiency in the code).
Wayne Davison [Fri, 10 Jun 2005 17:51:33 +0000 (17:51 +0000)]
Use umask kluge from fns to try to get rid of a potential
permissions difference when copying symlinks.
Wayne Davison [Fri, 10 Jun 2005 17:21:52 +0000 (17:21 +0000)]
Make the sed commands compatible with Solaris (hopefully).
Wayne Davison [Fri, 10 Jun 2005 17:17:38 +0000 (17:17 +0000)]
Starting NEWS for 2.6.6.
Wayne Davison [Fri, 10 Jun 2005 17:17:24 +0000 (17:17 +0000)]
Aged news from NEWS file.
Wayne Davison [Fri, 10 Jun 2005 17:06:43 +0000 (17:06 +0000)]
Got rid of some potentially unhandled permissions differences.
Wayne Davison [Fri, 10 Jun 2005 16:57:43 +0000 (16:57 +0000)]
Changed the "max verbosity" setting from global to per-module.
Wayne Davison [Fri, 10 Jun 2005 16:50:09 +0000 (16:50 +0000)]
Use the new NOBODY_USER and NOBODY_GROUP configure defines.
Wayne Davison [Fri, 10 Jun 2005 16:46:50 +0000 (16:46 +0000)]
Added a simple check to see if the /etc/group file has the
group "nobody" or "nogroup".
Wayne Davison [Thu, 9 Jun 2005 22:27:59 +0000 (22:27 +0000)]
Test that our outputting of itemized messages (as well as
double-verbose output) is happening correctly.
Wayne Davison [Thu, 9 Jun 2005 22:27:22 +0000 (22:27 +0000)]
- Fixed the overzealous outputting of unchanged hard-linked items
when verbose > 1.
- An unchanged hard-link with -i (log-format w/%i) now changes the
trailing dots to spaces.
Wayne Davison [Thu, 9 Jun 2005 21:57:45 +0000 (21:57 +0000)]
Don't set ITEM_REPORT_TIME when a hard-linked file is already
linked up as it should be and --times was not enabled.
Wayne Davison [Thu, 9 Jun 2005 21:56:11 +0000 (21:56 +0000)]
- Never output the '"FOO" is a hard link' message when -i (%i)
output is enabled.
- Go back to outputting '"FOO" is a hard link' message when -i (%i)
is not enabled and verbose > 1.
Wayne Davison [Thu, 9 Jun 2005 21:18:26 +0000 (21:18 +0000)]
Updated version to 2.6.6cvs.
Wayne Davison [Thu, 2 Jun 2005 03:57:58 +0000 (03:57 +0000)]
Preparing for release of 2.6.5
Wayne Davison [Thu, 2 Jun 2005 03:54:00 +0000 (03:54 +0000)]
Improved a few of the items.
Wayne Davison [Wed, 1 Jun 2005 16:21:41 +0000 (16:21 +0000)]
One more configure item.
Wayne Davison [Tue, 31 May 2005 06:09:42 +0000 (06:09 +0000)]
Mention HAVE_REMSH fix.
Wayne Davison [Fri, 27 May 2005 18:15:18 +0000 (18:15 +0000)]
Simplified the last change a bit.
Wayne Davison [Fri, 27 May 2005 18:09:34 +0000 (18:09 +0000)]
Test for various past problems with --relative.
Wayne Davison [Fri, 27 May 2005 18:04:04 +0000 (18:04 +0000)]
If we unduplicate '.', make sure we also copy FLAG_DEL_HERE (in
addition to FLAG_TOP_DIR), so that the unduplication of a real
dir and an implied dir (implied by --relative) works right.
Wayne Davison [Fri, 27 May 2005 16:41:19 +0000 (16:41 +0000)]
- Only define HAVE_REMSH if it is going to have a non-0 value.
- Got rid of ssh warning that was added for 2.6.0.
Wayne Davison [Thu, 26 May 2005 18:00:09 +0000 (18:00 +0000)]
Improved the opening comment.
Wayne Davison [Wed, 25 May 2005 15:52:03 +0000 (15:52 +0000)]
Mention the latest bug-fix.
Wayne Davison [Wed, 25 May 2005 01:24:01 +0000 (01:24 +0000)]
Handle nested "." dirs (caused by --relative and a trailing slash or
a trailing "/.") in f_name_cmp() when dirname is not an identical
pointer.
Wayne Davison [Sun, 22 May 2005 20:53:18 +0000 (20:53 +0000)]
Mention the output change for a mount-dir when -x is used.
Wayne Davison [Sun, 22 May 2005 20:52:32 +0000 (20:52 +0000)]
- Don't stop deleting in a dir if one item fails.
- Don't skip deleting in a dir if the initial rmdir fails
(2.6.4 only continued if it was a non-empty error).
Wayne Davison [Sun, 22 May 2005 17:19:16 +0000 (17:19 +0000)]
Must check FLAG_MOUNT_POINT in delete_in_dir() to avoid starting a
descent into a mounted directory when -x is specified.
Wayne Davison [Fri, 20 May 2005 17:57:31 +0000 (17:57 +0000)]
Improved the SYMBOLIC LINKS section, as suggested by John.
Wayne Davison [Fri, 20 May 2005 17:39:10 +0000 (17:39 +0000)]
Improved a --files-from example (as suggested by Paul).
Wayne Davison [Thu, 19 May 2005 22:16:50 +0000 (22:16 +0000)]
Tweaked a sentence.
Wayne Davison [Thu, 19 May 2005 21:45:41 +0000 (21:45 +0000)]
Preparing for release of 2.6.5pre2
Wayne Davison [Thu, 19 May 2005 21:42:20 +0000 (21:42 +0000)]
Tweaked the opening comments.
Wayne Davison [Thu, 19 May 2005 21:38:25 +0000 (21:38 +0000)]
Mentioned the improved keep-alive code.
Wayne Davison [Thu, 19 May 2005 21:36:30 +0000 (21:36 +0000)]
Clarifications related to --dirs.
Wayne Davison [Thu, 19 May 2005 08:52:24 +0000 (08:52 +0000)]
Periodically call maybe_send_keepalive() when timeouts are in effect
(this ensures that the receiver doesn't timeout when we're still
doing work reading data from the generator).
Wayne Davison [Thu, 19 May 2005 08:52:22 +0000 (08:52 +0000)]
The global allowed_lull is now already set, so just set lull_mod.
Wayne Davison [Thu, 19 May 2005 08:52:19 +0000 (08:52 +0000)]
- Call the new set_io_timeout() function to set the timeout value.
- If the user specified a shorter timeout than the config-file,
don't override the shorter value.
Wayne Davison [Thu, 19 May 2005 08:52:17 +0000 (08:52 +0000)]
- The variable allowed_lull is now our global.
- Tweaked the --timeout option handling to call set_io_timeout().
Wayne Davison [Thu, 19 May 2005 08:52:13 +0000 (08:52 +0000)]
- Added set_io_timeout(), which sets all the timeout-dependent
variables when the timeout value changes.
- Split last_io into last_io_in and last_io_out.
- Made select_timeout static.
Wayne Davison [Thu, 19 May 2005 00:02:29 +0000 (00:02 +0000)]
The latest bug-fix.
Wayne Davison [Thu, 19 May 2005 00:00:28 +0000 (00:00 +0000)]
One place that was testing errno for ENOTEMPTY was failing to
also test for EEXIST (which is returned by some OSes).
Wayne Davison [Wed, 18 May 2005 23:59:12 +0000 (23:59 +0000)]
Fixed a typo.
Wayne Davison [Tue, 17 May 2005 15:08:05 +0000 (15:08 +0000)]
Two more items.
Wayne Davison [Sat, 14 May 2005 18:44:57 +0000 (18:44 +0000)]
Treat a trailing ".." dir-name as if "../" had been specified so
that we don't use the name in the destination path and save files
into a higher destination directory.
Wayne Davison [Fri, 13 May 2005 23:03:00 +0000 (23:03 +0000)]
Mention the latest bug fix.
Wayne Davison [Fri, 13 May 2005 23:00:20 +0000 (23:00 +0000)]
Have do_delete_pass() immediately return if list_only is set.
Wayne Davison [Fri, 13 May 2005 22:02:24 +0000 (22:02 +0000)]
If adding a trailing dot to a directory name overflows
MAXPATHLEN, die with an overflow error.
Wayne Davison [Fri, 13 May 2005 18:37:11 +0000 (18:37 +0000)]
An example filter script to maintain .cvsinclude files.
Wayne Davison [Thu, 12 May 2005 17:36:29 +0000 (17:36 +0000)]
Improved the use of the "remaining" var in readfd_unbuffered() to
make certain that the static value is always set correctly anytime
we call out to another function.
Wayne Davison [Thu, 12 May 2005 07:45:21 +0000 (07:45 +0000)]
Got rid of some code from writefd_unbuffered() that was only needed
back when the generator had a writeable pipe to the receiver.
Wayne Davison [Thu, 12 May 2005 07:43:14 +0000 (07:43 +0000)]
Make the --stats output come out after any delete-after messages.
Wayne Davison [Thu, 12 May 2005 07:34:45 +0000 (07:34 +0000)]
Improved a few sentences.
Wayne Davison [Tue, 10 May 2005 18:31:46 +0000 (18:31 +0000)]
Fixed a typo.
Wayne Davison [Tue, 10 May 2005 17:28:34 +0000 (17:28 +0000)]
Preparing for release of 2.6.5pre1
Wayne Davison [Tue, 10 May 2005 17:27:39 +0000 (17:27 +0000)]
Added more missing NEWS items.
Wayne Davison [Tue, 10 May 2005 16:55:22 +0000 (16:55 +0000)]
Mention two more changes.
Wayne Davison [Tue, 10 May 2005 16:14:26 +0000 (16:14 +0000)]
Refer to the rsync daemon as a "daemon", not a "server". This is
to avoid confusion with the server that rsync runs in a normal
remote-shell transfer.
Wayne Davison [Tue, 10 May 2005 16:04:02 +0000 (16:04 +0000)]
- Improved the GENERAL section.
- Improved the description of --list-only.
- Added a VERSION section, like the rsyncd.conf manpage.
Wayne Davison [Tue, 10 May 2005 16:00:24 +0000 (16:00 +0000)]
Refer to the rsync daemon as a "daemon", not a "server". This is
to avoid confusion with the server that rsync runs in a normal
remote-shell transfer.
Wayne Davison [Mon, 9 May 2005 15:39:24 +0000 (15:39 +0000)]
Fixed one synopsis line to make the DEST arg optional.
Wayne Davison [Tue, 3 May 2005 17:04:26 +0000 (17:04 +0000)]
Use new MAX_SERVER_ARGS define instead of hard-wired "100".
Wayne Davison [Tue, 3 May 2005 17:01:59 +0000 (17:01 +0000)]
There was no reason to have MAX_BASIS_DIRS factored into the
length of the argstr[] array.
Wayne Davison [Tue, 3 May 2005 17:00:47 +0000 (17:00 +0000)]
Added MAX_SERVER_ARGS.
Wayne Davison [Tue, 3 May 2005 16:47:03 +0000 (16:47 +0000)]
A few minor doc tweaks.
Wayne Davison [Tue, 3 May 2005 16:46:49 +0000 (16:46 +0000)]
- Moved the --version option in the help text.
- Tweaked the --log-format option's description.
- Added a comment.
Wayne Davison [Tue, 3 May 2005 16:45:40 +0000 (16:45 +0000)]
Mention the change in error message and exit status when we pull an
empty file list.
Wayne Davison [Tue, 3 May 2005 16:44:47 +0000 (16:44 +0000)]
Tweaked the checking of the "limit" in safe_fname().
Wayne Davison [Tue, 3 May 2005 16:03:31 +0000 (16:03 +0000)]
Fixed a typo.
Wayne Davison [Tue, 3 May 2005 15:59:24 +0000 (15:59 +0000)]
- Improved the comments on the backslash-escaped output, and moved it
to the top in an "OUTPUT CHANGES" section.
- Added a mention of the generator's new output-flushing optimization.
Wayne Davison [Tue, 3 May 2005 15:58:06 +0000 (15:58 +0000)]
Improved a sentence.
Wayne Davison [Mon, 2 May 2005 18:04:32 +0000 (18:04 +0000)]
Mention the '?'-in-filenames change.
Wayne Davison [Mon, 2 May 2005 17:27:20 +0000 (17:27 +0000)]
Fixed some misspellings.
Wayne Davison [Mon, 2 May 2005 17:23:08 +0000 (17:23 +0000)]
Tweaked the description of --from0.
Wayne Davison [Mon, 2 May 2005 17:22:42 +0000 (17:22 +0000)]
Tweaked the doc for --from0.
Wayne Davison [Thu, 28 Apr 2005 16:26:23 +0000 (16:26 +0000)]
Moved the max-size checking code down so that it only checks
regular files.
Wayne Davison [Thu, 28 Apr 2005 16:11:32 +0000 (16:11 +0000)]
Moved the size-parsing code for --max-size into its own function.