Wayne Davison [Tue, 16 Sep 2003 05:33:09 +0000 (05:33 +0000)]
Tweaked the just-added error message to use my new full_fname()
function. Also removed some trailing whitespace from lines.
J.W. Schultz [Tue, 16 Sep 2003 02:49:59 +0000 (02:49 +0000)]
Detect and report when open or opendir succeed but read and
readdir fail caused by network filesystems issues and
truncated files.
Thanks to David Norwood and Michael Brown
Wayne Davison [Thu, 11 Sep 2003 05:00:52 +0000 (05:00 +0000)]
Mention my recent changes.
Wayne Davison [Thu, 11 Sep 2003 04:53:05 +0000 (04:53 +0000)]
Improved file-related error messages by using the new
full_fname() function.
Wayne Davison [Thu, 11 Sep 2003 04:53:01 +0000 (04:53 +0000)]
Tweaked an error message.
Wayne Davison [Thu, 11 Sep 2003 04:48:15 +0000 (04:48 +0000)]
Added a new function, full_fname(), that makes a filename more complete
for error messages. If the path is in a module, we ensure that the
"path" setting (from the config file) is not revealed, while still
reminding the user that the path is relative to the module's root.
Wayne Davison [Thu, 11 Sep 2003 04:48:13 +0000 (04:48 +0000)]
Include a few new stubs to handle the new full_fname() function.
Wayne Davison [Thu, 11 Sep 2003 04:48:09 +0000 (04:48 +0000)]
Got rid of some "/* dw */" comments and fixed some line's indentation.
Wayne Davison [Thu, 11 Sep 2003 04:48:07 +0000 (04:48 +0000)]
Got rid of some "/* dw */" comments.
Wayne Davison [Thu, 11 Sep 2003 04:00:19 +0000 (04:00 +0000)]
If lp_path() returns "/", set exclude_path_prefix to "" (because the
exclude code doesn't want any trailing slashes).
Wayne Davison [Thu, 11 Sep 2003 03:49:53 +0000 (03:49 +0000)]
Make sure that the new slash-stripping P_PATH code doesn't turn
a "/" into an empty string.
Wayne Davison [Wed, 10 Sep 2003 08:27:34 +0000 (08:27 +0000)]
Changed main() definition to avoid an extra prototype being put
into the proto.h file.
Wayne Davison [Wed, 10 Sep 2003 08:08:14 +0000 (08:08 +0000)]
Make sure that the "path" value has any trailing slashes removed.
Wayne Davison [Wed, 10 Sep 2003 07:31:58 +0000 (07:31 +0000)]
Got rid of trailing whitespace.
Wayne Davison [Tue, 9 Sep 2003 15:58:56 +0000 (15:58 +0000)]
Added the new --protocol option.
Wayne Davison [Tue, 9 Sep 2003 15:58:53 +0000 (15:58 +0000)]
Changed most instances of "remote_version" to "protocol_version", and
others to "remote_protocol". Downgrade the protocol_version if the
remote_protocol" is lower. Output the protocol values if the verbose
level is large enough. Exit if the user tried to force a protocol
value that is not within the range that we can handle. Fixed the
output of the "very old version of rsync" message to output the right
Client/Server string.
Wayne Davison [Tue, 9 Sep 2003 15:58:50 +0000 (15:58 +0000)]
Changed most instances of "remote_version" to "protocol_version", and
others to "remote_protocol". Downgrade the protocol_version if the
remote_protocol is lower.
Wayne Davison [Tue, 9 Sep 2003 15:58:48 +0000 (15:58 +0000)]
Changed "remote_version" to "protocol_version".
J.W. Schultz [Thu, 4 Sep 2003 05:54:20 +0000 (05:54 +0000)]
*** empty log message ***
J.W. Schultz [Thu, 4 Sep 2003 05:49:50 +0000 (05:49 +0000)]
Allow non-dir special files to be replaced with regular
files and fix error that caused directories in link-dest or
compare-dest to prevent the creation of files of same path.
Wayne Davison [Fri, 22 Aug 2003 21:26:08 +0000 (21:26 +0000)]
Cast various s->blength references inside of MIN() macros to OFF_T
so that compilers don't warn about signed/unsigned comparisons.
Wayne Davison [Fri, 22 Aug 2003 05:51:42 +0000 (05:51 +0000)]
Whitespace tweaks.
Wayne Davison [Fri, 22 Aug 2003 05:42:13 +0000 (05:42 +0000)]
Fixed the multiplying of blength*blength so that it can't overflow
before it gets cast to a uint64.
Wayne Davison [Fri, 22 Aug 2003 05:04:13 +0000 (05:04 +0000)]
Made the UNUSED(parameter) macro calls read a little nicer.
Wayne Davison [Fri, 22 Aug 2003 00:31:46 +0000 (00:31 +0000)]
Mark unused vars.
Wayne Davison [Fri, 22 Aug 2003 00:30:46 +0000 (00:30 +0000)]
Make extra backup dirs mode 0700, not 0755.
Wayne Davison [Thu, 21 Aug 2003 23:54:20 +0000 (23:54 +0000)]
Got rid of a duplicate include for malloc.h and improved the "do we
need malloc.h" logic a bit more. (Trying to prevent #warning and
#error problems on *BSD systems.)
Wayne Davison [Thu, 21 Aug 2003 23:46:10 +0000 (23:46 +0000)]
Got rid of signed/unsigned-comparison warning if st_rdev is signed.
Wayne Davison [Thu, 21 Aug 2003 23:45:49 +0000 (23:45 +0000)]
Got rid of signed/unsigned-comparison warning if st_dev is signed.
Wayne Davison [Thu, 21 Aug 2003 23:32:35 +0000 (23:32 +0000)]
Let's try only including malloc.h if stdlib.h isn't around (and it
exists).
Wayne Davison [Thu, 21 Aug 2003 23:28:24 +0000 (23:28 +0000)]
Silenced a couple compiler warnings.
Wayne Davison [Wed, 20 Aug 2003 23:36:45 +0000 (23:36 +0000)]
Mention some more bug fixes.
Wayne Davison [Wed, 20 Aug 2003 23:25:52 +0000 (23:25 +0000)]
Call setgroups(1, &gid) after setting the gid (rather than calling
setgroups(0, NULL) before).
Wayne Davison [Wed, 20 Aug 2003 10:37:53 +0000 (10:37 +0000)]
Use the AVAIL_OUT_SIZE() macro in a few more places to ensure
that the avail_out buffer is big enough to uncompress all the
compressed data.
Wayne Davison [Mon, 18 Aug 2003 23:52:43 +0000 (23:52 +0000)]
Fixed a couple option-name typos (that had '_' instead of '-').
Wayne Davison [Sun, 17 Aug 2003 21:29:11 +0000 (21:29 +0000)]
- Made special exclusion-handling of '.' work in -R mode (so that we
can't accidentally lose the '.' dir and not transfer anything at all).
- Add a trailing '.' onto all '/'-trailing names, even '/' (fixes
skipped deletions in -R mode from '/').
- Fixed loss of FLAG_DELETE on user-specified dir when unduplicating '.'
(could happen on "./." or similar).
J.W. Schultz [Fri, 15 Aug 2003 00:57:27 +0000 (00:57 +0000)]
Whitespace and indentation cleanup. There is a lot of deep
indentation mostly due to read_batch but at least it is now
consistant.
J.W. Schultz [Wed, 6 Aug 2003 06:45:14 +0000 (06:45 +0000)]
Make --progress imply --verbose without incrementing verbosity.
Wayne Davison [Tue, 5 Aug 2003 17:56:54 +0000 (17:56 +0000)]
Got rid of unused OPT_* enums.
Wayne Davison [Mon, 4 Aug 2003 21:03:07 +0000 (21:03 +0000)]
Improved the mkstemp error message.
Wayne Davison [Mon, 4 Aug 2003 21:00:57 +0000 (21:00 +0000)]
Make sure that the error message for mkstemp() includes the full
path of where we're trying to create the temp file.
Wayne Davison [Mon, 4 Aug 2003 18:27:27 +0000 (18:27 +0000)]
Instead of ignoring SIG_CHLD, reap zombies in the signal handler.
Wayne Davison [Fri, 1 Aug 2003 20:19:51 +0000 (20:19 +0000)]
Change the way we pass the --suffix option to the remote process so
that a string that starts with ~ doesn't get modified.
Wayne Davison [Fri, 1 Aug 2003 19:40:31 +0000 (19:40 +0000)]
Complain if the --suffix value contains slashes (which is all too easy
to accidentally have happen if you try to specify "~" with --backup-dir).
Wayne Davison [Fri, 1 Aug 2003 08:20:53 +0000 (08:20 +0000)]
We should bump the deletion_count for backed-up deleted files too.
Wayne Davison [Fri, 1 Aug 2003 08:01:15 +0000 (08:01 +0000)]
Mention the --backup fix.
Wayne Davison [Fri, 1 Aug 2003 07:58:47 +0000 (07:58 +0000)]
Properly handle the backup_suffix/backup_dir settings when deleting
files. Also optimized the code that calls delete_one(). Don't
neglect to mention a file being deleted with --backup set.
Wayne Davison [Fri, 1 Aug 2003 07:58:44 +0000 (07:58 +0000)]
Got rid of suffix_specified and instead set backup_suffix to the
correct default value for the current backup_dir mode. Added two
new values: backup_suffix_len and backup_dir_len. Improved some
error-message code to not output duplicate errors.
Wayne Davison [Fri, 1 Aug 2003 07:58:41 +0000 (07:58 +0000)]
Use the new backup_suffix_len and backup_dir_len variables. Got rid
of the suffix_specified kludge.
Wayne Davison [Fri, 1 Aug 2003 00:50:23 +0000 (00:50 +0000)]
Clarify some --backup/--backup-dir/--suffix issues.
J.W. Schultz [Thu, 31 Jul 2003 09:32:15 +0000 (09:32 +0000)]
Whitespace and indentation fixes.
Wayne Davison [Wed, 30 Jul 2003 06:13:47 +0000 (06:13 +0000)]
No longer needed (replaced by wildmatch).
Wayne Davison [Wed, 30 Jul 2003 06:12:41 +0000 (06:12 +0000)]
Updated the exclude/include section to mention the "**" vs "*" change.
Wayne Davison [Wed, 30 Jul 2003 06:12:33 +0000 (06:12 +0000)]
Changed the "**" description to reflect its no-longer-buggy behavior.
Wayne Davison [Wed, 30 Jul 2003 06:12:31 +0000 (06:12 +0000)]
Include "lib/wildmatch.h", not "lib/fnmatch.h" or <fnmatch.h>.
Wayne Davison [Wed, 30 Jul 2003 06:12:29 +0000 (06:12 +0000)]
Got rid of test for fnmatch.
Wayne Davison [Wed, 30 Jul 2003 06:12:27 +0000 (06:12 +0000)]
Call wildmatch(), not fnmatch().
Wayne Davison [Wed, 30 Jul 2003 06:12:25 +0000 (06:12 +0000)]
Changed lib/fnmatch.o to lib/wildmatch.o.
Wayne Davison [Sat, 26 Jul 2003 18:13:38 +0000 (18:13 +0000)]
Made the list of exclude/include changes more prominent and clear.
Wayne Davison [Sat, 26 Jul 2003 17:55:07 +0000 (17:55 +0000)]
Some superficial tweaks I made while reading through the io.c code.
Wayne Davison [Mon, 14 Jul 2003 15:46:34 +0000 (15:46 +0000)]
Added one more test.
Wayne Davison [Mon, 14 Jul 2003 15:13:31 +0000 (15:13 +0000)]
Updated for latest character-class change.
Wayne Davison [Mon, 14 Jul 2003 15:12:59 +0000 (15:12 +0000)]
Make sure that no character class can match a '/'.
Wayne Davison [Tue, 8 Jul 2003 16:54:53 +0000 (16:54 +0000)]
Optimized show_progress() to reduce the calls to gettimeofday() when
am_server is set. No need to check do_progress here anymore, since
we aren't called if do_progress isn't set.
Wayne Davison [Tue, 8 Jul 2003 16:49:10 +0000 (16:49 +0000)]
Only call show_progress() and end_progress() if do_progress is set.
Wayne Davison [Mon, 7 Jul 2003 19:37:58 +0000 (19:37 +0000)]
Changed "./
0123456789" to just ".
0123456789".
Wayne Davison [Mon, 7 Jul 2003 18:37:38 +0000 (18:37 +0000)]
I decided to go with the slightly simpler logic Thorild Selen suggested
in a subsequent email.
Wayne Davison [Mon, 7 Jul 2003 18:25:01 +0000 (18:25 +0000)]
Improved deficiencies in the hostname-vs-address check (reintroduced in the
last revision) based on the suggestions of Thorild Selen.
Wayne Davison [Mon, 7 Jul 2003 07:28:02 +0000 (07:28 +0000)]
Commented-out a test that wasn't consistent across all platforms.
Wayne Davison [Mon, 7 Jul 2003 07:22:08 +0000 (07:22 +0000)]
Silence some compiler warnings on HP-UX.
Wayne Davison [Mon, 7 Jul 2003 07:10:40 +0000 (07:10 +0000)]
A few more tests.
Wayne Davison [Mon, 7 Jul 2003 07:08:24 +0000 (07:08 +0000)]
Improved the summary output to use correct English for all counts.
Wayne Davison [Mon, 7 Jul 2003 07:07:16 +0000 (07:07 +0000)]
Don't treat "[:" as the start of a named set if there's no ":]".
Wayne Davison [Sun, 6 Jul 2003 18:54:08 +0000 (18:54 +0000)]
Added a few more items to the tests.
Wayne Davison [Sun, 6 Jul 2003 18:29:24 +0000 (18:29 +0000)]
Improve the format of the --iterations output.
Wayne Davison [Sun, 6 Jul 2003 18:26:34 +0000 (18:26 +0000)]
- Return ABORT_ALL for a syntax error in the pattern (not FALSE).
- Abort if the [:class:] name is not known.
Wayne Davison [Sun, 6 Jul 2003 17:41:37 +0000 (17:41 +0000)]
Added match for new "no errors" line from wildtest.
Wayne Davison [Sun, 6 Jul 2003 17:41:01 +0000 (17:41 +0000)]
Switch to using an input file so that backslashes are specified
normally, and so that test additions and changes are easier.
Wayne Davison [Sun, 6 Jul 2003 16:29:32 +0000 (16:29 +0000)]
Added some portability code for the ctype functions.
Wayne Davison [Sun, 6 Jul 2003 04:34:19 +0000 (04:34 +0000)]
Updated for latest wildmatch.c changes.
Wayne Davison [Sun, 6 Jul 2003 04:33:54 +0000 (04:33 +0000)]
- Added [:class:] handling to the character-class code.
- Use explicit unsigned characters for proper set checks.
- Made the character-class code honor backslash escapes.
- Accept '^' as a class-negation character in addition to '!'.
Wayne Davison [Sat, 5 Jul 2003 22:57:08 +0000 (22:57 +0000)]
We now figure out if diff accepts -u and we'll use it instead of -c,
if possible.
Wayne Davison [Sat, 5 Jul 2003 22:40:27 +0000 (22:40 +0000)]
Simplified the character-class code a bit.
Wayne Davison [Sat, 5 Jul 2003 19:21:41 +0000 (19:21 +0000)]
Fixed the output of popt errors and changed our one option to be
--iterations (-i).
Wayne Davison [Sat, 5 Jul 2003 19:14:10 +0000 (19:14 +0000)]
A wildtest change to handle someone using the included popt lib.
Wayne Davison [Sat, 5 Jul 2003 19:06:49 +0000 (19:06 +0000)]
Added dependencies for wildtest.o.
Wayne Davison [Sat, 5 Jul 2003 19:03:42 +0000 (19:03 +0000)]
Changed some names since "depth" wasn't really the right term.
Wayne Davison [Sat, 5 Jul 2003 18:55:09 +0000 (18:55 +0000)]
Another change to the wildtest rule to make it more portable.
Wayne Davison [Sat, 5 Jul 2003 18:49:38 +0000 (18:49 +0000)]
Added a --depth option to report recursion depth values.
Wayne Davison [Sat, 5 Jul 2003 18:48:34 +0000 (18:48 +0000)]
Improved the ABORT logic to allow aborting consecutive "*" wildcards
back to a "**" wildcard. Added optional debug code for recursion stats.
Wayne Davison [Sat, 5 Jul 2003 18:46:02 +0000 (18:46 +0000)]
Changed the build rule for wildtest.
Wayne Davison [Sat, 5 Jul 2003 17:30:53 +0000 (17:30 +0000)]
Added in the ABORT optimization logic from a newer wildmat release,
adapted for our code that distinguishes "**" from "*".
Wayne Davison [Sat, 5 Jul 2003 07:39:57 +0000 (07:39 +0000)]
Restored an isdigit() check in the match_address() function, but check
the last character in the hostname, not the first.
Wayne Davison [Sat, 5 Jul 2003 07:22:13 +0000 (07:22 +0000)]
A couple comment tweaks.
Wayne Davison [Sat, 5 Jul 2003 07:09:31 +0000 (07:09 +0000)]
Changed "diff -u" back to "diff -c" (for portability).
Wayne Davison [Sat, 5 Jul 2003 07:03:56 +0000 (07:03 +0000)]
Change most SAME-AS-FNMATCH "false" values to "true" (since we _should_
work the same as fnmatch in most cases, if fnmatch was actually working
right).
Wayne Davison [Sat, 5 Jul 2003 06:56:16 +0000 (06:56 +0000)]
Get rid of a couple compiler warnings.
Wayne Davison [Sat, 5 Jul 2003 06:53:41 +0000 (06:53 +0000)]
Don't define COMPARE_WITH_FNMATCH by default.
Wayne Davison [Sat, 5 Jul 2003 00:13:38 +0000 (00:13 +0000)]
Include lib/wildmatch.h directly for now (until we make h include
it for us).
Wayne Davison [Sat, 5 Jul 2003 00:08:11 +0000 (00:08 +0000)]
Test the new wildmatch() routine using the wildtest executable.