Wayne Davison [Wed, 4 Feb 2004 16:33:34 +0000 (16:33 +0000)]
Added geteuid to the functions to check.
Wayne Davison [Wed, 4 Feb 2004 16:27:47 +0000 (16:27 +0000)]
Another improvement to the debug info we output.
Wayne Davison [Wed, 4 Feb 2004 07:32:48 +0000 (07:32 +0000)]
Set the "max verbosity" global to 9.
Wayne Davison [Wed, 4 Feb 2004 07:32:12 +0000 (07:32 +0000)]
Use the new lp_max_verbosity() value to limit the server's "verbose"
value.
Wayne Davison [Wed, 4 Feb 2004 07:31:29 +0000 (07:31 +0000)]
Added "max verbosity" global parameter that allows you to configure
a higher debug level instead of the default of level-l verbosity.
Wayne Davison [Wed, 4 Feb 2004 07:24:13 +0000 (07:24 +0000)]
Tweaked the new debug-logging strings.
Wayne Davison [Wed, 4 Feb 2004 06:15:24 +0000 (06:15 +0000)]
Turned on 4 -v options for some build-farm testing.
Wayne Davison [Wed, 4 Feb 2004 05:34:29 +0000 (05:34 +0000)]
If we encounter an error, output the rsyncd.log file, if it exists.
Wayne Davison [Wed, 4 Feb 2004 03:58:19 +0000 (03:58 +0000)]
Temporarily switch to 4 -v options.
Wayne Davison [Wed, 4 Feb 2004 03:52:51 +0000 (03:52 +0000)]
Delay the output the (verbose > 3) list of files until we've had a
chance to map the uid/gid info in the receiver.
Wayne Davison [Wed, 4 Feb 2004 03:50:16 +0000 (03:50 +0000)]
Output some debug info if verbose > 3.
Wayne Davison [Wed, 4 Feb 2004 03:28:22 +0000 (03:28 +0000)]
If we're dumping the file list (i.e. verbose > 3), mention the uid and/or
gid (depending on applicability).
Wayne Davison [Wed, 4 Feb 2004 03:25:18 +0000 (03:25 +0000)]
Changed the -x code to allow -L to copy a file on another filesystem
that is pointed to by a symlink on our exclusive filesystem.
Wayne Davison [Wed, 4 Feb 2004 03:01:32 +0000 (03:01 +0000)]
Fixed a dropped '-'.
Wayne Davison [Tue, 3 Feb 2004 23:28:19 +0000 (23:28 +0000)]
Added a little more compatibility code for non-standard systems.
Wayne Davison [Tue, 3 Feb 2004 23:04:25 +0000 (23:04 +0000)]
Some indentation fixes and the removal of some superfluous parens.
Wayne Davison [Tue, 3 Feb 2004 23:01:58 +0000 (23:01 +0000)]
Changed a couple sizeof calls and improved some string handling in
the {send,recv}_exclude_list() calls.
Wayne Davison [Tue, 3 Feb 2004 22:48:32 +0000 (22:48 +0000)]
Modified sizeof usage and eliminated trailing whitespace.
Wayne Davison [Tue, 3 Feb 2004 20:01:26 +0000 (20:01 +0000)]
Added some temporary code to try to figure out what is going wrong
on one NetBSD box in our build farm.
Wayne Davison [Tue, 3 Feb 2004 20:00:35 +0000 (20:00 +0000)]
If verbose > 2, mention it if we're setting the uid or the gid.
J.W. Schultz [Tue, 3 Feb 2004 06:21:56 +0000 (06:21 +0000)]
correct sizeof usage.
Wayne Davison [Tue, 3 Feb 2004 04:21:15 +0000 (04:21 +0000)]
Made hard-link sending compatible with pre-28 protocols again.
J.W. Schultz [Tue, 3 Feb 2004 03:42:49 +0000 (03:42 +0000)]
Corrected sizeof usage:
sizeof obj
sizeof (type)
Wayne Davison [Mon, 2 Feb 2004 22:35:07 +0000 (22:35 +0000)]
Fix for memset bug found by buildfarm.
Wayne Davison [Mon, 2 Feb 2004 22:18:23 +0000 (22:18 +0000)]
Change to try to debug a failure on the build farm.
Wayne Davison [Mon, 2 Feb 2004 21:33:10 +0000 (21:33 +0000)]
Don't warn about lack of -l support if we're the sender -- we just won't
send the receiver any symlinks.
Wayne Davison [Mon, 2 Feb 2004 21:33:06 +0000 (21:33 +0000)]
- Call init_flist().
- Got rid of the symbolic-links-warning code (it was not right, and it is
now handled in options.c).
Wayne Davison [Mon, 2 Feb 2004 21:33:03 +0000 (21:33 +0000)]
- Use as little memory as possible for the file_struct (saves another 3
bytes per file).
- Made the idev struct allocated by the group-malloc again (J.W. suggested
the proper way to align it for all systems).
- Added init_flist().
Wayne Davison [Mon, 2 Feb 2004 21:32:56 +0000 (21:32 +0000)]
Added comment about the position of file_list's "flags" var.
Wayne Davison [Mon, 2 Feb 2004 21:32:52 +0000 (21:32 +0000)]
Don't free link_u.idev.
Wayne Davison [Mon, 2 Feb 2004 21:02:13 +0000 (21:02 +0000)]
Use "%H:%M:%S" instead of "%T" in strftime() call since it looks to be
more portable.
Wayne Davison [Mon, 2 Feb 2004 18:25:37 +0000 (18:25 +0000)]
Clarify the safe/unsafe symlink options in the usage text.
Wayne Davison [Mon, 2 Feb 2004 18:23:09 +0000 (18:23 +0000)]
Clarify the various safe/unsafe symlink options.
Wayne Davison [Mon, 2 Feb 2004 07:06:54 +0000 (07:06 +0000)]
Go back to using malloc() for the hard-link data structure (for now
at least).
Wayne Davison [Mon, 2 Feb 2004 07:06:50 +0000 (07:06 +0000)]
Free the hlink data again.
Wayne Davison [Mon, 2 Feb 2004 06:52:49 +0000 (06:52 +0000)]
Make sure that the idev struct's data is 4-byte aligned.
Wayne Davison [Mon, 2 Feb 2004 05:06:36 +0000 (05:06 +0000)]
- Changed the file-list allocation to alloc all the memory we need
with one call, not with several mallocs and strdups.
- Got rid of string_area() stuff (as suggested in the "@todo").
- Enhanced free_file() to optionally free the whole struct or to
clear it (since we don't need to do both).
- Don't zero out the other flist data when we're about to free it.
Wayne Davison [Mon, 2 Feb 2004 05:06:35 +0000 (05:06 +0000)]
Don't free the hlink data (it is not separately allocated anymore).
Wayne Davison [Mon, 2 Feb 2004 05:06:34 +0000 (05:06 +0000)]
Changed args to make_file() and free_file().
Wayne Davison [Mon, 2 Feb 2004 05:06:33 +0000 (05:06 +0000)]
Added CLEAR_STRUCT and FREE_STRUCT defines.
Wayne Davison [Sun, 1 Feb 2004 17:37:14 +0000 (17:37 +0000)]
Added some missing #if SUPPORT_HARD_LINK and #if SUPPORT_LINK directives.
Wayne Davison [Sun, 1 Feb 2004 17:29:41 +0000 (17:29 +0000)]
- Fixed the bug where the --daemon option would squelch all option errors
for later parameters.
- Complain if someone passes us -l and we don't support symlinks.
Wayne Davison [Sun, 1 Feb 2004 16:28:31 +0000 (16:28 +0000)]
Changed the rdev code to have both an "rdev" variable (which always
has the full device value) and an "rdev_high" variable (which zeros
the lower byte in the last rdev value).
Wayne Davison [Sat, 31 Jan 2004 22:40:55 +0000 (22:40 +0000)]
One more improvement to the 0-flag-byte avoidance algorithm.
Wayne Davison [Sat, 31 Jan 2004 21:01:01 +0000 (21:01 +0000)]
A small optimization to the symlink-send code, and an extra sanity
check to the symlink-receive code.
Wayne Davison [Sat, 31 Jan 2004 20:24:52 +0000 (20:24 +0000)]
Fixed the test to ensure that we don't send a flag-byte of 0 to the
receiver when transferring the file list.
Wayne Davison [Sat, 31 Jan 2004 11:36:03 +0000 (11:36 +0000)]
One more minor variable-name change.
Wayne Davison [Sat, 31 Jan 2004 11:32:30 +0000 (11:32 +0000)]
Switched a buffer name in make_file() to make the code a little more
similar to what is in receive_file_entry().
Wayne Davison [Fri, 30 Jan 2004 16:14:46 +0000 (16:14 +0000)]
Fixed the optional sanitization of the files_from arg.
Wayne Davison [Wed, 28 Jan 2004 01:39:29 +0000 (01:39 +0000)]
OK, "find ... -print0 | xargs -0 ..." wasn't portable. This is.
Wayne Davison [Wed, 28 Jan 2004 00:37:55 +0000 (00:37 +0000)]
Got rid of indeterminacy in the overlapping-files.
Wayne Davison [Wed, 28 Jan 2004 00:04:57 +0000 (00:04 +0000)]
A couple more unsigned char changes to silence compiler warnings
on signed-char systems (like Solaris).
Wayne Davison [Tue, 27 Jan 2004 23:56:00 +0000 (23:56 +0000)]
New test to make sure that merging files from multiple directories
continues to work.
Wayne Davison [Tue, 27 Jan 2004 23:13:15 +0000 (23:13 +0000)]
Use who_am_i() to qualify some debug messages.
Wayne Davison [Tue, 27 Jan 2004 23:13:14 +0000 (23:13 +0000)]
Set the am_generator flag. Use who_am_i().
Wayne Davison [Tue, 27 Jan 2004 23:13:13 +0000 (23:13 +0000)]
New function: who_am_i() returns "sender", "receiver", or "generator".
Wayne Davison [Tue, 27 Jan 2004 23:13:12 +0000 (23:13 +0000)]
Added "am_generator".
Wayne Davison [Tue, 27 Jan 2004 23:00:47 +0000 (23:00 +0000)]
Don't free lastdir! It is still needed by the flist basedir pointers.
Also, output the basedir pointer when dumping the flist for debugging.
Wayne Davison [Tue, 27 Jan 2004 22:35:15 +0000 (22:35 +0000)]
Relocated the externs.
Wayne Davison [Tue, 27 Jan 2004 16:27:05 +0000 (16:27 +0000)]
Silenced some compiler warnings.
Wayne Davison [Tue, 27 Jan 2004 08:14:33 +0000 (08:14 +0000)]
Better pid handling.
Wayne Davison [Tue, 27 Jan 2004 08:02:31 +0000 (08:02 +0000)]
Cast getpid() to a long for output.
Wayne Davison [Tue, 27 Jan 2004 07:57:12 +0000 (07:57 +0000)]
Better pid handling.
Wayne Davison [Tue, 27 Jan 2004 07:48:57 +0000 (07:48 +0000)]
Fixed a comment.
Wayne Davison [Tue, 27 Jan 2004 07:48:19 +0000 (07:48 +0000)]
Tweaked the externs.
Wayne Davison [Tue, 27 Jan 2004 06:51:39 +0000 (06:51 +0000)]
Percentage of file-count output was off by one.
J.W. Schultz [Tue, 27 Jan 2004 05:00:43 +0000 (05:00 +0000)]
EXCLUDE PATTERNS is not just about syntax.
Wayne Davison [Tue, 27 Jan 2004 03:49:54 +0000 (03:49 +0000)]
Mention the latest -x improvement. Also improved the description of
one of my previous fixes.
Wayne Davison [Tue, 27 Jan 2004 01:47:41 +0000 (01:47 +0000)]
Optimized the -x option by removing the skip_filesystem() call and using the
new FLAG_MOUNT_POINT flag.
Wayne Davison [Tue, 27 Jan 2004 01:47:40 +0000 (01:47 +0000)]
Added FLAG_MOUNT_POINT.
Wayne Davison [Tue, 27 Jan 2004 01:27:37 +0000 (01:27 +0000)]
Tweaked a comment.
Wayne Davison [Tue, 27 Jan 2004 01:05:14 +0000 (01:05 +0000)]
Improved the differentiation of the transmit flags from the live flags
by naming the transmit flags with an XMIT_ prefix. Improved the names
of two other flags, got rid of the LIVE_FLAGS mask, and shortened the
flag storage in the flist struct (to save memory).
Wayne Davison [Tue, 27 Jan 2004 01:05:13 +0000 (01:05 +0000)]
Use the new names for the transmit-flag defines. We also make sure
that the FLAG_TOP_DIR flag doesn't get set in the live data for a
non-directory (when it's used as a kluge to prevent a 0x00 byte being
sent over the wire for the flag data).
Wayne Davison [Tue, 27 Jan 2004 01:05:12 +0000 (01:05 +0000)]
Use the new names for the transmit-flag defines.
Wayne Davison [Mon, 26 Jan 2004 22:35:04 +0000 (22:35 +0000)]
Fixed reference to -u that should have been -o.
J.W. Schultz [Mon, 26 Jan 2004 20:54:02 +0000 (20:54 +0000)]
Back out bad refactor (thanks Wayne)
Wayne Davison [Mon, 26 Jan 2004 04:21:59 +0000 (04:21 +0000)]
Mention new hard-link optimization.
Wayne Davison [Sun, 25 Jan 2004 22:32:11 +0000 (22:32 +0000)]
Added defines (FLAG_HLINK_EOL, HL_CHECK_MASTER, and HL_SKIP) and changed
the struct hlink to have an index into the hlink_list[] array instead of
a head pointer.
Wayne Davison [Sun, 25 Jan 2004 22:32:10 +0000 (22:32 +0000)]
We now link the hard-linked flist entries into a circular list, mark
the last item with FLAG_HLINK_EOL, and save off an index for our
master entry in the hlink_list[] array. Added the hard_link_check()
function.
Wayne Davison [Sun, 25 Jan 2004 22:32:09 +0000 (22:32 +0000)]
Use the new hard_link_check() function to figure out which one of the
hard-linked files to send (when -H was specified, of course). Moved
the call to do_hard_links() and the final directory-permissions scan
into generate_files() from recv_files().
Wayne Davison [Sun, 25 Jan 2004 22:32:08 +0000 (22:32 +0000)]
Moved the call to do_hard_links() and the final directory-permissions
scan from recv_files() into generate_files().
Wayne Davison [Sun, 25 Jan 2004 22:32:07 +0000 (22:32 +0000)]
Changed F_HEAD to F_HLINDEX.
Wayne Davison [Sun, 25 Jan 2004 22:32:05 +0000 (22:32 +0000)]
Tweaked a comment.
J.W. Schultz [Sun, 25 Jan 2004 22:11:09 +0000 (22:11 +0000)]
Tightened up code in skip_filesystem()
Wayne Davison [Sat, 24 Jan 2004 22:12:58 +0000 (22:12 +0000)]
Replaced an snprintf() call with pathjoin().
Wayne Davison [Sat, 24 Jan 2004 18:36:36 +0000 (18:36 +0000)]
The static last_in value in match_gid() needed to default to -2 so
that we don't accidentally return a GID of 0 when we don't have the
permissions to set it.
Wayne Davison [Sat, 24 Jan 2004 01:48:12 +0000 (01:48 +0000)]
Another improvement in the "use chroot" section.
Wayne Davison [Fri, 23 Jan 2004 16:58:24 +0000 (16:58 +0000)]
Refer to I/O (not IO), ID (not id), and "an rsync" (not "a rsync").
Wayne Davison [Fri, 23 Jan 2004 16:55:40 +0000 (16:55 +0000)]
Improved the "use chroot" discussion on ID mapping.
Wayne Davison [Fri, 23 Jan 2004 16:40:17 +0000 (16:40 +0000)]
More changes to make the --owner and --group items clearer.
Wayne Davison [Fri, 23 Jan 2004 09:34:04 +0000 (09:34 +0000)]
Use "an" in front of rsync, not "a".
Wayne Davison [Fri, 23 Jan 2004 09:32:50 +0000 (09:32 +0000)]
Tweaked the --help text to refer to I/O (not IO) and use "an" in
front of rsync (not "a").
Wayne Davison [Fri, 23 Jan 2004 09:30:45 +0000 (09:30 +0000)]
Improved the "use chroot" section to mention how to get user/group
preservation by name (getting rid of the erroneous bit about the
--numeric-ids option being implied).
Wayne Davison [Fri, 23 Jan 2004 09:29:16 +0000 (09:29 +0000)]
Improved comments on --owner and --groups, and removed misinformation
on a chroot daemon (it does not imply --numeric-ids).
Wayne Davison [Fri, 23 Jan 2004 08:59:19 +0000 (08:59 +0000)]
Properly punctuate "etc." and changed all occurrences of "IO" to "I/O".
Wayne Davison [Fri, 23 Jan 2004 02:02:51 +0000 (02:02 +0000)]
Fixed two more misspelled words.
Wayne Davison [Fri, 23 Jan 2004 01:36:59 +0000 (01:36 +0000)]
Some spelling corrections and other simple fixes.
Wayne Davison [Thu, 22 Jan 2004 18:39:32 +0000 (18:39 +0000)]
When setting an flist entry's flags, mask it with LIVE_FLAGS.
Wayne Davison [Thu, 22 Jan 2004 18:37:26 +0000 (18:37 +0000)]
A couple comment tweaks.
Wayne Davison [Thu, 22 Jan 2004 09:16:21 +0000 (09:16 +0000)]
Made the getgroups() code a little more portable. This will hopefully
make the chgrp test work on the NetBSD and OpenBSD systems where it is
failing.