Andrew Tridgell [Thu, 27 Aug 1998 05:07:52 +0000 (05:07 +0000)]
removed the limit on the read buffer size until I fully understand the
interactions with ssh. The old ssh freezes have shown up again and
some debugging (with help from James Welborn) showed that the cause
was the read buffer hitting maximum size. I think this means that ssh
must be misbehaving about blocking IO.
This change gets rid of the freezes at the expense of memory
usage. Where it would have frozen it uses more memory instead.
Andrew Tridgell [Thu, 27 Aug 1998 05:05:14 +0000 (05:05 +0000)]
a couple of changes to where the nonblocking settings are called.
Andrew Tridgell [Sat, 25 Jul 1998 09:20:33 +0000 (09:20 +0000)]
fix PATTERN/FILE in --help output
Andrew Tridgell [Sat, 25 Jul 1998 02:25:22 +0000 (02:25 +0000)]
c was getting a bit unwieldy so I split the code into 3 modules,
for the 3 logical stages of rsync; generator, sender and receiver.
Andrew Tridgell [Thu, 23 Jul 1998 03:09:14 +0000 (03:09 +0000)]
fixed the relative paths bug pointed out by Alberto Accomazzi
rsync-bugs [Mon, 20 Jul 1998 05:43:51 +0000 (05:43 +0000)]
preparing for release of 2.1.0
Andrew Tridgell [Mon, 20 Jul 1998 05:36:25 +0000 (05:36 +0000)]
I think I might havefinally fixed the rsync hanging bug. It was caused
by a read during an io_flush() triggered during a readfd(). A simple
logic bug in the io code :(
Andrew Tridgell [Sun, 19 Jul 1998 10:51:26 +0000 (10:51 +0000)]
always use a timeout to select, even if --timeout is not
specified. This makes things easier to debug.
Andrew Tridgell [Sun, 19 Jul 1998 05:22:05 +0000 (05:22 +0000)]
- defer the error message from the options parsing until after the
socket is multiplexed. This allows clients sending new options which
the remote server doesn't understand to get a sensible error message.
Andrew Tridgell [Sun, 19 Jul 1998 04:50:48 +0000 (04:50 +0000)]
- close stdout and stderr and reopen then as /dev/null when running as
a daemon. This prevents library functions (such as getopt) stuffing up
our protocol stream when errors are detected.
- defer the error message from the options parsing until after the
socket is multiplexed. This allows clients sending new options which
the remote server doesn't understand to get a sensible error message.
rsync-bugs [Fri, 17 Jul 1998 14:53:00 +0000 (14:53 +0000)]
preparing for release of 2.0.19
Andrew Tridgell [Fri, 17 Jul 1998 14:42:59 +0000 (14:42 +0000)]
handle hard links on systems with 16 bit ino_t
Andrew Tridgell [Fri, 17 Jul 1998 14:25:14 +0000 (14:25 +0000)]
added a bit in the man page about the clean shell error
Andrew Tridgell [Fri, 17 Jul 1998 14:05:57 +0000 (14:05 +0000)]
check whether there is a / before a : in the rsync command line. If
there is then assume that the : is from a filename, not a host:dir
separator. This allows you to copy files with a : in them. (suggestion
from pfeifer@wait.de)
Andrew Tridgell [Fri, 17 Jul 1998 13:18:32 +0000 (13:18 +0000)]
make rsync behave more like GNU cp with regard to file permissions
when -p (preserve permissions) isn't set.
It works by taking the sending file permissions and masking them with
the umask to create the destination file permissions. (There is really
no "correct" way of doing this but at least we now behave like GNU cp
which fits the principle of least surprise.)
also fixed a race condition in copy_file()
Andrew Tridgell [Fri, 17 Jul 1998 10:00:48 +0000 (10:00 +0000)]
added the --safe-links option to disallow symlinks outside the
destination tree
Andrew Tridgell [Fri, 17 Jul 1998 10:00:43 +0000 (10:00 +0000)]
added the --safe-links option to disallow symlinks outside the
destination tree
Andrew Tridgell [Fri, 17 Jul 1998 07:42:04 +0000 (07:42 +0000)]
some code reformatting
Andrew Tridgell [Fri, 17 Jul 1998 07:26:08 +0000 (07:26 +0000)]
removed old "make dist" target
Andrew Tridgell [Fri, 17 Jul 1998 07:25:42 +0000 (07:25 +0000)]
changed wording of an error message
Andrew Tridgell [Fri, 17 Jul 1998 07:17:11 +0000 (07:17 +0000)]
moved getopt.h above unistd.h to prevent problems with uwin on NT
Andrew Tridgell [Fri, 17 Jul 1998 07:07:23 +0000 (07:07 +0000)]
fixed a problem with rsync buffering the debug output when redirected
to a file.
Andrew Tridgell [Fri, 17 Jul 1998 05:38:51 +0000 (05:38 +0000)]
make a function static
Andrew Tridgell [Fri, 17 Jul 1998 05:38:21 +0000 (05:38 +0000)]
remove a useless debug message
Andrew Tridgell [Fri, 17 Jul 1998 05:37:56 +0000 (05:37 +0000)]
code style change
Andrew Tridgell [Fri, 17 Jul 1998 05:37:18 +0000 (05:37 +0000)]
use error to detect lockfile open failures vs. max connections reached
and report an appropriate error message
Andrew Tridgell [Thu, 2 Jul 1998 10:57:20 +0000 (10:57 +0000)]
- use explicit flushes instead of setlinebuf. I've had reports of
verbose info not being line buffered to files.
- add a call to localtime() in open_log() in order to prime the C
libraries timezone cache before the chroot(). This should fix the
problem of rsyncd log entries being in GMT time.
Andrew Tridgell [Thu, 2 Jul 1998 03:02:14 +0000 (03:02 +0000)]
remove a redundent continue statement
Andrew Tridgell [Thu, 2 Jul 1998 02:59:04 +0000 (02:59 +0000)]
prioritise reading over writing in the select loop. (this is another
ssh-friendly attempt)
Andrew Tridgell [Thu, 2 Jul 1998 02:48:09 +0000 (02:48 +0000)]
fix the problem of --timeout waiting for twice the specified time.
Andrew Tridgell [Thu, 2 Jul 1998 02:08:55 +0000 (02:08 +0000)]
- don't show "created directory" message unless verbose is selected
- check for null buf in show_progress
Andrew Tridgell [Thu, 2 Jul 1998 01:28:39 +0000 (01:28 +0000)]
output progress % every 1k instead of every 1%, this is better for
large files.
Andrew Tridgell [Thu, 2 Jul 1998 01:27:51 +0000 (01:27 +0000)]
the recv_generator can be static
Andrew Tridgell [Thu, 2 Jul 1998 01:27:14 +0000 (01:27 +0000)]
enable output buffering in the recv generator. This makes a
significant difference when the transport is ssh as ssh will otherwise
output a complete frame for each checksum record, which increases the
checksum data in size by a factor of around 4.
Andrew Tridgell [Thu, 2 Jul 1998 00:48:20 +0000 (00:48 +0000)]
don't need to send --progress option to server as the server never
prints progress info.
Andrew Tridgell [Thu, 2 Jul 1998 00:47:13 +0000 (00:47 +0000)]
added --progress option which shows the progress of transfers. This
gives bored users something to watch.
Andrew Tridgell [Wed, 1 Jul 1998 11:03:50 +0000 (11:03 +0000)]
- only keep a partial file if some literal data has been transferred,
this prevents a second interrupted transfer from reducing the size of
the transferred file.
- set SIGUSR1 to SIG_IGN early to prevent a race condition that
prevents the --partial code from working properly
Andrew Tridgell [Wed, 1 Jul 1998 05:10:42 +0000 (05:10 +0000)]
I've had reports of rsyncd leaving zombies under digital unix. This
patch tries to address the problem in two ways:
1) reinstall the SIGCHLD handler before each fork
2) reap any children not caught by the handler using waitpid with
WNOHANG.
I expect this will fix the problem.
Andrew Tridgell [Wed, 1 Jul 1998 03:36:03 +0000 (03:36 +0000)]
added a --partial option which tells rsync to keep partially
transferred files if the transfer is interrupted.
added a "options summary" section to the man page
Andrew Tridgell [Fri, 19 Jun 1998 00:55:19 +0000 (00:55 +0000)]
if we get EWOULDBLOCK on a write then reduce the amount of data we are
trying to write. This guarantees that the maximum amount of data that
can be written at any one time is written.
Andrew Tridgell [Thu, 18 Jun 1998 14:15:16 +0000 (14:15 +0000)]
use LDFLAGS in Makefile.in (fix from arndt@schoenewald.de)
Andrew Tridgell [Thu, 18 Jun 1998 13:26:10 +0000 (13:26 +0000)]
fixed chmod bug pointed out by Han Holl <jeholl@euronet.nl>
rsync-bugs [Thu, 18 Jun 1998 13:06:00 +0000 (13:06 +0000)]
preparing for release of 2.0.18
Andrew Tridgell [Thu, 18 Jun 1998 12:17:23 +0000 (12:17 +0000)]
fixed a race condition in rsync that opened a security hole. The
temporary files were being created with the same permissions as the
original file. So if the file was setuid but not owned by the user
doing the transfer then there was a window of opportunity for a
malicious user to execute it with the wrong permissions while it was
being transferred.
Thanks to snabb@epipe.fi for pointing this out.
rsync-bugs [Thu, 18 Jun 1998 10:30:48 +0000 (10:30 +0000)]
preparing for release of 2.0.17
Andrew Tridgell [Thu, 18 Jun 1998 10:03:44 +0000 (10:03 +0000)]
if as non-root we failed to update the group of a file then don't
print the file name.
Andrew Tridgell [Thu, 18 Jun 1998 09:51:44 +0000 (09:51 +0000)]
for consistency use memcpy/memset everywhere instead of bcopy/bzero
Andrew Tridgell [Thu, 18 Jun 1998 09:37:21 +0000 (09:37 +0000)]
move include of compat.h after other includes.
Andrew Tridgell [Thu, 18 Jun 1998 09:36:24 +0000 (09:36 +0000)]
change the order of chmod and chown calls so that setuid bits don't
get removed by chown calls.
Andrew Tridgell [Thu, 18 Jun 1998 09:34:56 +0000 (09:34 +0000)]
set network file descriptors non-blocking before starting main rsync
algorithm.
Andrew Tridgell [Thu, 18 Jun 1998 09:33:46 +0000 (09:33 +0000)]
handle non-blocking file descriptors for both read and write. Add a
workaround for buggy systems that say there is space to write when
there isn't.
Andrew Tridgell [Thu, 18 Jun 1998 09:32:45 +0000 (09:32 +0000)]
put set_nonblocking() code back in.
Andrew Tridgell [Thu, 18 Jun 1998 09:31:42 +0000 (09:31 +0000)]
--help changes suggested by Francois
Andrew Tridgell [Thu, 18 Jun 1998 09:30:51 +0000 (09:30 +0000)]
manpage updates, mostly suggested by Francois
Andrew Tridgell [Wed, 3 Jun 1998 02:47:52 +0000 (02:47 +0000)]
the tag table should be of type int* not tag*.
This bug resulted in rsync being much less efficient that it could be
for files with more than 64k blocks. With the adaptive block size code
giving a maximum block size of 16k this means that files larger than
1GB were handled very inefficiently. The transfer was still accurate,
just slow.
Andrew Tridgell [Wed, 3 Jun 1998 02:35:51 +0000 (02:35 +0000)]
if the user passes a block size on the command line then don't adapt
the block size.
Andrew Tridgell [Tue, 2 Jun 1998 12:50:23 +0000 (12:50 +0000)]
added note to docs saying that --stats doesn't work unless -v is used
Andrew Tridgell [Tue, 2 Jun 1998 12:46:46 +0000 (12:46 +0000)]
added some fflush() calls to make sure the statistics lines are
printed when redirecting output to a file.
rsync-bugs [Mon, 1 Jun 1998 13:49:12 +0000 (13:49 +0000)]
preparing for release of 2.0.16
Andrew Tridgell [Mon, 1 Jun 1998 13:44:06 +0000 (13:44 +0000)]
added some notes to test.sh
Andrew Tridgell [Mon, 1 Jun 1998 13:39:54 +0000 (13:39 +0000)]
replace calls to strcmp() with a u_strcmp() function that uses only
unsigned comparisons. Transferring files between two machines that
treated strcmp() differently led to the files being given the wrong
name at the destination if the filenames had characters > 128 (such as
Kanji characters) and the source and destination machines treated
strcmp() differently (ie. one treated strings as signed and the other
as unsigned).
We now treat all string comparisons for file list sorting as unsigned.
Andrew Tridgell [Mon, 1 Jun 1998 10:38:24 +0000 (10:38 +0000)]
updated the usage info
Andrew Tridgell [Mon, 1 Jun 1998 03:42:14 +0000 (03:42 +0000)]
added --stats option for verbose stats on the file transfer
rsync-bugs [Sat, 30 May 1998 02:10:18 +0000 (02:10 +0000)]
preparing for release of 2.0.15
Andrew Tridgell [Sat, 30 May 1998 02:07:36 +0000 (02:07 +0000)]
replace BAD with zBAD so it compiles on AIX
Andrew Tridgell [Sat, 30 May 1998 02:03:29 +0000 (02:03 +0000)]
cosmetic fix.
reset offset to 0 at the start of each loop so the filenames get
printed correctly when sending directories followed by local names.
Andrew Tridgell [Sat, 30 May 1998 02:02:23 +0000 (02:02 +0000)]
make sure that io_flush() doesn't call writefd_unbuffered from within
a writefd_unbuffered call!
this should fix the "decompressor lost sync" bug
Andrew Tridgell [Fri, 29 May 1998 14:36:39 +0000 (14:36 +0000)]
replaced chdir and getcwd calls with push_dir/pop_dir functions. These
are faster and don't cause problems in a chrooted environment on any
systems.
rsync-bugs [Fri, 29 May 1998 02:29:33 +0000 (02:29 +0000)]
preparing for release of 2.0.14
Andrew Tridgell [Fri, 29 May 1998 02:28:33 +0000 (02:28 +0000)]
fixed a bug in the flist sending code that caused the flist sending to
get out of sync.
Andrew Tridgell [Thu, 28 May 1998 06:40:25 +0000 (06:40 +0000)]
use Realloc instead of realloc
Andrew Tridgell [Thu, 28 May 1998 06:29:57 +0000 (06:29 +0000)]
fix realloc call for systems that don't handle realloc(NULL, ...)
Andrew Tridgell [Thu, 28 May 1998 05:05:26 +0000 (05:05 +0000)]
don't do recursive deletion if the recurse option is not selected.
Andrew Tridgell [Thu, 28 May 1998 01:58:33 +0000 (01:58 +0000)]
cosmetic fix. don't display a EOF error when displaying just the motd
from a rsync server
rsync-bugs [Wed, 27 May 1998 13:54:41 +0000 (13:54 +0000)]
preparing for release of 2.0.13
Andrew Tridgell [Wed, 27 May 1998 13:47:34 +0000 (13:47 +0000)]
reduce IO_BUFFER_SIZE by 4 bytes so when then length word gets added
it is a power of 2.
Andrew Tridgell [Wed, 27 May 1998 13:39:40 +0000 (13:39 +0000)]
added new include/exclude options to man page
Andrew Tridgell [Wed, 27 May 1998 13:05:05 +0000 (13:05 +0000)]
- always flush the IO write buffer when reading
- handle start of line in exclude properly
Andrew Tridgell [Wed, 27 May 1998 12:37:22 +0000 (12:37 +0000)]
heaps of cleanup in the io code.
we no longer use non-blocking IO, instead it uses select a lot more,
being careful to always allow for reading whenever a valid read fd is
available and chcking timeouts.
also split the file io calls into fileio.c
Andrew Tridgell [Wed, 27 May 1998 11:02:33 +0000 (11:02 +0000)]
added support for --include, --include-from and the +/- syntax
Andrew Tridgell [Wed, 27 May 1998 06:31:37 +0000 (06:31 +0000)]
new test code from Phil
Andrew Tridgell [Wed, 27 May 1998 06:30:50 +0000 (06:30 +0000)]
fixed a race condition in the --delete handling code. The bug led to
spurious error messages about not be able to delete some files.
this fix also makes --delete processing more efficient
rsync-bugs [Tue, 26 May 1998 14:45:05 +0000 (14:45 +0000)]
preparing for release of 2.0.12
Andrew Tridgell [Tue, 26 May 1998 14:39:18 +0000 (14:39 +0000)]
fixed a bug in the handling of very long filenames (longer than 255
chars) where two neighboring filenames share more than 255 characters
at the start of their names.
Andrew Tridgell [Tue, 26 May 1998 14:18:59 +0000 (14:18 +0000)]
check for munmap as well as mmap. NextStep only has mmap in standard
libs
Andrew Tridgell [Tue, 26 May 1998 14:17:27 +0000 (14:17 +0000)]
formatting changes
Andrew Tridgell [Tue, 26 May 1998 14:16:20 +0000 (14:16 +0000)]
error formatting changes
Andrew Tridgell [Sat, 23 May 1998 05:57:08 +0000 (05:57 +0000)]
- don't allow chown for the group of a file if running as a daemon and
uid!=0
- reset am_root after startup as a daemon
Andrew Tridgell [Sat, 23 May 1998 03:13:46 +0000 (03:13 +0000)]
don't treat intermediate link directories as links in the relative
path code
Andrew Tridgell [Fri, 22 May 1998 14:22:41 +0000 (14:22 +0000)]
need strchr check in configure.in
Andrew Tridgell [Fri, 22 May 1998 14:03:30 +0000 (14:03 +0000)]
use a simpler mmap() test in autoconf as we don't need all the
features of mmap that the standard test uses, and it reports Ultrix as
having no working mmap() when in fact any mmap will do what we want
for rsync.
Andrew Tridgell [Fri, 22 May 1998 13:51:26 +0000 (13:51 +0000)]
need a ifdef around some mmap code
rsync-bugs [Fri, 22 May 1998 13:46:30 +0000 (13:46 +0000)]
preparing for release of 2.0.11
Andrew Tridgell [Fri, 22 May 1998 13:27:55 +0000 (13:27 +0000)]
add a cast to initialisation of mask
Andrew Tridgell [Fri, 22 May 1998 13:02:22 +0000 (13:02 +0000)]
change WRAP to ZWRAP so it doesn't conflict with IRIX includes
Andrew Tridgell [Fri, 22 May 1998 12:20:07 +0000 (12:20 +0000)]
added a README.rsync to explain what we have changed in zlib and to
tell people that any bugs are our responsibility.
Andrew Tridgell [Fri, 22 May 1998 12:13:07 +0000 (12:13 +0000)]
no longer needed
Andrew Tridgell [Fri, 22 May 1998 12:08:49 +0000 (12:08 +0000)]
- fix redefinition of MAX
- fix shadow of variable "overflow"
Andrew Tridgell [Fri, 22 May 1998 12:07:23 +0000 (12:07 +0000)]
fix shadowed variable
Andrew Tridgell [Fri, 22 May 1998 12:06:25 +0000 (12:06 +0000)]
removing an unused variable