-After applying this patch, run these commands for a successful build:
+To use this patch, run these commands for a successful build:
+ patch -p1 <patches/atimes.diff
./prepare-source
./configure (optional if already run)
make
--- old/flist.c
+++ new/flist.c
-@@ -50,6 +50,7 @@ extern int preserve_devices;
+@@ -46,6 +46,7 @@ extern int preserve_devices;
extern int preserve_specials;
extern int preserve_uid;
extern int preserve_gid;
+extern int preserve_atimes;
extern int relative_paths;
extern int implied_dirs;
- extern int prune_empty_dirs;
-@@ -84,7 +85,13 @@ void init_flist(void)
- struct file_struct f;
-
- /* Figure out how big the file_struct is without trailing padding */
-- file_struct_len = offsetof(struct file_struct, flags) + sizeof f.flags;
-+ if (preserve_atimes)
-+ file_struct_len = offsetof(struct file_struct, fl4g5);
-+ else
-+ file_struct_len = offsetof(struct file_struct, atime);
-+ /* The "flags" uchar is no longer accessed directly, so I
-+ * mangled the name to fl4g5 as a reminder. */
-+ file_struct_len += sizeof f.fl4g5;
- checksum_len = protocol_version < 21 ? 2 : MD4_SUM_LENGTH;
- }
+ extern int ignore_perishable;
+@@ -127,6 +128,7 @@ void show_flist_stats(void)
+ static void list_file_entry(struct file_struct *f)
+ {
+ char permbuf[PERMSTRING_SIZE];
++ time_t atime = preserve_atimes ? IVAL(ATIME_PTR(f), 0) : 0;
-@@ -140,16 +147,18 @@ static void list_file_entry(struct file_
+ if (!f->basename) {
+ /* this can happen if duplicate names were removed */
+@@ -137,16 +139,18 @@ static void list_file_entry(struct file_
#ifdef SUPPORT_LINKS
if (preserve_links && S_ISLNK(f->mode)) {
+ rprintf(FINFO, "%s %11.0f %s %s %s -> %s\n",
permbuf,
(double)f->length, timestring(f->modtime),
-+ preserve_atimes ? timestring(f->atime) : "",
++ preserve_atimes ? timestring(atime) : "",
f_name(f, NULL), f->u.link);
} else
#endif
+ rprintf(FINFO, "%s %11.0f %s %s %s\n",
permbuf,
(double)f->length, timestring(f->modtime),
-+ preserve_atimes ? timestring(f->atime) : "",
++ preserve_atimes ? timestring(atime) : "",
f_name(f, NULL));
}
}
-@@ -311,6 +320,7 @@ static void send_file_entry(struct file_
+@@ -304,6 +308,7 @@ static void send_file_entry(struct file_
{
unsigned short flags;
static time_t modtime;
static mode_t mode;
static int64 dev;
static dev_t rdev;
-@@ -326,7 +336,7 @@ static void send_file_entry(struct file_
+@@ -319,7 +324,7 @@ static void send_file_entry(struct file_
if (!file) {
write_byte(f, 0);
- modtime = 0, mode = 0;
+ modtime = 0, atime = 0, mode = 0;
- dev = 0, rdev = makedev(0, 0);
+ dev = 0, rdev = MAKEDEV(0, 0);
rdev_major = 0;
uid = 0, gid = 0;
-@@ -338,7 +348,7 @@ static void send_file_entry(struct file_
-
- f_name(file, fname);
-
-- flags = file->flags & XMIT_TOP_DIR;
-+ flags = FFLAGS(file) & XMIT_TOP_DIR;
-
- if (file->mode == mode)
- flags |= XMIT_SAME_MODE;
-@@ -374,6 +384,12 @@ static void send_file_entry(struct file_
+@@ -365,6 +370,13 @@ static void send_file_entry(struct file_
flags |= XMIT_SAME_TIME;
else
modtime = file->modtime;
+ if (preserve_atimes && !S_ISDIR(mode)) {
-+ if (file->atime == atime)
++ time_t file_atime = IVAL(ATIME_PTR(file), 0);
++ if (file_atime == atime)
+ flags |= XMIT_SAME_ATIME;
+ else
-+ atime = file->atime;
++ atime = file_atime;
+ }
#ifdef SUPPORT_HARD_LINKS
if (file->link_u.idev) {
-@@ -427,6 +443,8 @@ static void send_file_entry(struct file_
+@@ -418,6 +430,8 @@ static void send_file_entry(struct file_
write_int(f, modtime);
if (!(flags & XMIT_SAME_MODE))
write_int(f, to_wire_mode(mode));
if (preserve_uid && !(flags & XMIT_SAME_UID)) {
if (!numeric_ids)
add_uid(uid);
-@@ -495,6 +513,7 @@ static struct file_struct *receive_file_
+@@ -484,6 +498,7 @@ static struct file_struct *receive_file_
unsigned short flags, int f)
{
static time_t modtime;
static mode_t mode;
static int64 dev;
static dev_t rdev;
-@@ -513,7 +532,7 @@ static struct file_struct *receive_file_
+@@ -497,12 +512,13 @@ static struct file_struct *receive_file_
+ char thisname[MAXPATHLEN];
+ unsigned int l1 = 0, l2 = 0;
+ int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
++ int atime_len;
+ OFF_T file_length;
+ char *basename, *dirname, *bp;
struct file_struct *file;
if (!flist) {
- modtime = 0, mode = 0;
+ modtime = 0, atime = 0, mode = 0;
- dev = 0, rdev = makedev(0, 0);
+ dev = 0, rdev = MAKEDEV(0, 0);
rdev_major = 0;
uid = 0, gid = 0;
-@@ -569,6 +588,8 @@ static struct file_struct *receive_file_
+@@ -558,6 +574,8 @@ static struct file_struct *receive_file_
modtime = (time_t)read_int(f);
if (!(flags & XMIT_SAME_MODE))
mode = from_wire_mode(read_int(f));
if (chmod_modes && !S_ISLNK(mode))
mode = tweak_mode(mode, chmod_modes);
-@@ -624,6 +645,8 @@ static struct file_struct *receive_file_
+@@ -600,19 +618,23 @@ static struct file_struct *receive_file_
+
+ sum_len = always_checksum && S_ISREG(mode) ? MD4_SUM_LENGTH : 0;
+
++ atime_len = preserve_atimes ? 4 : 0;
++
+ alloc_len = file_struct_len + dirname_len + basename_len
+- + linkname_len + sum_len;
++ + atime_len + linkname_len + sum_len;
+ bp = pool_alloc(flist->file_pool, alloc_len, "receive_file_entry");
+
+ file = (struct file_struct *)bp;
+ memset(bp, 0, file_struct_len);
+- bp += file_struct_len;
++ bp += file_struct_len + atime_len;
+
+ file->modtime = modtime;
+ file->length = file_length;
file->mode = mode;
file->uid = uid;
file->gid = gid;
+ if (preserve_atimes)
-+ file->atime = atime;
++ SIVAL(ATIME_PTR(file), 0, atime);
if (dirname_len) {
file->dirname = lastdir = bp;
-@@ -649,12 +672,12 @@ static struct file_struct *receive_file_
- && lastname[del_hier_name_len-1] == '.'
- && lastname[del_hier_name_len-2] == '/')
- del_hier_name_len -= 2;
-- file->flags |= FLAG_TOP_DIR | FLAG_DEL_HERE;
-+ FFLAGS(file) |= FLAG_TOP_DIR | FLAG_DEL_HERE;
- } else if (in_del_hier) {
- if (!relative_paths || !del_hier_name_len
- || (l1 >= del_hier_name_len
- && lastname[del_hier_name_len] == '/'))
-- file->flags |= FLAG_DEL_HERE;
-+ FFLAGS(file) |= FLAG_DEL_HERE;
- else
- in_del_hier = 0;
- }
-@@ -870,12 +893,14 @@ struct file_struct *make_file(char *fnam
+@@ -731,6 +753,7 @@ struct file_struct *make_file(char *fnam
+ char thisname[MAXPATHLEN];
+ char linkname[MAXPATHLEN];
+ int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
++ int atime_len;
+ char *basename, *dirname, *bp;
+
+ if (!flist || !flist->count) /* Ignore lastdir when invalid. */
+@@ -854,8 +877,10 @@ struct file_struct *make_file(char *fnam
+ sum_len = always_checksum && am_sender && S_ISREG(st.st_mode)
+ ? MD4_SUM_LENGTH : 0;
+
++ atime_len = preserve_atimes ? 4 : 0;
++
+ alloc_len = file_struct_len + dirname_len + basename_len
+- + linkname_len + sum_len;
++ + atime_len + linkname_len + sum_len;
+ if (flist)
+ bp = pool_alloc(flist->file_pool, alloc_len, "make_file");
+ else {
+@@ -865,7 +890,7 @@ struct file_struct *make_file(char *fnam
+
+ file = (struct file_struct *)bp;
memset(bp, 0, file_struct_len);
- bp += file_struct_len;
+- bp += file_struct_len;
++ bp += file_struct_len + atime_len;
-- file->flags = flags;
-+ FFLAGS(file) = flags;
+ file->flags = flags;
file->modtime = st.st_mtime;
- file->length = st.st_size;
+@@ -873,6 +898,8 @@ struct file_struct *make_file(char *fnam
file->mode = st.st_mode;
file->uid = st.st_uid;
file->gid = st.st_gid;
+ if (preserve_atimes)
-+ file->atime = st.st_atime;
++ SIVAL(ATIME_PTR(file), 0, st.st_atime);
#ifdef SUPPORT_HARD_LINKS
if (flist && flist->hlink_pool) {
-@@ -988,7 +1013,7 @@ static void send_if_directory(int f, str
- char is_dot_dir = fbuf[ol-1] == '.' && (ol == 1 || fbuf[ol-2] == '/');
-
- if (S_ISDIR(file->mode)
-- && !(file->flags & FLAG_MOUNT_POINT) && f_name(file, fbuf)) {
-+ && !(FFLAGS(file) & FLAG_MOUNT_POINT) && f_name(file, fbuf)) {
- void *save_filters;
- unsigned int len = strlen(fbuf);
- if (len > 1 && fbuf[len-1] == '/')
-@@ -1594,8 +1619,9 @@ static void clean_flist(struct file_list
+@@ -1595,8 +1622,9 @@ static void clean_flist(struct file_list
}
/* Make sure we don't lose track of a user-specified
* top directory. */
- flist->files[keep]->flags |= flist->files[drop]->flags
- & (FLAG_TOP_DIR|FLAG_DEL_HERE);
-+ FFLAGS(flist->files[keep])
-+ |= FFLAGS(flist->files[drop])
++ flist->files[keep]->flags
++ |= flist->files[drop]->flags
+ & (FLAG_TOP_DIR|FLAG_DEL_HERE);
clear_file(flist->files[drop], flist);
-@@ -1719,7 +1745,7 @@ static void output_flist(struct file_lis
- file->dirname ? file->dirname : "",
- file->dirname ? "/" : "", NS(file->basename),
- S_ISDIR(file->mode) ? "/" : "", (int)file->mode,
-- (double)file->length, uidbuf, gidbuf, file->flags);
-+ (double)file->length, uidbuf, gidbuf, FFLAGS(file));
- }
- }
-
--- old/generator.c
+++ new/generator.c
-@@ -44,6 +44,7 @@ extern int preserve_perms;
+@@ -43,6 +43,7 @@ extern int preserve_perms;
extern int preserve_uid;
extern int preserve_gid;
extern int preserve_times;
extern struct file_list *the_file_list;
extern struct filter_list_struct server_filter_list;
-@@ -184,7 +186,7 @@ static int delete_item(char *fname, int
- for (j = dirlist->count; j--; ) {
- struct file_struct *fp = dirlist->files[j];
-
-- if (fp->flags & FLAG_MOUNT_POINT)
-+ if (FFLAGS(fp) & FLAG_MOUNT_POINT)
- continue;
-
- strlcpy(p, fp->basename, remainder);
-@@ -262,7 +264,7 @@ static void delete_in_dir(struct file_li
- filt_array[cur_depth] = push_local_filters(fbuf, dlen);
-
- if (one_file_system) {
-- if (file->flags & FLAG_TOP_DIR)
-+ if (FFLAGS(file) & FLAG_TOP_DIR)
- filesystem_dev = stp->st_dev;
- else if (filesystem_dev != stp->st_dev)
- return;
-@@ -274,7 +276,7 @@ static void delete_in_dir(struct file_li
- * from the filesystem. */
- for (i = dirlist->count; i--; ) {
- struct file_struct *fp = dirlist->files[i];
-- if (!fp->basename || fp->flags & FLAG_MOUNT_POINT)
-+ if (!fp->basename || FFLAGS(fp) & FLAG_MOUNT_POINT)
- continue;
- if (flist_find(flist, fp) < 0) {
- f_name(fp, delbuf);
-@@ -300,11 +302,11 @@ static void do_delete_pass(struct file_l
- for (j = 0; j < flist->count; j++) {
- struct file_struct *file = flist->files[j];
-
-- if (!(file->flags & FLAG_DEL_HERE))
-+ if (!(FFLAGS(file) & FLAG_DEL_HERE))
- continue;
-
- f_name(file, fbuf);
-- if (verbose > 1 && file->flags & FLAG_TOP_DIR)
-+ if (verbose > 1 && FFLAGS(file) & FLAG_TOP_DIR)
- rprintf(FINFO, "deleting in %s\n", fbuf);
-
- if (link_stat(fbuf, &st, keep_dirlinks) < 0
-@@ -348,6 +350,9 @@ void itemize(struct file_struct *file, i
- && (!(iflags & ITEM_XNAME_FOLLOWS) || *xname))
- || (keep_time && cmp_time(file->modtime, st->st_mtime) != 0))
+@@ -409,6 +411,9 @@ void itemize(struct file_struct *file, i
+ && (!(iflags & ITEM_XNAME_FOLLOWS) || *xname))
+ || (keep_time && cmp_time(file->modtime, st->st_mtime) != 0))
iflags |= ITEM_REPORT_TIME;
+ if (preserve_atimes && !S_ISDIR(file->mode) && !S_ISLNK(file->mode)
-+ && cmp_time(file->atime, st->st_atime) != 0)
++ && cmp_time(IVAL(ATIME_PTR(file), 0), st->st_atime) != 0)
+ iflags |= ITEM_REPORT_ATIME;
if ((file->mode & CHMOD_BITS) != (st->st_mode & CHMOD_BITS))
iflags |= ITEM_REPORT_PERMS;
if (preserve_uid && am_root && file->uid != st->st_uid)
-@@ -549,7 +554,7 @@ static int find_fuzzy(struct file_struct
- uint32 dist;
-
- if (!S_ISREG(fp->mode) || !fp->length
-- || fp->flags & FLAG_NO_FUZZY)
-+ || FFLAGS(fp) & FLAG_NO_FUZZY)
- continue;
-
- name = fp->basename;
-@@ -658,6 +663,8 @@ static int try_dests_reg(struct file_str
- itemizing && verbose > 1,
- code) < 0)
+@@ -720,6 +725,8 @@ static int try_dests_reg(struct file_str
+ if (hard_link_one(file, ndx, fname, 0, stp,
+ cmpbuf, 1, i, code) < 0)
goto try_a_copy;
+ if (preserve_atimes)
+ set_file_attrs(fname, file, stp, 0);
- if (preserve_hard_links && file->link_u.links)
- hard_link_cluster(file, ndx, itemizing, code);
- } else if (itemizing)
-@@ -906,7 +913,7 @@ static void recv_generator(char *fname,
- && verbose && code && f_out != -1)
- rprintf(code, "%s/\n", fname);
- if (delete_during && f_out != -1 && !phase && dry_run < 2
-- && (file->flags & FLAG_DEL_HERE))
-+ && (FFLAGS(file) & FLAG_DEL_HERE))
- delete_in_dir(the_file_list, fname, file, &st);
- return;
- }
-@@ -1188,7 +1195,7 @@ static void recv_generator(char *fname,
- if (fuzzy_dirlist) {
- int j = flist_find(fuzzy_dirlist, file);
- if (j >= 0) /* don't use changing file as future fuzzy basis */
-- fuzzy_dirlist->files[j]->flags |= FLAG_NO_FUZZY;
-+ FFLAGS(fuzzy_dirlist->files[j]) |= FLAG_NO_FUZZY;
- }
-
- /* open the file */
---- old/hlink.c
-+++ new/hlink.c
-@@ -25,6 +25,7 @@ extern int link_dest;
- extern int make_backups;
- extern int log_format_has_i;
- extern char *basis_dir[];
-+extern unsigned int file_struct_len;
- extern struct file_list *the_file_list;
-
- #ifdef SUPPORT_HARD_LINKS
-@@ -85,10 +86,10 @@ static void link_idev_data(void)
- FPTR(cur)->link_u.links = pool_talloc(hlink_pool,
- struct hlink, 1, "hlink_list");
-
-- FPTR(head)->flags |= FLAG_HLINK_TOL;
-+ FFLAGS(FPTR(head)) |= FLAG_HLINK_TOL;
- FPTR(cur)->F_HLINDEX = to;
- FPTR(cur)->F_NEXT = head;
-- FPTR(cur)->flags |= FLAG_HLINK_EOL;
-+ FFLAGS(FPTR(cur)) |= FLAG_HLINK_EOL;
- hlink_list[to++] = head;
- } else
- FPTR(cur)->link_u.links = NULL;
-@@ -174,7 +175,7 @@ int hard_link_check(struct file_struct *
- {
- #ifdef SUPPORT_HARD_LINKS
- int head;
-- if (skip && !(file->flags & FLAG_HLINK_EOL))
-+ if (skip && !(FFLAGS(file) & FLAG_HLINK_EOL))
- head = hlink_list[file->F_HLINDEX] = file->F_NEXT;
- else
- head = hlink_list[file->F_HLINDEX];
-@@ -269,8 +270,8 @@ void hard_link_cluster(struct file_struc
- file->F_HLINDEX = FINISHED_LINK;
- if (link_stat(f_name(file, hlink1), &st1, 0) < 0)
- return;
-- if (!(file->flags & FLAG_HLINK_TOL)) {
-- while (!(file->flags & FLAG_HLINK_EOL)) {
-+ if (!(FFLAGS(file) & FLAG_HLINK_TOL)) {
-+ while (!(FFLAGS(file) & FLAG_HLINK_EOL)) {
- ndx = file->F_NEXT;
- file = FPTR(ndx);
- }
-@@ -285,6 +286,6 @@ void hard_link_cluster(struct file_struc
- maybe_hard_link(file, ndx, hlink2, statret, &st2,
- hlink1, &st1, itemizing, code);
- file->F_HLINDEX = FINISHED_LINK;
-- } while (!(file->flags & FLAG_HLINK_EOL));
-+ } while (!(FFLAGS(file) & FLAG_HLINK_EOL));
- #endif
- }
+ if (preserve_hard_links && file->link_u.links) {
+ if (dry_run)
+ file->link_u.links->link_dest_used = j + 1;
--- old/log.c
+++ new/log.c
-@@ -42,6 +42,7 @@ extern int msg_fd_out;
+@@ -37,6 +37,7 @@ extern int msg_fd_out;
extern int allow_8bit_chars;
extern int protocol_version;
extern int preserve_times;
+extern int preserve_atimes;
- extern int log_format_has_i;
- extern int log_format_has_o_or_i;
- extern int daemon_log_format_has_o_or_i;
-@@ -608,7 +609,8 @@ static void log_formatted(enum logcode c
+ extern int stdout_format_has_i;
+ extern int stdout_format_has_o_or_i;
+ extern int logfile_format_has_i;
+@@ -606,7 +607,8 @@ static void log_formatted(enum logcode c
n[5] = !(iflags & ITEM_REPORT_PERMS) ? '.' : 'p';
n[6] = !(iflags & ITEM_REPORT_OWNER) ? '.' : 'o';
n[7] = !(iflags & ITEM_REPORT_GROUP) ? '.' : 'g';
if (iflags & (ITEM_IS_NEW|ITEM_MISSING_DATA)) {
--- old/options.c
+++ new/options.c
-@@ -53,6 +53,7 @@ int preserve_uid = 0;
+@@ -55,6 +55,7 @@ int preserve_uid = 0;
int preserve_gid = 0;
int preserve_times = 0;
int omit_dir_times = 0;
int update_only = 0;
int cvs_exclude = 0;
int dry_run = 0;
-@@ -301,8 +302,9 @@ void usage(enum logcode F)
+@@ -311,8 +312,9 @@ void usage(enum logcode F)
rprintf(F," --devices preserve device files (super-user only)\n");
rprintf(F," --specials preserve special files\n");
rprintf(F," -D same as --devices --specials\n");
rprintf(F," --super receiver attempts super-user activities\n");
rprintf(F," -S, --sparse handle sparse files efficiently\n");
rprintf(F," -n, --dry-run show what would have been transferred\n");
-@@ -413,6 +415,9 @@ static struct poptOption long_options[]
+@@ -428,6 +430,9 @@ static struct poptOption long_options[]
{"times", 't', POPT_ARG_VAL, &preserve_times, 1, 0, 0 },
{"no-times", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
{"no-t", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
{"omit-dir-times", 'O', POPT_ARG_VAL, &omit_dir_times, 2, 0, 0 },
{"modify-window", 0, POPT_ARG_INT, &modify_window, OPT_MODIFY_WINDOW, 0, 0 },
{"super", 0, POPT_ARG_VAL, &am_root, 2, 0, 0 },
-@@ -1519,6 +1524,8 @@ void server_options(char **args,int *arg
+@@ -1538,6 +1543,8 @@ void server_options(char **args,int *arg
argstr[x++] = 'D';
if (preserve_times)
argstr[x++] = 't';
else if (preserve_executability && am_sender)
--- old/rsync.c
+++ new/rsync.c
-@@ -35,6 +35,7 @@ extern int dry_run;
- extern int daemon_log_format_has_i;
+@@ -34,6 +34,7 @@ extern int verbose;
+ extern int dry_run;
extern int preserve_perms;
extern int preserve_executability;
+extern int preserve_atimes;
extern int preserve_times;
extern int omit_dir_times;
extern int am_root;
-@@ -128,6 +129,7 @@ int set_file_attrs(char *fname, struct f
+@@ -49,6 +50,7 @@ extern int keep_dirlinks;
+ extern int make_backups;
+ extern mode_t orig_umask;
+ extern struct stats stats;
++extern unsigned int file_struct_len;
+ extern struct chmod_mode_struct *daemon_chmod_modes;
+
+ #if defined HAVE_ICONV_OPEN && defined HAVE_ICONV_H
+@@ -129,6 +131,7 @@ int set_file_attrs(char *fname, struct f
int updated = 0;
STRUCT_STAT st2;
int change_uid, change_gid;
+ time_t atime, mtime;
+ mode_t new_mode = file->mode;
if (!st) {
- if (dry_run)
-@@ -146,18 +148,33 @@ int set_file_attrs(char *fname, struct f
+@@ -148,18 +151,36 @@ int set_file_attrs(char *fname, struct f
}
}
+ updated = 1;
+ } else
+ mtime = st->st_mtime;
-+ if (!(flags & ATTRS_SKIP_ATIME)
-+ && cmp_time(st->st_atime, file->atime) != 0) {
-+ atime = file->atime;
-+ updated = 1;
++ if (!(flags & ATTRS_SKIP_ATIME)) {
++ time_t file_atime = IVAL(ATIME_PTR(file), 0);
++ if (cmp_time(st->st_atime, file_atime) != 0) {
++ atime = file_atime;
++ updated = 1;
++ } else
++ atime = st->st_atime;
+ } else
+ atime = st->st_atime;
+ if (updated) {
/* These flags are used in the live flist data. */
-@@ -119,6 +120,7 @@
+@@ -120,6 +121,7 @@
#define ATTRS_REPORT (1<<0)
#define ATTRS_SKIP_MTIME (1<<1)
#define FULL_FLUSH 1
#define NORMAL_FLUSH 0
-@@ -522,9 +524,12 @@ struct file_struct {
- uid_t uid;
- gid_t gid;
- mode_t mode;
-- uchar flags; /* this item MUST remain last */
-+ time_t atime; /* this MUST be second to last */
-+ uchar fl4g5; /* this item MUST remain last */
+@@ -534,6 +536,8 @@ struct file_struct {
+ uchar flags; /* this item MUST remain last */
};
-+#define FFLAGS(f) ((uchar*)(f))[file_struct_len-1]
++#define ATIME_PTR(f) (((uchar*)(f))+file_struct_len)
+
/*
* Start the flist array at FLIST_START entries and grow it
* by doubling until FLIST_LINEAR then grow by FLIST_LINEAR
--- old/rsync.yo
+++ new/rsync.yo
-@@ -327,8 +327,9 @@ to the detailed description below for a
+@@ -328,8 +328,9 @@ to the detailed description below for a
--devices preserve device files (super-user only)
--specials preserve special files
-D same as --devices --specials
--super receiver attempts super-user activities
-S, --sparse handle sparse files efficiently
-n, --dry-run show what would have been transferred
-@@ -851,6 +852,12 @@ it is preserving modification times (see
+@@ -869,6 +870,12 @@ it is preserving modification times (see
the directories on the receiving side, it is a good idea to use bf(-O).
This option is inferred if you use bf(--backup) without bf(--backup-dir).
dit(bf(--super)) This tells the receiving side to attempt super-user
activities even if the receiving rsync wasn't run by the super-user. These
activities include: preserving users via the bf(--owner) option, preserving
-@@ -1366,7 +1373,7 @@ with older versions of rsync, but that a
+@@ -1396,7 +1403,7 @@ with older versions of rsync, but that a
verbose messages).
The "%i" escape has a cryptic output that is 9 letters long. The general
type of update being done, bf(X) is replaced by the file-type, and the
other letters represent attributes that may be output if they are being
modified.
-@@ -1406,7 +1413,7 @@ quote(itemize(
+@@ -1436,7 +1443,7 @@ quote(itemization(
by the file transfer.
it() A bf(t) means the modification time is different and is being updated
to the sender's value (requires bf(--times)). An alternate value of bf(T)
anytime a symlink is transferred, or when a file or device is transferred
without bf(--times).
it() A bf(p) means the permissions are different and are being updated to
-@@ -1415,7 +1422,10 @@ quote(itemize(
+@@ -1445,7 +1452,10 @@ quote(itemization(
sender's value (requires bf(--owner) and super-user privileges).
it() A bf(g) means the group is different and is being updated to the
sender's value (requires bf(--group) and the authority to set the group).
One other output is possible: when deleting files, the "%i" will output
--- old/sender.c
+++ new/sender.c
-@@ -38,6 +38,7 @@ extern int do_progress;
+@@ -41,6 +41,7 @@ extern int do_progress;
extern int inplace;
extern int batch_fd;
extern int write_batch;
+extern unsigned int file_struct_len;
extern struct stats stats;
extern struct file_list *the_file_list;
- extern char *log_format;
-@@ -126,7 +127,7 @@ void successful_send(int ndx)
-
- file = the_file_list->files[ndx];
- /* The generator might tell us about symlinks we didn't send. */
-- if (!(file->flags & FLAG_SENT) && !S_ISLNK(file->mode))
-+ if (!(FFLAGS(file) & FLAG_SENT) && !S_ISLNK(file->mode))
- return;
- if (file->dir.root) {
- offset = stringjoin(fname, sizeof fname,
-@@ -370,7 +371,7 @@ void send_files(struct file_list *flist,
- rprintf(FINFO, "sender finished %s\n", fname);
-
- /* Flag that we actually sent this entry. */
-- file->flags |= FLAG_SENT;
-+ FFLAGS(file) |= FLAG_SENT;
- }
- make_backups = save_make_backups;
-
+ extern char *stdout_format;
--- old/testsuite/atimes.test
+++ new/testsuite/atimes.test
@@ -0,0 +1,19 @@
--- old/tls.c
+++ new/tls.c
-@@ -39,6 +39,7 @@
-
+@@ -34,6 +34,7 @@
+ * change. */
#include "rsync.h"
+#include "popt.h"
#define PROGRAM "tls"
-@@ -48,6 +49,7 @@ int read_only = 1;
+@@ -43,6 +44,8 @@ int read_only = 1;
int list_only = 0;
int preserve_perms = 0;
+static int display_atime = 0;
-
++
static void failed(char const *what, char const *where)
{
-@@ -56,14 +58,29 @@ static void failed(char const *what, cha
+ fprintf(stderr, PROGRAM ": %s %s: %s\n",
+@@ -50,12 +53,29 @@ static void failed(char const *what, cha
exit(1);
}
-+static void storetime(char *dest, time_t t)
++static void storetime(char *dest, time_t t, size_t destsize)
+{
+ if (t) {
+ struct tm *mt = gmtime(&t);
-
-+ sprintf(dest, "%04d-%02d-%02d %02d:%02d:%02d ",
++
++ snprintf(dest, destsize,
++ "%04d-%02d-%02d %02d:%02d:%02d ",
+ (int)mt->tm_year + 1900,
+ (int)mt->tm_mon + 1,
+ (int)mt->tm_mday,
+ (int)mt->tm_hour,
+ (int)mt->tm_min,
+ (int)mt->tm_sec);
-+ } else {
-+ strcpy(dest, " ");
-+ }
-+}
-
++ } else
++ strlcpy(dest, " ", destsize);
++}
++
static void list_file(const char *fname)
{
STRUCT_STAT buf;
char linkbuf[4096];
if (do_lstat(fname, &buf) < 0)
-@@ -96,19 +113,8 @@ static void list_file(const char *fname)
+@@ -88,19 +108,8 @@ static void list_file(const char *fname)
permstring(permbuf, buf.st_mode);
- if (buf.st_mtime) {
- mt = gmtime(&buf.st_mtime);
-
-- sprintf(datebuf, "%04d-%02d-%02d %02d:%02d:%02d",
+- snprintf(datebuf, sizeof datebuf,
+- "%04d-%02d-%02d %02d:%02d:%02d",
- (int)mt->tm_year + 1900,
- (int)mt->tm_mon + 1,
- (int)mt->tm_mday,
- (int)mt->tm_hour,
- (int)mt->tm_min,
- (int)mt->tm_sec);
-- } else {
-- strcpy(datebuf, " ");
-- }
-+ storetime(mtimebuf, buf.st_mtime);
-+ storetime(atimebuf, buf.st_atime);
+- } else
+- strlcpy(datebuf, " ", sizeof datebuf);
++ storetime(mtimebuf, buf.st_mtime, sizeof mtimebuf);
++ storetime(atimebuf, buf.st_atime, sizeof atimebuf);
/* TODO: Perhaps escape special characters in fname? */
-@@ -119,24 +125,55 @@ static void list_file(const char *fname)
+@@ -111,23 +120,55 @@ static void list_file(const char *fname)
(long)minor(buf.st_rdev));
} else /* NB: use double for size since it might not fit in a long. */
printf("%12.0f", (double)buf.st_size);
- datebuf, fname, linkbuf);
+ mtimebuf, display_atime && !S_ISDIR(buf.st_mode) ? atimebuf : "",
+ fname, linkbuf);
- }
-
++}
++
+static struct poptOption long_options[] = {
+ /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
+ {"atime", 'u', POPT_ARG_NONE, &display_atime, 0, 0, 0},
+ fprintf(stderr, "usage: " PROGRAM " [--atime | -u] DIR ...\n"
+ "Trivial file listing program for portably checking rsync\n");
+ exit(ret);
-+}
+ }
int
main(int argc, char *argv[])
- fprintf(stderr, "usage: " PROGRAM " DIR ...\n"
- "Trivial file listing program for portably checking rsync\n");
- return 1;
+- }
+ poptContext pc;
+ const char **extra_args;
+ int opt;
-+
+
+- for (argv++; *argv; argv++) {
+- list_file(*argv);
+ pc = poptGetContext(PROGRAM, argc, (const char **)argv,
+ long_options, 0);
+ while ((opt = poptGetNextOpt(pc)) != -1) {
+ }
}
-- for (argv++; *argv; argv++) {
-- list_file(*argv);
-- }
+ extra_args = poptGetArgs(pc);
+ if (*extra_args == NULL)
+ tls_usage(1);
+ for (; *extra_args; extra_args++)
+ list_file(*extra_args);
+ poptFreeContext(pc);
-
++
return 0;
}
--- old/util.c
+++ new/util.c
-@@ -126,7 +126,7 @@ void overflow_exit(char *str)
+@@ -121,7 +121,7 @@ NORETURN void overflow_exit(char *str)
exit_cleanup(RERR_MALLOC);
}
{
#if !defined HAVE_LUTIMES || !defined HAVE_UTIMES
if (S_ISLNK(mode))
-@@ -134,9 +134,13 @@ int set_modtime(char *fname, time_t modt
+@@ -129,9 +129,13 @@ int set_modtime(char *fname, time_t modt
#endif
if (verbose > 2) {
}
if (dry_run)
-@@ -145,7 +149,7 @@ int set_modtime(char *fname, time_t modt
+@@ -140,7 +144,7 @@ int set_modtime(char *fname, time_t modt
{
#ifdef HAVE_UTIMES
struct timeval t[2];
t[0].tv_usec = 0;
t[1].tv_sec = modtime;
t[1].tv_usec = 0;
-@@ -156,12 +160,12 @@ int set_modtime(char *fname, time_t modt
+@@ -153,12 +157,12 @@ int set_modtime(char *fname, time_t modt
return utimes(fname, t);
#elif defined HAVE_UTIMBUF
struct utimbuf tbuf;
Matt McCutchen's Web Site / rsync / rsync-patches.git / blobdiff