This patch from Sami Farin lets you specify --fsync if you want fsync()
to be called on every file we write.
---- orig/options.c 2005-10-15 16:39:46
-+++ options.c 2005-08-27 21:21:34
-@@ -41,6 +41,7 @@ int whole_file = -1;
- int append_mode = 0;
+To use this patch, run these commands for a successful build:
+
+ patch -p1 <patches/fsync.diff
+ ./configure (optional if already run)
+ make
+
+based-on: a01e3b490eb36ccf9e704840e1b6683dab867550
+diff --git a/options.c b/options.c
+--- a/options.c
++++ b/options.c
+@@ -48,6 +48,7 @@ int append_mode = 0;
int keep_dirlinks = 0;
+ int copy_dirlinks = 0;
int copy_links = 0;
+int do_fsync = 0;
int preserve_links = 0;
int preserve_hard_links = 0;
- int preserve_perms = 0;
-@@ -313,6 +314,7 @@ void usage(enum logcode F)
- rprintf(F," --partial keep partially transferred files\n");
+ int preserve_acls = 0;
+@@ -731,6 +732,7 @@ void usage(enum logcode F)
rprintf(F," --partial-dir=DIR put a partially transferred file into DIR\n");
rprintf(F," --delay-updates put all updated files into place at transfer's end\n");
+ rprintf(F," -m, --prune-empty-dirs prune empty directory chains from the file-list\n");
+ rprintf(F," --fsync fsync every written file\n");
rprintf(F," --numeric-ids don't map uid/gid values by user/group name\n");
- rprintf(F," --timeout=TIME set I/O timeout in seconds\n");
- rprintf(F," -I, --ignore-times don't skip files that match in size and mod-time\n");
-@@ -471,6 +473,7 @@ static struct poptOption long_options[]
- {"only-write-batch", 0, POPT_ARG_STRING, &batch_name, OPT_ONLY_WRITE_BATCH, 0, 0 },
- {"files-from", 0, POPT_ARG_STRING, &files_from, 0, 0, 0 },
- {"from0", '0', POPT_ARG_NONE, &eol_nulls, 0, 0, 0},
+ rprintf(F," --usermap=STRING custom username mapping\n");
+ rprintf(F," --groupmap=STRING custom groupname mapping\n");
+@@ -989,6 +991,7 @@ static struct poptOption long_options[] = {
+ {"no-timeout", 0, POPT_ARG_VAL, &io_timeout, 0, 0, 0 },
+ {"contimeout", 0, POPT_ARG_INT, &connect_timeout, 0, 0, 0 },
+ {"no-contimeout", 0, POPT_ARG_VAL, &connect_timeout, 0, 0, 0 },
+ {"fsync", 0, POPT_ARG_NONE, &do_fsync, 0, 0, 0 },
- {"numeric-ids", 0, POPT_ARG_NONE, &numeric_ids, 0, 0, 0 },
- {"timeout", 0, POPT_ARG_INT, &io_timeout, 0, 0, 0 },
{"rsh", 'e', POPT_ARG_STRING, &shell_cmd, 0, 0, 0 },
-@@ -1560,6 +1563,9 @@ void server_options(char **args,int *arg
- args[ac++] = tmpdir;
- }
+ {"rsync-path", 0, POPT_ARG_STRING, &rsync_path, 0, 0, 0 },
+ {"temp-dir", 'T', POPT_ARG_STRING, &tmpdir, 0, 0, 0 },
+@@ -2607,6 +2610,9 @@ void server_options(char **args, int *argc_p)
+ args[ac++] = tmpdir;
+ }
-+ if (do_fsync && am_sender)
-+ args[ac++] = "--fsync";
++ if (do_fsync)
++ args[ac++] = "--fsync";
+
- if (basis_dir[0] && am_sender) {
- /* the server only needs this option if it is not the sender,
- * and it may be an older version that doesn't know this
---- orig/receiver.c 2005-09-16 05:41:02
-+++ receiver.c 2005-02-20 00:17:37
-@@ -38,6 +38,7 @@ extern int keep_dirlinks;
+ if (basis_dir[0]) {
+ /* the server only needs this option if it is not the sender,
+ * and it may be an older version that doesn't know this
+diff --git a/receiver.c b/receiver.c
+--- a/receiver.c
++++ b/receiver.c
+@@ -38,6 +38,7 @@ extern int relative_paths;
extern int preserve_hard_links;
extern int preserve_perms;
- extern int io_error;
+ extern int preserve_xattrs;
+extern int do_fsync;
extern int basis_dir_cnt;
extern int make_backups;
extern int cleanup_got_literal;
-@@ -319,6 +320,12 @@ static int receive_data(int f_in, char *
- exit_cleanup(RERR_FILEIO);
- }
+@@ -337,6 +338,12 @@ static int receive_data(int f_in, char *fname_r, int fd_r, OFF_T size_r,
+ if (sum_end(file_sum1) != checksum_len)
+ overflow_exit("checksum_len"); /* Impossible... */
+ if (do_fsync && fd != -1 && fsync(fd) != 0) {
+ rsyserr(FERROR, errno, "fsync failed on %s",
+ exit_cleanup(RERR_FILEIO);
+ }
+
- sum_end(file_sum1);
-
if (mapbuf)
---- orig/t_stub.c 2005-10-16 22:38:39
-+++ t_stub.c 2005-10-18 08:16:12
-@@ -29,6 +29,7 @@
+ unmap_file(mapbuf);
+
+diff --git a/t_stub.c b/t_stub.c
+--- a/t_stub.c
++++ b/t_stub.c
+@@ -21,6 +21,7 @@
+
+ #include "rsync.h"
+
++int do_fsync = 0;
int modify_window = 0;
int module_id = -1;
int relative_paths = 0;
-+int do_fsync;
- char *partial_dir;
- struct filter_list_struct server_filter_list;
+diff --git a/util.c b/util.c
+--- a/util.c
++++ b/util.c
+@@ -27,6 +27,7 @@
---- orig/util.c 2005-10-16 22:38:40
-+++ util.c 2005-10-18 08:17:00
-@@ -32,6 +32,7 @@ extern int dry_run;
+ extern int dry_run;
extern int module_id;
++extern int do_fsync;
extern int modify_window;
extern int relative_paths;
-+extern int do_fsync;
- extern char *partial_dir;
- extern struct filter_list_struct server_filter_list;
-
-@@ -311,6 +312,12 @@ int copy_file(char *source, char *dest,
- return -1;
+ extern int preserve_xattrs;
+@@ -382,6 +383,13 @@ int copy_file(const char *source, const char *dest, int ofd, mode_t mode)
+ full_fname(source));
}
+ if (do_fsync && fsync(ofd) < 0) {
+ rsyserr(FERROR, errno, "fsync failed on %s",
+ full_fname(dest));
++ close(ofd);
+ return -1;
+ }
+
- return 0;
- }
-
+ if (close(ofd) < 0) {
+ int save_errno = errno;
+ rsyserr(FERROR_XFER, errno, "close failed on %s",
Matt McCutchen's Web Site / rsync / rsync-patches.git / blobdiff