Got rid of the extra compare_dest scan in skip_file().
[rsync/rsync-patches.git] / g2r-basis-filename.diff
index 69d050e..e299415 100644 (file)
@@ -7,87 +7,63 @@ support for multiple --compare-dest options).
 
 You must run "make proto" before compiling.
 
---- orig/generator.c   2004-07-21 23:59:35
-+++ generator.c        2004-07-22 00:05:38
-@@ -258,9 +258,9 @@ static void generate_and_send_sums(int f
+--- orig/generator.c   2004-07-29 16:08:03
++++ generator.c        2004-07-28 10:14:15
+@@ -259,9 +259,9 @@ static void generate_and_send_sums(int f
   * out.  It might be wrong.
   */
  static void recv_generator(char *fname, struct file_struct *file, int i,
 -                         int f_out)
-+                         int f_out, int f_nameout)
++                         int f_out, int f_out_name)
  {
 -      int fd;
 +      int fd = -1;
        STRUCT_STAT st;
-       int statret;
+       int statret, stat_errno;
        char *fnamecmp;
-@@ -421,8 +421,10 @@ static void recv_generator(char *fname, 
-               statret = link_stat(fnamecmpbuf, &st, 0);
-               if (!S_ISREG(st.st_mode))
-                       statret = -1;
--              if (statret == -1)
-+              if (statret == -1) {
-                       errno = saveerrno;
-+                      *fnamecmpbuf = '\0';
-+              }
- #if HAVE_LINK
-               else if (link_dest && !dry_run) {
-                       if (do_link(fnamecmpbuf, fname) != 0) {
-@@ -430,22 +432,22 @@ static void recv_generator(char *fname, 
-                                       rsyserr(FINFO, errno, "link %s => %s",
-                                               fnamecmpbuf, fname);
-                               }
--                      }
--                      fnamecmp = fnamecmpbuf;
-+                              fnamecmp = fnamecmpbuf;
-+                      } else
-+                              *fnamecmpbuf = '\0';
-               }
+@@ -437,13 +437,16 @@ static void recv_generator(char *fname, 
+                                                       safe_fname(fname));
+                                       }
+                                       fnamecmp = fnamecmpbuf;
+-                              }
++                              } else
++                                      *fnamecmpbuf = '\0';
+                       } else
  #endif
-               else
-                       fnamecmp = fnamecmpbuf;
+                               fnamecmp = fnamecmpbuf;
+                       statret = 0;
+-              }
 -      }
++              } else
++                      *fnamecmpbuf = '\0';
 +      } else
 +              *fnamecmpbuf = '\0';
  
+       if (statret == 0 && !S_ISREG(st.st_mode)) {
+               if (delete_file(fname) != 0)
+@@ -455,11 +458,9 @@ static void recv_generator(char *fname, 
        if (statret == -1) {
                if (preserve_hard_links && hard_link_check(file, HL_SKIP))
                        return;
--              if (errno == ENOENT) {
+-              if (stat_errno == ENOENT) {
 -                      write_int(f_out,i);
 -                      if (!dry_run && !read_batch)
 -                              write_sum_head(f_out, NULL);
 -              } else if (verbose > 1) {
-+              if (errno == ENOENT)
++              if (stat_errno == ENOENT)
 +                      goto notify_others;
 +              if (verbose > 1) {
-                       rsyserr(FERROR, errno,
-                               "recv_generator: failed to open %s",
+                       rsyserr(FERROR, stat_errno,
+                               "recv_generator: failed to stat %s",
                                full_fname(fname));
-@@ -454,26 +456,23 @@ static void recv_generator(char *fname, 
-       }
-       if (!S_ISREG(st.st_mode)) {
--              if (delete_file(fname) != 0) {
-+              if (delete_file(fname) != 0)
-                       return;
--              }
-               /* now pretend the file didn't exist */
-               if (preserve_hard_links && hard_link_check(file, HL_SKIP))
-                       return;
--              write_int(f_out,i);
--              if (!dry_run && !read_batch)
--                      write_sum_head(f_out, NULL);
--              return;
-+              statret = -1;
-+              goto notify_others;
+@@ -467,13 +468,13 @@ static void recv_generator(char *fname, 
+               return;
        }
  
 -      if (opt_ignore_existing && fnamecmp == fname) {
 +      if (opt_ignore_existing && !*fnamecmpbuf) {
                if (verbose > 1)
-                       rprintf(FINFO,"%s exists\n",fname);
+                       rprintf(FINFO, "%s exists\n", safe_fname(fname));
                return;
        }
  
@@ -95,8 +71,8 @@ You must run "make proto" before compiling.
 +      if (update_only && !*fnamecmpbuf
            && cmp_modtime(st.st_mtime, file->modtime) > 0) {
                if (verbose > 1)
-                       rprintf(FINFO,"%s is newer\n",fname);
-@@ -481,21 +480,17 @@ static void recv_generator(char *fname, 
+                       rprintf(FINFO, "%s is newer\n", safe_fname(fname));
+@@ -481,21 +482,17 @@ static void recv_generator(char *fname, 
        }
  
        if (skip_file(fname, file, &st)) {
@@ -122,9 +98,9 @@ You must run "make proto" before compiling.
 +      if (read_batch)
 +              goto notify_others;
  
-       /* open the file */
-       fd = do_open(fnamecmp, O_RDONLY, 0);
-@@ -506,9 +501,8 @@ static void recv_generator(char *fname, 
+       if (partial_dir) {
+               STRUCT_STAT st2;
+@@ -516,9 +513,8 @@ static void recv_generator(char *fname, 
                /* pretend the file didn't exist */
                if (preserve_hard_links && hard_link_check(file, HL_SKIP))
                        return;
@@ -136,14 +112,14 @@ You must run "make proto" before compiling.
        }
  
        if (verbose > 3) {
-@@ -519,14 +513,40 @@ static void recv_generator(char *fname, 
+@@ -529,14 +525,41 @@ static void recv_generator(char *fname, 
        if (verbose > 2)
                rprintf(FINFO, "generating and sending sums for %d\n", i);
  
 -      write_int(f_out,i);
 -      generate_and_send_sums(fd, st.st_size, f_out);
 +notify_others:
-+      if (f_nameout >= 0) {
++      if (f_out_name >= 0) {
 +              uchar lenbuf[3], *lb = lenbuf;
 +              int len = statret == -1 ? 0 : strlen(fnamecmpbuf);
 +              if (len > 0x7F) {
@@ -155,14 +131,15 @@ You must run "make proto" before compiling.
 +#endif
 +              }
 +              *lb = len;
-+              write_buf(f_nameout, lenbuf, lb - lenbuf + 1);
++              write_buf(f_out_name, lenbuf, lb - lenbuf + 1);
 +              if (len)
-+                      write_buf(f_nameout, fnamecmpbuf, len);
++                      write_buf(f_out_name, fnamecmpbuf, len);
++              io_flush(NORMAL_FLUSH); /* XXX make this more efficient! */
 +      }
 +
 +      write_int(f_out, i);
 +
-+      if (read_batch)
++      if (dry_run || read_batch)
 +              return;
  
 -      close(fd);
@@ -170,36 +147,36 @@ You must run "make proto" before compiling.
 +              generate_and_send_sums(fd, st.st_size, f_out);
 +
 +              close(fd);
-+      } else if (!dry_run)
++      } else
 +              write_sum_head(f_out, NULL);
  }
  
  
 -void generate_files(int f_out, struct file_list *flist, char *local_name)
 +void generate_files(int f_out, struct file_list *flist, char *local_name,
-+                  int f_nameout)
++                  int f_out_name)
  {
        int i;
        int phase = 0;
-@@ -567,7 +587,7 @@ void generate_files(int f_out, struct fi
+@@ -577,7 +600,7 @@ void generate_files(int f_out, struct fi
                }
  
                recv_generator(local_name ? local_name : f_name_to(file, fbuf),
 -                             file, i, f_out);
-+                             file, i, f_out, f_nameout);
++                             file, i, f_out, f_out_name);
        }
  
        phase++;
-@@ -584,7 +604,7 @@ void generate_files(int f_out, struct fi
+@@ -594,7 +617,7 @@ void generate_files(int f_out, struct fi
        while ((i = get_redo_num()) != -1) {
                struct file_struct *file = flist->files[i];
                recv_generator(local_name ? local_name : f_name_to(file, fbuf),
 -                             file, i, f_out);
-+                             file, i, f_out, f_nameout);
++                             file, i, f_out, f_out_name);
        }
  
        phase++;
-@@ -603,7 +623,7 @@ void generate_files(int f_out, struct fi
+@@ -613,7 +636,7 @@ void generate_files(int f_out, struct fi
                if (!file->basename || !S_ISDIR(file->mode))
                        continue;
                recv_generator(local_name ? local_name : f_name(file),
@@ -208,7 +185,7 @@ You must run "make proto" before compiling.
        }
  
        if (verbose > 2)
---- orig/main.c        2004-07-21 23:59:35
+--- orig/main.c        2004-07-29 16:08:03
 +++ main.c     2004-07-22 00:10:43
 @@ -58,6 +58,7 @@ extern int filesfrom_fd;
  extern pid_t cleanup_child_pid;
@@ -218,23 +195,18 @@ You must run "make proto" before compiling.
  extern char *rsync_path;
  extern char *shell_cmd;
  extern char *batch_name;
-@@ -454,20 +455,21 @@ static int do_recv(int f_in,int f_out,st
+@@ -456,7 +457,8 @@ static int do_recv(int f_in,int f_out,st
  {
        int pid;
        int status = 0;
 -      int error_pipe[2];
 +      int error_pipe[2], name_pipe[2];
-+      int need_name_pipe = compare_dest;
++      BOOL need_name_pipe = compare_dest && !dry_run;
  
        if (preserve_hard_links)
                init_hard_links(flist);
-       if (!delete_after) {
-               /* I moved this here from recv_files() to prevent a race condition */
--              if (recurse && delete_mode && !local_name && flist->count>0) {
-+              if (recurse && delete_mode && !local_name && flist->count > 0)
+@@ -467,8 +469,9 @@ static int do_recv(int f_in,int f_out,st
                        delete_files(flist);
--              }
        }
  
 -      if (fd_pair(error_pipe) < 0) {
@@ -245,7 +217,7 @@ You must run "make proto" before compiling.
                exit_cleanup(RERR_SOCKETIO);
        }
  
-@@ -475,6 +477,11 @@ static int do_recv(int f_in,int f_out,st
+@@ -476,6 +479,11 @@ static int do_recv(int f_in,int f_out,st
  
        if ((pid = do_fork()) == 0) {
                close(error_pipe[0]);
@@ -257,7 +229,7 @@ You must run "make proto" before compiling.
                if (f_in != f_out)
                        close(f_out);
  
-@@ -484,7 +491,7 @@ static int do_recv(int f_in,int f_out,st
+@@ -485,7 +493,7 @@ static int do_recv(int f_in,int f_out,st
                /* set place to send errors */
                set_msg_fd_out(error_pipe[1]);
  
@@ -266,7 +238,7 @@ You must run "make proto" before compiling.
                io_flush(FULL_FLUSH);
                report(f_in);
  
-@@ -502,6 +509,11 @@ static int do_recv(int f_in,int f_out,st
+@@ -504,6 +512,11 @@ static int do_recv(int f_in,int f_out,st
                stop_write_batch();
  
        close(error_pipe[1]);
@@ -278,7 +250,7 @@ You must run "make proto" before compiling.
        if (f_in != f_out)
                close(f_in);
  
-@@ -509,7 +521,7 @@ static int do_recv(int f_in,int f_out,st
+@@ -511,7 +524,7 @@ static int do_recv(int f_in,int f_out,st
  
        set_msg_fd_in(error_pipe[0]);
  
@@ -287,9 +259,9 @@ You must run "make proto" before compiling.
  
        get_redo_num(); /* Read final MSG_DONE and any prior messages. */
        report(-1);
---- orig/receiver.c    2004-07-22 00:07:20
-+++ receiver.c 2004-07-22 00:20:50
-@@ -320,6 +320,30 @@ static int receive_data(int f_in, char *
+--- orig/receiver.c    2004-07-29 16:08:03
++++ receiver.c 2004-07-23 21:59:07
+@@ -323,6 +323,30 @@ static int receive_data(int f_in, char *
  }
  
  
@@ -320,67 +292,78 @@ You must run "make proto" before compiling.
  static void discard_receive_data(int f_in, OFF_T length)
  {
        receive_data(f_in, NULL, -1, 0, NULL, -1, length);
-@@ -330,7 +354,8 @@ static void discard_receive_data(int f_i
+@@ -333,7 +357,8 @@ static void discard_receive_data(int f_i
   * main routine for receiver process.
   *
   * Receiver process runs on the same host as the generator process. */
 -int recv_files(int f_in, struct file_list *flist, char *local_name)
 +int recv_files(int f_in, struct file_list *flist, char *local_name,
-+             int f_name_in)
++             int f_in_name)
  {
        int next_gen_i = -1;
        int fd1,fd2;
-@@ -359,8 +384,15 @@ int recv_files(int f_in, struct file_lis
+@@ -362,8 +387,15 @@ int recv_files(int f_in, struct file_lis
                i = read_int(f_in);
                if (i == -1) {
                        if (read_batch) {
 -                              if (next_gen_i != flist->count)
 -                                      while (read_int(batch_gen_fd) != -1) {}
 +                              while (next_gen_i < flist->count) {
-+                                      if (f_name_in >= 0 && next_gen_i >= 0) {
-+                                              read_gen_name(f_name_in,
++                                      if (f_in_name >= 0 && next_gen_i >= 0) {
++                                              read_gen_name(f_in_name,
 +                                                      fnamecmpbuf, NULL);
 +                                      }
-+                                      next_gen_i = read_int(f_name_in);
++                                      next_gen_i = read_int(batch_gen_fd);
 +                                      if (next_gen_i < 0)
 +                                              break;
 +                              }
                                next_gen_i = -1;
                        }
  
-@@ -406,10 +438,12 @@ int recv_files(int f_in, struct file_lis
-               if (verbose > 2)
-                       rprintf(FINFO,"recv_files(%s)\n",fname);
+@@ -411,6 +443,10 @@ int recv_files(int f_in, struct file_lis
  
--              fnamecmp = fname;
--
                if (read_batch) {
                        while (i > next_gen_i) {
-+                              if (f_name_in >= 0 && next_gen_i >= 0) {
-+                                      read_gen_name(f_name_in, fnamecmpbuf,
++                              if (f_in_name >= 0 && next_gen_i >= 0) {
++                                      read_gen_name(f_in_name, fnamecmpbuf,
 +                                                    NULL);
 +                              }
                                next_gen_i = read_int(batch_gen_fd);
                                if (next_gen_i == -1)
                                        next_gen_i = flist->count;
-@@ -420,8 +454,14 @@ int recv_files(int f_in, struct file_lis
+@@ -421,8 +457,14 @@ int recv_files(int f_in, struct file_lis
                                discard_receive_data(f_in, file->length);
                                continue;
                        }
 +                      next_gen_i = -1;
                }
  
-+              if (f_name_in >= 0)
-+                      fnamecmp = read_gen_name(f_name_in, fnamecmpbuf, fname);
++              if (f_in_name >= 0)
++                      fnamecmp = read_gen_name(f_in_name, fnamecmpbuf, fname);
 +              else
 +                      fnamecmp = fname;
 +
                if (server_exclude_list.head
                    && check_exclude(&server_exclude_list, fname,
                                     S_ISDIR(file->mode)) < 0) {
-@@ -437,14 +477,6 @@ int recv_files(int f_in, struct file_lis
+@@ -435,13 +477,7 @@ int recv_files(int f_in, struct file_lis
+                       continue;
+               }
+-              if (partial_dir) {
+-                      if ((partialptr = partial_dir_fname(fname)) != NULL)
+-                              fnamecmp = partialptr;
+-                      else
+-                              fnamecmp = fname;
+-              } else
+-                      fnamecmp = partialptr = fname;
++              partialptr = partial_dir ? partial_dir_fname(fname) : fname;
                /* open the file */
                fd1 = do_open(fnamecmp, O_RDONLY, 0);
+@@ -451,14 +487,6 @@ int recv_files(int f_in, struct file_lis
+                       fd1 = do_open(fnamecmp, O_RDONLY, 0);
+               }
  
 -              if (fd1 == -1 && compare_dest != NULL) {
 -                      /* try the file at compare_dest instead */