Make sure that ida_list_free() doesn't call free() on a NULL pointer.
[rsync/rsync-patches.git] / acls.diff
... / ...
CommitLineData
1After applying this patch, run these commands for a successful build:
2
3 ./prepare-source
4 ./configure --enable-acl-support
5 make
6
7See the --acls (-A) option in the revised man page for a note on using this
8latest ACL-enabling patch to send files to an older ACL-enabled rsync.
9
10TODO items:
11
12- The -i option does not yet itemize changes in ACL information.
13
14- The --link-dest option might link together two files that differ just
15 in their ACL info, and if that happens the file in the --link-dest dir
16 would get its ACLs updated.
17
18--- old/Makefile.in
19+++ new/Makefile.in
20@@ -25,15 +25,15 @@ VERSION=@VERSION@
21 .SUFFIXES:
22 .SUFFIXES: .c .o
23
24-HEADERS=byteorder.h config.h errcode.h proto.h rsync.h lib/pool_alloc.h
25+HEADERS=byteorder.h config.h errcode.h proto.h rsync.h smb_acls.h lib/pool_alloc.h
26 LIBOBJ=lib/wildmatch.o lib/compat.o lib/snprintf.o lib/mdfour.o \
27- lib/permstring.o lib/pool_alloc.o @LIBOBJS@
28+ lib/permstring.o lib/pool_alloc.o lib/sysacls.o @LIBOBJS@
29 ZLIBOBJ=zlib/deflate.o zlib/inffast.o zlib/inflate.o zlib/inftrees.o \
30 zlib/trees.o zlib/zutil.o zlib/adler32.o zlib/compress.o zlib/crc32.o
31 OBJS1=rsync.o generator.o receiver.o cleanup.o sender.o exclude.o util.o \
32 main.o checksum.o match.o syscall.o log.o backup.o
33 OBJS2=options.o flist.o io.o compat.o hlink.o token.o uidlist.o socket.o \
34- fileio.o batch.o clientname.o chmod.o
35+ fileio.o batch.o clientname.o chmod.o acls.o
36 OBJS3=progress.o pipe.o
37 DAEMON_OBJ = params.o loadparm.o clientserver.o access.o connection.o authenticate.o
38 popt_OBJS=popt/findme.o popt/popt.o popt/poptconfig.o \
39--- old/acls.c
40+++ new/acls.c
41@@ -0,0 +1,1307 @@
42+/* -*- c-file-style: "linux" -*-
43+ Copyright (C) Andrew Tridgell 1996
44+ Copyright (C) Paul Mackerras 1996
45+ Copyright (C) Matt McCutchen 2006
46+ Copyright (C) Wayne Davison 2006
47+
48+ This program is free software; you can redistribute it and/or modify
49+ it under the terms of the GNU General Public License as published by
50+ the Free Software Foundation; either version 2 of the License, or
51+ (at your option) any later version.
52+
53+ This program is distributed in the hope that it will be useful,
54+ but WITHOUT ANY WARRANTY; without even the implied warranty of
55+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
56+ GNU General Public License for more details.
57+
58+ You should have received a copy of the GNU General Public License
59+ along with this program; if not, write to the Free Software
60+ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
61+*/
62+
63+/* handle passing ACLs between systems */
64+
65+#include "rsync.h"
66+#include "lib/sysacls.h"
67+
68+#ifdef SUPPORT_ACLS
69+
70+extern int am_root;
71+extern int dry_run;
72+extern int orig_umask;
73+extern int preserve_acls;
74+
75+typedef struct {
76+ id_t id;
77+ uchar access;
78+} id_access;
79+
80+typedef struct {
81+ size_t count;
82+ size_t malloced;
83+ id_access *idas;
84+} ida_list;
85+
86+#define ACL_NO_ENTRY ((uchar)0x80)
87+typedef struct {
88+ ida_list users;
89+ ida_list groups;
90+ /* These will be ACL_NO_ENTRY if there's no such entry. */
91+ uchar user_obj;
92+ uchar group_obj;
93+ uchar mask;
94+ uchar other;
95+} rsync_acl;
96+
97+static const rsync_acl rsync_acl_initializer = {
98+ {0, 0, NULL}, {0, 0, NULL},
99+ ACL_NO_ENTRY, ACL_NO_ENTRY, ACL_NO_ENTRY, ACL_NO_ENTRY
100+};
101+
102+#define OTHER_TYPE(t) (SMB_ACL_TYPE_ACCESS+SMB_ACL_TYPE_DEFAULT-(t))
103+#define BUMP_TYPE(t) ((t = OTHER_TYPE(t)) == SMB_ACL_TYPE_DEFAULT)
104+
105+/* a few useful calculations */
106+
107+static int count_racl_entries(const rsync_acl *racl)
108+{
109+ return racl->users.count + racl->groups.count
110+ + (racl->user_obj != ACL_NO_ENTRY)
111+ + (racl->group_obj != ACL_NO_ENTRY)
112+ + (racl->mask != ACL_NO_ENTRY)
113+ + (racl->other != ACL_NO_ENTRY);
114+}
115+
116+static int calc_sacl_entries(const rsync_acl *racl)
117+{
118+ return racl->users.count + racl->groups.count
119+#ifdef ACLS_NEED_MASK
120+ + 4;
121+#else
122+ + (racl->mask != ACL_NO_ENTRY) + 3;
123+#endif
124+}
125+
126+static int rsync_acl_get_perms(const rsync_acl *racl)
127+{
128+ /* Note that (ACL_NO_ENTRY & 7) is 0. */
129+ return ((racl->user_obj & 7) << 6)
130+ + (((racl->mask != ACL_NO_ENTRY ? racl->mask : racl->group_obj) & 7) << 3)
131+ + (racl->other & 7);
132+}
133+
134+static void rsync_acl_strip_perms(rsync_acl *racl)
135+{
136+ racl->user_obj = ACL_NO_ENTRY;
137+ if (racl->mask == ACL_NO_ENTRY)
138+ racl->group_obj = ACL_NO_ENTRY;
139+ else
140+ racl->mask = ACL_NO_ENTRY;
141+ racl->other = ACL_NO_ENTRY;
142+}
143+
144+static void expand_ida_list(ida_list *idal)
145+{
146+ /* First time through, 0 <= 0, so list is expanded. */
147+ if (idal->malloced <= idal->count) {
148+ id_access *new_ptr;
149+ size_t new_size = idal->malloced + 10;
150+ new_ptr = realloc_array(idal->idas, id_access, new_size);
151+ if (verbose >= 4) {
152+ rprintf(FINFO, "expand rsync_acl to %.0f bytes, did%s move\n",
153+ (double) new_size * sizeof idal->idas[0],
154+ idal->idas ? "" : " not");
155+ }
156+
157+ idal->idas = new_ptr;
158+ idal->malloced = new_size;
159+
160+ if (!idal->idas)
161+ out_of_memory("expand_ida_list");
162+ }
163+}
164+
165+static void ida_list_free(ida_list *idal)
166+{
167+ if (idal->idas) {
168+ free(idal->idas);
169+ idal->idas = NULL;
170+ idal->count = 0;
171+ idal->malloced = 0;
172+ }
173+}
174+
175+static void rsync_acl_free(rsync_acl *racl)
176+{
177+ ida_list_free(&racl->users);
178+ ida_list_free(&racl->groups);
179+}
180+
181+static int id_access_sorter(const void *r1, const void *r2)
182+{
183+ id_access *ida1 = (id_access *)r1;
184+ id_access *ida2 = (id_access *)r2;
185+ id_t rid1 = ida1->id, rid2 = ida2->id;
186+ return rid1 == rid2 ? 0 : rid1 < rid2 ? -1 : 1;
187+}
188+
189+static void sort_ida_list(ida_list *idal)
190+{
191+ if (!idal->count)
192+ return;
193+ qsort((void **)idal->idas, idal->count, sizeof idal->idas[0],
194+ &id_access_sorter);
195+}
196+
197+static BOOL unpack_smb_acl(rsync_acl *racl, SMB_ACL_T sacl)
198+{
199+ SMB_ACL_ENTRY_T entry;
200+ const char *errfun;
201+ int rc;
202+
203+ *racl = rsync_acl_initializer;
204+ errfun = "sys_acl_get_entry";
205+ for (rc = sys_acl_get_entry(sacl, SMB_ACL_FIRST_ENTRY, &entry);
206+ rc == 1;
207+ rc = sys_acl_get_entry(sacl, SMB_ACL_NEXT_ENTRY, &entry)) {
208+ SMB_ACL_TAG_T tag_type;
209+ SMB_ACL_PERMSET_T permset;
210+ uchar access;
211+ void *qualifier;
212+ id_access *ida;
213+ ida_list *idal;
214+ if ((rc = sys_acl_get_tag_type(entry, &tag_type))) {
215+ errfun = "sys_acl_get_tag_type";
216+ break;
217+ }
218+ if ((rc = sys_acl_get_permset(entry, &permset))) {
219+ errfun = "sys_acl_get_tag_type";
220+ break;
221+ }
222+ access = (sys_acl_get_perm(permset, SMB_ACL_READ) ? 4 : 0)
223+ | (sys_acl_get_perm(permset, SMB_ACL_WRITE) ? 2 : 0)
224+ | (sys_acl_get_perm(permset, SMB_ACL_EXECUTE) ? 1 : 0);
225+ /* continue == done with entry; break == store in given idal */
226+ switch (tag_type) {
227+ case SMB_ACL_USER_OBJ:
228+ if (racl->user_obj == ACL_NO_ENTRY)
229+ racl->user_obj = access;
230+ else
231+ rprintf(FINFO, "unpack_smb_acl: warning: duplicate USER_OBJ entry ignored\n");
232+ continue;
233+ case SMB_ACL_USER:
234+ idal = &racl->users;
235+ break;
236+ case SMB_ACL_GROUP_OBJ:
237+ if (racl->group_obj == ACL_NO_ENTRY)
238+ racl->group_obj = access;
239+ else
240+ rprintf(FINFO, "unpack_smb_acl: warning: duplicate GROUP_OBJ entry ignored\n");
241+ continue;
242+ case SMB_ACL_GROUP:
243+ idal = &racl->groups;
244+ break;
245+ case SMB_ACL_MASK:
246+ if (racl->mask == ACL_NO_ENTRY)
247+ racl->mask = access;
248+ else
249+ rprintf(FINFO, "unpack_smb_acl: warning: duplicate MASK entry ignored\n");
250+ continue;
251+ case SMB_ACL_OTHER:
252+ if (racl->other == ACL_NO_ENTRY)
253+ racl->other = access;
254+ else
255+ rprintf(FINFO, "unpack_smb_acl: warning: duplicate OTHER entry ignored\n");
256+ continue;
257+ default:
258+ rprintf(FINFO, "unpack_smb_acl: warning: entry with unrecognized tag type ignored\n");
259+ continue;
260+ }
261+ if (!(qualifier = sys_acl_get_qualifier(entry))) {
262+ errfun = "sys_acl_get_tag_type";
263+ rc = EINVAL;
264+ break;
265+ }
266+ expand_ida_list(idal);
267+ ida = &idal->idas[idal->count++];
268+ ida->id = *((id_t *)qualifier);
269+ ida->access = access;
270+ sys_acl_free_qualifier(qualifier, tag_type);
271+ }
272+ if (rc) {
273+ rprintf(FERROR, "unpack_smb_acl: %s(): %s\n",
274+ errfun, strerror(errno));
275+ rsync_acl_free(racl);
276+ return False;
277+ }
278+
279+ sort_ida_list(&racl->users);
280+ sort_ida_list(&racl->groups);
281+
282+ return True;
283+}
284+
285+static BOOL ida_lists_equal(const ida_list *ial1, const ida_list *ial2)
286+{
287+ id_access *ida1, *ida2;
288+ size_t count = ial1->count;
289+ if (count != ial2->count)
290+ return False;
291+ ida1 = ial1->idas;
292+ ida2 = ial2->idas;
293+ for (; count--; ida1++, ida2++) {
294+ if (ida1->access != ida2->access || ida1->id != ida2->id)
295+ return False;
296+ }
297+ return True;
298+}
299+
300+static BOOL rsync_acls_equal(const rsync_acl *racl1, const rsync_acl *racl2)
301+{
302+ return (racl1->user_obj == racl2->user_obj
303+ && racl1->group_obj == racl2->group_obj
304+ && racl1->mask == racl2->mask
305+ && racl1->other == racl2->other
306+ && ida_lists_equal(&racl1->users, &racl2->users)
307+ && ida_lists_equal(&racl1->groups, &racl2->groups));
308+}
309+
310+/* The first parameter will always be a fully-populated rsync_acl.
311+ * The second parameter will usually be a condensed rsync_acl, which means
312+ * that it might have several of its access objects set to ACL_NO_ENTRY. */
313+static BOOL rsync_acl_extended_parts_equal(const rsync_acl *racl1,
314+ const rsync_acl *racl2, mode_t m)
315+{
316+ /* We ignore any differences that chmod() can take care of. */
317+ if ((racl1->mask ^ racl2->mask) & ACL_NO_ENTRY)
318+ return False;
319+ if (racl1->mask != ACL_NO_ENTRY) {
320+ /* A condensed rsync_acl with a mask can only have no
321+ * group_obj when it was identical to the mask. This
322+ * means that it was also identical to the group attrs
323+ * from the mode. */
324+ if (racl2->group_obj == ACL_NO_ENTRY) {
325+ if (racl1->group_obj != ((m >> 3) & 7))
326+ return False;
327+ } else if (racl1->group_obj != racl2->group_obj)
328+ return False;
329+ }
330+ return ida_lists_equal(&racl1->users, &racl2->users)
331+ && ida_lists_equal(&racl1->groups, &racl2->groups);
332+}
333+
334+typedef struct {
335+ size_t count;
336+ size_t malloced;
337+ rsync_acl *racls;
338+} rsync_acl_list;
339+
340+static rsync_acl_list _rsync_acl_lists[] = {
341+ { 0, 0, NULL }, /* SMB_ACL_TYPE_ACCESS */
342+ { 0, 0, NULL } /* SMB_ACL_TYPE_DEFAULT */
343+};
344+
345+static inline rsync_acl_list *rsync_acl_lists(SMB_ACL_TYPE_T type)
346+{
347+ return &_rsync_acl_lists[type != SMB_ACL_TYPE_ACCESS];
348+}
349+
350+static void expand_rsync_acl_list(rsync_acl_list *racl_list)
351+{
352+ /* First time through, 0 <= 0, so list is expanded. */
353+ if (racl_list->malloced <= racl_list->count) {
354+ rsync_acl *new_ptr;
355+ size_t new_size;
356+ if (racl_list->malloced < 1000)
357+ new_size = racl_list->malloced + 1000;
358+ else
359+ new_size = racl_list->malloced * 2;
360+ new_ptr = realloc_array(racl_list->racls, rsync_acl, new_size);
361+ if (verbose >= 3) {
362+ rprintf(FINFO, "expand_rsync_acl_list to %.0f bytes, did%s move\n",
363+ (double) new_size * sizeof racl_list->racls[0],
364+ racl_list->racls ? "" : " not");
365+ }
366+
367+ racl_list->racls = new_ptr;
368+ racl_list->malloced = new_size;
369+
370+ if (!racl_list->racls)
371+ out_of_memory("expand_rsync_acl_list");
372+ }
373+}
374+
375+static int find_matching_rsync_acl(SMB_ACL_TYPE_T type,
376+ const rsync_acl_list *racl_list,
377+ const rsync_acl *racl)
378+{
379+ static int access_match = -1, default_match = -1;
380+ int *match = type == SMB_ACL_TYPE_ACCESS ? &access_match : &default_match;
381+ size_t count = racl_list->count;
382+
383+ /* If this is the first time through or we didn't match the last
384+ * time, then start at the end of the list, which should be the
385+ * best place to start hunting. */
386+ if (*match == -1)
387+ *match = racl_list->count - 1;
388+ while (count--) {
389+ if (rsync_acls_equal(&racl_list->racls[*match], racl))
390+ return *match;
391+ if (!(*match)--)
392+ *match = racl_list->count - 1;
393+ }
394+
395+ *match = -1;
396+ return *match;
397+}
398+
399+/* The general strategy with the tag_type <-> character mapping is that
400+ * lowercase implies that no qualifier follows, where uppercase does.
401+ * A similar idiom for the acl type (access or default) itself, but
402+ * lowercase in this instance means there's no ACL following, so the
403+ * ACL is a repeat, so the receiver should reuse the last of the same
404+ * type ACL. */
405+static void send_ida_list(int f, const ida_list *idal, char tag_char)
406+{
407+ id_access *ida;
408+ size_t count = idal->count;
409+ for (ida = idal->idas; count--; ida++) {
410+ write_byte(f, tag_char);
411+ write_byte(f, ida->access);
412+ write_int(f, ida->id);
413+ /* FIXME: sorta wasteful: we should maybe buffer as
414+ * many ids as max(ACL_USER + ACL_GROUP) objects to
415+ * keep from making so many calls. */
416+ if (tag_char == 'U')
417+ add_uid(ida->id);
418+ else
419+ add_gid(ida->id);
420+ }
421+}
422+
423+static void send_rsync_acl(int f, const rsync_acl *racl)
424+{
425+ size_t count = count_racl_entries(racl);
426+ write_int(f, count);
427+ if (racl->user_obj != ACL_NO_ENTRY) {
428+ write_byte(f, 'u');
429+ write_byte(f, racl->user_obj);
430+ }
431+ send_ida_list(f, &racl->users, 'U');
432+ if (racl->group_obj != ACL_NO_ENTRY) {
433+ write_byte(f, 'g');
434+ write_byte(f, racl->group_obj);
435+ }
436+ send_ida_list(f, &racl->groups, 'G');
437+ if (racl->mask != ACL_NO_ENTRY) {
438+ write_byte(f, 'm');
439+ write_byte(f, racl->mask);
440+ }
441+ if (racl->other != ACL_NO_ENTRY) {
442+ write_byte(f, 'o');
443+ write_byte(f, racl->other);
444+ }
445+}
446+
447+static rsync_acl _curr_rsync_acls[2];
448+
449+static const char *str_acl_type(SMB_ACL_TYPE_T type)
450+{
451+ return type == SMB_ACL_TYPE_ACCESS ? "SMB_ACL_TYPE_ACCESS"
452+ : type == SMB_ACL_TYPE_DEFAULT ? "SMB_ACL_TYPE_DEFAULT"
453+ : "unknown SMB_ACL_TYPE_T";
454+}
455+
456+/* Generate the ACL(s) for this flist entry;
457+ * ACL(s) are either sent or cleaned-up by send_acl() below. */
458+int make_acl(const struct file_struct *file, const char *fname)
459+{
460+ SMB_ACL_TYPE_T type;
461+ rsync_acl *curr_racl;
462+
463+ if (S_ISLNK(file->mode))
464+ return 1;
465+
466+ curr_racl = &_curr_rsync_acls[0];
467+ type = SMB_ACL_TYPE_ACCESS;
468+ do {
469+ SMB_ACL_T sacl;
470+ BOOL ok;
471+ if ((sacl = sys_acl_get_file(fname, type)) != 0) {
472+ ok = unpack_smb_acl(curr_racl, sacl);
473+ sys_acl_free_acl(sacl);
474+ if (!ok)
475+ return -1;
476+ /* Avoid sending a redundant group/mask value. */
477+ if (curr_racl->group_obj == curr_racl->mask
478+ && (preserve_acls == 1
479+ || (!curr_racl->users.count
480+ && !curr_racl->groups.count)))
481+ curr_racl->mask = ACL_NO_ENTRY;
482+ /* Strip access ACLs of permission-bit entries. */
483+ if (type == SMB_ACL_TYPE_ACCESS && preserve_acls == 1)
484+ rsync_acl_strip_perms(curr_racl);
485+ } else if (errno == ENOTSUP) {
486+ /* ACLs are not supported. Leave list empty. */
487+ *curr_racl = rsync_acl_initializer;
488+ } else {
489+ rprintf(FERROR, "send_acl: sys_acl_get_file(%s, %s): %s\n",
490+ fname, str_acl_type(type), strerror(errno));
491+ return -1;
492+ }
493+ curr_racl++;
494+ } while (BUMP_TYPE(type) && S_ISDIR(file->mode));
495+
496+ return 0;
497+}
498+
499+/* Send the make_acl()-generated ACLs for this flist entry,
500+ * or clean up after an flist entry that's not being sent (f == -1). */
501+void send_acl(const struct file_struct *file, int f)
502+{
503+ SMB_ACL_TYPE_T type;
504+ rsync_acl *curr_racl;
505+
506+ if (S_ISLNK(file->mode))
507+ return;
508+
509+ curr_racl = &_curr_rsync_acls[0];
510+ type = SMB_ACL_TYPE_ACCESS;
511+ do {
512+ int index;
513+ rsync_acl_list *racl_list = rsync_acl_lists(type);
514+ if (f == -1) {
515+ rsync_acl_free(curr_racl);
516+ continue;
517+ }
518+ if ((index = find_matching_rsync_acl(type, racl_list, curr_racl))
519+ != -1) {
520+ write_byte(f, type == SMB_ACL_TYPE_ACCESS ? 'a' : 'd');
521+ write_int(f, index);
522+ rsync_acl_free(curr_racl);
523+ } else {
524+ write_byte(f, type == SMB_ACL_TYPE_ACCESS ? 'A' : 'D');
525+ send_rsync_acl(f, curr_racl);
526+ expand_rsync_acl_list(racl_list);
527+ racl_list->racls[racl_list->count++] = *curr_racl;
528+ }
529+ curr_racl++;
530+ } while (BUMP_TYPE(type) && S_ISDIR(file->mode));
531+}
532+
533+/* The below stuff is only used by the receiver: */
534+
535+/* structure to hold index to rsync_acl_list member corresponding to
536+ * flist->files[i] */
537+
538+typedef struct {
539+ const struct file_struct *file;
540+ int aclidx;
541+} file_acl_index;
542+
543+typedef struct {
544+ size_t count;
545+ size_t malloced;
546+ file_acl_index *fais;
547+} file_acl_index_list;
548+
549+static file_acl_index_list _file_acl_index_lists[] = {
550+ {0, 0, NULL }, /* SMB_ACL_TYPE_ACCESS */
551+ {0, 0, NULL } /* SMB_ACL_TYPE_DEFAULT */
552+};
553+
554+static inline file_acl_index_list *file_acl_index_lists(SMB_ACL_TYPE_T type)
555+{
556+ return &_file_acl_index_lists[type != SMB_ACL_TYPE_ACCESS];
557+}
558+
559+static void expand_file_acl_index_list(file_acl_index_list *flst)
560+{
561+ /* First time through, 0 <= 0, so list is expanded. */
562+ if (flst->malloced <= flst->count) {
563+ file_acl_index *new_ptr;
564+ size_t new_size;
565+
566+ if (flst->malloced < 1000)
567+ new_size = flst->malloced + 1000;
568+ else
569+ new_size = flst->malloced * 2;
570+ new_ptr = realloc_array(flst->fais, file_acl_index, new_size);
571+ if (verbose >= 3) {
572+ rprintf(FINFO, "expand_file_acl_index_list to %.0f bytes, did%s move\n",
573+ (double) new_size * sizeof flst->fais[0],
574+ flst->fais ? "" : " not");
575+ }
576+
577+ flst->fais = new_ptr;
578+ flst->malloced = new_size;
579+
580+ if (!flst->fais)
581+ out_of_memory("expand_file_acl_index_list");
582+ }
583+}
584+
585+/* lists to hold the SMB_ACL_Ts corresponding to the rsync_acl_list entries */
586+
587+typedef struct {
588+ size_t count;
589+ size_t malloced;
590+ SMB_ACL_T *sacls;
591+} smb_acl_list;
592+
593+static smb_acl_list _smb_acl_lists[] = {
594+ { 0, 0, NULL }, /* SMB_ACL_TYPE_ACCESS */
595+ { 0, 0, NULL } /* SMB_ACL_TYPE_DEFAULT */
596+};
597+
598+static inline smb_acl_list *smb_acl_lists(SMB_ACL_TYPE_T type)
599+{
600+ return &_smb_acl_lists[type != SMB_ACL_TYPE_ACCESS];
601+}
602+
603+static void expand_smb_acl_list(smb_acl_list *sacl_list)
604+{
605+ /* First time through, 0 <= 0, so list is expanded. */
606+ if (sacl_list->malloced <= sacl_list->count) {
607+ SMB_ACL_T *new_ptr;
608+ size_t new_size;
609+ if (sacl_list->malloced < 1000)
610+ new_size = sacl_list->malloced + 1000;
611+ else
612+ new_size = sacl_list->malloced * 2;
613+ new_ptr = realloc_array(sacl_list->sacls, SMB_ACL_T, new_size);
614+ if (verbose >= 3) {
615+ rprintf(FINFO, "expand_smb_acl_list to %.0f bytes, did%s move\n",
616+ (double) new_size * sizeof sacl_list->sacls[0],
617+ sacl_list->sacls ? "" : " not");
618+ }
619+
620+ sacl_list->sacls = new_ptr;
621+ sacl_list->malloced = new_size;
622+
623+ if (!sacl_list->sacls)
624+ out_of_memory("expand_smb_acl_list");
625+ }
626+}
627+
628+#define CALL_OR_ERROR(func,args,str) \
629+ do { \
630+ if (func args) { \
631+ errfun = str; \
632+ goto error_exit; \
633+ } \
634+ } while (0)
635+
636+#define COE(func,args) CALL_OR_ERROR(func,args,#func)
637+#define COE2(func,args) CALL_OR_ERROR(func,args,NULL)
638+
639+static int store_access_in_entry(uchar access, SMB_ACL_ENTRY_T entry)
640+{
641+ const char *errfun = NULL;
642+ SMB_ACL_PERMSET_T permset;
643+
644+ COE( sys_acl_get_permset,(entry, &permset) );
645+ COE( sys_acl_clear_perms,(permset) );
646+ if (access & 4)
647+ COE( sys_acl_add_perm,(permset, SMB_ACL_READ) );
648+ if (access & 2)
649+ COE( sys_acl_add_perm,(permset, SMB_ACL_WRITE) );
650+ if (access & 1)
651+ COE( sys_acl_add_perm,(permset, SMB_ACL_EXECUTE) );
652+ COE( sys_acl_set_permset,(entry, permset) );
653+
654+ return 0;
655+
656+ error_exit:
657+ rprintf(FERROR, "store_access_in_entry %s(): %s\n", errfun,
658+ strerror(errno));
659+ return -1;
660+}
661+
662+/* build an SMB_ACL_T corresponding to an rsync_acl */
663+static BOOL pack_smb_acl(SMB_ACL_T *smb_acl, const rsync_acl *racl)
664+{
665+ size_t count;
666+ id_access *ida;
667+ const char *errfun = NULL;
668+ SMB_ACL_ENTRY_T entry;
669+
670+ if (!(*smb_acl = sys_acl_init(calc_sacl_entries(racl)))) {
671+ rprintf(FERROR, "pack_smb_acl: sys_acl_init(): %s\n",
672+ strerror(errno));
673+ return False;
674+ }
675+
676+ COE( sys_acl_create_entry,(smb_acl, &entry) );
677+ COE( sys_acl_set_tag_type,(entry, SMB_ACL_USER_OBJ) );
678+ COE2( store_access_in_entry,(racl->user_obj & 7, entry) );
679+
680+ for (ida = racl->users.idas, count = racl->users.count;
681+ count--; ida++) {
682+ COE( sys_acl_create_entry,(smb_acl, &entry) );
683+ COE( sys_acl_set_tag_type,(entry, SMB_ACL_USER) );
684+ COE( sys_acl_set_qualifier,(entry, (void*)&ida->id) );
685+ COE2( store_access_in_entry,(ida->access, entry) );
686+ }
687+
688+ COE( sys_acl_create_entry,(smb_acl, &entry) );
689+ COE( sys_acl_set_tag_type,(entry, SMB_ACL_GROUP_OBJ) );
690+ COE2( store_access_in_entry,(racl->group_obj & 7, entry) );
691+
692+ for (ida = racl->groups.idas, count = racl->groups.count;
693+ count--; ida++) {
694+ COE( sys_acl_create_entry,(smb_acl, &entry) );
695+ COE( sys_acl_set_tag_type,(entry, SMB_ACL_GROUP) );
696+ COE( sys_acl_set_qualifier,(entry, (void*)&ida->id) );
697+ COE2( store_access_in_entry,(ida->access, entry) );
698+ }
699+#ifndef ACLS_NEED_MASK
700+ if (racl->mask != ACL_NO_ENTRY) {
701+#endif
702+ COE( sys_acl_create_entry,(smb_acl, &entry) );
703+ COE( sys_acl_set_tag_type,(entry, SMB_ACL_MASK) );
704+ COE2( store_access_in_entry,(racl->mask, entry) );
705+#ifndef ACLS_NEED_MASK
706+ }
707+#endif
708+
709+ COE( sys_acl_create_entry,(smb_acl, &entry) );
710+ COE( sys_acl_set_tag_type,(entry, SMB_ACL_OTHER) );
711+ COE2( store_access_in_entry,(racl->other & 7, entry) );
712+
713+#ifdef DEBUG
714+ if (sys_acl_valid(*smb_acl) < 0)
715+ rprintf(FINFO, "pack_smb_acl: warning: system says the ACL I packed is invalid\n");
716+#endif
717+
718+ return True;
719+
720+ error_exit:
721+ if (errfun) {
722+ rprintf(FERROR, "pack_smb_acl %s(): %s\n", errfun,
723+ strerror(errno));
724+ }
725+ sys_acl_free_acl(*smb_acl);
726+ return False;
727+}
728+
729+static mode_t change_sacl_perms(SMB_ACL_T sacl, rsync_acl *racl, mode_t old_mode, mode_t mode)
730+{
731+ SMB_ACL_ENTRY_T entry;
732+ const char *errfun;
733+ int rc;
734+
735+ if (S_ISDIR(mode)) {
736+ /* If the sticky bit is going on, it's not safe to allow all
737+ * the new ACLs to go into effect before it gets set. */
738+#ifdef SMB_ACL_LOSES_SPECIAL_MODE_BITS
739+ if (mode & S_ISVTX)
740+ mode &= ~0077;
741+#else
742+ if (mode & S_ISVTX && !(old_mode & S_ISVTX))
743+ mode &= ~0077;
744+ } else {
745+ /* If setuid or setgid is going off, it's not safe to allow all
746+ * the new ACLs to go into effect before they get cleared. */
747+ if ((old_mode & S_ISUID && !(mode & S_ISUID))
748+ || (old_mode & S_ISGID && !(mode & S_ISGID)))
749+ mode &= ~0077;
750+#endif
751+ }
752+
753+ errfun = "sys_acl_get_entry";
754+ for (rc = sys_acl_get_entry(sacl, SMB_ACL_FIRST_ENTRY, &entry);
755+ rc == 1;
756+ rc = sys_acl_get_entry(sacl, SMB_ACL_NEXT_ENTRY, &entry)) {
757+ SMB_ACL_TAG_T tag_type;
758+ if ((rc = sys_acl_get_tag_type(entry, &tag_type))) {
759+ errfun = "sys_acl_get_tag_type";
760+ break;
761+ }
762+ switch (tag_type) {
763+ case SMB_ACL_USER_OBJ:
764+ COE2( store_access_in_entry,((mode >> 6) & 7, entry) );
765+ break;
766+ case SMB_ACL_GROUP_OBJ:
767+ /* group is only empty when identical to group perms. */
768+ if (racl->group_obj != ACL_NO_ENTRY)
769+ break;
770+ COE2( store_access_in_entry,((mode >> 3) & 7, entry) );
771+ break;
772+ case SMB_ACL_MASK:
773+#ifndef ACLS_NEED_MASK
774+ /* mask is only empty when we don't need it. */
775+ if (racl->mask == ACL_NO_ENTRY)
776+ break;
777+#endif
778+ COE2( store_access_in_entry,((mode >> 3) & 7, entry) );
779+ break;
780+ case SMB_ACL_OTHER:
781+ COE2( store_access_in_entry,(mode & 7, entry) );
782+ break;
783+ }
784+ }
785+ if (rc) {
786+ error_exit:
787+ if (errfun) {
788+ rprintf(FERROR, "change_sacl_perms: %s(): %s\n",
789+ errfun, strerror(errno));
790+ }
791+ return ~0u;
792+ }
793+
794+#ifdef SMB_ACL_LOSES_SPECIAL_MODE_BITS
795+ /* Ensure that chmod() will be called to restore any lost setid bits. */
796+ if (old_mode & (S_ISUID | S_ISGID | S_ISVTX)
797+ && (old_mode & CHMOD_BITS) == (mode & CHMOD_BITS))
798+ old_mode &= ~(S_ISUID | S_ISGID | S_ISVTX);
799+#endif
800+
801+ /* Return the mode of the file on disk, as we will set them. */
802+ return (old_mode & ~ACCESSPERMS) | (mode & ACCESSPERMS);
803+}
804+
805+static void receive_rsync_acl(rsync_acl *racl, int f, SMB_ACL_TYPE_T type)
806+{
807+ uchar computed_mask_bits = 0;
808+ ida_list *idal = NULL;
809+ id_access *ida;
810+ size_t count;
811+
812+ *racl = rsync_acl_initializer;
813+
814+ if (!(count = read_int(f)))
815+ return;
816+
817+ while (count--) {
818+ char tag = read_byte(f);
819+ uchar access = read_byte(f);
820+ if (access & ~ (4 | 2 | 1)) {
821+ rprintf(FERROR, "receive_rsync_acl: bogus permset %o\n",
822+ access);
823+ exit_cleanup(RERR_STREAMIO);
824+ }
825+ switch (tag) {
826+ case 'u':
827+ if (racl->user_obj != ACL_NO_ENTRY) {
828+ rprintf(FERROR, "receive_rsync_acl: error: duplicate USER_OBJ entry\n");
829+ exit_cleanup(RERR_STREAMIO);
830+ }
831+ racl->user_obj = access;
832+ continue;
833+ case 'U':
834+ idal = &racl->users;
835+ break;
836+ case 'g':
837+ if (racl->group_obj != ACL_NO_ENTRY) {
838+ rprintf(FERROR, "receive_rsync_acl: error: duplicate GROUP_OBJ entry\n");
839+ exit_cleanup(RERR_STREAMIO);
840+ }
841+ racl->group_obj = access;
842+ continue;
843+ case 'G':
844+ idal = &racl->groups;
845+ break;
846+ case 'm':
847+ if (racl->mask != ACL_NO_ENTRY) {
848+ rprintf(FERROR, "receive_rsync_acl: error: duplicate MASK entry\n");
849+ exit_cleanup(RERR_STREAMIO);
850+ }
851+ racl->mask = access;
852+ continue;
853+ case 'o':
854+ if (racl->other != ACL_NO_ENTRY) {
855+ rprintf(FERROR, "receive_rsync_acl: error: duplicate OTHER entry\n");
856+ exit_cleanup(RERR_STREAMIO);
857+ }
858+ racl->other = access;
859+ continue;
860+ default:
861+ rprintf(FERROR, "receive_rsync_acl: unknown tag %c\n",
862+ tag);
863+ exit_cleanup(RERR_STREAMIO);
864+ }
865+ expand_ida_list(idal);
866+ ida = &idal->idas[idal->count++];
867+ ida->access = access;
868+ ida->id = read_int(f);
869+ computed_mask_bits |= access;
870+ }
871+
872+ if (type == SMB_ACL_TYPE_DEFAULT) {
873+ /* Ensure that these are never unset. */
874+ if (racl->user_obj == ACL_NO_ENTRY)
875+ racl->user_obj = 7;
876+ if (racl->group_obj == ACL_NO_ENTRY)
877+ racl->group_obj = 0;
878+ if (racl->other == ACL_NO_ENTRY)
879+ racl->other = 0;
880+ }
881+#ifndef ACLS_NEED_MASK
882+ if (!racl->users.count && !racl->groups.count) {
883+ /* If we, a system without ACLS_NEED_MASK, received a
884+ * superfluous mask, throw it away. */
885+ if (racl->mask != ACL_NO_ENTRY) {
886+ /* mask off group perms with it first */
887+ racl->group_obj &= racl->mask | ACL_NO_ENTRY;
888+ racl->mask = ACL_NO_ENTRY;
889+ }
890+ } else
891+#endif
892+ if (racl->mask == ACL_NO_ENTRY) /* Always non-empty when needed. */
893+ racl->mask = computed_mask_bits | (racl->group_obj & 7);
894+}
895+
896+/* receive and build the rsync_acl_lists */
897+void receive_acl(struct file_struct *file, int f)
898+{
899+ SMB_ACL_TYPE_T type;
900+ char *fname;
901+
902+ if (S_ISLNK(file->mode))
903+ return;
904+
905+ fname = f_name(file, NULL);
906+ type = SMB_ACL_TYPE_ACCESS;
907+ do {
908+ char tag;
909+ file_acl_index_list *flst = file_acl_index_lists(type);
910+
911+ expand_file_acl_index_list(flst);
912+
913+ tag = read_byte(f);
914+ if (tag == 'A' || tag == 'a') {
915+ if (type != SMB_ACL_TYPE_ACCESS) {
916+ rprintf(FERROR, "receive_acl %s: duplicate access ACL\n",
917+ fname);
918+ exit_cleanup(RERR_STREAMIO);
919+ }
920+ } else if (tag == 'D' || tag == 'd') {
921+ if (type == SMB_ACL_TYPE_ACCESS) {
922+ rprintf(FERROR, "receive_acl %s: expecting access ACL; got default\n",
923+ fname);
924+ exit_cleanup(RERR_STREAMIO);
925+ }
926+ } else {
927+ rprintf(FERROR, "receive_acl %s: unknown ACL type tag: %c\n",
928+ fname, tag);
929+ exit_cleanup(RERR_STREAMIO);
930+ }
931+ if (tag == 'A' || tag == 'D') {
932+ rsync_acl racl;
933+ rsync_acl_list *racl_list = rsync_acl_lists(type);
934+ smb_acl_list *sacl_list = smb_acl_lists(type);
935+ flst->fais[flst->count].aclidx = racl_list->count;
936+ flst->fais[flst->count++].file = file;
937+ receive_rsync_acl(&racl, f, type);
938+ expand_rsync_acl_list(racl_list);
939+ racl_list->racls[racl_list->count++] = racl;
940+ expand_smb_acl_list(sacl_list);
941+ sacl_list->sacls[sacl_list->count++] = NULL;
942+ } else {
943+ int index = read_int(f);
944+ rsync_acl_list *racl_list = rsync_acl_lists(type);
945+ if ((size_t) index >= racl_list->count) {
946+ rprintf(FERROR, "receive_acl %s: %s ACL index %d out of range\n",
947+ fname,
948+ str_acl_type(type),
949+ index);
950+ exit_cleanup(RERR_STREAMIO);
951+ }
952+ flst->fais[flst->count].aclidx = index;
953+ flst->fais[flst->count++].file = file;
954+ }
955+ } while (BUMP_TYPE(type) && S_ISDIR(file->mode));
956+}
957+
958+static int file_acl_index_list_sorter(const void *f1, const void *f2)
959+{
960+ const file_acl_index *fileaclidx1 = (const file_acl_index *)f1;
961+ const file_acl_index *fileaclidx2 = (const file_acl_index *)f2;
962+ return fileaclidx1->file == fileaclidx2->file ? 0
963+ : fileaclidx1->file < fileaclidx2->file ? -1 : 1;
964+}
965+
966+void sort_file_acl_index_lists()
967+{
968+ SMB_ACL_TYPE_T type;
969+
970+ type = SMB_ACL_TYPE_ACCESS;
971+ do {
972+ file_acl_index_list *flst = file_acl_index_lists(type);
973+
974+ if (!flst->count)
975+ continue;
976+
977+ qsort(flst->fais, flst->count, sizeof flst->fais[0],
978+ &file_acl_index_list_sorter);
979+ } while (BUMP_TYPE(type));
980+}
981+
982+static int find_file_acl_index(const file_acl_index_list *flst,
983+ const struct file_struct *file)
984+{
985+ int low = 0, high = flst->count;
986+ const struct file_struct *file_mid;
987+
988+ if (!high--)
989+ return -1;
990+ do {
991+ int mid = (high + low) / 2;
992+ file_mid = flst->fais[mid].file;
993+ if (file_mid == file)
994+ return flst->fais[mid].aclidx;
995+ if (file_mid > file)
996+ high = mid - 1;
997+ else
998+ low = mid + 1;
999+ } while (low < high);
1000+ if (low == high) {
1001+ file_mid = flst->fais[low].file;
1002+ if (file_mid == file)
1003+ return flst->fais[low].aclidx;
1004+ }
1005+ rprintf(FERROR,
1006+ "find_file_acl_index: can't find entry for file in list\n");
1007+ exit_cleanup(RERR_STREAMIO);
1008+ return -1;
1009+}
1010+
1011+/* for duplicating ACLs on backups when using backup_dir */
1012+int dup_acl(const char *orig, const char *bak, mode_t mode)
1013+{
1014+ SMB_ACL_TYPE_T type;
1015+ int ret = 0;
1016+
1017+ type = SMB_ACL_TYPE_ACCESS;
1018+ do {
1019+ SMB_ACL_T sacl_orig, sacl_bak;
1020+ rsync_acl racl_orig, racl_bak;
1021+ if (!(sacl_orig = sys_acl_get_file(orig, type))) {
1022+ rprintf(FERROR, "dup_acl: sys_acl_get_file(%s, %s): %s\n",
1023+ orig, str_acl_type(type), strerror(errno));
1024+ ret = -1;
1025+ continue;
1026+ }
1027+ if (!(sacl_bak = sys_acl_get_file(orig, type))) {
1028+ rprintf(FERROR, "dup_acl: sys_acl_get_file(%s, %s): %s. ignoring\n",
1029+ bak, str_acl_type(type), strerror(errno));
1030+ ret = -1;
1031+ /* try to forge on through */
1032+ }
1033+ if (!unpack_smb_acl(&racl_orig, sacl_orig)) {
1034+ ret = -1;
1035+ goto out_with_sacls;
1036+ }
1037+ if (sacl_bak) {
1038+ if (!unpack_smb_acl(&racl_bak, sacl_bak)) {
1039+ ret = -1;
1040+ goto out_with_one_racl;
1041+ }
1042+ if (rsync_acls_equal(&racl_orig, &racl_bak))
1043+ goto out_with_all;
1044+ } else {
1045+ ; /* presume they're unequal */
1046+ }
1047+ if (type == SMB_ACL_TYPE_DEFAULT
1048+ && racl_orig.user_obj == ACL_NO_ENTRY) {
1049+ if (sys_acl_delete_def_file(bak) < 0) {
1050+ rprintf(FERROR, "dup_acl: sys_acl_delete_def_file(%s): %s\n",
1051+ bak, strerror(errno));
1052+ ret = -1;
1053+ }
1054+ } else if (sys_acl_set_file(bak, type, sacl_bak) < 0) {
1055+ rprintf(FERROR, "dup_acl: sys_acl_set_file(%s, %s): %s\n",
1056+ bak, str_acl_type(type), strerror(errno));
1057+ ret = -1;
1058+ }
1059+ out_with_all:
1060+ if (sacl_bak)
1061+ rsync_acl_free(&racl_bak);
1062+ out_with_one_racl:
1063+ rsync_acl_free(&racl_orig);
1064+ out_with_sacls:
1065+ if (sacl_bak)
1066+ sys_acl_free_acl(sacl_bak);
1067+ if (sacl_orig)
1068+ sys_acl_free_acl(sacl_orig);
1069+ } while (BUMP_TYPE(type) && S_ISDIR(mode));
1070+
1071+ return ret;
1072+}
1073+
1074+/* Stuff for redirecting calls to set_acl() from set_file_attrs()
1075+ * for keep_backup(). */
1076+static const struct file_struct *backup_orig_file = NULL;
1077+static const char null_string[] = "";
1078+static const char *backup_orig_fname = null_string;
1079+static const char *backup_dest_fname = null_string;
1080+static SMB_ACL_T _backup_sacl[] = { NULL, NULL };
1081+
1082+void push_keep_backup_acl(const struct file_struct *file,
1083+ const char *orig, const char *dest)
1084+{
1085+ SMB_ACL_TYPE_T type;
1086+ SMB_ACL_T *sacl;
1087+
1088+ backup_orig_file = file;
1089+ backup_orig_fname = orig;
1090+ backup_dest_fname = dest;
1091+
1092+ sacl = &_backup_sacl[0];
1093+ type = SMB_ACL_TYPE_ACCESS;
1094+ do {
1095+ if (type == SMB_ACL_TYPE_DEFAULT && !S_ISDIR(file->mode)) {
1096+ *sacl = NULL;
1097+ break;
1098+ }
1099+ if (!(*sacl = sys_acl_get_file(orig, type))) {
1100+ rprintf(FERROR,
1101+ "push_keep_backup_acl: sys_acl_get_file(%s, %s): %s\n",
1102+ orig, str_acl_type(type),
1103+ strerror(errno));
1104+ }
1105+ } while (BUMP_TYPE(type));
1106+}
1107+
1108+static int set_keep_backup_acl()
1109+{
1110+ SMB_ACL_TYPE_T type;
1111+ SMB_ACL_T *sacl;
1112+ int ret = 0;
1113+
1114+ sacl = &_backup_sacl[0];
1115+ type = SMB_ACL_TYPE_ACCESS;
1116+ do {
1117+ if (*sacl
1118+ && sys_acl_set_file(backup_dest_fname, type, *sacl) < 0) {
1119+ rprintf(FERROR,
1120+ "push_keep_backup_acl: sys_acl_get_file(%s, %s): %s\n",
1121+ backup_dest_fname,
1122+ str_acl_type(type),
1123+ strerror(errno));
1124+ ret = -1;
1125+ }
1126+ } while (BUMP_TYPE(type));
1127+
1128+ return ret;
1129+}
1130+
1131+void cleanup_keep_backup_acl()
1132+{
1133+ SMB_ACL_TYPE_T type;
1134+ SMB_ACL_T *sacl;
1135+
1136+ backup_orig_file = NULL;
1137+ backup_orig_fname = null_string;
1138+ backup_dest_fname = null_string;
1139+
1140+ sacl = &_backup_sacl[0];
1141+ type = SMB_ACL_TYPE_ACCESS;
1142+ do {
1143+ if (*sacl) {
1144+ sys_acl_free_acl(*sacl);
1145+ *sacl = NULL;
1146+ }
1147+ } while (BUMP_TYPE(type));
1148+}
1149+
1150+/* set ACL on rsync-ed or keep_backup-ed file
1151+ *
1152+ * This sets extended access ACL entries and default ACLs. If convenient,
1153+ * it sets permission bits along with the access ACLs and signals having
1154+ * done so by modifying mode_p, which should point into the stat buffer.
1155+ *
1156+ * returns: 1 for unchanged, 0 for changed, -1 for failed
1157+ * Pass NULL for mode_p to get the return code without changing anything. */
1158+int set_acl(const char *fname, const struct file_struct *file, mode_t *mode_p)
1159+{
1160+ int unchanged = 1;
1161+ SMB_ACL_TYPE_T type;
1162+
1163+ if (S_ISLNK(file->mode))
1164+ return 1;
1165+
1166+ if (file == backup_orig_file) {
1167+ if (!strcmp(fname, backup_dest_fname))
1168+ return set_keep_backup_acl();
1169+ }
1170+ type = SMB_ACL_TYPE_ACCESS;
1171+ do {
1172+ BOOL ok;
1173+ SMB_ACL_T sacl_orig, *sacl_new;
1174+ rsync_acl racl_orig, *racl_new;
1175+ int aclidx = find_file_acl_index(file_acl_index_lists(type), file);
1176+
1177+ racl_new = &(rsync_acl_lists(type)->racls[aclidx]);
1178+ sacl_new = &(smb_acl_lists(type)->sacls[aclidx]);
1179+ sacl_orig = sys_acl_get_file(fname, type);
1180+ if (!sacl_orig) {
1181+ rprintf(FERROR, "set_acl: sys_acl_get_file(%s, %s): %s\n",
1182+ fname, str_acl_type(type), strerror(errno));
1183+ unchanged = -1;
1184+ continue;
1185+ }
1186+ ok = unpack_smb_acl(&racl_orig, sacl_orig);
1187+ sys_acl_free_acl(sacl_orig);
1188+ if (!ok) {
1189+ unchanged = -1;
1190+ continue;
1191+ }
1192+ if (type == SMB_ACL_TYPE_ACCESS)
1193+ ok = rsync_acl_extended_parts_equal(&racl_orig, racl_new, file->mode);
1194+ else
1195+ ok = rsync_acls_equal(&racl_orig, racl_new);
1196+ rsync_acl_free(&racl_orig);
1197+ if (ok)
1198+ continue;
1199+ if (!dry_run && mode_p) {
1200+ if (type == SMB_ACL_TYPE_DEFAULT
1201+ && racl_new->user_obj == ACL_NO_ENTRY) {
1202+ if (sys_acl_delete_def_file(fname) < 0) {
1203+ rprintf(FERROR, "set_acl: sys_acl_delete_def_file(%s): %s\n",
1204+ fname, strerror(errno));
1205+ unchanged = -1;
1206+ continue;
1207+ }
1208+ } else {
1209+ mode_t cur_mode = *mode_p;
1210+ if (!*sacl_new
1211+ && !pack_smb_acl(sacl_new, racl_new)) {
1212+ unchanged = -1;
1213+ continue;
1214+ }
1215+ if (type == SMB_ACL_TYPE_ACCESS) {
1216+ cur_mode = change_sacl_perms(*sacl_new, racl_new,
1217+ cur_mode, file->mode);
1218+ if (cur_mode == ~0u)
1219+ continue;
1220+ }
1221+ if (sys_acl_set_file(fname, type, *sacl_new) < 0) {
1222+ rprintf(FERROR, "set_acl: sys_acl_set_file(%s, %s): %s\n",
1223+ fname, str_acl_type(type),
1224+ strerror(errno));
1225+ unchanged = -1;
1226+ continue;
1227+ }
1228+ if (type == SMB_ACL_TYPE_ACCESS)
1229+ *mode_p = cur_mode;
1230+ }
1231+ }
1232+ if (unchanged == 1)
1233+ unchanged = 0;
1234+ } while (BUMP_TYPE(type) && S_ISDIR(file->mode));
1235+
1236+ return unchanged;
1237+}
1238+
1239+/* Enumeration functions for uid mapping: */
1240+
1241+/* Context -- one and only one. Should be cycled through once on uid
1242+ * mapping and once on gid mapping. */
1243+static rsync_acl_list *_enum_racl_lists[] = {
1244+ &_rsync_acl_lists[0], &_rsync_acl_lists[1], NULL
1245+};
1246+
1247+static rsync_acl_list **enum_racl_list = &_enum_racl_lists[0];
1248+static size_t enum_racl_index = 0;
1249+static size_t enum_ida_index = 0;
1250+
1251+/* This returns the next tag_type id from the given acl for the next entry,
1252+ * or it returns 0 if there are no more tag_type ids in the acl. */
1253+static id_t *next_ace_id(SMB_ACL_TAG_T tag_type, const rsync_acl *racl)
1254+{
1255+ const ida_list *idal = tag_type == SMB_ACL_USER ? &racl->users : &racl->groups;
1256+ if (enum_ida_index < idal->count) {
1257+ id_access *ida = &idal->idas[enum_ida_index++];
1258+ return &ida->id;
1259+ }
1260+ enum_ida_index = 0;
1261+ return NULL;
1262+}
1263+
1264+static id_t *next_acl_id(SMB_ACL_TAG_T tag_type, const rsync_acl_list *racl_list)
1265+{
1266+ for (; enum_racl_index < racl_list->count; enum_racl_index++) {
1267+ rsync_acl *racl = &racl_list->racls[enum_racl_index];
1268+ id_t *id = next_ace_id(tag_type, racl);
1269+ if (id)
1270+ return id;
1271+ }
1272+ enum_racl_index = 0;
1273+ return NULL;
1274+}
1275+
1276+static id_t *next_acl_list_id(SMB_ACL_TAG_T tag_type)
1277+{
1278+ for (; *enum_racl_list; enum_racl_list++) {
1279+ id_t *id = next_acl_id(tag_type, *enum_racl_list);
1280+ if (id)
1281+ return id;
1282+ }
1283+ enum_racl_list = &_enum_racl_lists[0];
1284+ return NULL;
1285+}
1286+
1287+id_t *next_acl_uid()
1288+{
1289+ return next_acl_list_id(SMB_ACL_USER);
1290+}
1291+
1292+id_t *next_acl_gid()
1293+{
1294+ return next_acl_list_id(SMB_ACL_GROUP);
1295+}
1296+
1297+int default_perms_for_dir(const char *dir)
1298+{
1299+ rsync_acl racl;
1300+ SMB_ACL_T sacl;
1301+ BOOL ok;
1302+ int perms;
1303+
1304+ if (dir == NULL)
1305+ dir = ".";
1306+ perms = ACCESSPERMS & ~orig_umask;
1307+ /* Read the directory's default ACL. If it has none, this will successfully return an empty ACL. */
1308+ sacl = sys_acl_get_file(dir, SMB_ACL_TYPE_DEFAULT);
1309+ if (sacl == NULL) {
1310+ /* Couldn't get an ACL. Darn. */
1311+ switch (errno) {
1312+ case ENOTSUP:
1313+ /* ACLs are disabled. We could yell at the user to turn them on, but... */
1314+ break;
1315+ case ENOENT:
1316+ if (dry_run) {
1317+ /* We're doing a dry run, so the containing directory
1318+ * wasn't actually created. Don't worry about it. */
1319+ break;
1320+ }
1321+ /* Otherwise fall through. */
1322+ default:
1323+ rprintf(FERROR, "default_perms_for_dir: sys_acl_get_file(%s, %s): %s, falling back on umask\n",
1324+ dir, str_acl_type(SMB_ACL_TYPE_DEFAULT), strerror(errno));
1325+ }
1326+ return perms;
1327+ }
1328+
1329+ /* Convert it. */
1330+ ok = unpack_smb_acl(&racl, sacl);
1331+ sys_acl_free_acl(sacl);
1332+ if (!ok) {
1333+ rprintf(FERROR, "default_perms_for_dir: unpack_smb_acl failed, falling back on umask\n");
1334+ return perms;
1335+ }
1336+
1337+ /* Apply the permission-bit entries of the default ACL, if any. */
1338+ if (racl.user_obj != ACL_NO_ENTRY) {
1339+ perms = rsync_acl_get_perms(&racl);
1340+ if (verbose > 2)
1341+ rprintf(FINFO, "got ACL-based default perms %o for directory %s\n", perms, dir);
1342+ }
1343+
1344+ rsync_acl_free(&racl);
1345+ return perms;
1346+}
1347+
1348+#endif /* SUPPORT_ACLS */
1349--- old/backup.c
1350+++ new/backup.c
1351@@ -29,6 +29,7 @@ extern char *backup_suffix;
1352 extern char *backup_dir;
1353
1354 extern int am_root;
1355+extern int preserve_acls;
1356 extern int preserve_devices;
1357 extern int preserve_specials;
1358 extern int preserve_links;
1359@@ -133,6 +134,10 @@ static int make_bak_dir(char *fullpath)
1360 } else {
1361 do_lchown(fullpath, st.st_uid, st.st_gid);
1362 do_chmod(fullpath, st.st_mode);
1363+#ifdef SUPPORT_ACLS
1364+ if (preserve_acls)
1365+ dup_acl(end, fullpath, st.st_mode);
1366+#endif
1367 }
1368 }
1369 *p = '/';
1370@@ -186,6 +191,11 @@ static int keep_backup(char *fname)
1371 if (!(buf = get_backup_name(fname)))
1372 return 0;
1373
1374+#ifdef SUPPORT_ACLS
1375+ if (preserve_acls)
1376+ push_keep_backup_acl(file, fname, buf);
1377+#endif
1378+
1379 /* Check to see if this is a device file, or link */
1380 if ((am_root && preserve_devices && IS_DEVICE(file->mode))
1381 || (preserve_specials && IS_SPECIAL(file->mode))) {
1382@@ -261,6 +271,10 @@ static int keep_backup(char *fname)
1383 }
1384 }
1385 set_file_attrs(buf, file, NULL, 0);
1386+#ifdef SUPPORT_ACLS
1387+ if (preserve_acls)
1388+ cleanup_keep_backup_acl();
1389+#endif
1390 free(file);
1391
1392 if (verbose > 1) {
1393--- old/configure.in
1394+++ new/configure.in
1395@@ -482,6 +482,11 @@ if test x"$ac_cv_func_strcasecmp" = x"no
1396 AC_CHECK_LIB(resolv, strcasecmp)
1397 fi
1398
1399+AC_CHECK_FUNCS(aclsort)
1400+if test x"$ac_cv_func_aclsort" = x"no"; then
1401+ AC_CHECK_LIB(sec, aclsort)
1402+fi
1403+
1404 dnl At the moment we don't test for a broken memcmp(), because all we
1405 dnl need to do is test for equality, not comparison, and it seems that
1406 dnl every platform has a memcmp that can do at least that.
1407@@ -746,6 +751,78 @@ AC_SUBST(OBJ_RESTORE)
1408 AC_SUBST(CC_SHOBJ_FLAG)
1409 AC_SUBST(BUILD_POPT)
1410
1411+AC_CHECK_HEADERS(sys/acl.h)
1412+AC_CHECK_FUNCS(_acl __acl _facl __facl)
1413+#################################################
1414+# check for ACL support
1415+
1416+AC_MSG_CHECKING(whether to support ACLs)
1417+AC_ARG_ENABLE(acl-support,
1418+AC_HELP_STRING([--enable-acl-support], [Include ACL support (default=no)]),
1419+[ case "$enableval" in
1420+ yes)
1421+
1422+ case "$host_os" in
1423+ *sysv5*)
1424+ AC_MSG_RESULT(Using UnixWare ACLs)
1425+ AC_DEFINE(HAVE_UNIXWARE_ACLS, 1, [true if you have UnixWare ACLs])
1426+ ;;
1427+ *solaris*|*cygwin*)
1428+ AC_MSG_RESULT(Using solaris ACLs)
1429+ AC_DEFINE(HAVE_SOLARIS_ACLS, 1, [true if you have solaris ACLs])
1430+ ;;
1431+ *hpux*)
1432+ AC_MSG_RESULT(Using HPUX ACLs)
1433+ AC_DEFINE(HAVE_HPUX_ACLS, 1, [true if you have HPUX ACLs])
1434+ ;;
1435+ *irix*)
1436+ AC_MSG_RESULT(Using IRIX ACLs)
1437+ AC_DEFINE(HAVE_IRIX_ACLS, 1, [true if you have IRIX ACLs])
1438+ ;;
1439+ *aix*)
1440+ AC_MSG_RESULT(Using AIX ACLs)
1441+ AC_DEFINE(HAVE_AIX_ACLS, 1, [true if you have AIX ACLs])
1442+ ;;
1443+ *osf*)
1444+ AC_MSG_RESULT(Using Tru64 ACLs)
1445+ AC_DEFINE(HAVE_TRU64_ACLS, 1, [true if you have Tru64 ACLs])
1446+ LIBS="$LIBS -lpacl"
1447+ ;;
1448+ *)
1449+ AC_MSG_RESULT(ACLs requested -- running tests)
1450+ AC_CHECK_LIB(acl,acl_get_file)
1451+ AC_CACHE_CHECK([for ACL support],samba_cv_HAVE_POSIX_ACLS,[
1452+ AC_TRY_LINK([#include <sys/types.h>
1453+#include <sys/acl.h>],
1454+[ acl_t acl; int entry_id; acl_entry_t *entry_p; return acl_get_entry( acl, entry_id, entry_p);],
1455+samba_cv_HAVE_POSIX_ACLS=yes,samba_cv_HAVE_POSIX_ACLS=no)])
1456+ AC_MSG_CHECKING(ACL test results)
1457+ if test x"$samba_cv_HAVE_POSIX_ACLS" = x"yes"; then
1458+ AC_MSG_RESULT(Using posix ACLs)
1459+ AC_DEFINE(HAVE_POSIX_ACLS, 1, [true if you have posix ACLs])
1460+ AC_CACHE_CHECK([for acl_get_perm_np],samba_cv_HAVE_ACL_GET_PERM_NP,[
1461+ AC_TRY_LINK([#include <sys/types.h>
1462+#include <sys/acl.h>],
1463+[ acl_permset_t permset_d; acl_perm_t perm; return acl_get_perm_np( permset_d, perm);],
1464+samba_cv_HAVE_ACL_GET_PERM_NP=yes,samba_cv_HAVE_ACL_GET_PERM_NP=no)])
1465+ if test x"$samba_cv_HAVE_ACL_GET_PERM_NP" = x"yes"; then
1466+ AC_DEFINE(HAVE_ACL_GET_PERM_NP, 1, [true if you have acl_get_perm_np])
1467+ fi
1468+ else
1469+ AC_MSG_ERROR(Failed to find ACL support)
1470+ fi
1471+ ;;
1472+ esac
1473+ ;;
1474+ *)
1475+ AC_MSG_RESULT(no)
1476+ AC_DEFINE(HAVE_NO_ACLS, 1, [true if you don't have ACLs])
1477+ ;;
1478+ esac ],
1479+ AC_DEFINE(HAVE_NO_ACLS, 1, [true if you don't have ACLs])
1480+ AC_MSG_RESULT(no)
1481+)
1482+
1483 AC_CONFIG_FILES([Makefile lib/dummy zlib/dummy popt/dummy shconfig])
1484 AC_OUTPUT
1485
1486--- old/flist.c
1487+++ new/flist.c
1488@@ -40,6 +40,7 @@ extern int filesfrom_fd;
1489 extern int one_file_system;
1490 extern int copy_dirlinks;
1491 extern int keep_dirlinks;
1492+extern int preserve_acls;
1493 extern int preserve_links;
1494 extern int preserve_hard_links;
1495 extern int preserve_devices;
1496@@ -961,6 +962,11 @@ static struct file_struct *send_file_nam
1497 if (chmod_modes && !S_ISLNK(file->mode))
1498 file->mode = tweak_mode(file->mode, chmod_modes);
1499
1500+#ifdef SUPPORT_ACLS
1501+ if (preserve_acls && make_acl(file, fname) < 0)
1502+ return NULL;
1503+#endif
1504+
1505 maybe_emit_filelist_progress(flist->count + flist_count_offset);
1506
1507 flist_expand(flist);
1508@@ -968,6 +974,16 @@ static struct file_struct *send_file_nam
1509 if (file->basename[0]) {
1510 flist->files[flist->count++] = file;
1511 send_file_entry(file, f);
1512+#ifdef SUPPORT_ACLS
1513+ if (preserve_acls)
1514+ send_acl(file, f);
1515+#endif
1516+ } else {
1517+#ifdef SUPPORT_ACLS
1518+ /* Cleanup unsent ACL(s). */
1519+ if (preserve_acls)
1520+ send_acl(file, -1);
1521+#endif
1522 }
1523 return file;
1524 }
1525@@ -1356,6 +1372,11 @@ struct file_list *recv_file_list(int f)
1526 flags |= read_byte(f) << 8;
1527 file = receive_file_entry(flist, flags, f);
1528
1529+#ifdef SUPPORT_ACLS
1530+ if (preserve_acls)
1531+ receive_acl(file, f);
1532+#endif
1533+
1534 if (S_ISREG(file->mode) || S_ISLNK(file->mode))
1535 stats.total_size += file->length;
1536
1537@@ -1378,6 +1399,11 @@ struct file_list *recv_file_list(int f)
1538
1539 clean_flist(flist, relative_paths, 1);
1540
1541+#ifdef SUPPORT_ACLS
1542+ if (preserve_acls)
1543+ sort_file_acl_index_lists();
1544+#endif
1545+
1546 if (f >= 0) {
1547 recv_uid_list(f, flist);
1548
1549--- old/generator.c
1550+++ new/generator.c
1551@@ -85,6 +85,7 @@ extern long block_size; /* "long" becaus
1552 extern int max_delete;
1553 extern int force_delete;
1554 extern int one_file_system;
1555+extern mode_t orig_umask;
1556 extern struct stats stats;
1557 extern dev_t filesystem_dev;
1558 extern char *backup_dir;
1559@@ -319,6 +320,8 @@ static void do_delete_pass(struct file_l
1560
1561 int unchanged_attrs(struct file_struct *file, STRUCT_STAT *st)
1562 {
1563+ /* FIXME: Flag ACL changes. */
1564+
1565 if (preserve_perms
1566 && (st->st_mode & CHMOD_BITS) != (file->mode & CHMOD_BITS))
1567 return 0;
1568@@ -353,6 +356,7 @@ void itemize(struct file_struct *file, i
1569 if (preserve_gid && file->gid != GID_NONE
1570 && st->st_gid != file->gid)
1571 iflags |= ITEM_REPORT_GROUP;
1572+ /* FIXME: Itemize ACL changes. ITEM_REPORT_XATTR? */
1573 } else
1574 iflags |= ITEM_IS_NEW;
1575
1576@@ -769,6 +773,7 @@ static int try_dests_non(struct file_str
1577 }
1578
1579 static int phase = 0;
1580+static int dflt_perms;
1581
1582 /* Acts on the_file_list->file's ndx'th item, whose name is fname. If a dir,
1583 * make sure it exists, and has the right permissions/timestamp info. For
1584@@ -860,6 +865,10 @@ static void recv_generator(char *fname,
1585 }
1586 if (fuzzy_basis)
1587 need_fuzzy_dirlist = 1;
1588+#ifdef SUPPORT_ACLS
1589+ if (!preserve_perms)
1590+ dflt_perms = default_perms_for_dir(dn);
1591+#endif
1592 }
1593 parent_dirname = dn;
1594
1595@@ -887,7 +896,8 @@ static void recv_generator(char *fname,
1596 if (!preserve_perms) {
1597 int exists = statret == 0
1598 && S_ISDIR(st.st_mode) == S_ISDIR(file->mode);
1599- file->mode = dest_mode(file->mode, st.st_mode, exists);
1600+ file->mode = dest_mode(file->mode, st.st_mode, dflt_perms,
1601+ exists);
1602 }
1603
1604 if (S_ISDIR(file->mode)) {
1605@@ -1366,6 +1376,8 @@ void generate_files(int f_out, struct fi
1606 * notice that and let us know via the redo pipe (or its closing). */
1607 ignore_timeout = 1;
1608
1609+ dflt_perms = (ACCESSPERMS & ~orig_umask);
1610+
1611 for (i = 0; i < flist->count; i++) {
1612 struct file_struct *file = flist->files[i];
1613
1614--- old/lib/sysacls.c
1615+++ new/lib/sysacls.c
1616@@ -0,0 +1,3240 @@
1617+/*
1618+ Unix SMB/CIFS implementation.
1619+ Samba system utilities for ACL support.
1620+ Copyright (C) Jeremy Allison 2000.
1621+
1622+ This program is free software; you can redistribute it and/or modify
1623+ it under the terms of the GNU General Public License as published by
1624+ the Free Software Foundation; either version 2 of the License, or
1625+ (at your option) any later version.
1626+
1627+ This program is distributed in the hope that it will be useful,
1628+ but WITHOUT ANY WARRANTY; without even the implied warranty of
1629+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1630+ GNU General Public License for more details.
1631+
1632+ You should have received a copy of the GNU General Public License
1633+ along with this program; if not, write to the Free Software
1634+ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
1635+*/
1636+
1637+#include "rsync.h"
1638+#include "sysacls.h" /****** ADDED ******/
1639+
1640+/****** EXTRAS -- THESE ITEMS ARE NOT FROM THE SAMBA SOURCE ******/
1641+void SAFE_FREE(void *mem)
1642+{
1643+ if (mem)
1644+ free(mem);
1645+}
1646+
1647+char *uidtoname(uid_t uid)
1648+{
1649+ static char idbuf[12];
1650+ struct passwd *pw;
1651+
1652+ if ((pw = getpwuid(uid)) == NULL) {
1653+ slprintf(idbuf, sizeof(idbuf)-1, "%ld", (long)uid);
1654+ return idbuf;
1655+ }
1656+ return pw->pw_name;
1657+}
1658+/****** EXTRAS -- END ******/
1659+
1660+/*
1661+ This file wraps all differing system ACL interfaces into a consistent
1662+ one based on the POSIX interface. It also returns the correct errors
1663+ for older UNIX systems that don't support ACLs.
1664+
1665+ The interfaces that each ACL implementation must support are as follows :
1666+
1667+ int sys_acl_get_entry( SMB_ACL_T theacl, int entry_id, SMB_ACL_ENTRY_T *entry_p)
1668+ int sys_acl_get_tag_type( SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p)
1669+ int sys_acl_get_permset( SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p
1670+ void *sys_acl_get_qualifier( SMB_ACL_ENTRY_T entry_d)
1671+ SMB_ACL_T sys_acl_get_file( const char *path_p, SMB_ACL_TYPE_T type)
1672+ SMB_ACL_T sys_acl_get_fd(int fd)
1673+ int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset);
1674+ int sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm);
1675+ char *sys_acl_to_text( SMB_ACL_T theacl, ssize_t *plen)
1676+ SMB_ACL_T sys_acl_init( int count)
1677+ int sys_acl_create_entry( SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry)
1678+ int sys_acl_set_tag_type( SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype)
1679+ int sys_acl_set_qualifier( SMB_ACL_ENTRY_T entry, void *qual)
1680+ int sys_acl_set_permset( SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset)
1681+ int sys_acl_valid( SMB_ACL_T theacl )
1682+ int sys_acl_set_file( const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl)
1683+ int sys_acl_set_fd( int fd, SMB_ACL_T theacl)
1684+ int sys_acl_delete_def_file(const char *path)
1685+
1686+ This next one is not POSIX complient - but we *have* to have it !
1687+ More POSIX braindamage.
1688+
1689+ int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
1690+
1691+ The generic POSIX free is the following call. We split this into
1692+ several different free functions as we may need to add tag info
1693+ to structures when emulating the POSIX interface.
1694+
1695+ int sys_acl_free( void *obj_p)
1696+
1697+ The calls we actually use are :
1698+
1699+ int sys_acl_free_text(char *text) - free acl_to_text
1700+ int sys_acl_free_acl(SMB_ACL_T posix_acl)
1701+ int sys_acl_free_qualifier(void *qualifier, SMB_ACL_TAG_T tagtype)
1702+
1703+*/
1704+
1705+#if defined(HAVE_POSIX_ACLS)
1706+
1707+/* Identity mapping - easy. */
1708+
1709+int sys_acl_get_entry( SMB_ACL_T the_acl, int entry_id, SMB_ACL_ENTRY_T *entry_p)
1710+{
1711+ return acl_get_entry( the_acl, entry_id, entry_p);
1712+}
1713+
1714+int sys_acl_get_tag_type( SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p)
1715+{
1716+ return acl_get_tag_type( entry_d, tag_type_p);
1717+}
1718+
1719+int sys_acl_get_permset( SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
1720+{
1721+ return acl_get_permset( entry_d, permset_p);
1722+}
1723+
1724+void *sys_acl_get_qualifier( SMB_ACL_ENTRY_T entry_d)
1725+{
1726+ return acl_get_qualifier( entry_d);
1727+}
1728+
1729+SMB_ACL_T sys_acl_get_file( const char *path_p, SMB_ACL_TYPE_T type)
1730+{
1731+ return acl_get_file( path_p, type);
1732+}
1733+
1734+SMB_ACL_T sys_acl_get_fd(int fd)
1735+{
1736+ return acl_get_fd(fd);
1737+}
1738+
1739+int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset)
1740+{
1741+ return acl_clear_perms(permset);
1742+}
1743+
1744+int sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
1745+{
1746+ return acl_add_perm(permset, perm);
1747+}
1748+
1749+int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
1750+{
1751+#if defined(HAVE_ACL_GET_PERM_NP)
1752+ /*
1753+ * Required for TrustedBSD-based ACL implementations where
1754+ * non-POSIX.1e functions are denoted by a _np (non-portable)
1755+ * suffix.
1756+ */
1757+ return acl_get_perm_np(permset, perm);
1758+#else
1759+ return acl_get_perm(permset, perm);
1760+#endif
1761+}
1762+
1763+char *sys_acl_to_text( SMB_ACL_T the_acl, ssize_t *plen)
1764+{
1765+ return acl_to_text( the_acl, plen);
1766+}
1767+
1768+SMB_ACL_T sys_acl_init( int count)
1769+{
1770+ return acl_init(count);
1771+}
1772+
1773+int sys_acl_create_entry( SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry)
1774+{
1775+ return acl_create_entry(pacl, pentry);
1776+}
1777+
1778+int sys_acl_set_tag_type( SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype)
1779+{
1780+ return acl_set_tag_type(entry, tagtype);
1781+}
1782+
1783+int sys_acl_set_qualifier( SMB_ACL_ENTRY_T entry, void *qual)
1784+{
1785+ return acl_set_qualifier(entry, qual);
1786+}
1787+
1788+int sys_acl_set_permset( SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset)
1789+{
1790+ return acl_set_permset(entry, permset);
1791+}
1792+
1793+int sys_acl_valid( SMB_ACL_T theacl )
1794+{
1795+ return acl_valid(theacl);
1796+}
1797+
1798+int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl)
1799+{
1800+ return acl_set_file(name, acltype, theacl);
1801+}
1802+
1803+int sys_acl_set_fd( int fd, SMB_ACL_T theacl)
1804+{
1805+ return acl_set_fd(fd, theacl);
1806+}
1807+
1808+int sys_acl_delete_def_file(const char *name)
1809+{
1810+ return acl_delete_def_file(name);
1811+}
1812+
1813+int sys_acl_free_text(char *text)
1814+{
1815+ return acl_free(text);
1816+}
1817+
1818+int sys_acl_free_acl(SMB_ACL_T the_acl)
1819+{
1820+ return acl_free(the_acl);
1821+}
1822+
1823+int sys_acl_free_qualifier(void *qual, UNUSED(SMB_ACL_TAG_T tagtype))
1824+{
1825+ return acl_free(qual);
1826+}
1827+
1828+#elif defined(HAVE_TRU64_ACLS)
1829+/*
1830+ * The interface to DEC/Compaq Tru64 UNIX ACLs
1831+ * is based on Draft 13 of the POSIX spec which is
1832+ * slightly different from the Draft 16 interface.
1833+ *
1834+ * Also, some of the permset manipulation functions
1835+ * such as acl_clear_perm() and acl_add_perm() appear
1836+ * to be broken on Tru64 so we have to manipulate
1837+ * the permission bits in the permset directly.
1838+ */
1839+int sys_acl_get_entry( SMB_ACL_T the_acl, int entry_id, SMB_ACL_ENTRY_T *entry_p)
1840+{
1841+ SMB_ACL_ENTRY_T entry;
1842+
1843+ if (entry_id == SMB_ACL_FIRST_ENTRY && acl_first_entry(the_acl) != 0) {
1844+ return -1;
1845+ }
1846+
1847+ errno = 0;
1848+ if ((entry = acl_get_entry(the_acl)) != NULL) {
1849+ *entry_p = entry;
1850+ return 1;
1851+ }
1852+
1853+ return errno ? -1 : 0;
1854+}
1855+
1856+int sys_acl_get_tag_type( SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p)
1857+{
1858+ return acl_get_tag_type( entry_d, tag_type_p);
1859+}
1860+
1861+int sys_acl_get_permset( SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
1862+{
1863+ return acl_get_permset( entry_d, permset_p);
1864+}
1865+
1866+void *sys_acl_get_qualifier( SMB_ACL_ENTRY_T entry_d)
1867+{
1868+ return acl_get_qualifier( entry_d);
1869+}
1870+
1871+SMB_ACL_T sys_acl_get_file( const char *path_p, SMB_ACL_TYPE_T type)
1872+{
1873+ return acl_get_file((char *)path_p, type);
1874+}
1875+
1876+SMB_ACL_T sys_acl_get_fd(int fd)
1877+{
1878+ return acl_get_fd(fd, ACL_TYPE_ACCESS);
1879+}
1880+
1881+int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset)
1882+{
1883+ *permset = 0; /* acl_clear_perm() is broken on Tru64 */
1884+
1885+ return 0;
1886+}
1887+
1888+int sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
1889+{
1890+ if (perm & ~(SMB_ACL_READ | SMB_ACL_WRITE | SMB_ACL_EXECUTE)) {
1891+ errno = EINVAL;
1892+ return -1;
1893+ }
1894+
1895+ *permset |= perm; /* acl_add_perm() is broken on Tru64 */
1896+
1897+ return 0;
1898+}
1899+
1900+int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
1901+{
1902+ return *permset & perm; /* Tru64 doesn't have acl_get_perm() */
1903+}
1904+
1905+char *sys_acl_to_text( SMB_ACL_T the_acl, ssize_t *plen)
1906+{
1907+ return acl_to_text( the_acl, plen);
1908+}
1909+
1910+SMB_ACL_T sys_acl_init( int count)
1911+{
1912+ return acl_init(count);
1913+}
1914+
1915+int sys_acl_create_entry( SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry)
1916+{
1917+ SMB_ACL_ENTRY_T entry;
1918+
1919+ if ((entry = acl_create_entry(pacl)) == NULL) {
1920+ return -1;
1921+ }
1922+
1923+ *pentry = entry;
1924+ return 0;
1925+}
1926+
1927+int sys_acl_set_tag_type( SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype)
1928+{
1929+ return acl_set_tag_type(entry, tagtype);
1930+}
1931+
1932+int sys_acl_set_qualifier( SMB_ACL_ENTRY_T entry, void *qual)
1933+{
1934+ return acl_set_qualifier(entry, qual);
1935+}
1936+
1937+int sys_acl_set_permset( SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset)
1938+{
1939+ return acl_set_permset(entry, permset);
1940+}
1941+
1942+int sys_acl_valid( SMB_ACL_T theacl )
1943+{
1944+ acl_entry_t entry;
1945+
1946+ return acl_valid(theacl, &entry);
1947+}
1948+
1949+int sys_acl_set_file( const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl)
1950+{
1951+ return acl_set_file((char *)name, acltype, theacl);
1952+}
1953+
1954+int sys_acl_set_fd( int fd, SMB_ACL_T theacl)
1955+{
1956+ return acl_set_fd(fd, ACL_TYPE_ACCESS, theacl);
1957+}
1958+
1959+int sys_acl_delete_def_file(const char *name)
1960+{
1961+ return acl_delete_def_file((char *)name);
1962+}
1963+
1964+int sys_acl_free_text(char *text)
1965+{
1966+ /*
1967+ * (void) cast and explicit return 0 are for DEC UNIX
1968+ * which just #defines acl_free_text() to be free()
1969+ */
1970+ (void) acl_free_text(text);
1971+ return 0;
1972+}
1973+
1974+int sys_acl_free_acl(SMB_ACL_T the_acl)
1975+{
1976+ return acl_free(the_acl);
1977+}
1978+
1979+int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype)
1980+{
1981+ return acl_free_qualifier(qual, tagtype);
1982+}
1983+
1984+#elif defined(HAVE_UNIXWARE_ACLS) || defined(HAVE_SOLARIS_ACLS)
1985+
1986+/*
1987+ * Donated by Michael Davidson <md@sco.COM> for UnixWare / OpenUNIX.
1988+ * Modified by Toomas Soome <tsoome@ut.ee> for Solaris.
1989+ */
1990+
1991+/*
1992+ * Note that while this code implements sufficient functionality
1993+ * to support the sys_acl_* interfaces it does not provide all
1994+ * of the semantics of the POSIX ACL interfaces.
1995+ *
1996+ * In particular, an ACL entry descriptor (SMB_ACL_ENTRY_T) returned
1997+ * from a call to sys_acl_get_entry() should not be assumed to be
1998+ * valid after calling any of the following functions, which may
1999+ * reorder the entries in the ACL.
2000+ *
2001+ * sys_acl_valid()
2002+ * sys_acl_set_file()
2003+ * sys_acl_set_fd()
2004+ */
2005+
2006+/*
2007+ * The only difference between Solaris and UnixWare / OpenUNIX is
2008+ * that the #defines for the ACL operations have different names
2009+ */
2010+#if defined(HAVE_UNIXWARE_ACLS)
2011+
2012+#define SETACL ACL_SET
2013+#define GETACL ACL_GET
2014+#define GETACLCNT ACL_CNT
2015+
2016+#endif
2017+
2018+
2019+int sys_acl_get_entry(SMB_ACL_T acl_d, int entry_id, SMB_ACL_ENTRY_T *entry_p)
2020+{
2021+ if (entry_id != SMB_ACL_FIRST_ENTRY && entry_id != SMB_ACL_NEXT_ENTRY) {
2022+ errno = EINVAL;
2023+ return -1;
2024+ }
2025+
2026+ if (entry_p == NULL) {
2027+ errno = EINVAL;
2028+ return -1;
2029+ }
2030+
2031+ if (entry_id == SMB_ACL_FIRST_ENTRY) {
2032+ acl_d->next = 0;
2033+ }
2034+
2035+ if (acl_d->next < 0) {
2036+ errno = EINVAL;
2037+ return -1;
2038+ }
2039+
2040+ if (acl_d->next >= acl_d->count) {
2041+ return 0;
2042+ }
2043+
2044+ *entry_p = &acl_d->acl[acl_d->next++];
2045+
2046+ return 1;
2047+}
2048+
2049+int sys_acl_get_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *type_p)
2050+{
2051+ *type_p = entry_d->a_type;
2052+
2053+ return 0;
2054+}
2055+
2056+int sys_acl_get_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
2057+{
2058+ *permset_p = &entry_d->a_perm;
2059+
2060+ return 0;
2061+}
2062+
2063+void *sys_acl_get_qualifier(SMB_ACL_ENTRY_T entry_d)
2064+{
2065+ if (entry_d->a_type != SMB_ACL_USER
2066+ && entry_d->a_type != SMB_ACL_GROUP) {
2067+ errno = EINVAL;
2068+ return NULL;
2069+ }
2070+
2071+ return &entry_d->a_id;
2072+}
2073+
2074+/*
2075+ * There is no way of knowing what size the ACL returned by
2076+ * GETACL will be unless you first call GETACLCNT which means
2077+ * making an additional system call.
2078+ *
2079+ * In the hope of avoiding the cost of the additional system
2080+ * call in most cases, we initially allocate enough space for
2081+ * an ACL with INITIAL_ACL_SIZE entries. If this turns out to
2082+ * be too small then we use GETACLCNT to find out the actual
2083+ * size, reallocate the ACL buffer, and then call GETACL again.
2084+ */
2085+
2086+#define INITIAL_ACL_SIZE 16
2087+
2088+SMB_ACL_T sys_acl_get_file(const char *path_p, SMB_ACL_TYPE_T type)
2089+{
2090+ SMB_ACL_T acl_d;
2091+ int count; /* # of ACL entries allocated */
2092+ int naccess; /* # of access ACL entries */
2093+ int ndefault; /* # of default ACL entries */
2094+
2095+ if (type != SMB_ACL_TYPE_ACCESS && type != SMB_ACL_TYPE_DEFAULT) {
2096+ errno = EINVAL;
2097+ return NULL;
2098+ }
2099+
2100+ count = INITIAL_ACL_SIZE;
2101+ if ((acl_d = sys_acl_init(count)) == NULL) {
2102+ return NULL;
2103+ }
2104+
2105+ /*
2106+ * If there isn't enough space for the ACL entries we use
2107+ * GETACLCNT to determine the actual number of ACL entries
2108+ * reallocate and try again. This is in a loop because it
2109+ * is possible that someone else could modify the ACL and
2110+ * increase the number of entries between the call to
2111+ * GETACLCNT and the call to GETACL.
2112+ */
2113+ while ((count = acl(path_p, GETACL, count, &acl_d->acl[0])) < 0
2114+ && errno == ENOSPC) {
2115+
2116+ sys_acl_free_acl(acl_d);
2117+
2118+ if ((count = acl(path_p, GETACLCNT, 0, NULL)) < 0) {
2119+ return NULL;
2120+ }
2121+
2122+ if ((acl_d = sys_acl_init(count)) == NULL) {
2123+ return NULL;
2124+ }
2125+ }
2126+
2127+ if (count < 0) {
2128+ sys_acl_free_acl(acl_d);
2129+ return NULL;
2130+ }
2131+
2132+ /*
2133+ * calculate the number of access and default ACL entries
2134+ *
2135+ * Note: we assume that the acl() system call returned a
2136+ * well formed ACL which is sorted so that all of the
2137+ * access ACL entries preceed any default ACL entries
2138+ */
2139+ for (naccess = 0; naccess < count; naccess++) {
2140+ if (acl_d->acl[naccess].a_type & ACL_DEFAULT)
2141+ break;
2142+ }
2143+ ndefault = count - naccess;
2144+
2145+ /*
2146+ * if the caller wants the default ACL we have to copy
2147+ * the entries down to the start of the acl[] buffer
2148+ * and mask out the ACL_DEFAULT flag from the type field
2149+ */
2150+ if (type == SMB_ACL_TYPE_DEFAULT) {
2151+ int i, j;
2152+
2153+ for (i = 0, j = naccess; i < ndefault; i++, j++) {
2154+ acl_d->acl[i] = acl_d->acl[j];
2155+ acl_d->acl[i].a_type &= ~ACL_DEFAULT;
2156+ }
2157+
2158+ acl_d->count = ndefault;
2159+ } else {
2160+ acl_d->count = naccess;
2161+ }
2162+
2163+ return acl_d;
2164+}
2165+
2166+SMB_ACL_T sys_acl_get_fd(int fd)
2167+{
2168+ SMB_ACL_T acl_d;
2169+ int count; /* # of ACL entries allocated */
2170+ int naccess; /* # of access ACL entries */
2171+
2172+ count = INITIAL_ACL_SIZE;
2173+ if ((acl_d = sys_acl_init(count)) == NULL) {
2174+ return NULL;
2175+ }
2176+
2177+ while ((count = facl(fd, GETACL, count, &acl_d->acl[0])) < 0
2178+ && errno == ENOSPC) {
2179+
2180+ sys_acl_free_acl(acl_d);
2181+
2182+ if ((count = facl(fd, GETACLCNT, 0, NULL)) < 0) {
2183+ return NULL;
2184+ }
2185+
2186+ if ((acl_d = sys_acl_init(count)) == NULL) {
2187+ return NULL;
2188+ }
2189+ }
2190+
2191+ if (count < 0) {
2192+ sys_acl_free_acl(acl_d);
2193+ return NULL;
2194+ }
2195+
2196+ /*
2197+ * calculate the number of access ACL entries
2198+ */
2199+ for (naccess = 0; naccess < count; naccess++) {
2200+ if (acl_d->acl[naccess].a_type & ACL_DEFAULT)
2201+ break;
2202+ }
2203+
2204+ acl_d->count = naccess;
2205+
2206+ return acl_d;
2207+}
2208+
2209+int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset_d)
2210+{
2211+ *permset_d = 0;
2212+
2213+ return 0;
2214+}
2215+
2216+int sys_acl_add_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
2217+{
2218+ if (perm != SMB_ACL_READ && perm != SMB_ACL_WRITE
2219+ && perm != SMB_ACL_EXECUTE) {
2220+ errno = EINVAL;
2221+ return -1;
2222+ }
2223+
2224+ if (permset_d == NULL) {
2225+ errno = EINVAL;
2226+ return -1;
2227+ }
2228+
2229+ *permset_d |= perm;
2230+
2231+ return 0;
2232+}
2233+
2234+int sys_acl_get_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
2235+{
2236+ return *permset_d & perm;
2237+}
2238+
2239+char *sys_acl_to_text(SMB_ACL_T acl_d, ssize_t *len_p)
2240+{
2241+ int i;
2242+ int len, maxlen;
2243+ char *text;
2244+
2245+ /*
2246+ * use an initial estimate of 20 bytes per ACL entry
2247+ * when allocating memory for the text representation
2248+ * of the ACL
2249+ */
2250+ len = 0;
2251+ maxlen = 20 * acl_d->count;
2252+ if ((text = SMB_MALLOC(maxlen)) == NULL) {
2253+ errno = ENOMEM;
2254+ return NULL;
2255+ }
2256+
2257+ for (i = 0; i < acl_d->count; i++) {
2258+ struct acl *ap = &acl_d->acl[i];
2259+ struct group *gr;
2260+ char tagbuf[12];
2261+ char idbuf[12];
2262+ char *tag;
2263+ char *id = "";
2264+ char perms[4];
2265+ int nbytes;
2266+
2267+ switch (ap->a_type) {
2268+ /*
2269+ * for debugging purposes it's probably more
2270+ * useful to dump unknown tag types rather
2271+ * than just returning an error
2272+ */
2273+ default:
2274+ slprintf(tagbuf, sizeof(tagbuf)-1, "0x%x",
2275+ ap->a_type);
2276+ tag = tagbuf;
2277+ slprintf(idbuf, sizeof(idbuf)-1, "%ld",
2278+ (long)ap->a_id);
2279+ id = idbuf;
2280+ break;
2281+
2282+ case SMB_ACL_USER:
2283+ id = uidtoname(ap->a_id);
2284+ case SMB_ACL_USER_OBJ:
2285+ tag = "user";
2286+ break;
2287+
2288+ case SMB_ACL_GROUP:
2289+ if ((gr = getgrgid(ap->a_id)) == NULL) {
2290+ slprintf(idbuf, sizeof(idbuf)-1, "%ld",
2291+ (long)ap->a_id);
2292+ id = idbuf;
2293+ } else {
2294+ id = gr->gr_name;
2295+ }
2296+ case SMB_ACL_GROUP_OBJ:
2297+ tag = "group";
2298+ break;
2299+
2300+ case SMB_ACL_OTHER:
2301+ tag = "other";
2302+ break;
2303+
2304+ case SMB_ACL_MASK:
2305+ tag = "mask";
2306+ break;
2307+
2308+ }
2309+
2310+ perms[0] = (ap->a_perm & SMB_ACL_READ) ? 'r' : '-';
2311+ perms[1] = (ap->a_perm & SMB_ACL_WRITE) ? 'w' : '-';
2312+ perms[2] = (ap->a_perm & SMB_ACL_EXECUTE) ? 'x' : '-';
2313+ perms[3] = '\0';
2314+
2315+ /* <tag> : <qualifier> : rwx \n \0 */
2316+ nbytes = strlen(tag) + 1 + strlen(id) + 1 + 3 + 1 + 1;
2317+
2318+ /*
2319+ * If this entry would overflow the buffer
2320+ * allocate enough additional memory for this
2321+ * entry and an estimate of another 20 bytes
2322+ * for each entry still to be processed
2323+ */
2324+ if ((len + nbytes) > maxlen) {
2325+ char *oldtext = text;
2326+
2327+ maxlen += nbytes + 20 * (acl_d->count - i);
2328+
2329+ if ((text = SMB_REALLOC(oldtext, maxlen)) == NULL) {
2330+ SAFE_FREE(oldtext);
2331+ errno = ENOMEM;
2332+ return NULL;
2333+ }
2334+ }
2335+
2336+ slprintf(&text[len], nbytes-1, "%s:%s:%s\n", tag, id, perms);
2337+ len += nbytes - 1;
2338+ }
2339+
2340+ if (len_p)
2341+ *len_p = len;
2342+
2343+ return text;
2344+}
2345+
2346+SMB_ACL_T sys_acl_init(int count)
2347+{
2348+ SMB_ACL_T a;
2349+
2350+ if (count < 0) {
2351+ errno = EINVAL;
2352+ return NULL;
2353+ }
2354+
2355+ /*
2356+ * note that since the definition of the structure pointed
2357+ * to by the SMB_ACL_T includes the first element of the
2358+ * acl[] array, this actually allocates an ACL with room
2359+ * for (count+1) entries
2360+ */
2361+ if ((a = (SMB_ACL_T)SMB_MALLOC(sizeof(struct SMB_ACL_T) + count * sizeof(struct acl))) == NULL) {
2362+ errno = ENOMEM;
2363+ return NULL;
2364+ }
2365+
2366+ a->size = count + 1;
2367+ a->count = 0;
2368+ a->next = -1;
2369+
2370+ return a;
2371+}
2372+
2373+
2374+int sys_acl_create_entry(SMB_ACL_T *acl_p, SMB_ACL_ENTRY_T *entry_p)
2375+{
2376+ SMB_ACL_T acl_d;
2377+ SMB_ACL_ENTRY_T entry_d;
2378+
2379+ if (acl_p == NULL || entry_p == NULL || (acl_d = *acl_p) == NULL) {
2380+ errno = EINVAL;
2381+ return -1;
2382+ }
2383+
2384+ if (acl_d->count >= acl_d->size) {
2385+ errno = ENOSPC;
2386+ return -1;
2387+ }
2388+
2389+ entry_d = &acl_d->acl[acl_d->count++];
2390+ entry_d->a_type = 0;
2391+ entry_d->a_id = -1;
2392+ entry_d->a_perm = 0;
2393+ *entry_p = entry_d;
2394+
2395+ return 0;
2396+}
2397+
2398+int sys_acl_set_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T tag_type)
2399+{
2400+ switch (tag_type) {
2401+ case SMB_ACL_USER:
2402+ case SMB_ACL_USER_OBJ:
2403+ case SMB_ACL_GROUP:
2404+ case SMB_ACL_GROUP_OBJ:
2405+ case SMB_ACL_OTHER:
2406+ case SMB_ACL_MASK:
2407+ entry_d->a_type = tag_type;
2408+ break;
2409+ default:
2410+ errno = EINVAL;
2411+ return -1;
2412+ }
2413+
2414+ return 0;
2415+}
2416+
2417+int sys_acl_set_qualifier(SMB_ACL_ENTRY_T entry_d, void *qual_p)
2418+{
2419+ if (entry_d->a_type != SMB_ACL_GROUP
2420+ && entry_d->a_type != SMB_ACL_USER) {
2421+ errno = EINVAL;
2422+ return -1;
2423+ }
2424+
2425+ entry_d->a_id = *((id_t *)qual_p);
2426+
2427+ return 0;
2428+}
2429+
2430+int sys_acl_set_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T permset_d)
2431+{
2432+ if (*permset_d & ~(SMB_ACL_READ|SMB_ACL_WRITE|SMB_ACL_EXECUTE)) {
2433+ return EINVAL;
2434+ }
2435+
2436+ entry_d->a_perm = *permset_d;
2437+
2438+ return 0;
2439+}
2440+
2441+/*
2442+ * sort the ACL and check it for validity
2443+ *
2444+ * if it's a minimal ACL with only 4 entries then we
2445+ * need to recalculate the mask permissions to make
2446+ * sure that they are the same as the GROUP_OBJ
2447+ * permissions as required by the UnixWare acl() system call.
2448+ *
2449+ * (note: since POSIX allows minimal ACLs which only contain
2450+ * 3 entries - ie there is no mask entry - we should, in theory,
2451+ * check for this and add a mask entry if necessary - however
2452+ * we "know" that the caller of this interface always specifies
2453+ * a mask so, in practice "this never happens" (tm) - if it *does*
2454+ * happen aclsort() will fail and return an error and someone will
2455+ * have to fix it ...)
2456+ */
2457+
2458+static int acl_sort(SMB_ACL_T acl_d)
2459+{
2460+ int fixmask = (acl_d->count <= 4);
2461+
2462+ if (aclsort(acl_d->count, fixmask, acl_d->acl) != 0) {
2463+ errno = EINVAL;
2464+ return -1;
2465+ }
2466+ return 0;
2467+}
2468+
2469+int sys_acl_valid(SMB_ACL_T acl_d)
2470+{
2471+ return acl_sort(acl_d);
2472+}
2473+
2474+int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T type, SMB_ACL_T acl_d)
2475+{
2476+ struct stat s;
2477+ struct acl *acl_p;
2478+ int acl_count;
2479+ struct acl *acl_buf = NULL;
2480+ int ret;
2481+
2482+ if (type != SMB_ACL_TYPE_ACCESS && type != SMB_ACL_TYPE_DEFAULT) {
2483+ errno = EINVAL;
2484+ return -1;
2485+ }
2486+
2487+ if (acl_sort(acl_d) != 0) {
2488+ return -1;
2489+ }
2490+
2491+ acl_p = &acl_d->acl[0];
2492+ acl_count = acl_d->count;
2493+
2494+ /*
2495+ * if it's a directory there is extra work to do
2496+ * since the acl() system call will replace both
2497+ * the access ACLs and the default ACLs (if any)
2498+ */
2499+ if (stat(name, &s) != 0) {
2500+ return -1;
2501+ }
2502+ if (S_ISDIR(s.st_mode)) {
2503+ SMB_ACL_T acc_acl;
2504+ SMB_ACL_T def_acl;
2505+ SMB_ACL_T tmp_acl;
2506+ int i;
2507+
2508+ if (type == SMB_ACL_TYPE_ACCESS) {
2509+ acc_acl = acl_d;
2510+ def_acl = tmp_acl = sys_acl_get_file(name, SMB_ACL_TYPE_DEFAULT);
2511+
2512+ } else {
2513+ def_acl = acl_d;
2514+ acc_acl = tmp_acl = sys_acl_get_file(name, SMB_ACL_TYPE_ACCESS);
2515+ }
2516+
2517+ if (tmp_acl == NULL) {
2518+ return -1;
2519+ }
2520+
2521+ /*
2522+ * allocate a temporary buffer for the complete ACL
2523+ */
2524+ acl_count = acc_acl->count + def_acl->count;
2525+ acl_p = acl_buf = SMB_MALLOC_ARRAY(struct acl, acl_count);
2526+
2527+ if (acl_buf == NULL) {
2528+ sys_acl_free_acl(tmp_acl);
2529+ errno = ENOMEM;
2530+ return -1;
2531+ }
2532+
2533+ /*
2534+ * copy the access control and default entries into the buffer
2535+ */
2536+ memcpy(&acl_buf[0], &acc_acl->acl[0],
2537+ acc_acl->count * sizeof(acl_buf[0]));
2538+
2539+ memcpy(&acl_buf[acc_acl->count], &def_acl->acl[0],
2540+ def_acl->count * sizeof(acl_buf[0]));
2541+
2542+ /*
2543+ * set the ACL_DEFAULT flag on the default entries
2544+ */
2545+ for (i = acc_acl->count; i < acl_count; i++) {
2546+ acl_buf[i].a_type |= ACL_DEFAULT;
2547+ }
2548+
2549+ sys_acl_free_acl(tmp_acl);
2550+
2551+ } else if (type != SMB_ACL_TYPE_ACCESS) {
2552+ errno = EINVAL;
2553+ return -1;
2554+ }
2555+
2556+ ret = acl(name, SETACL, acl_count, acl_p);
2557+
2558+ SAFE_FREE(acl_buf);
2559+
2560+ return ret;
2561+}
2562+
2563+int sys_acl_set_fd(int fd, SMB_ACL_T acl_d)
2564+{
2565+ if (acl_sort(acl_d) != 0) {
2566+ return -1;
2567+ }
2568+
2569+ return facl(fd, SETACL, acl_d->count, &acl_d->acl[0]);
2570+}
2571+
2572+int sys_acl_delete_def_file(const char *path)
2573+{
2574+ SMB_ACL_T acl_d;
2575+ int ret;
2576+
2577+ /*
2578+ * fetching the access ACL and rewriting it has
2579+ * the effect of deleting the default ACL
2580+ */
2581+ if ((acl_d = sys_acl_get_file(path, SMB_ACL_TYPE_ACCESS)) == NULL) {
2582+ return -1;
2583+ }
2584+
2585+ ret = acl(path, SETACL, acl_d->count, acl_d->acl);
2586+
2587+ sys_acl_free_acl(acl_d);
2588+
2589+ return ret;
2590+}
2591+
2592+int sys_acl_free_text(char *text)
2593+{
2594+ SAFE_FREE(text);
2595+ return 0;
2596+}
2597+
2598+int sys_acl_free_acl(SMB_ACL_T acl_d)
2599+{
2600+ SAFE_FREE(acl_d);
2601+ return 0;
2602+}
2603+
2604+int sys_acl_free_qualifier(UNUSED(void *qual), UNUSED(SMB_ACL_TAG_T tagtype))
2605+{
2606+ return 0;
2607+}
2608+
2609+#elif defined(HAVE_HPUX_ACLS)
2610+#include <dl.h>
2611+
2612+/*
2613+ * Based on the Solaris/SCO code - with modifications.
2614+ */
2615+
2616+/*
2617+ * Note that while this code implements sufficient functionality
2618+ * to support the sys_acl_* interfaces it does not provide all
2619+ * of the semantics of the POSIX ACL interfaces.
2620+ *
2621+ * In particular, an ACL entry descriptor (SMB_ACL_ENTRY_T) returned
2622+ * from a call to sys_acl_get_entry() should not be assumed to be
2623+ * valid after calling any of the following functions, which may
2624+ * reorder the entries in the ACL.
2625+ *
2626+ * sys_acl_valid()
2627+ * sys_acl_set_file()
2628+ * sys_acl_set_fd()
2629+ */
2630+
2631+/* This checks if the POSIX ACL system call is defined */
2632+/* which basically corresponds to whether JFS 3.3 or */
2633+/* higher is installed. If acl() was called when it */
2634+/* isn't defined, it causes the process to core dump */
2635+/* so it is important to check this and avoid acl() */
2636+/* calls if it isn't there. */
2637+
2638+static BOOL hpux_acl_call_presence(void)
2639+{
2640+
2641+ shl_t handle = NULL;
2642+ void *value;
2643+ int ret_val=0;
2644+ static BOOL already_checked=0;
2645+
2646+ if(already_checked)
2647+ return True;
2648+
2649+
2650+ ret_val = shl_findsym(&handle, "acl", TYPE_PROCEDURE, &value);
2651+
2652+ if(ret_val != 0) {
2653+ DEBUG(5, ("hpux_acl_call_presence: shl_findsym() returned %d, errno = %d, error %s\n",
2654+ ret_val, errno, strerror(errno)));
2655+ DEBUG(5,("hpux_acl_call_presence: acl() system call is not present. Check if you have JFS 3.3 and above?\n"));
2656+ return False;
2657+ }
2658+
2659+ DEBUG(10,("hpux_acl_call_presence: acl() system call is present. We have JFS 3.3 or above \n"));
2660+
2661+ already_checked = True;
2662+ return True;
2663+}
2664+
2665+int sys_acl_get_entry(SMB_ACL_T acl_d, int entry_id, SMB_ACL_ENTRY_T *entry_p)
2666+{
2667+ if (entry_id != SMB_ACL_FIRST_ENTRY && entry_id != SMB_ACL_NEXT_ENTRY) {
2668+ errno = EINVAL;
2669+ return -1;
2670+ }
2671+
2672+ if (entry_p == NULL) {
2673+ errno = EINVAL;
2674+ return -1;
2675+ }
2676+
2677+ if (entry_id == SMB_ACL_FIRST_ENTRY) {
2678+ acl_d->next = 0;
2679+ }
2680+
2681+ if (acl_d->next < 0) {
2682+ errno = EINVAL;
2683+ return -1;
2684+ }
2685+
2686+ if (acl_d->next >= acl_d->count) {
2687+ return 0;
2688+ }
2689+
2690+ *entry_p = &acl_d->acl[acl_d->next++];
2691+
2692+ return 1;
2693+}
2694+
2695+int sys_acl_get_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *type_p)
2696+{
2697+ *type_p = entry_d->a_type;
2698+
2699+ return 0;
2700+}
2701+
2702+int sys_acl_get_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
2703+{
2704+ *permset_p = &entry_d->a_perm;
2705+
2706+ return 0;
2707+}
2708+
2709+void *sys_acl_get_qualifier(SMB_ACL_ENTRY_T entry_d)
2710+{
2711+ if (entry_d->a_type != SMB_ACL_USER
2712+ && entry_d->a_type != SMB_ACL_GROUP) {
2713+ errno = EINVAL;
2714+ return NULL;
2715+ }
2716+
2717+ return &entry_d->a_id;
2718+}
2719+
2720+/*
2721+ * There is no way of knowing what size the ACL returned by
2722+ * ACL_GET will be unless you first call ACL_CNT which means
2723+ * making an additional system call.
2724+ *
2725+ * In the hope of avoiding the cost of the additional system
2726+ * call in most cases, we initially allocate enough space for
2727+ * an ACL with INITIAL_ACL_SIZE entries. If this turns out to
2728+ * be too small then we use ACL_CNT to find out the actual
2729+ * size, reallocate the ACL buffer, and then call ACL_GET again.
2730+ */
2731+
2732+#define INITIAL_ACL_SIZE 16
2733+
2734+SMB_ACL_T sys_acl_get_file(const char *path_p, SMB_ACL_TYPE_T type)
2735+{
2736+ SMB_ACL_T acl_d;
2737+ int count; /* # of ACL entries allocated */
2738+ int naccess; /* # of access ACL entries */
2739+ int ndefault; /* # of default ACL entries */
2740+
2741+ if(hpux_acl_call_presence() == False) {
2742+ /* Looks like we don't have the acl() system call on HPUX.
2743+ * May be the system doesn't have the latest version of JFS.
2744+ */
2745+ return NULL;
2746+ }
2747+
2748+ if (type != SMB_ACL_TYPE_ACCESS && type != SMB_ACL_TYPE_DEFAULT) {
2749+ errno = EINVAL;
2750+ return NULL;
2751+ }
2752+
2753+ count = INITIAL_ACL_SIZE;
2754+ if ((acl_d = sys_acl_init(count)) == NULL) {
2755+ return NULL;
2756+ }
2757+
2758+ /*
2759+ * If there isn't enough space for the ACL entries we use
2760+ * ACL_CNT to determine the actual number of ACL entries
2761+ * reallocate and try again. This is in a loop because it
2762+ * is possible that someone else could modify the ACL and
2763+ * increase the number of entries between the call to
2764+ * ACL_CNT and the call to ACL_GET.
2765+ */
2766+ while ((count = acl(path_p, ACL_GET, count, &acl_d->acl[0])) < 0 && errno == ENOSPC) {
2767+
2768+ sys_acl_free_acl(acl_d);
2769+
2770+ if ((count = acl(path_p, ACL_CNT, 0, NULL)) < 0) {
2771+ return NULL;
2772+ }
2773+
2774+ if ((acl_d = sys_acl_init(count)) == NULL) {
2775+ return NULL;
2776+ }
2777+ }
2778+
2779+ if (count < 0) {
2780+ sys_acl_free_acl(acl_d);
2781+ return NULL;
2782+ }
2783+
2784+ /*
2785+ * calculate the number of access and default ACL entries
2786+ *
2787+ * Note: we assume that the acl() system call returned a
2788+ * well formed ACL which is sorted so that all of the
2789+ * access ACL entries preceed any default ACL entries
2790+ */
2791+ for (naccess = 0; naccess < count; naccess++) {
2792+ if (acl_d->acl[naccess].a_type & ACL_DEFAULT)
2793+ break;
2794+ }
2795+ ndefault = count - naccess;
2796+
2797+ /*
2798+ * if the caller wants the default ACL we have to copy
2799+ * the entries down to the start of the acl[] buffer
2800+ * and mask out the ACL_DEFAULT flag from the type field
2801+ */
2802+ if (type == SMB_ACL_TYPE_DEFAULT) {
2803+ int i, j;
2804+
2805+ for (i = 0, j = naccess; i < ndefault; i++, j++) {
2806+ acl_d->acl[i] = acl_d->acl[j];
2807+ acl_d->acl[i].a_type &= ~ACL_DEFAULT;
2808+ }
2809+
2810+ acl_d->count = ndefault;
2811+ } else {
2812+ acl_d->count = naccess;
2813+ }
2814+
2815+ return acl_d;
2816+}
2817+
2818+SMB_ACL_T sys_acl_get_fd(int fd)
2819+{
2820+ /*
2821+ * HPUX doesn't have the facl call. Fake it using the path.... JRA.
2822+ */
2823+
2824+ files_struct *fsp = file_find_fd(fd);
2825+
2826+ if (fsp == NULL) {
2827+ errno = EBADF;
2828+ return NULL;
2829+ }
2830+
2831+ /*
2832+ * We know we're in the same conn context. So we
2833+ * can use the relative path.
2834+ */
2835+
2836+ return sys_acl_get_file(fsp->fsp_name, SMB_ACL_TYPE_ACCESS);
2837+}
2838+
2839+int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset_d)
2840+{
2841+ *permset_d = 0;
2842+
2843+ return 0;
2844+}
2845+
2846+int sys_acl_add_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
2847+{
2848+ if (perm != SMB_ACL_READ && perm != SMB_ACL_WRITE
2849+ && perm != SMB_ACL_EXECUTE) {
2850+ errno = EINVAL;
2851+ return -1;
2852+ }
2853+
2854+ if (permset_d == NULL) {
2855+ errno = EINVAL;
2856+ return -1;
2857+ }
2858+
2859+ *permset_d |= perm;
2860+
2861+ return 0;
2862+}
2863+
2864+int sys_acl_get_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
2865+{
2866+ return *permset_d & perm;
2867+}
2868+
2869+char *sys_acl_to_text(SMB_ACL_T acl_d, ssize_t *len_p)
2870+{
2871+ int i;
2872+ int len, maxlen;
2873+ char *text;
2874+
2875+ /*
2876+ * use an initial estimate of 20 bytes per ACL entry
2877+ * when allocating memory for the text representation
2878+ * of the ACL
2879+ */
2880+ len = 0;
2881+ maxlen = 20 * acl_d->count;
2882+ if ((text = SMB_MALLOC(maxlen)) == NULL) {
2883+ errno = ENOMEM;
2884+ return NULL;
2885+ }
2886+
2887+ for (i = 0; i < acl_d->count; i++) {
2888+ struct acl *ap = &acl_d->acl[i];
2889+ struct group *gr;
2890+ char tagbuf[12];
2891+ char idbuf[12];
2892+ char *tag;
2893+ char *id = "";
2894+ char perms[4];
2895+ int nbytes;
2896+
2897+ switch (ap->a_type) {
2898+ /*
2899+ * for debugging purposes it's probably more
2900+ * useful to dump unknown tag types rather
2901+ * than just returning an error
2902+ */
2903+ default:
2904+ slprintf(tagbuf, sizeof(tagbuf)-1, "0x%x",
2905+ ap->a_type);
2906+ tag = tagbuf;
2907+ slprintf(idbuf, sizeof(idbuf)-1, "%ld",
2908+ (long)ap->a_id);
2909+ id = idbuf;
2910+ break;
2911+
2912+ case SMB_ACL_USER:
2913+ id = uidtoname(ap->a_id);
2914+ case SMB_ACL_USER_OBJ:
2915+ tag = "user";
2916+ break;
2917+
2918+ case SMB_ACL_GROUP:
2919+ if ((gr = getgrgid(ap->a_id)) == NULL) {
2920+ slprintf(idbuf, sizeof(idbuf)-1, "%ld",
2921+ (long)ap->a_id);
2922+ id = idbuf;
2923+ } else {
2924+ id = gr->gr_name;
2925+ }
2926+ case SMB_ACL_GROUP_OBJ:
2927+ tag = "group";
2928+ break;
2929+
2930+ case SMB_ACL_OTHER:
2931+ tag = "other";
2932+ break;
2933+
2934+ case SMB_ACL_MASK:
2935+ tag = "mask";
2936+ break;
2937+
2938+ }
2939+
2940+ perms[0] = (ap->a_perm & SMB_ACL_READ) ? 'r' : '-';
2941+ perms[1] = (ap->a_perm & SMB_ACL_WRITE) ? 'w' : '-';
2942+ perms[2] = (ap->a_perm & SMB_ACL_EXECUTE) ? 'x' : '-';
2943+ perms[3] = '\0';
2944+
2945+ /* <tag> : <qualifier> : rwx \n \0 */
2946+ nbytes = strlen(tag) + 1 + strlen(id) + 1 + 3 + 1 + 1;
2947+
2948+ /*
2949+ * If this entry would overflow the buffer
2950+ * allocate enough additional memory for this
2951+ * entry and an estimate of another 20 bytes
2952+ * for each entry still to be processed
2953+ */
2954+ if ((len + nbytes) > maxlen) {
2955+ char *oldtext = text;
2956+
2957+ maxlen += nbytes + 20 * (acl_d->count - i);
2958+
2959+ if ((text = SMB_REALLOC(oldtext, maxlen)) == NULL) {
2960+ free(oldtext);
2961+ errno = ENOMEM;
2962+ return NULL;
2963+ }
2964+ }
2965+
2966+ slprintf(&text[len], nbytes-1, "%s:%s:%s\n", tag, id, perms);
2967+ len += nbytes - 1;
2968+ }
2969+
2970+ if (len_p)
2971+ *len_p = len;
2972+
2973+ return text;
2974+}
2975+
2976+SMB_ACL_T sys_acl_init(int count)
2977+{
2978+ SMB_ACL_T a;
2979+
2980+ if (count < 0) {
2981+ errno = EINVAL;
2982+ return NULL;
2983+ }
2984+
2985+ /*
2986+ * note that since the definition of the structure pointed
2987+ * to by the SMB_ACL_T includes the first element of the
2988+ * acl[] array, this actually allocates an ACL with room
2989+ * for (count+1) entries
2990+ */
2991+ if ((a = SMB_MALLOC(sizeof(struct SMB_ACL_T) + count * sizeof(struct acl))) == NULL) {
2992+ errno = ENOMEM;
2993+ return NULL;
2994+ }
2995+
2996+ a->size = count + 1;
2997+ a->count = 0;
2998+ a->next = -1;
2999+
3000+ return a;
3001+}
3002+
3003+
3004+int sys_acl_create_entry(SMB_ACL_T *acl_p, SMB_ACL_ENTRY_T *entry_p)
3005+{
3006+ SMB_ACL_T acl_d;
3007+ SMB_ACL_ENTRY_T entry_d;
3008+
3009+ if (acl_p == NULL || entry_p == NULL || (acl_d = *acl_p) == NULL) {
3010+ errno = EINVAL;
3011+ return -1;
3012+ }
3013+
3014+ if (acl_d->count >= acl_d->size) {
3015+ errno = ENOSPC;
3016+ return -1;
3017+ }
3018+
3019+ entry_d = &acl_d->acl[acl_d->count++];
3020+ entry_d->a_type = 0;
3021+ entry_d->a_id = -1;
3022+ entry_d->a_perm = 0;
3023+ *entry_p = entry_d;
3024+
3025+ return 0;
3026+}
3027+
3028+int sys_acl_set_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T tag_type)
3029+{
3030+ switch (tag_type) {
3031+ case SMB_ACL_USER:
3032+ case SMB_ACL_USER_OBJ:
3033+ case SMB_ACL_GROUP:
3034+ case SMB_ACL_GROUP_OBJ:
3035+ case SMB_ACL_OTHER:
3036+ case SMB_ACL_MASK:
3037+ entry_d->a_type = tag_type;
3038+ break;
3039+ default:
3040+ errno = EINVAL;
3041+ return -1;
3042+ }
3043+
3044+ return 0;
3045+}
3046+
3047+int sys_acl_set_qualifier(SMB_ACL_ENTRY_T entry_d, void *qual_p)
3048+{
3049+ if (entry_d->a_type != SMB_ACL_GROUP
3050+ && entry_d->a_type != SMB_ACL_USER) {
3051+ errno = EINVAL;
3052+ return -1;
3053+ }
3054+
3055+ entry_d->a_id = *((id_t *)qual_p);
3056+
3057+ return 0;
3058+}
3059+
3060+int sys_acl_set_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T permset_d)
3061+{
3062+ if (*permset_d & ~(SMB_ACL_READ|SMB_ACL_WRITE|SMB_ACL_EXECUTE)) {
3063+ return EINVAL;
3064+ }
3065+
3066+ entry_d->a_perm = *permset_d;
3067+
3068+ return 0;
3069+}
3070+
3071+/* Structure to capture the count for each type of ACE. */
3072+
3073+struct hpux_acl_types {
3074+ int n_user;
3075+ int n_def_user;
3076+ int n_user_obj;
3077+ int n_def_user_obj;
3078+
3079+ int n_group;
3080+ int n_def_group;
3081+ int n_group_obj;
3082+ int n_def_group_obj;
3083+
3084+ int n_other;
3085+ int n_other_obj;
3086+ int n_def_other_obj;
3087+
3088+ int n_class_obj;
3089+ int n_def_class_obj;
3090+
3091+ int n_illegal_obj;
3092+};
3093+
3094+/* count_obj:
3095+ * Counts the different number of objects in a given array of ACL
3096+ * structures.
3097+ * Inputs:
3098+ *
3099+ * acl_count - Count of ACLs in the array of ACL strucutres.
3100+ * aclp - Array of ACL structures.
3101+ * acl_type_count - Pointer to acl_types structure. Should already be
3102+ * allocated.
3103+ * Output:
3104+ *
3105+ * acl_type_count - This structure is filled up with counts of various
3106+ * acl types.
3107+ */
3108+
3109+static int hpux_count_obj(int acl_count, struct acl *aclp, struct hpux_acl_types *acl_type_count)
3110+{
3111+ int i;
3112+
3113+ memset(acl_type_count, 0, sizeof(struct hpux_acl_types));
3114+
3115+ for(i=0;i<acl_count;i++) {
3116+ switch(aclp[i].a_type) {
3117+ case USER:
3118+ acl_type_count->n_user++;
3119+ break;
3120+ case USER_OBJ:
3121+ acl_type_count->n_user_obj++;
3122+ break;
3123+ case DEF_USER_OBJ:
3124+ acl_type_count->n_def_user_obj++;
3125+ break;
3126+ case GROUP:
3127+ acl_type_count->n_group++;
3128+ break;
3129+ case GROUP_OBJ:
3130+ acl_type_count->n_group_obj++;
3131+ break;
3132+ case DEF_GROUP_OBJ:
3133+ acl_type_count->n_def_group_obj++;
3134+ break;
3135+ case OTHER_OBJ:
3136+ acl_type_count->n_other_obj++;
3137+ break;
3138+ case DEF_OTHER_OBJ:
3139+ acl_type_count->n_def_other_obj++;
3140+ break;
3141+ case CLASS_OBJ:
3142+ acl_type_count->n_class_obj++;
3143+ break;
3144+ case DEF_CLASS_OBJ:
3145+ acl_type_count->n_def_class_obj++;
3146+ break;
3147+ case DEF_USER:
3148+ acl_type_count->n_def_user++;
3149+ break;
3150+ case DEF_GROUP:
3151+ acl_type_count->n_def_group++;
3152+ break;
3153+ default:
3154+ acl_type_count->n_illegal_obj++;
3155+ break;
3156+ }
3157+ }
3158+}
3159+
3160+/* swap_acl_entries: Swaps two ACL entries.
3161+ *
3162+ * Inputs: aclp0, aclp1 - ACL entries to be swapped.
3163+ */
3164+
3165+static void hpux_swap_acl_entries(struct acl *aclp0, struct acl *aclp1)
3166+{
3167+ struct acl temp_acl;
3168+
3169+ temp_acl.a_type = aclp0->a_type;
3170+ temp_acl.a_id = aclp0->a_id;
3171+ temp_acl.a_perm = aclp0->a_perm;
3172+
3173+ aclp0->a_type = aclp1->a_type;
3174+ aclp0->a_id = aclp1->a_id;
3175+ aclp0->a_perm = aclp1->a_perm;
3176+
3177+ aclp1->a_type = temp_acl.a_type;
3178+ aclp1->a_id = temp_acl.a_id;
3179+ aclp1->a_perm = temp_acl.a_perm;
3180+}
3181+
3182+/* prohibited_duplicate_type
3183+ * Identifies if given ACL type can have duplicate entries or
3184+ * not.
3185+ *
3186+ * Inputs: acl_type - ACL Type.
3187+ *
3188+ * Outputs:
3189+ *
3190+ * Return..
3191+ *
3192+ * True - If the ACL type matches any of the prohibited types.
3193+ * False - If the ACL type doesn't match any of the prohibited types.
3194+ */
3195+
3196+static BOOL hpux_prohibited_duplicate_type(int acl_type)
3197+{
3198+ switch(acl_type) {
3199+ case USER:
3200+ case GROUP:
3201+ case DEF_USER:
3202+ case DEF_GROUP:
3203+ return True;
3204+ default:
3205+ return False;
3206+ }
3207+}
3208+
3209+/* get_needed_class_perm
3210+ * Returns the permissions of a ACL structure only if the ACL
3211+ * type matches one of the pre-determined types for computing
3212+ * CLASS_OBJ permissions.
3213+ *
3214+ * Inputs: aclp - Pointer to ACL structure.
3215+ */
3216+
3217+static int hpux_get_needed_class_perm(struct acl *aclp)
3218+{
3219+ switch(aclp->a_type) {
3220+ case USER:
3221+ case GROUP_OBJ:
3222+ case GROUP:
3223+ case DEF_USER_OBJ:
3224+ case DEF_USER:
3225+ case DEF_GROUP_OBJ:
3226+ case DEF_GROUP:
3227+ case DEF_CLASS_OBJ:
3228+ case DEF_OTHER_OBJ:
3229+ return aclp->a_perm;
3230+ default:
3231+ return 0;
3232+ }
3233+}
3234+
3235+/* acl_sort for HPUX.
3236+ * Sorts the array of ACL structures as per the description in
3237+ * aclsort man page. Refer to aclsort man page for more details
3238+ *
3239+ * Inputs:
3240+ *
3241+ * acl_count - Count of ACLs in the array of ACL structures.
3242+ * calclass - If this is not zero, then we compute the CLASS_OBJ
3243+ * permissions.
3244+ * aclp - Array of ACL structures.
3245+ *
3246+ * Outputs:
3247+ *
3248+ * aclp - Sorted array of ACL structures.
3249+ *
3250+ * Outputs:
3251+ *
3252+ * Returns 0 for success -1 for failure. Prints a message to the Samba
3253+ * debug log in case of failure.
3254+ */
3255+
3256+static int hpux_acl_sort(int acl_count, int calclass, struct acl *aclp)
3257+{
3258+#if !defined(HAVE_HPUX_ACLSORT)
3259+ /*
3260+ * The aclsort() system call is availabe on the latest HPUX General
3261+ * Patch Bundles. So for HPUX, we developed our version of acl_sort
3262+ * function. Because, we don't want to update to a new
3263+ * HPUX GR bundle just for aclsort() call.
3264+ */
3265+
3266+ struct hpux_acl_types acl_obj_count;
3267+ int n_class_obj_perm = 0;
3268+ int i, j;
3269+
3270+ if(!acl_count) {
3271+ DEBUG(10,("Zero acl count passed. Returning Success\n"));
3272+ return 0;
3273+ }
3274+
3275+ if(aclp == NULL) {
3276+ DEBUG(0,("Null ACL pointer in hpux_acl_sort. Returning Failure. \n"));
3277+ return -1;
3278+ }
3279+
3280+ /* Count different types of ACLs in the ACLs array */
3281+
3282+ hpux_count_obj(acl_count, aclp, &acl_obj_count);
3283+
3284+ /* There should be only one entry each of type USER_OBJ, GROUP_OBJ,
3285+ * CLASS_OBJ and OTHER_OBJ
3286+ */
3287+
3288+ if( (acl_obj_count.n_user_obj != 1) ||
3289+ (acl_obj_count.n_group_obj != 1) ||
3290+ (acl_obj_count.n_class_obj != 1) ||
3291+ (acl_obj_count.n_other_obj != 1)
3292+ ) {
3293+ DEBUG(0,("hpux_acl_sort: More than one entry or no entries for \
3294+USER OBJ or GROUP_OBJ or OTHER_OBJ or CLASS_OBJ\n"));
3295+ return -1;
3296+ }
3297+
3298+ /* If any of the default objects are present, there should be only
3299+ * one of them each.
3300+ */
3301+
3302+ if( (acl_obj_count.n_def_user_obj > 1) || (acl_obj_count.n_def_group_obj > 1) ||
3303+ (acl_obj_count.n_def_other_obj > 1) || (acl_obj_count.n_def_class_obj > 1) ) {
3304+ DEBUG(0,("hpux_acl_sort: More than one entry for DEF_CLASS_OBJ \
3305+or DEF_USER_OBJ or DEF_GROUP_OBJ or DEF_OTHER_OBJ\n"));
3306+ return -1;
3307+ }
3308+
3309+ /* We now have proper number of OBJ and DEF_OBJ entries. Now sort the acl
3310+ * structures.
3311+ *
3312+ * Sorting crieteria - First sort by ACL type. If there are multiple entries of
3313+ * same ACL type, sort by ACL id.
3314+ *
3315+ * I am using the trival kind of sorting method here because, performance isn't
3316+ * really effected by the ACLs feature. More over there aren't going to be more
3317+ * than 17 entries on HPUX.
3318+ */
3319+
3320+ for(i=0; i<acl_count;i++) {
3321+ for (j=i+1; j<acl_count; j++) {
3322+ if( aclp[i].a_type > aclp[j].a_type ) {
3323+ /* ACL entries out of order, swap them */
3324+
3325+ hpux_swap_acl_entries((aclp+i), (aclp+j));
3326+
3327+ } else if ( aclp[i].a_type == aclp[j].a_type ) {
3328+
3329+ /* ACL entries of same type, sort by id */
3330+
3331+ if(aclp[i].a_id > aclp[j].a_id) {
3332+ hpux_swap_acl_entries((aclp+i), (aclp+j));
3333+ } else if (aclp[i].a_id == aclp[j].a_id) {
3334+ /* We have a duplicate entry. */
3335+ if(hpux_prohibited_duplicate_type(aclp[i].a_type)) {
3336+ DEBUG(0, ("hpux_acl_sort: Duplicate entry: Type(hex): %x Id: %d\n",
3337+ aclp[i].a_type, aclp[i].a_id));
3338+ return -1;
3339+ }
3340+ }
3341+
3342+ }
3343+ }
3344+ }
3345+
3346+ /* set the class obj permissions to the computed one. */
3347+ if(calclass) {
3348+ int n_class_obj_index = -1;
3349+
3350+ for(i=0;i<acl_count;i++) {
3351+ n_class_obj_perm |= hpux_get_needed_class_perm((aclp+i));
3352+
3353+ if(aclp[i].a_type == CLASS_OBJ)
3354+ n_class_obj_index = i;
3355+ }
3356+ aclp[n_class_obj_index].a_perm = n_class_obj_perm;
3357+ }
3358+
3359+ return 0;
3360+#else
3361+ return aclsort(acl_count, calclass, aclp);
3362+#endif
3363+}
3364+
3365+/*
3366+ * sort the ACL and check it for validity
3367+ *
3368+ * if it's a minimal ACL with only 4 entries then we
3369+ * need to recalculate the mask permissions to make
3370+ * sure that they are the same as the GROUP_OBJ
3371+ * permissions as required by the UnixWare acl() system call.
3372+ *
3373+ * (note: since POSIX allows minimal ACLs which only contain
3374+ * 3 entries - ie there is no mask entry - we should, in theory,
3375+ * check for this and add a mask entry if necessary - however
3376+ * we "know" that the caller of this interface always specifies
3377+ * a mask so, in practice "this never happens" (tm) - if it *does*
3378+ * happen aclsort() will fail and return an error and someone will
3379+ * have to fix it ...)
3380+ */
3381+
3382+static int acl_sort(SMB_ACL_T acl_d)
3383+{
3384+ int fixmask = (acl_d->count <= 4);
3385+
3386+ if (hpux_acl_sort(acl_d->count, fixmask, acl_d->acl) != 0) {
3387+ errno = EINVAL;
3388+ return -1;
3389+ }
3390+ return 0;
3391+}
3392+
3393+int sys_acl_valid(SMB_ACL_T acl_d)
3394+{
3395+ return acl_sort(acl_d);
3396+}
3397+
3398+int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T type, SMB_ACL_T acl_d)
3399+{
3400+ struct stat s;
3401+ struct acl *acl_p;
3402+ int acl_count;
3403+ struct acl *acl_buf = NULL;
3404+ int ret;
3405+
3406+ if(hpux_acl_call_presence() == False) {
3407+ /* Looks like we don't have the acl() system call on HPUX.
3408+ * May be the system doesn't have the latest version of JFS.
3409+ */
3410+ errno=ENOSYS;
3411+ return -1;
3412+ }
3413+
3414+ if (type != SMB_ACL_TYPE_ACCESS && type != SMB_ACL_TYPE_DEFAULT) {
3415+ errno = EINVAL;
3416+ return -1;
3417+ }
3418+
3419+ if (acl_sort(acl_d) != 0) {
3420+ return -1;
3421+ }
3422+
3423+ acl_p = &acl_d->acl[0];
3424+ acl_count = acl_d->count;
3425+
3426+ /*
3427+ * if it's a directory there is extra work to do
3428+ * since the acl() system call will replace both
3429+ * the access ACLs and the default ACLs (if any)
3430+ */
3431+ if (stat(name, &s) != 0) {
3432+ return -1;
3433+ }
3434+ if (S_ISDIR(s.st_mode)) {
3435+ SMB_ACL_T acc_acl;
3436+ SMB_ACL_T def_acl;
3437+ SMB_ACL_T tmp_acl;
3438+ int i;
3439+
3440+ if (type == SMB_ACL_TYPE_ACCESS) {
3441+ acc_acl = acl_d;
3442+ def_acl = tmp_acl = sys_acl_get_file(name, SMB_ACL_TYPE_DEFAULT);
3443+
3444+ } else {
3445+ def_acl = acl_d;
3446+ acc_acl = tmp_acl = sys_acl_get_file(name, SMB_ACL_TYPE_ACCESS);
3447+ }
3448+
3449+ if (tmp_acl == NULL) {
3450+ return -1;
3451+ }
3452+
3453+ /*
3454+ * allocate a temporary buffer for the complete ACL
3455+ */
3456+ acl_count = acc_acl->count + def_acl->count;
3457+ acl_p = acl_buf = SMB_MALLOC_ARRAY(struct acl, acl_count);
3458+
3459+ if (acl_buf == NULL) {
3460+ sys_acl_free_acl(tmp_acl);
3461+ errno = ENOMEM;
3462+ return -1;
3463+ }
3464+
3465+ /*
3466+ * copy the access control and default entries into the buffer
3467+ */
3468+ memcpy(&acl_buf[0], &acc_acl->acl[0],
3469+ acc_acl->count * sizeof(acl_buf[0]));
3470+
3471+ memcpy(&acl_buf[acc_acl->count], &def_acl->acl[0],
3472+ def_acl->count * sizeof(acl_buf[0]));
3473+
3474+ /*
3475+ * set the ACL_DEFAULT flag on the default entries
3476+ */
3477+ for (i = acc_acl->count; i < acl_count; i++) {
3478+ acl_buf[i].a_type |= ACL_DEFAULT;
3479+ }
3480+
3481+ sys_acl_free_acl(tmp_acl);
3482+
3483+ } else if (type != SMB_ACL_TYPE_ACCESS) {
3484+ errno = EINVAL;
3485+ return -1;
3486+ }
3487+
3488+ ret = acl(name, ACL_SET, acl_count, acl_p);
3489+
3490+ if (acl_buf) {
3491+ free(acl_buf);
3492+ }
3493+
3494+ return ret;
3495+}
3496+
3497+int sys_acl_set_fd(int fd, SMB_ACL_T acl_d)
3498+{
3499+ /*
3500+ * HPUX doesn't have the facl call. Fake it using the path.... JRA.
3501+ */
3502+
3503+ files_struct *fsp = file_find_fd(fd);
3504+
3505+ if (fsp == NULL) {
3506+ errno = EBADF;
3507+ return NULL;
3508+ }
3509+
3510+ if (acl_sort(acl_d) != 0) {
3511+ return -1;
3512+ }
3513+
3514+ /*
3515+ * We know we're in the same conn context. So we
3516+ * can use the relative path.
3517+ */
3518+
3519+ return sys_acl_set_file(fsp->fsp_name, SMB_ACL_TYPE_ACCESS, acl_d);
3520+}
3521+
3522+int sys_acl_delete_def_file(const char *path)
3523+{
3524+ SMB_ACL_T acl_d;
3525+ int ret;
3526+
3527+ /*
3528+ * fetching the access ACL and rewriting it has
3529+ * the effect of deleting the default ACL
3530+ */
3531+ if ((acl_d = sys_acl_get_file(path, SMB_ACL_TYPE_ACCESS)) == NULL) {
3532+ return -1;
3533+ }
3534+
3535+ ret = acl(path, ACL_SET, acl_d->count, acl_d->acl);
3536+
3537+ sys_acl_free_acl(acl_d);
3538+
3539+ return ret;
3540+}
3541+
3542+int sys_acl_free_text(char *text)
3543+{
3544+ free(text);
3545+ return 0;
3546+}
3547+
3548+int sys_acl_free_acl(SMB_ACL_T acl_d)
3549+{
3550+ free(acl_d);
3551+ return 0;
3552+}
3553+
3554+int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype)
3555+{
3556+ return 0;
3557+}
3558+
3559+#elif defined(HAVE_IRIX_ACLS)
3560+
3561+int sys_acl_get_entry(SMB_ACL_T acl_d, int entry_id, SMB_ACL_ENTRY_T *entry_p)
3562+{
3563+ if (entry_id != SMB_ACL_FIRST_ENTRY && entry_id != SMB_ACL_NEXT_ENTRY) {
3564+ errno = EINVAL;
3565+ return -1;
3566+ }
3567+
3568+ if (entry_p == NULL) {
3569+ errno = EINVAL;
3570+ return -1;
3571+ }
3572+
3573+ if (entry_id == SMB_ACL_FIRST_ENTRY) {
3574+ acl_d->next = 0;
3575+ }
3576+
3577+ if (acl_d->next < 0) {
3578+ errno = EINVAL;
3579+ return -1;
3580+ }
3581+
3582+ if (acl_d->next >= acl_d->aclp->acl_cnt) {
3583+ return 0;
3584+ }
3585+
3586+ *entry_p = &acl_d->aclp->acl_entry[acl_d->next++];
3587+
3588+ return 1;
3589+}
3590+
3591+int sys_acl_get_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *type_p)
3592+{
3593+ *type_p = entry_d->ae_tag;
3594+
3595+ return 0;
3596+}
3597+
3598+int sys_acl_get_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
3599+{
3600+ *permset_p = entry_d;
3601+
3602+ return 0;
3603+}
3604+
3605+void *sys_acl_get_qualifier(SMB_ACL_ENTRY_T entry_d)
3606+{
3607+ if (entry_d->ae_tag != SMB_ACL_USER
3608+ && entry_d->ae_tag != SMB_ACL_GROUP) {
3609+ errno = EINVAL;
3610+ return NULL;
3611+ }
3612+
3613+ return &entry_d->ae_id;
3614+}
3615+
3616+SMB_ACL_T sys_acl_get_file(const char *path_p, SMB_ACL_TYPE_T type)
3617+{
3618+ SMB_ACL_T a;
3619+
3620+ if ((a = SMB_MALLOC_P(struct SMB_ACL_T)) == NULL) {
3621+ errno = ENOMEM;
3622+ return NULL;
3623+ }
3624+ if ((a->aclp = acl_get_file(path_p, type)) == NULL) {
3625+ SAFE_FREE(a);
3626+ return NULL;
3627+ }
3628+ a->next = -1;
3629+ a->freeaclp = True;
3630+ return a;
3631+}
3632+
3633+SMB_ACL_T sys_acl_get_fd(int fd)
3634+{
3635+ SMB_ACL_T a;
3636+
3637+ if ((a = SMB_MALLOC_P(struct SMB_ACL_T)) == NULL) {
3638+ errno = ENOMEM;
3639+ return NULL;
3640+ }
3641+ if ((a->aclp = acl_get_fd(fd)) == NULL) {
3642+ SAFE_FREE(a);
3643+ return NULL;
3644+ }
3645+ a->next = -1;
3646+ a->freeaclp = True;
3647+ return a;
3648+}
3649+
3650+int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset_d)
3651+{
3652+ permset_d->ae_perm = 0;
3653+
3654+ return 0;
3655+}
3656+
3657+int sys_acl_add_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
3658+{
3659+ if (perm != SMB_ACL_READ && perm != SMB_ACL_WRITE
3660+ && perm != SMB_ACL_EXECUTE) {
3661+ errno = EINVAL;
3662+ return -1;
3663+ }
3664+
3665+ if (permset_d == NULL) {
3666+ errno = EINVAL;
3667+ return -1;
3668+ }
3669+
3670+ permset_d->ae_perm |= perm;
3671+
3672+ return 0;
3673+}
3674+
3675+int sys_acl_get_perm(SMB_ACL_PERMSET_T permset_d, SMB_ACL_PERM_T perm)
3676+{
3677+ return permset_d->ae_perm & perm;
3678+}
3679+
3680+char *sys_acl_to_text(SMB_ACL_T acl_d, ssize_t *len_p)
3681+{
3682+ return acl_to_text(acl_d->aclp, len_p);
3683+}
3684+
3685+SMB_ACL_T sys_acl_init(int count)
3686+{
3687+ SMB_ACL_T a;
3688+
3689+ if (count < 0) {
3690+ errno = EINVAL;
3691+ return NULL;
3692+ }
3693+
3694+ if ((a = SMB_MALLOC(sizeof(struct SMB_ACL_T) + sizeof(struct acl))) == NULL) {
3695+ errno = ENOMEM;
3696+ return NULL;
3697+ }
3698+
3699+ a->next = -1;
3700+ a->freeaclp = False;
3701+ a->aclp = (struct acl *)(&a->aclp + sizeof(struct acl *));
3702+ a->aclp->acl_cnt = 0;
3703+
3704+ return a;
3705+}
3706+
3707+
3708+int sys_acl_create_entry(SMB_ACL_T *acl_p, SMB_ACL_ENTRY_T *entry_p)
3709+{
3710+ SMB_ACL_T acl_d;
3711+ SMB_ACL_ENTRY_T entry_d;
3712+
3713+ if (acl_p == NULL || entry_p == NULL || (acl_d = *acl_p) == NULL) {
3714+ errno = EINVAL;
3715+ return -1;
3716+ }
3717+
3718+ if (acl_d->aclp->acl_cnt >= ACL_MAX_ENTRIES) {
3719+ errno = ENOSPC;
3720+ return -1;
3721+ }
3722+
3723+ entry_d = &acl_d->aclp->acl_entry[acl_d->aclp->acl_cnt++];
3724+ entry_d->ae_tag = 0;
3725+ entry_d->ae_id = 0;
3726+ entry_d->ae_perm = 0;
3727+ *entry_p = entry_d;
3728+
3729+ return 0;
3730+}
3731+
3732+int sys_acl_set_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T tag_type)
3733+{
3734+ switch (tag_type) {
3735+ case SMB_ACL_USER:
3736+ case SMB_ACL_USER_OBJ:
3737+ case SMB_ACL_GROUP:
3738+ case SMB_ACL_GROUP_OBJ:
3739+ case SMB_ACL_OTHER:
3740+ case SMB_ACL_MASK:
3741+ entry_d->ae_tag = tag_type;
3742+ break;
3743+ default:
3744+ errno = EINVAL;
3745+ return -1;
3746+ }
3747+
3748+ return 0;
3749+}
3750+
3751+int sys_acl_set_qualifier(SMB_ACL_ENTRY_T entry_d, void *qual_p)
3752+{
3753+ if (entry_d->ae_tag != SMB_ACL_GROUP
3754+ && entry_d->ae_tag != SMB_ACL_USER) {
3755+ errno = EINVAL;
3756+ return -1;
3757+ }
3758+
3759+ entry_d->ae_id = *((id_t *)qual_p);
3760+
3761+ return 0;
3762+}
3763+
3764+int sys_acl_set_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T permset_d)
3765+{
3766+ if (permset_d->ae_perm & ~(SMB_ACL_READ|SMB_ACL_WRITE|SMB_ACL_EXECUTE)) {
3767+ return EINVAL;
3768+ }
3769+
3770+ entry_d->ae_perm = permset_d->ae_perm;
3771+
3772+ return 0;
3773+}
3774+
3775+int sys_acl_valid(SMB_ACL_T acl_d)
3776+{
3777+ return acl_valid(acl_d->aclp);
3778+}
3779+
3780+int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T type, SMB_ACL_T acl_d)
3781+{
3782+ return acl_set_file(name, type, acl_d->aclp);
3783+}
3784+
3785+int sys_acl_set_fd(int fd, SMB_ACL_T acl_d)
3786+{
3787+ return acl_set_fd(fd, acl_d->aclp);
3788+}
3789+
3790+int sys_acl_delete_def_file(const char *name)
3791+{
3792+ return acl_delete_def_file(name);
3793+}
3794+
3795+int sys_acl_free_text(char *text)
3796+{
3797+ return acl_free(text);
3798+}
3799+
3800+int sys_acl_free_acl(SMB_ACL_T acl_d)
3801+{
3802+ if (acl_d->freeaclp) {
3803+ acl_free(acl_d->aclp);
3804+ }
3805+ acl_free(acl_d);
3806+ return 0;
3807+}
3808+
3809+int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype)
3810+{
3811+ return 0;
3812+}
3813+
3814+#elif defined(HAVE_AIX_ACLS)
3815+
3816+/* Donated by Medha Date, mdate@austin.ibm.com, for IBM */
3817+
3818+int sys_acl_get_entry( SMB_ACL_T theacl, int entry_id, SMB_ACL_ENTRY_T *entry_p)
3819+{
3820+ struct acl_entry_link *link;
3821+ struct new_acl_entry *entry;
3822+ int keep_going;
3823+
3824+ DEBUG(10,("This is the count: %d\n",theacl->count));
3825+
3826+ /* Check if count was previously set to -1. *
3827+ * If it was, that means we reached the end *
3828+ * of the acl last time. */
3829+ if(theacl->count == -1)
3830+ return(0);
3831+
3832+ link = theacl;
3833+ /* To get to the next acl, traverse linked list until index *
3834+ * of acl matches the count we are keeping. This count is *
3835+ * incremented each time we return an acl entry. */
3836+
3837+ for(keep_going = 0; keep_going < theacl->count; keep_going++)
3838+ link = link->nextp;
3839+
3840+ entry = *entry_p = link->entryp;
3841+
3842+ DEBUG(10,("*entry_p is %d\n",entry_p));
3843+ DEBUG(10,("*entry_p->ace_access is %d\n",entry->ace_access));
3844+
3845+ /* Increment count */
3846+ theacl->count++;
3847+ if(link->nextp == NULL)
3848+ theacl->count = -1;
3849+
3850+ return(1);
3851+}
3852+
3853+int sys_acl_get_tag_type( SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p)
3854+{
3855+ /* Initialize tag type */
3856+
3857+ *tag_type_p = -1;
3858+ DEBUG(10,("the tagtype is %d\n",entry_d->ace_id->id_type));
3859+
3860+ /* Depending on what type of entry we have, *
3861+ * return tag type. */
3862+ switch(entry_d->ace_id->id_type) {
3863+ case ACEID_USER:
3864+ *tag_type_p = SMB_ACL_USER;
3865+ break;
3866+ case ACEID_GROUP:
3867+ *tag_type_p = SMB_ACL_GROUP;
3868+ break;
3869+
3870+ case SMB_ACL_USER_OBJ:
3871+ case SMB_ACL_GROUP_OBJ:
3872+ case SMB_ACL_OTHER:
3873+ *tag_type_p = entry_d->ace_id->id_type;
3874+ break;
3875+
3876+ default:
3877+ return(-1);
3878+ }
3879+
3880+ return(0);
3881+}
3882+
3883+int sys_acl_get_permset( SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p)
3884+{
3885+ DEBUG(10,("Starting AIX sys_acl_get_permset\n"));
3886+ *permset_p = &entry_d->ace_access;
3887+ DEBUG(10,("**permset_p is %d\n",**permset_p));
3888+ if(!(**permset_p & S_IXUSR) &&
3889+ !(**permset_p & S_IWUSR) &&
3890+ !(**permset_p & S_IRUSR) &&
3891+ (**permset_p != 0))
3892+ return(-1);
3893+
3894+ DEBUG(10,("Ending AIX sys_acl_get_permset\n"));
3895+ return(0);
3896+}
3897+
3898+void *sys_acl_get_qualifier( SMB_ACL_ENTRY_T entry_d)
3899+{
3900+ return(entry_d->ace_id->id_data);
3901+}
3902+
3903+SMB_ACL_T sys_acl_get_file( const char *path_p, SMB_ACL_TYPE_T type)
3904+{
3905+ struct acl *file_acl = (struct acl *)NULL;
3906+ struct acl_entry *acl_entry;
3907+ struct new_acl_entry *new_acl_entry;
3908+ struct ace_id *idp;
3909+ struct acl_entry_link *acl_entry_link;
3910+ struct acl_entry_link *acl_entry_link_head;
3911+ int i;
3912+ int rc = 0;
3913+ uid_t user_id;
3914+
3915+ /* AIX has no DEFAULT */
3916+ if ( type == SMB_ACL_TYPE_DEFAULT )
3917+ return NULL;
3918+
3919+ /* Get the acl using statacl */
3920+
3921+ DEBUG(10,("Entering sys_acl_get_file\n"));
3922+ DEBUG(10,("path_p is %s\n",path_p));
3923+
3924+ file_acl = (struct acl *)SMB_MALLOC(BUFSIZ);
3925+
3926+ if(file_acl == NULL) {
3927+ errno=ENOMEM;
3928+ DEBUG(0,("Error in AIX sys_acl_get_file: %d\n",errno));
3929+ return(NULL);
3930+ }
3931+
3932+ memset(file_acl,0,BUFSIZ);
3933+
3934+ rc = statacl((char *)path_p,0,file_acl,BUFSIZ);
3935+ if(rc == -1) {
3936+ DEBUG(0,("statacl returned %d with errno %d\n",rc,errno));
3937+ SAFE_FREE(file_acl);
3938+ return(NULL);
3939+ }
3940+
3941+ DEBUG(10,("Got facl and returned it\n"));
3942+
3943+ /* Point to the first acl entry in the acl */
3944+ acl_entry = file_acl->acl_ext;
3945+
3946+ /* Begin setting up the head of the linked list *
3947+ * that will be used for the storing the acl *
3948+ * in a way that is useful for the posix_acls.c *
3949+ * code. */
3950+
3951+ acl_entry_link_head = acl_entry_link = sys_acl_init(0);
3952+ if(acl_entry_link_head == NULL)
3953+ return(NULL);
3954+
3955+ acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
3956+ if(acl_entry_link->entryp == NULL) {
3957+ SAFE_FREE(file_acl);
3958+ errno = ENOMEM;
3959+ DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
3960+ return(NULL);
3961+ }
3962+
3963+ DEBUG(10,("acl_entry is %d\n",acl_entry));
3964+ DEBUG(10,("acl_last(file_acl) id %d\n",acl_last(file_acl)));
3965+
3966+ /* Check if the extended acl bit is on. *
3967+ * If it isn't, do not show the *
3968+ * contents of the acl since AIX intends *
3969+ * the extended info to remain unused */
3970+
3971+ if(file_acl->acl_mode & S_IXACL){
3972+ /* while we are not pointing to the very end */
3973+ while(acl_entry < acl_last(file_acl)) {
3974+ /* before we malloc anything, make sure this is */
3975+ /* a valid acl entry and one that we want to map */
3976+ idp = id_nxt(acl_entry->ace_id);
3977+ if((acl_entry->ace_type == ACC_SPECIFY ||
3978+ (acl_entry->ace_type == ACC_PERMIT)) && (idp != id_last(acl_entry))) {
3979+ acl_entry = acl_nxt(acl_entry);
3980+ continue;
3981+ }
3982+
3983+ idp = acl_entry->ace_id;
3984+
3985+ /* Check if this is the first entry in the linked list. *
3986+ * The first entry needs to keep prevp pointing to NULL *
3987+ * and already has entryp allocated. */
3988+
3989+ if(acl_entry_link_head->count != 0) {
3990+ acl_entry_link->nextp = SMB_MALLOC_P(struct acl_entry_link);
3991+
3992+ if(acl_entry_link->nextp == NULL) {
3993+ SAFE_FREE(file_acl);
3994+ errno = ENOMEM;
3995+ DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
3996+ return(NULL);
3997+ }
3998+
3999+ acl_entry_link->nextp->prevp = acl_entry_link;
4000+ acl_entry_link = acl_entry_link->nextp;
4001+ acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4002+ if(acl_entry_link->entryp == NULL) {
4003+ SAFE_FREE(file_acl);
4004+ errno = ENOMEM;
4005+ DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
4006+ return(NULL);
4007+ }
4008+ acl_entry_link->nextp = NULL;
4009+ }
4010+
4011+ acl_entry_link->entryp->ace_len = acl_entry->ace_len;
4012+
4013+ /* Don't really need this since all types are going *
4014+ * to be specified but, it's better than leaving it 0 */
4015+
4016+ acl_entry_link->entryp->ace_type = acl_entry->ace_type;
4017+
4018+ acl_entry_link->entryp->ace_access = acl_entry->ace_access;
4019+
4020+ memcpy(acl_entry_link->entryp->ace_id,idp,sizeof(struct ace_id));
4021+
4022+ /* The access in the acl entries must be left shifted by *
4023+ * three bites, because they will ultimately be compared *
4024+ * to S_IRUSR, S_IWUSR, and S_IXUSR. */
4025+
4026+ switch(acl_entry->ace_type){
4027+ case ACC_PERMIT:
4028+ case ACC_SPECIFY:
4029+ acl_entry_link->entryp->ace_access = acl_entry->ace_access;
4030+ acl_entry_link->entryp->ace_access <<= 6;
4031+ acl_entry_link_head->count++;
4032+ break;
4033+ case ACC_DENY:
4034+ /* Since there is no way to return a DENY acl entry *
4035+ * change to PERMIT and then shift. */
4036+ DEBUG(10,("acl_entry->ace_access is %d\n",acl_entry->ace_access));
4037+ acl_entry_link->entryp->ace_access = ~acl_entry->ace_access & 7;
4038+ DEBUG(10,("acl_entry_link->entryp->ace_access is %d\n",acl_entry_link->entryp->ace_access));
4039+ acl_entry_link->entryp->ace_access <<= 6;
4040+ acl_entry_link_head->count++;
4041+ break;
4042+ default:
4043+ return(0);
4044+ }
4045+
4046+ DEBUG(10,("acl_entry = %d\n",acl_entry));
4047+ DEBUG(10,("The ace_type is %d\n",acl_entry->ace_type));
4048+
4049+ acl_entry = acl_nxt(acl_entry);
4050+ }
4051+ } /* end of if enabled */
4052+
4053+ /* Since owner, group, other acl entries are not *
4054+ * part of the acl entries in an acl, they must *
4055+ * be dummied up to become part of the list. */
4056+
4057+ for( i = 1; i < 4; i++) {
4058+ DEBUG(10,("i is %d\n",i));
4059+ if(acl_entry_link_head->count != 0) {
4060+ acl_entry_link->nextp = SMB_MALLOC_P(struct acl_entry_link);
4061+ if(acl_entry_link->nextp == NULL) {
4062+ SAFE_FREE(file_acl);
4063+ errno = ENOMEM;
4064+ DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
4065+ return(NULL);
4066+ }
4067+
4068+ acl_entry_link->nextp->prevp = acl_entry_link;
4069+ acl_entry_link = acl_entry_link->nextp;
4070+ acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4071+ if(acl_entry_link->entryp == NULL) {
4072+ SAFE_FREE(file_acl);
4073+ errno = ENOMEM;
4074+ DEBUG(0,("Error in AIX sys_acl_get_file is %d\n",errno));
4075+ return(NULL);
4076+ }
4077+ }
4078+
4079+ acl_entry_link->nextp = NULL;
4080+
4081+ new_acl_entry = acl_entry_link->entryp;
4082+ idp = new_acl_entry->ace_id;
4083+
4084+ new_acl_entry->ace_len = sizeof(struct acl_entry);
4085+ new_acl_entry->ace_type = ACC_PERMIT;
4086+ idp->id_len = sizeof(struct ace_id);
4087+ DEBUG(10,("idp->id_len = %d\n",idp->id_len));
4088+ memset(idp->id_data,0,sizeof(uid_t));
4089+
4090+ switch(i) {
4091+ case 2:
4092+ new_acl_entry->ace_access = file_acl->g_access << 6;
4093+ idp->id_type = SMB_ACL_GROUP_OBJ;
4094+ break;
4095+
4096+ case 3:
4097+ new_acl_entry->ace_access = file_acl->o_access << 6;
4098+ idp->id_type = SMB_ACL_OTHER;
4099+ break;
4100+
4101+ case 1:
4102+ new_acl_entry->ace_access = file_acl->u_access << 6;
4103+ idp->id_type = SMB_ACL_USER_OBJ;
4104+ break;
4105+
4106+ default:
4107+ return(NULL);
4108+
4109+ }
4110+
4111+ acl_entry_link_head->count++;
4112+ DEBUG(10,("new_acl_entry->ace_access = %d\n",new_acl_entry->ace_access));
4113+ }
4114+
4115+ acl_entry_link_head->count = 0;
4116+ SAFE_FREE(file_acl);
4117+
4118+ return(acl_entry_link_head);
4119+}
4120+
4121+SMB_ACL_T sys_acl_get_fd(int fd)
4122+{
4123+ struct acl *file_acl = (struct acl *)NULL;
4124+ struct acl_entry *acl_entry;
4125+ struct new_acl_entry *new_acl_entry;
4126+ struct ace_id *idp;
4127+ struct acl_entry_link *acl_entry_link;
4128+ struct acl_entry_link *acl_entry_link_head;
4129+ int i;
4130+ int rc = 0;
4131+ uid_t user_id;
4132+
4133+ /* Get the acl using fstatacl */
4134+
4135+ DEBUG(10,("Entering sys_acl_get_fd\n"));
4136+ DEBUG(10,("fd is %d\n",fd));
4137+ file_acl = (struct acl *)SMB_MALLOC(BUFSIZ);
4138+
4139+ if(file_acl == NULL) {
4140+ errno=ENOMEM;
4141+ DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
4142+ return(NULL);
4143+ }
4144+
4145+ memset(file_acl,0,BUFSIZ);
4146+
4147+ rc = fstatacl(fd,0,file_acl,BUFSIZ);
4148+ if(rc == -1) {
4149+ DEBUG(0,("The fstatacl call returned %d with errno %d\n",rc,errno));
4150+ SAFE_FREE(file_acl);
4151+ return(NULL);
4152+ }
4153+
4154+ DEBUG(10,("Got facl and returned it\n"));
4155+
4156+ /* Point to the first acl entry in the acl */
4157+
4158+ acl_entry = file_acl->acl_ext;
4159+ /* Begin setting up the head of the linked list *
4160+ * that will be used for the storing the acl *
4161+ * in a way that is useful for the posix_acls.c *
4162+ * code. */
4163+
4164+ acl_entry_link_head = acl_entry_link = sys_acl_init(0);
4165+ if(acl_entry_link_head == NULL){
4166+ SAFE_FREE(file_acl);
4167+ return(NULL);
4168+ }
4169+
4170+ acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4171+
4172+ if(acl_entry_link->entryp == NULL) {
4173+ errno = ENOMEM;
4174+ DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
4175+ SAFE_FREE(file_acl);
4176+ return(NULL);
4177+ }
4178+
4179+ DEBUG(10,("acl_entry is %d\n",acl_entry));
4180+ DEBUG(10,("acl_last(file_acl) id %d\n",acl_last(file_acl)));
4181+
4182+ /* Check if the extended acl bit is on. *
4183+ * If it isn't, do not show the *
4184+ * contents of the acl since AIX intends *
4185+ * the extended info to remain unused */
4186+
4187+ if(file_acl->acl_mode & S_IXACL){
4188+ /* while we are not pointing to the very end */
4189+ while(acl_entry < acl_last(file_acl)) {
4190+ /* before we malloc anything, make sure this is */
4191+ /* a valid acl entry and one that we want to map */
4192+
4193+ idp = id_nxt(acl_entry->ace_id);
4194+ if((acl_entry->ace_type == ACC_SPECIFY ||
4195+ (acl_entry->ace_type == ACC_PERMIT)) && (idp != id_last(acl_entry))) {
4196+ acl_entry = acl_nxt(acl_entry);
4197+ continue;
4198+ }
4199+
4200+ idp = acl_entry->ace_id;
4201+
4202+ /* Check if this is the first entry in the linked list. *
4203+ * The first entry needs to keep prevp pointing to NULL *
4204+ * and already has entryp allocated. */
4205+
4206+ if(acl_entry_link_head->count != 0) {
4207+ acl_entry_link->nextp = SMB_MALLOC_P(struct acl_entry_link);
4208+ if(acl_entry_link->nextp == NULL) {
4209+ errno = ENOMEM;
4210+ DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
4211+ SAFE_FREE(file_acl);
4212+ return(NULL);
4213+ }
4214+ acl_entry_link->nextp->prevp = acl_entry_link;
4215+ acl_entry_link = acl_entry_link->nextp;
4216+ acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4217+ if(acl_entry_link->entryp == NULL) {
4218+ errno = ENOMEM;
4219+ DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
4220+ SAFE_FREE(file_acl);
4221+ return(NULL);
4222+ }
4223+
4224+ acl_entry_link->nextp = NULL;
4225+ }
4226+
4227+ acl_entry_link->entryp->ace_len = acl_entry->ace_len;
4228+
4229+ /* Don't really need this since all types are going *
4230+ * to be specified but, it's better than leaving it 0 */
4231+
4232+ acl_entry_link->entryp->ace_type = acl_entry->ace_type;
4233+ acl_entry_link->entryp->ace_access = acl_entry->ace_access;
4234+
4235+ memcpy(acl_entry_link->entryp->ace_id, idp, sizeof(struct ace_id));
4236+
4237+ /* The access in the acl entries must be left shifted by *
4238+ * three bites, because they will ultimately be compared *
4239+ * to S_IRUSR, S_IWUSR, and S_IXUSR. */
4240+
4241+ switch(acl_entry->ace_type){
4242+ case ACC_PERMIT:
4243+ case ACC_SPECIFY:
4244+ acl_entry_link->entryp->ace_access = acl_entry->ace_access;
4245+ acl_entry_link->entryp->ace_access <<= 6;
4246+ acl_entry_link_head->count++;
4247+ break;
4248+ case ACC_DENY:
4249+ /* Since there is no way to return a DENY acl entry *
4250+ * change to PERMIT and then shift. */
4251+ DEBUG(10,("acl_entry->ace_access is %d\n",acl_entry->ace_access));
4252+ acl_entry_link->entryp->ace_access = ~acl_entry->ace_access & 7;
4253+ DEBUG(10,("acl_entry_link->entryp->ace_access is %d\n",acl_entry_link->entryp->ace_access));
4254+ acl_entry_link->entryp->ace_access <<= 6;
4255+ acl_entry_link_head->count++;
4256+ break;
4257+ default:
4258+ return(0);
4259+ }
4260+
4261+ DEBUG(10,("acl_entry = %d\n",acl_entry));
4262+ DEBUG(10,("The ace_type is %d\n",acl_entry->ace_type));
4263+
4264+ acl_entry = acl_nxt(acl_entry);
4265+ }
4266+ } /* end of if enabled */
4267+
4268+ /* Since owner, group, other acl entries are not *
4269+ * part of the acl entries in an acl, they must *
4270+ * be dummied up to become part of the list. */
4271+
4272+ for( i = 1; i < 4; i++) {
4273+ DEBUG(10,("i is %d\n",i));
4274+ if(acl_entry_link_head->count != 0){
4275+ acl_entry_link->nextp = SMB_MALLOC_P(struct acl_entry_link);
4276+ if(acl_entry_link->nextp == NULL) {
4277+ errno = ENOMEM;
4278+ DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
4279+ SAFE_FREE(file_acl);
4280+ return(NULL);
4281+ }
4282+
4283+ acl_entry_link->nextp->prevp = acl_entry_link;
4284+ acl_entry_link = acl_entry_link->nextp;
4285+ acl_entry_link->entryp = SMB_MALLOC_P(struct new_acl_entry);
4286+
4287+ if(acl_entry_link->entryp == NULL) {
4288+ SAFE_FREE(file_acl);
4289+ errno = ENOMEM;
4290+ DEBUG(0,("Error in sys_acl_get_fd is %d\n",errno));
4291+ return(NULL);
4292+ }
4293+ }
4294+
4295+ acl_entry_link->nextp = NULL;
4296+
4297+ new_acl_entry = acl_entry_link->entryp;
4298+ idp = new_acl_entry->ace_id;
4299+
4300+ new_acl_entry->ace_len = sizeof(struct acl_entry);
4301+ new_acl_entry->ace_type = ACC_PERMIT;
4302+ idp->id_len = sizeof(struct ace_id);
4303+ DEBUG(10,("idp->id_len = %d\n",idp->id_len));
4304+ memset(idp->id_data,0,sizeof(uid_t));
4305+
4306+ switch(i) {
4307+ case 2:
4308+ new_acl_entry->ace_access = file_acl->g_access << 6;
4309+ idp->id_type = SMB_ACL_GROUP_OBJ;
4310+ break;
4311+
4312+ case 3:
4313+ new_acl_entry->ace_access = file_acl->o_access << 6;
4314+ idp->id_type = SMB_ACL_OTHER;
4315+ break;
4316+
4317+ case 1:
4318+ new_acl_entry->ace_access = file_acl->u_access << 6;
4319+ idp->id_type = SMB_ACL_USER_OBJ;
4320+ break;
4321+
4322+ default:
4323+ return(NULL);
4324+ }
4325+
4326+ acl_entry_link_head->count++;
4327+ DEBUG(10,("new_acl_entry->ace_access = %d\n",new_acl_entry->ace_access));
4328+ }
4329+
4330+ acl_entry_link_head->count = 0;
4331+ SAFE_FREE(file_acl);
4332+
4333+ return(acl_entry_link_head);
4334+}
4335+
4336+int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset)
4337+{
4338+ *permset = *permset & ~0777;
4339+ return(0);
4340+}
4341+
4342+int sys_acl_add_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
4343+{
4344+ if((perm != 0) &&
4345+ (perm & (S_IXUSR | S_IWUSR | S_IRUSR)) == 0)
4346+ return(-1);
4347+
4348+ *permset |= perm;
4349+ DEBUG(10,("This is the permset now: %d\n",*permset));
4350+ return(0);
4351+}
4352+
4353+char *sys_acl_to_text( SMB_ACL_T theacl, ssize_t *plen)
4354+{
4355+ return(NULL);
4356+}
4357+
4358+SMB_ACL_T sys_acl_init( int count)
4359+{
4360+ struct acl_entry_link *theacl = NULL;
4361+
4362+ DEBUG(10,("Entering sys_acl_init\n"));
4363+
4364+ theacl = SMB_MALLOC_P(struct acl_entry_link);
4365+ if(theacl == NULL) {
4366+ errno = ENOMEM;
4367+ DEBUG(0,("Error in sys_acl_init is %d\n",errno));
4368+ return(NULL);
4369+ }
4370+
4371+ theacl->count = 0;
4372+ theacl->nextp = NULL;
4373+ theacl->prevp = NULL;
4374+ theacl->entryp = NULL;
4375+ DEBUG(10,("Exiting sys_acl_init\n"));
4376+ return(theacl);
4377+}
4378+
4379+int sys_acl_create_entry( SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry)
4380+{
4381+ struct acl_entry_link *theacl;
4382+ struct acl_entry_link *acl_entryp;
4383+ struct acl_entry_link *temp_entry;
4384+ int counting;
4385+
4386+ DEBUG(10,("Entering the sys_acl_create_entry\n"));
4387+
4388+ theacl = acl_entryp = *pacl;
4389+
4390+ /* Get to the end of the acl before adding entry */
4391+
4392+ for(counting=0; counting < theacl->count; counting++){
4393+ DEBUG(10,("The acl_entryp is %d\n",acl_entryp));
4394+ temp_entry = acl_entryp;
4395+ acl_entryp = acl_entryp->nextp;
4396+ }
4397+
4398+ if(theacl->count != 0){
4399+ temp_entry->nextp = acl_entryp = SMB_MALLOC_P(struct acl_entry_link);
4400+ if(acl_entryp == NULL) {
4401+ errno = ENOMEM;
4402+ DEBUG(0,("Error in sys_acl_create_entry is %d\n",errno));
4403+ return(-1);
4404+ }
4405+
4406+ DEBUG(10,("The acl_entryp is %d\n",acl_entryp));
4407+ acl_entryp->prevp = temp_entry;
4408+ DEBUG(10,("The acl_entryp->prevp is %d\n",acl_entryp->prevp));
4409+ }
4410+
4411+ *pentry = acl_entryp->entryp = SMB_MALLOC_P(struct new_acl_entry);
4412+ if(*pentry == NULL) {
4413+ errno = ENOMEM;
4414+ DEBUG(0,("Error in sys_acl_create_entry is %d\n",errno));
4415+ return(-1);
4416+ }
4417+
4418+ memset(*pentry,0,sizeof(struct new_acl_entry));
4419+ acl_entryp->entryp->ace_len = sizeof(struct acl_entry);
4420+ acl_entryp->entryp->ace_type = ACC_PERMIT;
4421+ acl_entryp->entryp->ace_id->id_len = sizeof(struct ace_id);
4422+ acl_entryp->nextp = NULL;
4423+ theacl->count++;
4424+ DEBUG(10,("Exiting sys_acl_create_entry\n"));
4425+ return(0);
4426+}
4427+
4428+int sys_acl_set_tag_type( SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype)
4429+{
4430+ DEBUG(10,("Starting AIX sys_acl_set_tag_type\n"));
4431+ entry->ace_id->id_type = tagtype;
4432+ DEBUG(10,("The tag type is %d\n",entry->ace_id->id_type));
4433+ DEBUG(10,("Ending AIX sys_acl_set_tag_type\n"));
4434+}
4435+
4436+int sys_acl_set_qualifier( SMB_ACL_ENTRY_T entry, void *qual)
4437+{
4438+ DEBUG(10,("Starting AIX sys_acl_set_qualifier\n"));
4439+ memcpy(entry->ace_id->id_data,qual,sizeof(uid_t));
4440+ DEBUG(10,("Ending AIX sys_acl_set_qualifier\n"));
4441+ return(0);
4442+}
4443+
4444+int sys_acl_set_permset( SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset)
4445+{
4446+ DEBUG(10,("Starting AIX sys_acl_set_permset\n"));
4447+ if(!(*permset & S_IXUSR) &&
4448+ !(*permset & S_IWUSR) &&
4449+ !(*permset & S_IRUSR) &&
4450+ (*permset != 0))
4451+ return(-1);
4452+
4453+ entry->ace_access = *permset;
4454+ DEBUG(10,("entry->ace_access = %d\n",entry->ace_access));
4455+ DEBUG(10,("Ending AIX sys_acl_set_permset\n"));
4456+ return(0);
4457+}
4458+
4459+int sys_acl_valid( SMB_ACL_T theacl )
4460+{
4461+ int user_obj = 0;
4462+ int group_obj = 0;
4463+ int other_obj = 0;
4464+ struct acl_entry_link *acl_entry;
4465+
4466+ for(acl_entry=theacl; acl_entry != NULL; acl_entry = acl_entry->nextp) {
4467+ user_obj += (acl_entry->entryp->ace_id->id_type == SMB_ACL_USER_OBJ);
4468+ group_obj += (acl_entry->entryp->ace_id->id_type == SMB_ACL_GROUP_OBJ);
4469+ other_obj += (acl_entry->entryp->ace_id->id_type == SMB_ACL_OTHER);
4470+ }
4471+
4472+ DEBUG(10,("user_obj=%d, group_obj=%d, other_obj=%d\n",user_obj,group_obj,other_obj));
4473+
4474+ if(user_obj != 1 || group_obj != 1 || other_obj != 1)
4475+ return(-1);
4476+
4477+ return(0);
4478+}
4479+
4480+int sys_acl_set_file( const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl)
4481+{
4482+ struct acl_entry_link *acl_entry_link = NULL;
4483+ struct acl *file_acl = NULL;
4484+ struct acl *file_acl_temp = NULL;
4485+ struct acl_entry *acl_entry = NULL;
4486+ struct ace_id *ace_id = NULL;
4487+ uint id_type;
4488+ uint ace_access;
4489+ uint user_id;
4490+ uint acl_length;
4491+ uint rc;
4492+
4493+ DEBUG(10,("Entering sys_acl_set_file\n"));
4494+ DEBUG(10,("File name is %s\n",name));
4495+
4496+ /* AIX has no default ACL */
4497+ if(acltype == SMB_ACL_TYPE_DEFAULT)
4498+ return(0);
4499+
4500+ acl_length = BUFSIZ;
4501+ file_acl = (struct acl *)SMB_MALLOC(BUFSIZ);
4502+
4503+ if(file_acl == NULL) {
4504+ errno = ENOMEM;
4505+ DEBUG(0,("Error in sys_acl_set_file is %d\n",errno));
4506+ return(-1);
4507+ }
4508+
4509+ memset(file_acl,0,BUFSIZ);
4510+
4511+ file_acl->acl_len = ACL_SIZ;
4512+ file_acl->acl_mode = S_IXACL;
4513+
4514+ for(acl_entry_link=theacl; acl_entry_link != NULL; acl_entry_link = acl_entry_link->nextp) {
4515+ acl_entry_link->entryp->ace_access >>= 6;
4516+ id_type = acl_entry_link->entryp->ace_id->id_type;
4517+
4518+ switch(id_type) {
4519+ case SMB_ACL_USER_OBJ:
4520+ file_acl->u_access = acl_entry_link->entryp->ace_access;
4521+ continue;
4522+ case SMB_ACL_GROUP_OBJ:
4523+ file_acl->g_access = acl_entry_link->entryp->ace_access;
4524+ continue;
4525+ case SMB_ACL_OTHER:
4526+ file_acl->o_access = acl_entry_link->entryp->ace_access;
4527+ continue;
4528+ case SMB_ACL_MASK:
4529+ continue;
4530+ }
4531+
4532+ if((file_acl->acl_len + sizeof(struct acl_entry)) > acl_length) {
4533+ acl_length += sizeof(struct acl_entry);
4534+ file_acl_temp = (struct acl *)SMB_MALLOC(acl_length);
4535+ if(file_acl_temp == NULL) {
4536+ SAFE_FREE(file_acl);
4537+ errno = ENOMEM;
4538+ DEBUG(0,("Error in sys_acl_set_file is %d\n",errno));
4539+ return(-1);
4540+ }
4541+
4542+ memcpy(file_acl_temp,file_acl,file_acl->acl_len);
4543+ SAFE_FREE(file_acl);
4544+ file_acl = file_acl_temp;
4545+ }
4546+
4547+ acl_entry = (struct acl_entry *)((char *)file_acl + file_acl->acl_len);
4548+ file_acl->acl_len += sizeof(struct acl_entry);
4549+ acl_entry->ace_len = acl_entry_link->entryp->ace_len;
4550+ acl_entry->ace_access = acl_entry_link->entryp->ace_access;
4551+
4552+ /* In order to use this, we'll need to wait until we can get denies */
4553+ /* if(!acl_entry->ace_access && acl_entry->ace_type == ACC_PERMIT)
4554+ acl_entry->ace_type = ACC_SPECIFY; */
4555+
4556+ acl_entry->ace_type = ACC_SPECIFY;
4557+
4558+ ace_id = acl_entry->ace_id;
4559+
4560+ ace_id->id_type = acl_entry_link->entryp->ace_id->id_type;
4561+ DEBUG(10,("The id type is %d\n",ace_id->id_type));
4562+ ace_id->id_len = acl_entry_link->entryp->ace_id->id_len;
4563+ memcpy(&user_id, acl_entry_link->entryp->ace_id->id_data, sizeof(uid_t));
4564+ memcpy(acl_entry->ace_id->id_data, &user_id, sizeof(uid_t));
4565+ }
4566+
4567+ rc = chacl(name,file_acl,file_acl->acl_len);
4568+ DEBUG(10,("errno is %d\n",errno));
4569+ DEBUG(10,("return code is %d\n",rc));
4570+ SAFE_FREE(file_acl);
4571+ DEBUG(10,("Exiting the sys_acl_set_file\n"));
4572+ return(rc);
4573+}
4574+
4575+int sys_acl_set_fd( int fd, SMB_ACL_T theacl)
4576+{
4577+ struct acl_entry_link *acl_entry_link = NULL;
4578+ struct acl *file_acl = NULL;
4579+ struct acl *file_acl_temp = NULL;
4580+ struct acl_entry *acl_entry = NULL;
4581+ struct ace_id *ace_id = NULL;
4582+ uint id_type;
4583+ uint user_id;
4584+ uint acl_length;
4585+ uint rc;
4586+
4587+ DEBUG(10,("Entering sys_acl_set_fd\n"));
4588+ acl_length = BUFSIZ;
4589+ file_acl = (struct acl *)SMB_MALLOC(BUFSIZ);
4590+
4591+ if(file_acl == NULL) {
4592+ errno = ENOMEM;
4593+ DEBUG(0,("Error in sys_acl_set_fd is %d\n",errno));
4594+ return(-1);
4595+ }
4596+
4597+ memset(file_acl,0,BUFSIZ);
4598+
4599+ file_acl->acl_len = ACL_SIZ;
4600+ file_acl->acl_mode = S_IXACL;
4601+
4602+ for(acl_entry_link=theacl; acl_entry_link != NULL; acl_entry_link = acl_entry_link->nextp) {
4603+ acl_entry_link->entryp->ace_access >>= 6;
4604+ id_type = acl_entry_link->entryp->ace_id->id_type;
4605+ DEBUG(10,("The id_type is %d\n",id_type));
4606+
4607+ switch(id_type) {
4608+ case SMB_ACL_USER_OBJ:
4609+ file_acl->u_access = acl_entry_link->entryp->ace_access;
4610+ continue;
4611+ case SMB_ACL_GROUP_OBJ:
4612+ file_acl->g_access = acl_entry_link->entryp->ace_access;
4613+ continue;
4614+ case SMB_ACL_OTHER:
4615+ file_acl->o_access = acl_entry_link->entryp->ace_access;
4616+ continue;
4617+ case SMB_ACL_MASK:
4618+ continue;
4619+ }
4620+
4621+ if((file_acl->acl_len + sizeof(struct acl_entry)) > acl_length) {
4622+ acl_length += sizeof(struct acl_entry);
4623+ file_acl_temp = (struct acl *)SMB_MALLOC(acl_length);
4624+ if(file_acl_temp == NULL) {
4625+ SAFE_FREE(file_acl);
4626+ errno = ENOMEM;
4627+ DEBUG(0,("Error in sys_acl_set_fd is %d\n",errno));
4628+ return(-1);
4629+ }
4630+
4631+ memcpy(file_acl_temp,file_acl,file_acl->acl_len);
4632+ SAFE_FREE(file_acl);
4633+ file_acl = file_acl_temp;
4634+ }
4635+
4636+ acl_entry = (struct acl_entry *)((char *)file_acl + file_acl->acl_len);
4637+ file_acl->acl_len += sizeof(struct acl_entry);
4638+ acl_entry->ace_len = acl_entry_link->entryp->ace_len;
4639+ acl_entry->ace_access = acl_entry_link->entryp->ace_access;
4640+
4641+ /* In order to use this, we'll need to wait until we can get denies */
4642+ /* if(!acl_entry->ace_access && acl_entry->ace_type == ACC_PERMIT)
4643+ acl_entry->ace_type = ACC_SPECIFY; */
4644+
4645+ acl_entry->ace_type = ACC_SPECIFY;
4646+
4647+ ace_id = acl_entry->ace_id;
4648+
4649+ ace_id->id_type = acl_entry_link->entryp->ace_id->id_type;
4650+ DEBUG(10,("The id type is %d\n",ace_id->id_type));
4651+ ace_id->id_len = acl_entry_link->entryp->ace_id->id_len;
4652+ memcpy(&user_id, acl_entry_link->entryp->ace_id->id_data, sizeof(uid_t));
4653+ memcpy(ace_id->id_data, &user_id, sizeof(uid_t));
4654+ }
4655+
4656+ rc = fchacl(fd,file_acl,file_acl->acl_len);
4657+ DEBUG(10,("errno is %d\n",errno));
4658+ DEBUG(10,("return code is %d\n",rc));
4659+ SAFE_FREE(file_acl);
4660+ DEBUG(10,("Exiting sys_acl_set_fd\n"));
4661+ return(rc);
4662+}
4663+
4664+int sys_acl_delete_def_file(const char *name)
4665+{
4666+ /* AIX has no default ACL */
4667+ return 0;
4668+}
4669+
4670+int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
4671+{
4672+ return(*permset & perm);
4673+}
4674+
4675+int sys_acl_free_text(char *text)
4676+{
4677+ return(0);
4678+}
4679+
4680+int sys_acl_free_acl(SMB_ACL_T posix_acl)
4681+{
4682+ struct acl_entry_link *acl_entry_link;
4683+
4684+ for(acl_entry_link = posix_acl->nextp; acl_entry_link->nextp != NULL; acl_entry_link = acl_entry_link->nextp) {
4685+ SAFE_FREE(acl_entry_link->prevp->entryp);
4686+ SAFE_FREE(acl_entry_link->prevp);
4687+ }
4688+
4689+ SAFE_FREE(acl_entry_link->prevp->entryp);
4690+ SAFE_FREE(acl_entry_link->prevp);
4691+ SAFE_FREE(acl_entry_link->entryp);
4692+ SAFE_FREE(acl_entry_link);
4693+
4694+ return(0);
4695+}
4696+
4697+int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype)
4698+{
4699+ return(0);
4700+}
4701+
4702+#else /* No ACLs. */
4703+
4704+int sys_acl_get_entry(UNUSED(SMB_ACL_T the_acl), UNUSED(int entry_id), UNUSED(SMB_ACL_ENTRY_T *entry_p))
4705+{
4706+ errno = ENOSYS;
4707+ return -1;
4708+}
4709+
4710+int sys_acl_get_tag_type(UNUSED(SMB_ACL_ENTRY_T entry_d), UNUSED(SMB_ACL_TAG_T *tag_type_p))
4711+{
4712+ errno = ENOSYS;
4713+ return -1;
4714+}
4715+
4716+int sys_acl_get_permset(UNUSED(SMB_ACL_ENTRY_T entry_d), UNUSED(SMB_ACL_PERMSET_T *permset_p))
4717+{
4718+ errno = ENOSYS;
4719+ return -1;
4720+}
4721+
4722+void *sys_acl_get_qualifier(UNUSED(SMB_ACL_ENTRY_T entry_d))
4723+{
4724+ errno = ENOSYS;
4725+ return NULL;
4726+}
4727+
4728+SMB_ACL_T sys_acl_get_file(UNUSED(const char *path_p), UNUSED(SMB_ACL_TYPE_T type))
4729+{
4730+ errno = ENOSYS;
4731+ return (SMB_ACL_T)NULL;
4732+}
4733+
4734+SMB_ACL_T sys_acl_get_fd(UNUSED(int fd))
4735+{
4736+ errno = ENOSYS;
4737+ return (SMB_ACL_T)NULL;
4738+}
4739+
4740+int sys_acl_clear_perms(UNUSED(SMB_ACL_PERMSET_T permset))
4741+{
4742+ errno = ENOSYS;
4743+ return -1;
4744+}
4745+
4746+int sys_acl_add_perm( UNUSED(SMB_ACL_PERMSET_T permset), UNUSED(SMB_ACL_PERM_T perm))
4747+{
4748+ errno = ENOSYS;
4749+ return -1;
4750+}
4751+
4752+int sys_acl_get_perm( SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm)
4753+{
4754+ errno = ENOSYS;
4755+ return (permset & perm) ? 1 : 0;
4756+}
4757+
4758+char *sys_acl_to_text(UNUSED(SMB_ACL_T the_acl), UNUSED(ssize_t *plen))
4759+{
4760+ errno = ENOSYS;
4761+ return NULL;
4762+}
4763+
4764+int sys_acl_free_text(UNUSED(char *text))
4765+{
4766+ errno = ENOSYS;
4767+ return -1;
4768+}
4769+
4770+SMB_ACL_T sys_acl_init(UNUSED(int count))
4771+{
4772+ errno = ENOSYS;
4773+ return NULL;
4774+}
4775+
4776+int sys_acl_create_entry(UNUSED(SMB_ACL_T *pacl), UNUSED(SMB_ACL_ENTRY_T *pentry))
4777+{
4778+ errno = ENOSYS;
4779+ return -1;
4780+}
4781+
4782+int sys_acl_set_tag_type(UNUSED(SMB_ACL_ENTRY_T entry), UNUSED(SMB_ACL_TAG_T tagtype))
4783+{
4784+ errno = ENOSYS;
4785+ return -1;
4786+}
4787+
4788+int sys_acl_set_qualifier(UNUSED(SMB_ACL_ENTRY_T entry), UNUSED(void *qual))
4789+{
4790+ errno = ENOSYS;
4791+ return -1;
4792+}
4793+
4794+int sys_acl_set_permset(UNUSED(SMB_ACL_ENTRY_T entry), UNUSED(SMB_ACL_PERMSET_T permset))
4795+{
4796+ errno = ENOSYS;
4797+ return -1;
4798+}
4799+
4800+int sys_acl_valid(UNUSED(SMB_ACL_T theacl))
4801+{
4802+ errno = ENOSYS;
4803+ return -1;
4804+}
4805+
4806+int sys_acl_set_file(UNUSED(const char *name), UNUSED(SMB_ACL_TYPE_T acltype), UNUSED(SMB_ACL_T theacl))
4807+{
4808+ errno = ENOSYS;
4809+ return -1;
4810+}
4811+
4812+int sys_acl_set_fd(UNUSED(int fd), UNUSED(SMB_ACL_T theacl))
4813+{
4814+ errno = ENOSYS;
4815+ return -1;
4816+}
4817+
4818+int sys_acl_delete_def_file(UNUSED(const char *name))
4819+{
4820+ errno = ENOSYS;
4821+ return -1;
4822+}
4823+
4824+int sys_acl_free_acl(UNUSED(SMB_ACL_T the_acl))
4825+{
4826+ errno = ENOSYS;
4827+ return -1;
4828+}
4829+
4830+int sys_acl_free_qualifier(UNUSED(void *qual), UNUSED(SMB_ACL_TAG_T tagtype))
4831+{
4832+ errno = ENOSYS;
4833+ return -1;
4834+}
4835+
4836+#endif /* No ACLs. */
4837+
4838+/************************************************************************
4839+ Deliberately outside the ACL defines. Return 1 if this is a "no acls"
4840+ errno, 0 if not.
4841+************************************************************************/
4842+
4843+int no_acl_syscall_error(int err)
4844+{
4845+#if defined(ENOSYS)
4846+ if (err == ENOSYS) {
4847+ return 1;
4848+ }
4849+#endif
4850+#if defined(ENOTSUP)
4851+ if (err == ENOTSUP) {
4852+ return 1;
4853+ }
4854+#endif
4855+ return 0;
4856+}
4857--- old/lib/sysacls.h
4858+++ new/lib/sysacls.h
4859@@ -0,0 +1,28 @@
4860+#define SMB_MALLOC(cnt) new_array(char, cnt)
4861+#define SMB_MALLOC_P(obj) new_array(obj, 1)
4862+#define SMB_MALLOC_ARRAY(obj, cnt) new_array(obj, cnt)
4863+#define SMB_REALLOC(mem, cnt) realloc_array(mem, char, cnt)
4864+#define slprintf snprintf
4865+
4866+int sys_acl_get_entry(SMB_ACL_T the_acl, int entry_id, SMB_ACL_ENTRY_T *entry_p);
4867+int sys_acl_get_tag_type(SMB_ACL_ENTRY_T entry_d, SMB_ACL_TAG_T *tag_type_p);
4868+int sys_acl_get_permset(SMB_ACL_ENTRY_T entry_d, SMB_ACL_PERMSET_T *permset_p);
4869+void *sys_acl_get_qualifier(SMB_ACL_ENTRY_T entry_d);
4870+SMB_ACL_T sys_acl_get_file(const char *path_p, SMB_ACL_TYPE_T type);
4871+SMB_ACL_T sys_acl_get_fd(int fd);
4872+int sys_acl_clear_perms(SMB_ACL_PERMSET_T permset);
4873+int sys_acl_add_perm(SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm);
4874+int sys_acl_get_perm(SMB_ACL_PERMSET_T permset, SMB_ACL_PERM_T perm);
4875+char *sys_acl_to_text(SMB_ACL_T the_acl, ssize_t *plen);
4876+SMB_ACL_T sys_acl_init(int count);
4877+int sys_acl_create_entry(SMB_ACL_T *pacl, SMB_ACL_ENTRY_T *pentry);
4878+int sys_acl_set_tag_type(SMB_ACL_ENTRY_T entry, SMB_ACL_TAG_T tagtype);
4879+int sys_acl_set_qualifier(SMB_ACL_ENTRY_T entry, void *qual);
4880+int sys_acl_set_permset(SMB_ACL_ENTRY_T entry, SMB_ACL_PERMSET_T permset);
4881+int sys_acl_valid(SMB_ACL_T theacl);
4882+int sys_acl_set_file(const char *name, SMB_ACL_TYPE_T acltype, SMB_ACL_T theacl);
4883+int sys_acl_set_fd(int fd, SMB_ACL_T theacl);
4884+int sys_acl_delete_def_file(const char *name);
4885+int sys_acl_free_text(char *text);
4886+int sys_acl_free_acl(SMB_ACL_T the_acl);
4887+int sys_acl_free_qualifier(void *qual, SMB_ACL_TAG_T tagtype);
4888--- old/mkproto.awk
4889+++ new/mkproto.awk
4890@@ -58,7 +58,7 @@ BEGIN {
4891 next;
4892 }
4893
4894-!/^OFF_T|^size_t|^off_t|^pid_t|^unsigned|^mode_t|^DIR|^user|^int|^char|^uint|^uchar|^short|^struct|^BOOL|^void|^time|^const|^RETSIGTYPE/ {
4895+!/^OFF_T|^size_t|^off_t|^pid_t|^id_t|^unsigned|^mode_t|^DIR|^user|^int|^char|^uint|^uchar|^short|^struct|^BOOL|^void|^time|^const|^RETSIGTYPE/ {
4896 next;
4897 }
4898
4899--- old/options.c
4900+++ new/options.c
4901@@ -47,6 +47,7 @@ int copy_dirlinks = 0;
4902 int copy_links = 0;
4903 int preserve_links = 0;
4904 int preserve_hard_links = 0;
4905+int preserve_acls = 0;
4906 int preserve_perms = 0;
4907 int preserve_executability = 0;
4908 int preserve_devices = 0;
4909@@ -194,6 +195,7 @@ static void print_rsync_version(enum log
4910 char const *got_socketpair = "no ";
4911 char const *have_inplace = "no ";
4912 char const *hardlinks = "no ";
4913+ char const *acls = "no ";
4914 char const *links = "no ";
4915 char const *ipv6 = "no ";
4916 STRUCT_STAT *dumstat;
4917@@ -210,6 +212,10 @@ static void print_rsync_version(enum log
4918 hardlinks = "";
4919 #endif
4920
4921+#ifdef SUPPORT_ACLS
4922+ acls = "";
4923+#endif
4924+
4925 #ifdef SUPPORT_LINKS
4926 links = "";
4927 #endif
4928@@ -223,9 +229,9 @@ static void print_rsync_version(enum log
4929 rprintf(f, "Copyright (C) 1996-2006 by Andrew Tridgell, Wayne Davison, and others.\n");
4930 rprintf(f, "<http://rsync.samba.org/>\n");
4931 rprintf(f, "Capabilities: %d-bit files, %ssocketpairs, "
4932- "%shard links, %ssymlinks, batchfiles,\n",
4933+ "%shard links, %sACLs, %ssymlinks, batchfiles,\n",
4934 (int) (sizeof (OFF_T) * 8),
4935- got_socketpair, hardlinks, links);
4936+ got_socketpair, hardlinks, acls, links);
4937
4938 /* Note that this field may not have type ino_t. It depends
4939 * on the complicated interaction between largefile feature
4940@@ -295,6 +301,9 @@ void usage(enum logcode F)
4941 rprintf(F," -H, --hard-links preserve hard links\n");
4942 rprintf(F," -p, --perms preserve permissions\n");
4943 rprintf(F," -E, --executability preserve the file's executability\n");
4944+#ifdef SUPPORT_ACLS
4945+ rprintf(F," -A, --acls preserve ACLs (implies --perms)\n");
4946+#endif
4947 rprintf(F," --chmod=CHMOD change destination permissions\n");
4948 rprintf(F," -o, --owner preserve owner (super-user only)\n");
4949 rprintf(F," -g, --group preserve group\n");
4950@@ -410,6 +419,9 @@ static struct poptOption long_options[]
4951 {"no-perms", 0, POPT_ARG_VAL, &preserve_perms, 0, 0, 0 },
4952 {"no-p", 0, POPT_ARG_VAL, &preserve_perms, 0, 0, 0 },
4953 {"executability", 'E', POPT_ARG_NONE, &preserve_executability, 0, 0, 0 },
4954+ {"acls", 'A', POPT_ARG_NONE, 0, 'A', 0, 0 },
4955+ {"no-acls", 0, POPT_ARG_VAL, &preserve_acls, 0, 0, 0 },
4956+ {"no-A", 0, POPT_ARG_VAL, &preserve_acls, 0, 0, 0 },
4957 {"times", 't', POPT_ARG_VAL, &preserve_times, 1, 0, 0 },
4958 {"no-times", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
4959 {"no-t", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
4960@@ -1068,6 +1080,24 @@ int parse_arguments(int *argc, const cha
4961 usage(FINFO);
4962 exit_cleanup(0);
4963
4964+ case 'A':
4965+#ifdef SUPPORT_ACLS
4966+ preserve_acls++;
4967+ preserve_perms = 1;
4968+ break;
4969+#else
4970+ /* FIXME: this should probably be ignored with a
4971+ * warning and then countermeasures taken to
4972+ * restrict group and other access in the presence
4973+ * of any more restrictive ACLs, but this is safe
4974+ * for now */
4975+ snprintf(err_buf,sizeof(err_buf),
4976+ "ACLs are not supported on this %s\n",
4977+ am_server ? "server" : "client");
4978+ return 0;
4979+#endif
4980+
4981+
4982 default:
4983 /* A large opt value means that set_refuse_options()
4984 * turned this option off. */
4985@@ -1510,6 +1540,10 @@ void server_options(char **args,int *arg
4986
4987 if (preserve_hard_links)
4988 argstr[x++] = 'H';
4989+#ifdef SUPPORT_ACLS
4990+ if (preserve_acls)
4991+ argstr[x++] = 'A';
4992+#endif
4993 if (preserve_uid)
4994 argstr[x++] = 'o';
4995 if (preserve_gid)
4996--- old/receiver.c
4997+++ new/receiver.c
4998@@ -48,6 +48,7 @@ extern int keep_partial;
4999 extern int checksum_seed;
5000 extern int inplace;
5001 extern int delay_updates;
5002+extern mode_t orig_umask;
5003 extern struct stats stats;
5004 extern char *log_format;
5005 extern char *tmpdir;
5006@@ -346,6 +347,10 @@ int recv_files(int f_in, struct file_lis
5007 int itemizing = am_daemon ? daemon_log_format_has_i
5008 : !am_server && log_format_has_i;
5009 int max_phase = protocol_version >= 29 ? 2 : 1;
5010+ int dflt_perms = (ACCESSPERMS & ~orig_umask);
5011+#ifdef SUPPORT_ACLS
5012+ char *parent_dirname = "";
5013+#endif
5014 int i, recv_ok;
5015
5016 if (verbose > 2)
5017@@ -543,7 +548,16 @@ int recv_files(int f_in, struct file_lis
5018 * mode based on the local permissions and some heuristics. */
5019 if (!preserve_perms) {
5020 int exists = fd1 != -1;
5021- file->mode = dest_mode(file->mode, st.st_mode, exists);
5022+#ifdef SUPPORT_ACLS
5023+ char *dn = file->dirname ? file->dirname : ".";
5024+ if (parent_dirname != dn
5025+ && strcmp(parent_dirname, dn) != 0) {
5026+ dflt_perms = default_perms_for_dir(dn);
5027+ parent_dirname = dn;
5028+ }
5029+#endif
5030+ file->mode = dest_mode(file->mode, st.st_mode,
5031+ dflt_perms, exists);
5032 }
5033
5034 /* We now check to see if we are writing file "inplace" */
5035--- old/rsync.c
5036+++ new/rsync.c
5037@@ -33,6 +33,7 @@
5038 extern int verbose;
5039 extern int dry_run;
5040 extern int daemon_log_format_has_i;
5041+extern int preserve_acls;
5042 extern int preserve_perms;
5043 extern int preserve_executability;
5044 extern int preserve_times;
5045@@ -101,7 +102,8 @@ void free_sums(struct sum_struct *s)
5046
5047 /* This is only called when we aren't preserving permissions. Figure out what
5048 * the permissions should be and return them merged back into the mode. */
5049-mode_t dest_mode(mode_t flist_mode, mode_t cur_mode, int exists)
5050+mode_t dest_mode(mode_t flist_mode, mode_t cur_mode, int dflt_perms,
5051+ int exists)
5052 {
5053 /* If the file already exists, we'll return the local permissions,
5054 * possibly tweaked by the --executability option. */
5055@@ -116,7 +118,7 @@ mode_t dest_mode(mode_t flist_mode, mode
5056 cur_mode |= (cur_mode & 0444) >> 2;
5057 }
5058 } else
5059- cur_mode = flist_mode & ACCESSPERMS & ~orig_umask;
5060+ cur_mode = flist_mode & ACCESSPERMS & dflt_perms;
5061 if (daemon_chmod_modes && !S_ISLNK(flist_mode))
5062 cur_mode = tweak_mode(cur_mode, daemon_chmod_modes);
5063 return (flist_mode & ~CHMOD_BITS) | (cur_mode & CHMOD_BITS);
5064@@ -203,6 +205,17 @@ int set_file_attrs(char *fname, struct f
5065 updated = 1;
5066 }
5067
5068+#ifdef SUPPORT_ACLS
5069+ /* It's OK to call set_acl() now, even for a dir, as the generator
5070+ * will enable owner-writability using chmod, if necessary.
5071+ *
5072+ * If set_acl changes permission bits in the process of setting
5073+ * an access ACL, it changes st->st_mode so we know whether we
5074+ * need to chmod. */
5075+ if (preserve_acls && set_acl(fname, file, &st->st_mode) == 0)
5076+ updated = 1;
5077+#endif
5078+
5079 #ifdef HAVE_CHMOD
5080 if ((st->st_mode & CHMOD_BITS) != (file->mode & CHMOD_BITS)) {
5081 int ret = do_chmod(fname, file->mode);
5082--- old/rsync.h
5083+++ new/rsync.h
5084@@ -660,6 +660,20 @@ struct chmod_mode_struct;
5085
5086 #define UNUSED(x) x __attribute__((__unused__))
5087
5088+#if HAVE_POSIX_ACLS|HAVE_UNIXWARE_ACLS|HAVE_SOLARIS_ACLS|\
5089+ HAVE_HPUX_ACLS|HAVE_IRIX_ACLS|HAVE_AIX_ACLS|HAVE_TRU64_ACLS
5090+#define SUPPORT_ACLS 1
5091+#endif
5092+
5093+#if HAVE_UNIXWARE_ACLS|HAVE_SOLARIS_ACLS|HAVE_HPUX_ACLS
5094+#define ACLS_NEED_MASK 1
5095+#endif
5096+
5097+#if defined SUPPORT_ACLS && defined HAVE_SYS_ACL_H
5098+#include <sys/acl.h>
5099+#endif
5100+#include "smb_acls.h"
5101+
5102 #include "proto.h"
5103
5104 /* We have replacement versions of these if they're missing. */
5105--- old/rsync.yo
5106+++ new/rsync.yo
5107@@ -321,6 +321,7 @@ to the detailed description below for a
5108 -H, --hard-links preserve hard links
5109 -p, --perms preserve permissions
5110 -E, --executability preserve executability
5111+ -A, --acls preserve ACLs (implies -p) [non-standard]
5112 --chmod=CHMOD change destination permissions
5113 -o, --owner preserve owner (super-user only)
5114 -g, --group preserve group
5115@@ -742,7 +743,9 @@ quote(itemize(
5116 permissions, though the bf(--executability) option might change just
5117 the execute permission for the file.
5118 it() New files get their "normal" permission bits set to the source
5119- file's permissions masked with the receiving end's umask setting, and
5120+ file's permissions masked with the receiving directory's default
5121+ permissions (either the receiving process's umask, or the permissions
5122+ specified via the destination directory's default ACL), and
5123 their special permission bits disabled except in the case where a new
5124 directory inherits a setgid bit from its parent directory.
5125 ))
5126@@ -773,9 +776,11 @@ The preservation of the destination's se
5127 directories when bf(--perms) is off was added in rsync 2.6.7. Older rsync
5128 versions erroneously preserved the three special permission bits for
5129 newly-created files when bf(--perms) was off, while overriding the
5130-destination's setgid bit setting on a newly-created directory. (Keep in
5131-mind that it is the version of the receiving rsync that affects this
5132-behavior.)
5133+destination's setgid bit setting on a newly-created directory. Default ACL
5134+observance was added to the ACL patch for rsync 2.6.7, so older (or
5135+non-ACL-enabled) rsyncs use the umask even if default ACLs are present.
5136+(Keep in mind that it is the version of the receiving rsync that affects
5137+these behaviors.)
5138
5139 dit(bf(-E, --executability)) This option causes rsync to preserve the
5140 executability (or non-executability) of regular files when bf(--perms) is
5141@@ -793,6 +798,15 @@ quote(itemize(
5142
5143 If bf(--perms) is enabled, this option is ignored.
5144
5145+dit(bf(-A, --acls)) This option causes rsync to update the destination
5146+ACLs to be the same as the source ACLs. This nonstandard option only
5147+works if the remote rsync also supports it. bf(--acls) implies bf(--perms).
5148+
5149+Note also that an optimization of the ACL-sending protocol used by this
5150+version makes it incompatible with sending files to an older ACL-enabled
5151+rsync unless you double the bf(--acls) option (e.g. bf(-AA)). This
5152+doubling is not needed when pulling files from an older rsync.
5153+
5154 dit(bf(--chmod)) This option tells rsync to apply one or more
5155 comma-separated "chmod" strings to the permission of the files in the
5156 transfer. The resulting value is treated as though it was the permissions
5157--- old/smb_acls.h
5158+++ new/smb_acls.h
5159@@ -0,0 +1,281 @@
5160+/*
5161+ Unix SMB/Netbios implementation.
5162+ Version 2.2.x
5163+ Portable SMB ACL interface
5164+ Copyright (C) Jeremy Allison 2000
5165+
5166+ This program is free software; you can redistribute it and/or modify
5167+ it under the terms of the GNU General Public License as published by
5168+ the Free Software Foundation; either version 2 of the License, or
5169+ (at your option) any later version.
5170+
5171+ This program is distributed in the hope that it will be useful,
5172+ but WITHOUT ANY WARRANTY; without even the implied warranty of
5173+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5174+ GNU General Public License for more details.
5175+
5176+ You should have received a copy of the GNU General Public License
5177+ along with this program; if not, write to the Free Software
5178+ Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
5179+*/
5180+
5181+#ifndef _SMB_ACLS_H
5182+#define _SMB_ACLS_H
5183+
5184+#if defined HAVE_POSIX_ACLS
5185+
5186+/* This is an identity mapping (just remove the SMB_). */
5187+
5188+#define SMB_ACL_TAG_T acl_tag_t
5189+#define SMB_ACL_TYPE_T acl_type_t
5190+#define SMB_ACL_PERMSET_T acl_permset_t
5191+#define SMB_ACL_PERM_T acl_perm_t
5192+#define SMB_ACL_READ ACL_READ
5193+#define SMB_ACL_WRITE ACL_WRITE
5194+#define SMB_ACL_EXECUTE ACL_EXECUTE
5195+
5196+/* Types of ACLs. */
5197+#define SMB_ACL_USER ACL_USER
5198+#define SMB_ACL_USER_OBJ ACL_USER_OBJ
5199+#define SMB_ACL_GROUP ACL_GROUP
5200+#define SMB_ACL_GROUP_OBJ ACL_GROUP_OBJ
5201+#define SMB_ACL_OTHER ACL_OTHER
5202+#define SMB_ACL_MASK ACL_MASK
5203+
5204+#define SMB_ACL_T acl_t
5205+
5206+#define SMB_ACL_ENTRY_T acl_entry_t
5207+
5208+#define SMB_ACL_FIRST_ENTRY ACL_FIRST_ENTRY
5209+#define SMB_ACL_NEXT_ENTRY ACL_NEXT_ENTRY
5210+
5211+#define SMB_ACL_TYPE_ACCESS ACL_TYPE_ACCESS
5212+#define SMB_ACL_TYPE_DEFAULT ACL_TYPE_DEFAULT
5213+
5214+#elif defined HAVE_TRU64_ACLS
5215+
5216+/* This is for DEC/Compaq Tru64 UNIX */
5217+
5218+#define SMB_ACL_TAG_T acl_tag_t
5219+#define SMB_ACL_TYPE_T acl_type_t
5220+#define SMB_ACL_PERMSET_T acl_permset_t
5221+#define SMB_ACL_PERM_T acl_perm_t
5222+#define SMB_ACL_READ ACL_READ
5223+#define SMB_ACL_WRITE ACL_WRITE
5224+#define SMB_ACL_EXECUTE ACL_EXECUTE
5225+
5226+/* Types of ACLs. */
5227+#define SMB_ACL_USER ACL_USER
5228+#define SMB_ACL_USER_OBJ ACL_USER_OBJ
5229+#define SMB_ACL_GROUP ACL_GROUP
5230+#define SMB_ACL_GROUP_OBJ ACL_GROUP_OBJ
5231+#define SMB_ACL_OTHER ACL_OTHER
5232+#define SMB_ACL_MASK ACL_MASK
5233+
5234+#define SMB_ACL_T acl_t
5235+
5236+#define SMB_ACL_ENTRY_T acl_entry_t
5237+
5238+#define SMB_ACL_FIRST_ENTRY 0
5239+#define SMB_ACL_NEXT_ENTRY 1
5240+
5241+#define SMB_ACL_TYPE_ACCESS ACL_TYPE_ACCESS
5242+#define SMB_ACL_TYPE_DEFAULT ACL_TYPE_DEFAULT
5243+
5244+#elif defined HAVE_UNIXWARE_ACLS || defined HAVE_SOLARIS_ACLS
5245+/*
5246+ * Donated by Michael Davidson <md@sco.COM> for UnixWare / OpenUNIX.
5247+ * Modified by Toomas Soome <tsoome@ut.ee> for Solaris.
5248+ */
5249+
5250+/* SVR4.2 ES/MP ACLs */
5251+typedef int SMB_ACL_TAG_T;
5252+typedef int SMB_ACL_TYPE_T;
5253+typedef ushort *SMB_ACL_PERMSET_T;
5254+typedef ushort SMB_ACL_PERM_T;
5255+#define SMB_ACL_READ 4
5256+#define SMB_ACL_WRITE 2
5257+#define SMB_ACL_EXECUTE 1
5258+
5259+/* Types of ACLs. */
5260+#define SMB_ACL_USER USER
5261+#define SMB_ACL_USER_OBJ USER_OBJ
5262+#define SMB_ACL_GROUP GROUP
5263+#define SMB_ACL_GROUP_OBJ GROUP_OBJ
5264+#define SMB_ACL_OTHER OTHER_OBJ
5265+#define SMB_ACL_MASK CLASS_OBJ
5266+
5267+typedef struct SMB_ACL_T {
5268+ int size;
5269+ int count;
5270+ int next;
5271+ struct acl acl[1];
5272+} *SMB_ACL_T;
5273+
5274+typedef struct acl *SMB_ACL_ENTRY_T;
5275+
5276+#define SMB_ACL_FIRST_ENTRY 0
5277+#define SMB_ACL_NEXT_ENTRY 1
5278+
5279+#define SMB_ACL_TYPE_ACCESS 0
5280+#define SMB_ACL_TYPE_DEFAULT 1
5281+
5282+#ifdef __CYGWIN__
5283+#define SMB_ACL_LOSES_SPECIAL_MODE_BITS
5284+#endif
5285+
5286+#elif defined HAVE_HPUX_ACLS
5287+
5288+/*
5289+ * Based on the Solaris & UnixWare code.
5290+ */
5291+
5292+#undef GROUP
5293+#include <sys/aclv.h>
5294+
5295+/* SVR4.2 ES/MP ACLs */
5296+typedef int SMB_ACL_TAG_T;
5297+typedef int SMB_ACL_TYPE_T;
5298+typedef ushort *SMB_ACL_PERMSET_T;
5299+typedef ushort SMB_ACL_PERM_T;
5300+#define SMB_ACL_READ 4
5301+#define SMB_ACL_WRITE 2
5302+#define SMB_ACL_EXECUTE 1
5303+
5304+/* Types of ACLs. */
5305+#define SMB_ACL_USER USER
5306+#define SMB_ACL_USER_OBJ USER_OBJ
5307+#define SMB_ACL_GROUP GROUP
5308+#define SMB_ACL_GROUP_OBJ GROUP_OBJ
5309+#define SMB_ACL_OTHER OTHER_OBJ
5310+#define SMB_ACL_MASK CLASS_OBJ
5311+
5312+typedef struct SMB_ACL_T {
5313+ int size;
5314+ int count;
5315+ int next;
5316+ struct acl acl[1];
5317+} *SMB_ACL_T;
5318+
5319+typedef struct acl *SMB_ACL_ENTRY_T;
5320+
5321+#define SMB_ACL_FIRST_ENTRY 0
5322+#define SMB_ACL_NEXT_ENTRY 1
5323+
5324+#define SMB_ACL_TYPE_ACCESS 0
5325+#define SMB_ACL_TYPE_DEFAULT 1
5326+
5327+#elif defined HAVE_IRIX_ACLS
5328+
5329+#define SMB_ACL_TAG_T acl_tag_t
5330+#define SMB_ACL_TYPE_T acl_type_t
5331+#define SMB_ACL_PERMSET_T acl_permset_t
5332+#define SMB_ACL_PERM_T acl_perm_t
5333+#define SMB_ACL_READ ACL_READ
5334+#define SMB_ACL_WRITE ACL_WRITE
5335+#define SMB_ACL_EXECUTE ACL_EXECUTE
5336+
5337+/* Types of ACLs. */
5338+#define SMB_ACL_USER ACL_USER
5339+#define SMB_ACL_USER_OBJ ACL_USER_OBJ
5340+#define SMB_ACL_GROUP ACL_GROUP
5341+#define SMB_ACL_GROUP_OBJ ACL_GROUP_OBJ
5342+#define SMB_ACL_OTHER ACL_OTHER_OBJ
5343+#define SMB_ACL_MASK ACL_MASK
5344+
5345+typedef struct SMB_ACL_T {
5346+ int next;
5347+ BOOL freeaclp;
5348+ struct acl *aclp;
5349+} *SMB_ACL_T;
5350+
5351+#define SMB_ACL_ENTRY_T acl_entry_t
5352+
5353+#define SMB_ACL_FIRST_ENTRY 0
5354+#define SMB_ACL_NEXT_ENTRY 1
5355+
5356+#define SMB_ACL_TYPE_ACCESS ACL_TYPE_ACCESS
5357+#define SMB_ACL_TYPE_DEFAULT ACL_TYPE_DEFAULT
5358+
5359+#elif defined HAVE_AIX_ACLS
5360+
5361+/* Donated by Medha Date, mdate@austin.ibm.com, for IBM */
5362+
5363+#include "/usr/include/acl.h"
5364+
5365+typedef uint *SMB_ACL_PERMSET_T;
5366+
5367+struct acl_entry_link{
5368+ struct acl_entry_link *prevp;
5369+ struct new_acl_entry *entryp;
5370+ struct acl_entry_link *nextp;
5371+ int count;
5372+};
5373+
5374+struct new_acl_entry{
5375+ unsigned short ace_len;
5376+ unsigned short ace_type;
5377+ unsigned int ace_access;
5378+ struct ace_id ace_id[1];
5379+};
5380+
5381+#define SMB_ACL_ENTRY_T struct new_acl_entry*
5382+#define SMB_ACL_T struct acl_entry_link*
5383+
5384+#define SMB_ACL_TAG_T unsigned short
5385+#define SMB_ACL_TYPE_T int
5386+#define SMB_ACL_PERM_T uint
5387+#define SMB_ACL_READ S_IRUSR
5388+#define SMB_ACL_WRITE S_IWUSR
5389+#define SMB_ACL_EXECUTE S_IXUSR
5390+
5391+/* Types of ACLs. */
5392+#define SMB_ACL_USER ACEID_USER
5393+#define SMB_ACL_USER_OBJ 3
5394+#define SMB_ACL_GROUP ACEID_GROUP
5395+#define SMB_ACL_GROUP_OBJ 4
5396+#define SMB_ACL_OTHER 5
5397+#define SMB_ACL_MASK 6
5398+
5399+
5400+#define SMB_ACL_FIRST_ENTRY 1
5401+#define SMB_ACL_NEXT_ENTRY 2
5402+
5403+#define SMB_ACL_TYPE_ACCESS 0
5404+#define SMB_ACL_TYPE_DEFAULT 1
5405+
5406+#else /* No ACLs. */
5407+
5408+/* No ACLS - fake it. */
5409+#define SMB_ACL_TAG_T int
5410+#define SMB_ACL_TYPE_T int
5411+#define SMB_ACL_PERMSET_T mode_t
5412+#define SMB_ACL_PERM_T mode_t
5413+#define SMB_ACL_READ S_IRUSR
5414+#define SMB_ACL_WRITE S_IWUSR
5415+#define SMB_ACL_EXECUTE S_IXUSR
5416+
5417+/* Types of ACLs. */
5418+#define SMB_ACL_USER 0
5419+#define SMB_ACL_USER_OBJ 1
5420+#define SMB_ACL_GROUP 2
5421+#define SMB_ACL_GROUP_OBJ 3
5422+#define SMB_ACL_OTHER 4
5423+#define SMB_ACL_MASK 5
5424+
5425+typedef struct SMB_ACL_T {
5426+ int dummy;
5427+} *SMB_ACL_T;
5428+
5429+typedef struct SMB_ACL_ENTRY_T {
5430+ int dummy;
5431+} *SMB_ACL_ENTRY_T;
5432+
5433+#define SMB_ACL_FIRST_ENTRY 0
5434+#define SMB_ACL_NEXT_ENTRY 1
5435+
5436+#define SMB_ACL_TYPE_ACCESS 0
5437+#define SMB_ACL_TYPE_DEFAULT 1
5438+
5439+#endif /* No ACLs. */
5440+#endif /* _SMB_ACLS_H */
5441--- old/testsuite/acls.test
5442+++ new/testsuite/acls.test
5443@@ -0,0 +1,34 @@
5444+#! /bin/sh
5445+
5446+# This program is distributable under the terms of the GNU GPL (see
5447+# COPYING).
5448+
5449+# Test that rsync handles basic ACL preservation.
5450+
5451+. $srcdir/testsuite/rsync.fns
5452+
5453+$RSYNC --version | grep ", ACLs" >/dev/null || test_skipped "Rsync is configured without ACL support"
5454+case "$setfacl_nodef" in
5455+true) test_skipped "I don't know how to use your setfacl command" ;;
5456+esac
5457+
5458+makepath "$fromdir/foo"
5459+echo something >"$fromdir/file1"
5460+echo else >"$fromdir/file2"
5461+
5462+files='foo file1 file2'
5463+
5464+setfacl -m u:0:7 "$fromdir/foo" || test_skipped "Your filesystem has ACLs disabled"
5465+setfacl -m u:0:5 "$fromdir/file1"
5466+setfacl -m u:0:5 "$fromdir/file2"
5467+
5468+$RSYNC -avvA "$fromdir/" "$todir/"
5469+
5470+cd "$fromdir"
5471+getfacl $files >"$scratchdir/acls.txt"
5472+
5473+cd "$todir"
5474+getfacl $files | diff $diffopt "$scratchdir/acls.txt" -
5475+
5476+# The script would have aborted on error, so getting here means we've won.
5477+exit 0
5478--- old/testsuite/default-acls.test
5479+++ new/testsuite/default-acls.test
5480@@ -0,0 +1,65 @@
5481+#! /bin/sh
5482+
5483+# This program is distributable under the terms of the GNU GPL (see
5484+# COPYING).
5485+
5486+# Test that rsync obeys default ACLs. -- Matt McCutchen
5487+
5488+. $srcdir/testsuite/rsync.fns
5489+
5490+$RSYNC --version | grep ", ACLs" >/dev/null || test_skipped "Rsync is configured without ACL support"
5491+case "$setfacl_nodef" in
5492+true) test_skipped "I don't know how to use your setfacl command" ;;
5493+*-k*) opts='-dm u::7,g::5,o:5' ;;
5494+*) opts='-m d:u::7,d:g::5,d:o:5' ;;
5495+esac
5496+setfacl $opts "$scratchdir" || test_skipped "Your filesystem has ACLs disabled"
5497+
5498+# Call as: testit <dirname> <default-acl> <file-expected> <program-expected>
5499+testit() {
5500+ todir="$scratchdir/$1"
5501+ mkdir "$todir"
5502+ $setfacl_nodef "$todir"
5503+ if [ "$2" ]; then
5504+ case "$setfacl_nodef" in
5505+ *-k*) opts="-dm $2" ;;
5506+ *) opts="-m `echo $2 | sed 's/\([ugom]:\)/d:\1/g'`"
5507+ esac
5508+ setfacl $opts "$todir"
5509+ fi
5510+ # Make sure we obey ACLs when creating a directory to hold multiple transferred files,
5511+ # even though the directory itself is outside the transfer
5512+ $RSYNC -rvv "$scratchdir/dir" "$scratchdir/file" "$scratchdir/program" "$todir/to/"
5513+ check_perms "$todir/to" $4 "Target $1"
5514+ check_perms "$todir/to/dir" $4 "Target $1"
5515+ check_perms "$todir/to/file" $3 "Target $1"
5516+ check_perms "$todir/to/program" $4 "Target $1"
5517+ # Make sure get_local_name doesn't mess us up when transferring only one file
5518+ $RSYNC -rvv "$scratchdir/file" "$todir/to/anotherfile"
5519+ check_perms "$todir/to/anotherfile" $3 "Target $1"
5520+ # Make sure we obey default ACLs when not transferring a regular file
5521+ $RSYNC -rvv "$scratchdir/dir/" "$todir/to/anotherdir/"
5522+ check_perms "$todir/to/anotherdir" $4 "Target $1"
5523+}
5524+
5525+mkdir "$scratchdir/dir"
5526+echo "File!" >"$scratchdir/file"
5527+echo "#!/bin/sh" >"$scratchdir/program"
5528+chmod 777 "$scratchdir/dir"
5529+chmod 666 "$scratchdir/file"
5530+chmod 777 "$scratchdir/program"
5531+
5532+# Test some target directories
5533+umask 0077
5534+testit da777 u::7,g::7,o:7 rw-rw-rw- rwxrwxrwx
5535+testit da775 u::7,g::7,o:5 rw-rw-r-- rwxrwxr-x
5536+testit da750 u::7,g::5,o:0 rw-r----- rwxr-x---
5537+testit da770mask u::7,u:0:7,g::0,m:7,o:0 rw-rw---- rwxrwx---
5538+testit noda1 '' rw------- rwx------
5539+umask 0000
5540+testit noda2 '' rw-rw-rw- rwxrwxrwx
5541+umask 0022
5542+testit noda3 '' rw-r--r-- rwxr-xr-x
5543+
5544+# Hooray
5545+exit 0
5546--- old/uidlist.c
5547+++ new/uidlist.c
5548@@ -35,6 +35,7 @@
5549 extern int verbose;
5550 extern int preserve_uid;
5551 extern int preserve_gid;
5552+extern int preserve_acls;
5553 extern int numeric_ids;
5554 extern int am_root;
5555
5556@@ -275,7 +276,7 @@ void send_uid_list(int f)
5557 if (numeric_ids)
5558 return;
5559
5560- if (preserve_uid) {
5561+ if (preserve_uid || preserve_acls) {
5562 int len;
5563 /* we send sequences of uid/byte-length/name */
5564 for (list = uidlist; list; list = list->next) {
5565@@ -292,7 +293,7 @@ void send_uid_list(int f)
5566 write_int(f, 0);
5567 }
5568
5569- if (preserve_gid) {
5570+ if (preserve_gid || preserve_acls) {
5571 int len;
5572 for (list = gidlist; list; list = list->next) {
5573 if (!list->name)
5574@@ -313,7 +314,7 @@ void recv_uid_list(int f, struct file_li
5575 int id, i;
5576 char *name;
5577
5578- if (preserve_uid && !numeric_ids) {
5579+ if ((preserve_uid || preserve_acls) && !numeric_ids) {
5580 /* read the uid list */
5581 while ((id = read_int(f)) != 0) {
5582 int len = read_byte(f);
5583@@ -325,7 +326,7 @@ void recv_uid_list(int f, struct file_li
5584 }
5585 }
5586
5587- if (preserve_gid && !numeric_ids) {
5588+ if ((preserve_gid || preserve_acls) && !numeric_ids) {
5589 /* read the gid list */
5590 while ((id = read_int(f)) != 0) {
5591 int len = read_byte(f);
5592@@ -337,6 +338,16 @@ void recv_uid_list(int f, struct file_li
5593 }
5594 }
5595
5596+#ifdef SUPPORT_ACLS
5597+ if (preserve_acls && !numeric_ids) {
5598+ id_t *id;
5599+ while ((id = next_acl_uid(flist)) != NULL)
5600+ *id = match_uid(*id);
5601+ while ((id = next_acl_gid(flist)) != NULL)
5602+ *id = match_gid(*id);
5603+ }
5604+#endif
5605+
5606 /* Now convert all the uids/gids from sender values to our values. */
5607 if (am_root && preserve_uid && !numeric_ids) {
5608 for (i = 0; i < flist->count; i++)