Fixed the value of CENT_POS for non-Linux systems.
[rsync/rsync-patches.git] / xattrs.diff
CommitLineData
03019e41
WD
1This patch adds basic support for extended attributes. It works, but there
2are some things that still needs to be improved (see TODO list below).
bbdff76a 3
03019e41 4To use this patch, run these commands for a successful build:
bbdff76a 5
03019e41
WD
6 patch -p1 <patches/acls.diff
7 patch -p1 <patches/xattrs.diff
27e96866 8 ./prepare-source
f787c90c 9 ./configure --enable-acl-support --enable-xattr-support
bbdff76a
WD
10 make
11
03019e41
WD
12Alternately, if you don't want ACL support, configure it this way:
13
14 ./configure --enable-xattr-support
15
0f6fb3c8
WD
16TODO:
17
d2dc8a18
WD
18 - This patch needs to more efficiently handle large xattrs, especially when
19 they're unchanged.
0f6fb3c8 20
a74926e4
WD
21 - Extraneous xattr values need to be removed from files that are not being
22 recreated.
23
0f6fb3c8
WD
24 - We need to affect the itemized output to know when xattrs are being updated.
25
26 - We need to affect the --link-dest option to avoid hard-linking two files
27 that differ in their xattrs (when --xattrs was specified).
28
9a7eef96
WD
29--- old/Makefile.in
30+++ new/Makefile.in
1ed0b5c9 31@@ -28,13 +28,13 @@ VERSION=@VERSION@
bbdff76a
WD
32
33 HEADERS=byteorder.h config.h errcode.h proto.h rsync.h smb_acls.h lib/pool_alloc.h
34 LIBOBJ=lib/wildmatch.o lib/compat.o lib/snprintf.o lib/mdfour.o \
35- lib/permstring.o lib/pool_alloc.o lib/sysacls.o @LIBOBJS@
36+ lib/permstring.o lib/pool_alloc.o lib/sysacls.o lib/sysxattr.o @LIBOBJS@
4bf6f8c7
WD
37 ZLIBOBJ=zlib/deflate.o zlib/inffast.o zlib/inflate.o zlib/inftrees.o \
38 zlib/trees.o zlib/zutil.o zlib/adler32.o zlib/compress.o zlib/crc32.o
bbdff76a
WD
39 OBJS1=rsync.o generator.o receiver.o cleanup.o sender.o exclude.o util.o \
40 main.o checksum.o match.o syscall.o log.o backup.o
41 OBJS2=options.o flist.o io.o compat.o hlink.o token.o uidlist.o socket.o \
610969d1
WD
42- fileio.o batch.o clientname.o chmod.o acls.o
43+ fileio.o batch.o clientname.o chmod.o acls.o xattr.o
bbdff76a
WD
44 OBJS3=progress.o pipe.o
45 DAEMON_OBJ = params.o loadparm.o clientserver.o access.o connection.o authenticate.o
46 popt_OBJS=popt/findme.o popt/popt.o popt/poptconfig.o \
0f6fb3c8
WD
47--- old/acls.c
48+++ new/acls.c
03019e41 49@@ -30,6 +30,7 @@ extern int read_only;
8889f85e 50 extern int list_only;
0f6fb3c8
WD
51 extern int orig_umask;
52 extern int preserve_acls;
53+extern int preserve_xattrs;
54 extern unsigned int file_struct_len;
55
56 /* === ACL structures === */
03019e41 57@@ -741,6 +742,10 @@ void receive_acl(struct file_struct *fil
0f6fb3c8
WD
58 type = SMB_ACL_TYPE_ACCESS;
59 racl_list = &access_acl_list;
60 ndx_ptr = (char*)file + file_struct_len;
61+#ifdef SUPPORT_XATTRS
62+ if (preserve_xattrs)
63+ ndx_ptr += 4;
64+#endif
65 do {
66 char tag = read_byte(f);
67 int ndx;
03019e41 68@@ -800,6 +805,10 @@ void cache_acl(struct file_struct *file,
0f6fb3c8
WD
69 racl = sxp->acc_acl;
70 racl_list = &access_acl_list;
71 ndx_ptr = (char*)file + file_struct_len;
72+#ifdef SUPPORT_XATTRS
73+ if (preserve_xattrs)
74+ ndx_ptr += 4;
75+#endif
76 do {
77 if (!racl)
78 ndx = -1;
03019e41 79@@ -920,6 +929,10 @@ int set_acl(const char *fname, const str
0f6fb3c8
WD
80
81 type = SMB_ACL_TYPE_ACCESS;
82 ndx_ptr = (char*)file + file_struct_len;
83+#ifdef SUPPORT_XATTRS
84+ if (preserve_xattrs)
85+ ndx_ptr += 4;
86+#endif
87 do {
88 acl_duo *duo_item;
89 BOOL eq;
9a7eef96
WD
90--- old/backup.c
91+++ new/backup.c
dc52bc1a 92@@ -30,6 +30,7 @@ extern char *backup_dir;
93d6ca6d
WD
93
94 extern int am_root;
95 extern int preserve_acls;
96+extern int preserve_xattrs;
97 extern int preserve_devices;
98 extern int preserve_specials;
99 extern int preserve_links;
0f6fb3c8
WD
100@@ -136,6 +137,9 @@ static int make_bak_dir(char *fullpath)
101 #ifdef SUPPORT_ACLS
102 sx.acc_acl = sx.def_acl = NULL;
103 #endif
104+#ifdef SUPPORT_XATTRS
105+ sx.xattr = NULL;
106+#endif
107 if (!(file = make_file(rel, NULL, NULL, 0, NO_FILTERS)))
108 continue;
109 #ifdef SUPPORT_ACLS
110@@ -144,6 +148,12 @@ static int make_bak_dir(char *fullpath)
111 cache_acl(file, &sx);
112 }
09cc6650
WD
113 #endif
114+#ifdef SUPPORT_XATTRS
0f6fb3c8
WD
115+ if (preserve_xattrs) {
116+ get_xattr(rel, &sx);
117+ cache_xattr(file, &sx);
118+ }
09cc6650 119+#endif
0f6fb3c8
WD
120 set_file_attrs(fullpath, file, NULL, 0);
121 free(file);
bbdff76a 122 }
0f6fb3c8
WD
123@@ -195,6 +205,9 @@ static int keep_backup(char *fname)
124 #ifdef SUPPORT_ACLS
125 sx.acc_acl = sx.def_acl = NULL;
09cc6650
WD
126 #endif
127+#ifdef SUPPORT_XATTRS
0f6fb3c8 128+ sx.xattr = NULL;
09cc6650 129+#endif
bbdff76a 130
0f6fb3c8
WD
131 if (!(file = make_file(fname, NULL, NULL, 0, NO_FILTERS)))
132 return 1; /* the file could have disappeared */
133@@ -208,6 +221,12 @@ static int keep_backup(char *fname)
134 cache_acl(file, &sx);
135 }
09cc6650
WD
136 #endif
137+#ifdef SUPPORT_XATTRS
0f6fb3c8
WD
138+ if (preserve_xattrs) {
139+ get_xattr(fname, &sx);
140+ cache_xattr(file, &sx);
141+ }
09cc6650 142+#endif
bbdff76a 143
0f6fb3c8
WD
144 /* Check to see if this is a device file, or link */
145 if ((am_root && preserve_devices && IS_DEVICE(file->mode))
9a7eef96
WD
146--- old/configure.in
147+++ new/configure.in
742a4103 148@@ -856,6 +856,40 @@ samba_cv_HAVE_ACL_GET_PERM_NP=yes,samba_
bbdff76a
WD
149 AC_MSG_RESULT(no)
150 )
151
152+AC_CHECK_HEADERS(attr/xattr.h)
49de5440 153+AC_CHECK_HEADERS(sys/xattr.h)
742a4103 154+AC_CHECK_HEADERS(sys/extattr.h)
bbdff76a 155+AC_MSG_CHECKING(whether to support extended attributes)
f787c90c
WD
156+AC_ARG_ENABLE(xattr-support,
157+AC_HELP_STRING([--enable-xattr-support], [Include extended attribute support (default=no)]),
3b05e91f 158+[ case "$enableval" in
bbdff76a
WD
159+ yes)
160+ case "$host_os" in
161+ *linux*)
162+ AC_MSG_RESULT(Using Linux xattrs)
163+ AC_DEFINE(HAVE_LINUX_XATTRS, 1, [True if you have Linux xattrs])
164+ ;;
49de5440
WD
165+ darwin*)
166+ AC_MSG_RESULT(Using OS X xattrs)
167+ AC_DEFINE(HAVE_OSX_XATTRS, 1, [True if you have Mac OS X xattrs])
168+ ;;
742a4103
WD
169+ freebsd*)
170+ AC_MSG_RESULT(Using FreeBSD extattrs)
171+ AC_DEFINE(HAVE_FREEBSD_XATTRS, 1, [True if you have FreeBSD xattrs])
172+ ;;
bbdff76a 173+ *)
49de5440 174+ AC_MSG_RESULT(Xattrs requested but not Linux or OS X. Good luck...)
bbdff76a
WD
175+ ;;
176+ esac
177+ ;;
178+ *)
179+ AC_MSG_RESULT(no)
742378cf 180+ AC_DEFINE(HAVE_NO_XATTRS, 1, [True if you don't have extended attributes])
bbdff76a
WD
181+ esac ],
182+ AC_MSG_RESULT(no)
56473cb9 183+ AC_DEFINE(HAVE_NO_XATTRS, 1, [True if you don't have extended attributes])
bbdff76a
WD
184+)
185+
186 AC_CONFIG_FILES([Makefile lib/dummy zlib/dummy popt/dummy shconfig])
187 AC_OUTPUT
188
9a7eef96
WD
189--- old/flist.c
190+++ new/flist.c
dc52bc1a 191@@ -41,6 +41,7 @@ extern int one_file_system;
93d6ca6d
WD
192 extern int copy_dirlinks;
193 extern int keep_dirlinks;
194 extern int preserve_acls;
195+extern int preserve_xattrs;
196 extern int preserve_links;
197 extern int preserve_hard_links;
198 extern int preserve_devices;
de565f59 199@@ -498,7 +499,7 @@ static struct file_struct *receive_file_
0f6fb3c8
WD
200 char thisname[MAXPATHLEN];
201 unsigned int l1 = 0, l2 = 0;
202 int alloc_len, basename_len, dirname_len, linkname_len, sum_len;
203-#ifdef SUPPORT_ACLS
204+#if defined SUPPORT_ACLS || defined SUPPORT_XATTRS
205 int xtra_len;
206 #endif
207 OFF_T file_length;
de565f59 208@@ -610,10 +611,16 @@ static struct file_struct *receive_file_
0f6fb3c8
WD
209 xtra_len = (S_ISDIR(mode) ? 2 : 1) * 4;
210 else
211 xtra_len = 0;
212+#elif defined SUPPORT_XATTRS
213+ xtra_len = 0;
214+#endif
215+#ifdef SUPPORT_XATTRS
216+ if (preserve_xattrs)
217+ xtra_len += 4;
218 #endif
219
220 alloc_len = file_struct_len + dirname_len + basename_len
221-#ifdef SUPPORT_ACLS
222+#if defined SUPPORT_ACLS || defined SUPPORT_XATTRS
223 + xtra_len
224 #endif
225 + linkname_len + sum_len;
de565f59 226@@ -622,7 +629,7 @@ static struct file_struct *receive_file_
0f6fb3c8
WD
227 file = (struct file_struct *)bp;
228 memset(bp, 0, file_struct_len);
229 bp += file_struct_len;
230-#ifdef SUPPORT_ACLS
231+#if defined SUPPORT_ACLS || defined SUPPORT_XATTRS
232 bp += xtra_len;
233 #endif
234
de565f59 235@@ -723,6 +730,10 @@ static struct file_struct *receive_file_
0f6fb3c8
WD
236 if (preserve_acls)
237 receive_acl(file, f);
238 #endif
239+#ifdef SUPPORT_XATTRS
240+ if (preserve_xattrs)
241+ receive_xattr(file, f );
242+#endif
243
244 return file;
245 }
a071aea2
WD
246@@ -974,7 +985,7 @@ static struct file_struct *send_file_nam
247 unsigned short flags)
248 {
249 struct file_struct *file;
250-#ifdef SUPPORT_ACLS
251+#if defined SUPPORT_ACLS || defined SUPPORT_XATTRS
252 statx sx;
253 #endif
254
de565f59 255@@ -994,6 +1005,13 @@ static struct file_struct *send_file_nam
0f6fb3c8
WD
256 return NULL;
257 }
09cc6650
WD
258 #endif
259+#ifdef SUPPORT_XATTRS
0f6fb3c8
WD
260+ if (preserve_xattrs) {
261+ sx.xattr = NULL;
262+ if (get_xattr(fname, &sx) < 0)
263+ return NULL;
264+ }
09cc6650 265+#endif
bbdff76a 266
a2f9a486
WD
267 maybe_emit_filelist_progress(flist->count + flist_count_offset);
268
de565f59 269@@ -1006,11 +1024,19 @@ static struct file_struct *send_file_nam
93d6ca6d 270 if (preserve_acls)
0f6fb3c8 271 send_acl(&sx, f);
93d6ca6d 272 #endif
09cc6650 273+#ifdef SUPPORT_XATTRS
93d6ca6d 274+ if (preserve_xattrs)
0f6fb3c8 275+ send_xattr(&sx, f);
09cc6650 276+#endif
bbdff76a 277 } else {
93d6ca6d 278 #ifdef SUPPORT_ACLS
93d6ca6d 279 if (preserve_acls)
0f6fb3c8 280 free_acl(&sx);
09cc6650
WD
281 #endif
282+#ifdef SUPPORT_XATTRS
93d6ca6d 283+ if (preserve_xattrs)
0f6fb3c8 284+ free_xattr(&sx);
09cc6650 285+#endif
bbdff76a
WD
286 }
287 return file;
288 }
9a7eef96
WD
289--- old/lib/sysxattr.c
290+++ new/lib/sysxattr.c
742a4103 291@@ -0,0 +1,136 @@
dc52bc1a
WD
292+/*
293+ * Extended attribute support for rsync.
294+ *
295+ * Copyright (C) 2004 Red Hat, Inc.
296+ * Written by Jay Fenlason.
297+ *
298+ * This program is free software; you can redistribute it and/or modify
299+ * it under the terms of the GNU General Public License as published by
300+ * the Free Software Foundation; either version 2 of the License, or
301+ * (at your option) any later version.
302+ *
303+ * This program is distributed in the hope that it will be useful,
304+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
305+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
306+ * GNU General Public License for more details.
307+ *
308+ * You should have received a copy of the GNU General Public License along
309+ * with this program; if not, write to the Free Software Foundation, Inc.,
310+ * 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
311+ */
bbdff76a
WD
312+
313+#include "rsync.h"
0f6fb3c8 314+#include "sysxattr.h"
bbdff76a 315+
56473cb9
WD
316+#ifdef SUPPORT_XATTRS
317+
09cc6650 318+#if defined HAVE_LINUX_XATTRS
bbdff76a
WD
319+
320+ssize_t sys_lgetxattr(const char *path, const char *name, void *value, size_t size)
321+{
322+ return lgetxattr(path, name, value, size);
323+}
324+
8627d8a2
WD
325+ssize_t sys_fgetxattr(int filedes, const char *name, void *value, size_t size)
326+{
0bac098f 327+ return fgetxattr(filedes, name, value, size);
8627d8a2
WD
328+}
329+
742a4103 330+int sys_lsetxattr(const char *path, const char *name, const void *value, size_t size)
bbdff76a 331+{
742a4103 332+ return lsetxattr(path, name, value, size, 0);
bbdff76a
WD
333+}
334+
a74926e4
WD
335+int sys_lremovexattr(const char *path, const char *name)
336+{
337+ return lremovexattr(path, name);
338+}
339+
bbdff76a
WD
340+ssize_t sys_llistxattr(const char *path, char *list, size_t size)
341+{
342+ return llistxattr(path, list, size);
343+}
344+
49de5440
WD
345+#elif HAVE_OSX_XATTRS
346+
347+ssize_t sys_lgetxattr(const char *path, const char *name, void *value, size_t size)
348+{
349+ return getxattr(path, name, value, size, 0, XATTR_NOFOLLOW);
350+}
351+
8627d8a2
WD
352+ssize_t sys_fgetxattr(int filedes, const char *name, void *value, size_t size)
353+{
0bac098f 354+ return fgetxattr(filedes, name, value, size, 0, 0);
8627d8a2
WD
355+}
356+
742a4103 357+int sys_lsetxattr(const char *path, const char *name, const void *value, size_t size)
49de5440 358+{
742a4103 359+ return setxattr(path, name, value, size, 0, XATTR_NOFOLLOW);
49de5440
WD
360+}
361+
a74926e4
WD
362+int sys_lremovexattr(const char *path, const char *name)
363+{
364+ return removexattr(path, name, XATTR_NOFOLLOW);
365+}
366+
49de5440
WD
367+ssize_t sys_llistxattr(const char *path, char *list, size_t size)
368+{
369+ return listxattr(path, list, size, XATTR_NOFOLLOW);
370+}
371+
742a4103
WD
372+#elif HAVE_FREEBSD_XATTRS
373+
374+ssize_t sys_lgetxattr(const char *path, const char *name, void *value, size_t size)
375+{
376+ return extattr_get_link(path, EXTATTR_NAMESPACE_USER, name, value, size);
377+}
378+
379+ssize_t sys_fgetxattr(int filedes, const char *name, void *value, size_t size)
380+{
381+ return extattr_get_fd(filedes, EXTATTR_NAMESPACE_USER, name, value, size);
382+}
383+
384+int sys_lsetxattr(const char *path, const char *name, const void *value, size_t size)
385+{
386+ return extattr_set_link(path, EXTATTR_NAMESPACE_USER, name, value, size);
387+}
388+
389+int sys_lremovexattr(const char *path, const char *name)
390+{
391+ return extattr_delete_link(path, EXTATTR_NAMESPACE_USER, name);
392+}
393+
394+ssize_t sys_llistxattr(const char *path, char *list, size_t size)
395+{
396+ unsigned char keylen;
397+ ssize_t off, len = extattr_list_link(path, EXTATTR_NAMESPACE_USER, list, size);
398+
399+ if (len <= 0 || (size_t)len > size)
400+ return len;
401+
402+ /* FreeBSD puts a single-byte length before each string, with no '\0'
403+ * terminator. We need to change this into a series of null-terminted
404+ * strings. Since the size is the same, we can simply transform the
405+ * output in place. */
406+ for (off = 0; off < len; ) {
407+ keylen = ((unsigned char*)list)[off];
408+ if (off + keylen >= len) {
409+ /* Should be impossible, but kernel bugs happen! */
410+ errno = EINVAL;
411+ return -1;
412+ }
413+ memmove(list+off, list+off+1, keylen);
414+ off += keylen;
415+ list[off++] = '\0';
416+ }
417+
418+ return len;
419+}
420+
bbdff76a
WD
421+#else
422+
56473cb9
WD
423+#error You need to create xattr compatibility functions.
424+
425+#endif
426+
427+#endif /* SUPPORT_XATTRS */
9a7eef96
WD
428--- old/lib/sysxattr.h
429+++ new/lib/sysxattr.h
742a4103 430@@ -0,0 +1,26 @@
49de5440 431+#ifdef SUPPORT_XATTRS
8889f85e 432+
49de5440 433+#if defined HAVE_ATTR_XATTR_H
0f6fb3c8 434+#include <attr/xattr.h>
49de5440
WD
435+#elif defined HAVE_SYS_XATTR_H
436+#include <sys/xattr.h>
742a4103
WD
437+#elif defined HAVE_SYS_EXTATTR_H
438+#include <sys/extattr.h>
49de5440 439+#endif
bbdff76a 440+
a74926e4
WD
441+/* Linux 2.4 does not define this as a distinct errno value: */
442+#ifndef ENOATTR
443+#define ENOATTR ENODATA
444+#endif
445+
bbdff76a 446+ssize_t sys_lgetxattr(const char *path, const char *name, void *value, size_t size);
8627d8a2 447+ssize_t sys_fgetxattr(int filedes, const char *name, void *value, size_t size);
742a4103 448+int sys_lsetxattr(const char *path, const char *name, const void *value, size_t size);
a74926e4 449+int sys_lremovexattr(const char *path, const char *name);
bbdff76a
WD
450+ssize_t sys_llistxattr(const char *path, char *list, size_t size);
451+
452+#else
453+
8889f85e 454+/* No xattrs available */
49de5440
WD
455+
456+#endif
9a7eef96
WD
457--- old/options.c
458+++ new/options.c
dc52bc1a 459@@ -48,6 +48,7 @@ int copy_links = 0;
bbdff76a
WD
460 int preserve_links = 0;
461 int preserve_hard_links = 0;
462 int preserve_acls = 0;
463+int preserve_xattrs = 0;
464 int preserve_perms = 0;
4a65fe72 465 int preserve_executability = 0;
bbdff76a 466 int preserve_devices = 0;
4959107f 467@@ -201,6 +202,7 @@ static void print_rsync_version(enum log
bbdff76a
WD
468 char const *have_inplace = "no ";
469 char const *hardlinks = "no ";
470 char const *acls = "no ";
471+ char const *xattrs = "no ";
472 char const *links = "no ";
473 char const *ipv6 = "no ";
474 STRUCT_STAT *dumstat;
4959107f 475@@ -220,7 +222,9 @@ static void print_rsync_version(enum log
bbdff76a
WD
476 #ifdef SUPPORT_ACLS
477 acls = "";
478 #endif
479-
480+#ifdef SUPPORT_XATTRS
481+ xattrs = "";
482+#endif
483 #ifdef SUPPORT_LINKS
484 links = "";
485 #endif
56473cb9
WD
486@@ -236,8 +240,8 @@ static void print_rsync_version(enum log
487 rprintf(f, "Capabilities: %d-bit files, %ssocketpairs, %shard links, %ssymlinks,\n",
488 (int) (sizeof (OFF_T) * 8), got_socketpair, hardlinks, links);
489
490- rprintf(f, " batchfiles, %sinplace, %sIPv6, %sACLs,\n",
491- have_inplace, ipv6, acls);
492+ rprintf(f, " batchfiles, %sinplace, %sIPv6, %sACLs, %sxattrs,\n",
493+ have_inplace, ipv6, acls, xattrs);
bbdff76a
WD
494
495 /* Note that this field may not have type ino_t. It depends
496 * on the complicated interaction between largefile feature
56473cb9 497@@ -289,7 +293,7 @@ void usage(enum logcode F)
1b57ecb0 498 rprintf(F," -q, --quiet suppress non-error messages\n");
4959107f 499 rprintf(F," --no-motd suppress daemon-mode MOTD (see manpage caveat)\n");
1b57ecb0
WD
500 rprintf(F," -c, --checksum skip based on checksum, not mod-time & size\n");
501- rprintf(F," -a, --archive archive mode; same as -rlptgoD (no -H, -A)\n");
502+ rprintf(F," -a, --archive archive mode; equals -rlptgoD (no -H,-A,-X)\n");
503 rprintf(F," --no-OPTION turn off an implied OPTION (e.g. --no-D)\n");
504 rprintf(F," -r, --recursive recurse into directories\n");
505 rprintf(F," -R, --relative use relative path names\n");
56473cb9 506@@ -314,6 +318,9 @@ void usage(enum logcode F)
3610c43c 507 #ifdef SUPPORT_ACLS
bbdff76a 508 rprintf(F," -A, --acls preserve ACLs (implies --perms)\n");
3610c43c
WD
509 #endif
510+#ifdef SUPPORT_XATTRS
bbdff76a 511+ rprintf(F," -X, --xattrs preserve extended attributes (implies --perms)\n");
3610c43c 512+#endif
4a65fe72 513 rprintf(F," -o, --owner preserve owner (super-user only)\n");
bbdff76a 514 rprintf(F," -g, --group preserve group\n");
1ed0b5c9 515 rprintf(F," --devices preserve device files (super-user only)\n");
56473cb9 516@@ -436,6 +443,9 @@ static struct poptOption long_options[]
489b0a72
WD
517 {"acls", 'A', POPT_ARG_NONE, 0, 'A', 0, 0 },
518 {"no-acls", 0, POPT_ARG_VAL, &preserve_acls, 0, 0, 0 },
519 {"no-A", 0, POPT_ARG_VAL, &preserve_acls, 0, 0, 0 },
520+ {"xattrs", 'X', POPT_ARG_NONE, 0, 'X', 0, 0 },
521+ {"no-xattrs", 0, POPT_ARG_VAL, &preserve_xattrs, 0, 0, 0 },
522+ {"no-X", 0, POPT_ARG_VAL, &preserve_xattrs, 0, 0, 0 },
523 {"times", 't', POPT_ARG_VAL, &preserve_times, 1, 0, 0 },
524 {"no-times", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
525 {"no-t", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
56473cb9 526@@ -1117,6 +1127,17 @@ int parse_arguments(int *argc, const cha
489b0a72 527 return 0;
3610c43c 528 #endif
bbdff76a
WD
529
530+ case 'X':
531+#ifdef SUPPORT_XATTRS
532+ preserve_xattrs = 1;
533+ preserve_perms = 1;
489b0a72 534+ break;
bbdff76a
WD
535+#else
536+ snprintf(err_buf,sizeof(err_buf),
537+ "extended attributes are not supported on this %s\n",
538+ am_server ? "server" : "client");
539+ return 0;
d2dc8a18 540+#endif
bbdff76a
WD
541
542 default:
543 /* A large opt value means that set_refuse_options()
56473cb9 544@@ -1563,6 +1584,10 @@ void server_options(char **args,int *arg
bbdff76a
WD
545 if (preserve_acls)
546 argstr[x++] = 'A';
3610c43c
WD
547 #endif
548+#ifdef SUPPORT_XATTRS
bbdff76a
WD
549+ if (preserve_xattrs)
550+ argstr[x++] = 'X';
3610c43c 551+#endif
bbdff76a
WD
552 if (preserve_uid)
553 argstr[x++] = 'o';
554 if (preserve_gid)
9a7eef96
WD
555--- old/rsync.c
556+++ new/rsync.c
ff318e90
WD
557@@ -33,6 +33,7 @@
558 extern int verbose;
93d6ca6d 559 extern int dry_run;
93d6ca6d
WD
560 extern int preserve_acls;
561+extern int preserve_xattrs;
562 extern int preserve_perms;
563 extern int preserve_executability;
564 extern int preserve_times;
03019e41 565@@ -218,6 +219,10 @@ int set_file_attrs(char *fname, struct f
071c5b19
WD
566 if (daemon_chmod_modes && !S_ISLNK(new_mode))
567 new_mode = tweak_mode(new_mode, daemon_chmod_modes);
568
09cc6650 569+#ifdef SUPPORT_XATTRS
0f6fb3c8 570+ if (preserve_xattrs && set_xattr(fname, file, sxp) == 0)
09cc6650
WD
571+ updated = 1;
572+#endif
071c5b19
WD
573 #ifdef SUPPORT_ACLS
574 /* It's OK to call set_acl() now, even for a dir, as the generator
575 * will enable owner-writability using chmod, if necessary.
9a7eef96
WD
576--- old/rsync.h
577+++ new/rsync.h
56473cb9 578@@ -500,6 +500,10 @@ struct idev {
0f6fb3c8 579 #define ACLS_NEED_MASK 1
09cc6650 580 #endif
bbdff76a 581
56473cb9 582+#ifndef HAVE_NO_XATTRS
bbdff76a
WD
583+#define SUPPORT_XATTRS 1
584+#endif
585+
0f6fb3c8
WD
586 #define GID_NONE ((gid_t)-1)
587
588 #define HL_CHECK_MASTER 0
56473cb9 589@@ -694,6 +698,9 @@ typedef struct {
0f6fb3c8
WD
590 struct rsync_acl *acc_acl; /* access ACL */
591 struct rsync_acl *def_acl; /* default ACL */
592 #endif
593+#ifdef SUPPORT_XATTRS
594+ item_list *xattr;
bbdff76a 595+#endif
0f6fb3c8 596 } statx;
bbdff76a 597
0f6fb3c8 598 #define ACL_READY(sx) ((sx).acc_acl != NULL)
9a7eef96
WD
599--- old/rsync.yo
600+++ new/rsync.yo
4959107f 601@@ -301,7 +301,7 @@ to the detailed description below for a
1b57ecb0 602 -q, --quiet suppress non-error messages
4959107f 603 --no-motd suppress daemon-mode MOTD (see caveat)
1b57ecb0
WD
604 -c, --checksum skip based on checksum, not mod-time & size
605- -a, --archive archive mode; same as -rlptgoD (no -H, -A)
606+ -a, --archive archive mode; equals -rlptgoD (no -H,-A,-X)
607 --no-OPTION turn off an implied OPTION (e.g. --no-D)
608 -r, --recursive recurse into directories
609 -R, --relative use relative path names
4959107f 610@@ -324,6 +324,7 @@ to the detailed description below for a
4a65fe72 611 -E, --executability preserve executability
063cf77b 612 --chmod=CHMOD affect file and/or directory permissions
4a65fe72
WD
613 -A, --acls preserve ACLs (implies -p) [non-standard]
614+ -X, --xattrs preserve extended attrs (implies -p) [n.s.]
4a65fe72 615 -o, --owner preserve owner (super-user only)
bbdff76a 616 -g, --group preserve group
1ed0b5c9 617 --devices preserve device files (super-user only)
4959107f 618@@ -818,6 +819,11 @@ version makes it incompatible with sendi
3fcc541f
WD
619 rsync unless you double the bf(--acls) option (e.g. bf(-AA)). This
620 doubling is not needed when pulling files from an older rsync.
bbdff76a
WD
621
622+dit(bf(-X, --xattrs)) This option causes rsync to update the remote
623+extended attributes to be the same as the local ones. This will work
624+only if the remote machine's rsync supports this option also. This is
625+a non-standard option.
626+
4a65fe72
WD
627 dit(bf(--chmod)) This option tells rsync to apply one or more
628 comma-separated "chmod" strings to the permission of the files in the
629 transfer. The resulting value is treated as though it was the permissions
9a7eef96
WD
630--- old/xattr.c
631+++ new/xattr.c
27502d8d 632@@ -0,0 +1,406 @@
dc52bc1a
WD
633+/*
634+ * Extended Attribute support for rsync.
0f6fb3c8 635+ * Written by Jay Fenlason, vaguely based on the ACLs patch.
dc52bc1a
WD
636+ *
637+ * Copyright (C) 2004 Red Hat, Inc.
0f6fb3c8 638+ * Copyright (C) 2006 Wayne Davison
dc52bc1a
WD
639+ *
640+ * This program is free software; you can redistribute it and/or modify
641+ * it under the terms of the GNU General Public License as published by
642+ * the Free Software Foundation; either version 2 of the License, or
643+ * (at your option) any later version.
644+ *
645+ * This program is distributed in the hope that it will be useful,
646+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
647+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
648+ * GNU General Public License for more details.
649+ *
650+ * You should have received a copy of the GNU General Public License along
651+ * with this program; if not, write to the Free Software Foundation, Inc.,
652+ * 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
653+ */
bbdff76a
WD
654+
655+#include "rsync.h"
656+#include "lib/sysxattr.h"
657+
658+#ifdef SUPPORT_XATTRS
659+
bbdff76a 660+extern int dry_run;
3f24a3a8 661+extern int am_root;
8889f85e
WD
662+extern int read_only;
663+extern int list_only;
0f6fb3c8 664+extern unsigned int file_struct_len;
bbdff76a
WD
665+
666+#define RSYNC_XAL_INITIAL 5
667+#define RSYNC_XAL_LIST_INITIAL 100
668+
3f24a3a8 669+#define USER_PREFIX "user."
27502d8d
WD
670+#define UPRE_LEN ((int)sizeof USER_PREFIX - 1)
671+#define SYSTEM_PREFIX "system."
672+#define SPRE_LEN ((int)sizeof SYSTEM_PREFIX - 1)
673+
674+#ifdef HAVE_LINUX_XATTRS
675+#define RPRE_LEN 0
676+#else
677+#define RSYNC_PREFIX "rsync."
678+#define RPRE_LEN ((int)sizeof RSYNC_PREFIX - 1)
679+#endif
3f24a3a8 680+
bbdff76a 681+typedef struct {
27502d8d
WD
682+ char *datum, *name;
683+ size_t datum_len, name_len;
bbdff76a
WD
684+} rsync_xa;
685+
bbdff76a
WD
686+static size_t namebuf_len = 0;
687+static char *namebuf = NULL;
688+
0f6fb3c8
WD
689+static item_list empty_xattr = EMPTY_ITEM_LIST;
690+static item_list rsync_xal_l = EMPTY_ITEM_LIST;
bbdff76a
WD
691+
692+/* ------------------------------------------------------------------------- */
693+
0f6fb3c8 694+static void rsync_xal_free(item_list *xalp)
bbdff76a
WD
695+{
696+ size_t i;
0f6fb3c8 697+ rsync_xa *rxas = xalp->items;
bbdff76a 698+
0f6fb3c8 699+ for (i = 0; i < xalp->count; i++) {
27502d8d
WD
700+ free(rxas[i].datum);
701+ /*free(rxas[i].name);*/
bbdff76a 702+ }
0f6fb3c8 703+ xalp->count = 0;
bbdff76a
WD
704+}
705+
0f6fb3c8 706+void free_xattr(statx *sxp)
bbdff76a 707+{
0f6fb3c8
WD
708+ rsync_xal_free(sxp->xattr);
709+ free(sxp->xattr);
710+ sxp->xattr = NULL;
711+}
bbdff76a 712+
0f6fb3c8
WD
713+static int rsync_xal_compare_names(const void *x1, const void *x2)
714+{
715+ const rsync_xa *xa1 = x1;
716+ const rsync_xa *xa2 = x2;
bbdff76a
WD
717+ return strcmp(xa1->name, xa2->name);
718+}
719+
0f6fb3c8 720+static int rsync_xal_get(const char *fname, item_list *xalp)
bbdff76a 721+{
27502d8d
WD
722+ ssize_t list_len, name_len, datum_len;
723+ char *name, *ptr;
bbdff76a
WD
724+
725+ if (!namebuf) {
49de5440 726+ namebuf_len = 1024;
bbdff76a 727+ namebuf = new_array(char, namebuf_len);
49de5440 728+ if (!namebuf)
bbdff76a
WD
729+ out_of_memory("rsync_xal_get");
730+ }
731+
49de5440 732+ /* The length returned includes all the '\0' terminators. */
27502d8d
WD
733+ list_len = sys_llistxattr(fname, namebuf, namebuf_len);
734+ if (list_len > (ssize_t)namebuf_len) {
735+ list_len = -1;
bbdff76a
WD
736+ errno = ERANGE;
737+ }
27502d8d 738+ if (list_len < 0) {
bbdff76a 739+ if (errno == ENOTSUP)
0f6fb3c8 740+ return 0;
bbdff76a 741+ if (errno == ERANGE) {
27502d8d
WD
742+ list_len = sys_llistxattr(fname, NULL, 0);
743+ if (list_len < 0) {
0f6fb3c8
WD
744+ rsyserr(FERROR, errno, "%s: rsync_xal_get: llistxattr",
745+ fname);
e5754c5f 746+ return -1;
bbdff76a 747+ }
27502d8d 748+ namebuf = realloc_array(namebuf, char, list_len + 1024);
bbdff76a
WD
749+ if (!namebuf)
750+ out_of_memory("rsync_xal_get");
27502d8d
WD
751+ namebuf_len = list_len + 1024;
752+ list_len = sys_llistxattr(fname, namebuf, namebuf_len);
753+ if (list_len < 0) {
0f6fb3c8
WD
754+ rsyserr(FERROR, errno,
755+ "%s: rsync_xal_get: re-llistxattr failed",
756+ fname);
e5754c5f 757+ return -1;
bbdff76a
WD
758+ }
759+ } else {
0f6fb3c8
WD
760+ rsyserr(FERROR, errno,
761+ "%s: rsync_xal_get: llistxattr failed:",
762+ fname);
e5754c5f 763+ return -1;
bbdff76a
WD
764+ }
765+ }
27502d8d 766+
b54d5ec2 767+ for (name = namebuf; list_len > 0; list_len -= name_len, name += name_len) {
3f24a3a8 768+ rsync_xa *rxas;
bbdff76a 769+
27502d8d 770+ name_len = strlen(name) + 1;
3f24a3a8
WD
771+
772+#ifdef HAVE_LINUX_XATTRS
27502d8d
WD
773+ /* We don't send the system namespace. */
774+ if (strncmp(name, SYSTEM_PREFIX, SPRE_LEN) == 0)
3f24a3a8
WD
775+ continue;
776+#endif
777+
27502d8d
WD
778+ datum_len = sys_lgetxattr(fname, name, NULL, 0);
779+ if (datum_len < 0) {
bbdff76a 780+ if (errno == ENOTSUP)
e5754c5f 781+ return -1;
49de5440
WD
782+ rsyserr(FERROR, errno,
783+ "%s: rsync_xal_get: lgetxattr %s failed",
784+ fname, name);
785+ return -1;
bbdff76a 786+ }
27502d8d 787+ ptr = new_array(char, name_len + datum_len);
bbdff76a
WD
788+ if (!ptr)
789+ out_of_memory("rsync_xal_get");
27502d8d
WD
790+ if (datum_len) {
791+ ssize_t len = sys_lgetxattr(fname, name, ptr, datum_len);
792+ if (len != datum_len) {
793+ if (len < 0) {
49de5440
WD
794+ rsyserr(FERROR, errno,
795+ "rsync_xal_get: lgetxattr(%s,%s)"
796+ " failed", fname, name);
797+ } else {
798+ rprintf(FERROR,
799+ "rsync_xal_get: lgetxattr(%s,%s)"
bb6b64ea
WD
800+ " returned %ld instead of %ld\n",
801+ fname, name,
27502d8d 802+ (long)len, (long)datum_len);
49de5440 803+ }
27502d8d 804+ free(ptr);
49de5440
WD
805+ return -1;
806+ }
807+ }
27502d8d
WD
808+ rxas = EXPAND_ITEM_LIST(xalp, rsync_xa, RSYNC_XAL_INITIAL);
809+ rxas->name = ptr + datum_len;
b54d5ec2 810+ rxas->datum = ptr;
27502d8d
WD
811+ rxas->name_len = name_len;
812+ rxas->datum_len = datum_len;
b54d5ec2 813+ memcpy(rxas->name, name, name_len);
bbdff76a 814+ }
0f6fb3c8
WD
815+ if (xalp->count > 1)
816+ qsort(xalp->items, xalp->count, sizeof (rsync_xa), rsync_xal_compare_names);
e5754c5f 817+ return 0;
bbdff76a
WD
818+}
819+
0f6fb3c8
WD
820+/* Read the xattr(s) for this filename. */
821+int get_xattr(const char *fname, statx *sxp)
bbdff76a 822+{
0f6fb3c8
WD
823+ sxp->xattr = new(item_list);
824+ *sxp->xattr = empty_xattr;
825+ if (rsync_xal_get(fname, sxp->xattr) < 0) {
826+ free_xattr(sxp);
827+ return -1;
828+ }
829+ return 0;
bbdff76a
WD
830+}
831+
0f6fb3c8 832+static int find_matching_xattr(item_list *xalp)
bbdff76a 833+{
0f6fb3c8
WD
834+ size_t i, j;
835+ item_list *lst = rsync_xal_l.items;
bbdff76a
WD
836+
837+ for (i = 0; i < rsync_xal_l.count; i++) {
0f6fb3c8
WD
838+ rsync_xa *rxas1 = lst[i].items;
839+ rsync_xa *rxas2 = xalp->items;
840+
bbdff76a 841+ /* Wrong number of elements? */
0f6fb3c8 842+ if (lst[i].count != xalp->count)
bbdff76a
WD
843+ continue;
844+ /* any elements different? */
0f6fb3c8
WD
845+ for (j = 0; j < xalp->count; j++) {
846+ if (rxas1[j].name_len != rxas2[j].name_len
847+ || rxas1[j].datum_len != rxas2[j].datum_len
848+ || strcmp(rxas1[j].name, rxas2[j].name)
849+ || memcmp(rxas1[j].datum, rxas2[j].datum, rxas2[j].datum_len))
bbdff76a
WD
850+ break;
851+ }
852+ /* no differences found. This is The One! */
0f6fb3c8
WD
853+ if (j == xalp->count)
854+ return i;
bbdff76a 855+ }
0f6fb3c8
WD
856+
857+ return -1;
bbdff76a
WD
858+}
859+
0f6fb3c8
WD
860+/* Store *xalp on the end of rsync_xal_l */
861+static void rsync_xal_store(item_list *xalp)
bbdff76a 862+{
0f6fb3c8 863+ item_list *new_lst = EXPAND_ITEM_LIST(&rsync_xal_l, item_list, RSYNC_XAL_LIST_INITIAL);
de565f59
WD
864+ /* Since the following call starts a new list, we know it will hold the
865+ * entire initial-count, not just enough space for one new item. */
49de5440
WD
866+ *new_lst = empty_xattr;
867+ (void)EXPAND_ITEM_LIST(new_lst, rsync_xa, xalp->count);
868+ memcpy(new_lst->items, xalp->items, xalp->count * sizeof (rsync_xa));
0f6fb3c8
WD
869+ new_lst->count = xalp->count;
870+ xalp->count = 0;
bbdff76a
WD
871+}
872+
0f6fb3c8
WD
873+/* Send the make_xattr()-generated xattr list for this flist entry. */
874+void send_xattr(statx *sxp, int f)
bbdff76a 875+{
0f6fb3c8
WD
876+ int ndx = find_matching_xattr(sxp->xattr);
877+ if (ndx != -1) {
bbdff76a 878+ write_byte(f, 'x');
0f6fb3c8
WD
879+ write_int(f, ndx);
880+ rsync_xal_free(sxp->xattr);
bbdff76a
WD
881+ } else {
882+ rsync_xa *rxa;
0f6fb3c8 883+ int count = sxp->xattr->count;
bbdff76a
WD
884+ write_byte(f, 'X');
885+ write_int(f, count);
0f6fb3c8 886+ for (rxa = sxp->xattr->items; count--; rxa++) {
27502d8d
WD
887+#ifdef HAVE_LINUX_XATTRS
888+ write_int(f, rxa->name_len);
889+ write_int(f, rxa->datum_len);
890+ write_buf(f, rxa->name, rxa->name_len);
891+#else
892+ /* We strip the rsync prefix from disguised namespaces
893+ * and put everything else in the user namespace. */
894+ if (strncmp(rxa->name, RSYNC_PREFIX, RPRE_LEN) == 0) {
895+ write_int(f, rxa->name_len - RPRE_LEN);
896+ write_int(f, rxa->datum_len);
897+ write_buf(f, rxa->name + RPRE_LEN, rxa->name_len - RPRE_LEN);
898+ } else {
3f24a3a8
WD
899+ write_int(f, rxa->name_len + UPRE_LEN);
900+ write_int(f, rxa->datum_len);
901+ write_buf(f, USER_PREFIX, UPRE_LEN);
27502d8d 902+ write_buf(f, rxa->name, rxa->name_len);
3f24a3a8 903+ }
27502d8d 904+#endif
bbdff76a
WD
905+ write_buf(f, rxa->datum, rxa->datum_len);
906+ }
49de5440 907+ rsync_xal_store(sxp->xattr); /* adds item to rsync_xal_l */
bbdff76a 908+ }
0f6fb3c8 909+ free_xattr(sxp);
bbdff76a
WD
910+}
911+
bbdff76a 912+/* ------------------------------------------------------------------------- */
bbdff76a 913+
0f6fb3c8 914+/* receive and build the rsync_xattr_lists */
bbdff76a
WD
915+void receive_xattr(struct file_struct *file, int f)
916+{
0f6fb3c8 917+ static item_list temp_xattr = EMPTY_ITEM_LIST;
0f6fb3c8 918+ char *ndx_ptr = (char*)file + file_struct_len;
27502d8d 919+ int ndx, tag = read_byte(f);
bbdff76a 920+
bbdff76a 921+ if (tag == 'X') {
0f6fb3c8 922+ int i, count = read_int(f);
bbdff76a 923+ for (i = 0; i < count; i++) {
27502d8d 924+ char *ptr, *name;
0f6fb3c8
WD
925+ rsync_xa *rxa;
926+ size_t name_len = read_int(f);
927+ size_t datum_len = read_int(f);
3fcc541f
WD
928+ if (name_len + datum_len < name_len)
929+ out_of_memory("receive_xattr"); /* overflow */
27502d8d
WD
930+#ifndef HAVE_LINUX_XATTRS
931+ if (name_len + datum_len + RPRE_LEN < RPRE_LEN)
932+ out_of_memory("receive_xattr"); /* overflow */
933+#endif
934+ ptr = new_array(char, name_len + datum_len + RPRE_LEN);
bbdff76a
WD
935+ if (!ptr)
936+ out_of_memory("receive_xattr");
27502d8d
WD
937+ name = ptr + datum_len + RPRE_LEN;
938+ read_buf(f, name, name_len);
939+ read_buf(f, ptr, datum_len);
3f24a3a8 940+#ifdef HAVE_LINUX_XATTRS
27502d8d
WD
941+ /* Non-root can only save the user namespace. */
942+ if (!am_root && strncmp(name, USER_PREFIX, UPRE_LEN) != 0) {
3f24a3a8
WD
943+ free(ptr);
944+ continue;
945+ }
946+#else
27502d8d
WD
947+ /* This OS only has a user namespace, so we either
948+ * strip the user prefix, or we put a non-user
949+ * namespace inside our rsync hierarchy. */
950+ if (strncmp(name, USER_PREFIX, UPRE_LEN) == 0) {
951+ name += UPRE_LEN;
952+ name_len -= UPRE_LEN;
953+ } else {
954+ name -= RPRE_LEN;
b54d5ec2 955+ name_len += RPRE_LEN;
27502d8d 956+ memcpy(name, RSYNC_PREFIX, RPRE_LEN);
517cc92f
WD
957+ }
958+#endif
27502d8d
WD
959+ rxa = EXPAND_ITEM_LIST(&temp_xattr, rsync_xa, count);
960+ rxa->name = name;
27502d8d 961+ rxa->datum = ptr;
b54d5ec2 962+ rxa->name_len = name_len;
27502d8d 963+ rxa->datum_len = datum_len;
bbdff76a 964+ }
49de5440
WD
965+ ndx = rsync_xal_l.count; /* pre-incremented count */
966+ rsync_xal_store(&temp_xattr); /* adds item to rsync_xal_l */
0f6fb3c8
WD
967+ } else if (tag == 'x') {
968+ ndx = read_int(f);
969+ if (ndx < 0 || (size_t)ndx >= rsync_xal_l.count) {
970+ rprintf(FERROR, "%s: receive_xattr: xa index %d out of range\n",
971+ f_name(file, NULL), ndx);
bbdff76a
WD
972+ exit_cleanup(RERR_STREAMIO);
973+ }
0f6fb3c8
WD
974+ } else {
975+ rprintf(FERROR,
976+ "%s: receive_xattr: unknown extended attribute type tag: %c\n",
977+ f_name(file, NULL), tag);
978+ exit_cleanup(RERR_STREAMIO);
bbdff76a 979+ }
bbdff76a 980+
0f6fb3c8 981+ SIVAL(ndx_ptr, 0, ndx);
bbdff76a
WD
982+}
983+
0f6fb3c8
WD
984+/* Turn the xattr data in statx into cached xattr data, setting the index
985+ * values in the file struct. */
986+void cache_xattr(struct file_struct *file, statx *sxp)
bbdff76a 987+{
0f6fb3c8
WD
988+ char *ndx_ptr = (char*)file + file_struct_len;
989+ int ndx;
bbdff76a 990+
0f6fb3c8
WD
991+ if (!sxp->xattr)
992+ return;
bbdff76a 993+
0f6fb3c8
WD
994+ ndx = find_matching_xattr(sxp->xattr);
995+ if (ndx == -1)
49de5440 996+ rsync_xal_store(sxp->xattr); /* adds item to rsync_xal_l */
0f6fb3c8 997+ free_xattr(sxp);
bbdff76a 998+
0f6fb3c8 999+ SIVAL(ndx_ptr, 0, ndx);
bbdff76a
WD
1000+}
1001+
0f6fb3c8 1002+static int rsync_xal_set(const char *fname, item_list *xalp)
bbdff76a 1003+{
0f6fb3c8
WD
1004+ rsync_xa *rxas = xalp->items;
1005+ size_t i;
1006+ int ret = 0;
bbdff76a 1007+
0f6fb3c8 1008+ for (i = 0; i < xalp->count; i++) {
742a4103 1009+ int status = sys_lsetxattr(fname, rxas[i].name, rxas[i].datum, rxas[i].datum_len);
0f6fb3c8
WD
1010+ if (status < 0) {
1011+ rsyserr(FERROR, errno, "%s: rsync_xal_set: lsetxattr %s failed",
1012+ fname, rxas[i].name);
1013+ ret = -1;
1014+ }
bbdff76a 1015+ }
0f6fb3c8 1016+ return ret;
bbdff76a
WD
1017+}
1018+
0f6fb3c8
WD
1019+/* Set extended attributes on indicated filename. */
1020+int set_xattr(const char *fname, const struct file_struct *file, UNUSED(statx *sxp))
bbdff76a 1021+{
0f6fb3c8
WD
1022+ int ndx;
1023+ char *ndx_ptr = (char*)file + file_struct_len;
1024+ item_list *lst = rsync_xal_l.items;
bbdff76a 1025+
93d6ca6d
WD
1026+ if (dry_run)
1027+ return 1; /* FIXME: --dry-run needs to compute this value */
1028+
8889f85e
WD
1029+ if (read_only || list_only) {
1030+ errno = EROFS;
1031+ return -1;
1032+ }
1033+
0f6fb3c8
WD
1034+ ndx = IVAL(ndx_ptr, 0);
1035+ return rsync_xal_set(fname, lst + ndx); /* TODO: This needs to return 1 if no xattrs changed! */
bbdff76a
WD
1036+}
1037+
1038+#endif /* SUPPORT_XATTRS */