Fixed failing hunks.
[rsync/rsync-patches.git] / atimes.diff
CommitLineData
03019e41 1To use this patch, run these commands for a successful build:
8a529471 2
03019e41 3 patch -p1 <patches/atimes.diff
27e96866
WD
4 ./prepare-source
5 ./configure (optional if already run)
6 make
8a529471
WD
7
8
fdf967c7
WD
9--- old/compat.c
10+++ new/compat.c
4306c620 11@@ -62,6 +62,8 @@ void setup_protocol(int f_out,int f_in)
7e27b6c0 12 preserve_uid = ++file_extra_cnt;
fdf967c7 13 if (preserve_gid)
7e27b6c0 14 preserve_gid = ++file_extra_cnt;
fdf967c7 15+ if (preserve_atimes)
7e27b6c0 16+ preserve_atimes = ++file_extra_cnt;
4306c620
WD
17 if (preserve_acls && !am_sender)
18 preserve_acls = ++file_extra_cnt;
fdf967c7 19
9a7eef96
WD
20--- old/flist.c
21+++ new/flist.c
fc068916 22@@ -48,6 +48,7 @@ extern int preserve_devices;
4a65fe72 23 extern int preserve_specials;
81c32ffd
WD
24 extern int preserve_uid;
25 extern int preserve_gid;
26+extern int preserve_atimes;
27 extern int relative_paths;
a5e0f697 28 extern int implied_dirs;
7e27b6c0 29 extern int file_extra_cnt;
fc068916 30@@ -143,6 +144,7 @@ void show_flist_stats(void)
672ad041
WD
31 static void list_file_entry(struct file_struct *f)
32 {
33 char permbuf[PERMSTRING_SIZE];
70891d26 34+ time_t atime = preserve_atimes ? F_ATIME(f) : 0;
1aa236e1 35 double len;
1cb60481 36
1aa236e1 37 if (!F_IS_ACTIVE(f)) {
4306c620 38@@ -157,14 +159,16 @@ static void list_file_entry(struct file_
43581f16 39
09fb8f03 40 #ifdef SUPPORT_LINKS
43581f16
WD
41 if (preserve_links && S_ISLNK(f->mode)) {
42- rprintf(FINFO, "%s %11.0f %s %s -> %s\n",
43+ rprintf(FINFO, "%s %11.0f %s %s %s -> %s\n",
1aa236e1 44 permbuf, len, timestring(f->modtime),
672ad041 45+ preserve_atimes ? timestring(atime) : "",
70891d26 46 f_name(f, NULL), F_SYMLINK(f));
43581f16
WD
47 } else
48 #endif
896c61d0 49 {
43581f16
WD
50- rprintf(FINFO, "%s %11.0f %s %s\n",
51+ rprintf(FINFO, "%s %11.0f %s %s %s\n",
1aa236e1 52 permbuf, len, timestring(f->modtime),
672ad041 53+ preserve_atimes ? timestring(atime) : "",
bd68c3c2 54 f_name(f, NULL));
896c61d0 55 }
43581f16 56 }
4306c620 57@@ -348,6 +352,7 @@ int push_flist_dir(const char *dir, int
fc068916 58 static void send_file_entry(int f, struct file_struct *file, int ndx)
43581f16 59 {
43581f16
WD
60 static time_t modtime;
61+ static time_t atime;
62 static mode_t mode;
ba50e96c 63 static int64 dev;
43581f16 64 static dev_t rdev;
4306c620 65@@ -415,6 +420,13 @@ static void send_file_entry(int f, struc
43581f16
WD
66 flags |= XMIT_SAME_TIME;
67 else
68 modtime = file->modtime;
81c32ffd 69+ if (preserve_atimes && !S_ISDIR(mode)) {
70891d26 70+ time_t file_atime = F_ATIME(file);
672ad041 71+ if (file_atime == atime)
43581f16
WD
72+ flags |= XMIT_SAME_ATIME;
73+ else
672ad041 74+ atime = file_atime;
43581f16
WD
75+ }
76
09fb8f03 77 #ifdef SUPPORT_HARD_LINKS
fdf967c7 78 if (tmp_dev != 0) {
4306c620 79@@ -482,6 +494,8 @@ static void send_file_entry(int f, struc
43581f16
WD
80 write_int(f, modtime);
81 if (!(flags & XMIT_SAME_MODE))
82 write_int(f, to_wire_mode(mode));
81c32ffd 83+ if (preserve_atimes && !S_ISDIR(mode) && !(flags & XMIT_SAME_ATIME))
43581f16
WD
84+ write_int(f, atime);
85 if (preserve_uid && !(flags & XMIT_SAME_UID)) {
4306c620 86 write_abbrevint30(f, uid);
fc068916 87 if (flags & XMIT_USER_NAME_FOLLOWS) {
4306c620 88@@ -558,7 +572,7 @@ static void send_file_entry(int f, struc
70891d26 89 static struct file_struct *recv_file_entry(struct file_list *flist,
7e27b6c0 90 int flags, int f)
43581f16 91 {
70891d26
WD
92- static time_t modtime;
93+ static time_t modtime, atime;
43581f16 94 static mode_t mode;
ba50e96c 95 static int64 dev;
43581f16 96 static dev_t rdev;
4306c620 97@@ -655,6 +669,8 @@ static struct file_struct *recv_file_ent
43581f16
WD
98 modtime = (time_t)read_int(f);
99 if (!(flags & XMIT_SAME_MODE))
100 mode = from_wire_mode(read_int(f));
81c32ffd 101+ if (preserve_atimes && !S_ISDIR(mode) && !(flags & XMIT_SAME_ATIME))
43581f16
WD
102+ atime = (time_t)read_int(f);
103
1cb60481
WD
104 if (chmod_modes && !S_ISLNK(mode))
105 mode = tweak_mode(mode, chmod_modes);
4306c620 106@@ -769,6 +785,8 @@ static struct file_struct *recv_file_ent
fc068916 107 F_OWNER(file) = uid;
70891d26 108 if (preserve_gid)
fc068916 109 F_GROUP(file) = gid;
1cb60481 110+ if (preserve_atimes)
70891d26 111+ F_ATIME(file) = atime;
1cb60481 112
fc068916
WD
113 if (basename != thisname) {
114 file->dirname = lastdir;
4306c620 115@@ -1074,6 +1092,8 @@ struct file_struct *make_file(const char
fc068916 116 F_OWNER(file) = st.st_uid;
70891d26 117 if (preserve_gid)
fc068916 118 F_GROUP(file) = st.st_gid;
1cb60481 119+ if (preserve_atimes)
70891d26 120+ F_ATIME(file) = st.st_atime;
1cb60481 121
fc068916
WD
122 if (basename != thisname)
123 file->dirname = lastdir;
9a7eef96
WD
124--- old/generator.c
125+++ new/generator.c
fc068916 126@@ -44,6 +44,7 @@ extern int preserve_perms;
55602791 127 extern int preserve_uid;
81c32ffd
WD
128 extern int preserve_gid;
129 extern int preserve_times;
81c32ffd 130+extern int preserve_atimes;
55602791 131 extern int omit_dir_times;
4a65fe72 132 extern int delete_mode;
81c32ffd 133 extern int delete_before;
4306c620 134@@ -552,6 +553,9 @@ void itemize(const char *fname, struct f
9a70b743 135 && (!(iflags & ITEM_XNAME_FOLLOWS) || *xname))
4306c620 136 || (keep_time && cmp_time(file->modtime, sxp->st.st_mtime) != 0))
f20eb450 137 iflags |= ITEM_REPORT_TIME;
55602791 138+ if (preserve_atimes && !S_ISDIR(file->mode) && !S_ISLNK(file->mode)
70891d26 139+ && cmp_time(F_ATIME(file), st->st_atime) != 0)
55602791 140+ iflags |= ITEM_REPORT_ATIME;
4306c620 141 if (!BITS_EQUAL(sxp->st.st_mode, file->mode, CHMOD_BITS))
f20eb450 142 iflags |= ITEM_REPORT_PERMS;
4306c620
WD
143 if (preserve_uid && am_root && F_UID(file) != sxp->st.st_uid)
144@@ -852,6 +856,8 @@ static int try_dests_reg(struct file_str
8aec0853
WD
145 if (link_dest) {
146 if (!hard_link_one(file, fname, cmpbuf, 1))
8a04c9a7
WD
147 goto try_a_copy;
148+ if (preserve_atimes)
4a65fe72 149+ set_file_attrs(fname, file, stp, 0);
1aa236e1 150 if (preserve_hard_links && F_IS_HLINKED(file))
4306c620 151 finish_hard_link(file, fname, &sxp->st, itemizing, code, j);
8aec0853 152 if (itemizing && (verbose > 1 || stdout_format_has_i > 1)) {
9a7eef96
WD
153--- old/log.c
154+++ new/log.c
4306c620 155@@ -36,6 +36,7 @@ extern int msg_fd_out;
577db5e2 156 extern int allow_8bit_chars;
81c32ffd
WD
157 extern int protocol_version;
158 extern int preserve_times;
159+extern int preserve_atimes;
70891d26
WD
160 extern int preserve_uid;
161 extern int preserve_gid;
1aa236e1 162 extern int stdout_format_has_i;
4306c620 163@@ -624,7 +625,8 @@ static void log_formatted(enum logcode c
fb11cdd7
WD
164 c[5] = !(iflags & ITEM_REPORT_PERMS) ? '.' : 'p';
165 c[6] = !(iflags & ITEM_REPORT_OWNER) ? '.' : 'o';
166 c[7] = !(iflags & ITEM_REPORT_GROUP) ? '.' : 'g';
4306c620 167- c[8] = !(iflags & ITEM_REPORT_ATIME) ? '.' : 'u';
fb11cdd7 168+ c[8] = !(iflags & ITEM_REPORT_ATIME) ? '.'
55602791 169+ : S_ISLNK(file->mode) ? 'U' : 'u';
4306c620
WD
170 c[9] = !(iflags & ITEM_REPORT_ACL) ? '.' : 'a';
171 c[10] = !(iflags & ITEM_REPORT_XATTR) ? '.' : 'x';
172 c[11] = '\0';
9a7eef96
WD
173--- old/options.c
174+++ new/options.c
b3593e7c 175@@ -55,6 +55,7 @@ int preserve_uid = 0;
43581f16
WD
176 int preserve_gid = 0;
177 int preserve_times = 0;
9a21ad72 178 int omit_dir_times = 0;
81c32ffd 179+int preserve_atimes = 0;
43581f16
WD
180 int update_only = 0;
181 int cvs_exclude = 0;
182 int dry_run = 0;
4306c620 183@@ -315,8 +316,9 @@ void usage(enum logcode F)
4a65fe72
WD
184 rprintf(F," --devices preserve device files (super-user only)\n");
185 rprintf(F," --specials preserve special files\n");
186 rprintf(F," -D same as --devices --specials\n");
81c32ffd
WD
187- rprintf(F," -t, --times preserve times\n");
188- rprintf(F," -O, --omit-dir-times omit directories when preserving times\n");
189+ rprintf(F," -t, --times preserve modify times\n");
190+ rprintf(F," -O, --omit-dir-times omit directories when preserving modify times\n");
55602791 191+ rprintf(F," -U, --atimes preserve access (use) times\n");
4a65fe72 192 rprintf(F," --super receiver attempts super-user activities\n");
43581f16
WD
193 rprintf(F," -S, --sparse handle sparse files efficiently\n");
194 rprintf(F," -n, --dry-run show what would have been transferred\n");
4306c620 195@@ -436,6 +438,9 @@ static struct poptOption long_options[]
489b0a72
WD
196 {"times", 't', POPT_ARG_VAL, &preserve_times, 1, 0, 0 },
197 {"no-times", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
198 {"no-t", 0, POPT_ARG_VAL, &preserve_times, 0, 0, 0 },
55602791 199+ {"atimes", 'U', POPT_ARG_VAL, &preserve_atimes, 1, 0, 0 },
489b0a72 200+ {"no-atimes", 0, POPT_ARG_VAL, &preserve_atimes, 0, 0, 0 },
70891d26 201+ {"no-U", 0, POPT_ARG_VAL, &preserve_atimes, 0, 0, 0 },
52f25864 202 {"omit-dir-times", 'O', POPT_ARG_VAL, &omit_dir_times, 2, 0, 0 },
489b0a72 203 {"modify-window", 0, POPT_ARG_INT, &modify_window, OPT_MODIFY_WINDOW, 0, 0 },
4a65fe72 204 {"super", 0, POPT_ARG_VAL, &am_root, 2, 0, 0 },
4306c620 205@@ -1577,6 +1582,8 @@ void server_options(char **args,int *arg
43581f16
WD
206 argstr[x++] = 'D';
207 if (preserve_times)
208 argstr[x++] = 't';
81c32ffd 209+ if (preserve_atimes)
55602791 210+ argstr[x++] = 'U';
43581f16 211 if (preserve_perms)
4a65fe72
WD
212 argstr[x++] = 'p';
213 else if (preserve_executability && am_sender)
9a7eef96
WD
214--- old/rsync.c
215+++ new/rsync.c
4306c620
WD
216@@ -34,6 +34,7 @@ extern int dry_run;
217 extern int preserve_acls;
d9a67109 218 extern int preserve_perms;
4a65fe72 219 extern int preserve_executability;
d9a67109 220+extern int preserve_atimes;
43581f16 221 extern int preserve_times;
9a21ad72 222 extern int omit_dir_times;
43581f16 223 extern int am_root;
4306c620 224@@ -234,6 +235,7 @@ int set_file_attrs(char *fname, struct f
9a21ad72 225 int updated = 0;
4306c620 226 statx sx2;
9a21ad72
WD
227 int change_uid, change_gid;
228+ time_t atime, mtime;
1ed0b5c9 229 mode_t new_mode = file->mode;
9a21ad72 230
4306c620
WD
231 if (!sxp) {
232@@ -261,18 +263,36 @@ int set_file_attrs(char *fname, struct f
233 get_acl(fname, sxp);
234 #endif
9a21ad72 235
8a04c9a7
WD
236+ /* This code must be the first update in the function due to
237+ * how it uses the "updated" variable. */
4306c620 238 if (!preserve_times || (S_ISDIR(sxp->st.st_mode) && omit_dir_times))
4a65fe72 239 flags |= ATTRS_SKIP_MTIME;
4306c620 240+ if (!preserve_atimes || S_ISDIR(sxp->st.st_mode))
4a65fe72
WD
241+ flags |= ATTRS_SKIP_ATIME;
242 if (!(flags & ATTRS_SKIP_MTIME)
4306c620
WD
243 && cmp_time(sxp->st.st_mtime, file->modtime) != 0) {
244- int ret = set_modtime(fname, file->modtime, sxp->st.st_mode);
9a21ad72 245+ mtime = file->modtime;
9e355bf1 246+ updated = 1;
9a21ad72 247+ } else
4306c620 248+ mtime = sxp->st.st_mtime;
672ad041 249+ if (!(flags & ATTRS_SKIP_ATIME)) {
70891d26 250+ time_t file_atime = F_ATIME(file);
4306c620 251+ if (cmp_time(sxp->st.st_atime, file_atime) != 0) {
672ad041
WD
252+ atime = file_atime;
253+ updated = 1;
254+ } else
4306c620 255+ atime = sxp->st.st_atime;
81c32ffd 256+ } else
4306c620 257+ atime = sxp->st.st_atime;
9e355bf1 258+ if (updated) {
4306c620 259+ int ret = set_times(fname, mtime, atime, sxp->st.st_mode);
9e355bf1
WD
260 if (ret < 0) {
261 rsyserr(FERROR, errno, "failed to set times on %s",
262 full_fname(fname));
4306c620 263 goto cleanup;
9e355bf1
WD
264 }
265- if (ret == 0) /* ret == 1 if symlink could not be set */
266- updated = 1;
267+ if (ret > 0) /* ret == 1 if symlink could not be set */
268+ updated = 0;
43581f16
WD
269 }
270
4306c620 271 change_uid = am_root && preserve_uid && sxp->st.st_uid != F_UID(file);
9a7eef96
WD
272--- old/rsync.h
273+++ new/rsync.h
4306c620 274@@ -56,6 +56,7 @@
43581f16 275 #define XMIT_RDEV_MINOR_IS_SMALL (1<<11)
fc068916
WD
276 #define XMIT_USER_NAME_FOLLOWS (1<<12) /* protocols >= 30 */
277 #define XMIT_GROUP_NAME_FOLLOWS (1<<13) /* protocols >= 30 */
278+#define XMIT_SAME_ATIME (1<<14) /* protocols >= 30 */
43581f16
WD
279
280 /* These flags are used in the live flist data. */
281
4306c620 282@@ -136,6 +137,7 @@
8a529471 283
4a65fe72
WD
284 #define ATTRS_REPORT (1<<0)
285 #define ATTRS_SKIP_MTIME (1<<1)
286+#define ATTRS_SKIP_ATIME (1<<2)
8a529471
WD
287
288 #define FULL_FLUSH 1
289 #define NORMAL_FLUSH 0
4306c620 290@@ -571,6 +573,7 @@ extern int file_extra_cnt;
fdf967c7
WD
291 extern int preserve_uid;
292 extern int preserve_gid;
4306c620 293 extern int preserve_acls;
fdf967c7
WD
294+extern int preserve_atimes;
295
296 #define FILE_STRUCT_LEN (offsetof(struct file_struct, basename))
297 #define EXTRA_LEN (sizeof (union file_extras))
4306c620 298@@ -603,6 +606,7 @@ extern int preserve_acls;
1aa236e1 299 /* When the associated option is on, all entries will have these present: */
fc068916
WD
300 #define F_OWNER(f) REQ_EXTRA(f, preserve_uid)->unum
301 #define F_GROUP(f) REQ_EXTRA(f, preserve_gid)->unum
fdf967c7 302+#define F_ATIME(f) REQ_EXTRA(f, preserve_atimes)->unum
4306c620 303 #define F_ACL(f) REQ_EXTRA(f, preserve_acls)->unum
70891d26 304
1071853f 305 /* These items are per-entry optional and mutally exclusive: */
9a7eef96
WD
306--- old/rsync.yo
307+++ new/rsync.yo
4306c620 308@@ -329,8 +329,9 @@ to the detailed description below for a
4a65fe72
WD
309 --devices preserve device files (super-user only)
310 --specials preserve special files
311 -D same as --devices --specials
81c32ffd 312- -t, --times preserve times
610969d1 313- -O, --omit-dir-times omit directories when preserving times
81c32ffd 314+ -t, --times preserve modify times
610969d1 315+ -O, --omit-dir-times omit directories when preserving mod-times
55602791 316+ -U, --atimes preserve access (use) times
4a65fe72 317 --super receiver attempts super-user activities
43581f16
WD
318 -S, --sparse handle sparse files efficiently
319 -n, --dry-run show what would have been transferred
4306c620 320@@ -896,6 +897,12 @@ it is preserving modification times (see
a7219d20 321 the directories on the receiving side, it is a good idea to use bf(-O).
333b8af4 322 This option is inferred if you use bf(--backup) without bf(--backup-dir).
7b675ff5 323
55602791
WD
324+dit(bf(-U, --atimes)) This tells rsync to set the access (use) times of the
325+destination files to the same value as the source files. Note that the
81c32ffd
WD
326+reading of the source file may update the atime of the source files, so
327+repeated rsync runs with --atimes may be needed if you want to force the
328+access-time values to be 100% identical on the two systems.
7b675ff5 329+
4a65fe72
WD
330 dit(bf(--super)) This tells the receiving side to attempt super-user
331 activities even if the receiving rsync wasn't run by the super-user. These
332 activities include: preserving users via the bf(--owner) option, preserving
4306c620 333@@ -1482,7 +1489,7 @@ quote(itemization(
81c32ffd
WD
334 by the file transfer.
335 it() A bf(t) means the modification time is different and is being updated
336 to the sender's value (requires bf(--times)). An alternate value of bf(T)
337- means that the time will be set to the transfer time, which happens
338+ means that the modify time will be set to the transfer time, which happens
339 anytime a symlink is transferred, or when a file or device is transferred
340 without bf(--times).
ccc3a12c 341 it() A bf(p) means the permissions are different and are being updated to
4306c620 342@@ -1491,8 +1498,10 @@ quote(itemization(
ccc3a12c
WD
343 sender's value (requires bf(--owner) and super-user privileges).
344 it() A bf(g) means the group is different and is being updated to the
345 sender's value (requires bf(--group) and the authority to set the group).
4306c620
WD
346- it() The bf(u) slot is reserved for reporting update (access) time changes
347- (a feature that is not yet released).
55602791
WD
348+ it() A bf(u) means the access (use) time is different and is being updated to
349+ the sender's value (requires bf(--atimes)). An alternate value of bf(U)
350+ means that the access time will be set to the transfer time, which happens
ccc3a12c 351+ when a symlink or directory is updated.
4306c620
WD
352 it() The bf(a) means that the ACL information changed.
353 it() The bf(x) slot is reserved for reporting extended attribute changes
354 (a feature that is not yet released).
9a7eef96
WD
355--- old/sender.c
356+++ new/sender.c
4306c620 357@@ -41,6 +41,7 @@ extern int do_progress;
1cb60481
WD
358 extern int inplace;
359 extern int batch_fd;
360 extern int write_batch;
361+extern unsigned int file_struct_len;
362 extern struct stats stats;
fc068916 363 extern struct file_list *cur_flist, *first_flist;
4306c620 364
9a7eef96
WD
365--- old/testsuite/atimes.test
366+++ new/testsuite/atimes.test
13bed3dd
WD
367@@ -0,0 +1,19 @@
368+#! /bin/sh
369+
370+# Test rsync copying atimes
371+
372+. "$suitedir/rsync.fns"
373+
374+set -x
375+
376+mkdir "$fromdir"
377+
378+touch "$fromdir/foo"
379+touch -a -t 200102031717.42 "$fromdir/foo"
380+
381+TLS_ARGS=--atime
382+
55602791 383+checkit "$RSYNC -rtUgvvv \"$fromdir/\" \"$todir/\"" "$fromdir" "$todir"
13bed3dd
WD
384+
385+# The script would have aborted on error, so getting here means we've won.
386+exit 0
9a7eef96
WD
387--- old/testsuite/rsync.fns
388+++ new/testsuite/rsync.fns
7a56a8f1
WD
389@@ -66,7 +66,7 @@ printmsg() {
390 }
13bed3dd
WD
391
392 rsync_ls_lR() {
b78a6aba
WD
393- find "$@" -print | sort | sed 's/ /\\ /g' | xargs "$TOOLDIR/tls"
394+ find "$@" -print | sort | sed 's/ /\\ /g' | xargs "$TOOLDIR/tls" $TLS_ARGS
13bed3dd
WD
395 }
396
7a56a8f1
WD
397 check_perms() {
398@@ -184,6 +184,10 @@ checkit() {
13bed3dd
WD
399 # We can just write everything to stdout/stderr, because the
400 # wrapper hides it unless there is a problem.
401
81c32ffd
WD
402+ if test x$TLS_ARGS = x--atime; then
403+ ( cd "$2" && rsync_ls_lR . ) > "$tmpdir/ls-from"
404+ fi
13bed3dd
WD
405+
406 echo "Running: \"$1\""
407 eval "$1"
408 status=$?
7a56a8f1 409@@ -191,10 +195,13 @@ checkit() {
81c32ffd
WD
410 failed="YES";
411 fi
412
413+ if test x$TLS_ARGS != x--atime; then
414+ ( cd "$2" && rsync_ls_lR . ) > "$tmpdir/ls-from"
415+ fi
416+
13bed3dd 417 echo "-------------"
b78a6aba
WD
418 echo "check how the directory listings compare with diff:"
419 echo ""
13bed3dd 420- ( cd "$2" && rsync_ls_lR . ) > "$tmpdir/ls-from"
b78a6aba
WD
421 ( cd "$3" && rsync_ls_lR . ) > "$tmpdir/ls-to"
422 diff $diffopt "$tmpdir/ls-from" "$tmpdir/ls-to" || failed=YES
4da25dad 423
9a7eef96
WD
424--- old/tls.c
425+++ new/tls.c
b3593e7c
WD
426@@ -34,6 +34,7 @@
427 * change. */
43581f16
WD
428
429 #include "rsync.h"
430+#include "popt.h"
431
432 #define PROGRAM "tls"
433
b3593e7c 434@@ -43,6 +44,8 @@ int read_only = 1;
43581f16
WD
435 int list_only = 0;
436 int preserve_perms = 0;
437
438+static int display_atime = 0;
b3593e7c 439+
fe6407b5
WD
440 static void failed(char const *what, char const *where)
441 {
b3593e7c
WD
442 fprintf(stderr, PROGRAM ": %s %s: %s\n",
443@@ -50,12 +53,29 @@ static void failed(char const *what, cha
fe6407b5 444 exit(1);
43581f16
WD
445 }
446
3f053c45 447+static void storetime(char *dest, time_t t, size_t destsize)
43581f16
WD
448+{
449+ if (t) {
450+ struct tm *mt = gmtime(&t);
b3593e7c 451+
3f053c45
WD
452+ snprintf(dest, destsize,
453+ "%04d-%02d-%02d %02d:%02d:%02d ",
9d95bd65
WD
454+ (int)mt->tm_year + 1900,
455+ (int)mt->tm_mon + 1,
456+ (int)mt->tm_mday,
457+ (int)mt->tm_hour,
458+ (int)mt->tm_min,
459+ (int)mt->tm_sec);
3f053c45
WD
460+ } else
461+ strlcpy(dest, " ", destsize);
b3593e7c
WD
462+}
463+
fe6407b5 464 static void list_file(const char *fname)
43581f16
WD
465 {
466 STRUCT_STAT buf;
467 char permbuf[PERMSTRING_SIZE];
468- struct tm *mt;
469- char datebuf[50];
470+ char mtimebuf[50];
471+ char atimebuf[50];
472 char linkbuf[4096];
473
ba50e96c 474 if (do_lstat(fname, &buf) < 0)
b3593e7c 475@@ -88,19 +108,8 @@ static void list_file(const char *fname)
43581f16
WD
476
477 permstring(permbuf, buf.st_mode);
478
479- if (buf.st_mtime) {
480- mt = gmtime(&buf.st_mtime);
481-
3f053c45
WD
482- snprintf(datebuf, sizeof datebuf,
483- "%04d-%02d-%02d %02d:%02d:%02d",
9d95bd65
WD
484- (int)mt->tm_year + 1900,
485- (int)mt->tm_mon + 1,
486- (int)mt->tm_mday,
487- (int)mt->tm_hour,
488- (int)mt->tm_min,
489- (int)mt->tm_sec);
3f053c45
WD
490- } else
491- strlcpy(datebuf, " ", sizeof datebuf);
492+ storetime(mtimebuf, buf.st_mtime, sizeof mtimebuf);
493+ storetime(atimebuf, buf.st_atime, sizeof atimebuf);
43581f16
WD
494
495 /* TODO: Perhaps escape special characters in fname? */
496
b3593e7c 497@@ -111,23 +120,55 @@ static void list_file(const char *fname)
43581f16
WD
498 (long)minor(buf.st_rdev));
499 } else /* NB: use double for size since it might not fit in a long. */
500 printf("%12.0f", (double)buf.st_size);
501- printf(" %6ld.%-6ld %6ld %s %s%s\n",
502+ printf(" %6ld.%-6ld %6ld %s%s%s%s\n",
503 (long)buf.st_uid, (long)buf.st_gid, (long)buf.st_nlink,
504- datebuf, fname, linkbuf);
c0be1af2 505+ mtimebuf, display_atime && !S_ISDIR(buf.st_mode) ? atimebuf : "",
43581f16 506+ fname, linkbuf);
b3593e7c
WD
507+}
508+
43581f16
WD
509+static struct poptOption long_options[] = {
510+ /* longName, shortName, argInfo, argPtr, value, descrip, argDesc */
511+ {"atime", 'u', POPT_ARG_NONE, &display_atime, 0, 0, 0},
512+ {"help", 'h', POPT_ARG_NONE, 0, 'h', 0, 0},
513+ {0,0,0,0,0,0,0}
514+};
515+
516+static void tls_usage(int ret)
517+{
041d67b8 518+ fprintf(stderr, "usage: " PROGRAM " [--atime | -u] FILE ...\n"
43581f16
WD
519+ "Trivial file listing program for portably checking rsync\n");
520+ exit(ret);
b3593e7c 521 }
43581f16
WD
522
523 int
524 main(int argc, char *argv[])
525 {
526- if (argc < 2) {
041d67b8 527- fprintf(stderr, "usage: " PROGRAM " FILE ...\n"
fe6407b5 528- "Trivial file listing program for portably checking rsync\n");
43581f16 529- return 1;
03019e41 530- }
43581f16
WD
531+ poptContext pc;
532+ const char **extra_args;
533+ int opt;
03019e41
WD
534
535- for (argv++; *argv; argv++) {
536- list_file(*argv);
43581f16
WD
537+ pc = poptGetContext(PROGRAM, argc, (const char **)argv,
538+ long_options, 0);
539+ while ((opt = poptGetNextOpt(pc)) != -1) {
540+ switch (opt) {
541+ case 'h':
542+ tls_usage(0);
543+ default:
544+ fprintf(stderr,
545+ "%s: %s\n",
546+ poptBadOption(pc, POPT_BADOPTION_NOALIAS),
547+ poptStrerror(opt));
548+ tls_usage(1);
549+ }
550 }
551
43581f16
WD
552+ extra_args = poptGetArgs(pc);
553+ if (*extra_args == NULL)
554+ tls_usage(1);
555+
556+ for (; *extra_args; extra_args++)
557+ list_file(*extra_args);
558+ poptFreeContext(pc);
03019e41 559+
43581f16
WD
560 return 0;
561 }
9a7eef96
WD
562--- old/util.c
563+++ new/util.c
4306c620 564@@ -120,7 +120,7 @@ NORETURN void overflow_exit(const char *
577db5e2
WD
565 exit_cleanup(RERR_MALLOC);
566 }
43581f16 567
fb11cdd7
WD
568-int set_modtime(const char *fname, time_t modtime, mode_t mode)
569+int set_times(const char *fname, time_t modtime, time_t atime, mode_t mode)
43581f16 570 {
9e355bf1
WD
571 #if !defined HAVE_LUTIMES || !defined HAVE_UTIMES
572 if (S_ISLNK(mode))
4306c620 573@@ -128,9 +128,13 @@ int set_modtime(const char *fname, time_
9e355bf1
WD
574 #endif
575
43581f16
WD
576 if (verbose > 2) {
577- rprintf(FINFO, "set modtime of %s to (%ld) %s",
578+ char mtimebuf[200];
43581f16 579+
125d7fca 580+ strlcpy(mtimebuf, timestring(modtime), sizeof mtimebuf);
43581f16
WD
581+ rprintf(FINFO,
582+ "set modtime, atime of %s to (%ld) %s, (%ld) %s\n",
93ca4d27 583 fname, (long)modtime,
43581f16 584- asctime(localtime(&modtime)));
9e355bf1 585+ mtimebuf, (long)atime, timestring(atime));
43581f16
WD
586 }
587
ba50e96c 588 if (dry_run)
4306c620 589@@ -139,7 +143,7 @@ int set_modtime(const char *fname, time_
43581f16 590 {
9e355bf1
WD
591 #ifdef HAVE_UTIMES
592 struct timeval t[2];
593- t[0].tv_sec = time(NULL);
594+ t[0].tv_sec = atime;
595 t[0].tv_usec = 0;
596 t[1].tv_sec = modtime;
597 t[1].tv_usec = 0;
4306c620 598@@ -152,12 +156,12 @@ int set_modtime(const char *fname, time_
9e355bf1
WD
599 return utimes(fname, t);
600 #elif defined HAVE_UTIMBUF
43581f16
WD
601 struct utimbuf tbuf;
602- tbuf.actime = time(NULL);
603+ tbuf.actime = atime;
604 tbuf.modtime = modtime;
605 return utime(fname,&tbuf);
09fb8f03 606 #elif defined HAVE_UTIME
43581f16
WD
607 time_t t[2];
608- t[0] = time(NULL);
609+ t[0] = atime;
610 t[1] = modtime;
611 return utime(fname,t);
612 #else