From f8e1fa627219873be6d37244dc70fbfd157f1e9c Mon Sep 17 00:00:00 2001 From: Wayne Davison Date: Sun, 13 Dec 2009 19:28:01 -0800 Subject: [PATCH] Free a strdup() in do_cmd() that checker was complaining about. --- main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/main.c b/main.c index ebfadd24..dec59f46 100644 --- a/main.c +++ b/main.c @@ -395,7 +395,7 @@ static pid_t do_cmd(char *cmd, char *machine, char *user, char **remote_argv, in int *f_in_p, int *f_out_p) { int i, argc = 0; - char *args[MAX_ARGS]; + char *args[MAX_ARGS], *need_to_free = NULL; pid_t pid; int dash_l_set = 0; @@ -406,7 +406,7 @@ static pid_t do_cmd(char *cmd, char *machine, char *user, char **remote_argv, in cmd = rsh_env; if (!cmd) cmd = RSYNC_RSH; - cmd = strdup(cmd); /*MEMORY LEAK*/ + cmd = need_to_free = strdup(cmd); if (!cmd) goto oom; @@ -538,6 +538,9 @@ static pid_t do_cmd(char *cmd, char *machine, char *user, char **remote_argv, in send_protected_args(*f_out_p, args); } + if (need_to_free) + free(need_to_free); + return pid; oom: -- 2.34.1