From d532c0f56959058cc14dfa643d3abf8eec2b6e04 Mon Sep 17 00:00:00 2001 From: David Dykstra Date: Thu, 5 Nov 1998 14:33:38 +0000 Subject: [PATCH] Add comment before call to mktemp saying it is deliberately chosen over mkstemp. --- receiver.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/receiver.c b/receiver.c index 189aa417..ac9c6695 100644 --- a/receiver.c +++ b/receiver.c @@ -387,6 +387,10 @@ int recv_files(int f_in,struct file_list *flist,char *local_name,int f_gen) continue; } + /* mktemp is deliberately used here instead of mkstemp. + because O_EXCL is used on the open, the race condition + is not a problem or a security hole, and we want to + control the access permissions on the created file. */ if (NULL == do_mktemp(fnametmp)) { rprintf(FERROR,"mktemp %s failed\n",fnametmp); receive_data(f_in,buf,-1,NULL,file->length); -- 2.34.1