From ca20c7fd625c27f540b0ae5be027cb51700c80e3 Mon Sep 17 00:00:00 2001 From: Wayne Davison Date: Mon, 4 Aug 2003 18:27:27 +0000 Subject: [PATCH] Instead of ignoring SIG_CHLD, reap zombies in the signal handler. --- socket.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/socket.c b/socket.c index eb0660bb..cb15441f 100644 --- a/socket.c +++ b/socket.c @@ -374,6 +374,14 @@ int is_a_socket(int fd) } +static RETSIGTYPE sigchld_handler(int UNUSED(val)) { + signal(SIGCHLD, sigchld_handler); +#ifdef WNOHANG + while (waitpid(-1, NULL, WNOHANG) > 0) {} +#endif +} + + void start_accept_loop(int port, int (*fn)(int, int)) { int s; @@ -419,14 +427,7 @@ void start_accept_loop(int port, int (*fn)(int, int)) if (fd == -1) continue; - signal(SIGCHLD, SIG_IGN); - - /* we shouldn't have any children left hanging around - but I have had reports that on Digital Unix zombies - are produced, so this ensures that they are reaped */ -#ifdef WNOHANG - while (waitpid(-1, NULL, WNOHANG) > 0); -#endif + signal(SIGCHLD, sigchld_handler); if ((pid = fork()) == 0) { int ret; -- 2.34.1