From 3ef526f5fa28b6a77ef55d3bf37ec37789dde8ae Mon Sep 17 00:00:00 2001 From: Martin Pool Date: Fri, 31 Aug 2001 08:08:42 +0000 Subject: [PATCH] Add comment about handling of 'use chroot' --- clientserver.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/clientserver.c b/clientserver.c index 7dd72e9b..0f543610 100644 --- a/clientserver.c +++ b/clientserver.c @@ -244,6 +244,10 @@ static int rsync_module(int fd, int i) log_init(); if (use_chroot) { + /* TODO: If we're not running as root, then we'll get + * an error here. I wonder if we should perhaps just + * log a warning here, and continue anyhow using the + * push_dir feature? -- mbp 2001-08-31 */ if (chroot(lp_path(i))) { rsyserr(FERROR, errno, "chroot %s failed", lp_path(i)); io_printf(fd,"@ERROR: chroot failed\n"); -- 2.34.1