From 384958ed3dcd18e8ec7cf2e5a6142812f14229d8 Mon Sep 17 00:00:00 2001 From: Martin Pool Date: Sun, 2 Dec 2001 22:47:30 +0000 Subject: [PATCH] Note about crash from Ayamura KIKUCHI --- batch.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/batch.c b/batch.c index e45d3642..0a8b1cf6 100644 --- a/batch.c +++ b/batch.c @@ -150,6 +150,10 @@ void write_batch_argvs_file(int orig_argc, int argc, char **argv) /* Write argvs info to batch file */ for (i = argc - orig_argc; i < argc; i++) { + /* FIXME: This apparently crashes if rsync is run with + * just "rsync -F". I think directly manipulating + * argv[] is probably bogus -- what if -F is part of a + * run of several short options? */ if (!strcmp(argv[i], "-F")) { /* safer to change it here than script */ strncat(buff, "-f ", 3); /* chg to -f + ext to get ready for remote */ strncat(buff, batch_file_ext, -- 2.34.1