From 21897ecbedeec3fbcaf2cbed895df6d11d811ba9 Mon Sep 17 00:00:00 2001 From: Wayne Davison Date: Sat, 9 Feb 2008 21:41:50 -0800 Subject: [PATCH] Improved the "symlink has no referent" logic to work with all the --copy*links options. --- flist.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/flist.c b/flist.c index 3616a8e2..a0970216 100644 --- a/flist.c +++ b/flist.c @@ -1037,9 +1037,15 @@ struct file_struct *make_file(const char *fname, struct file_list *flist, } if (save_errno == ENOENT) { #ifdef SUPPORT_LINKS - /* Avoid "vanished" error if symlink points nowhere. */ - if (copy_links && x_lstat(thisname, &st, NULL) == 0 - && S_ISLNK(st.st_mode)) { + /* When our options tell us to follow a symlink that + * points nowhere, tell the user about the symlink + * instead of giving a "vanished" message. We only + * dereference a symlink if one of the --copy*links + * options was specified, so there's no need for the + * extra lstat() if one of these options isn't on. */ + if ((copy_links || copy_unsafe_links || copy_dirlinks) + && x_lstat(thisname, &st, NULL) == 0 + && S_ISLNK(st.st_mode)) { io_error |= IOERR_GENERAL; rprintf(FERROR_XFER, "symlink has no referent: %s\n", full_fname(thisname)); -- 2.34.1