rsync/rsync.git
19 years agoMy modified version of Chris Shoemaker's improved batch-file handling.
Wayne Davison [Thu, 15 Jul 2004 02:20:08 +0000 (02:20 +0000)]
My modified version of Chris Shoemaker's improved batch-file handling.

19 years agoMention recent changes.
Wayne Davison [Wed, 14 Jul 2004 17:11:53 +0000 (17:11 +0000)]
Mention recent changes.

19 years agoTweaked some single-line ifs.
Wayne Davison [Wed, 14 Jul 2004 16:41:10 +0000 (16:41 +0000)]
Tweaked some single-line ifs.

19 years agoThe "len" to generate_and_send_sums() is supposed to be an OFF_T.
Wayne Davison [Wed, 14 Jul 2004 16:40:08 +0000 (16:40 +0000)]
The "len" to generate_and_send_sums() is supposed to be an OFF_T.

19 years agoCommitted a space-tweak from Chris Shoemaker.
Wayne Davison [Wed, 14 Jul 2004 16:39:08 +0000 (16:39 +0000)]
Committed a space-tweak from Chris Shoemaker.

19 years agoImproved the write_batch_argvs_file() routine so that it doesn't
Wayne Davison [Wed, 14 Jul 2004 07:20:18 +0000 (07:20 +0000)]
Improved the write_batch_argvs_file() routine so that it doesn't
need the character buffers and so that it properly removes the
hostname from the destination arg.

19 years agoGot rid of the disable_deltas_p() function (the whole_file value
Wayne Davison [Tue, 13 Jul 2004 01:45:51 +0000 (01:45 +0000)]
Got rid of the disable_deltas_p() function (the whole_file value
is now fully set before the generator forks).

19 years agoWe now conditionally turn on whole_file in do_cmd() right before
Wayne Davison [Tue, 13 Jul 2004 01:44:03 +0000 (01:44 +0000)]
We now conditionally turn on whole_file in do_cmd() right before
calling local_child().

19 years agoIn generate_files(), changed arg "f" to "f_out", as Chris Shoemaker
Wayne Davison [Mon, 12 Jul 2004 20:42:48 +0000 (20:42 +0000)]
In generate_files(), changed arg "f" to "f_out", as Chris Shoemaker
suggested.

19 years agoMade hard_link_check() compile when SUPPORT_HARD_LINKS isn't enabled.
Wayne Davison [Mon, 12 Jul 2004 07:03:28 +0000 (07:03 +0000)]
Made hard_link_check() compile when SUPPORT_HARD_LINKS isn't enabled.

19 years agoUse want_i instead of last_i+1.
Wayne Davison [Wed, 7 Jul 2004 08:38:40 +0000 (08:38 +0000)]
Use want_i instead of last_i+1.

19 years agoMake the GID_NONE define a little safer.
Wayne Davison [Wed, 7 Jul 2004 08:25:13 +0000 (08:25 +0000)]
Make the GID_NONE define a little safer.

19 years agoAdded some missing $(srcdir) references.
Wayne Davison [Sun, 4 Jul 2004 08:56:31 +0000 (08:56 +0000)]
Added some missing $(srcdir) references.

19 years agoChanged a "for" loop into a "do ... while" loop.
Wayne Davison [Sun, 4 Jul 2004 08:07:23 +0000 (08:07 +0000)]
Changed a "for" loop into a "do ... while" loop.

19 years agoOptimized away a loop in hash_search().
Wayne Davison [Fri, 2 Jul 2004 23:35:30 +0000 (23:35 +0000)]
Optimized away a loop in hash_search().

19 years agoSome formatting tweaks.
Wayne Davison [Fri, 2 Jul 2004 18:23:57 +0000 (18:23 +0000)]
Some formatting tweaks.

19 years agoMoved the verbose message about renaming the finished file down into
Wayne Davison [Fri, 2 Jul 2004 18:13:53 +0000 (18:13 +0000)]
Moved the verbose message about renaming the finished file down into
finish_transfer() so that it only gets output when we're actually going
to rename the file.

19 years agoTweaked some formatting.
Wayne Davison [Fri, 2 Jul 2004 18:12:24 +0000 (18:12 +0000)]
Tweaked some formatting.

19 years agoSome simple whitespace tweaks.
Wayne Davison [Wed, 30 Jun 2004 07:27:30 +0000 (07:27 +0000)]
Some simple whitespace tweaks.

19 years agoMade recv_generator static.
Wayne Davison [Tue, 29 Jun 2004 19:19:00 +0000 (19:19 +0000)]
Made recv_generator static.

19 years agoOptimized away a call to cmp_modtime() for a compare-dest file.
Wayne Davison [Tue, 29 Jun 2004 16:22:54 +0000 (16:22 +0000)]
Optimized away a call to cmp_modtime() for a compare-dest file.

19 years agoMention the extended argv-overflow checking.
Wayne Davison [Tue, 29 Jun 2004 15:13:18 +0000 (15:13 +0000)]
Mention the extended argv-overflow checking.

19 years agoTweaked an overly-long line.
Wayne Davison [Tue, 29 Jun 2004 15:12:01 +0000 (15:12 +0000)]
Tweaked an overly-long line.

19 years agoA few more improvements to the anti-overflow args[] checking.
Wayne Davison [Mon, 28 Jun 2004 17:45:40 +0000 (17:45 +0000)]
A few more improvements to the anti-overflow args[] checking.

19 years agoMake sure that do_cmd() doesn't overflow its arg-pointer array
Wayne Davison [Mon, 28 Jun 2004 17:25:14 +0000 (17:25 +0000)]
Make sure that do_cmd() doesn't overflow its arg-pointer array
(which was also made larger).

19 years agoGot rid of a couple unneeded assignments.
Wayne Davison [Thu, 24 Jun 2004 04:46:02 +0000 (04:46 +0000)]
Got rid of a couple unneeded assignments.

19 years agoRestoring correct skip_file() return semantics.
Wayne Davison [Wed, 23 Jun 2004 21:21:19 +0000 (21:21 +0000)]
Restoring correct skip_file() return semantics.

19 years agoThought skip_file() wasn't returning 1 for "skip" and 0 or "keep"
Wayne Davison [Wed, 23 Jun 2004 16:51:21 +0000 (16:51 +0000)]
Thought skip_file() wasn't returning 1 for "skip" and 0 or "keep"
so I reversed the return.

19 years agoFixed a newly-introduced problem in read_timeout() where FD_ZERO(&w_fds)
Wayne Davison [Wed, 23 Jun 2004 01:13:09 +0000 (01:13 +0000)]
Fixed a newly-introduced problem in read_timeout() where FD_ZERO(&w_fds)
wasn't always called before w_fds was used.

19 years agoSome trivial format tweaks.
Wayne Davison [Sun, 20 Jun 2004 21:48:06 +0000 (21:48 +0000)]
Some trivial format tweaks.

19 years agoMentioned the latest socket change and fixed a few typos.
Wayne Davison [Sun, 20 Jun 2004 20:37:06 +0000 (20:37 +0000)]
Mentioned the latest socket change and fixed a few typos.

19 years agoRestored the code in the IPV6_V6ONLY section that checks the
Wayne Davison [Sun, 20 Jun 2004 19:51:19 +0000 (19:51 +0000)]
Restored the code in the IPV6_V6ONLY section that checks the
return value from setsockopt() with one improvement:  if the
user has used --ipv6 (-6) we don't discard the IPv6 socket.
This should help people using older Linux kernels that don't
implement IPv6 support quite right.

19 years agoTweaked a comment.
Wayne Davison [Sun, 20 Jun 2004 19:47:05 +0000 (19:47 +0000)]
Tweaked a comment.

19 years agoMust not call check_timeout() before checking the errno value.
Wayne Davison [Sat, 19 Jun 2004 07:09:57 +0000 (07:09 +0000)]
Must not call check_timeout() before checking the errno value.

19 years agoAdded some missing changes.
Wayne Davison [Sat, 19 Jun 2004 06:55:58 +0000 (06:55 +0000)]
Added some missing changes.

19 years agoSome minor improved sentences.
Wayne Davison [Sat, 19 Jun 2004 05:52:45 +0000 (05:52 +0000)]
Some minor improved sentences.

19 years agoTweaked some comments.
Wayne Davison [Fri, 18 Jun 2004 16:55:12 +0000 (16:55 +0000)]
Tweaked some comments.

19 years agoSome helpful comments from Chris Shoemaker.
Wayne Davison [Fri, 18 Jun 2004 16:50:20 +0000 (16:50 +0000)]
Some helpful comments from Chris Shoemaker.

19 years agoFixed some typos in a comment, moved an extern, and made a few
Wayne Davison [Fri, 18 Jun 2004 16:30:24 +0000 (16:30 +0000)]
Fixed some typos in a comment, moved an extern, and made a few
minor format tweaks.

19 years agoImproved a comment.
Wayne Davison [Fri, 18 Jun 2004 16:29:21 +0000 (16:29 +0000)]
Improved a comment.

19 years agoMoved the externs to the top and made a few trivial format tweaks.
Wayne Davison [Fri, 18 Jun 2004 16:22:14 +0000 (16:22 +0000)]
Moved the externs to the top and made a few trivial format tweaks.

19 years agoGot rid of some trailing whitespace.
Wayne Davison [Fri, 18 Jun 2004 16:00:33 +0000 (16:00 +0000)]
Got rid of some trailing whitespace.

19 years agoIf --partial was specified, make sure that make_backup is turned
Wayne Davison [Mon, 14 Jun 2004 15:09:36 +0000 (15:09 +0000)]
If --partial was specified, make sure that make_backup is turned
off during the second (retry) phase of the transfer to avoid
making a second backup of a file (which would lose the original).

19 years agoAdded a short msleep() after option_error() before we exit. This
Wayne Davison [Sun, 13 Jun 2004 14:18:48 +0000 (14:18 +0000)]
Added a short msleep() after option_error() before we exit.  This
ensures that the remote client has time to read our error message
while it is trying to write data to us before it gets a socket
error.

19 years agoChanged the new code in delete_one() so that some compilers
Wayne Davison [Sat, 12 Jun 2004 21:30:07 +0000 (21:30 +0000)]
Changed the new code in delete_one() so that some compilers
don't complain about returning a value from a void function.

19 years agoMention the bugfix in option-parsing error-reporting from a daemon.
Wayne Davison [Sat, 12 Jun 2004 18:27:04 +0000 (18:27 +0000)]
Mention the bugfix in option-parsing error-reporting from a daemon.

19 years ago- Changed some FERROR log calls to FLOG.
Wayne Davison [Sat, 12 Jun 2004 18:22:39 +0000 (18:22 +0000)]
- Changed some FERROR log calls to FLOG.
- Improved the option-error-reporting to actually get the error back
  to the user (by getting I/O multiplexing started).

19 years ago- Made readlink_stat() and link_stat() optionally follow a symlink
Wayne Davison [Fri, 11 Jun 2004 07:40:57 +0000 (07:40 +0000)]
- Made readlink_stat() and link_stat() optionally follow a symlink
  to a dir.  This fixes deletions inside "kept" symlinked dirs.
- Call link_stat() with its new arg (for --keep-dirlinks support).

19 years agoMake sure that keep_dirlinks is turned off for the sender.
Wayne Davison [Fri, 11 Jun 2004 07:40:54 +0000 (07:40 +0000)]
Make sure that keep_dirlinks is turned off for the sender.

19 years ago- Moved --keep-dirlinks code over to flist.c.
Wayne Davison [Fri, 11 Jun 2004 07:40:51 +0000 (07:40 +0000)]
- Moved --keep-dirlinks code over to flist.c.
- Call link_stat() with its new arg (for --keep-dirlinks support).

19 years agoMade delete_one() handle a failed rmdir on a symlink when
Wayne Davison [Fri, 11 Jun 2004 07:40:48 +0000 (07:40 +0000)]
Made delete_one() handle a failed rmdir on a symlink when
--keep-dirlinks was specified.

19 years agoCall link_stat() with its new arg (for --keep-dirlinks support).
Wayne Davison [Fri, 11 Jun 2004 07:40:45 +0000 (07:40 +0000)]
Call link_stat() with its new arg (for --keep-dirlinks support).

19 years agoIn set_filesystem(), call do_stat(), not link_stat() to ensure
Wayne Davison [Fri, 11 Jun 2004 05:02:59 +0000 (05:02 +0000)]
In set_filesystem(), call do_stat(), not link_stat() to ensure
that we get the directory behind it all.

19 years agoThe mkdir code should be using do_stat(), not do_lstat() to copy
Wayne Davison [Thu, 10 Jun 2004 16:43:52 +0000 (16:43 +0000)]
The mkdir code should be using do_stat(), not do_lstat() to copy
each existing dir's mode & owner info.

19 years agoAllow the argv list the daemon uses for globbing its args to grow.
Wayne Davison [Wed, 9 Jun 2004 21:51:07 +0000 (21:51 +0000)]
Allow the argv list the daemon uses for globbing its args to grow.

19 years agoRemoved some excessive parens.
Wayne Davison [Wed, 9 Jun 2004 21:43:28 +0000 (21:43 +0000)]
Removed some excessive parens.

19 years agoMentioned a couple more bugfixes.
Wayne Davison [Wed, 9 Jun 2004 21:42:33 +0000 (21:42 +0000)]
Mentioned a couple more bugfixes.

19 years agoRestore UNUSED() macro (the prior problems that prompted me to remove
Wayne Davison [Wed, 9 Jun 2004 21:41:21 +0000 (21:41 +0000)]
Restore UNUSED() macro (the prior problems that prompted me to remove
it appear to have been a build-farm bug).

19 years agoNeeded to enclose the new symlink-warning code in an
Wayne Davison [Wed, 9 Jun 2004 19:23:56 +0000 (19:23 +0000)]
Needed to enclose the new symlink-warning code in an
"#if SUPPORT_LINKS" conditional.

19 years agoRenamed read_unbuffered() to readfd_unbuffered() so that it matches
Wayne Davison [Wed, 9 Jun 2004 03:07:50 +0000 (03:07 +0000)]
Renamed read_unbuffered() to readfd_unbuffered() so that it matches
writefd_unbuffered().

19 years ago- Made the maximum-fd computation prior to a select() use the same idiom
Wayne Davison [Tue, 8 Jun 2004 22:18:04 +0000 (22:18 +0000)]
- Made the maximum-fd computation prior to a select() use the same idiom
  in both the read and write code (also use a better variable name).
- Made the bytes-available code at the end of the select() loop use the
  same flow of control in the read and the write code.

19 years agoImproved a comment in read_msg_fd() and made the byte-reading code
Wayne Davison [Tue, 8 Jun 2004 16:23:54 +0000 (16:23 +0000)]
Improved a comment in read_msg_fd() and made the byte-reading code
in read_timeout() a little better.

19 years agoImproved rwrite() in two ways:
Wayne Davison [Mon, 7 Jun 2004 22:51:14 +0000 (22:51 +0000)]
Improved rwrite() in two ways:
- We no longer assume that the buffer is null terminated (daemon
  mode would ignore the len when logging a message).
- Errors in daemon mode are now sent to both the log and the user.

19 years agoIncrease the size of the message-receving buffer for error
Wayne Davison [Mon, 7 Jun 2004 22:47:01 +0000 (22:47 +0000)]
Increase the size of the message-receving buffer for error
messages sent from the receiver to the generator.

19 years agoChanged a few FINFO messages to FLOG.
Wayne Davison [Mon, 7 Jun 2004 22:33:01 +0000 (22:33 +0000)]
Changed a few FINFO messages to FLOG.

19 years agoGot rid of some am_daemon games in option_error().
Wayne Davison [Mon, 7 Jun 2004 22:05:22 +0000 (22:05 +0000)]
Got rid of some am_daemon games in option_error().

19 years agoUpdated some exclude information that has changed.
Wayne Davison [Mon, 7 Jun 2004 21:40:11 +0000 (21:40 +0000)]
Updated some exclude information that has changed.

19 years agoDon't report a "file vanished" error if a symlink points to nowhere
Wayne Davison [Mon, 7 Jun 2004 19:59:20 +0000 (19:59 +0000)]
Don't report a "file vanished" error if a symlink points to nowhere
and -L was specified.

19 years agoUpdated a couple things.
Wayne Davison [Sun, 6 Jun 2004 20:41:01 +0000 (20:41 +0000)]
Updated a couple things.

19 years agoTell folks to go to the bug-tracking page to report bugs.
Wayne Davison [Sun, 6 Jun 2004 20:36:56 +0000 (20:36 +0000)]
Tell folks to go to the bug-tracking page to report bugs.

19 years ago- Got rid of some useless calls to msg_list_push().
Wayne Davison [Sun, 6 Jun 2004 19:15:58 +0000 (19:15 +0000)]
- Got rid of some useless calls to msg_list_push().
- Added a couple checks to ensure that the receiver doesn't mix two
  clashing kinds of writes on the msg_fd_out pipe.
- Made sure that the read code in the receiver flushes the msg_fd_out
  pipe, if needed.

19 years agoIf the user specifies a small io_timeout value, lower select_timeout.
Wayne Davison [Sun, 6 Jun 2004 19:02:40 +0000 (19:02 +0000)]
If the user specifies a small io_timeout value, lower select_timeout.

19 years agoMake sure our select calls don't sleep for over one minute at a time,
Wayne Davison [Sun, 6 Jun 2004 19:02:09 +0000 (19:02 +0000)]
Make sure our select calls don't sleep for over one minute at a time,
even when io_timeout is a longer value (though the code in options.c
might set it to a shorter value if io_timeout is small).

19 years agoDon't use single-line "if (condition) statement;" idiom.
Wayne Davison [Sun, 6 Jun 2004 18:36:22 +0000 (18:36 +0000)]
Don't use single-line "if (condition) statement;" idiom.

19 years agoMention changes to the patches dir.
Wayne Davison [Sat, 5 Jun 2004 21:23:59 +0000 (21:23 +0000)]
Mention changes to the patches dir.

19 years agoNeatened up some of the glob-expand code and made a few other
Wayne Davison [Sat, 5 Jun 2004 20:26:56 +0000 (20:26 +0000)]
Neatened up some of the glob-expand code and made a few other
minor tweaks.

19 years agoSome superficial code tweaks.
Wayne Davison [Sat, 5 Jun 2004 19:59:03 +0000 (19:59 +0000)]
Some superficial code tweaks.

19 years agoMentioned new --keep-dirlinks option.
Wayne Davison [Sat, 5 Jun 2004 16:19:02 +0000 (16:19 +0000)]
Mentioned new --keep-dirlinks option.

19 years agoNew --keep-dirlinks option.
Wayne Davison [Sat, 5 Jun 2004 16:16:30 +0000 (16:16 +0000)]
New --keep-dirlinks option.

19 years agoMention new SSH_* vars.
Wayne Davison [Thu, 3 Jun 2004 17:20:33 +0000 (17:20 +0000)]
Mention new SSH_* vars.

19 years agoThe daemon-over-ssh code now looks for $SSH_CONNECTION and $SSH2_CLIENT
Wayne Davison [Thu, 3 Jun 2004 17:20:21 +0000 (17:20 +0000)]
The daemon-over-ssh code now looks for $SSH_CONNECTION and $SSH2_CLIENT
as well as $SSH_CLIENT to figure out the remote IP address.

19 years ago- Added older news from NEWS file.
Wayne Davison [Tue, 1 Jun 2004 21:27:52 +0000 (21:27 +0000)]
- Added older news from NEWS file.
- Added missing releases from the Partial Protocol History section.

19 years agoMoved older news to OLDNEWS.
Wayne Davison [Tue, 1 Jun 2004 21:27:12 +0000 (21:27 +0000)]
Moved older news to OLDNEWS.

19 years agoGot rid of an unneeded character pointer in send_file_entry().
Wayne Davison [Sat, 29 May 2004 21:21:17 +0000 (21:21 +0000)]
Got rid of an unneeded character pointer in send_file_entry().

19 years agoMention the --bwlimit change.
Wayne Davison [Fri, 28 May 2004 19:42:06 +0000 (19:42 +0000)]
Mention the --bwlimit change.

19 years agoImprovements to make --bwlimit work better.
Wayne Davison [Thu, 27 May 2004 22:09:31 +0000 (22:09 +0000)]
Improvements to make --bwlimit work better.

19 years agoSet a new variable, bwlimit_writemax, based on the value of the bwlimit
Wayne Davison [Thu, 27 May 2004 21:51:53 +0000 (21:51 +0000)]
Set a new variable, bwlimit_writemax, based on the value of the bwlimit
option.

19 years agoGot rid of a superfluous call to gettimeofday().
Wayne Davison [Mon, 24 May 2004 22:59:16 +0000 (22:59 +0000)]
Got rid of a superfluous call to gettimeofday().

19 years agoThe various include/exclude options are not used on the server side,
Wayne Davison [Mon, 24 May 2004 18:38:05 +0000 (18:38 +0000)]
The various include/exclude options are not used on the server side,
so if someone is trying something funny, just quit.

19 years agoMade full_fname()'s char-pointer arg const.
Wayne Davison [Mon, 24 May 2004 08:10:22 +0000 (08:10 +0000)]
Made full_fname()'s char-pointer arg const.

19 years ago- Properly quote the $excl references.
Wayne Davison [Mon, 24 May 2004 00:16:07 +0000 (00:16 +0000)]
- Properly quote the $excl references.
- Moved the creation of our .cvsignore exclude file.

19 years agoImproved the depth calculation in sanitize_path() so that it properly
Wayne Davison [Sun, 23 May 2004 23:46:56 +0000 (23:46 +0000)]
Improved the depth calculation in sanitize_path() so that it properly
handles a trailing slash, a leading slash, and an empty string.

19 years agoMoved a couple lines.
Wayne Davison [Sat, 22 May 2004 19:29:53 +0000 (19:29 +0000)]
Moved a couple lines.

19 years agoA few minor improvements to the existing items.
Wayne Davison [Sat, 22 May 2004 19:24:24 +0000 (19:24 +0000)]
A few minor improvements to the existing items.

19 years agoFixed a typo in the sending of the --checksum-seed option to the server.
Wayne Davison [Sat, 22 May 2004 06:09:22 +0000 (06:09 +0000)]
Fixed a typo in the sending of the --checksum-seed option to the server.

19 years agoFixed the comment for get_exclude_tok().
Wayne Davison [Sat, 22 May 2004 05:32:20 +0000 (05:32 +0000)]
Fixed the comment for get_exclude_tok().

19 years agoTweaked the alloc/realloc code in flist_expand().
Wayne Davison [Fri, 21 May 2004 23:22:14 +0000 (23:22 +0000)]
Tweaked the alloc/realloc code in flist_expand().

19 years agoTell rsync to preserve permissions.
Wayne Davison [Fri, 21 May 2004 10:06:09 +0000 (10:06 +0000)]
Tell rsync to preserve permissions.

19 years agoAnother new option.
Wayne Davison [Fri, 21 May 2004 10:00:21 +0000 (10:00 +0000)]
Another new option.

19 years agoGot rid of a compiler warning (which was only output by certain
Wayne Davison [Fri, 21 May 2004 09:59:49 +0000 (09:59 +0000)]
Got rid of a compiler warning (which was only output by certain
compilers).