rsync/rsync.git
22 years agoTry to fix ctype issues by always calling these functions as
Martin Pool [Thu, 11 Apr 2002 02:25:53 +0000 (02:25 +0000)]
Try to fix ctype issues by always calling these functions as

if (!isdigit(* (unsigned char *) p)) {

so that the argument is always in the range of unsigned char when
coerced to an int.

(See digit 1.)

22 years agoDoc.
Martin Pool [Thu, 11 Apr 2002 02:21:41 +0000 (02:21 +0000)]
Doc.

22 years agoDoxygen
Martin Pool [Thu, 11 Apr 2002 02:18:51 +0000 (02:18 +0000)]
Doxygen

22 years agoReceiving an @ERROR line from the server is (I think) always fatal, so
Martin Pool [Thu, 11 Apr 2002 02:16:34 +0000 (02:16 +0000)]
Receiving an @ERROR line from the server is (I think) always fatal, so
the client should exit upon receiving one and not be surprised that
the socket closes.

22 years agoFix old typo.
Martin Pool [Thu, 11 Apr 2002 02:11:50 +0000 (02:11 +0000)]
Fix old typo.

22 years agoReceiving an @ERROR line from the server is (I think) always fatal, so
Martin Pool [Thu, 11 Apr 2002 01:56:35 +0000 (01:56 +0000)]
Receiving an @ERROR line from the server is (I think) always fatal, so
the client should exit upon receiving one and not be surprised that
the socket closes.

22 years agoCorrection from Nelson Beebe: argument to functions such as isspace()
Martin Pool [Tue, 9 Apr 2002 06:32:07 +0000 (06:32 +0000)]
Correction from Nelson Beebe: argument to functions such as isspace()
must be an int, not a char.  This could cause sign-extension problems.

22 years agoDoc.
Martin Pool [Tue, 9 Apr 2002 06:18:13 +0000 (06:18 +0000)]
Doc.

Correction from Nelson Beebe: argument to functions such as isspace()
must be an int, not a char.  This could cause sign-extension problems.

22 years agoCorrection from Nelson Beebe: argument to functions such as isspace()
Martin Pool [Tue, 9 Apr 2002 06:15:13 +0000 (06:15 +0000)]
Correction from Nelson Beebe: argument to functions such as isspace()
must be an int, not a char.  This could cause sign-extension problems.

22 years agolong int and signedness fix from Nelson Beebe
Martin Pool [Tue, 9 Apr 2002 06:11:06 +0000 (06:11 +0000)]
long int and signedness fix from Nelson Beebe

22 years agolong int fix from Nelson Beebe
Martin Pool [Tue, 9 Apr 2002 06:03:50 +0000 (06:03 +0000)]
long int fix from Nelson Beebe

22 years agoFix type error.
Martin Pool [Tue, 9 Apr 2002 05:32:52 +0000 (05:32 +0000)]
Fix type error.

22 years agoAdd RERR_OK == 0
Martin Pool [Tue, 9 Apr 2002 05:29:26 +0000 (05:29 +0000)]
Add RERR_OK == 0

22 years agoDoc _exit_cleanup.
Martin Pool [Tue, 9 Apr 2002 05:26:46 +0000 (05:26 +0000)]
Doc _exit_cleanup.

22 years agoDoc start_socket_client
Martin Pool [Tue, 9 Apr 2002 05:23:07 +0000 (05:23 +0000)]
Doc start_socket_client

22 years agoDoc start_socket_client
Martin Pool [Tue, 9 Apr 2002 05:20:30 +0000 (05:20 +0000)]
Doc start_socket_client

22 years agoNotes about supplementary groups and -z.
Martin Pool [Tue, 9 Apr 2002 05:14:59 +0000 (05:14 +0000)]
Notes about supplementary groups and -z.

22 years agoDoc.
Martin Pool [Tue, 9 Apr 2002 05:07:15 +0000 (05:07 +0000)]
Doc.

22 years agoDoc.
Martin Pool [Tue, 9 Apr 2002 05:03:45 +0000 (05:03 +0000)]
Doc.

22 years agoA bit more support for IO phase names.
Martin Pool [Tue, 9 Apr 2002 05:00:03 +0000 (05:00 +0000)]
A bit more support for IO phase names.

22 years agoOK, we can now get phase messages if we fail in send_file_entry
Martin Pool [Tue, 9 Apr 2002 04:50:25 +0000 (04:50 +0000)]
OK, we can now get phase messages if we fail in send_file_entry

22 years agoDoc
Martin Pool [Tue, 9 Apr 2002 04:49:42 +0000 (04:49 +0000)]
Doc

Try symlinks with an empty target

22 years agolong int fix from Nelson Beebe
Martin Pool [Tue, 9 Apr 2002 04:49:23 +0000 (04:49 +0000)]
long int fix from Nelson Beebe

22 years agoFix typo.
Martin Pool [Tue, 9 Apr 2002 04:41:03 +0000 (04:41 +0000)]
Fix typo.

Show io phase name in error message.

22 years agoRather than a loop subtracting 1e6 to convert usecs to secs/usecs, just
Martin Pool [Tue, 9 Apr 2002 04:33:32 +0000 (04:33 +0000)]
Rather than a loop subtracting 1e6 to convert usecs to secs/usecs, just
use div/mod.

22 years agoFactor out bwlimit sleep code from writefd_unbuffered into its own function.
Martin Pool [Tue, 9 Apr 2002 04:29:46 +0000 (04:29 +0000)]
Factor out bwlimit sleep code from writefd_unbuffered into its own function.

22 years agoClarify "error writing %d bytes" message.
Martin Pool [Tue, 9 Apr 2002 04:23:18 +0000 (04:23 +0000)]
Clarify "error writing %d bytes" message.

22 years agoClean up docs.
Martin Pool [Tue, 9 Apr 2002 04:20:36 +0000 (04:20 +0000)]
Clean up docs.

22 years agoChange error message "partial transfer" to "some files could not be
Martin Pool [Mon, 8 Apr 2002 09:10:50 +0000 (09:10 +0000)]
Change error message "partial transfer" to "some files could not be
transferred".

I don't generally like changing that sort of thing, but I think this
one was a persistent source of confusion.

22 years agoNote code cleanups
Martin Pool [Mon, 8 Apr 2002 09:09:03 +0000 (09:09 +0000)]
Note code cleanups

22 years agoDoc and indent only.
Martin Pool [Mon, 8 Apr 2002 09:05:26 +0000 (09:05 +0000)]
Doc and indent only.

22 years agoRemove redundant list of options. It might be nice to summarise the
Martin Pool [Mon, 8 Apr 2002 08:58:26 +0000 (08:58 +0000)]
Remove redundant list of options.  It might be nice to summarise the
most frequently-used ones in here.

Nelson Beebe pointed out that the information about bug tracking was
out of date.

22 years agoNotes on MD4 performance. This quite unnecessarily takes up 90% of
Martin Pool [Mon, 8 Apr 2002 08:39:03 +0000 (08:39 +0000)]
Notes on MD4 performance.  This quite unnecessarily takes up 90% of
CPU on a local transfer, without achieving anything useful.

22 years agoDoc
Martin Pool [Mon, 8 Apr 2002 08:35:30 +0000 (08:35 +0000)]
Doc

22 years agoDoc file
Martin Pool [Mon, 8 Apr 2002 08:34:03 +0000 (08:34 +0000)]
Doc file

22 years agoDoc match_sums.
Martin Pool [Mon, 8 Apr 2002 08:33:13 +0000 (08:33 +0000)]
Doc match_sums.

22 years agoDoc sum_update
Martin Pool [Mon, 8 Apr 2002 08:29:04 +0000 (08:29 +0000)]
Doc sum_update

22 years agoAdd manual prototype for maintainer-mode function
Martin Pool [Mon, 8 Apr 2002 08:24:59 +0000 (08:24 +0000)]
Add manual prototype for maintainer-mode function

22 years agoDocument the perversely-named matched() function, which is called even
Martin Pool [Mon, 8 Apr 2002 08:23:50 +0000 (08:23 +0000)]
Document the perversely-named matched() function, which is called even
if we have not matched!

22 years agoWith -vv, show state of --whole-file once at the start of the transfer.
Martin Pool [Mon, 8 Apr 2002 08:06:18 +0000 (08:06 +0000)]
With -vv, show state of --whole-file once at the start of the transfer.

22 years agoDoc.
Martin Pool [Mon, 8 Apr 2002 08:02:08 +0000 (08:02 +0000)]
Doc.

22 years agoDoc rsync_panic_handler()
Martin Pool [Mon, 8 Apr 2002 07:46:34 +0000 (07:46 +0000)]
Doc rsync_panic_handler()

22 years agoClean up prototype.
Martin Pool [Mon, 8 Apr 2002 07:42:54 +0000 (07:42 +0000)]
Clean up prototype.

Drop unused variables.

22 years agoFix prototype.
Martin Pool [Mon, 8 Apr 2002 07:39:56 +0000 (07:39 +0000)]
Fix prototype.

22 years agoShow panic_action in --version.
Martin Pool [Mon, 8 Apr 2002 07:36:05 +0000 (07:36 +0000)]
Show panic_action in --version.

22 years agoAllow panic_action to be configured through environment variable RSYNC_PANIC_ACTION.
Martin Pool [Mon, 8 Apr 2002 07:34:17 +0000 (07:34 +0000)]
Allow panic_action to be configured through environment variable RSYNC_PANIC_ACTION.

22 years agot_unsafe needs asnprintf on some platforms.
Martin Pool [Mon, 8 Apr 2002 06:23:34 +0000 (06:23 +0000)]
t_unsafe needs asnprintf on some platforms.

22 years agocorrect behaviour is unclear
Martin Pool [Mon, 8 Apr 2002 06:18:03 +0000 (06:18 +0000)]
correct behaviour is unclear

22 years agoCleanup
Martin Pool [Mon, 8 Apr 2002 06:01:26 +0000 (06:01 +0000)]
Cleanup

22 years agohandle yodl and vpath
Martin Pool [Mon, 8 Apr 2002 05:38:51 +0000 (05:38 +0000)]
handle yodl and vpath

22 years agoClarify meaning of unsafe symlinks
Martin Pool [Mon, 8 Apr 2002 05:30:28 +0000 (05:30 +0000)]
Clarify meaning of unsafe symlinks

22 years agoFix copyright.
Martin Pool [Mon, 8 Apr 2002 05:28:31 +0000 (05:28 +0000)]
Fix copyright.

22 years agoAdd more test cases.
Martin Pool [Mon, 8 Apr 2002 05:22:50 +0000 (05:22 +0000)]
Add more test cases.

Turn off -x.

22 years agoDoc.
Martin Pool [Mon, 8 Apr 2002 05:21:51 +0000 (05:21 +0000)]
Doc.

22 years agoAdd more test cases.
Martin Pool [Mon, 8 Apr 2002 05:19:41 +0000 (05:19 +0000)]
Add more test cases.

22 years agoFormatting cleanup.
Martin Pool [Mon, 8 Apr 2002 04:59:34 +0000 (04:59 +0000)]
Formatting cleanup.

22 years agoDoc.
Martin Pool [Mon, 8 Apr 2002 04:48:51 +0000 (04:48 +0000)]
Doc.

22 years agoA test suite that calls unsafe_symlink() directly to see how it
Martin Pool [Mon, 8 Apr 2002 04:47:01 +0000 (04:47 +0000)]
A test suite that calls unsafe_symlink() directly to see how it
handles different strings.

22 years agoSplit code out into separate files and remove some global variables to
Martin Pool [Mon, 8 Apr 2002 04:16:46 +0000 (04:16 +0000)]
Split code out into separate files and remove some global variables to
reduce symbol dependencies between files and therefore make it easier
to write unit tests.  The diff is large, but the actual code changes
are pretty small.

22 years agoTest harness for unsafe_symlink: just passes in argv[].
Martin Pool [Mon, 8 Apr 2002 04:13:43 +0000 (04:13 +0000)]
Test harness for unsafe_symlink: just passes in argv[].

22 years agoLittle stub module that replaces functions such as rprintf called from
Martin Pool [Mon, 8 Apr 2002 04:12:31 +0000 (04:12 +0000)]
Little stub module that replaces functions such as rprintf called from
many places with a redirector to stderr.  If you just want to test a
particular routine you can link to this rather than the whole framework.

22 years agoSplit code out into separate files and remove some global variables to
Martin Pool [Mon, 8 Apr 2002 04:10:20 +0000 (04:10 +0000)]
Split code out into separate files and remove some global variables to
reduce symbol dependencies between files and therefore make it easier
to write unit tests.  The diff is large, but the actual code changes
are pretty small.

22 years agoDon't generate code for zlib and popt.
Martin Pool [Mon, 8 Apr 2002 04:00:24 +0000 (04:00 +0000)]
Don't generate code for zlib and popt.

22 years agoDoc.
Martin Pool [Mon, 8 Apr 2002 03:43:54 +0000 (03:43 +0000)]
Doc.

22 years agoDoc.
Martin Pool [Mon, 8 Apr 2002 03:38:36 +0000 (03:38 +0000)]
Doc.

22 years agoRearrange code slightly to avoid util.c depending on main.c.
Martin Pool [Mon, 8 Apr 2002 03:37:19 +0000 (03:37 +0000)]
Rearrange code slightly to avoid util.c depending on main.c.

22 years agoTune doxygen output, remove warning.
Martin Pool [Mon, 8 Apr 2002 03:13:11 +0000 (03:13 +0000)]
Tune doxygen output, remove warning.

22 years agoDocument unsafe_symlink().
Martin Pool [Mon, 8 Apr 2002 03:10:01 +0000 (03:10 +0000)]
Document unsafe_symlink().

22 years agoClean up comments for Doxygen.
Martin Pool [Mon, 8 Apr 2002 03:03:04 +0000 (03:03 +0000)]
Clean up comments for Doxygen.

22 years agoDoc.
Martin Pool [Mon, 8 Apr 2002 02:41:23 +0000 (02:41 +0000)]
Doc.

22 years agoNote on debugging daemon
Martin Pool [Mon, 8 Apr 2002 02:39:00 +0000 (02:39 +0000)]
Note on debugging daemon

22 years agoNotes about logging.
Martin Pool [Mon, 8 Apr 2002 01:59:21 +0000 (01:59 +0000)]
Notes about logging.

22 years agoNote about two small bugs.
Martin Pool [Fri, 5 Apr 2002 07:25:06 +0000 (07:25 +0000)]
Note about two small bugs.

22 years agoTest more permutations.
Martin Pool [Fri, 5 Apr 2002 07:13:01 +0000 (07:13 +0000)]
Test more permutations.

22 years agoFix filenames.
Martin Pool [Fri, 5 Apr 2002 07:04:23 +0000 (07:04 +0000)]
Fix filenames.

22 years agoGet rid of testlink after use.
Martin Pool [Fri, 5 Apr 2002 07:00:53 +0000 (07:00 +0000)]
Get rid of testlink after use.

22 years agoTest case for --copy-unsafe-links, contributed by Vladimír Michl,
Martin Pool [Fri, 5 Apr 2002 06:57:47 +0000 (06:57 +0000)]
Test case for --copy-unsafe-links, contributed by Vladimír Michl,
converted to the test suite.  Thankyou!

It fails at the moment; I don't know if that's a test bug or an rsync bug.

22 years agoDoc
Martin Pool [Fri, 5 Apr 2002 06:17:50 +0000 (06:17 +0000)]
Doc

22 years agoFix completely braindead previous patch. Thanks Jos.
Martin Pool [Wed, 3 Apr 2002 06:55:24 +0000 (06:55 +0000)]
Fix completely braindead previous patch.  Thanks Jos.

22 years agoPatch from Zoong Pham and Albert Chin to improve detection of
Martin Pool [Wed, 3 Apr 2002 06:03:27 +0000 (06:03 +0000)]
Patch from Zoong Pham and Albert Chin to improve detection of
getaddrinfo on Tru64.

Also configure.in test for mkfifo and sys/un.h, although we don't
actually use that yet.

22 years agoChange code that writes s_count to a batch file to squish it into an
Martin Pool [Wed, 3 Apr 2002 05:55:54 +0000 (05:55 +0000)]
Change code that writes s_count to a batch file to squish it into an
int first -- a stopgap for compilers that reasonably complain about a
ternary that returns either a size_t or an int.

Really we should not write an int, but rather a larger type.  Somebody
more familiar with the batch code should look at it.

22 years agoSupport Doxygen pretty-printer
Martin Pool [Wed, 3 Apr 2002 04:29:19 +0000 (04:29 +0000)]
Support Doxygen pretty-printer

22 years agoCommit patch based on one from John L. Allen to fix "forward name
Martin Pool [Wed, 3 Apr 2002 02:33:42 +0000 (02:33 +0000)]
Commit patch based on one from John L. Allen to fix "forward name
lookup failed" on AIX 4.3.3.

When doing an name->addr lookup on the client address, there's no
point including the service name, because it can't be spoofed and it
apparently causes trouble when not present in /etc/services.

22 years agoRoll over version and news.
Martin Pool [Wed, 3 Apr 2002 02:13:42 +0000 (02:13 +0000)]
Roll over version and news.

22 years agoNote about --dry-run.
Martin Pool [Wed, 3 Apr 2002 00:10:11 +0000 (00:10 +0000)]
Note about --dry-run.

22 years agoRemove warning about "run autoconf". It tends to break too much with
Martin Pool [Tue, 2 Apr 2002 02:00:29 +0000 (02:00 +0000)]
Remove warning about "run autoconf".  It tends to break too much with
CVS.

22 years agoBump to 2.5.5.
Martin Pool [Tue, 2 Apr 2002 01:41:58 +0000 (01:41 +0000)]
Bump to 2.5.5.

22 years agoIf configured with --enable-maintainer-mode, then on receipt of a
Martin Pool [Wed, 27 Mar 2002 05:10:44 +0000 (05:10 +0000)]
If configured with --enable-maintainer-mode, then on receipt of a
fatal signal rsync will try to open an xterm running gdb, similarly to
Samba's "panic action" or GNOME's bug-buddy.

22 years agoImproved network error handling. (Greg A. Woods)
Martin Pool [Wed, 27 Mar 2002 01:03:13 +0000 (01:03 +0000)]
Improved network error handling.  (Greg A. Woods)

22 years agoShell scripts should explicitly "exit 0" for portability. Thanks Jos.
Martin Pool [Tue, 26 Mar 2002 10:36:45 +0000 (10:36 +0000)]
Shell scripts should explicitly "exit 0" for portability.  Thanks Jos.

22 years agoFix suggested by Jos for hands.test. Some of the functionality
Martin Pool [Tue, 26 Mar 2002 10:28:57 +0000 (10:28 +0000)]
Fix suggested by Jos for hands.test.  Some of the functionality
previously built into Phil's test was clashing with the runtests.sh
framework.  I think one of the core problems might be that scripts
which don't explicitly "exit 0" have return codes which vary depending
on the particular shell.  (c.f. the autoconf portability guide.)

This might break the Debian test suite but I'm afraid I don't know
enough about how it works yet.  Hopefully eventually it can become
just a wrapper around our 'make check'.

22 years agoUpdated spec file from Jason Haar. Seems to mostly just change the
Martin Pool [Tue, 26 Mar 2002 05:15:09 +0000 (05:15 +0000)]
Updated spec file from Jason Haar.  Seems to mostly just change the
path for manuals, and bumps the version.

22 years agoIgnore autoconf cache. (??)
Martin Pool [Tue, 26 Mar 2002 01:27:24 +0000 (01:27 +0000)]
Ignore autoconf cache. (??)

22 years agoJos points out that test -L is still broken on Solaris. Now we try up
Martin Pool [Tue, 26 Mar 2002 01:25:47 +0000 (01:25 +0000)]
Jos points out that test -L is still broken on Solaris.  Now we try up
front to detect a command that will work properly, and use that
consistently.

Also, in test report, show setting of $preserve_scratch.

Reset version.

22 years agoBump version to 2.5.5rc1.
Martin Pool [Mon, 25 Mar 2002 23:22:08 +0000 (23:22 +0000)]
Bump version to 2.5.5rc1.

22 years agoAdd note about possible hardlink bug.
Martin Pool [Mon, 25 Mar 2002 23:09:31 +0000 (23:09 +0000)]
Add note about possible hardlink bug.

22 years agoMake the situation w.r.t. dynamically linking zlib and libpopt clear.
Martin Pool [Mon, 25 Mar 2002 09:42:36 +0000 (09:42 +0000)]
Make the situation w.r.t. dynamically linking zlib and libpopt clear.

22 years agoAdd link to Apple bug.
Martin Pool [Mon, 25 Mar 2002 07:29:43 +0000 (07:29 +0000)]
Add link to Apple bug.

22 years agoDoc
Martin Pool [Mon, 25 Mar 2002 07:07:03 +0000 (07:07 +0000)]
Doc

22 years agoHm, strange off-by-one bug.
Martin Pool [Mon, 25 Mar 2002 06:59:17 +0000 (06:59 +0000)]
Hm, strange off-by-one bug.