From: Wayne Davison <wayned@samba.org>
Date: Tue, 7 Sep 2004 20:37:36 +0000 (+0000)
Subject: W mustn't backup an inplace file in finish_transfer().
X-Git-Url: https://mattmccutchen.net/rsync/rsync.git/commitdiff_plain/e484f0cc04d7ae5a92f3737d7dbebb40e70f74ff

W mustn't backup an inplace file in finish_transfer().
---

diff --git a/rsync.c b/rsync.c
index a97357d9..47b49a6f 100644
--- a/rsync.c
+++ b/rsync.c
@@ -239,15 +239,15 @@ void finish_transfer(char *fname, char *fnametmp, struct file_struct *file,
 {
 	int ret;
 
-	if (make_backups && !make_backup(fname))
-		return;
-
 	if (inplace) {
 		if (verbose > 2)
 			rprintf(FINFO, "finishing %s\n", fname);
 		goto do_set_perms;
 	}
 
+	if (make_backups && !make_backup(fname))
+		return;
+
 	/* Change permissions before putting the file into place. */
 	set_perms(fnametmp, file, NULL, ok_to_set_time ? 0 : PERMS_SKIP_MTIME);